Peter Maydell <peter.mayd...@linaro.org> writes:
...
>> + } else {
>> + usb_mtp_queue_result(s, RES_STORE_FULL, d->trans,
>> + 0, 0, 0, 0);
>> + }
>
> Presumably one of these should be RES_OK of some kind ?
>
Ah, yes, that's a typo.
>> goto free;
>> }
>
> It does seem like a more consistent approach if we can say
> "usb_mtp_write_data() will always queue an appropriate result"
> rather than having it do that for some use cases and not others,
> so I like this suggestion.
>
Sounds good, I will send a patch.
> thanks
> -- PMM
