Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > ' > On Tue, Mar 12, 2019 at 6:44 PM Markus Armbruster wrote: >> >> Dear board code maintainers, >> >> This is a (rather late) follow-up to the last QEMU summit. Minutes[*]: >> >> * Deprecating unmaintained features (devices, targets, backends) in QEMU >> >>

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-03-18 Thread Fernando Casas Schössow
Hi all, Wanted to share one more update regarding this issue. Since running the new package with the patch from Natanael, the issue never happen again. It's been three weeks with all guests running on virtio-scsi and no issues at all so I guess we can consider this solved. Thanks again to every

[Qemu-devel] [Bug 1820247] Re: QEMU random crash caused by libspice-server

2019-03-18 Thread Christian Ehrhardt 
Hi Premysl, this has similarities to [1] which was fixed long ago. In case it is reproducible for you - as it was asked back then - it might be helpful attaching SPICE_DEBUG=1 log, using remote-viewer. And if reproducible in general also worth a quick check to try with the latest qemu version whi

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-18 Thread Markus Armbruster
Bastian Koppelmann writes: > On 3/12/19 6:36 PM, Markus Armbruster wrote: > [snip] >> >> = hw/tricore/tricore_testboard.c = >> Bastian Koppelmann (maintainer:TriCore) > > > I created a patchset for tcg tests for this board > (https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg

Re: [Qemu-devel] [PATCH 0/3] migration: add sztd compression

2019-03-18 Thread Denis Plotnikov
ping ping ping ping! On 11.03.2019 11:20, Denis Plotnikov wrote: > ping ping ping! > > On 04.03.2019 18:10, Denis Plotnikov wrote: >> ping! >> >> On 26.02.2019 16:15, Denis Plotnikov wrote: >>> zstd date compression algorithm shows better performance on data >>> compression. >>> It might be usef

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-18 Thread Markus Armbruster
Michael Walle writes: > Am 2019-03-12 18:36, schrieb Markus Armbruster: >> = hw/lm32/lm32_boards.c = >> Michael Walle (maintainer:LM32) >> >> = hw/lm32/milkymist.c = >> Michael Walle (maintainer:milkymist) >> > > Hi folks, > > I guess it is time to pull the plug. Mainly, because

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-18 Thread Gerd Hoffmann
Hi, > > A more correct model would probably be to create two i2c busses for > > that, then hook up the ddc to one of them (possibly depending on a > > config option). > > Isn't it enough to only emulate the DVI port DDC then? Well, strictly speaking the radion has 4 i2c busses and the most cor

Re: [Qemu-devel] [PATCH v2 08/12] pc-bios: add edk2 firmware binaries and variable store templates

2019-03-18 Thread Gerd Hoffmann
Hi, > > But that point is moot if we can get fully automated firmware builds > > going, by using docker and a distro with cross compilers ... > > The main problem would be that we target many different operating > systems, but only Linux would be able to run the docker builds. > So people on Fr

Re: [Qemu-devel] [RFC PATCH] spapr/irq: force XICS interrupt mode on non P9 machines

2019-03-18 Thread Greg Kurz
On Mon, 18 Mar 2019 07:27:59 +0100 Cédric Le Goater wrote: > On 3/18/19 2:52 AM, David Gibson wrote: > > On Sun, Mar 17, 2019 at 09:33:42PM +0100, Cédric Le Goater wrote: > >> There is no need to propose the 'dual' interrupt mode interrupt device > >> on POWER7/8 machines and the XIVE mode will

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Paolo Bonzini
On 15/03/19 21:05, Alistair Francis wrote: > Set msi_nonbroken as true for the PLIC. > > According to the comment located here: > https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=HEAD#l38 > the msi_nonbroken variable should be set to true even if

Re: [Qemu-devel] [PATCH v5 00/20] Acceptance Tests: target architecture support

2019-03-18 Thread Markus Armbruster
I understand these tests could serve as "meaningful boot tests" in the sense I used in "Maintainers, please tell us how to boot your machines!"[*] Which machine types do they cover? [*] Message-ID: <87d0mwatbu@dusky.pond.sub.org> https://lists.nongnu.org/archive/html/qemu-devel/2019-03/msg0

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-18 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 12 Mar 2019 at 17:36, Markus Armbruster wrote: >> I gathered the machine types, mapped them to source files, which I fed >> to get_maintainer.pl. Results are appended. If you're cc'ed, >> MAINTAINERS fingers you for at least one machine type's source file. >> Pl

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Markus Armbruster
Alistair Francis writes: > Set msi_nonbroken as true for the PLIC. > > According to the comment located here: > https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=HEAD#l38 > the msi_nonbroken variable should be set to true even if they don't > sup

Re: [Qemu-devel] [PATCH 13/14] hw/hppa/Kconfig: Dino board requires e1000 network card

2019-03-18 Thread Paolo Bonzini
On 16/03/19 23:41, Philippe Mathieu-Daudé wrote: > On 3/16/19 10:50 PM, Paolo Bonzini wrote: >>> This fixes when configuring with --without-default-devices: >>> >>> $ qemu-system-hppa >>> qemu-system-hppa: Unsupported NIC model: e1000 >> >> This is intended. --without-default-devices does not

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-18 Thread Michael Walle
[resend because my mobile client messed up the message and gmail rejected it] Am 2019-03-18 09:15, schrieb Markus Armbruster: Michael Walle writes: Am 2019-03-12 18:36, schrieb Markus Armbruster: = hw/lm32/lm32_boards.c = Michael Walle (maintainer:LM32) = hw/lm32/milkymist.c =

[Qemu-devel] [PATCH v15 18/24] replay: describe reverse debugging in docs/replay.txt

2019-03-18 Thread Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt index ce97c3f72f..47b4f2d9f

[Qemu-devel] [PATCH v15 20/24] replay: document development rules

2019-03-18 Thread Pavel Dovgalyuk
This patch introduces docs/devel/replay.txt which describes the rules that should be followed to make virtual devices usable in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v9: fixed external virtual clock description (reported by Artem Pisarenko) --- docs/devel/replay.txt | 46

[Qemu-devel] [PATCH v15 24/24] icount: clean up cpu_can_io before jumping to the next block

2019-03-18 Thread Pavel Dovgalyuk
Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the next block. This patch res

[Qemu-devel] [PATCH v15 17/24] gdbstub: add reverse continue support in replay mode

2019-03-18 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were hit

[Qemu-devel] [PATCH v15 21/24] util/qemu-timer: refactor deadline calculation for external timers

2019-03-18 Thread Pavel Dovgalyuk
icount-based record/replay uses qemu_clock_deadline_ns_all to measure the period until vCPU may be interrupted. This function takes in account the virtual timers, because they belong to the virtual devices that may generate interrupt request or affect the virtual machine state. However, there are a

[Qemu-devel] [PATCH v15 19/24] replay: add BH oneshot event for block layer

2019-03-18 Thread Pavel Dovgalyuk
Replay is capable of recording normal BH events, but sometimes there are single use callbacks scheduled with aio_bh_schedule_oneshot function. This patch enables recording and replaying such callbacks. Block layer uses these events for calling the completion function. Replaying these calls makes th

[Qemu-devel] [PATCH v15 23/24] replay: rename step-related variables and functions

2019-03-18 Thread Pavel Dovgalyuk
This patch renames replay_get_current_step() and related variables to make these names consistent with hmp/qmp commands. Signed-off-by: Pavel Dovgalyuk --- blockdev.c|2 +- include/sysemu/replay.h |2 +- migration/savevm.c|2 +- replay/replay-debugging.c |

[Qemu-devel] [PATCH v15 16/24] gdbstub: add reverse step support in replay mode

2019-03-18 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Palmer Dabbelt
On Mon, 18 Mar 2019 01:39:46 PDT (-0700), pbonz...@redhat.com wrote: On 15/03/19 21:05, Alistair Francis wrote: Set msi_nonbroken as true for the PLIC. According to the comment located here: https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=HEA

[Qemu-devel] [PATCH v15 22/24] replay: fix replay shutdown

2019-03-18 Thread Pavel Dovgalyuk
This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call. Signed-off-by: Pavel Dov

[Qemu-devel] [PATCH v15 12/24] replay: introduce breakpoint at the specified step

2019-03-18 Thread Pavel Dovgalyuk
This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - number of instructions execu

[Qemu-devel] [PATCH v15 13/24] replay: implement replay-seek command

2019-03-18 Thread Pavel Dovgalyuk
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by: Markus Armbruster --

[Qemu-devel] [PATCH v15 15/24] replay: flush rr queue before loading the vmstate

2019-03-18 Thread Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing t

[Qemu-devel] [PATCH v15 01/24] replay: add missing fix for internal function

2019-03-18 Thread Pavel Dovgalyuk
From: pbonz...@redhat.com This is a fix which was missed by patch 74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step parameter to the replay_advance_current_step function. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c |2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH v15 09/24] replay: provide an accessor for rr filename

2019-03-18 Thread Pavel Dovgalyuk
This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/replay.h |2 ++ replay/replay.c

[Qemu-devel] [PATCH v15 07/24] qcow2: introduce icount field for snapshots

2019-03-18 Thread Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v2: - documented format changes in docs/interop/qcow2.txt (suggested by Eric Blake) v10:

[Qemu-devel] [PATCH v15 14/24] replay: refine replay-time module

2019-03-18 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/replay/replay-time.c b/replay/replay-time.c index 0df1693337

[Qemu-devel] [PATCH v15 03/24] replay: disable default snapshot for record/replay

2019-03-18 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- vl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletio

[Qemu-devel] [PATCH v15 10/24] qapi: introduce replay.json for record/replay-related stuff

2019-03-18 Thread Pavel Dovgalyuk
This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster -- v10: - minor changes v13: - rebased to the new QAPI files --- MAINTAINERS |1 + include/sysemu/re

[Qemu-devel] [PATCH v15 11/24] replay: introduce info hmp/qmp command

2019-03-18 Thread Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the replay_seek/replay_break

[Qemu-devel] [PATCH v15 08/24] migration: introduce icount field for snapshots

2019-03-18 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (introduced in one of the

[Qemu-devel] [PATCH v15 02/24] block: implement bdrv_snapshot_goto for blkreplay

2019-03-18 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- block/blkreplay.c |8

Re: [Qemu-devel] [PATCH] docs: reST-ify vhost-user documentation

2019-03-18 Thread Jens Freimann
On Fri, Mar 15, 2019 at 07:07:35PM +0100, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau --- MAINTAINERS |2 +- docs/interop/index.rst |2 +- docs/interop/vhost-user.rst | 1351 +++ docs/interop/vhost-user.txt | 1219 --

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Andrea Bolognani
On Mon, 2019-03-18 at 09:39 +0100, Paolo Bonzini wrote: > On 15/03/19 21:05, Alistair Francis wrote: > > Set msi_nonbroken as true for the PLIC. > > > > According to the comment located here: > > https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=H

[Qemu-devel] [PATCH v15 06/24] replay: finish record/replay before closing the disks

2019-03-18 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |2 ++ vl.c|

Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-18 Thread Christian Borntraeger
On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: > Hi Marcel, > > On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: >> Configuring QEMU with: >> configure --cc=clang --target-list=s390x-softmmu >> And compiling it using a 32 bit machine leads to: > > Because there sizeof(ram_addr_t) = sizeof(ui

[Qemu-devel] [PATCH v15 05/24] replay: don't drain/flush bdrv queue while RR is working

2019-03-18 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode. This

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Peter Maydell
On Mon, 18 Mar 2019 at 08:59, Markus Armbruster wrote: > > Alistair Francis writes: > > > Set msi_nonbroken as true for the PLIC. > > > > According to the comment located here: > > https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=HEAD#l38 > > th

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Andrea Bolognani
On Fri, 2019-03-15 at 20:05 +, Alistair Francis wrote: > Set msi_nonbroken as true for the PLIC. > > According to the comment located here: > https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=HEAD#l38 > the msi_nonbroken variable should be set

[Qemu-devel] [PATCH v15 04/24] replay: update docs for record/replay with block devices

2019-03-18 Thread Pavel Dovgalyuk
This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt b/docs/replay.txt index ee6aee9861..c

[Qemu-devel] [PATCH v15 00/24] Fix record/replay and add reverse debugging

2019-03-18 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-18 Thread Markus Armbruster
Michael Walle writes: > [resend because my mobile client messed up the message and gmail > rejected it] > > Am 2019-03-18 09:15, schrieb Markus Armbruster: >> Michael Walle writes: >> >>> Am 2019-03-12 18:36, schrieb Markus Armbruster: = hw/lm32/lm32_boards.c = Michael Walle (

Re: [Qemu-devel] [PATCHv2] curses ui: always initialize all curses_line fields

2019-03-18 Thread Gerd Hoffmann
On Fri, Mar 15, 2019 at 02:09:32PM +0100, Samuel Thibault wrote: > cchar_t can contain not only attr and chars fields, but also ext_color. > Initialize the whole structure to zero instead of enumerating fields. > > Spotted by Coverity: CID 1399711 > > Signed-off-by: Samuel Thibault Added to UI

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread David Abdurachmanov
On Mon, Mar 18, 2019 at 10:22 AM Andrea Bolognani wrote: > > On Mon, 2019-03-18 at 09:39 +0100, Paolo Bonzini wrote: > > On 15/03/19 21:05, Alistair Francis wrote: > > > Set msi_nonbroken as true for the PLIC. > > > > > > According to the comment located here: > > > https://git.qemu.org/?p=qemu.gi

Re: [Qemu-devel] Combining synchronous and asynchronous IO

2019-03-18 Thread Kevin Wolf
Am 17.03.2019 um 06:58 hat Fam Zheng geschrieben: > > On Mar 15, 2019, at 01:31, Sergio Lopez wrote: > > > > Hi, > > > > Our current AIO path does a great job at unloading the work from the VM, > > and combined with IOThreads provides a good performance in most > > scenarios. But it also comes w

Re: [Qemu-devel] [PATCH v2] vnc: fix unalignment access in tight_pack24

2019-03-18 Thread Gerd Hoffmann
On Mon, Mar 18, 2019 at 09:04:42AM +0800, Li Qiang wrote: > When adding '-fsanitize=undefined' in compiling configuration > and connect VM with vnc, it reports following error: > > ui/vnc-enc-tight.c:910:13: runtime error: load of > misaligned address 0x621000466513 for type 'uint32_t', > which re

Re: [Qemu-devel] [PATCHv2] curses ui: add missing iconv_close calls

2019-03-18 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 06:25:24PM +0100, Samuel Thibault wrote: > The iconv_t are opened but never closed. > > Spotted by Coverity: CID 1399708 > Spotted by Coverity: CID 1399709 > Spotted by Coverity: CID 1399713 > > Signed-off-by: Samuel Thibault > --- > > Change since previous version: clos

[Qemu-devel] [PATCH] Re-evaluate SVE vector length everytime ADDVL/RDVL is called

2019-03-18 Thread Amir Charif
In system emulation mode, the kernel may internally use 16-byte vectors. If this size is saved in the DisasContext before entering a userspace app that uses higher SVE sizes, the wrong size may be allocated on the stack resulting in corruption (segfaults in user space). This fix evaluates the vecto

Re: [Qemu-devel] Set up github repo for pmon sources

2019-03-18 Thread Daniel P . Berrangé
On Sat, Mar 16, 2019 at 10:39:49PM +0100, BALATON Zoltan wrote: > On Sat, 16 Mar 2019, Eric Blake wrote: > > On 3/15/19 9:06 PM, Andrew Randrianasulu wrote: > > > https://github.com/Randrianasulu/pmon/commits/2014 > > > > > > hopefully it will stay this way. > > > > > > Anyone know what license I

Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-18 Thread Marcel Apfelbaum
Hi Christian, On 3/18/19 11:27 AM, Christian Borntraeger wrote: On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: Hi Marcel, On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: Configuring QEMU with: configure --cc=clang --target-list=s390x-softmmu And compiling it using a 32 bit machine leads

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-18 Thread BALATON Zoltan
Hello, On Mon, 18 Mar 2019, Gerd Hoffmann wrote: A more correct model would probably be to create two i2c busses for that, then hook up the ddc to one of them (possibly depending on a config option). Isn't it enough to only emulate the DVI port DDC then? Well, strictly speaking the radion ha

Re: [Qemu-devel] [PATCH 1/2] tests: refactor file monitor test to make it more understandable

2019-03-18 Thread Marc-André Lureau
Hi On Thu, Mar 14, 2019 at 4:26 PM Daniel P. Berrangé wrote: > > The current file monitor unit tests are too clever for their own good > making it hard to understand the desired output. > > Instead of trying to infer the expected events, explicitly list the > events we expect in the operation seq

Re: [Qemu-devel] [PULL] A Single RISC-V Patch for 4.0-rc0

2019-03-18 Thread Peter Maydell
On Mon, 18 Mar 2019 at 05:28, Palmer Dabbelt wrote: > > The following changes since commit d4e65539e570d5872003710b5a1064489911d33d: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20190316' into > staging (2019-03-17 14:10:52 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PULL 2/4] usb-mtp: fix some usb_mtp_write_data return paths

2019-03-18 Thread Peter Maydell
On Fri, 15 Mar 2019 at 15:49, Bandan Das wrote: > usb_mtp_write_metadata() handles the sendobjectinfo phase where the > initiator sends the metadata associated with the incoming object. > For a file, the name and the size is sent and once the responder sends > back OK, the initiator starts the sen

[Qemu-devel] [PULL 4/5] keymaps: use nodeadkeys variant for de and fr

2019-03-18 Thread Gerd Hoffmann
The reverse keymap code can't handle dead keys. So use the nodeadkeys variant of the keyboard layout for the german and french maps. Signed-off-by: Gerd Hoffmann Message-id: 20190315110248.29208-2-kra...@redhat.com --- pc-bios/keymaps/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[Qemu-devel] [PULL 3/5] curses ui: add missing iconv_close calls

2019-03-18 Thread Gerd Hoffmann
From: Samuel Thibault The iconv_t are opened but never closed. Spotted by Coverity: CID 1399708 Spotted by Coverity: CID 1399709 Spotted by Coverity: CID 1399713 Signed-off-by: Samuel Thibault Message-Id: <20190314172524.9290-1-samuel.thiba...@ens-lyon.org> Reviewed-by: Peter Maydell Signed-o

[Qemu-devel] [PULL 2/5] curses ui: always initialize all curses_line fields

2019-03-18 Thread Gerd Hoffmann
From: Samuel Thibault cchar_t can contain not only attr and chars fields, but also ext_color. Initialize the whole structure to zero instead of enumerating fields. Spotted by Coverity: CID 1399711 Signed-off-by: Samuel Thibault Message-Id: <20190315130932.26094-1-samuel.thiba...@ens-lyon.org>

[Qemu-devel] [PULL 1/5] vnc: fix unalignment access in tight_pack24

2019-03-18 Thread Gerd Hoffmann
From: Li Qiang When adding '-fsanitize=undefined' in compiling configuration and connect VM with vnc, it reports following error: ui/vnc-enc-tight.c:910:13: runtime error: load of misaligned address 0x621000466513 for type 'uint32_t', which requires 4 byte alignment This patch fix this issue.

[Qemu-devel] [PULL 0/5] Ui 20190318 patches

2019-03-18 Thread Gerd Hoffmann
The following changes since commit d4e65539e570d5872003710b5a1064489911d33d: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20190316' into staging (2019-03-17 14:10:52 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20190318-pull-reques

[Qemu-devel] [PULL 5/5] keymaps: regenerate keymaps

2019-03-18 Thread Gerd Hoffmann
Pick up the config updates. Also add a few keys to the maps which got a QKeyCode assigned since the last time we generated the maps (Hiragana_Katakana, Muhenkan). Sync with xkbcommon updates. Signed-off-by: Gerd Hoffmann Message-id: 20190315110248.29208-3-kra...@redhat.com --- pc-bios/keymaps/

[Qemu-devel] [PATCH for-4.0] include/qemu/bswap.h: Use __builtin_memcpy() in accessor functions

2019-03-18 Thread Peter Maydell
In the accessor functions ld*_he_p() and st*_he_p() we use memcpy() to perform a load or store to a pointer which might not be aligned for the size of the type. We rely on the compiler to optimize this memcpy() into an efficient load or store instruction where possible. This is required for good pe

Re: [Qemu-devel] [PATCH 1/2] Fix absolute input device grabbing issues on Mojave

2019-03-18 Thread Peter Maydell
On Fri, 15 Mar 2019 at 09:37, Chen Zhang wrote: > > > Signed-off-by: Chen Zhang Hi; thanks for this patch. I think a commit message for the patch would be useful, containing the rationale for why we make the change. I know you put that in the cover letter, but that won't get into the git commit

Re: [Qemu-devel] [PATCH 2/2] ui/cocoa: fix grabbing issue in fullscreen mode

2019-03-18 Thread Peter Maydell
On Fri, 15 Mar 2019 at 09:37, Chen Zhang wrote: > > Signed-off-by: Chen Zhang Again, it would be nice to see a commit message here that explained what was being changed and why. If you take my suggestion from my review of patch 1 this is no longer relevant, but: > @@ -881,7 +900,7 @@ QemuCocoa

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 11:50:54AM +0100, Markus Armbruster wrote: > We have two separate type trees, object types rooted at TYPE_OBJECT, and > interface types at TYPE_INTERFACE. > > Object types are fore defining ultimately concrete types, i.e. any > concrete type is a descendant of TYPE_OBJECT.

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Peter Maydell
On Mon, 18 Mar 2019 at 11:54, Daniel P. Berrangé wrote: > > TYPE_ACPI_DEVICE_IF > > TYPE_ARM_LINUX_BOOT_IF > > TYPE_TEST_IF > > TYPE_TPM_IF > > > > TYPE_IDAU_INTERFACE > > TYPE_IPMI_INTERFACE > > TYPE_PNV_XSCOM_INTERFACE > > I'm not so bothered by these, though they are

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Daniel P . Berrangé
On Mon, Mar 18, 2019 at 11:59:43AM +, Peter Maydell wrote: > On Mon, 18 Mar 2019 at 11:54, Daniel P. Berrangé wrote: > > > TYPE_ACPI_DEVICE_IF > > > TYPE_ARM_LINUX_BOOT_IF > > > TYPE_TEST_IF > > > TYPE_TPM_IF > > > > > > TYPE_IDAU_INTERFACE > > > TYPE_IPMI_INTERFACE > >

Re: [Qemu-devel] [PATCH V4 0/3] Fixes for PulseAudio driver

2019-03-18 Thread Gerd Hoffmann
On Fri, Mar 15, 2019 at 09:46:50AM +0100, Martin Schrodt wrote: > Version 2 of the series added proper commit messages > and fixed a typo. > > Version 3 fixes coding style problems > > Version 4 reintroduces the check, whether PA support adjusting > latency, and sets the default buffer_length to

[Qemu-devel] [PULL 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-18 Thread Gerd Hoffmann
From: Martin Schrodt Audiodev configuration allows to set the length of the buffered data. The setting was ignored and a constant value used instead. This patch makes the code apply the setting properly, and uses the previous default if nothing is supplied. Signed-off-by: Martin Schrodt Message

[Qemu-devel] [PULL 0/3] Audio 20190318 patches

2019-03-18 Thread Gerd Hoffmann
The following changes since commit d4e65539e570d5872003710b5a1064489911d33d: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20190316' into staging (2019-03-17 14:10:52 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20190318-pull-re

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-18 Thread Joel Stanley
On Tue, 12 Mar 2019 at 17:36, Markus Armbruster wrote: I regularly use the powernv and aspeed machines, but others have contributed their command lines already. > = hw/arm/microbit.c = > Joel Stanley (maintainer:NRF51) > Peter Maydell (maintainer:NRF51) > qemu-...@nongnu.org (o

[Qemu-devel] [PULL 3/3] audio/paaudio: fix microphone input being unusable

2019-03-18 Thread Gerd Hoffmann
From: Martin Schrodt The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Sig

[Qemu-devel] [PULL 2/3] audio/paaudio: prolong and make latency configurable

2019-03-18 Thread Gerd Hoffmann
From: Martin Schrodt The latency of a connection to the PulseAudio server is determined by the tlength parameter. This was hardcoded to 10ms, which is a bit too tight on my machine, causing audio on host and guest to malfunction. A setting of 15ms works fine here. To allow tweaking, I also made t

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 18 Mar 2019 at 08:59, Markus Armbruster wrote: >> >> Alistair Francis writes: >> >> > Set msi_nonbroken as true for the PLIC. >> > >> > According to the comment located here: >> > https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17

Re: [Qemu-devel] Combining synchronous and asynchronous IO

2019-03-18 Thread Sergio Lopez
Kevin Wolf writes: > Am 15.03.2019 um 16:33 hat Sergio Lopez geschrieben: >> >> Stefan Hajnoczi writes: >> >> > On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote: >> >> Our current AIO path does a great job at unloading the work from the VM, >> >> and combined with IOThreads provide

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-18 Thread Igor Mammedov
On Fri, 15 Mar 2019 08:44:32 +0800 Wei Yang wrote: in subject: s/extract/generalize/ > arm and i386 has almost the same function acpi_add_rom_blob(), except > giving different FWCfgCallback function. > > This patch extract acpi_add_rom_blob() to utils.c by passing s/extract/moves/

Re: [Qemu-devel] [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support

2019-03-18 Thread Igor Mammedov
On Fri, 8 Mar 2019 11:42:16 + Shameer Kolothum wrote: > From: Samuel Ortiz > > The ACPI Generic Event Device (GED) is a hardware-reduced specific > device that handles all platform events, including the hotplug ones. > This patch generate the AML code that defines GEDs. > Platforms need to

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-18 Thread Peter Maydell
On Mon, 18 Mar 2019 at 12:34, gengdongjiu wrote: > > > > On 2019/3/16 4:11, Philippe Mathieu-Daudé wrote: > >> Signed-off-by: Peter Maydell > >> --- > >> Should we try to put this in for rc1? Not sure... Testing > >> definitely appreciated. > > You might include it for rc1 and we still have rc2/r

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-18 Thread Gerd Hoffmann
Hi, > Does it work with the latest patch for you? No (testing with radeonfb.ko). > you could share those. It may also need changes to vgabios but I'm not > familiar with that so I hope you can help with that. I've found the r128 X > driver needs a VBE BIOS function to access DDC as mentioned i

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 12, 2019 at 11:50:54AM +0100, Markus Armbruster wrote: >> We have two separate type trees, object types rooted at TYPE_OBJECT, and >> interface types at TYPE_INTERFACE. >> >> Object types are fore defining ultimately concrete types, i.e. any >> concrete t

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-18 Thread gengdongjiu
On 2019/3/16 4:11, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Peter Maydell >> --- >> Should we try to put this in for rc1? Not sure... Testing >> definitely appreciated. > You might include it for rc1 and we still have rc2/rc3 to revert it. why we still have rc2/rc3 to revert it? If we c

Re: [Qemu-devel] [PATCH for-4.1 v2 02/13] tcg: Return bool success from tcg_out_mov

2019-03-18 Thread Richard Henderson
On 3/17/19 8:03 PM, Aleksandar Markovic wrote: > This patch merely changes the interface, aborting on all failures, > of which there are currently none. > > > Why is this necessary? See patch 6, in which tcg/ppc tcg_out_mov returns false for moves between integer and vector registers.

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Mar 18, 2019 at 11:59:43AM +, Peter Maydell wrote: >> On Mon, 18 Mar 2019 at 11:54, Daniel P. Berrangé wrote: >> > > TYPE_ACPI_DEVICE_IF >> > > TYPE_ARM_LINUX_BOOT_IF >> > > TYPE_TEST_IF >> > > TYPE_TPM_IF >> > > >> > > TYPE_IDAU_INTER

Re: [Qemu-devel] [PATCH for-4.0] include/qemu/bswap.h: Use __builtin_memcpy() in accessor functions

2019-03-18 Thread Richard Henderson
On 3/18/19 4:29 AM, Peter Maydell wrote: > In the meantime, switch to using __builtin_memcpy() in the > bswap.h accessor functions. This will make us robust against things > like this fortify library in the short term. In the longer term > it will mean that we don't end up with these functions bein

[Qemu-devel] [PULL 2/3] seabios: turn off CONFIG_ATA_DMA

2019-03-18 Thread Gerd Hoffmann
There have been regressions reported, when booting FreeDOS. https://www.mail-archive.com/qemu-devel@nongnu.org/msg593254.html Signed-off-by: Gerd Hoffmann --- roms/config.seabios-128k | 2 +- roms/config.seabios-256k | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/roms/con

[Qemu-devel] [PULL 1/3] seabios: update submodule to 1.12.1

2019-03-18 Thread Gerd Hoffmann
git shortlog rel-1.12.0..rel-1.12.1 === Kevin O'Connor (1): usb-ehci: Clear pipe token on pipe reallocate Stephen Douthit (1): tpm: Check for TPM related ACPI tables before attempting hw probe Signed-off-by: Gerd Hoffmann --- roms/seabios | 2 +- 1 f

Re: [Qemu-devel] [PULL 0/3] Audio 20190318 patches

2019-03-18 Thread Peter Maydell
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/audio-20190318-pull-request > > for you to fetch changes up to ade103011c6476353fbc2a707aa6ef1f1aa9e2fb: > > audio/paaudio: fix microphone i

[Qemu-devel] [PULL 3/3] seabios: update binaries to 1.12.1

2019-03-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- pc-bios/bios-256k.bin | Bin 262144 -> 262144 bytes pc-bios/bios.bin | Bin 131072 -> 131072 bytes pc-bios/vgabios-bochs-display.bin | Bin 27648 -> 27648 bytes pc-bios/vgabios-cirrus.bin| Bin 38400 -> 38400 bytes pc-bios/vgab

[Qemu-devel] [PULL 0/3] Seabios 1.12.1 20190318 patches

2019-03-18 Thread Gerd Hoffmann
The following changes since commit d4e65539e570d5872003710b5a1064489911d33d: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20190316' into staging (2019-03-17 14:10:52 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/seabios-1.12.1-201

Re: [Qemu-devel] [PULL 0/5] Ui 20190318 patches

2019-03-18 Thread Peter Maydell
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190318-pull-request > > for you to fetch changes up to 0a87602268884f977ba67df8b51735bf5ac141ec: > > keymaps: regenerate keymaps (2019-03-18 12:06:04 +0100) > > --

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Daniel P . Berrangé
On Mon, Mar 18, 2019 at 01:53:38PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > >> For instance if I > >> see a PROP_LINK that wants a TYPE_IDAU_INTERFACE I know > >> I need to implement an interface on some suitable object, > >> whereas if

Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Peter Maydell
On Mon, 18 Mar 2019 at 13:17, Daniel P. Berrangé wrote: > On Mon, Mar 18, 2019 at 01:53:38PM +0100, Markus Armbruster wrote: > > In case teaching it to checkpatch turns out to be too onerous: perhaps > > certain things would be easier to check in a program that looks at > > sources rather than pat

Re: [Qemu-devel] [PATCH v8 3/6] ui: add keycodemapdb repository as a GIT submodule

2019-03-18 Thread Daniel P . Berrangé
On Fri, Mar 15, 2019 at 06:35:59PM +, Peter Maydell wrote: > On Fri, 29 Sep 2017 at 11:12, Daniel P. Berrange wrote: > > > > The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a > > data file mapping between all the different scancode/keycode/keysym > > sets that are known, and a to

[Qemu-devel] [PULL 1/3] ati-vga: fix tracing

2019-03-18 Thread Gerd Hoffmann
HWADDR_PRIx can't be used in tracing, use PRIx64 instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Message-id: 20190312081143.24850-1-kra...@redhat.com --- hw/display/trace-eve

[Qemu-devel] [PULL 2/3] virtio-gpu: delay virglrenderer reset when blocked.

2019-03-18 Thread Gerd Hoffmann
If renderer_blocked is set do not call virtio_gpu_virgl_reset(). Instead set a flag indicating that virglrenderer needs a reset. When renderer_blocked gets cleared do the actual reset call. Without this we can trigger an assert in spice due to calling spice_qxl_gl_scanout() while another operation

[Qemu-devel] [PULL 0/3] Vga 20190318 patches

2019-03-18 Thread Gerd Hoffmann
The following changes since commit d4e65539e570d5872003710b5a1064489911d33d: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20190316' into staging (2019-03-17 14:10:52 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20190318-pull-reques

  1   2   3   >