From: Samuel Thibault <samuel.thiba...@ens-lyon.org> cchar_t can contain not only attr and chars fields, but also ext_color. Initialize the whole structure to zero instead of enumerating fields.
Spotted by Coverity: CID 1399711 Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Message-Id: <20190315130932.26094-1-samuel.thiba...@ens-lyon.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- ui/curses.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 3a7e8649f3de..4ef9b9c677ce 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -75,9 +75,9 @@ static void curses_update(DisplayChangeListener *dcl, if (vga_to_curses[ch].chars[0]) { curses_line[x] = vga_to_curses[ch]; } else { - curses_line[x].chars[0] = ch; - curses_line[x].chars[1] = 0; - curses_line[x].attr = 0; + curses_line[x] = (cchar_t) { + .chars[0] = ch, + }; } curses_line[x].attr |= at; } -- 2.18.1