Re: [Qemu-devel] [PATCH] hw/arm/acpi: enable SHPC native hot plug

2019-03-02 Thread Heyi Guo
On 2019/3/1 23:49, Michael S. Tsirkin wrote: On Fri, Mar 01, 2019 at 03:33:11PM +0100, Igor Mammedov wrote: On Fri, 1 Mar 2019 09:12:33 -0500 "Michael S. Tsirkin" wrote: On Fri, Mar 01, 2019 at 10:04:38PM +0800, Heyi Guo wrote: On 2019/3/1 21:47, Michael S. Tsirkin wrote: On Fri, Mar 01

Re: [Qemu-devel] [PULL 13/76] pvh: Add x86/HVM direct boot ABI header file

2019-03-02 Thread Stefano Garzarella
On Fri, Mar 01, 2019 at 05:56:36PM +, Alex Bennée wrote: > > Stefano Garzarella writes: > > > On Fri, Mar 01, 2019 at 04:53:57PM +, Alex Bennée wrote: > >> > >> Paolo Bonzini writes: > >> > >> > From: Liam Merwick > >> > > >> > The x86/HVM direct boot ABI permits Qemu to be able to boo

Re: [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-03-02 Thread Wei Yang
On Fri, Mar 01, 2019 at 10:55:22AM +0100, Stefano Garzarella wrote: >On Fri, Mar 01, 2019 at 10:01:46AM +0800, Wei Yang wrote: >> We didn't specify the indent rule for multiline code here, which may >> mislead users. And in current code, the code use various styles. >> >> Add this rule in CODING_S

[Qemu-devel] Forward-porting RTC device for eppc500 ?

2019-03-02 Thread Andrew Randrianasulu
Hello, all! I stumbled upon this email from 2015 (trying to understand why my emulated ppce500 machine failed to set clock correctly: https://lists.gnu.org/archive/html/qemu-devel/2015-01/msg02642.html Now, after some quite blind trial-and-error I applied ('forward-ported') this patch to qemu

Re: [Qemu-devel] [PATCH] qom: remove type_initialize() in object_new_with_type()

2019-03-02 Thread Wei Yang
On Fri, Mar 01, 2019 at 10:33:46AM +0100, Igor Mammedov wrote: >On Fri, 1 Mar 2019 15:44:48 +0800 >Wei Yang wrote: > >> Here is the abstraction of current call flow of object_new_with_type() >> >> object_initialize_with_type >> type_initialize >> object_initialize_with_type >>

[Qemu-devel] qemu bluetooth support

2019-03-02 Thread Daryl Oliver
Hello there I don't know if this is till valid but I thought I should mention my use cases for the bluetooth option in qemu. Use case would be using Bluetooth controllers for gaming on kvm qemu since I don't know if kvm would be able to use my hosts Bluetooth chip or emulate one. since I manily us

Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?

2019-03-02 Thread BALATON Zoltan
Hello, On Sat, 2 Mar 2019, Andrew Randrianasulu wrote: Hello, all! I stumbled upon this email from 2015 (trying to understand why my emulated ppce500 machine failed to set clock correctly: https://lists.gnu.org/archive/html/qemu-devel/2015-01/msg02642.html Now, after some quite blind trial-an

Re: [Qemu-devel] [PATCH] slirp: fix big/little endian conversion in ident protocol

2019-03-02 Thread Philippe Mathieu-Daudé
Hi Samuel, On 3/2/19 3:25 AM, Samuel Thibault wrote: > Signed-off-by: Samuel Thibault > --- I got: Applying: slirp: fix big/little endian conversion in ident protocol error: patch failed: slirp/tcp_subr.c:660 error: slirp/tcp_subr.c: patch does not apply Then noticed another slirp patch, appli

Re: [Qemu-devel] [PATCH] slirp: fix big/little endian conversion in ident protocol

2019-03-02 Thread Samuel Thibault
Philippe Mathieu-Daudé, le sam. 02 mars 2019 18:31:56 +0100, a ecrit: > On 3/2/19 3:25 AM, Samuel Thibault wrote: > > Signed-off-by: Samuel Thibault > > --- > > I got: > > Applying: slirp: fix big/little endian conversion in ident protocol > error: patch failed: slirp/tcp_subr.c:660 > error: sli

Re: [Qemu-devel] [PATCH] slirp: check sscanf result when emulating ident

2019-03-02 Thread Philippe Mathieu-Daudé
Hi William, Samuel, On 3/1/19 10:45 PM, William Bowling wrote: > When emulating ident in tcp_emu, if the strchr checks passed but the > sscanf check failed, two uninitialized variables would be copied and > sent in the reply. William: How did you notice that? Using a static analyzer? Samuel: sin

Re: [Qemu-devel] [PATCH] slirp: fix big/little endian conversion in ident protocol

2019-03-02 Thread Philippe Mathieu-Daudé
On 3/2/19 6:36 PM, Samuel Thibault wrote: > Philippe Mathieu-Daudé, le sam. 02 mars 2019 18:31:56 +0100, a ecrit: >> On 3/2/19 3:25 AM, Samuel Thibault wrote: >>> Signed-off-by: Samuel Thibault >>> --- >> >> I got: >> >> Applying: slirp: fix big/little endian conversion in ident protocol >> error:

Re: [Qemu-devel] [PATCH] slirp: check sscanf result when emulating ident

2019-03-02 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le sam. 02 mars 2019 18:42:42 +0100, a ecrit: > Samuel: since this diff is not obvious without looking at the context > (also due to the code re-indent), I dropped the code re-indent to make the change obvious. I still added the commit description, always better goe

[Qemu-devel] [Bug 1815889]

2019-03-02 Thread Ahzo
(In reply to Daniel P. Berrange from comment #3) > (In reply to Ahzo from comment #2) > > To check for the availability of the syscall, one can try it in a child > > process and see if the child is terminated by a signal, e.g. like this: > > Afraid not, QEMU's seccomp filter blocks use of fork() t

Re: [Qemu-devel] [PATCH RFC v3 00/11] Add RX archtecture support

2019-03-02 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 3/2/19 7:21 AM, Yoshinori Sato wrote: > Hello. > This patch series is added Renesas RX target emulation. > > My git repository is bellow. > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git > > Since my understanding is not enough, > I want many comments to make this a good one.

Re: [Qemu-devel] [PATCH RFC v3 11/11] MAINTAINERS: Add RX entry.

2019-03-02 Thread Philippe Mathieu-Daudé
On 3/2/19 7:21 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > MAINTAINERS | 20 > 1 file changed, 20 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5040d9dfb1..141c4994b9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -270,6 +270,14

Re: [Qemu-devel] [PATCH] target/arm: Fix PC test for LDM (exception return)

2019-03-02 Thread Philippe Mathieu-Daudé
On 3/1/19 9:29 PM, Richard Henderson wrote: > Found by inspection: Rn is the base register against which the > load began; I is the register within the mask being processed. > The exception return should of course be procesed from the loaded PC. "processed" > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v5 07/10] tests/tcg: target/mips: Add test utilities for 64-bit tests

2019-03-02 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 3/1/19 8:18 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add test utilities for 64-bit tests. Some of MIPS64R6 instructions > require 64-bit inputs to be 32-bit integers sign-extedned to 64 bits, "sign-extended" > hence the need for sets of such inputs. > >

Re: [Qemu-devel] [PATCH v5 08/10] tests/tcg: target/mips: Add wrappers for some MIPS64R6 instructions

2019-03-02 Thread Philippe Mathieu-Daudé
On 3/1/19 8:18 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add wrappers for some MIPS64R6 instructions. > > Signed-off-by: Aleksandar Markovic > --- > tests/tcg/mips/include/wrappers_mips64r6.h | 64 > ++ > 1 file changed, 64 insertions(+) > cre

Re: [Qemu-devel] [PATCH RFC v3 08/11] RX62N internal serial communication interface

2019-03-02 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 3/2/19 7:21 AM, Yoshinori Sato wrote: > This module supported only non FIFO type. > Hardware manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf?key=086621e01bd70347c18ea7f794aa9cc3 This link also works without the trailing "?key=08

Re: [Qemu-devel] [PATCH] MAINTAINERS: add missing support status fields

2019-03-02 Thread Philippe Mathieu-Daudé
On 3/1/19 5:35 PM, Stefan Hajnoczi wrote: > This patch adds the "S:" line for areas of the codebase that currently > lack a support status field. > > Note that there are a few more areas that are more abstract and do not > correspond to a specific set of files. They have not been modified. > > C

Re: [Qemu-devel] [RFC] multi phase reset

2019-03-02 Thread Philippe Mathieu-Daudé
Hi Damien, On 3/1/19 5:52 PM, Peter Maydell wrote: > On Fri, 1 Mar 2019 at 15:34, Damien Hedde wrote: >> On 3/1/19 12:43 PM, Peter Maydell wrote: >>> In my design the only thing that I thought would happen in phase 3 >>> was the "clear the resetting flag", but you've moved that to RELEASE. >>> Wh

Re: [Qemu-devel] [PATCH v3 18/20] Boot Linux Console Test: add a test for arm + virt

2019-03-02 Thread Philippe Mathieu-Daudé
Hi Cleber, On 2/21/19 1:57 AM, Cleber Rosa wrote: > Just like the previous tests, boots a Linux kernel on an arm target > using the virt machine. > > Signed-off-by: Cleber Rosa > Reviewed-by: Caio Carrara > --- > .travis.yml| 2 +- > tests/acceptance/boot_linux_con

[Qemu-devel] [PATCH] Re-applying Freescale PPC E500 i2c/RTC patch

2019-03-02 Thread Andrew Randrianasulu
From ad2b4baf8b369c8ef354e56f75ae780413acd989 Mon Sep 17 00:00:00 2001 From: Amit Singh Tomar Date: Sun, 3 Mar 2019 00:05:04 +0300 Subject: [PATCH] Re-applying Freescale PPC E500 i2c/RTC patch Patch was originally writen by Amit Singh Tomar see http://patchwork.ozlabs.org/patch/431475/ I only fi

Re: [Qemu-devel] [PATCH v3 15/20] Boot Linux Console Test: add a test for mips64el + malta

2019-03-02 Thread Philippe Mathieu-Daudé
On 2/21/19 1:57 AM, Cleber Rosa wrote: > Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta > board and verify the serial is working. > > If mips64el is a target being built, "make check-acceptance" will > automatically include this test by the use of the "arch:mips64el" > tags. >

Re: [Qemu-devel] [PATCH v3 09/20] Boot Linux Console Test: update the x86_64 kernel

2019-03-02 Thread Philippe Mathieu-Daudé
On 2/21/19 1:57 AM, Cleber Rosa wrote: > To the stock Fedora 29 kernel, from the Fedora 28. New tests will be [Update] to ... ? > added using the 29 kernel, so for consistency, let's also update it > here. > > Signed-off-by: Cleber Rosa > Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathi

Re: [Qemu-devel] [PATCH v3 14/20] Boot Linux Console Test: add a test for mips + malta

2019-03-02 Thread Philippe Mathieu-Daudé
On 2/21/19 1:57 AM, Cleber Rosa wrote: > From: Philippe Mathieu-Daudé > > Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta > board and verify the serial is working. Also, it relies on the serial > device set by the machine itself. > > If mips is a target being built, "make ch

Re: [Qemu-devel] [PATCH v3 11/20] Boot Linux Console Test: increase timeout

2019-03-02 Thread Philippe Mathieu-Daudé
On 2/21/19 1:57 AM, Cleber Rosa wrote: > When running on very low powered environments, some tests may time out > causing false negatives. As a conservative change, and for > considering that human time (investigating false negatives) is worth > more than some extra machine cycles (and time), let'

[Qemu-devel] [Bug 1818367] [NEW] Initialization of device cfi.pflash01 failed: Block node is read-only

2019-03-02 Thread José Pekkarinen
Public bug reported: Hi, I have several vms defined in libvirt using ovmf for uefi, since a later update of my server I'm unable to start any of the domains defined. This is an example of the output given: # virsh start os-1 error: Failed to start domain os-1 error: internal error: qemu unexpect

Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?

2019-03-02 Thread Andrew Randrianasulu
В сообщении от Saturday 02 March 2019 23:40:47 BALATON Zoltan написал(а): [snip] > > On Sat, 2 Mar 2019, Andrew Randrianasulu wrote: > > Should I fix those? > > [...] > > > total: 14 errors, 2 warnings, 462 lines checked > > > > 0001-Re-applying-of-Freescale-PPC500-i2c-RTC-patch-writte.patch has

[Qemu-devel] [PATCH] BootLinuxConsoleTest: Let extract_from_deb handle various compressions

2019-03-02 Thread Philippe Mathieu-Daudé
Debian binary package format supports various compressions. Per man deb(5): NAME deb - Debian binary package format FORMAT ... The third, last required member is named data.tar. It contains the filesystem as a tar archive, either not compressed (supported since dpkg 1.10

Re: [Qemu-devel] [Bug 1818367] [NEW] Initialization of device cfi.pflash01 failed: Block node is read-only

2019-03-02 Thread Philippe Mathieu-Daudé
Hi José, On 3/2/19 10:35 PM, José Pekkarinen wrote: > Public bug reported: > > Hi, > > I have several vms defined in libvirt using ovmf for uefi, since a later > update of my server I'm unable to start any of the domains defined. This is This looks more like a libvirt issue than a QEMU one. >

[Qemu-devel] [PATCH 0/2] util/error: Trivial cleanup

2019-03-02 Thread Philippe Mathieu-Daudé
Trivial cleanups suggested by Daniel and Thomas. Philippe Mathieu-Daudé (2): util/error: Remove an unnecessary NULL check util/error: Remove unnecessary saved_errno util/error.c | 7 --- 1 file changed, 7 deletions(-) -- 2.20.1

[Qemu-devel] [PATCH 1/2] util/error: Remove an unnecessary NULL check

2019-03-02 Thread Philippe Mathieu-Daudé
This NULL check was required while introduced in 680d16dcb79f. Later refactor added a NULL check in error_setv(), so this check is now redundant. Reviewed-by: Daniel P. Berrangé Reviewed-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- util/error.c | 4 1 file changed, 4 de

[Qemu-devel] [PATCH 2/2] util/error: Remove unnecessary saved_errno

2019-03-02 Thread Philippe Mathieu-Daudé
Since 552375088a8, error_set_errno() calls error_setv() which already protect errno for clobbering. Remove the now unnecessary saved_errno. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- util/error.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/util/error.c b/util/

Re: [Qemu-devel] [PATCH v6 39/73] i386: convert to cpu_interrupt_request

2019-03-02 Thread Emilio G. Cota
On Fri, Feb 08, 2019 at 11:00:23 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Reviewed-by: Richard Henderson > > Signed-off-by: Emilio G. Cota > > --- > > target/i386/cpu.c| 2 +- > > target/i386/helper.c | 4 ++-- > > target/i386/svm_helper.c | 4 ++-- > > 3 files c

Re: [Qemu-devel] [PATCH v6 40/73] i386/kvm: convert to cpu_interrupt_request

2019-03-02 Thread Emilio G. Cota
On Fri, Feb 08, 2019 at 11:15:27 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Reviewed-by: Richard Henderson > > Signed-off-by: Emilio G. Cota > > --- > > target/i386/kvm.c | 54 +++ > > 1 file changed, 31 insertions(+), 23 deletions(-

Re: [Qemu-devel] [PATCH] slirp: check sscanf result when emulating ident

2019-03-02 Thread William Bowling
Hi Phil, William: How did you notice that? Using a static analyzer? It was while looking into a previous CVE in tcp_emu, just with a manual code review. We have a data leak, Cc'ing qemu-stable. > (Adding the address I noticed you Cc'ed secal...@redhat.com, so that > confirms my guess). Yeah t

[Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-02 Thread BALATON Zoltan
At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the fulong2e expect this to be available. Fortunately these are very similar chips so they can be mostly emulated

Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?

2019-03-02 Thread Andrew Randrianasulu
В сообщении от Sunday 03 March 2019 03:17:47 BALATON Zoltan написал(а): > On Sun, 3 Mar 2019, Andrew Randrianasulu wrote: > > git commit -a --author="Amit Singh Tomar " > > git format-patch -s 20b084c4b1401b7f8fbc385649d48c67b6f43d44 > > > > scripts/checkpatch.pl > > 0001-Re-applying-Freescale-PPC-

Re: [Qemu-devel] [Qemu-ppc] Forward-porting RTC device for eppc500 ?

2019-03-02 Thread BALATON Zoltan
On Sun, 3 Mar 2019, Andrew Randrianasulu wrote: git commit -a --author="Amit Singh Tomar " git format-patch -s 20b084c4b1401b7f8fbc385649d48c67b6f43d44 scripts/checkpatch.pl 0001-Re-applying-Freescale-PPC-E500-i2c-RTC-patch.patch After this I created new message in Kmail and inserted 0001 file,

Re: [Qemu-devel] [PATCH 2/2] util/error: Remove unnecessary saved_errno

2019-03-02 Thread Eric Blake
On 3/2/19 4:38 PM, Philippe Mathieu-Daudé wrote: > Since 552375088a8, error_set_errno() calls error_setv() which > already protect errno for clobbering. > Remove the now unnecessary saved_errno. > > Suggested-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > --- > util/error.c | 3 --- >

Re: [Qemu-devel] [PATCH 2/2] util/error: Remove unnecessary saved_errno

2019-03-02 Thread Philippe Mathieu-Daudé
On 3/3/19 2:12 AM, Eric Blake wrote: > On 3/2/19 4:38 PM, Philippe Mathieu-Daudé wrote: >> Since 552375088a8, error_set_errno() calls error_setv() which >> already protect errno for clobbering. >> Remove the now unnecessary saved_errno. >> >> Suggested-by: Thomas Huth >> Signed-off-by: Philippe Ma

Re: [Qemu-devel] [PATCH v4] hw/display: Add basic ATI VGA emulation

2019-03-02 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 3/3/19 12:34 AM, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available. Fortunate

[Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

2019-03-02 Thread Samuel Thibault
By default, curses will only report single ESC key event after 1s delay, since ESC is also used for keypad escape sequences. This however makes users believe that ESC is not working. Reducing to 0.2s provides good enough user experience, while still allowing 200ms for keypad sequences to get in, wh

[Qemu-devel] [PATCH] slirp: Mark pieces missing IPv6 support

2019-03-02 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- net/slirp.c | 1 + slirp/misc.c | 3 +++ slirp/slirp.c | 5 + slirp/socket.c| 1 + slirp/tcp_input.c | 2 ++ slirp/tcp_subr.c | 2 ++ slirp/udp.c | 1 + 7 files changed, 15 insertions(+) diff --git a/net/slirp.c b/net/slirp.c index

Re: [Qemu-devel] [PATCH] slirp: Mark pieces missing IPv6 support

2019-03-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190303060423.29356-1-samuel.thiba...@ens-lyon.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190303060423.29356-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PATCH