On Sun, 3 Mar 2019, Andrew Randrianasulu wrote:
git commit -a --author="Amit Singh Tomar <amit.to...@freescale.com>"
git format-patch -s 20b084c4b1401b7f8fbc385649d48c67b6f43d44
scripts/checkpatch.pl 0001-Re-applying-Freescale-PPC-E500-i2c-RTC-patch.patch
After this I created new message in Kmail and inserted 0001 file, edited it a
bit more (adding patchwork link and mentioning fact I actually boot-tested
patch), and then send out.
When sending patches to list make sure your mailer sends them as plain
text and does not try to break up lines or alter white space because that
breaks the patch and it won't apply with git am. You can check it in
patchew (linked from SubmitAPatch wiki page):
https://patchew.org/QEMU/201903030021.22070.randrianas...@gmail.com/
Not sure if Kmail can do this, maybe it has some settings for this but
it's usually better to do all editing on the git commit and send patch
mails with git send-email.
Guess next time I better to add second "-s" to git format-patch, so first
signed-off-by-line from original will be around too?
Or ..lets wait what actual maintainers will say.
Yes, I'll let actual maintainers to comment then you can do a corrected
version with any requested fixes or Reviewed-by tags added. I think for
next revision you should leave original author's Signed-off-by in commit
message and add yours with -s after that. (When sending another version of
a patch use -v2 option of git format-patch to add v2 to the patch
subject and so on for higher revisions if needed.)
Regards,
BALATON Zoltan
