Re: [Qemu-devel] [Qemu-block] [PULL 0/9] Block patches

2019-02-12 Thread Stefano Garzarella
On Tue, Feb 12, 2019 at 11:51:18AM +0800, Stefan Hajnoczi wrote: > On Mon, Feb 11, 2019 at 11:42:14AM +, Peter Maydell wrote: > > > > Hi; this fails to pass "make check" (all platforms): > > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > > QTEST_QEMU_BINARY=arm-softmmu

Re: [Qemu-devel] [PATCH v3 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-12 Thread Knut Omang
On Mon, 2019-02-11 at 16:09 -0700, Alex Williamson wrote: > On Sun, 10 Feb 2019 07:52:59 +0100 > Knut Omang wrote: > > > Add a helper function to add PCIe capability for Access Control Services > > (ACS) > > ACS support in the associated root port is a prerequisite to be able to do > > passthroug

Re: [Qemu-devel] [PATCH v2 1/2] linux-user: Add ELF_PLATFORM for arm

2019-02-12 Thread Laurent Vivier
On 12/02/2019 08:48, Richard Henderson wrote: > The 32-bit kernel has strings for v4, v5, v6, v7, v7m. > The 64-bit kernel, in compat mode, has strings for v8. > > Fixes: https://bugs.launchpad.net/bugs/1813034 > Signed-off-by: Richard Henderson > --- > v2: Include v8. > --- > linux-user/elfload

Re: [Qemu-devel] [PATCH v2 2/2] linux-user: Fix ELF_PLATFORM for aarch64_be-linux-user

2019-02-12 Thread Laurent Vivier
On 12/02/2019 08:48, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/elfload.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/linux-user/elfload.c b/linux-user/elfload.c > index d796d51ec6..5aa0628ae9 100644 > --- a/linux-user/elfload

Re: [Qemu-devel] [PATCH 03/19] xive: extend the XiveRouter get_tctx() method with the page offset

2019-02-12 Thread Cédric Le Goater
On 2/12/19 5:34 AM, David Gibson wrote: > On Mon, Jan 28, 2019 at 10:46:09AM +0100, Cédric Le Goater wrote: >> The PowerNV machine can perform indirect loads and stores on the TIMA >> on behalf of another CPU. The PIR of the CPU is controlled by a set of >> 4 registers, one per TIMA page. To know w

Re: [Qemu-devel] [PATCH] hostmem-file: reject invalid pmem file sizes

2019-02-12 Thread Pankaj Gupta
Hi Stefan, > > Guests started with NVDIMMs larger than the underlying host file produce > confusing errors inside the guest. This happens because the guest > accesses pages beyond the end of the file. > > Check the pmem file size on startup and print a clear error message if > the size is inv

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Thomas Huth
On 2019-02-11 17:38, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/devel/kconfig.rst | 284 + > 1 file changed, 284 insertions(+) > create mode 100644 docs/devel/kconfig.rst Thanks for writing this up - that's a really helpful text! >

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-02-12 Thread Kevin Wolf
Am 11.02.2019 um 19:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.02.2019 20:54, Kevin Wolf wrote: > > Am 21.12.2018 um 17:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Move to way of device selecting, however fall back to device name if > >> path is not found. > >> > >> Signed-off-

Re: [Qemu-devel] [PATCH v3 0/2] target/s390x: Implement STCK et al for CONFIG_USER_ONLY

2019-02-12 Thread Cornelia Huck
On Mon, 11 Feb 2019 21:30:42 -0800 Richard Henderson wrote: > Changes since v2: > * Fix botched subject line, include r-b tags. > > Changes since v1: > * Move more of hw/s390x/tod.h to a new header. > * Use time2tod. > > > r~ > > > Richard Henderson (2): > target/s390x: Split out s39

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Markus Armbruster
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > docs/devel/kconfig.rst | 284 + > 1 file changed, 284 insertions(+) > create mode 100644 docs/devel/kconfig.rst > > diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst > new file mode

Re: [Qemu-devel] [PATCH v2 2/3] s390x/cpumodel: default enable mepoch for z14 and later

2019-02-12 Thread David Hildenbrand
On 12.02.19 02:16, Collin Walling wrote: > Latest systems and host kernels support mepoch, which is a > feature that was meant to be supported for z14 GA1 from the > get-go. Let's copy it to the z14 GA1 default CPU model. > > Machines s390-ccw-virtio-3.1 and older will retain the old CPU > models

Re: [Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging

2019-02-12 Thread Markus Armbruster
dovgaluk writes: > Markus Armbruster писал 2019-02-12 10:14: >> "Pavel Dovgalyuk" writes: >> >>> Ping? >> >> Are you pinging for more review, or for someone to merge this? > > From my point of view this patch set is ready. MAINTAINERS Record/replay M: Pavel Dovgalyuk R: Paolo Bonz

[Qemu-devel] [Bug 1815143] Re: qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-12 Thread Thomas Huth
This should be the commit that fixed this issue: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=303c681a8f50eb88fbafc ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Qemu-devel] [PATCH v1] s390x: add zPCI feature to "qemu" CPU model

2019-02-12 Thread David Hildenbrand
As we now always have PCI support, let's add it to the "qemu" CPU model, taking care of backwards compatibility. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/gen-features.c | 8 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/s

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-02-12 Thread Cornelia Huck
On Mon, 11 Feb 2019 12:57:36 -0500 "Jason J. Herne" wrote: > On 2/4/19 5:45 AM, Cornelia Huck wrote: > > On Tue, 29 Jan 2019 08:29:12 -0500 > > "Jason J. Herne" wrote: > >> diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c > >> index 7e3f65e..2457752 100644 > >> --- a/pc-bios/s390-

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-12 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Feb 06, 2019 at 02:23:29PM +0100, Juan Quintela wrote: >> Libvirt don't want to expose (and explain it). And testing looks like >> 128 is good for all use cases, so just drop it. > > One significant concern inline... > >> >> Signed-off-by: Juan Quintela >> --

Re: [Qemu-devel] [PATCH v3 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-12 Thread Knut Omang
On Tue, 2019-02-12 at 09:07 +0100, Knut Omang wrote: > On Mon, 2019-02-11 at 16:09 -0700, Alex Williamson wrote: > > On Sun, 10 Feb 2019 07:52:59 +0100 > > Knut Omang wrote: > > > > > Add a helper function to add PCIe capability for Access Control Services > > > (ACS) > > > ACS support in the ass

Re: [Qemu-devel] [Qemu-block] [PULL 0/9] Block patches

2019-02-12 Thread Peter Maydell
On Tue, 12 Feb 2019 at 03:51, Stefan Hajnoczi wrote: > > On Mon, Feb 11, 2019 at 11:42:14AM +, Peter Maydell wrote: > > Hi; this fails to pass "make check" (all platforms): > > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > > QTEST_QEMU_BINARY=arm-softmmu/qemu-system-ar

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-02-12 Thread Vladimir Sementsov-Ogievskiy
12.02.2019 12:07, Kevin Wolf wrote: > Am 11.02.2019 um 19:30 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 11.02.2019 20:54, Kevin Wolf wrote: >>> Am 21.12.2018 um 17:53 hat Vladimir Sementsov-Ogievskiy geschrieben: Move to way of device selecting, however fall back to device name if p

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] coroutines: generate wrapper code

2019-02-12 Thread Vladimir Sementsov-Ogievskiy
12.02.2019 6:22, Stefan Hajnoczi wrote: > On Mon, Feb 11, 2019 at 09:38:37AM +, Vladimir Sementsov-Ogievskiy wrote: >> 11.02.2019 6:42, Stefan Hajnoczi wrote: >>> On Fri, Feb 08, 2019 at 05:11:22PM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: Hi all! We have a very frequent pa

Re: [Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

2019-02-12 Thread Cornelia Huck
On Mon, 11 Feb 2019 20:16:55 -0500 Collin Walling wrote: > The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent > on the multiple-epoch facility (mepoch). Let's print a warning if these > features are enabled without mepoch. > > While we're at it, let's move the FEAT_GROUP_INIT fo

[Qemu-devel] [PATCH v2] Kconfig: add documentation

2019-02-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/kconfig.rst | 305 + 1 file changed, 305 insertions(+) create mode 100644 docs/devel/kconfig.rst diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst new file mode 100644 index 00..ff1ed3d1b2 ---

Re: [Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

2019-02-12 Thread Christian Borntraeger
On 12.02.2019 02:16, Collin Walling wrote: > The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent > on the multiple-epoch facility (mepoch). Let's print a warning if these > features are enabled without mepoch. > > While we're at it, let's move the FEAT_GROUP_INIT for mepochptff

Re: [Qemu-devel] [PATCH v2] Kconfig: add documentation

2019-02-12 Thread Cornelia Huck
On Tue, 12 Feb 2019 10:57:49 +0100 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/devel/kconfig.rst | 305 + > 1 file changed, 305 insertions(+) > create mode 100644 docs/devel/kconfig.rst Looks good! Reviewed-by: Cornelia Huck

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-12 Thread Daniel P . Berrangé
On Tue, Feb 12, 2019 at 10:34:35AM +0100, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Feb 06, 2019 at 02:23:29PM +0100, Juan Quintela wrote: > >> Libvirt don't want to expose (and explain it). And testing looks like > >> 128 is good for all use cases, so just drop it. > > > > One

Re: [Qemu-devel] [PATCH 1/1] RFC: net/slirp: link with libslirp

2019-02-12 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 11:22:27PM +0100, Samuel Thibault wrote: > Marc-André Lureau, le lun. 11 févr. 2019 12:34:47 +0100, a ecrit: > > On Mon, Feb 11, 2019 at 12:09 PM Daniel P. Berrangé > > wrote: > > > > > > On Fri, Feb 08, 2019 at 07:12:26PM +0100, Marc-André Lureau wrote: > > > > Once libsl

Re: [Qemu-devel] [PULL v3 26/28] seccomp: Work-around GCC 4.x bug in gnu99 mode

2019-02-12 Thread Eduardo Otubo
On 17/01/2019 - 14:38:12, Thomas Huth wrote: > We'd like to compile QEMU with -std=gnu99, but GCC 4.8 currently > fails to compile qemu-seccomp.c in this mode: > > qemu-seccomp.c:45:1: error: initializer element is not constant > }; > ^ > qemu-seccomp.c:45:1: error: (near initialization for > ‘

Re: [Qemu-devel] [PATCH 1/4] io/channel: add qio_channel_get_attached_aio_context()

2019-02-12 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 03:55:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Expose attached aio context. It will be used in nbd code, to > understand, in which aio context negotiation should be done. I'm not especially objecting to the idea of adding the API to the QIOChannel class, but I'm su

Re: [Qemu-devel] [PATCH] seccomp: Work-around GCC 4.x bug in gnu99 mode

2019-02-12 Thread Eduardo Otubo
On 23/01/2019 - 07:57:51, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/1547573562-32754-1-git-send-email-th...@redhat.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have D

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 8:11 AM, Peter Xu wrote: > On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S. Tsirkin wrote: >> >> OK I reverted the whole part dealing with vhost-user and reposted. > > I noticed that the merged pull request could possibly have squashed > the below two patches (in previous pull) into

Re: [Qemu-devel] [PATCH 1/1] RFC: net/slirp: link with libslirp

2019-02-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Feb 11, 2019 at 11:22:27PM +0100, Samuel Thibault wrote: > > Marc-André Lureau, le lun. 11 févr. 2019 12:34:47 +0100, a ecrit: > > > On Mon, Feb 11, 2019 at 12:09 PM Daniel P. Berrangé > > > wrote: > > > > > > > > On Fri, Feb 08, 2019 at

[Qemu-devel] [PATCH] hw/arm/armsse: Fix miswiring of expansion IRQs

2019-02-12 Thread Peter Maydell
In commit 91c1e9fcbd7548db368 where we added dual-CPU support to the ARMSSE, we set up the wiring of the expansion IRQs via nested loops: the outer loop on 'i' loops for each CPU, and the inner loop on 'j' loops for each interrupt. Fix a typo which meant we were wiring every expansion IRQ line to e

Re: [Qemu-devel] [PULL 0/4] NBD patches for 2019-02-11

2019-02-12 Thread Peter Maydell
On Mon, 11 Feb 2019 at 20:53, Eric Blake wrote: > > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into > staging (2019-02-11 17:04:57 +) > > are available in the Git repository at: > > htt

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] coroutines: generate wrapper code

2019-02-12 Thread Stefan Hajnoczi
On Tue, Feb 12, 2019 at 10:03:19AM +, Vladimir Sementsov-Ogievskiy wrote: > 12.02.2019 6:22, Stefan Hajnoczi wrote: > > On Mon, Feb 11, 2019 at 09:38:37AM +, Vladimir Sementsov-Ogievskiy > > wrote: > >> 11.02.2019 6:42, Stefan Hajnoczi wrote: > >>> On Fri, Feb 08, 2019 at 05:11:22PM +0300,

Re: [Qemu-devel] [Bug 1814418] [NEW] persistent bitmap will be inconsistent when qemu crash,

2019-02-12 Thread Vladimir Sementsov-Ogievskiy
12.02.2019 4:10, John Snow wrote: > > > On 2/4/19 11:22 AM, Vladimir Sementsov-Ogievskiy wrote: >> 04.02.2019 17:55, Eric Blake wrote: >>> On 2/2/19 11:52 PM, Cheng Chen wrote: Public bug reported: Follow these steps to reappear the bug: 1. start qemu 2. add persiste

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Paolo Bonzini
On 12/02/19 10:08, Markus Armbruster wrote: > Please wrap your lines at column 70 or so. Humans tend to have trouble > following long lines with their eyes (I sure do). Typographic manuals > suggest to limit columns to roughly 60 characters for exactly that > reason[*]. Yup, fixed in v2. >> +Ea

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Paolo Bonzini
On 12/02/19 10:13, Thomas Huth wrote: >> +Unlike Linux, there is no user interface to edit the configuration, which >> is instead >> +specified in per-target files under the ``default-configs/`` directory of >> the >> +QEMU source tree. This is because, unlike Linux, configuration and >> depend

[Qemu-devel] [PATCH v1 00/15] s390x/tcg: Implement floating-point extension facility

2019-02-12 Thread David Hildenbrand
This series is based on the patches currently on the list: - softfloat: Implement float128_to_uint32 - softfloat: add float128_is_{normal,denormal} - s390x: add zPCI feature to "qemu" CPU model For the KVM folks, only the last patch is of interest. The floating-point extension facility seems to b

Re: [Qemu-devel] [Qemu-ppc] [PATCH] cuda: decrease time delay before raising VIA SR interrupt

2019-02-12 Thread BALATON Zoltan
On Tue, 12 Feb 2019, Mark Cave-Ayland wrote: On 11/02/2019 23:35, Philippe Mathieu-Daudé wrote: Hi Mark, On 2/10/19 6:44 PM, Mark Cave-Ayland wrote: In order to handle a race condition in MacOS 9, a delay was introduced when raising the VIA SR interrupt inspired by similar code in MacOnLinux.

[Qemu-devel] [PATCH v1] s390x: Add floating-point extension facility to "qemu" cpu model

2019-02-12 Thread David Hildenbrand
The floating-point extension facility implemented certain changes to BFP, HFP and DFP instructions. As we don't implement HFP/DFP, we can ignore those completely. Related to BFP, the changes include - SET BFP ROUNDING MODE (SRNMB) instruction - BFP-rounding-mode field in the FPC register is change

[Qemu-devel] [PATCH v1 06/15] s390x/tcg: Refactor SET FPC AND SIGNAL handling

2019-02-12 Thread David Hildenbrand
We can directly work on the uint64_t value, no need for a temporary uint32_t value. Also cleanup and shorten the comments. Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/target/s390x/fpu

[Qemu-devel] [PATCH v1 02/15] s390x/tcg: Fix rounding from float128 to uint64_t/uin32_t

2019-02-12 Thread David Hildenbrand
Let's use the proepr conversion functions now that we have them. Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/s390x/fpu_helper.c b/target/s390x/fpu_helper.c index a3214bd546..f9ec519067 100644 --

[Qemu-devel] [PATCH v1 10/15] s390x/tcg: Refactor saving/restoring the bfp rounding mode

2019-02-12 Thread David Hildenbrand
We want to reuse this in the context of vector instructions. So use better matching names and introduce s390_restore_bfp_rounding_mode(). While at it, add proper newlines. Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 113 +++--- target/s390x/i

[Qemu-devel] [PATCH v1 04/15] s390x/tcg: Fix parts of IEEE exception handling

2019-02-12 Thread David Hildenbrand
Many things are wrong and some parts cannot be fixed yet. Fix what we can fix easily and add two FIXMEs: The fpc flags are not updated in case an exception is actually injected. Inexact exceptions have to be handled separately, as they are the only exceptions that can coexist with underflows and o

[Qemu-devel] [PATCH v1 01/15] s390x/tcg: Fix TEST DATA CLASS instructions

2019-02-12 Thread David Hildenbrand
Let's detect normal and denormal ("subnormal") numbers reliably. Also test for quiet NaN's. While at it, use a better check to test for the mask bits in the data class mask. The data class mask has 12 bits, whereby bit 0 is the leftmost bit and bit 11 the rightmost bit. In the PoP an easy to read

[Qemu-devel] [PATCH v1 14/15] s390x/tcg: Handle all rounding modes overwritten by BFP instructions

2019-02-12 Thread David Hildenbrand
PoP describes "Round to nearest with ties away from 0" as "The candidate nearest to the input value is selected. In case of a tie, the candidate selected is the one that is larger in magnitude." While float_round_ties_away is according to the introducing commit f9288a76f181 ("softfloat: Add s

[Qemu-devel] [PATCH v1 03/15] s390x/tcg: Factor out conversion of softfloat exceptions

2019-02-12 Thread David Hildenbrand
We want to reuse that function in vector instruction context. While at it, cleanup the code, using defines for magic values and avoiding the handcrafted bit conversion. Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 25 + target/s390x/internal.h | 7 +

[Qemu-devel] [PATCH v1 12/15] s390x/tcg: Implement XxC and checks for most FP instructions

2019-02-12 Thread David Hildenbrand
With the floating-point extension facility - CONVERT FROM LOGICAL - CONVERT TO LOGICAL - CONVERT TO FIXED - CONVERT FROM FIXED - LOAD FP INTEGER have both, a rounding mode specification and the inexact-exception control (XxC). Other instructions will be handled separatly. Check for valid rounding

[Qemu-devel] [PATCH v1 09/15] s390x/tcg: Check for exceptions in SET BFP ROUNDING MODE

2019-02-12 Thread David Hildenbrand
Let's split handling of BFP/DFP rounding mode configuration. Also, let's not reuse the sfpc handler, use a separate handler so we can properly check for specification exceptions for SRNMB. Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 11 target/s390x/helper.h |

[Qemu-devel] [PATCH v1 15/15] s390x: Add floating-point extension facility to "qemu" cpu model

2019-02-12 Thread David Hildenbrand
The floating-point extension facility implemented certain changes to BFP, HFP and DFP instructions. As we don't implement HFP/DFP, we can ignore those completely. Related to BFP, the changes include - SET BFP ROUNDING MODE (SRNMB) instruction - BFP-rounding-mode field in the FPC register is change

[Qemu-devel] [PATCH v1 11/15] s390x/tcg: Prepare for IEEE-inexact-exception control (XxC)

2019-02-12 Thread David Hildenbrand
Some instructions allow to suppress IEEE inexact exceptions. z14 PoP, 9-23, "Suppression of Certain IEEE Exceptions" IEEE-inexact-exception control (XxC): Bit 1 of the M4 field is the XxC bit. If XxC is zero, recogni- tion of IEEE-inexact exception is not suppressed; if XxC is one,

[Qemu-devel] [PATCH v1 08/15] s390x/tcg: Handle SET FPC AND LOAD FPC 3-bit BFP rounding modes

2019-02-12 Thread David Hildenbrand
We already forward the 3 bits correctly in the translation functions. We also have to handle them properly and check for specification exceptions. Setting an invalid rounding mode (BFP only, all DFP rounding modes) results in a specification exception. Setting unassigned bits in the fpc, results i

Re: [Qemu-devel] [PATCH] hw/arm/armsse: Fix miswiring of expansion IRQs

2019-02-12 Thread Peter Maydell
On Tue, 12 Feb 2019 at 11:05, Philippe Mathieu-Daudé wrote: > > On 2/12/19 11:52 AM, Peter Maydell wrote: > > In commit 91c1e9fcbd7548db368 where we added dual-CPU support to > > the ARMSSE, we set up the wiring of the expansion IRQs via nested > > loops: the outer loop on 'i' loops for each CPU,

[Qemu-devel] [PATCH v1 05/15] s390x/tcg: Hide IEEE underflows in some scenarios

2019-02-12 Thread David Hildenbrand
IEEE underflows are not reported when the mask bit is off and we don't also have an inexact exception. z14 PoP, 9-20, "IEEE Underflow": An IEEE-underflow exception is recognized for an IEEE target when the tininess condition exists and either: (1) the IEEE-underflow mask bit in the FPC

Re: [Qemu-devel] [PATCH] hw/arm/armsse: Fix miswiring of expansion IRQs

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 11:52 AM, Peter Maydell wrote: > In commit 91c1e9fcbd7548db368 where we added dual-CPU support to > the ARMSSE, we set up the wiring of the expansion IRQs via nested > loops: the outer loop on 'i' loops for each CPU, and the inner loop > on 'j' loops for each interrupt. Fix a typo which

[Qemu-devel] [PATCH v1 07/15] s390x/tcg: Fix simulated-IEEE exceptions

2019-02-12 Thread David Hildenbrand
The trap is triggered based on priority of the enabled signaling flags. Only overflow and underflow allow a concurrent inexact exception. z14 PoP, 9-33, Figure 9-21 Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 13 + 1 file changed, 13 insertions(+) diff --git a/

Re: [Qemu-devel] [PATCH v1] s390x: add zPCI feature to "qemu" CPU model

2019-02-12 Thread Cornelia Huck
On Tue, 12 Feb 2019 10:30:23 +0100 David Hildenbrand wrote: > As we now always have PCI support, let's add it to the "qemu" CPU model, > taking care of backwards compatibility. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 3 +++ > target/s390x/gen-features.c | 8 +

Re: [Qemu-devel] [PATCH v2] Kconfig: add documentation

2019-02-12 Thread Liam Merwick
On 12/02/2019 09:57, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Liam Merwick --- docs/devel/kconfig.rst | 305 + 1 file changed, 305 insertions(+) create mode 100644 docs/devel/kconfig.rst diff --git a/docs/devel/kconfig.rst

[Qemu-devel] [PATCH v1 13/15] s390x/tcg: Implement rounding mode and XxC for LOAD ROUNDED

2019-02-12 Thread David Hildenbrand
With the floating-point extension facility, LOAD ROUNDED has a rounding mode specification and the inexact-exception control (XxC). Handle them just like e.g. LOAD FP INTEGER. Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 22 -- target/s390x/helper.h

[Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model

2019-02-12 Thread David Hildenbrand
As we now always have PCI support, let's add it to the "qemu" CPU model, taking care of backwards compatibility. Signed-off-by: David Hildenbrand --- v1 -> v2: - Use correct model identifiction of the z12 we emulate hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/gen-features.c | 8 ++--

Re: [Qemu-devel] [PATCH v1] s390x: Add floating-point extension facility to "qemu" cpu model

2019-02-12 Thread David Hildenbrand
On 12.02.19 12:02, David Hildenbrand wrote: > The floating-point extension facility implemented certain changes to > BFP, HFP and DFP instructions. > > As we don't implement HFP/DFP, we can ignore those completely. Related > to BFP, the changes include > - SET BFP ROUNDING MODE (SRNMB) instruction

Re: [Qemu-devel] [PATCH v1] s390x: add zPCI feature to "qemu" CPU model

2019-02-12 Thread David Hildenbrand
On 12.02.19 12:16, Cornelia Huck wrote: > On Tue, 12 Feb 2019 10:30:23 +0100 > David Hildenbrand wrote: > >> As we now always have PCI support, let's add it to the "qemu" CPU model, >> taking care of backwards compatibility. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/s390-virtio-

[Qemu-devel] [PATCH] contrib/rdmacm-mux: Fix out-of-bounds risk

2019-02-12 Thread Yuval Shaia
The function get_fd extract context from the received MAD message and uses it as a key to fetch the destination fd from the mapping table. A context can be dgid in case of CM request message or comm_id in case of CM SIDR response message. When MAD message with a smaller size as expected for the me

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Paolo Bonzini
On 11/02/19 18:17, Cornelia Huck wrote: >> + >> +This domain-specific language is based on the Kconfig language that >> originated in the >> +Linux kernel, though it was heavily simplified and the handling of >> dependencies is >> +stricter in QEMU. >> + >> +Unlike Linux, there is no user interfa

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-12 Thread Alberto Garcia
On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote: >>> The problem is in the concept of "base" node. The code written in >>> manner that base is not changed during block job. However, job don't >>> own base and there is no guarantee that it will not change during >>> the job. >

Re: [Qemu-devel] [PATCH] contrib/rdmacm-mux: Fix out-of-bounds risk

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 12:23 PM, Yuval Shaia wrote: > The function get_fd extract context from the received MAD message and > uses it as a key to fetch the destination fd from the mapping table. > A context can be dgid in case of CM request message or comm_id in case > of CM SIDR response message. > > When MA

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 24.01.19 14:20, Gerd Hoffmann wrote: > Get rid of the pcspk_state global, allow pc speaker > be added using "-device isa-pcspk". > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Philippe Mathieu-Daudé > Message-id: 20190124110810.1040-1-kra...@redhat.com > --- > hw/audio/pcspk.c | 35

[Qemu-devel] [PATCH v2] ppc: add host-serial and host-model machine attributes

2019-02-12 Thread P J P
From: Prasad J Pandit On ppc hosts, hypervisor shares following system attributes - /proc/device-tree/system-id - /proc/device-tree/model with a guest. This could lead to information leakage and misuse.[*] Add machine attributes to control such system information exposure to a guest. [*] h

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Stefan Berger
On 2/11/19 10:03 AM, Liam Merwick wrote: cppcheck reports: [hw/tpm/tpm_tis.c:113]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int' Fix this by using %u instead of %d Signed-off-by: Liam Merwick Reviewed-by: Stefan Berger --- hw/tpm/tpm_tis.c

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] coroutines: generate wrapper code

2019-02-12 Thread Kevin Wolf
Am 12.02.2019 um 04:22 hat Stefan Hajnoczi geschrieben: > On Mon, Feb 11, 2019 at 09:38:37AM +, Vladimir Sementsov-Ogievskiy wrote: > > 11.02.2019 6:42, Stefan Hajnoczi wrote: > > > On Fri, Feb 08, 2019 at 05:11:22PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > >> Hi all! > > >> > > >>

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread Philippe Mathieu-Daudé
Hi David, On 2/12/19 12:47 PM, David Hildenbrand wrote: > On 24.01.19 14:20, Gerd Hoffmann wrote: >> Get rid of the pcspk_state global, allow pc speaker >> be added using "-device isa-pcspk". >> >> Signed-off-by: Gerd Hoffmann >> Reviewed-by: Philippe Mathieu-Daudé >> Message-id: 20190124110810.

[Qemu-devel] [PATCH] ppc: fix crash during branch stepping

2019-02-12 Thread Roman Kapl
The PPC BRANCH exception could bubble up, but this is an QEMU internal exception and QEMU then crased. Instead it should trigger TRACE exception, according to PPC 2.07 book. It could happen only when using branch stepping, which is not commonly used. Change gen_prep_dbgex do do trigger TRACE. The

Re: [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h"

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/5/19 12:18 AM, Philippe Mathieu-Daudé wrote: > Hi, > > As his first comment describes itself, the "hw/devices.h" contains > declarations for "Devices that have nowhere better to go." > This series remove it, creating new headers for devices covered there. > MAINTAINERS is updated. > I also in

Re: [Qemu-devel] [qemu-s390x] [PATCH 06/15] s390-bios: Clean up cio.h

2019-02-12 Thread Thomas Huth
On 2019-02-04 11:48, Cornelia Huck wrote: > On Tue, 29 Jan 2019 08:29:13 -0500 > "Jason J. Herne" wrote: > >> Add proper typedefs to all structs and modify all bit fields to use >> consistent >> formatting. >> >> Signed-off-by: Jason J. Herne >> Reviewed-by: Collin Walling >> --- >> pc-bios/s

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 12.02.19 13:20, David Hildenbrand wrote: > On 12.02.19 13:08, Philippe Mathieu-Daudé wrote: >> Hi David, >> >> On 2/12/19 12:47 PM, David Hildenbrand wrote: >>> On 24.01.19 14:20, Gerd Hoffmann wrote: Get rid of the pcspk_state global, allow pc speaker be added using "-device isa-pcspk

Re: [Qemu-devel] [PULL 0/3] Block patches

2019-02-12 Thread Peter Maydell
On Tue, 12 Feb 2019 at 04:01, Stefan Hajnoczi wrote: > > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into > staging (2019-02-11 17:04:57 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/11/19 10:13 PM, Stefan Berger wrote: > On 2/11/19 3:09 PM, Liam Merwick wrote: >> On 11/02/2019 19:56, Stefan Berger wrote: >>> On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 4:03 PM, Liam Merwick wrote: [...] > -printf("tpm_tis: %s length = %d\n", string, len); >>>

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 12.02.19 13:08, Philippe Mathieu-Daudé wrote: > Hi David, > > On 2/12/19 12:47 PM, David Hildenbrand wrote: >> On 24.01.19 14:20, Gerd Hoffmann wrote: >>> Get rid of the pcspk_state global, allow pc speaker >>> be added using "-device isa-pcspk". >>> >>> Signed-off-by: Gerd Hoffmann >>> Review

Re: [Qemu-devel] [PATCH] hw/arm/armsse: Fix miswiring of expansion IRQs

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 12:06 PM, Peter Maydell wrote: > On Tue, 12 Feb 2019 at 11:05, Philippe Mathieu-Daudé > wrote: >> On 2/12/19 11:52 AM, Peter Maydell wrote: >>> In commit 91c1e9fcbd7548db368 where we added dual-CPU support to >>> the ARMSSE, we set up the wiring of the expansion IRQs via nested >>> loo

[Qemu-devel] [PATCH] Discard old bitmap directories in QCOW2 image

2019-02-12 Thread Andrey Shinkevich
Clean QCOW2 image from bitmap obsolete directory when a new one is allocated and stored. It slows down the image growth a little bit. The flag QCOW2_DISCARD_ALWAYS allows a call to raw_co_pdiscard() that does the actual cleaning of the image on disk. With the flag QCOW2_DISCARD_OTHER, a reference c

Re: [Qemu-devel] [qemu-s390x] [PATCH 09/15] s390-bios: ptr2u32 and u32toptr

2019-02-12 Thread Thomas Huth
On 2019-01-29 14:29, Jason J. Herne wrote: > Introduce inline functions to convert between pointers and unsigned 32-bit > ints. These are used to hide the ugliness required to avoid compiler > warnings. > > Signed-off-by: Jason J. Herne > --- > pc-bios/s390-ccw/libc.h | 12 > 1 fil

Re: [Qemu-devel] [qemu-s390x] [PATCH 08/15] s390-bios: Map low core memory

2019-02-12 Thread Thomas Huth
On 2019-01-29 14:29, Jason J. Herne wrote: > Create a new header for basic architecture specific definitions and add a > mapping of low core memory. This mapping will be used by the real dasd boot > process. > > Signed-off-by: Jason J. Herne > --- > pc-bios/s390-ccw/main.c | 2 + > pc-bio

Re: [Qemu-devel] [PATCH v2 3/4] tests/migration-test: Add a test for ignore-shared capability

2019-02-12 Thread Yury Kotov
11.02.2019, 16:17, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  Signed-off-by: Yury Kotov >>  --- >>   tests/migration-test.c | 109 + >>   1 file changed, 89 insertions(+), 20 deletions(-) >> >>  diff --git a/tests/migrati

[Qemu-devel] [Bug 1808928] Re: Bitmap Extra data is not supported

2019-02-12 Thread Ali Sag
as far as i know nothing happened. it had worked normally while instance was running. For a reason, instance is shutdown, then it never open again. i have some backups, i tried to return previous backups. But they also gave same error. Thanks to replication i could get it back. i copied image from

[Qemu-devel] Key repeat is no longer working on TTY and grub menu

2019-02-12 Thread Leonardo Soares Müller
I noticed that the key inputs are no longer repeating when using default setting on QEMU. For example, if I press "a" and keep it pressed it will print only one "a" instead of repeating them. Another example is when deleting text: instead of holding backspace pressed and the text is deleted, it's n

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 11:39:21AM +0100, Philippe Mathieu-Daudé wrote: > On 2/12/19 8:11 AM, Peter Xu wrote: > > On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S. Tsirkin wrote: > >> > >> OK I reverted the whole part dealing with vhost-user and reposted. > > > > I noticed that the merged pull

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-02-12 Thread Halil Pasic
On Tue, 5 Feb 2019 11:18:38 +0100 Cornelia Huck wrote: > On Mon, 4 Feb 2019 14:29:18 -0500 > Farhan Ali wrote: > > > On 02/04/2019 06:13 AM, Cornelia Huck wrote: > > > On Thu, 31 Jan 2019 12:31:00 -0500 > > > Farhan Ali wrote: > > > > > >> On 01/29/2019 08:29 AM, Jason J. Herne wrote: > >

Re: [Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model

2019-02-12 Thread Cornelia Huck
On Tue, 12 Feb 2019 12:23:23 +0100 David Hildenbrand wrote: > As we now always have PCI support, let's add it to the "qemu" CPU model, > taking care of backwards compatibility. > > Signed-off-by: David Hildenbrand > --- > > v1 -> v2: > - Use correct model identifiction of the z12 we emulate >

Re: [Qemu-devel] Key repeat is no longer working on TTY and grub menu

2019-02-12 Thread Daniel P . Berrangé
On Tue, Feb 12, 2019 at 01:02:42PM +, Leonardo Soares Müller wrote: > I noticed that the key inputs are no longer repeating when using default > setting on QEMU. For example, if I press "a" and keep it pressed it will > print only one "a" instead of repeating them. Another example is when > del

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Stefan Berger
On 2/12/19 7:31 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 10:13 PM, Stefan Berger wrote: On 2/11/19 3:09 PM, Liam Merwick wrote: On 11/02/2019 19:56, Stefan Berger wrote: On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 4:03 PM, Liam Merwick wrote: [...] -printf("tpm_tis

Re: [Qemu-devel] [PULL 00/24] target/hppa patch queue

2019-02-12 Thread Peter Maydell
On Tue, 12 Feb 2019 at 04:57, Richard Henderson wrote: > > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into > staging (2019-02-11 17:04:57 +) > > are available in the Git repository at: >

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 02:15:36PM +0100, Philippe Mathieu-Daudé wrote: > On 2/12/19 2:04 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 12, 2019 at 11:39:21AM +0100, Philippe Mathieu-Daudé wrote: > >> On 2/12/19 8:11 AM, Peter Xu wrote: > >>> On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S. Tsi

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 2:04 PM, Michael S. Tsirkin wrote: > On Tue, Feb 12, 2019 at 11:39:21AM +0100, Philippe Mathieu-Daudé wrote: >> On 2/12/19 8:11 AM, Peter Xu wrote: >>> On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S. Tsirkin wrote: OK I reverted the whole part dealing with vhost-user and r

Re: [Qemu-devel] [PATCH v2] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Greg Kurz
On Tue, 12 Feb 2019 14:01:44 +0800 Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" > introduced extra fields to existing struct virtio_blk_config, when > migration was executed from older QEMU version to current head, it A hint about the breakag

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Liam Merwick
On 12/02/2019 13:27, Stefan Berger wrote: On 2/12/19 7:31 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 10:13 PM, Stefan Berger wrote: On 2/11/19 3:09 PM, Liam Merwick wrote: On 11/02/2019 19:56, Stefan Berger wrote: On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 4:03 PM, Liam

[Qemu-devel] [PATCH 0/4] a few trivials

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Just cleaning out my trivial pile; a few more traces and a couple of error reporting tweaks. Dave Dr. David Alan Gilbert (4): pckbd: Convert DPRINTF->trace HMP: Prepend errors with 'Error:' kvm: Add kvm_set_ioeventfd* traces wavcapture: Convert to error_r

[Qemu-devel] [PATCH 1/4] pckbd: Convert DPRINTF->trace

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- hw/input/pckbd.c | 19 ++- hw/input/trace-events | 7 +++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 72e7d5f6cc..47a606f5e3 100644 -

[Qemu-devel] [PATCH 3/4] kvm: Add kvm_set_ioeventfd* traces

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a couple of traces around the kvm_set_ioeventfd* calls. Signed-off-by: Dr. David Alan Gilbert --- accel/kvm/kvm-all.c| 3 +++ accel/kvm/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 4e1

Re: [Qemu-devel] [PATCH v2] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 02:01:44PM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" > introduced extra fields to existing struct virtio_blk_config, when > migration was executed from older QEMU version to current head, it > will break the mig

[Qemu-devel] [PATCH 2/4] HMP: Prepend errors with 'Error:'

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Always make error messages start with 'Error:' as a fallback to make sure that anything parsing them can tell it failed. Note: Some places don't use hmp_handle_error Signed-off-by: Dr. David Alan Gilbert --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

  1   2   3   4   >