Re: [Qemu-devel] [PULL 1/1] update seabios to master snapshot

2019-02-05 Thread Gerd Hoffmann
On Mon, Feb 04, 2019 at 10:25:34AM -0500, Emilio G. Cota wrote: > On Mon, Feb 04, 2019 at 12:20:33 +0100, Gerd Hoffmann wrote: > > > How can I bisect seabios? I can't find a recipe to generate > > > the .bin files included in this commit. > > > > "make -C roms bios" will build it, using the roms/s

[Qemu-devel] [PATCH v12 01/25] replay: add missing fix for internal function

2019-02-05 Thread Pavel Dovgalyuk
From: pbonz...@redhat.com This is a fix which was missed by patch 74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step parameter to the replay_advance_current_step function. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c |2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging

2019-02-05 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

[Qemu-devel] [PATCH v12 03/25] replay: disable default snapshot for record/replay

2019-02-05 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk --- vl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/vl

[Qemu-devel] [PATCH v12 04/25] replay: update docs for record/replay with block devices

2019-02-05 Thread Pavel Dovgalyuk
This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt b/docs/replay.txt index 3497585f5a..2

[Qemu-devel] [PATCH v12 02/25] block: implement bdrv_snapshot_goto for blkreplay

2019-02-05 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |8 1 file changed, 8 inse

[Qemu-devel] [PATCH v12 05/25] replay: don't drain/flush bdrv queue while RR is working

2019-02-05 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode. This

[Qemu-devel] [PATCH v12 06/25] replay: finish record/replay before closing the disks

2019-02-05 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |2 ++ vl.c|

[Qemu-devel] [PATCH v12 08/25] migration: introduce icount field for snapshots

2019-02-05 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (introduced in one of the

[Qemu-devel] [PATCH v12 12/25] replay: introduce breakpoint at the specified step

2019-02-05 Thread Pavel Dovgalyuk
This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - number of instructions execu

[Qemu-devel] [PATCH v12 07/25] qcow2: introduce icount field for snapshots

2019-02-05 Thread Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v2: - documented format changes in docs/interop/qcow2.txt (suggested by Eric Blake) v10:

[Qemu-devel] [PATCH v12 09/25] replay: provide an accessor for rr filename

2019-02-05 Thread Pavel Dovgalyuk
This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/replay.h |2 ++ replay/replay.c

[Qemu-devel] [PATCH v12 15/25] replay: flush rr queue before loading the vmstate

2019-02-05 Thread Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing t

[Qemu-devel] [PATCH v12 11/25] replay: introduce info hmp/qmp command

2019-02-05 Thread Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the replay_seek/replay_break

[Qemu-devel] [PATCH v12 14/25] replay: refine replay-time module

2019-02-05 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/replay/replay-time.c b/replay/replay-time.c index 0df1693337

[Qemu-devel] [PATCH v12 10/25] qapi: introduce replay.json for record/replay-related stuff

2019-02-05 Thread Pavel Dovgalyuk
This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster -- v10: - minor changes --- MAINTAINERS |1 + Makefile.objs |4 ++-- include/sysemu/rep

[Qemu-devel] [PATCH v12 17/25] gdbstub: add reverse continue support in replay mode

2019-02-05 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were hit

[Qemu-devel] [PATCH v12 18/25] replay: describe reverse debugging in docs/replay.txt

2019-02-05 Thread Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt index 2c2c5f6118..8447fdd35

[Qemu-devel] [PATCH v12 20/25] replay: init rtc after enabling the replay

2019-02-05 Thread Pavel Dovgalyuk
This patch postpones the call of 'configure_rtc' function. This call uses host clock to configure the rtc, but host clock access should be recorded when using icount record/replay mode. Therefore now rtc is configured after switching record/replay mode on. Signed-off-by: Pavel Dovgalyuk --- vl.c

[Qemu-devel] [PATCH v12 13/25] replay: implement replay-seek command

2019-02-05 Thread Pavel Dovgalyuk
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by: Markus Armbruster --

[Qemu-devel] [PATCH v12 24/25] replay: rename step-related variables and functions

2019-02-05 Thread Pavel Dovgalyuk
This patch renames replay_get_current_step() and related variables to make these names consistent with hmp/qmp commands. Signed-off-by: Pavel Dovgalyuk --- blockdev.c|2 +- include/sysemu/replay.h |2 +- migration/savevm.c|2 +- replay/replay-debugging.c |

[Qemu-devel] [PATCH v12 23/25] replay: fix replay shutdown

2019-02-05 Thread Pavel Dovgalyuk
This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call. Signed-off-by: Pavel Dov

[Qemu-devel] [PATCH v12 16/25] gdbstub: add reverse step support in replay mode

2019-02-05 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

[Qemu-devel] [PATCH v12 21/25] replay: document development rules

2019-02-05 Thread Pavel Dovgalyuk
This patch introduces docs/devel/replay.txt which describes the rules that should be followed to make virtual devices usable in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v9: fixed external virtual clock description (reported by Artem Pisarenko) --- docs/devel/replay.txt | 46

[Qemu-devel] [PATCH v12 25/25] icount: clean up cpu_can_io before jumping to the next block

2019-02-05 Thread Pavel Dovgalyuk
Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the next block. This patch res

[Qemu-devel] [PATCH v12 22/25] util/qemu-timer: refactor deadline calculation for external timers

2019-02-05 Thread Pavel Dovgalyuk
icount-based record/replay uses qemu_clock_deadline_ns_all to measure the period until vCPU may be interrupted. This function takes in account the virtual timers, because they belong to the virtual devices that may generate interrupt request or affect the virtual machine state. However, there are a

[Qemu-devel] [PATCH v12 19/25] replay: add BH oneshot event for block layer

2019-02-05 Thread Pavel Dovgalyuk
Replay is capable of recording normal BH events, but sometimes there are single use callbacks scheduled with aio_bh_schedule_oneshot function. This patch enables recording and replaying such callbacks. Block layer uses these events for calling the completion function. Replaying these calls makes th

Re: [Qemu-devel] [Qemu-ppc] 2x-3x tcg performance regression on ppc64 (maybe others)

2019-02-05 Thread Howard Spoelstra
On Fri, Feb 1, 2019 at 11:54 PM Cleber Rosa wrote: > While working on the "boot_linux_console.py" tests, after a given > rebase, I noticed that the ppc64 specific test began timing out. The > original timeout set to the test was 60 seconds, and it "always" had > room to spare when running either

Re: [Qemu-devel] [PATCH 2/2] usb: deal with potential Null pointer returned by usb_ep_get()

2019-02-05 Thread Gerd Hoffmann
On Mon, Feb 04, 2019 at 11:50:33AM +, Liam Merwick wrote: > On 31/01/2019 08:03, Gerd Hoffmann wrote: > > On Wed, Jan 30, 2019 at 02:37:02PM +, Liam Merwick wrote: > > > From: Liam Merwick > > > > > > usb_ep_get() can return a Null pointer in the (albeit unlikely) case > > > that a NULL U

Re: [Qemu-devel] [PATCH v3 4/5] tests/uefi-test-tools: add build scripts

2019-02-05 Thread Laszlo Ersek
On 02/04/19 22:55, Michael S. Tsirkin wrote: > On Mon, Feb 04, 2019 at 08:46:33PM +0100, Philippe Mathieu-Daudé > wrote: >> Hi Michael, >> >> On 2/4/19 8:32 PM, Michael S. Tsirkin wrote: >>> And question would be what if someone wanted a reproducible >>> build of QEMU, what would be the right way

Re: [Qemu-devel] [PATCH] Remove deprecated -no-frame option

2019-02-05 Thread Gerd Hoffmann
On Tue, Feb 05, 2019 at 08:29:29AM +0100, Thomas Huth wrote: > The -no-frame option has been deprecated with QEMU v2.12. It was only > useful with SDL1.2 - now that we've removed support for SDL1.2, we > can certainly remove the -no-frame option, too. Was about to do that too. Luckily I checked m

Re: [Qemu-devel] [PATCH] ui: don't send any event if delta_y == 0

2019-02-05 Thread Gerd Hoffmann
On Mon, Feb 04, 2019 at 01:20:43PM +0100, Sergio Lopez wrote: > When the user raises their fingers from the touchpad, we may receive a > GDK_SMOOTH_SCROLL event with delta_y == 0. Avoid generating a WHEEL_UP > event in this situation. > > Signed-off-by: Sergio Lopez Added to UI queue. thanks,

Re: [Qemu-devel] [PATCH] ui: listen for GDK_SMOOTH_SCROLL events

2019-02-05 Thread Gerd Hoffmann
On Mon, Feb 04, 2019 at 01:08:23PM +0100, Sergio Lopez wrote: > On Wayland, without grabbing focus, two-finger scrolling generates > GDK_SMOOTH_SCROLL events instead of GDK_SCROLL_*, so listen for them. > > Signed-off-by: Sergio Lopez Added to UI queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2] ui/sdl_keysym: Remove obsolete SDL1.2 related code

2019-02-05 Thread Gerd Hoffmann
On Mon, Feb 04, 2019 at 01:10:41PM +0100, Thomas Huth wrote: > sdl_keysym.h has only been included by sdl.c which has recently been > removed recently with this commit: > > 0015ca5cbabe0b31d31610ddfaafd90a9e5911a4 > ("ui: remove support for SDL1.2 in favour of SDL2") > > So we can drop this h

Re: [Qemu-devel] [PATCH v2] checkpatch: Flag suspicious attribution lines

2019-02-05 Thread Cornelia Huck
On Tue, 5 Feb 2019 00:29:14 +0100 Philippe Mathieu-Daudé wrote: > On 2/4/19 11:55 PM, Eric Blake wrote: > > Flag commit attribution tags that are unusual (often because they > > were a typo), but only as a warning (because sometimes a humorous > > or otherwise useful tag is intentionally supplied

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix macOS 10.14 deprecation warnings

2019-02-05 Thread Gerd Hoffmann
On Thu, Jan 31, 2019 at 11:12:25PM -0800, Brendan Shanks wrote: > macOS 10.14 deprecated NSOnState/NSOffState in favour of > NSControlStateValueOn/NSControlStateValueOff. Use the new constants, > and #define them to the old ones when compiling against a pre-10.13 SDK. > Also [NSGraphicsContext grap

[Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-02-05 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature into QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only late

Re: [Qemu-devel] sparc: crash when using initrd > 5M

2019-02-05 Thread Corentin Labbe
On Fri, Feb 01, 2019 at 02:15:15PM +, Mark Cave-Ayland wrote: > On 18/01/2019 13:33, Mark Cave-Ayland wrote: > > > On 03/01/2019 15:48, Corentin Labbe wrote: > > > >> Hello > >> > >> When using an initrd > 5M, I hit the following kernel crash: > >> qemu-system-sparc -kernel vmlinux -initrd ro

Re: [Qemu-devel] [PATCH v2] spice: set device address and device display ID in QXL interface

2019-02-05 Thread Gerd Hoffmann
On Mon, Feb 04, 2019 at 11:08:10AM +0100, Lukáš Hrázký wrote: > Calls the new SPICE QXL interface function spice_qxl_set_device_info to > set the hardware address of the graphics device represented by the QXL > interface (e.g. a PCI path) and the device display IDs (the IDs of the > device's monito

Re: [Qemu-devel] [PATCH v2] ui/egl-helpers: Augment parameter list of egl_texture_blend() to convey scales of viewport

2019-02-05 Thread Gerd Hoffmann
On Fri, Jan 25, 2019 at 03:47:23PM +0800, Chen Zhang wrote: > From 0be823a56682be57fe0370bb91e4062ec7b47be5 Mon Sep 17 00:00:00 2001 > From: Chen Zhang > Date: Fri, 25 Jan 2019 15:33:08 +0800 > Subject: [PATCH v2] ui/egl-helpers: Augment parameter list of > egl_texture_blend() to convey scales of

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/6] s390x/pci: Fix hotplugging of PCI bridges

2019-02-05 Thread Cornelia Huck
On Tue, 5 Feb 2019 00:43:08 +0100 David Hildenbrand wrote: > On 04.02.19 23:48, Collin Walling wrote: > > Side note: unrelated to the changes here -- and if you can clarify for > > me -- any idea why we do s->bus_no += 1? This throws me off a bit and > > begs me to ask what exactly is the S390pc

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 3/6] s390x/pci: Warn when adding PCI devices without the 'zpci' feature

2019-02-05 Thread Cornelia Huck
On Mon, 4 Feb 2019 23:45:35 +0100 David Hildenbrand wrote: > On 04.02.19 23:42, Collin Walling wrote: > > On 2/4/19 4:54 PM, David Hildenbrand wrote: > >> On 04.02.19 21:19, Collin Walling wrote: > >>> On 1/30/19 10:57 AM, David Hildenbrand wrote: > We decided to always create the PCI

Re: [Qemu-devel] [PULL 00/77] Misc patches for 2019-02-04

2019-02-05 Thread Peter Maydell
On Mon, 4 Feb 2019 at 18:38, Paolo Bonzini wrote: > > The following changes since commit 773c4a6228fd910556cee2d477ee56c591a3: > > test-filter-mirror: pass UNIX domain socket through fd (2019-02-04 16:03:20 > +) > > are available in the git repository at: > > git://github.com/bonzini/

Re: [Qemu-devel] [PATCH v2 6/6] s390x/pci: Unplug remaining requested devices on pcihost reset

2019-02-05 Thread Cornelia Huck
On Fri, 1 Feb 2019 16:06:43 +0100 David Hildenbrand wrote: > On 01.02.19 11:19, Cornelia Huck wrote: > > On Wed, 30 Jan 2019 16:57:33 +0100 > > David Hildenbrand wrote: > > > >> When resetting the guest we should unplug and remove all devices that > >> are still pending. > >> > >> With this p

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"

2019-02-05 Thread Thomas Huth
On 2019-02-04 22:04, Philippe Mathieu-Daudé wrote: > In 47973a2dbf we split the last generic chipset out of the PC > board, but forgot to remove the include of "hw/i386/pc.h". > Since it is now unused, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sparc64/sun4u.c | 1 - > 1 fil

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"

2019-02-05 Thread Thomas Huth
On 2019-02-04 22:04, Philippe Mathieu-Daudé wrote: > In 47973a2dbf we split the last generic chipset out of the PC > board, but forgot to remove the include of "hw/i386/pc.h". > Since it is now unused, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/unicore32/puv3.c | 1 - > 1 fi

Re: [Qemu-devel] SeaBIOS regression

2019-02-05 Thread Thomas Huth
On 2019-02-05 08:52, Gerd Hoffmann wrote: > On Mon, Feb 04, 2019 at 04:10:37PM +0100, Thomas Huth wrote: >> >> Hi Gerd, >> >> I noticed that certain FreeDOS images are not working correctly anymore >> with the current version of QEMU, for example >> http://www.qemu-advent-calendar.org/2016/downloa

Re: [Qemu-devel] SeaBIOS regression

2019-02-05 Thread Gerd Hoffmann
On Tue, Feb 05, 2019 at 10:31:24AM +0100, Thomas Huth wrote: > On 2019-02-05 08:52, Gerd Hoffmann wrote: > > On Mon, Feb 04, 2019 at 04:10:37PM +0100, Thomas Huth wrote: > >> > >> Hi Gerd, > >> > >> I noticed that certain FreeDOS images are not working correctly anymore > >> with the current versi

Re: [Qemu-devel] [PATCH v2] spice: set device address and device display ID in QXL interface

2019-02-05 Thread Gerd Hoffmann
On Tue, Feb 05, 2019 at 10:13:28AM +0100, Gerd Hoffmann wrote: > On Mon, Feb 04, 2019 at 11:08:10AM +0100, Lukáš Hrázký wrote: > > Calls the new SPICE QXL interface function spice_qxl_set_device_info to > > set the hardware address of the graphics device represented by the QXL > > interface (e.g. a

Re: [Qemu-devel] SeaBIOS regression

2019-02-05 Thread Thomas Huth
On 2019-02-05 10:42, Gerd Hoffmann wrote: > On Tue, Feb 05, 2019 at 10:31:24AM +0100, Thomas Huth wrote: >> On 2019-02-05 08:52, Gerd Hoffmann wrote: >>> On Mon, Feb 04, 2019 at 04:10:37PM +0100, Thomas Huth wrote: Hi Gerd, I noticed that certain FreeDOS images are not working

Re: [Qemu-devel] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches

2019-02-05 Thread Cornelia Huck
On Wed, 30 Jan 2019 16:57:27 +0100 David Hildenbrand wrote: > These are all the patches that are not yet upstream (@Conny you might > already picked some, including them for the full picture) and after > a good discussion yesterday, including a patch t get rid of the release > timer. I ran a coup

Re: [Qemu-devel] [qemu-s390x] [PATCH 02/15] s390-bios: decouple cio setup from virtio

2019-02-05 Thread Thomas Huth
On 2019-01-29 14:29, Jason J. Herne wrote: > Move channel i/o setup code out to a separate function. This decouples cio > setup from the virtio code path and allows us to make use of it for booting > dasd devices. > > Signed-off-by: Jason J. Herne > Acked-by: Halil Pasic > Reviewed-by: Collin Wa

Re: [Qemu-devel] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches

2019-02-05 Thread David Hildenbrand
On 05.02.19 10:55, Cornelia Huck wrote: > On Wed, 30 Jan 2019 16:57:27 +0100 > David Hildenbrand wrote: > >> These are all the patches that are not yet upstream (@Conny you might >> already picked some, including them for the full picture) and after >> a good discussion yesterday, including a pat

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-05 Thread Kevin Wolf
Am 04.02.2019 um 16:36 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.02.2019 16:45, Markus Armbruster wrote: > > Kevin Wolf writes: > > > >> Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: > >>> Andrey Shinkevich writes: > >>> > In the 'Format specific information' section of

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-02-05 Thread Cornelia Huck
On Mon, 4 Feb 2019 14:29:18 -0500 Farhan Ali wrote: > On 02/04/2019 06:13 AM, Cornelia Huck wrote: > > On Thu, 31 Jan 2019 12:31:00 -0500 > > Farhan Ali wrote: > > > >> On 01/29/2019 08:29 AM, Jason J. Herne wrote: > >>> Add struct for format-0 ccws. Support executing format-0 channel > >>>

Re: [Qemu-devel] [PATCH v3 2/3] util/cutils: Move ctype macros to "cutils.h"

2019-02-05 Thread Cornelia Huck
On Mon, 4 Feb 2019 22:12:03 +0100 Philippe Mathieu-Daudé wrote: > Introduced in cd390083ad1, these macros don't need to be in > a generic header. > Add documentation to justify their use. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Stefano Garzarella > Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH v3 2/3] util/cutils: Move ctype macros to "cutils.h"

2019-02-05 Thread Daniel P . Berrangé
On Tue, Feb 05, 2019 at 11:32:19AM +0100, Cornelia Huck wrote: > On Mon, 4 Feb 2019 22:12:03 +0100 > Philippe Mathieu-Daudé wrote: > > > Introduced in cd390083ad1, these macros don't need to be in > > a generic header. > > Add documentation to justify their use. > > > > Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH v3 3/3] util/cutils: Move function documentations to the header

2019-02-05 Thread Peter Maydell
On Tue, 5 Feb 2019 at 06:44, Markus Armbruster wrote: > There are two justifiable function comment placement styles: (1) next to > definition, and (2) next to declaration if it's in a header, else next > to definition. > > The rationale for the latter is having the headers do double-duty as > inte

[Qemu-devel] [PULL 13/14] keymap: pass full keyboard state to keysym2scancode

2019-02-05 Thread Gerd Hoffmann
Pass the keyboard state tracker handle down to keysym2scancode(), so the code can fully inspect the keyboard state as needed. No functional change. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20190122092814.14919-8-kra...@redhat.com --- ui/keymaps.h | 3 ++- ui/cur

[Qemu-devel] [PULL 11/14] kbd-state: use state tracker for gtk

2019-02-05 Thread Gerd Hoffmann
Use the new keyboard state tracked for gtk. Allows to drop the gtk-specific modifier state tracking code. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20190122092814.14919-6-kra...@redhat.com --- include/ui/gtk.h | 2 ++ ui/gtk.c | 38 ++

[Qemu-devel] [PULL 06/14] ui/egl-helpers: Augment parameter list of egl_texture_blend() to convey scales of viewport

2019-02-05 Thread Gerd Hoffmann
From: Chen Zhang This would help gtk-egl display showing scaled DMABuf cursor images when gtk window was zoomed. A default scale of (1.0, 1.0) was presumed for call sites where no scaling is needed. Signed-off-by: Chen Zhang Message-id: 23b229b3-3095-4dfb-8369-866784808...@me.com Signed-off-by:

[Qemu-devel] [PULL 02/14] ui: don't send any event if delta_y == 0

2019-02-05 Thread Gerd Hoffmann
From: Sergio Lopez When the user raises their fingers from the touchpad, we may receive a GDK_SMOOTH_SCROLL event with delta_y == 0. Avoid generating a WHEEL_UP event in this situation. Signed-off-by: Sergio Lopez Message-id: 20190204122043.43007-1-...@redhat.com Signed-off-by: Gerd Hoffmann -

[Qemu-devel] [PULL 01/14] Remove deprecated -no-frame option

2019-02-05 Thread Gerd Hoffmann
From: Thomas Huth The -no-frame option has been deprecated with QEMU v2.12. It was only useful with SDL1.2 - now that we've removed support for SDL1.2, we can certainly remove the -no-frame option, too. Signed-off-by: Thomas Huth Message-id: 1549351769-19620-1-git-send-email-th...@redhat.com Si

[Qemu-devel] [PULL 00/14] Ui 20190205 patches

2019-02-05 Thread Gerd Hoffmann
The following changes since commit 773c4a6228fd910556cee2d477ee56c591a3: test-filter-mirror: pass UNIX domain socket through fd (2019-02-04 16:03:20 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20190205-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 07/14] kbd-state: add keyboard state tracker

2019-02-05 Thread Gerd Hoffmann
Now that most user interfaces are using QKeyCodes it is easier to have common keyboard code useable by all user interfaces. This patch adds helper code to track the state of all keyboard keys, using a bitmap indexed by QKeyCode. Modifier state is tracked too, as separate bitmap. That makes check

[Qemu-devel] [PULL 12/14] kbd-state: use state tracker for vnc

2019-02-05 Thread Gerd Hoffmann
Use the new keyboard state tracked for vnc. Allows to drop the vnc-specific modifier state tracking code. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20190122092814.14919-7-kra...@redhat.com --- ui/vnc.h | 5 ++- ui/vnc.c | 120 ++-

[Qemu-devel] [PULL 04/14] ui/sdl_keysym: Remove obsolete SDL1.2 related code

2019-02-05 Thread Gerd Hoffmann
From: Thomas Huth sdl_keysym.h has only been included by sdl.c which has recently been removed recently with this commit: 0015ca5cbabe0b31d31610ddfaafd90a9e5911a4 ("ui: remove support for SDL1.2 in favour of SDL2") So we can drop this header file now completely, too. Signed-off-by: Thomas

[Qemu-devel] [PULL 05/14] ui/cocoa.m: Fix macOS 10.14 deprecation warnings

2019-02-05 Thread Gerd Hoffmann
From: Brendan Shanks macOS 10.14 deprecated NSOnState/NSOffState in favour of NSControlStateValueOn/NSControlStateValueOff. Use the new constants, and #define them to the old ones when compiling against a pre-10.13 SDK. Also [NSGraphicsContext graphicsPort] is now deprecated, use [NSGraphicsConte

[Qemu-devel] [PULL 09/14] kbd-state: use state tracker for sdl2

2019-02-05 Thread Gerd Hoffmann
Use the new keyboard state tracked for sdl2. We can drop the modifier state tracking from sdl2. Also keyup code is simpler, the state tracker will take care to not send suspious keyup events to the guest. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20190122092814.1

[Qemu-devel] [PULL 03/14] ui: listen for GDK_SMOOTH_SCROLL events

2019-02-05 Thread Gerd Hoffmann
From: Sergio Lopez On Wayland, without grabbing focus, two-finger scrolling generates GDK_SMOOTH_SCROLL events instead of GDK_SCROLL_*, so listen for them. Signed-off-by: Sergio Lopez Message-id: 20190204120823.41333-1-...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 1 + 1 file cha

[Qemu-devel] [PULL 10/14] sdl2: use only QKeyCode in sdl2_process_key()

2019-02-05 Thread Gerd Hoffmann
Also: sdl2_process_key is never called with scon == NULL. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20190122092814.14919-5-kra...@redhat.com --- ui/sdl2-input.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ui/sdl2-input.c b/ui/sdl2-in

[Qemu-devel] [PULL 14/14] keymap: fix keyup mappings

2019-02-05 Thread Gerd Hoffmann
It is possible that the modifier state on keyup is different from the modifier state on keydown. In that case the keycode lookup can end up with different keys in case multiple keysym -> keycode mappings exist, because it picks the mapping depending on modifier state. To fix that change the looku

[Qemu-devel] [PULL 08/14] sdl2: remove sdl2_reset_keys() function

2019-02-05 Thread Gerd Hoffmann
No users left, dead code. Signed-off-by: Gerd Hoffmann Message-id: 20190122092814.14919-3-kra...@redhat.com --- include/ui/sdl2.h | 1 - ui/sdl2-input.c | 16 2 files changed, 17 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index f6db642b65..71f5cfc6e3 100

Re: [Qemu-devel] [PATCH 00/11] target/xtensa: SMP updates and various fixes

2019-02-05 Thread Peter Maydell
On Mon, 4 Feb 2019 at 19:03, Max Filippov wrote: > > Hi Peter, > > please pull the following series that enables SMP linux support for > xtensa-softmmu. > > The following changes since commit 8b7a3e1e5434b55d7710071b00af97c7086cab7a: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-

Re: [Qemu-devel] [PATCH v3 3/3] util/cutils: Move function documentations to the header

2019-02-05 Thread Daniel P . Berrangé
On Tue, Feb 05, 2019 at 10:56:51AM +, Peter Maydell wrote: > On Tue, 5 Feb 2019 at 06:44, Markus Armbruster wrote: > > There are two justifiable function comment placement styles: (1) next to > > definition, and (2) next to declaration if it's in a header, else next > > to definition. > > > >

[Qemu-devel] [PATCH v4] scripts: use git archive in archive-source

2019-02-05 Thread Gerd Hoffmann
Use git archive to create tarballs of qemu and submodules instead of cloning the repository and the submodules. This is a order of magnitude faster because it doesn't fetch the submodules from the internet each time the script runs. Signed-off-by: Gerd Hoffmann --- scripts/archive-source.sh | 6

Re: [Qemu-devel] [PATCH v4] scripts: use git archive in archive-source

2019-02-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190205112315.23454-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4] scripts: use git archive in archive-source Type: series Message-id: 20190205112315.2

Re: [Qemu-devel] [PULL 00/77] Misc patches for 2019-02-04

2019-02-05 Thread Paolo Bonzini
On 05/02/19 10:35, Peter Maydell wrote: > On Mon, 4 Feb 2019 at 18:38, Paolo Bonzini wrote: >> >> The following changes since commit 773c4a6228fd910556cee2d477ee56c591a3: >> >> test-filter-mirror: pass UNIX domain socket through fd (2019-02-04 >> 16:03:20 +) >> >> are available in the g

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/37] ppc-for-4.0 queue 20190204

2019-02-05 Thread BALATON Zoltan
On Mon, 4 Feb 2019, Peter Maydell wrote: On Mon, 4 Feb 2019 at 09:01, David Gibson wrote: The following changes since commit b3fc0af1ff5e922d4dd7c875394dbd26dc7313b4: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-02-01 17:58:27 +) are available in t

Re: [Qemu-devel] [PATCH v4] scripts: use git archive in archive-source

2019-02-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190205112315.23454-1-kra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Halil Pasic
On Mon, 4 Feb 2019 16:31:02 +0100 Cornelia Huck wrote: > On Thu, 31 Jan 2019 13:34:55 +0100 > Halil Pasic wrote: > > > On Thu, 31 Jan 2019 12:52:20 +0100 > > Cornelia Huck wrote: > > > > > On Wed, 30 Jan 2019 19:51:27 +0100 > > > Halil Pasic wrote: > > > > > > > On Wed, 30 Jan 2019 14:22:

Re: [Qemu-devel] [PATCH v3 2/6] vfio-ccw: rework ssch state handling

2019-02-05 Thread Cornelia Huck
On Mon, 4 Feb 2019 16:29:40 -0500 Eric Farman wrote: > On 01/30/2019 08:22 AM, Cornelia Huck wrote: > > The flow for processing ssch requests can be improved by splitting > > the BUSY state: > > > > - CP_PROCESSING: We reject any user space requests while we are in > >the process of translat

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Cornelia Huck
On Mon, 4 Feb 2019 14:25:34 -0500 Eric Farman wrote: > On 01/30/2019 08:22 AM, Cornelia Huck wrote: > > When we get a solicited interrupt, the start function may have > > been cleared by a csch, but we still have a channel program > > structure allocated. Make it safe to call the cp accessors in

Re: [Qemu-devel] [PATCH v2 3/6] mips: Express dependencies of the r4k platform with kconfig

2019-02-05 Thread Philippe Mathieu-Daudé
On 2/5/19 5:11 AM, Thomas Huth wrote: > On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote: >> This platform use standard PC devices connected to an ISA bus. >> Networking is provided by a ne2000 chipset. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/mips/Kconfig | 10 ++ >> 1 f

Re: [Qemu-devel] [PATCH v2 2/6] mips: Express dependencies of the Jazz machine with kconfig

2019-02-05 Thread Philippe Mathieu-Daudé
On 2/5/19 5:04 AM, Thomas Huth wrote: > On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote: >> The Jazz use the RC4030 Asic to provide an EISA bus and DMA/IRQ. The >> framebuffer display is managed by a G364, the network card is a Sonic >> DP83932. A QLogic ESP216 provides a SCSI bus. >> >> Signed-o

Re: [Qemu-devel] [PATCH v2 6/6] mips: Express dependencies of the Loongson 2E machine with kconfig

2019-02-05 Thread Philippe Mathieu-Daudé
On 2/4/19 9:26 PM, Philippe Mathieu-Daudé wrote: > The Loongson 2E uses a Bonito64 system controller as North Bridge and a > VT82C686 chipset as South Bridge. The network card chipset is a RTL8139D. > > Signed-off-by: Philippe Mathieu-Daudé > --- > default-configs/mips64el-softmmu.mak | 3 --- >

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/37] ppc-for-4.0 queue 20190204

2019-02-05 Thread Philippe Mathieu-Daudé
On 2/5/19 12:46 PM, BALATON Zoltan wrote: > On Mon, 4 Feb 2019, Peter Maydell wrote: >> On Mon, 4 Feb 2019 at 09:01, David Gibson >> wrote: >>> >>> The following changes since commit >>> b3fc0af1ff5e922d4dd7c875394dbd26dc7313b4: >>> >>>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstre

Re: [Qemu-devel] [PATCH v3 3/3] util/cutils: Move function documentations to the header

2019-02-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 05, 2019 at 10:56:51AM +, Peter Maydell wrote: >> On Tue, 5 Feb 2019 at 06:44, Markus Armbruster wrote: >> > There are two justifiable function comment placement styles: (1) next to >> > definition, and (2) next to declaration if it's in a header, els

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Cornelia Huck
On Tue, 5 Feb 2019 12:52:29 +0100 Halil Pasic wrote: > On Mon, 4 Feb 2019 16:31:02 +0100 > Cornelia Huck wrote: > > > On Thu, 31 Jan 2019 13:34:55 +0100 > > Halil Pasic wrote: > > > > > On Thu, 31 Jan 2019 12:52:20 +0100 > > > Cornelia Huck wrote: > > > > > > > On Wed, 30 Jan 2019 19:51

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-05 Thread Peter Maydell
On Tue, 5 Feb 2019 at 01:52, Michael S. Tsirkin wrote: > So I think I fixed the build errors. And who knows maybe > that will fix the runtime ones somehow .. > Could you try pls? Re-pushed to same tag. these failures still remain: unused variable for OSX and the BSDs: tests/vhost-user-test.c:94

Re: [Qemu-devel] [PULL 00/77] Misc patches for 2019-02-04

2019-02-05 Thread Peter Maydell
On Tue, 5 Feb 2019 at 11:27, Paolo Bonzini wrote: > > On 05/02/19 10:35, Peter Maydell wrote: > > On Mon, 4 Feb 2019 at 18:38, Paolo Bonzini wrote: > >> > >> The following changes since commit > >> 773c4a6228fd910556cee2d477ee56c591a3: > >> > >> test-filter-mirror: pass UNIX domain socket

Re: [Qemu-devel] [PATCH] hw/cpu/cluster: Mark the cpu-cluster device with user_creatable = false

2019-02-05 Thread Peter Maydell
On Tue, 5 Feb 2019 at 12:58, Thomas Huth wrote: > > The device can not be instantiated by the user and QEMU currently > aborts when you try to use it: > > $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster > qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: > Assertion `cbdata.cp

[Qemu-devel] [PATCH] mips: implement qmp query-cpu-definitions command

2019-02-05 Thread Pavel Dovgalyuk
This patch enables QMP-based querying of the available CPU types for MIPS and MIPS64 platforms. Signed-off-by: Pavel Dovgalyuk --- monitor.c|2 +- target/mips/helper.c | 33 + 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/monitor

[Qemu-devel] [PATCH] hw/cpu/cluster: Mark the cpu-cluster device with user_creatable = false

2019-02-05 Thread Thomas Huth
The device can not be instantiated by the user and QEMU currently aborts when you try to use it: $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: Assertion `cbdata.cpu_count > 0' failed. Aborted (core dumped) Since this is an i

Re: [Qemu-devel] [PATCH] configure: Avoid non-portable 'test -o/-a'

2019-02-05 Thread Peter Maydell
On Tue, 5 Feb 2019 at 02:46, Eric Blake wrote: > > POSIX says that it is better to use &&/|| and two separate test > invocations than it is to try and use -a and -o (in fact, there > are some tests that are inherently ambiguous to parse if the > user passes in corner-case input like "("). > > Sinc

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2019 13:00, Kevin Wolf wrote: > Am 04.02.2019 um 16:36 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 04.02.2019 16:45, Markus Armbruster wrote: >>> Kevin Wolf writes: >>> Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: > Andrey Shinkevich writes: > >> In the 'F

Re: [Qemu-devel] [PATCH v2 01/18] tests/vm: Be verbose while extracting compressed images

2019-02-05 Thread Peter Maydell
On Tue, 29 Jan 2019 at 17:54, Philippe Mathieu-Daudé wrote: > > Depending of the host hardware, copying and extracting VM images can > take up to few minutes. Add verbosity to avoid the user to worry about > VMs hanging. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/vm/centos | 3 ++-

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-05 Thread Peter Maydell
On Tue, 29 Jan 2019 at 17:57, Philippe Mathieu-Daudé wrote: > > Various iotests scripts (run via 'make check-block') use bash > specific extentions. OpenBSD comes with the Korn shell as default. > Install bash to be able to run those tests. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tes

Re: [Qemu-devel] [PATCH] hw/cpu/cluster: Mark the cpu-cluster device with user_creatable = false

2019-02-05 Thread Thomas Huth
On 2019-02-05 14:09, Peter Maydell wrote: > On Tue, 5 Feb 2019 at 12:58, Thomas Huth wrote: >> >> The device can not be instantiated by the user and QEMU currently >> aborts when you try to use it: >> >> $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster >> qemu-system-x86_64: hw/cpu/cluster.

Re: [Qemu-devel] [PATCH v2 14/18] tests/vm: Run tests on OpenBSD

2019-02-05 Thread Peter Maydell
On Tue, 29 Jan 2019 at 17:59, Philippe Mathieu-Daudé wrote: > > Now than failing tests are commented out, let's reenable the testing > of this OS. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/vm/openbsd | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tests/

  1   2   3   4   5   >