On Tue, 29 Jan 2019 at 17:57, Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
>
> Various iotests scripts (run via 'make check-block') use bash
> specific extentions. OpenBSD comes with the Korn shell as default.
> Install bash to be able to run those tests.
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> ---
> tests/vm/openbsd | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/vm/openbsd b/tests/vm/openbsd
> index 6263c8956b..e9c2a3f2c8 100755
> --- a/tests/vm/openbsd
> +++ b/tests/vm/openbsd
> @@ -45,6 +45,8 @@ class OpenBSDVM(basevm.BaseVM):
> self.wait_ssh()
> sys.stderr.write("Disabling W^X on the build partition...\n")
> self.ssh_root_check("sed -E -i 's_(/tmp\ ffs)\ ([^\ ]*)_\\1
> \\2,wxallowed_' /etc/fstab")
> + sys.stderr.write("Installing bash...\n")
> +
> self.ssh_root_check("PKG_PATH=https://ftp.openbsd.org/pub/OpenBSD/6.1/packages/amd64
> pkg_add bash")
> self.ssh_root("shutdown -p now")
> self.wait()
>
Wouldn't it make more sense to just update the image to include
the necessary package, the same way we do with all QEMU's
other build dependencies ?
thanks
-- PMM
