[Qemu-devel] [PATCH v2 1/9] net: Introduce announce timer

2019-01-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'announce timer' will be used by migration, and explicit requests for qemu to perform network announces. Based on the work by Germano Veit Michel and Vlad Yasevich Signed-off-by: Dr. David Alan Gilbert --- include/net/announce.h | 39

[Qemu-devel] [PATCH v2 7/9] qmp: Add announce-self command

2019-01-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a qmp command that can trigger guest announcements. It uses its own announce-timer instance, and parameters passed to it explicitly in the command. Like most qmp commands, it's in the main thread/bql, so there's no racing with any outstanding timer. Based on

Re: [Qemu-devel] [PATCH v6 65/73] s390x: convert to cpu_has_work_with_iothread_lock

2019-01-30 Thread Cornelia Huck
On Tue, 29 Jan 2019 19:48:03 -0500 "Emilio G. Cota" wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: Cornelia Huck > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > target/s390x/cpu.c | 4 +++- > 1 fi

[Qemu-devel] [PATCH v2 6/9] virtio-net: Allow qemu_announce_self to trigger virtio announcements

2019-01-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Expose the virtio-net self announcement capability and allow qemu_announce_self() to call it. These announces are caused by something external (i.e. the announce-self command); they won't trigger if the migration counter is triggering announces at the same time. S

[Qemu-devel] [PATCH v2 3/9] virtio-net: Switch to using announce timer

2019-01-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Switch virtio's self announcement to use the AnnounceTimer. It keeps it's own AnnounceTimer (per device), and starts running it using a migration post-load and a virtual clock; that way the announce happens once the guest is actually running. The timer uses the migr

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 09:06:30AM +0100, Erik Skultety wrote: > Thanks for ^this bit which helped me understand the bits below. When I read > the > man page yesterday the first question was, okay, how do I figure out whether > the file capabilities bit is set? Well, use xattrs...which didn't retu

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/3] util/cutils: Move ctype macros to "cutils.h"

2019-01-30 Thread Laurent Vivier
On 30/01/2019 11:24, Laurent Vivier wrote: > On 04/01/2019 19:12, Philippe Mathieu-Daudé wrote: >> Introduced in cd390083ad1, these macros don't need to be in >> a generic header. >> Add documentation to justify their use. >> >> Reviewed-by: Stefano Garzarella >> Signed-off-by: Philippe Mathieu-Da

[Qemu-devel] [PATCH v2 8/9] hmp: Add hmp_announce_self

2019-01-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add an HMP command to trigger self annocements. Unlike the QMP command (which takes a set of parameters), the HMP command reuses the set of parameters used for migration. Signend-off-by: Vladislav Yasevich Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.h

[Qemu-devel] [PATCH v2 9/9] tests: Add a test for qemu self announcements

2019-01-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We now expose qemu_announce_self through QMP and HMP. Add a test with some very basic packet validation (make sure we get a RARP). Signed-off-by: Vlad Yasevich Signed-off-by: Dr. David Alan Gilbert --- tests/Makefile.include | 2 + tests/test-announce-self

Re: [Qemu-devel] [PATCH v2 2/9] migration: Add announce parameters

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 10:32:29AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add migration parameters that control RARP/GARP announcement timeouts. > > Based on earlier patches by myself and > Vladislav Yasevich > > Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v2 4/9] migration: Switch to using announce timer

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 10:32:31AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Switch the announcements to using the new announce timer. > Move the code that does it to announce.c rather than savevm > because it really has nothing to do with the actual migratio

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-25 11:07, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > Reviewed-by: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > default-configs/i386-softmmu.mak | 9 - > hw/audio/Kconfig

Re: [Qemu-devel] [PATCH v2 2/9] migration: Add announce parameters

2019-01-30 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Jan 30, 2019 at 10:32:29AM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Add migration parameters that control RARP/GARP announcement timeouts. > > > > Based on earlier patches by myself and > >

Re: [Qemu-devel] [PATCH v2] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-30 Thread Cornelia Huck
On Mon, 28 Jan 2019 15:28:37 -0500 Tony Krowiak wrote: > Introduces hot plug/unplug support for the vfio-ap device. Note that only one > vfio-ap device can be attached to the ap-bus, so a vfio-ap device can only be > hot plugged if the '-device vfio-ap,sysfsdev=$path_to_mdev' option is not > spec

Re: [Qemu-devel] [PATCH v2 2/9] migration: Add announce parameters

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 10:54:04AM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, Jan 30, 2019 at 10:32:29AM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Add migration parameters that control

Re: [Qemu-devel] [RFC PATCH 1/5] ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig

2019-01-30 Thread Cédric Le Goater
On 1/30/19 10:43 AM, Thomas Huth wrote: > The POWERNV switch should always select ISA_IPMI_BT, then the other > IPMI options are turned on automatically now. > CONFIG_DIMM should always be selected by the pseries machine, > which in turn depends on CONFIG_MEM_DEVICE since DIMM implements > this int

Re: [Qemu-devel] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-30 11:25, Thomas Huth wrote: > On 2019-01-30 11:17, Paolo Bonzini wrote: >> On 30/01/19 10:43, Thomas Huth wrote: >>> +select LSI_SCSI_PCI >> >> Should NE2000_ISA and LSI_SCSI_PCI be handled the same? Either rely on >> "default y" for both, or select both (I think I prefer the forme

Re: [Qemu-devel] [RFC PATCH 0/5] Kconfig dependencies for ppc machines

2019-01-30 Thread Yang Zhong
On Wed, Jan 30, 2019 at 10:43:02AM +0100, Thomas Huth wrote: > Here's now my stab at expressing the ppc machine dependencies with > Kconfig. I've carefully stepped through the dependencies and tried to > built each machine separately (which should be possible now, apart > from some few quirks like

Re: [Qemu-devel] [RFC PATCH 1/5] ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-30 12:00, Cédric Le Goater wrote: > On 1/30/19 10:43 AM, Thomas Huth wrote: >> The POWERNV switch should always select ISA_IPMI_BT, then the other >> IPMI options are turned on automatically now. >> CONFIG_DIMM should always be selected by the pseries machine, >> which in turn depends on

Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-30 Thread Philippe Mathieu-Daudé
On 1/30/19 10:50 AM, Thomas Huth wrote: > On 2019-01-30 01:06, Wei Yang wrote: >> Function pc_acpi_init() is not used anymore. >> >> Remove the definition and declaration. >> >> Signed-off-by: Wei Yang >> Reviewed-by: Philippe Mathieu-Daud茅 >> Tested-by: Philippe Mathieu-Daud茅 > > Hi, > > at

Re: [Qemu-devel] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig

2019-01-30 Thread Paolo Bonzini
On 30/01/19 11:25, Thomas Huth wrote: > On 2019-01-30 11:17, Paolo Bonzini wrote: >> On 30/01/19 10:43, Thomas Huth wrote: >>> +select LSI_SCSI_PCI >> >> Should NE2000_ISA and LSI_SCSI_PCI be handled the same? Either rely on >> "default y" for both, or select both (I think I prefer the former)

Re: [Qemu-devel] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig

2019-01-30 Thread Paolo Bonzini
On 30/01/19 12:02, Thomas Huth wrote: > On 2019-01-30 11:25, Thomas Huth wrote: >> On 2019-01-30 11:17, Paolo Bonzini wrote: >>> On 30/01/19 10:43, Thomas Huth wrote: +select LSI_SCSI_PCI >>> >>> Should NE2000_ISA and LSI_SCSI_PCI be handled the same? Either rely on >>> "default y" for bo

Re: [Qemu-devel] [RFC PATCH 1/5] ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig

2019-01-30 Thread Cédric Le Goater
On 1/30/19 12:04 PM, Thomas Huth wrote: > On 2019-01-30 12:00, Cédric Le Goater wrote: >> On 1/30/19 10:43 AM, Thomas Huth wrote: >>> The POWERNV switch should always select ISA_IPMI_BT, then the other >>> IPMI options are turned on automatically now. >>> CONFIG_DIMM should always be selected by th

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Paolo Bonzini
On 30/01/19 11:53, Thomas Huth wrote: >> diff --git a/hw/watchdog/Kconfig b/hw/watchdog/Kconfig >> index edb3d42..35ccb72 100644 >> --- a/hw/watchdog/Kconfig >> +++ b/hw/watchdog/Kconfig >> @@ -8,6 +8,8 @@ config WDT_IB6300ESB >> >> config WDT_IB700 >> bool >> +default y >> +depends

Re: [Qemu-devel] [PATCH] hw/m68k/mcf5208: Support loading of bios images

2019-01-30 Thread Philippe Mathieu-Daudé
Hi Thomas, On 1/29/19 11:19 PM, Thomas Huth wrote: > The MCF5208EVB supports 2 MiB of flash at address 0. Add support > for this memory region and some code to load the file that can > be specified with the "-bios" command line option. > This can be used for example to load U-Boot images for the >

Re: [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument

2019-01-30 Thread Philippe Mathieu-Daudé
On 1/30/19 4:02 AM, Wei Yang wrote: > The second argument of build_facs() is not used, just remove it. > > Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > hw/i386/acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH v4] s390x: remove direct reference to mem_path global from s390x code

2019-01-30 Thread David Hildenbrand
On 30.01.19 10:41, Cornelia Huck wrote: > On Wed, 30 Jan 2019 08:55:06 +0100 > Igor Mammedov wrote: > >> I plan to deprecate -mem-path option and replace it with memory-backend, >> for that it's necessary to get rid of mem_path global variable. >> Do it for s390x case, replacing it with alternati

Re: [Qemu-devel] [RFC PATCH 4/5] ppc: Express dependencies of the Sam460EX machines with kconfig

2019-01-30 Thread BALATON Zoltan
Hello, On Wed, 30 Jan 2019, Thomas Huth wrote: Most of the dependencies are now directly selected by the SAM460EX switch. We can drop CONFIG_VGA_CIRRUS since this device is already selected automatically when CONFIG_PCI_DEVICES is set. Cc: BALATON Zoltan Signed-off-by: Thomas Huth --- default

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-30 12:13, Paolo Bonzini wrote: > On 30/01/19 11:53, Thomas Huth wrote: >>> diff --git a/hw/watchdog/Kconfig b/hw/watchdog/Kconfig >>> index edb3d42..35ccb72 100644 >>> --- a/hw/watchdog/Kconfig >>> +++ b/hw/watchdog/Kconfig >>> @@ -8,6 +8,8 @@ config WDT_IB6300ESB >>> >>> config WDT_I

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: Don't use empty string as device id

2019-01-30 Thread Kevin Wolf
Am 29.01.2019 um 17:37 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > scsi-disk includes in the Device Identification VPD page, depending on > > configuration amongst others, a vendor specific designator that consists > > either of the serial number if given or the BlockBackend nam

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2019-01-30 Thread BALATON Zoltan
On Wed, 30 Jan 2019, Mark Cave-Ayland wrote: On 29/01/2019 23:05, Richard Henderson wrote: On 1/29/19 11:17 AM, Mark Cave-Ayland wrote: +#define VMRG_DO(name, element, access, ofs) \ void helper_v##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \ {

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Paolo Bonzini
On 30/01/19 12:32, Thomas Huth wrote: > Oh, I thought this was for convenience. So for s390x, the main problem is > AFAIK that the architecture does not support LSI, so all devices that > require LSI can not work here. Maybe we should introduce a "LSI" switch > instead, so that the boards which pro

[Qemu-devel] [PATCH RESEND] tcg: add early clober modifier in atomic16_cmpxchg on aarch64

2019-01-30 Thread Catherine Ho
Without this patch, gcc might mess up the Input/Output registers and cause unpredictable error. Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128") Signed-off-by: Catherine Ho --- Resend: sent previous patch before subscribing maillist include/qemu/atomic128.h | 2 +- 1 file changed

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-25 11:07, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > Reviewed-by: Thomas Huth > Signed-off-by: Paolo Bonzini > --- [...] > diff --git a/hw/net/Kconfig b/hw/net/Kconfig > index d50e301..

[Qemu-devel] [PATCH v4 2/4] configure: LM32 Milkymist Texture Mapping Unit (tmu2) also depends of X11

2019-01-30 Thread Philippe Mathieu-Daudé
Commit 5f9b1e35060b8 remove the dependency between OpenGL and X11. However the milkymist-tmu2 device do require X11. When using SDL, the configure script sets need_x11=yes, so the X11 flags are populated to the makefiles. When building without SDL, X11 is not pulled and populated, leading to a link

[Qemu-devel] [PATCH v4 1/4] hw/display: Move Milkymist specific hardware out of common-obj list

2019-01-30 Thread Philippe Mathieu-Daudé
The Milkymist specific hardware is only used by the LM32 target, it is pointless to compile those objects in other targets. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/Makefile.objs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/Makefile.objs b/hw/dis

[Qemu-devel] [PATCH v4 0/4] Milkymist: Allow building on OpenBSD (without SDL)

2019-01-30 Thread Philippe Mathieu-Daudé
since v3: - simply move LM32 'display' specific hardware (Gerd) - drop ./configure patch (Gerd) since v2: - move LM32 specific hardware out of common-obj to bypass make rules limitations - use "WARNING" string in configure v1 was too simple to work, so here we go again. I hit a problem with the M

[Qemu-devel] [PATCH v4 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source

2019-01-30 Thread Philippe Mathieu-Daudé
Move the complexity of milkymist_tmu2_create() into the source file. Doing so we avoid to include the X11/OpenGL headers in all LM32 devices, and we also avoid the duplicate declaration of glx_fbconfig_attr[] (it is already declared in hw/display/milkymist-tmu2.c). Since TYPE_MILKYMIST_TMU2 is now

[Qemu-devel] [PATCH v4 3/4] hw/display/milkymist-tmu2: Explicit the dependency to both X11 / OpenGL

2019-01-30 Thread Philippe Mathieu-Daudé
The TMU device requires both X11 and OpenGL. Signed-off-by: Philippe Mathieu-Daudé --- default-configs/lm32-softmmu.mak | 2 +- hw/display/Makefile.objs | 4 ++-- hw/lm32/milkymist-hw.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/default-configs/lm3

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Yang Zhong
On Wed, Jan 30, 2019 at 12:58:23PM +0100, Thomas Huth wrote: > On 2019-01-25 11:07, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Yang Zhong > > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > > Reviewed-by: Thomas Huth > > Signed-off-by: Paolo Bonzini > >

Re: [Qemu-devel] [PATCH v2 2/9] migration: Add announce parameters

2019-01-30 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Jan 30, 2019 at 10:54:04AM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Wed, Jan 30, 2019 at 10:32:29AM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan

Re: [Qemu-devel] [PATCH] scripts: use git archive in archive-source

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 07:55:30AM +0100, Gerd Hoffmann wrote: > Use git archive to create tarballs of qemu and submodules instead of > cloning the repository and the submodules. This is a order of magnitude > faster because it doesn't fetch the submodules from the internet each > time the script

Re: [Qemu-devel] [RFC PATCH 4/5] ppc: Express dependencies of the Sam460EX machines with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-30 12:29, BALATON Zoltan wrote: > Hello, > > On Wed, 30 Jan 2019, Thomas Huth wrote: >> Most of the dependencies are now directly selected by the SAM460EX >> switch. We can drop CONFIG_VGA_CIRRUS since this device is already >> selected automatically when CONFIG_PCI_DEVICES is set. >> >

Re: [Qemu-devel] [PATCH 02/52] ide: split ioport registration to a separate file

2019-01-30 Thread Thomas Huth
On 2019-01-25 11:06, Paolo Bonzini wrote: > This is not needed on ARM, and brings in ISA bus code which is otherwise not > necessary. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/Makefile.objs | 6 ++--- > hw/ide/core.c| 25 > hw/ide/ioport.c | 67 > +++

[Qemu-devel] [PATCH v11 4/4] tests: Add migration multifd test

2019-01-30 Thread Juan Quintela
We set the x-multifd-page-count and x-multifd-channels. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- tests/migration-test.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c ind

[Qemu-devel] [PATCH v11 1/4] tests: Add migration xbzrle test

2019-01-30 Thread Juan Quintela
Reviewed-by: Peter Xu Signed-off-by: Juan Quintela --- tests/migration-test.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 8352612364..b0670efde7 100644 --- a/tests/migration-test.c +++ b/tes

[Qemu-devel] [PATCH v11 3/4] tests: Add basic migration precopy tcp test

2019-01-30 Thread Juan Quintela
Not sharing code from precopy/unix because we have to read back the tcp parameter. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Juan Quintela --- tests/migration-test.c | 109 +++-- 1 file changed, 104 insertions(+), 5 deletions(-

[Qemu-devel] [PATCH v11 2/4] migration: Create socket-address parameter

2019-01-30 Thread Juan Quintela
It will be used to store the uri parameters. We want this only for tcp, so we don't set it for other uris. We need it to know what port is migration running. Signed-off-by: Juan Quintela -- This used to be uri parameter, but it has so many troubles to reproduce that it don't just make sense.

[Qemu-devel] [PATCH v11 0/4] Add make check tests for Migration

2019-01-30 Thread Juan Quintela
Iv v11: - Rebase to lastest - Remove the compress test. It didin't worked really. See my next series. - Only patch missing review-by is the second one. Please, consider them. In v10: - rebase to latest upstream - code changed quite a bit with qmp refactorings apllied them - make it work agai

Re: [Qemu-devel] [PATCH 02/52] ide: split ioport registration to a separate file

2019-01-30 Thread Paolo Bonzini
On 30/01/19 13:07, Thomas Huth wrote: > I think adding ioport.o to IDE_PCI and IDE_VIA is wrong. The > ide_init_ioport() function is only used by isa.c and piix.c, so it > should only be added for IDE_ISA and IDE_PIIX here. Good idea, another one for Yang. :) Paolo

Re: [Qemu-devel] [PATCH v4] s390x: remove direct reference to mem_path global from s390x code

2019-01-30 Thread Cornelia Huck
On Wed, 30 Jan 2019 12:18:44 +0100 David Hildenbrand wrote: > On 30.01.19 10:41, Cornelia Huck wrote: > > On Wed, 30 Jan 2019 08:55:06 +0100 > > Igor Mammedov wrote: > > > >> I plan to deprecate -mem-path option and replace it with memory-backend, > >> for that it's necessary to get rid of me

Re: [Qemu-devel] [PATCH v1] pc: Use hotplug_handler_(plug|unplug|unplug_request)

2019-01-30 Thread David Hildenbrand
On 14.12.18 10:58, Paolo Bonzini wrote: > On 12/12/18 10:57, David Hildenbrand wrote: >> Let's avoid manually looking up the hotplug handler class. Use the >> existing wrappers instead. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/i386/pc.c | 30 -- >> 1 file ch

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Drop unused parameters from fdt building helper

2019-01-30 Thread Greg Kurz
On Wed, 30 Jan 2019 12:42:16 +1100 Alexey Kardashevskiy wrote: > spapr_load_rtas() handles now RTAS address and size information in the FDT > so drop them from spapr_build_fdt(). > > While we are here, fix a small typo. > > Fixes: 2cac78c12ade9 "pseries: Consolidate RTAS loading" One nit. The

Re: [Qemu-devel] [PATCH v8 0/2] qemu-img info lists bitmap directory entries

2019-01-30 Thread Eric Blake
On 1/30/19 2:00 AM, Vladimir Sementsov-Ogievskiy wrote: >> So, I'm trying to test this, and I've discovered something rather >> annoying about persistent snapshots: they DON'T get written to disk >> until the qemu process exits. In other words, even after creating a >> persistent bitmap via QMP (

Re: [Qemu-devel] [PATCH v4 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2019-01-30 Thread Richard Henderson
On 1/29/19 9:10 PM, Mark Cave-Ayland wrote: >> So... the point of "half" was to not replicate knowledge out to VMRG. >> Just use >> >> int i, half = ARRAY_SIZE(r->element) / 2; >> for (i = 0; i < half; i++) { >> >> within VMRG_DO. > > Okay - I was a bit confused because in your example mac

[Qemu-devel] [Issues] PCI hotplug does not work well on pc platform?

2019-01-30 Thread Liu, Jing2
Hi everyone, I have two questions. 1. PCI hotplug on pci.0 must manually rescan in guest. The ACPI hotplug handler sends the GPE event to guest but it seems guest doesn't receive it? I tried to open ACPI debug level/layer to 0x, in order to see if there is any message after device_add

Re: [Qemu-devel] [Qemu-block] [PATCH v12 00/31] block: Fix some filename generation issues

2019-01-30 Thread Max Reitz
On 29.01.19 21:51, John Snow wrote: > > > On 12/17/18 5:43 PM, Max Reitz wrote: >> Once more, I’ll spare both me and you another iteration of the cover >> letter, so I direct you to the previous version’s cover letter (which >> will direct you further): >> >> http://lists.nongnu.org/archive/html/

Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-30 Thread Wei Yang
On Wed, Jan 30, 2019 at 12:07:02PM +0100, Philippe Mathieu-Daudé wrote: >On 1/30/19 10:50 AM, Thomas Huth wrote: >> On 2019-01-30 01:06, Wei Yang wrote: >>> Function pc_acpi_init() is not used anymore. >>> >>> Remove the definition and declaration. >>> >>> Signed-off-by: Wei Yang >>> Reviewed-by:

Re: [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument

2019-01-30 Thread Wei Yang
On Wed, Jan 30, 2019 at 12:15:57PM +0100, Philippe Mathieu-Daudé wrote: >On 1/30/19 4:02 AM, Wei Yang wrote: >> The second argument of build_facs() is not used, just remove it. >> >> Signed-off-by: Wei Yang > >Reviewed-by: Philippe Mathieu-Daudé >Tested-by: Philippe Mathieu-Daudé Thanks :-) >

Re: [Qemu-devel] [PATCH 02/52] ide: split ioport registration to a separate file

2019-01-30 Thread Yang Zhong
On Wed, Jan 30, 2019 at 01:20:42PM +0100, Paolo Bonzini wrote: > On 30/01/19 13:07, Thomas Huth wrote: > > I think adding ioport.o to IDE_PCI and IDE_VIA is wrong. The > > ide_init_ioport() function is only used by isa.c and piix.c, so it > > should only be added for IDE_ISA and IDE_PIIX here. > >

Re: [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS

2019-01-30 Thread Max Reitz
On 29.01.19 22:26, John Snow wrote: > > > On 1/23/19 9:46 AM, Max Reitz wrote: >> With IMGOPTSSYNTAX, $TEST_IMG is useless for this test (it only tests >> the file-posix protocol driver). Therefore, if $TEST_IMG_FILE is set, >> use that instead. >> >> Because this test requires the file protocol

Re: [Qemu-devel] [PATCH 5/9] iotests: Fix 237 for Python 2.x

2019-01-30 Thread Max Reitz
On 29.01.19 22:21, John Snow wrote: > > On 1/23/19 9:46 AM, Max Reitz wrote: >> It is not quite clear whether we want to support Python 2.x for any >> prolonged time, but this may as well be fixed along with the other >> issues some iotests have right now. >> > > I'd have shuffled this above patc

Re: [Qemu-devel] [PATCH v1] pc: Use hotplug_handler_(plug|unplug|unplug_request)

2019-01-30 Thread Paolo Bonzini
On 30/01/19 13:35, David Hildenbrand wrote: > On 14.12.18 10:58, Paolo Bonzini wrote: >> On 12/12/18 10:57, David Hildenbrand wrote: >>> Let's avoid manually looking up the hotplug handler class. Use the >>> existing wrappers instead. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>> hw/i386/p

Re: [Qemu-devel] [PATCH] hw/m68k/mcf5208: Support loading of bios images

2019-01-30 Thread Thomas Huth
On 2019-01-30 12:15, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 1/29/19 11:19 PM, Thomas Huth wrote: >> The MCF5208EVB supports 2 MiB of flash at address 0. Add support >> for this memory region and some code to load the file that can >> be specified with the "-bios" command line option. >>

[Qemu-devel] [PATCH v3 0/6] vfio-ccw: support hsch/csch (kernel part)

2019-01-30 Thread Cornelia Huck
[This is the Linux kernel part, git tree is available at https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git vfio-ccw-eagain-caps-v3 The companion QEMU patches are available at https://github.com/cohuck/qemu vfio-ccw-caps This is the previously posted v2 version, which should con

Re: [Qemu-devel] [PATCH 4/9] iotests: Fix 207 to use QMP filters for qmp_log

2019-01-30 Thread Max Reitz
On 29.01.19 22:31, John Snow wrote: > > > On 1/23/19 9:46 AM, Max Reitz wrote: >> Fixes: 08fcd6111e1949f456e1b232ebeeb0cc17019a92 >> Signed-off-by: Max Reitz > > Commit message is a bit barren, feel free to blame me for not realizing > that non-qcow2 tests used the feature I was rewriting. I ma

[Qemu-devel] [PATCH v3 4/6] vfio-ccw: add capabilities chain

2019-01-30 Thread Cornelia Huck
Allow to extend the regions used by vfio-ccw. The first user will be handling of halt and clear subchannel. Signed-off-by: Cornelia Huck --- drivers/s390/cio/vfio_ccw_ops.c | 181 drivers/s390/cio/vfio_ccw_private.h | 38 ++ include/uapi/linux/vfio.h

[Qemu-devel] [PATCH v3 2/6] vfio-ccw: rework ssch state handling

2019-01-30 Thread Cornelia Huck
The flow for processing ssch requests can be improved by splitting the BUSY state: - CP_PROCESSING: We reject any user space requests while we are in the process of translating a channel program and submitting it to the hardware. Use -EAGAIN to signal user space that it should retry the requ

[Qemu-devel] [PATCH v3 5/6] s390/cio: export hsch to modules

2019-01-30 Thread Cornelia Huck
The vfio-ccw code will need this, and it matches treatment of ssch and csch. Reviewed-by: Pierre Morel Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- drivers/s390/cio/ioasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s390/cio/ioasm.c b/drivers/s390/cio/ioasm.c inde

[Qemu-devel] [PATCH v3 3/6] vfio-ccw: protect the I/O region

2019-01-30 Thread Cornelia Huck
Introduce a mutex to disallow concurrent reads or writes to the I/O region. This makes sure that the data the kernel or user space see is always consistent. The same mutex will be used to protect the async region as well. Signed-off-by: Cornelia Huck --- drivers/s390/cio/vfio_ccw_drv.c | 3

[Qemu-devel] [PULL 02/13] typo: apci->acpi

2019-01-30 Thread Laurent Vivier
From: "Dr. David Alan Gilbert" apci_1_compatible should be acpi_1_compatible. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190125094047.22276-1-dgilb...@redhat.com> Signed-off-by: Laurent Vivier --- hw/acpi/cpu.c

[Qemu-devel] [PULL 03/13] hw: input: set category of the i8042 device

2019-01-30 Thread Laurent Vivier
From: kumar sourav Sets the category of i8042 device as DEVICE_CATEGORY_INPUT Devices should be assigned to one of DEVICE_CATEGORY_. Signed-off-by: kumar sourav Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-Id: <20190125151440.13794-

[Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-01-30 Thread Cornelia Huck
When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make it safe to call the cp accessors in any case, so we can call them unconditionally. While at it, also make sure that functions called from other parts

[Qemu-devel] [PULL 04/13] hw: sd: set category of the sd memory card

2019-01-30 Thread Laurent Vivier
From: kumar sourav Sets the category of the sd memory card as DEVICE_CATEGORY_STORAGE. Devices should be assigned to one of DEVICE_CATEGORY_. Signed-off-by: kumar sourav Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20190124162045.10474-1-sourav.jb1...@gmail.co

[Qemu-devel] [PULL 00/13] Trivial branch patches

2019-01-30 Thread Laurent Vivier
The following changes since commit b4fbe1f65a4769c09e6bf2d79fc84360f840f40e: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190129' into staging (2019-01-29 12:00:19 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pu

[Qemu-devel] [PULL 10/13] target/s390x: Fix LGPL version in the file header comments

2019-01-30 Thread Laurent Vivier
From: Thomas Huth It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Message-Id:

[Qemu-devel] [PATCH v3 6/6] vfio-ccw: add handling for async channel instructions

2019-01-30 Thread Cornelia Huck
Add a region to the vfio-ccw device that can be used to submit asynchronous I/O instructions. ssch continues to be handled by the existing I/O region; the new region handles hsch and csch. Interrupt status continues to be reported through the same channels as for ssch. Signed-off-by: Cornelia Huc

[Qemu-devel] [PULL 13/13] virtio-blk: remove duplicate definition of VirtIOBlock *s pointer

2019-01-30 Thread Laurent Vivier
From: Stefano Garzarella VirtIOBlock *s is already defined and initialized with req->dev on top of virtio_blk_handle_request(), so we can remove it from the code block of VIRTIO_BLK_T_GET_ID case. Signed-off-by: Stefano Garzarella Reviewed-by: Thomas Huth Message-Id: <20190130095231.42081-1-sg

[Qemu-devel] [PULL 05/13] Don't talk about the LGPL if the file is licensed under the GPL

2019-01-30 Thread Laurent Vivier
From: Thomas Huth Some files claim that the code is licensed under the GPL, but then suddenly suggest that the user should have a look at the LGPL. That's of course non-sense, replace it with the correct GPL wording instead. Signed-off-by: Thomas Huth Message-Id: <1548255083-8190-1-git-send-ema

[Qemu-devel] [PULL 06/13] COPYING.LIB: Synchronize the LGPL 2.1 with the version from gnu.org

2019-01-30 Thread Laurent Vivier
From: Thomas Huth The current version of the LGPL 2.1 from gnu.org (see the URL https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt ) slightly differs from the old one that we use in our repository. Especially the recommendation to use "either version 2 of the License, or [...] any later versi

[Qemu-devel] [PULL 01/13] hw: edu: set category of the edu device

2019-01-30 Thread Laurent Vivier
From: kumar sourav Sets the category of edu device as DEVICE_CATEGORY_MISC. Devices should be assigned to one of DEVICE_CATEGORY_. Signed-off-by: kumar sourav Reviewed-by: Thomas Huth Message-Id: <20190124144606.4352-1-sourav.jb1...@gmail.com> Signed-off-by: Laurent Vivier --- hw/misc/ed

[Qemu-devel] [PULL 08/13] target/tricore: Fix LGPL version number

2019-01-30 Thread Laurent Vivier
From: Thomas Huth It's either "GNU *Library* General Public version 2" or "GNU Lesser General Public version *2.1*", but there was no "version 2.0" of the "Lesser" library. So assume that version 2.1 is meant here. Cc: Bastian Koppelmann Signed-off-by: Thomas Huth Acked-by: Bastian Koppelmann

Re: [Qemu-devel] [PATCH 6/9] iotests.py: Add is_str()

2019-01-30 Thread Max Reitz
On 29.01.19 22:35, John Snow wrote: > > > On 1/23/19 9:46 AM, Max Reitz wrote: >> Strings can have various representations, this helper function checks >> whether a given value is in any of them. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/iotests.py | 6 ++ >> 1 file change

[Qemu-devel] [PULL 09/13] tcg: Fix LGPL version number

2019-01-30 Thread Laurent Vivier
From: Thomas Huth It's either "GNU *Library* General Public version 2" or "GNU Lesser General Public version *2.1*", but there was no "version 2.0" of the "Lesser" library. So assume that version 2.1 is meant here. Cc: Richard Henderson Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 07/13] target/openrisc: Fix LGPL version number

2019-01-30 Thread Laurent Vivier
From: Thomas Huth It's either "GNU *Library* General Public version 2" or "GNU Lesser General Public version *2.1*", but there was no "version 2.0" of the "Lesser" library. So assume that version 2.1 is meant here. Cc: Stafford Horne Signed-off-by: Thomas Huth Acked-by: Stafford Horne Reviewe

Re: [Qemu-devel] [PATCH] gdbstub: allow killing QEMU via vKill command

2019-01-30 Thread KONRAD Frederic
Hi, Le 1/29/19 à 9:32 PM, Max Filippov a écrit : With multiprocess extensions gdb uses 'vKill' packet instead of 'k' to kill the inferior. Handle 'vKill' the same way 'k' was handled in the presence of single process. Fixes: 7cf48f6752e5 ("gdbstub: add multiprocess support to (f|s)ThreadInfo an

Re: [Qemu-devel] [PATCH v8 0/2] qemu-img info lists bitmap directory entries

2019-01-30 Thread Vladimir Sementsov-Ogievskiy
30.01.2019 15:43, Eric Blake wrote: > On 1/30/19 2:00 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> So, I'm trying to test this, and I've discovered something rather >>> annoying about persistent snapshots: they DON'T get written to disk >>> until the qemu process exits. In other words, even afte

[Qemu-devel] [PULL 12/13] hw/block: clean up stale xen_disk trace entries

2019-01-30 Thread Laurent Vivier
From: Paul Durrant This should have been removed then xen_disk.c was removed but I missed them. Fixes: 19f87870baa570bcd7e80e7657e030bf427f16be xen: remove the legacy 'xen_disk' backend Signed-off-by: Paul Durrant Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190122145132.12571-1-p

Re: [Qemu-devel] [PATCH v4 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2019-01-30 Thread Mark Cave-Ayland
On 30/01/2019 12:51, Richard Henderson wrote: > > Why are you over-complicating things? I thought I'd explicitly said this > twice, but perhaps not: > > Pass the symbol "half" directly to VMRG_DO: > > #define VMRG(suffix, element, access) \ > VMRG_DO(mrgl##suffix, element, access,

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-30 Thread Cornelia Huck
On Tue, 29 Jan 2019 20:39:33 +0100 Halil Pasic wrote: > On Tue, 29 Jan 2019 10:58:40 +0100 > Cornelia Huck wrote: > > > > > > The problem I see with the let the hardware sort it out is that, for > > > > > that to work, we need to juggle multiple translations simultaneously > > > > > (or am I wr

[Qemu-devel] [PULL 11/13] target/m68k: Fix LGPL information in the file headers

2019-01-30 Thread Laurent Vivier
From: Thomas Huth It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. Also some files mention the GPL instead of the LGPL after declarin

[Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus"

2019-01-30 Thread Thomas Huth
The cirrus VGA card has been enabled in the PPC builds with commit 29f9cef39eb1ae55e82c ("ppc: Include vga cirrus card into the compiling process") last year. It also works on the pseries machine, even SLOF contains support for this card, so we can also support this for the "-vga" parameter here.

[Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64

2019-01-30 Thread Catherine Ho
Without this patch, gcc might up the Input/Output registers and cause unpredictable error. Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128") Signed-off-by: Catherine Ho --- include/qemu/atomic128.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/ato

Re: [Qemu-devel] [PATCH 1/2] usb: XHCI shall not halt isochronous endpoints

2019-01-30 Thread Dmitry Fleytman
> On 28 Jan 2019, at 22:05, Yuri Benditovich > wrote: > > According to the XHCI spec (4.10.2) the controller > never halts isochronous endpoints. This commit prevent > stop of isochronous streaming when sporadic errors > status received from backends. > > Signed-off-by: Yuri Benditovich Rev

Re: [Qemu-devel] [PATCH 2/2] usb: implement XHCI underrun/overrun events

2019-01-30 Thread Dmitry Fleytman
> On 28 Jan 2019, at 22:05, Yuri Benditovich > wrote: > > Implement underrun/overrun events of isochronous endpoints > according to XHCI spec (4.10.3.1) > Guest software restarts data streaming when receives these events. > The XHCI reports these events using interrupter assigned > to the slo

[Qemu-devel] [Bug 1813940] [NEW] kvm_mem_ioeventfd_add: error adding ioeventfd: No space left on device

2019-01-30 Thread Darek Stojaczyk
Public bug reported: Latest QEMU master fails to run with too many MMIO devices specified. After patch 3ac7d43a6fb [1] QEMU just prints an error message and exits. > kvm_mem_ioeventfd_add: error adding ioeventfd: No space left on device This is reproducible e.g. with the following setup: qemu-3

Re: [Qemu-devel] [PATCH 2/6] aarch64-linux-user: Update HWCAP bits from linux 5.0-rc1

2019-01-30 Thread Laurent Vivier
On 25/01/2019 23:57, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/elfload.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/linux-user/elfload.c b/linux-user/elfload.c > index 4cff9e1a31..3c7a7c2836 100644 > --- a/linux-user/elfload.c > +++ b/l

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Erik Skultety
> > > though, we need a #ifdef check for existance of PR_CAP_AMBIENT > > > > > > > An alternative question I've been playing ever since we exchanged the > > > > last few > > > > emails is that can't we wait until the ioctls are compared against > > > > permissions > > > > in kernel so that upstre

[Qemu-devel] job_pause_point

2019-01-30 Thread Vladimir Sementsov-Ogievskiy
Hi! I have a question about job_pause_point. Now a good job of moving generic things about block-jobs to job.c is done.. job_pause_point do visible job-state change, as changing job->status and job->paused. Is it assumed, that job don't do anything after that state change? Iotests are written

Re: [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-01-30 Thread Markus Armbruster
Cc: Paolo for additonal device infrastructure expertise. Peter Maydell writes: > On Fri, 25 Jan 2019 at 15:11, Markus Armbruster wrote: >> (1) cfi.pflash01 isn't available with -device. >> >> (2) "Magic board code picks up the backend [created for -drive >> if=pflash], creates a frontend (a

  1   2   3   4   >