On Wed, Jan 30, 2019 at 12:58:23PM +0100, Thomas Huth wrote: > On 2019-01-25 11:07, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > Signed-off-by: Yang Zhong <yang.zh...@intel.com> > > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > > Reviewed-by: Thomas Huth <th...@redhat.com> > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > --- > [...] > > diff --git a/hw/net/Kconfig b/hw/net/Kconfig > > index d50e301..6d15720 100644 > > --- a/hw/net/Kconfig > > +++ b/hw/net/Kconfig > > @@ -48,6 +48,9 @@ config LAN9118 > > > > config NE2000_ISA > > bool > > + default y > > + depends on ISA_BUS > > + depends on PCI # for NE2000State > > Yang, > > for the time being, could you please change the last line into > > depends on NE2000_PCI > > instead? Otherwise, it's still possible to enable NE2000_ISA while > NE2000_PCI is disabled, and this will currently result in linking errors. > Yes, i will use "depends on NE2000_PCI" to replace "depends on PCI # for NE2000State". thanks!
Yang > In the long run, we should likely put the common functions into a > separate file, but that's future work, after your series has been > merged, I think. > > Thanks, > Thomas
