On Wed, Jan 30, 2019 at 01:20:42PM +0100, Paolo Bonzini wrote: > On 30/01/19 13:07, Thomas Huth wrote: > > I think adding ioport.o to IDE_PCI and IDE_VIA is wrong. The > > ide_init_ioport() function is only used by isa.c and piix.c, so it > > should only be added for IDE_ISA and IDE_PIIX here. > > Good idea, another one for Yang. :) > Yes, for ioport.o, i will add as below:
+common-obj-$(CONFIG_IDE_ISA) += isa.o ioport.o +common-obj-$(CONFIG_IDE_PIIX) += piix.o ioport.o The newest hw/ide/via.c has removed ide_init_ioport() call. By the way, i plan to send non-RFC patches 1-27 tomorrow if there is not any new comments. thanks! Yang > Paolo
