Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Paolo Bonzini
On 03/01/19 19:37, Peter Maydell wrote: > On Sat, 22 Dec 2018 at 08:41, Paolo Bonzini wrote: >> >> On 21/12/18 22:09, Peter Maydell wrote: >>> I don't really understand what's going on here, or why >>> it only happens with this one system (my main x86-64 >>> Linux Ubuntu 16.04.5 box) and not the v

Re: [Qemu-devel] [PATCH] include: update Linux headers to 4.21/5.0

2019-01-04 Thread Paolo Bonzini
On 03/01/19 20:26, Peter Maydell wrote: > On Thu, 3 Jan 2019 at 18:19, Michael S. Tsirkin wrote: >> >> On Thu, Jan 03, 2019 at 06:51:13PM +0100, Paolo Bonzini wrote: >>> Signed-off-by: Paolo Bonzini >> >> Note that in the past we just updated what we needed. > > Not if I noticed it -- our copies

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-04 Thread Mark Cave-Ayland
On 04/01/2019 05:47, P J P wrote: > Hello Mark, > > +-- On Thu, 3 Jan 2019, Mark Cave-Ayland wrote --+ > | > /* Power */ > | > +static uint64_t power_mem_read(void *opaque, hwaddr addr, unsigned size) > | > +{ > | > +return 0x; > | > +} > | > + > | > > | > static const MemoryReg

[Qemu-devel] [PATCH 0/2] include: update Linux headers to 4.21-rc1/5.0-rc1

2019-01-04 Thread Paolo Bonzini
This is the same patch I've sent, except that scripts/update-linux-headers.sh changes are split to a separate commit. Paolo Paolo Bonzini (2): scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1) include: update Linux headers to 4.21-rc1/5.0-rc1 include/standard-heade

[Qemu-devel] [PATCH 1/2] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1)

2019-01-04 Thread Paolo Bonzini
There are three new indirect inclusions: vhost_types.h, which we'll shortly put to use as a portable header and thus is copied to standard-headers; and new per-subtarget versions of MIPS unistd.h and PowerPC unistd.h. Because vhost.h includes vhost_types.h, we also need a proxy include from linux/

Re: [Qemu-devel] [PATCH for-4.0 v4 2/2] virtio: Provide version-specific variants of virtio PCI devices

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 23:27:08 -0500 "Michael S. Tsirkin" wrote: > On Thu, Jan 03, 2019 at 04:32:06PM -0200, Eduardo Habkost wrote: > > On Thu, Jan 03, 2019 at 11:48:37AM +0100, Cornelia Huck wrote: > > > On Thu, 3 Jan 2019 11:14:44 +0100 > > > Thomas Huth wrote: > > > > > > > On 2019-01-03 10

Re: [Qemu-devel] [PATCH] include: update Linux headers to 4.21/5.0

2019-01-04 Thread Cornelia Huck
On Fri, 4 Jan 2019 09:07:23 +0100 Paolo Bonzini wrote: > On 03/01/19 20:26, Peter Maydell wrote: > > On Thu, 3 Jan 2019 at 18:19, Michael S. Tsirkin wrote: > >> I'd prefer the shell script part and the new vhost_types header which > >> are actually reviewable to be split out to a separate pat

[Qemu-devel] [PATCH] spapr: return from post_load method when RTC import fails

2019-01-04 Thread Cédric Le Goater
The error value can be squashed by the section handling radix migration. Simply bail out if an error occurs when the RTC offset is imported. Fixes: d39c90f5f3ae ("spapr: Fix migration of Radix guests") Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c | 9 +++-- 1 file changed, 7 insertion

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-04 Thread Paul Durrant
Ping Anthony & Kevin? I believe this version is purged of all legacy interface use. > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 20 December 2018 17:15 > To: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; xen- > de...@lists.xenproject.org > Cc: Paul Du

Re: [Qemu-devel] [PATCH v7 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2019-01-04 Thread Paul Durrant
Ping Anthony? I dropped your R-b on v6 since I screwed it up. Are you ok with v7? It should be back to how it was but with some whitespace fixes. Paul > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 20 December 2018 17:15 > To: qemu-devel@nongnu.org;

Re: [Qemu-devel] [PATCH 1/2] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1)

2019-01-04 Thread Cornelia Huck
On Fri, 4 Jan 2019 09:27:30 +0100 Paolo Bonzini wrote: > There are three new indirect inclusions: vhost_types.h, which we'll > shortly put to use as a portable header and thus is copied to > standard-headers; and new per-subtarget versions of MIPS unistd.h > and PowerPC unistd.h. > > Because vh

Re: [Qemu-devel] [PATCH 2/2] include: update Linux headers to 4.21-rc1/5.0-rc1

2019-01-04 Thread Cornelia Huck
On Fri, 4 Jan 2019 09:27:31 +0100 Paolo Bonzini wrote: > This is simply running the newly-updated script on Linux, in > order to obtain the new header files and all the other updates > from the recent Linux merge window. > > Signed-off-by: Paolo Bonzini > --- > include/standard-headers/drm/dr

Re: [Qemu-devel] [PATCH 1/1] include: Auto-generate the sizes lookup table

2019-01-04 Thread Alberto Garcia
On Thu 03 Jan 2019 10:42:30 PM CET, Eric Blake wrote: > In my view, code generators make sense when used on code that is > expected to change over time (a good example is QAPI because we add > new commands every release; other places might be a generator to help > deal with syscall handlers since

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 23:23:45 -0500 "Michael S. Tsirkin" wrote: > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern options. >

[Qemu-devel] Memory limit of a windows guest

2019-01-04 Thread Mahmood Naderan via Qemu-devel
Hi Is there any limitation for the guest memory? I have defined "-m 4" for a windows guest while the host have 64GB of memory. However, in the windows, I see only 16GB of physical memory. Any thought? Regards, Mahmood

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Cornelia Huck
On Fri, 4 Jan 2019 01:22:26 -0200 Eduardo Habkost wrote: > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > assumption: that all virtio-pci subclasses support the > disable-legacy and disable-modern options. > > That assumption was broken by commit f6e501a28ef9 ("virtio: > Provide vers

[Qemu-devel] [PATCH v1] sun4u: add power_mem_read routine

2019-01-04 Thread P J P
From: Prasad J Pandit Define skeleton 'power_mem_read' routine. Avoid NULL dereference. Reported-by: Fakhri Zulkifli Signed-off-by: Prasad J Pandit --- hw/sparc64/sun4u.c | 6 ++ 1 file changed, 6 insertions(+) Update v1: change return value to zero(0) -> https://lists.gnu.org/archive/

Re: [Qemu-devel] [PATCH 02/11] arm: Add header to host common definition for nRF51 SOC peripherals

2019-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2019 at 11:40:30AM +0100, Philippe Mathieu-Daudé wrote: > On 1/3/19 10:11 AM, Stefan Hajnoczi wrote: > > From: Steffen Görtz > > > > Adds a header that provides definitions that are used > > across nRF51 peripherals > > > > Signed-off-by: Steffen Görtz > > Reviewed-by: Stefan Ha

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-04 Thread P J P
+-- On Fri, 4 Jan 2019, Mark Cave-Ayland wrote --+ | I asked someone with real Ultra-5 hardware to check this for me, and they've | sent me back the following output: | | ok .properties | address fffb8000 | button | interrupts 0001 | reg 000

[Qemu-devel] [Bug 1810433] Re: aarch64-linux-user master: inconsistent pwrite behaviour

2019-01-04 Thread Peter Maydell
We run the Linux Test Project LTP test suite. However I think it may not cover this corner case. (It's also possible I missed it last time I went through our failure results -- it's a lot of analysis effort to disentangle "QEMU bug" from "QEMU missing feature that's impracticably hard to implement"

Re: [Qemu-devel] [Spice-devel] Always get Invalid password while trying to connect to spice server

2019-01-04 Thread Christophe Fergeau
Hey, On Thu, Jan 03, 2019 at 04:25:00PM -0600, Eric Blake wrote: > On 12/27/18 8:51 AM, Niccolò Belli wrote: > > On mercoledì 26 dicembre 2018 13:38:28 CET, Frediano Ziglio wrote: > >> Yes, this looks like a format string error in the upper (not into > >> spice) layer. > >> > >> This potentially i

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: > > On 03/01/19 19:37, Peter Maydell wrote: > > On Sat, 22 Dec 2018 at 08:41, Paolo Bonzini wrote: > > Interestingly, I have today run into "make: write error: stdout" > > with the existing make check infrastructure. [...] > > I presume that somet

Re: [Qemu-devel] [PATCH] spapr: return from post_load method when RTC import fails

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 09:07, Cédric Le Goater wrote: > > The error value can be squashed by the section handling radix migration. > Simply bail out if an error occurs when the RTC offset is imported. > > Fixes: d39c90f5f3ae ("spapr: Fix migration of Radix guests") You could also mention that this

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern options. > > > > That assump

Re: [Qemu-devel] [PATCH v2] chardev: Allow for pty path passing.

2019-01-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1546549573-22912-1-git-send-email-ptsne...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

Re: [Qemu-devel] [PATCH v2] chardev: Allow for pty path passing.

2019-01-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1546549573-22912-1-git-send-email-ptsne...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1546549573-22912-1-git-send-email-ptsne...@gmail.com Subject: [Qemu-devel] [PAT

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-04 Thread Philippe Mathieu-Daudé
Le ven. 4 janv. 2019 10:55, P J P a écrit : > +-- On Fri, 4 Jan 2019, Mark Cave-Ayland wrote --+ > | I asked someone with real Ultra-5 hardware to check this for me, and > they've > | sent me back the following output: > | > | ok .properties > | address fffb8000 > | button > | in

Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice

2019-01-04 Thread Roman Kapl
Le 25/12/2018 à 10:50, Jon Diekema a écrit : From f399f28441e0aa79458d68996038ca3606fcb699 Mon Sep 17 00:00:00 2001 From: Jon Diekema mailto:jon.diek...@ge.com>> Date: Tue, 25 Dec 2018 04:36:06 -0500 Subject: ppc: e6500 registers SPR 604 twice When using the e6500 CPU, QEMU generates a fatal er

[Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks

2019-01-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This series fixes the memory leaks in versal board creation reported by Peter Maydell. Best regards, Edgar Edgar E. Iglesias (1): hw/arm: versal: Plug memory leaks hw/arm/xlnx-versal-virt.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1

[Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug memory leaks

2019-01-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Plug a couple of "board creation time" memory leaks. Reported-by: Peter Maydell Signed-off-by: Edgar E. Iglesias --- hw/arm/xlnx-versal-virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c index c6feeac532

Re: [Qemu-devel] [PATCH 02/10] ppc/xive: introduce a XiveTCTX pointer under PowerPCCPU

2019-01-04 Thread David Gibson
On Thu, Jan 03, 2019 at 06:44:30PM +0100, Cédric Le Goater wrote: > On 1/3/19 4:57 AM, David Gibson wrote: > > On Wed, Jan 02, 2019 at 06:57:35AM +0100, Cédric Le Goater wrote: > >> which will be used by the machine only when the XIVE interrupt mode is > >> in use. > > > > I don't love the idea of

Re: [Qemu-devel] barebox on Canon A1100

2019-01-04 Thread Antony Pavlov
On Fri, 4 Jan 2019 09:17:41 +0100 Sascha Hauer wrote: > On Fri, Jan 04, 2019 at 01:56:41AM +0300, Antony Pavlov wrote: > > Hi Sascha! > > > > I have some good news and some bad news. > > > > First the good news. > > > > Barebox was used for Day 18 of QEMU 2018 advent > > (https://www.qemu-adv

Re: [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2019-01-04 Thread Marc-André Lureau
Hi On Fri, Dec 21, 2018 at 7:34 PM Cornelia Huck wrote: > > On Fri, 21 Dec 2018 13:04:07 +0400 > Marc-André Lureau wrote: > > > All qdev_prop_register_global() set &error_fatal for errp, except > > '-rtc driftfix=slew', which arguably should also use &error_fatal, as > > otherwise failing to app

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Paolo Bonzini
On 04/01/19 11:06, Peter Maydell wrote: > On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: >> >> On 03/01/19 19:37, Peter Maydell wrote: >>> On Sat, 22 Dec 2018 at 08:41, Paolo Bonzini wrote: >>> Interestingly, I have today run into "make: write error: stdout" >>> with the existing make check in

Re: [Qemu-devel] [PATCH 1/2] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1)

2019-01-04 Thread Paolo Bonzini
On 04/01/19 10:26, Cornelia Huck wrote: > On Fri, 4 Jan 2019 09:27:30 +0100 > Paolo Bonzini wrote: > >> There are three new indirect inclusions: vhost_types.h, which we'll >> shortly put to use as a portable header and thus is copied to >> standard-headers; and new per-subtarget versions of MIPS

Re: [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2019-01-04 Thread Cornelia Huck
On Fri, 4 Jan 2019 14:57:26 +0400 Marc-André Lureau wrote: > Hi > > On Fri, Dec 21, 2018 at 7:34 PM Cornelia Huck wrote: > > > > On Fri, 21 Dec 2018 13:04:07 +0400 > > Marc-André Lureau wrote: > > > > > All qdev_prop_register_global() set &error_fatal for errp, except > > > '-rtc driftfix=sl

Re: [Qemu-devel] [PATCH v3 0/3] dmg: fixing reading in dmg

2019-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2019 at 07:46:57PM +0800, yuchenlin wrote: > There are two bugs in dmg reading. > > First, it may hang in binary search. this problem is solved by patch 1. > Second, because of lacking zero chunk table, reading zero sector will > return EIO. this problem is solved by patch 2 and 3.

[Qemu-devel] [PULL 1/4] dmg: Fixing wrong dmg block type value for block terminator.

2019-01-04 Thread Stefan Hajnoczi
From: Julio Faracco This is a trivial patch to fix a wrong value for block terminator. The old value was 0x7fff which is wrong. It was not affecting the code because QEMU dmg block is not handling block terminator right now. Neverthless, it should be fixed. Signed-off-by: Julio Faracco Revi

[Qemu-devel] [PULL 4/4] dmg: don't skip zero chunk

2019-01-04 Thread Stefan Hajnoczi
From: yuchenlin The dmg file has many tables which describe: "start from sector XXX to sector XXX, the compression method is XXX and where the compressed data resides on". Each sector in the expanded file should be covered by a table. The table will describe the offset of compressed data (or raw

[Qemu-devel] [PULL 0/4] Block patches

2019-01-04 Thread Stefan Hajnoczi
The following changes since commit 20d6c7312f1b812bb9c750f4087f69ac8485cc90: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-3.2-part1' into staging (2019-01-03 13:26:30 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-requ

[Qemu-devel] [PULL 2/4] dmg: fix binary search

2019-01-04 Thread Stefan Hajnoczi
From: yuchenlin There is a possible hang in original binary search implementation. That is if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. The chunk1 will be still 4, and so on. Signed-off-by: yuchenlin Message-id: 20190103114700.9686-2-npes87...@gmail.com Signed-off-by: Stefan Haj

[Qemu-devel] [PULL 3/4] dmg: use enumeration type instead of hard coding number

2019-01-04 Thread Stefan Hajnoczi
From: yuchenlin Signed-off-by: yuchenlin Reviewed-by: Julio Faracco Reviewed-by: Stefan Hajnoczi Message-id: 20190103114700.9686-3-npes87...@gmail.com Signed-off-by: Stefan Hajnoczi --- block/dmg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/dmg.c b/block/dm

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 11:01, Paolo Bonzini wrote: > > On 04/01/19 11:06, Peter Maydell wrote: > > On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: > >> > >> On 03/01/19 19:37, Peter Maydell wrote: > >>> On Sat, 22 Dec 2018 at 08:41, Paolo Bonzini wrote: > >>> Interestingly, I have today run int

Re: [Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties

2019-01-04 Thread Marc-André Lureau
Hi On Fri, Dec 21, 2018 at 1:04 PM Marc-André Lureau wrote: > > Hi, > > During "[PATCH v2 05/10] qom/globals: generalize > object_property_set_globals()" review, Eduardo suggested to rework the > GlobalProperty handling, so that -global is limited to QDev only and > we avoid mixing the machine co

Re: [Qemu-devel] [RFC] target/microblaze: Switch to transaction_failed hook

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 06:32:49PM +, Peter Maydell wrote: > On Mon, 10 Dec 2018 at 18:31, Peter Maydell wrote: > > > > On Mon, 10 Dec 2018 at 17:57, Peter Maydell > > wrote: > > > > > > Switch the microblaze target from the old unassigned_access hook > > > to the transaction_failed hook. >

Re: [Qemu-devel] [PATCH 1/2] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1)

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 11:02, Paolo Bonzini wrote: > > On 04/01/19 10:26, Cornelia Huck wrote: > > On Fri, 4 Jan 2019 09:27:30 +0100 > > Paolo Bonzini wrote: > > > >> There are three new indirect inclusions: vhost_types.h, which we'll > >> shortly put to use as a portable header and thus is copie

Re: [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug memory leaks

2019-01-04 Thread Philippe Mathieu-Daudé
On 1/4/19 11:47 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Plug a couple of "board creation time" memory leaks. > Fixes 6f16da53ffe > Reported-by: Peter Maydell > Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé > --- > hw/arm/xlnx-versal-virt.c | 2

Re: [Qemu-devel] [PATCH] spapr: return from post_load method when RTC import fails

2019-01-04 Thread Cédric Le Goater
On 1/4/19 11:08 AM, Peter Maydell wrote: > On Fri, 4 Jan 2019 at 09:07, Cédric Le Goater wrote: >> >> The error value can be squashed by the section handling radix migration. >> Simply bail out if an error occurs when the RTC offset is imported. >> >> Fixes: d39c90f5f3ae ("spapr: Fix migration of

Re: [Qemu-devel] [PATCH] spapr: return from post_load method when RTC import fails

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 12:31, Cédric Le Goater wrote: > > On 1/4/19 11:08 AM, Peter Maydell wrote: > > On Fri, 4 Jan 2019 at 09:07, Cédric Le Goater wrote: > >> > >> The error value can be squashed by the section handling radix migration. > >> Simply bail out if an error occurs when the RTC offset

Re: [Qemu-devel] [PATCH 0/4] QGA - Win fixes

2019-01-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190103122323.1273034-1-ba...@daynix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190103122323.1273034-1-ba...@daynix.com Subject: [Qemu-devel] [PATCH 0/4] QGA - Win fixes

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Paolo Bonzini
On 04/01/19 12:31, Peter Maydell wrote: > I'll give this a go, but I think this will not necessarily be > sufficient if some program invoked by make sets the O_NONBLOCK flag, > and then make later in the same run tries to output and gets EINTR. > Perhaps it would be better to put it in the test har

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: > I don't know... I tried running make check under "strace -e fcntl" and I > didn't find any occurrences of fcntl(1, O_SETFL, ...|O_NONBLOCK). I found this strace command worked to track down some possible culprits: strace -o /tmp/strace.log -e fc

Re: [Qemu-devel] [RFC] target/microblaze: Switch to transaction_failed hook

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 06:32:49PM +, Peter Maydell wrote: > On Mon, 10 Dec 2018 at 18:31, Peter Maydell wrote: > > > > On Mon, 10 Dec 2018 at 17:57, Peter Maydell > > wrote: > > > > > > Switch the microblaze target from the old unassigned_access hook > > > to the transaction_failed hook. >

Re: [Qemu-devel] [PULL v3 00/44] MIPS pull request for December 2018 - v3

2019-01-04 Thread Peter Maydell
On Thu, 3 Jan 2019 at 17:08, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit 1b3e80082bcd9b760113bbc023496cd22efad2dc: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20181226' into > staging (2019-01-03 10:42:21 +) > > are availa

Re: [Qemu-devel] [RFC PATCH 12/25] build: convert usb.mak to Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Instead of including the same list of devices for each target, > let the host controllers select CONFIG_USB and make the devices > default to present whenever USB is available. > > Done with the following script: > while read i;

[Qemu-devel] [PATCH v2] spapr: return from post_load method when RTC import fails

2019-01-04 Thread Cédric Le Goater
The error value can be squashed by the section handling radix migration. Simply bail out if an error occurs when the RTC offset is imported. This fixes the Coverity issue CID 1398591. Fixes: d39c90f5f3ae ("spapr: Fix migration of Radix guests") Signed-off-by: Cédric Le Goater --- Changes since

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Paolo Bonzini
On 04/01/19 14:03, Peter Maydell wrote: > On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: >> I don't know... I tried running make check under "strace -e fcntl" and I >> didn't find any occurrences of fcntl(1, O_SETFL, ...|O_NONBLOCK). > > I found this strace command worked to track down some po

Re: [Qemu-devel] [RFC PATCH 11/25] build: convert sound.mak to Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > There is really nothing special in these devices; they are just > ISA devices. Instead of including them for each target, > set CONFIG_ISA to true, and make the devices default to present > whenever ISA is available. More conversi

Re: [Qemu-devel] [RFC PATCH 03/25] minikconfig: add parser skeleton

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:33, Yang Zhong wrote: > + > +# --- > +# KconfigParser implements a recursive descent parser for (simplified) > +# Kconfig syntax. The static parse() method returns a KconfigData > +# object, from which it is possible to build a BDD and compute

Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > This lets you disable SCSI altogether with "CONFIG_SCSI=n". USB_STORAGE_BOT and USB_STORAGE_UAS must also select SCSI. Paolo

Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > This lets you disable SCSI altogether with "CONFIG_SCSI=n". > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > hw/scsi/Kconfig | 11 ++- > hw/scsi/Makefile.objs | 2 +- > 2 files changed, 11 inse

Re: [Qemu-devel] [RFC PATCH 14/25] bluetooth: express dependencies with Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > hw/Makefile.objs | 2 +- > hw/usb/Kconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/Makefile.objs b/hw/Makefile.objs > index 3

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 13:03, Peter Maydell wrote: > > On Fri, 4 Jan 2019 at 07:59, Paolo Bonzini wrote: > > I don't know... I tried running make check under "strace -e fcntl" and I > > didn't find any occurrences of fcntl(1, O_SETFL, ...|O_NONBLOCK). > > I found this strace command worked to trac

Re: [Qemu-devel] [RFC PATCH 10/25] build: convert pci.mak to Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Instead of including the same list of devices for each target, > set CONFIG_PCI to true, and make the devices default to present > whenever PCI is available. > > Done mostly with the following script: > > while read i; do >

Re: [Qemu-devel] [RFC PATCH 15/25] isa: express dependencies with kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- [...] > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 5e73277cc2..e0d7919a06 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -9,6 +9,9

Re: [Qemu-devel] [RFC PATCH 00/13] Enabling tcg/tests for xtensa, mips and cris

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 03:28:16PM +, Alex Bennée wrote: > Hi, > > This is very much a work in progress but I'm posting it in the hope of > getting some feedback from the architecture maintainers. > > When I originally enabled tcg tests I only enabled linux-user tests for > architectures that

Re: [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:34, Yang Zhong wrote: > %-softmmu.mak only keep boards definitions in Kconfig mode. > > Signed-off-by: Yang Zhong > --- > default-configs/i386-softmmu.mak | 30 -- > hw/i386/Kconfig | 30 ++ > hw/ide/Kconfig

Re: [Qemu-devel] [RFC PATCH 11/13] tests/tcg/cris: comment out the ccs test

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 03:28:27PM +, Alex Bennée wrote: > Evidently upstream gcc doesn't like this opcode. > > Signed-off-by: Alex Bennée Hi Alex, this is probably an example of missmatching CRISv10 vs CRISv32 versions in toolchain usage. Cheers, Edgar > --- > tests/tcg/cris/system/ch

Re: [Qemu-devel] [RFC PATCH 00/13] Enabling tcg/tests for xtensa, mips and cris

2019-01-04 Thread Edgar E. Iglesias
On Mon, Dec 10, 2018 at 03:28:16PM +, Alex Bennée wrote: > Hi, > > This is very much a work in progress but I'm posting it in the hope of > getting some feedback from the architecture maintainers. > > When I originally enabled tcg tests I only enabled linux-user tests for > architectures that

Re: [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:33, Yang Zhong wrote: > (*) defconfig > "randconfig" build has some issues, which are mostly related > with CONFIG* in Kconfig.host abd configure. In randconfig mode, > some CONFIG* has different setting value in config-host.mak and > %/config-device.mak, which make Q

Re: [Qemu-devel] barebox on Canon A1100

2019-01-04 Thread Sascha Hauer
On Fri, Jan 04, 2019 at 01:56:41AM +0300, Antony Pavlov wrote: > Hi Sascha! > > I have some good news and some bad news. > > First the good news. > > Barebox was used for Day 18 of QEMU 2018 advent > (https://www.qemu-advent-calendar.org/2018/). > > Here is a quote: > > > This is an image f

Re: [Qemu-devel] [PATCH v15 23/26] sched: early boot clock (was Re: Bug#918036: linux: uptime after reboot wrong (kvm-clock related?))

2019-01-04 Thread Thorsten Glaser
Hi Salvatore, >p.s.: my earlier reply to you seem to have been rejected and never > reached you, hope this one does now. if you sent from Googlemail, it may reach me in the next weeks or never *shrug* they don’t play nice with greylisting. The -submitter or @d.o works, though. I’m following

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Add the 'A' SRAM and the SRAM controller

2019-01-04 Thread Peter Maydell
On Sun, 9 Dec 2018 at 19:37, Philippe Mathieu-Daudé wrote: > > From the "A10 User Manual V1.20" p.29: "3.2. Memory Mapping" and: > > 7. System Control > 7.1. Overview > > A10 embeds a high-speed SRAM which has been split into five segments. > See detailed memory mapping in following table:

Re: [Qemu-devel] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug()

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 07:16:12 -0800 Li Qiang wrote: > When getting the 'pbdev', the if...else has no default branch. > From Coverity, the 'pbdev' maybe null when the 'dev' is not > the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE. > This patch adds a default branch for device plug and unpl

Re: [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST

2019-01-04 Thread Paolo Bonzini
On 27/12/18 07:33, Yang Zhong wrote: > +self.clauses.append(KconfigData.DependsOnClause(var, expr)) > > def do_select(self, var, symbol, cond=None): > -pass > +cond = (cond & var) if not (cond is None) else var A better way to write this in Python is cond = (con

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Add the 'A' SRAM and the SRAM controller

2019-01-04 Thread Philippe Mathieu-Daudé
On Fri, Jan 4, 2019 at 3:10 PM Peter Maydell wrote: > On Sun, 9 Dec 2018 at 19:37, Philippe Mathieu-Daudé wrote: > > From the "A10 User Manual V1.20" p.29: "3.2. Memory Mapping" and: > > > > 7. System Control > > 7.1. Overview > > > > A10 embeds a high-speed SRAM which has been split into fi

Re: [Qemu-devel] [PATCH 1/2] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1)

2019-01-04 Thread Aleksandar Markovic
On Friday, January 4, 2019, Paolo Bonzini wrote: > There are three new indirect inclusions: vhost_types.h, which we'll > shortly put to use as a portable header and thus is copied to > standard-headers; and new per-subtarget versions of MIPS unistd.h > and PowerPC unistd.h. > > Because vhost.h in

[Qemu-devel] [PATCH v1 2/2] target/microblaze: Add props enabling exceptions on failed bus accesses

2019-01-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add MicroBlaze CPU properties to enable exceptions on failed bus accesses. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 12 +++- target/microblaze/cpu.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/target/microblaze

[Qemu-devel] [PATCH v2] hw/arm/allwinner-a10: Add the 'A' SRAM and the SRAM controller

2019-01-04 Thread Philippe Mathieu-Daudé
>From the "A10 User Manual V1.20" p.29: "3.2. Memory Mapping" and: 7. System Control 7.1. Overview A10 embeds a high-speed SRAM which has been split into five segments. See detailed memory mapping in following table: Area AddressSize (Bytes) A10x-0x3F

[Qemu-devel] [PATCH v1 0/2] target/microblaze: Add properties to enable exceptions on failed bus accesses

2019-01-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds the necessary properties to MicroBlaze cores to enable exceptions on failed bus accesses. There's no board that acutally uses this yet. This also adds an unimplemented device to the s3adsp1800 board since I used that board to test this feature. The s3adsp1800

[Qemu-devel] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()

2019-01-04 Thread Li Qiang
What do you think of ‘g_assert_not_reached();’. For example: else { g_assert_not_reached(); } Thanks, Li Qiang 发件人: Cornelia Huck 发送时间: 2019年1月4日 22:10 收件人: Li Qiang 抄送: wall...@linux.ibm.com; r...@twiddle.net; da...@redhat.com; pa...@linux.ibm.com; borntrae...@de.ibm.com; qemu-s3...@nong

Re: [Qemu-devel] [PATCH v6] s390x/pci: add common function measurement block

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 11:17:00 +0100 Pierre Morel wrote: > +static void fmb_update(void *opaque) > +{ > +S390PCIBusDevice *pbdev = opaque; > +int64_t t = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL); > +int i; > + > +/* Update U bit */ > +pbdev->fmb.last_update *= 2; > +pbdev->fmb.

[Qemu-devel] [Bug 1809546] Re: Writing a byte to a pl011 SFR overwrites the whole SFR

2019-01-04 Thread Peter Maydell
Yes, our PL011 implementation assumes that you only ever access the 32-bit registers with full width 32-bit word reads and writes. Don't try to do byte accesses to them. The PL011 data sheet doesn't specifically say that partial-width accesses to registers are permitted, so I think that trying to a

[Qemu-devel] [PATCH] tests/hexloader-test: Don't pass -nographic to the QEMU under test

2019-01-04 Thread Peter Maydell
The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_NONBLOCK is not per-fi

Re: [Qemu-devel] [PULL 0/4] Block patches

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 11:21, Stefan Hajnoczi wrote: > > The following changes since commit 20d6c7312f1b812bb9c750f4087f69ac8485cc90: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-3.2-part1' into staging (2019-01-03 > 13:26:30 +) > > are available in the Git repos

Re: [Qemu-devel] [PATCH v2 4/8] qcow2-threads: split out generic path

2019-01-04 Thread Alberto Garcia
On Fri 14 Dec 2018 09:51:12 AM CET, Vladimir Sementsov-Ogievskiy wrote: > 14.12.2018 2:28, Paolo Bonzini wrote: >> On 11/12/18 17:43, Vladimir Sementsov-Ogievskiy wrote: >>> +ThreadPool *pool = aio_get_thread_pool(bdrv_get_aio_context(bs)); >>> + >>> +while (s->nb_threads >= QCOW2_MAX_THREA

[Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file

2019-01-04 Thread Thomas Huth
This device does not use I2C, so no need to include the header file here. Signed-off-by: Thomas Huth --- hw/audio/marvell_88w8618.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c index 6600ab4..035dd76 100644 --- a/hw/audio/marvell_88w8

Re: [Qemu-devel] [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1

2019-01-04 Thread Aleksandar Markovic
> From: Fredrik Noring > Sent: Tuesday, January 1, 2019 7:27 PM > To: Aleksandar Markovic > Cc: Aurelien Jarno; Philippe Mathieu-Daudé; Jürgen Urban; Maciej W. Rozycki; > qemu-devel@nongnu.org > Subject: Re: [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1 > > Thanks Aleksandar! >

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug()

2019-01-04 Thread Halil Pasic
On Fri, 4 Jan 2019 15:10:05 +0100 Cornelia Huck wrote: > On Thu, 3 Jan 2019 07:16:12 -0800 > Li Qiang wrote: > > > When getting the 'pbdev', the if...else has no default branch. > > From Coverity, the 'pbdev' maybe null when the 'dev' is not > > the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PC

Re: [Qemu-devel] [PATCH v2] qemu: avoid memory leak while remove disk

2019-01-04 Thread Stefan Hajnoczi
On Sat, Dec 22, 2018 at 06:27:28PM +0800, w00426999 wrote: > Memset vhost_dev to zero in the vhost_dev_cleanup function. > This causes dev.vqs to be NULL, so that > vqs does not free up space when calling the g_free function. > This will result in a memory leak. But you can't release vqs > directly

Re: [Qemu-devel] [PATCH v8 00/16] gdbstub: support for the multiprocess extension

2019-01-04 Thread Peter Maydell
On Fri, 7 Dec 2018 at 09:01, Luc Michel wrote: > This series adds support for the multiprocess extension of the GDB > remote protocol in the QEMU GDB stub. > > This extension is useful to split QEMU emulated CPUs in different > processes from the point of view of the GDB client. It adds the > poss

Re: [Qemu-devel] Qemu the right way.

2019-01-04 Thread Stefan Hajnoczi
On Tue, Dec 25, 2018 at 05:48:50PM -0500, liebre...@grossmann-venter.com wrote: > I have been using Qemu in the past about 8 years ago or so to run legacy > windows software. > > I installed the latest qemu and noticed a lot changed and cant find > conclusive answers online. > > I am writing this

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-01-04 Thread Peter Maydell
On Thu, 3 Jan 2019 at 14:41, Stefan Hajnoczi wrote: > > This reverts commit 01fd41ab3fb69971c24a69ed49cde96086d81278. > > The generic loader device (-device loader,file=kernel.bin) can be used > to load a kernel instead of the -kernel option. Some boards have flash > memory (pflash) that is set v

Re: [Qemu-devel] [PATCH] include: update Linux headers to 4.21/5.0

2019-01-04 Thread Michael S. Tsirkin
On Fri, Jan 04, 2019 at 09:07:23AM +0100, Paolo Bonzini wrote: > On 03/01/19 20:26, Peter Maydell wrote: > > On Thu, 3 Jan 2019 at 18:19, Michael S. Tsirkin wrote: > >> > >> On Thu, Jan 03, 2019 at 06:51:13PM +0100, Paolo Bonzini wrote: > >>> Signed-off-by: Paolo Bonzini > >> > >> Note that in th

Re: [Qemu-devel] [PATCH 0/2] include: update Linux headers to 4.21-rc1/5.0-rc1

2019-01-04 Thread Michael S. Tsirkin
On Fri, Jan 04, 2019 at 09:27:29AM +0100, Paolo Bonzini wrote: > This is the same patch I've sent, except that scripts/update-linux-headers.sh > changes are split to a separate commit. > > Paolo Reviewed-by: Michael S. Tsirkin > Paolo Bonzini (2): > scripts/update-linux-headers.sh: adjust for

Re: [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks

2019-01-04 Thread Peter Maydell
On Fri, 4 Jan 2019 at 10:47, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > This series fixes the memory leaks in versal board creation > reported by Peter Maydell. > > Best regards, > Edgar > > Edgar E. Iglesias (1): > hw/arm: versal: Plug memory leaks > Applied to target-arm.next

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add ARM-related files for hw/[misc|input|timer]/

2019-01-04 Thread Peter Maydell
On Wed, 2 Jan 2019 at 12:53, Thomas Huth wrote: > > Some of the files in hw/input/, hw/misc/ and hw/timer/ are only > used by one of the ARM machines, so we can assign these files to > the corresponding boards. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 16 ++-- > 1 file ch

Re: [Qemu-devel] [PATCH] tests/hexloader-test: Don't pass -nographic to the QEMU under test

2019-01-04 Thread Thomas Huth
On 2019-01-04 15:50, Peter Maydell wrote: > The hexloader test invokes QEMU with the -nographic argument. This > is unnecessary, because the qtest_initf() function will pass it > -display none, which suffices to disable the graphical window. > It also means that the QEMU process will make the stdin

Re: [Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

2019-01-04 Thread Thomas Huth
On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- [...] > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 8ce968bfff..8ddce09ead 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -24,9 +24

[Qemu-devel] [PATCH] trivial: Don't include isa.h if it is not really necessary

2019-01-04 Thread Thomas Huth
These files don't seem to do anything related to ISA directly, so there is no need to include isa.h here. Signed-off-by: Thomas Huth --- hw/display/ramfb-standalone.c | 1 - hw/ide/pci.c | 1 - hw/ide/piix.c | 1 - hw/ide/via.c | 1 - hw/misc/mac

  1   2   3   >