On 03/01/19 19:37, Peter Maydell wrote: > On Sat, 22 Dec 2018 at 08:41, Paolo Bonzini <pbonz...@redhat.com> wrote: >> >> On 21/12/18 22:09, Peter Maydell wrote: >>> I don't really understand what's going on here, or why >>> it only happens with this one system (my main x86-64 >>> Linux Ubuntu 16.04.5 box) and not the various others I'm >>> running test builds on. But it does seem to be 100% >>> reliable with any of these pullreqs with the new test >>> driver in them :-( >> >> I'm afraid something in your setup is causing make's stdout to have >> O_NONBLOCK set. Make doesn't use O_NONBLOCK at all, so it must be >> something above it. I also checked Perl with strace and, at least here, >> it doesn't set O_NONBLOCK. > > Interestingly, I have today run into "make: write error: stdout" > with the existing make check infrastructure. [...] > I presume that something in one of the tests we're running, > likely QEMU itself, ends up setting stdout to non-blocking. > This while rune *used* to be entirely reliable, so maybe > something recent has changed ?
I don't know... I tried running make check under "strace -e fcntl" and I didn't find any occurrences of fcntl(1, O_SETFL, ...|O_NONBLOCK). Perhaps you can add a check after every invocation of a test executable. Are you going to apply the pull request since the bug is preexisting? Thanks, Polo
