On 2018-12-27 07:34, Yang Zhong wrote: > From: Paolo Bonzini <pbonz...@redhat.com> > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Yang Zhong <yang.zh...@intel.com> > --- [...] > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 5e73277cc2..e0d7919a06 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -9,6 +9,9 @@ config ADS7846 > > config VGA_CIRRUS > bool > + default y > + depends on ISA_BUS && PCI > + select VGA
Please note that the cirrus-isa device has recently been split into a separate file, see commit: ce3cf70edaaf1b8f9a566b36011350c642287879 Move "isa-cirrus-vga" device into a separate file I guess we need a dedicated VGA_CIRRUS_ISA switch for that file now? > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index 427bda3717..68a9064558 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -9,6 +9,7 @@ config I440FX > > config ISAPC > bool > + select ISA_BUS > > config Q35 > bool Can Q35 and I440FX work completely without ISA_BUS already, or should they also select ISA_BUS here? Thomas
