Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-20 Thread Marc-André Lureau
Hi On Tue, Nov 20, 2018 at 11:24 AM P J P wrote: > > From: Prasad J Pandit > > While performing mmio device r/w operations, guest could set 'addr' > parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 > after setting new 'locty' via 'tpm_tis_new_active_locality'. > Add check to av

Re: [Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-11-20 Thread Gerd Hoffmann
Hi, > > But I assume you specifically want things that do a lot of DMA, so I > > couldn't get away with asking for keeping it to the SBSA UART(s)? :) > > Ideally, it would be something that supports platform MSIs as well, > but that is unlikely to be a priority for anyone (and i would be very >

Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-20 Thread Igor Mammedov
On Mon, 19 Nov 2018 13:27:14 -0500 "Michael S. Tsirkin" wrote: > On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:28 +0100 > > Samuel Ortiz wrote: > > > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > > Description Table). RS

Re: [Qemu-devel] [PATCH] usb-host: set ifs.detached as true if kernel driver is not active

2018-11-20 Thread Gerd Hoffmann
On Tue, Nov 20, 2018 at 09:18:15AM +0800, linzhecheng wrote: > If no kernel driver is active, we can already claim and perform I/O on > it without detaching it. > > Signed-off-by: linzhecheng > > diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c > index f31e9cbbb8..db4ae1e6e8 100644 > ---

Re: [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState

2018-11-20 Thread Igor Mammedov
On Mon, 19 Nov 2018 18:02:53 + "Boeuf, Sebastien" wrote: > On Mon, 2018-11-19 at 16:37 +0100, Igor Mammedov wrote: > > On Fri, 16 Nov 2018 19:42:08 + > > "Boeuf, Sebastien" wrote: > > > > > > > > Hi Igor, > > > > > > On Fri, 2018-11-16 at 10:39 +0100, Igor Mammedov wrote: > > > >

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-20 Thread balducci
hello > incomplete because it can return 0 for data. Can you try this: > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index f524e7d929..4878ffb90b 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@ -2002,14 +2002,9 @@ static int kvm_put_msrs(X86CPU *cpu, int level) > #endif

[Qemu-devel] [PATCH v2] usb-host: set ifs.detached as true if kernel driver is not active

2018-11-20 Thread linzhecheng
If no kernel driver is active, we can already claim and perform I/O on it without detaching it. Signed-off-by: linzhecheng diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index f31e9cbbb8..b6602ded4e 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1120,6 +1120,9 @@ stat

Re: [Qemu-devel] [PATCH] usb-host: set ifs.detached as true if kernel driver is not active

2018-11-20 Thread linzhecheng
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, November 20, 2018 4:25 PM > To: linzhecheng > Cc: qemu-devel@nongnu.org; Zhoujian (jay) ; > wangxin (U) > Subject: Re: [PATCH] usb-host: set ifs.detached as true if kernel driver is > not > active >

Re: [Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-11-20 Thread Hongbo Zhang
On Tue, 20 Nov 2018 at 16:16, Gerd Hoffmann wrote: > > Hi, > > > > But I assume you specifically want things that do a lot of DMA, so I > > > couldn't get away with asking for keeping it to the SBSA UART(s)? :) > > > > Ideally, it would be something that supports platform MSIs as well, > > but t

Re: [Qemu-devel] [PATCH 10/10] vhost-user-test: create a temporary directory per TestServer

2018-11-20 Thread Marc-André Lureau
On Thu, Nov 15, 2018 at 6:31 PM Paolo Bonzini wrote: > > This makes the tests more independent, and also the source and destination > TestServers in the migration test. > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > tests/vhost-user-test.c | 75 +++

Re: [Qemu-devel] [PATCH 04/10] vhost-user: support cross-endian vnet headers

2018-11-20 Thread Marc-André Lureau
Hi On Thu, Nov 15, 2018 at 6:31 PM Paolo Bonzini wrote: > > vhost-user already has a way to communicate the endianness of the guest > via the vring endianness messages. The vring endianness always matches > the vnet header endianness so there is no need to do anything else in > the backend. > >

Re: [Qemu-devel] [PATCH 08/10] vhost-user-test: create a main loop per TestServer

2018-11-20 Thread Marc-André Lureau
On Thu, Nov 15, 2018 at 6:31 PM Paolo Bonzini wrote: > > This makes the tests more independent and removes the need to defer > test_server_free > via an idle event source. > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > tests/vhost-user-test.c | 38 ---

Re: [Qemu-devel] [PATCH 02/10] vhost-user-test: signal data_cond when s->rings changes

2018-11-20 Thread Marc-André Lureau
On Thu, Nov 15, 2018 at 6:31 PM Paolo Bonzini wrote: > > This speeds up wait_for_rings_started, which currently is just waiting for > the timeout before checking s->rings. > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > tests/vhost-user-test.c | 2 ++ > 1 file changed,

Re: [Qemu-devel] [PATCH 05/10] vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN

2018-11-20 Thread Marc-André Lureau
Hi On Thu, Nov 15, 2018 at 6:31 PM Paolo Bonzini wrote: > > This will be useful to run the qtest for ppc64 targets on (for example) > x86_64 hosts. > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > tests/vhost-user-test.c | 8 +--- > 1 file changed, 5 insertions(+),

Re: [Qemu-devel] [PATCH 07/10] vhost-user-test: reduce usage of global_qtest

2018-11-20 Thread Marc-André Lureau
On Thu, Nov 15, 2018 at 6:31 PM Paolo Bonzini wrote: > > Whenever the code can run on multiple QTestStates, use them explicitly > instead of > global_qtest. > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > tests/vhost-user-test.c | 38 +-

Re: [Qemu-devel] [PATCH 01/10] vhost-user-test: use g_cond_broadcast

2018-11-20 Thread Marc-André Lureau
On Thu, Nov 15, 2018 at 6:31 PM Paolo Bonzini wrote: > > g_cond_signal is rarely the right thing to do, it works now because > vhost-user-test only has two threads but it is not correct in general. > Fix it before adding more calls. > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 03/10] vhost-net: compile it for all targets

2018-11-20 Thread Marc-André Lureau
Hi On Thu, Nov 15, 2018 at 10:42 PM Paolo Bonzini wrote: > > On 15/11/2018 15:31, Paolo Bonzini wrote: > > Currently vhost-net is compiled only for KVM-enabled targets. This is > > not needed anymore because ioeventfd is supported and emulated by the > > memory core. Compile it and vhost-user-t

[Qemu-devel] [PATCH] qapi: add query-display-options command

2018-11-20 Thread Gerd Hoffmann
Add query-display-options command, which allows to query the qemu display configuration, and -- as intentional side effect -- makes DisplayOptions discoverable via query-qmp-schema so libvirt can go figure which display options are supported. Cc: Eric Blake Cc: Erik Skultety Signed-off-by: Gerd

[Qemu-devel] [PATCH v2 5/9] test-string-input-visitor: Add more tests

2018-11-20 Thread David Hildenbrand
Test that very big/small values are not accepted and that ranges with only one element work. Also test that ranges are ascending and cannot have more than 65536 elements. Rename expect4 to expect5, as we will be moving that to a separate ulist test after the rework. Signed-off-by: David Hildenbra

[Qemu-devel] [PATCH v2 4/9] qapi: Use qemu_strtod_finite() in qobject-input-visitor

2018-11-20 Thread David Hildenbrand
Let's use the new function. Just as current behavior, we have to consume the whole string (now it's just way clearer what's going on). Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand --- qapi/qobject-input-visitor.c | 9 + 1 file changed, 5 inser

[Qemu-devel] [PATCH v2 1/9] cutils: Add qemu_strtod() and qemu_strtod_finite()

2018-11-20 Thread David Hildenbrand
Let's provide a wrapper for strtod(). Reviewed-by: Eric Blake Signed-off-by: David Hildenbrand --- include/qemu/cutils.h | 2 ++ util/cutils.c | 65 +++ 2 files changed, 67 insertions(+) diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h

[Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-20 Thread David Hildenbrand
The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in inconsistent behavior and ugly/magical code - uint64_t are parsed like int64_t, so big uint64_t values are not supported and error messages are misleading - lists/ran

[Qemu-devel] [PATCH v2 0/9] qapi: rewrite string-input-visitor

2018-11-20 Thread David Hildenbrand
Rewrite string-input-visitor to be (hopefully) less ugly. Support int and uint lists (including ranges, but not implemented via type "Range"). Virtual walks are now supported and more errors are cought (and some bugs fixed). Fix and extend the tests. Parsing of uint64_t is now properly supported.

[Qemu-devel] [PATCH v2 8/9] test-string-input-visitor: Split off uint64 list tests

2018-11-20 Thread David Hildenbrand
Basically copy all int64 list tests but adapt them to work on uint64 instead. The values for very big/very small values have to be adapted. Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 113 -- 1 file changed,

[Qemu-devel] [PATCH v2 2/9] cutils: Fix qemu_strtosz() & friends to reject non-finite sizes

2018-11-20 Thread David Hildenbrand
qemu_strtosz() & friends reject NaNs, but happily accept inifities. They shouldn't. Fix that. The fix makes use of qemu_strtod_finite(). To avoid ugly casts, change the @end parameter of qemu_strtosz() & friends from char ** to const char **. Also, add two test cases, testing that "inf" and "NaN"

[Qemu-devel] [PATCH v2 3/9] qapi: Fix string-input-visitor to reject NaN and infinities

2018-11-20 Thread David Hildenbrand
The string-input-visitor happily accepts NaN and inifities when parsing numbers (doubles). They shouldn't. Fix that. Also, add two test cases, testing if "NaN" and "inf" is properly rejected. Reviewed-by: Eric Blake Signed-off-by: David Hildenbrand --- qapi/string-input-visitor.c | 6 ++

[Qemu-devel] [PATCH v2 7/9] test-string-input-visitor: Use virtual walk

2018-11-20 Thread David Hildenbrand
We now support virtual walks, so use that instead. Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 36 +++ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/tests/test-string-input-visitor.c b/tes

[Qemu-devel] [PATCH v2 9/9] test-string-input-visitor: Add range overflow tests

2018-11-20 Thread David Hildenbrand
Let's make sure that the range handling code can properly deal with ranges that end at the biggest possible number. Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/test-st

Re: [Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-11-20 Thread Ard Biesheuvel
On Tue, 20 Nov 2018 at 09:49, Hongbo Zhang wrote: > > On Tue, 20 Nov 2018 at 16:16, Gerd Hoffmann wrote: > > > > Hi, > > > > > > But I assume you specifically want things that do a lot of DMA, so I > > > > couldn't get away with asking for keeping it to the SBSA UART(s)? :) > > > > > > Ideally,

Re: [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode

2018-11-20 Thread Daniel P . Berrangé
On Mon, Nov 19, 2018 at 11:00:38AM -0600, Eric Blake wrote: > On 11/19/18 4:37 AM, Daniel P. Berrangé wrote: > > > > Actually, I tracked this message down to using socat (which actually > > > connects and then abruptly exits) when probing whether the socket is up > > > and > > > listening. That

Re: [Qemu-devel] [PATCH for-3.1?] qtest: log QEMU command line

2018-11-20 Thread Thomas Huth
On 2018-11-15 13:29, Paolo Bonzini wrote: > Record the command line that was used to start QEMU. This can be > useful for debugging. > > Signed-off-by: Paolo Bonzini > --- > tests/libqtest.c | 26 +++--- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --git a/t

Re: [Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 09:45:23AM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Nov 19, 2018 at 5:59 PM Daniel P. Berrangé > wrote: > > > > When debugging QEMU it is often useful to put a breakpoint on the > > error_setg_internal method impl. > > > > Unfortunately the object_property_add / o

Re: [Qemu-devel] SeaBIOS booting time optimization

2018-11-20 Thread Stefano Garzarella
Hi Gerd, On Tue, Nov 20, 2018 at 7:21 AM Gerd Hoffmann wrote: > > Hi, > > > just an update, I enabled the debug prints and I saw two timeouts fired > > with a lot > > of time lost (~780ms between "init timer" and "Scan for VGA ..."), > > putting other prints I discovered that a lot of time is s

Re: [Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 01:57:01AM +0100, Samuel Thibault wrote: > g_spawn_async_with_fds is portable on Windows, so we can now enable > fork_exec support there. > > Thanks Daniel P. Berrangé for the notice! > > Signed-off-by: Samuel Thibault > --- > slirp/misc.c | 14 ++ > 1 file c

Re: [Qemu-devel] [PATCH for-4.0] s390x: introduce 4.0 compat machine

2018-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2018 12:05:48 +0100 Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-virtio-ccw.c | 17 - > include/hw/compat.h| 3 +++ > 2 files changed, 19 insertions(+), 1 deletion(-) Queued to s390-next.

Re: [Qemu-devel] [Qemu-arm] more serial ports on arm?

2018-11-20 Thread Peter Maydell
On 19 November 2018 at 23:46, Jason A. Donenfeld wrote: > Hey guys, > > I sort of lost track of the discussion, but what ever happened to > adding an extra serial port to the arm virt machine? I'm still > carrying around the attached patch to run build.wireguard.com and I'd > of course like to see

Re: [Qemu-devel] [PATCH v2 09/10] pci/shpc: perform unplug via the hotplug handler

2018-11-20 Thread David Hildenbrand
>> diff --git a/hw/pci-bridge/pcie_pci_bridge.c >> b/hw/pci-bridge/pcie_pci_bridge.c >> index c634353b06..7c667bc97c 100644 >> --- a/hw/pci-bridge/pcie_pci_bridge.c >> +++ b/hw/pci-bridge/pcie_pci_bridge.c >> @@ -150,6 +150,19 @@ static void pcie_pci_bridge_plug_cb(HotplugHandler >> *hotplug_dev,

Re: [Qemu-devel] [PATCH] MAINTAINERS: Assign some more files in the hw/arm/ directory

2018-11-20 Thread Peter Maydell
On 19 November 2018 at 19:57, Thomas Huth wrote: > I apparently missed some more files and even a complete machine (the > "imx25-pdk") in my previous patch... but now we should hopefully have > a completely coverage for all available ARM boards. Hi; looks like you forgot to cc qemu-devel. > Fixe

Re: [Qemu-devel] [PULL 00/12] NBD patches for 3.1-rc2

2018-11-20 Thread Peter Maydell
On 19 November 2018 at 17:54, Eric Blake wrote: > The following changes since commit e6ebbd46b6e539f3613136111977721d212c2812: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-11-19 14:31:48 +) > > are available in the Git repository at: > > https://

Re: [Qemu-devel] [PATCH v2 2/5] util: introduce threaded workqueue

2018-11-20 Thread Xiao Guangrong
On 11/14/18 2:38 AM, Emilio G. Cota wrote: On Tue, Nov 06, 2018 at 20:20:22 +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong This modules implements the lockless and efficient threaded workqueue. (snip) +++ b/util/threaded-workqueue.c +struct Threads { +/* + * in order

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2018 19:32:32 -0200 Eduardo Habkost wrote: > However, I wish this kind of usability magic didn't automatically > imposed us the burden of keeping guest ABI compatibility too. > Keeping ABI compatibility on the machine-friendly device types and > interfaces is already hard enough.

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Daniel P . Berrangé
On Mon, Nov 19, 2018 at 10:44:54PM -0200, Eduardo Habkost wrote: > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > > On Thu, 15 Nov 2018 10:05:59 + > > Daniel P. Berrangé wrote: > > > > > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > > > > Many of the cur

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2018 22:44:54 -0200 Eduardo Habkost wrote: > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > > On Thu, 15 Nov 2018 10:05:59 + > > Daniel P. Berrangé wrote: > > > If libvirt did this compatibility approach, can you > > > confirm this would be live migration st

[Qemu-devel] [PULL 0/3] qtest patches

2018-11-20 Thread Thomas Huth
Hi Peter, the following changes since commit d304cf014bf9feec3dcd7ee65c75a7f52206ecdf: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181119' into staging (2018-11-19 15:58:17 +) are available in the git repository at: https://gitlab.com/huth/qemu.git tags/pull-

[Qemu-devel] [PULL 2/3] tests/ide: Free pcibus when finishing a test

2018-11-20 Thread Thomas Huth
Once a test has finished, the pcibus structure should be freed, to avoid leaking memory and to make sure that the structure is properly re-initialized when the next test starts. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Signed-off-by: Thomas Huth --- t

[Qemu-devel] [PULL 1/3] tests: add qmp/missing-any-arg test

2018-11-20 Thread Thomas Huth
From: Marc-André Lureau test_qmp_missing_any_arg() is about a bug in infrastructure used by the QMP core, fixed in commit c489780203. We covered the bug in infrastructure unit tests (commit bce3035a44). Let's test it at the QMP level as well. Signed-off-by: Marc-André Lureau Reviewed-by: Thom

[Qemu-devel] [PULL 3/3] qtest: log QEMU command line

2018-11-20 Thread Thomas Huth
From: Paolo Bonzini Record the command line that was used to start QEMU. This can be useful for debugging. Signed-off-by: Paolo Bonzini Reviewed-by: Laurent Vivier [thuth: removed trailing \n from the message string] Signed-off-by: Thomas Huth --- tests/libqtest.c | 26 +++--

Re: [Qemu-devel] [PULL 0/1] Seabios 1.12 20181120 patches

2018-11-20 Thread Peter Maydell
emu tags/seabios-1.12-20181120-pull-request > > for you to fetch changes up to af51dbed380b7eec0c815da1c37b46e57a909ce8: > > update seabios to 1.12 (2018-11-20 06:57:53 +0100) > > -

[Qemu-devel] [PATCH v3 00/11] pci: hotplug handler reworks

2018-11-20 Thread David Hildenbrand
This series reworks some pci hotplug handlers (except for s390, that will require more work but is not required for now). 1. Route all unplug calls via the hotplug handler when called from the unplug_request handler. This will be required to get multi-stage hotplug handlers running, but also

[Qemu-devel] [PATCH v3 02/11] pci/shpc: rename hotplug handler callbacks

2018-11-20 Thread David Hildenbrand
The callbacks are also called for cold plugged devices. Drop the "hot" to better match the actual callback names. While at it, also rename shpc_device_hotplug_common() to shpc_device_plug_common(). Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/pc

[Qemu-devel] [PATCH v3 05/11] pci/pcihp: perform check for bus capability in pre_plug handler

2018-11-20 Thread David Hildenbrand
Perform the check in the pre_plug handler. In addition, we need the capability only if the device is actually hotplugged (and not created during machine initialization). This is a preparation for coldplugging pci devices via that hotplug handler. Reviewed-by: Igor Mammedov Signed-off-by: David Hi

[Qemu-devel] [PATCH v3 03/11] s390x/pci: rename hotplug handler callbacks

2018-11-20 Thread David Hildenbrand
The callbacks are also called for cold plugged devices. Drop the "hot" to better match the actual callback names. Reviewed-by: David Gibson Reviewed-by: Cornelia Huck Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/s390x/s390-pci-bus.c | 12 ++-- 1 file changed, 6 i

[Qemu-devel] [PATCH v3 01/11] pci/pcie: rename hotplug handler callbacks

2018-11-20 Thread David Hildenbrand
The callbacks are also called for cold plugged devices. Drop the "hot" to better match the actual callback names. While at it, also rename pcie_cap_slot_hotplug_common() to pcie_cap_slot_plug_common(). Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PATCH v3 07/11] pci/pcihp: perform unplug via the hotplug handler

2018-11-20 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

[Qemu-devel] [PATCH v3 06/11] pci/pcihp: overwrite hotplug handler recursively from the start

2018-11-20 Thread David Hildenbrand
For now, the hotplug handler is not called for devices that are being cold plugged. The hotplug handler is setup when the machine initialization is fully done. Only bridges that were cold plugged are considered. Set the hotplug handler for the root piix bus directly when realizing. Overwrite the h

[Qemu-devel] [PATCH v3 09/11] pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge

2018-11-20 Thread David Hildenbrand
These functions are essentially the same, we only have to use object_get_typename() for reporting errors. So let's share the implementation of hotplug handler callbacks. Suggested-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/pci-bridge/pci_bridge_dev.c | 12 ++-- hw/pci-br

[Qemu-devel] [PATCH v3 04/11] pci/pcie: stop plug/unplug if the slot is locked

2018-11-20 Thread David Hildenbrand
We better stop right away. For now, errors would be partially ignored (so the guest might get informed or the device might get unplugged), although actual plug/unplug will be reported as failed to the user. While at it, properly move the check to the pre_plug handler for the plug case, as we can t

Re: [Qemu-devel] [PATCH] MAINTAINERS: Assign some more files in the hw/arm/ directory

2018-11-20 Thread Thomas Huth
On 2018-11-20 11:19, Peter Maydell wrote: > On 19 November 2018 at 19:57, Thomas Huth wrote: >> I apparently missed some more files and even a complete machine (the >> "imx25-pdk") in my previous patch... but now we should hopefully have >> a completely coverage for all available ARM boards. > >

[Qemu-devel] [PATCH v3 10/11] pci/shpc: perform unplug via the hotplug handler

2018-11-20 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

[Qemu-devel] [PATCH v3 08/11] pci/pcie: perform unplug via the hotplug handler

2018-11-20 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

[Qemu-devel] [PATCH v3 11/11] spapr_pci: perform unplug via the hotplug handler

2018-11-20 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

Re: [Qemu-devel] [PATCH] MAINTAINERS: Assign some more files in the hw/arm/ directory

2018-11-20 Thread Auger Eric
Hi Thomas, On 11/20/18 12:05 PM, Thomas Huth wrote: > On 2018-11-20 11:19, Peter Maydell wrote: >> On 19 November 2018 at 19:57, Thomas Huth wrote: >>> I apparently missed some more files and even a complete machine (the >>> "imx25-pdk") in my previous patch... but now we should hopefully have >>

Re: [Qemu-devel] SeaBIOS booting time optimization

2018-11-20 Thread Gerd Hoffmann
Hi, > > Background: The drivers in seabios work on both virtual and physical > > hardware (you can run seabios as coreboot payload on physical hardware). > > There are quite a few places where are delays and timeouts which are > > required to work properly on physical hardware. But typically v

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-20 Thread Marc-André Lureau
Hi On Tue, Nov 20, 2018 at 12:02 PM Marc-André Lureau wrote: > > Hi > > On Tue, Nov 20, 2018 at 11:24 AM P J P wrote: > > > > From: Prasad J Pandit > > > > While performing mmio device r/w operations, guest could set 'addr' > > parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5

Re: [Qemu-devel] [PULL 0/3] qtest patches

2018-11-20 Thread Peter Maydell
On 20 November 2018 at 10:52, Thomas Huth wrote: > Hi Peter, > > the following changes since commit d304cf014bf9feec3dcd7ee65c75a7f52206ecdf: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20181119' into staging (2018-11-19 > 15:58:17 +) > > are available in the

Re: [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker

2018-11-20 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Nested VMX does not support live migration yet. Add a blocker > until that is worked out. > > Nested SVM only does not support it, but unfortunately it is > enabled by default for -cpu host so we cannot really disable it. > > Signed-off-by: Paolo Bo

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Eduardo Habkost
On Tue, Nov 20, 2018 at 11:52:27AM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 22:44:54 -0200 > Eduardo Habkost wrote: > > > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > > > On Thu, 15 Nov 2018 10:05:59 + > > > Daniel P. Berrangé wrote: > > > > > If libvirt did thi

Re: [Qemu-devel] [PATCH v2 09/10] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-11-20 Thread Marc-André Lureau
On Thu, Nov 1, 2018 at 6:59 PM Igor Mammedov wrote: > > On Tue, 30 Oct 2018 19:04:52 +0400 > Marc-André Lureau wrote: > > > The following patch is going to add compatiblity parameters. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Igor Mammedov pi

[Qemu-devel] [PULL 0/1] 9p fixes for v3.1.0-rc2

2018-11-20 Thread Greg Kurz
The following changes since commit 3c035a41dca808f096a128fe2b62d849fe638a25: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-11-20' into staging (2018-11-20 10:56:57 +) are available in the Git repository at: https://github.com/gkurz/qemu.git tags/for-upstream

[Qemu-devel] [PULL 1/1] 9p: take write lock on fid path updates (CVE-2018-19364)

2018-11-20 Thread Greg Kurz
Recent commit 5b76ef50f62079a fixed a race where v9fs_co_open2() could possibly overwrite a fid path with v9fs_path_copy() while it is being accessed by some other thread, ie, use-after-free that can be detected by ASAN with a custom 9p client. It turns out that the same can happen at several loca

Re: [Qemu-devel] [PATCH for-3.2 v2] vhost-user: define conventions for vhost-user backends

2018-11-20 Thread Marc-André Lureau
Hi On Mon, Nov 12, 2018 at 8:03 PM Daniel P. Berrangé wrote: > > On Wed, Nov 07, 2018 at 07:13:11PM +0400, Marc-André Lureau wrote: > > As discussed during "[PATCH v4 00/29] vhost-user for input & GPU" > > review, let's define a common set of backend conventions to help with > > management layer i

Re: [Qemu-devel] [PATCH 1/6 for-3.1] nbd: fix whitespace in server error message

2018-11-20 Thread Philippe Mathieu-Daudé
On 16/11/18 17:01, Eric Blake wrote: On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: A space was missing after the option number was printed:    Option 0x8not permitted before TLS becomes    Option 0x8 not permitted before TLS This fixes    commit 3668328303429f3bc93ab3365c66331600b06a2d   

Re: [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker

2018-11-20 Thread Paolo Bonzini
On 20/11/18 12:44, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Nested VMX does not support live migration yet. Add a blocker >> until that is worked out. >> >> Nested SVM only does not support it, but unfortunately it is >> enabled by default for -cpu host so we

[Qemu-devel] [PATCH 0/5] tcg: Make bswap support in qemu_ld/st optional

2018-11-20 Thread Richard Henderson
Having to support bswap in the guest memory operations at times requires an irritating number of temporaries. Better to allow the bswap operations to be expanded outside of the memory ops and let register allocation do its thing. This is something that I've been planning to do for some time, to a

[Qemu-devel] [PATCH 2/5] tcg/optimize: Optimize bswap

2018-11-20 Thread Richard Henderson
Somehow we forgot these operations, once upon a time. This will allow immediate stores to have their bswap optimized away. Signed-off-by: Richard Henderson --- tcg/optimize.c | 12 1 file changed, 12 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 5dbe11c3c8..6b98e

[Qemu-devel] [PATCH 1/5] tcg: Add TCG_TARGET_HAS_MEMORY_BSWAP

2018-11-20 Thread Richard Henderson
For now, defined universally as true, since we previously required backends to implement swapped memory operations. Future patches may now remove that support where it is onerous. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 1 + tcg/arm/tcg-target.h | 1 + tcg/i386/t

[Qemu-devel] [PATCH 4/5] tcg/aarch64: Set TCG_TARGET_HAS_MEMORY_BSWAP to false

2018-11-20 Thread Richard Henderson
This allows us to remove some code from the backend, allowing the generic code to emit any extra bswaps. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 63 2 files changed, 14 insertions(+), 51 deleti

[Qemu-devel] [PATCH 5/5] tcg/arm: Set TCG_TARGET_HAS_MEMORY_BSWAP to false

2018-11-20 Thread Richard Henderson
This allows us to remove some code from the backend, allowing the generic code to emit any extra bswaps. It also allows us to avoid reserving an extra register for CONFIG_USER_ONLY. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.h | 2 +- tcg/arm/tcg-target.inc.c | 198 ++

[Qemu-devel] [PATCH 3/5] tcg/i386: Set TCG_TARGET_HAS_MEMORY_BSWAP with have_movbe

2018-11-20 Thread Richard Henderson
This allows us to remove some code from the backend, allowing the generic code to emit any extra bswaps. This does not quite allow all of the cleanup that should be possible, as we still must take care of i386 storing bytes from non 'q' registers. Signed-off-by: Richard Henderson --- tcg/i386/t

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Andrea Bolognani
On Mon, 2018-11-19 at 14:14 -0500, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote: > > On Mon, 19 Nov 2018 13:42:58 -0500 "Michael S. Tsirkin" > > wrote: > > > We have this assumption that if we force a choice then people will > > > choose the right thin

[Qemu-devel] When AioHandler->is_external=true?

2018-11-20 Thread Dongli Zhang
Hi, Would you please help explain in which case AioHandler->is_external is true, and when it is false? I read about iothread and mainloop and I am little bit confused about it. Thank you very much! Dongli Zhang

Re: [Qemu-devel] [RFC PATCH 1/1] target/ppc: support single stepping with KVM HV

2018-11-20 Thread Philippe Mathieu-Daudé
Hi Fabiano, You should Cc the relevant maintainers to get more attention. You can check this wiki page: https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer $ ./scripts/get_maintainer.pl -f accel/kvm/kvm-all.c include/sysemu/kvm.h target/*/kvm.c Paolo Bonzini (supporter:Ov

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-20 Thread Igor Mammedov
On Mon, 19 Nov 2018 18:14:26 +0100 Paolo Bonzini wrote: > On 19/11/18 16:31, Igor Mammedov wrote: > > I've tried to give suggestions how to restructure series > > on per patch basis. In my opinion it quite possible to split > > series in several smaller ones and it should really help with > > mak

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-20 Thread Peter Maydell
On 11 November 2018 at 21:24, Berkus Decker wrote: > It seems that Cocoa checks are stricter on Mojave and some callbacks that > worked from non-GUI thread on High Sierra are no longer working. > > The fixes included here are: > > * Deferring qemu_main() to another thread so that the actual main

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-20 Thread Peter Maydell
On 13 November 2018 at 12:12, Programmingkid wrote: >> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: >> These changes are ought to work on OSX 10.6, although I don?t have a machine >> handy to test it. > > I have Mac OS 10.6 available for testing. This is perhaps a good point to ask the ques

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 01:09:54PM +, Peter Maydell wrote: > On 13 November 2018 at 12:12, Programmingkid > wrote: > >> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: > >> These changes are ought to work on OSX 10.6, although I don?t have a > >> machine handy to test it. > > > > I have Ma

Re: [Qemu-devel] [PULL 0/1] 9p fixes for v3.1.0-rc2

2018-11-20 Thread Peter Maydell
On 20 November 2018 at 12:03, Greg Kurz wrote: > The following changes since commit 3c035a41dca808f096a128fe2b62d849fe638a25: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-11-20' into staging (2018-11-20 > 10:56:57 +) > > are available in the Git repository

Re: [Qemu-devel] [PATCH for 3.1] x86: Add 3.1 machine types

2018-11-20 Thread Peter Maydell
On 15 November 2018 at 19:48, Marc-André Lureau wrote: > On Thu, Nov 15, 2018 at 7:47 PM Dr. David Alan Gilbert (git) > wrote: >> >> From: "Dr. David Alan Gilbert" >> >> x86 doesn't need a 3.1 machine type, because there's no incompatibility, >> but it looks odd not having one, especially since

[Qemu-devel] [PATCH for-3.1] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-11-20 Thread Marc-André Lureau
We have a couple of PC_COMPAT_3_0, so we should have 3.1 PC machines, and update the 3.0 machines to make use of those. Fixes a "Known issue" from https://wiki.qemu.org/Planning/3.1. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Reviewed-by: Eduardo Habkost Reviewed-by: Igor

[Qemu-devel] panic in virtio_gpu in guest centos7.5

2018-11-20 Thread yezengruan
Hi, all When I run qemu (2.8.1 or 3.0.0) with guest os centos 7.5(kernel 4.14.0-49.el7a.aarch64), I got panic in virtio_gpu. My test steps are as follows: 1) Start the centos 7.5 virtual machine. 2) Enter a bunch of commands in VNC. 3) After enter 'top' command in VNC, continuously enter shift +

[Qemu-devel] Can't see mouse cursor on VNC viewer

2018-11-20 Thread Guoheyi
Hi folks, I'm using qemu 2.8 on ARM64 with KVM enabled, and TightVNC on MS Windows as a VNC viewer. We can see the graphic screen on VNC viewer, but we can't see the mouse cursor after we enable "Mouse Cursor -> Let remote server deal with cursor". When I move or click on VNC viewer screen, we

Re: [Qemu-devel] [PATCH 03/10] hyperv: only add SynIC in compatible configurations

2018-11-20 Thread Eduardo Habkost
On Fri, Sep 21, 2018 at 11:22:10AM +0300, Roman Kagan wrote: > Certain configurations do not allow SynIC to be used in QEMU. In > particular, > > - when hyperv_vpindex is off, SINT routes can't be used as they refer to > the destination vCPU by vp_index > > - older KVM (which doesn't expose KV

Re: [Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-20 Thread Peter Maydell
On 13 November 2018 at 16:52, Samuel Ortiz wrote: > Most of them are TCG dependent so we want to be able to not build them > in order to support TCG disablement with ARM. > > Signed-off-by: Samuel Ortiz > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Robert Bradford > --- > target/arm/excp_

[Qemu-devel] [PULL 0/1] [for -rc2] pc-*-3.1 machine-types

2018-11-20 Thread Eduardo Habkost
Hopefully in time for -rc2. commit 9b4cf107 ("hyperv: only add SynIC in compatible configurations") breaks compatibility on pc-*-3.0, so this is required as a bug fix. The following changes since commit 46cabfb41e9cb269affc14c8188f0c8745f8cd55: Merge remote-tracking branch 'remotes/gkurz/tags/

[Qemu-devel] [PULL 1/1] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-11-20 Thread Eduardo Habkost
From: Marc-André Lureau We have a couple of PC_COMPAT_3_0, so we should have 3.1 PC machines, and update the 3.0 machines to make use of those. Fixes a "Known issue" from https://wiki.qemu.org/Planning/3.1. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Reviewed-by: Eduardo

Re: [Qemu-devel] [PATCH 03/13] target: arm: Move all v7m helpers into their own file

2018-11-20 Thread Peter Maydell
On 13 November 2018 at 16:52, Samuel Ortiz wrote: > In preparation for supporting TCG disablement on ARM, we move all TCG > related v7m helpers and APIs into their own file (m_helper.c for all > v*-m helpers). > arm_v7m_cpu_do_interrupt pulls a large number of static functions > out of helper.c in

Re: [Qemu-devel] [PATCH 07/13] target: arm: Remove the LDST headers

2018-11-20 Thread Peter Maydell
On 13 November 2018 at 16:52, Samuel Ortiz wrote: > They are no longer needed. ...because a previous patch moved the code using them out to excp_helper.c. > Signed-off-by: Samuel Ortiz > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Robert Bradford >

Re: [Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-20 Thread Peter Maydell
On 13 November 2018 at 16:52, Samuel Ortiz wrote: > Most of them are TCG dependent so we want to be able to not build them > in order to support TCG disablement with ARM. > > Signed-off-by: Samuel Ortiz > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Robert Bradford > --- > target/arm/excp_

Re: [Qemu-devel] [RFC PATCH 1/1] target/ppc: support single stepping with KVM HV

2018-11-20 Thread Philippe Mathieu-Daudé
On 20/11/18 13:40, Philippe Mathieu-Daudé wrote: Hi Fabiano, You should Cc the relevant maintainers to get more attention. You can check this wiki page: https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer $ ./scripts/get_maintainer.pl -f accel/kvm/kvm-all.c include/sysemu/

Re: [Qemu-devel] [PATCH 11/13] target: arm: Define TCG dependent functions when TCG is enabled

2018-11-20 Thread Peter Maydell
On 13 November 2018 at 16:52, Samuel Ortiz wrote: > do_interrupt, do_unaligned_access, do_transaction_failed and debug_excp > are only relevant in the TCG context, so we should not define them > when TCG is disabled. > > Signed-off-by: Samuel Ortiz > Reviewed-by: Philippe Mathieu-Daudé > Tested-

  1   2   3   4   >