On 13 November 2018 at 16:52, Samuel Ortiz <sa...@linux.intel.com> wrote: > Most of them are TCG dependent so we want to be able to not build them > in order to support TCG disablement with ARM. > > Signed-off-by: Samuel Ortiz <sa...@linux.intel.com> > Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Reviewed-by: Robert Bradford <robert.bradf...@intel.com> > --- > target/arm/excp_helper.c | 550 +++++++++++++++++++++++++++++++++++++++ > target/arm/helper.c | 531 ------------------------------------- > target/arm/Makefile.objs | 2 +- > 3 files changed, 551 insertions(+), 532 deletions(-) > create mode 100644 target/arm/excp_helper.c
You'll find that you need to rebase as there is a recent change that your moved copies are missing: commit e24ad484909e7. (I have just discovered git diff's --color-moved option which is great for checking this sort of code-movement patch.) What is your plan for dealing with the way that the KVM code for injecting a breakpoint exception into the guest works by calling the do_interrupt code ? (see target/arm/kvm64.c:kvm_arm_handle_debug(), which calls cc->do_interrupt(cs).) This patch moves those functions to a file which won't be compiled and a later one in the series seems to stop cc->do_interrupt being set at all if CONFIG_TCG is not defined. That will result in QEMU crashing when it tries to inject an exception, won't it? thanks -- PMM
