Rewrite string-input-visitor to be (hopefully) less ugly. Support int and uint lists (including ranges, but not implemented via type "Range").
Virtual walks are now supported and more errors are cought (and some bugs fixed). Fix and extend the tests. Parsing of uint64_t is now properly supported. Importantly, when parsing a list we now return the list and not an ordered set (we are not an ordered set parser after all). Whoever needs that can add it on top. As far as I can see, current code can deal with it but I'll have to look at the details. While at it, introduce and use qemu_strtod() and qemu_strtod_finite(). However don't convert monitor.c as that seems to be too broken for me (it ignores both conversion errors and range errors, and there is an actual unit test in which conversion is expected to fail). v1 -> v2: - "cutils: Add qemu_strtod() and qemu_strtod_finite()" -- Add a proper documentation -- Make -EINVAL perform "no conversion" in qemu_strtod_finite(). - "cutils: Fix qemu_strtosz() & friends to reject non-finite sizes" -- New subject/description -- Added test case -- Forward -ERANGE - "qapi: Fix string-input-visitor to reject NaN and infinities" -- New subject/description -- Added test case - "test-string-input-visitor: Add more tests" -- Add even more tests (descending range, overflow, range limit) - "qapi: Rewrite string-input-visitor" -- Accept ranges with one element (e.g. 1-1) -- Bail out on big ranges (just like before) -- Minor style fixed + description updates - "test-string-input-visitor: split off uint64 list tests" -- ALso copy + adapt newly added tests for int64 lists RFC -> v1: - Too much to name it all, just some highlights - Pull some tests before the rework - Introduce qemu_strtod_finite() and use it in more places - More tests - "qapi: rewrite string-input-visitor" -- programming error -> assert -- g_assert() -> assert(), g_assert_not_reached() -> abort() -- Accept single-element ranges "1-1" -- Split parsing and returning the next range element -- Minor style fixes David Hildenbrand (9): cutils: Add qemu_strtod() and qemu_strtod_finite() cutils: Fix qemu_strtosz() & friends to reject non-finite sizes qapi: Fix string-input-visitor to reject NaN and infinities qapi: Use qemu_strtod_finite() in qobject-input-visitor test-string-input-visitor: Add more tests qapi: Rewrite string-input-visitor test-string-input-visitor: Use virtual walk test-string-input-visitor: Split off uint64 list tests test-string-input-visitor: Add range overflow tests include/qapi/string-input-visitor.h | 4 +- include/qemu/cutils.h | 8 +- monitor.c | 2 +- qapi/qobject-input-visitor.c | 9 +- qapi/string-input-visitor.c | 413 ++++++++++++++++------------ tests/test-cutils.c | 24 +- tests/test-string-input-visitor.c | 223 ++++++++++++--- util/cutils.c | 81 +++++- 8 files changed, 516 insertions(+), 248 deletions(-) -- 2.17.2
