On 11/14/18 11:27 AM, Edgar E. Iglesias wrote:
> On Wed, Nov 14, 2018 at 09:43:27AM +0100, Luc Michel wrote:
>> Hi Edgar,
>>
>> On 11/13/18 12:06 PM, Edgar E. Iglesias wrote:
>>> On Sat, Nov 10, 2018 at 09:11:34AM +0100, Luc Michel wrote:
The gdb_get_cpu_pid() function does the PID lookup f
From: Li Qiang
And also the g_malloc doesn't need check return value,
remove it.
Cc: qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
---
target/i386/hax-all.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
ind
On 15/11/2018 07:05, Li Qiang wrote:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-triv...@nongnu.org
>
> Signed-off-by: Li Qiang
> ---
> target/i386/hax-all.c | 15 +++
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
Reviewed-by: Laurent
Hi, the list,
I am trying to boot a FreeBSD guest but failed. It hangs at the
kernel booting phase:
/boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68 syms=[0x8+0x159ee8+0x8
Booting...
(nothing more)
It's just as simple as downloading the image and boot so I can't think
of anything stran
This patches provide qmp interface to query/set io throttle parameters of a
fsdev.
Some of patches also refactor the code and structure that was present in block
and fsdev files.
xiezhide (4):
fsdev-throttle-qmp: factor out throttle code to reuse code
fsdev-throttle-qmp: move struct Throttl
this patch move ThrottleLimits to new file and rename struct
field with common format
Signed-off-by: xiezhide
---
Makefile | 9 +++
Makefile.objs | 4 ++
blockdev.c| 51 +---
qapi/block-core.json | 122 +
qapi
provides two interfaces:
1. set the IO limits for the required fsdev device
2. query info of all the fsdev devices.
Signed-off-by: xiezhide
---
Makefile| 9 +
Makefile.objs | 4 ++
fsdev/qemu-fsdev-dummy.c| 11 +
fsdev/qemu-fsdev-throttle.c | 98 ++
introduces io throttling hmp interfaces for the fsdev devices
Signed-off-by: xiezhide
---
hmp-commands-info.hx | 15 ++
hmp-commands.hx | 15 ++
hmp.c| 83 +++-
hmp.h| 4 +++
qapi/tlimits.json
This patch factor out throttle parameter parse code to common function
which will be used by block and fsdev.
rename function throttle_parse_options to throttle_parse_group to resolve
function name conflict
Signed-off-by: xiezhide
---
block/throttle.c| 6 ++--
blockdev.c
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Message-id: 20181115020334.1189829-1-ebl...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v2 for-4.0 00/13]
When the parse_keyboard_layout() find a "include " line
in the keyboard layout file, it will call parse_keyboard_layout()
to perform a recursive parse. If the keyboard layout is malformed
by adding a line include itself, this can cause an infinite parse.
Thus cause qemu a segv. This patch avoid thi
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Message-id: 20181115020334.1189829-1-ebl...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v2 for-4.0 00/13]
ping
On 07/11/2018 13:19, Nick Hudson wrote:
noload kernels are loaded with the u-boot image header and as a result
the header size needs adding to the entry point. Fake up a hdr so the
kernel image is loaded at the right address and the entry point is
adjusted appropriately
Signed-off-by: Nic
This commit adds the cpu-cluster type. It aims at gathering CPUs from
the same cluster in a machine.
For now it only has a `cluster-id` property.
Signed-off-by: Luc Michel
Reviewed-by: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Edgar E.
changes since v5:
- patch 1Rebased on top of master
- patch 2Cluster ID handling hardening to ensure uint32_t overflow
won't cause PID 0 to be used [Edgar]
- patch 2Fix the GDB process ordering function to avoid uint32_t
overflow when comparing two
Add a structure GDBProcess that represent processes from the GDB
semantic point of view.
CPUs can be split into different processes, by grouping them under
different cpu-cluster objects. Each occurrence of a cpu-cluster object
implies the existence of the corresponding process in the GDB stub. Th
Add multiprocess extension support by enabling multiprocess mode when
the peer requests it, and by replying that we actually support it in the
qSupported reply packet.
Signed-off-by: Luc Michel
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Alistair Francis
---
gdbstub.c | 6 ++
1 file chan
Add a couple of helper functions to cope with GDB threads and processes.
The gdb_get_process() function looks for a process given a pid.
The gdb_get_cpu() function returns the CPU corresponding to the (pid,
tid) pair given as parameters.
The read_thread_id() function parses the thread-id sent by
The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It
checks if the CPU is a direct child of a CPU cluster. If it is, the
returned PID is the cluster ID plus one (cluster IDs start at 0, GDB
PIDs at 1). When the CPU is not a child of such a container, the PID of
the first process
Add the gdb_first_cpu() and gdb_next_cpu() to iterate over all
the CPUs in currently attached processes.
Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to
iterate over CPUs of a given process.
Use them to add multiprocess extension support to vCont packets.
Signed-off-by: Luc M
When a new connection is established, we set the first process to be
attached, and the others detached. The first CPU of the first process
is selected as the current CPU.
Signed-off-by: Luc Michel
Reviewed-by: Alistair Francis
---
gdbstub.c | 20 +++-
1 file changed, 15 insertio
Add support for multiprocess extension in gdb_vm_state_change()
function.
Signed-off-by: Luc Michel
Reviewed-by: Philippe Mathieu-Daudé
---
gdbstub.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 4cbc81ae5b..5df9929f92 100644
--
Add support for the vAttach packets. In multiprocess mode, GDB sends
them to attach to additional processes.
Signed-off-by: Luc Michel
---
gdbstub.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/gdbstub.c b/gdbstub.c
index ada53ac559..0427d1c4f0 100644
'D' packets are used by GDB to detach from a process. In multiprocess
mode, the PID to detach from is sent in the request.
Signed-off-by: Luc Michel
Reviewed-by: Philippe Mathieu-Daudé
---
gdbstub.c | 60 ---
1 file changed, 53 insertions(+),
Change the thread info related packets handling to support multiprocess
extension.
Add the CPUs class name in the extra info to help differentiate
them in multiprocess mode.
Signed-off-by: Luc Michel
Reviewed-by: Philippe Mathieu-Daudé
---
gdbstub.c | 35 +--
1
Create two separate CPU clusters for APUs and RPUs.
Signed-off-by: Luc Michel
Reviewed-by: Edgar E. Iglesias
---
include/hw/arm/xlnx-zynqmp.h | 3 +++
hw/arm/xlnx-zynqmp.c | 21 +
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/include/hw/arm/xlnx-zy
When gdb_set_stop_cpu() is called with a CPU associated to a process
currently not attached by the GDB client, return without modifying the
stop CPU. Otherwise, GDB gets confused if it receives packets with a
thread-id it does not know about.
Signed-off-by: Luc Michel
Acked-by: Alistair Francis
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181115032259.23968-1-sjitindarsi...@gmail.com
Type: series
Subject: [Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: tcg: Implement addex
instruction
=== TEST SCRIPT BEGIN ===
#!/bin/bash
Alistair Francis writes:
> On 14/11/2018 3:12 am, Peter Maydell wrote:
>> On 13 November 2018 at 20:10, Alistair Francis wrote:
>>> These two and the Xilinx boards seem a little out of place in this
>>> patch. I agree they probably aren't maintained as well as they should
>>> be, but the patch
Change the sC packet handling to support the multiprocess extension.
Instead of returning the first thread, we return the first thread of the
current process.
Signed-off-by: Luc Michel
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
gdbstub.c | 11 ---
1 file chan
Change the Xfer:features:read: packet handling to support the
multiprocess extension. This packet is used to request the XML
description of the CPU. In multiprocess mode, different descriptions can
be sent for different processes.
This function now takes the process to send the description for as
On 15 November 2018 at 09:22, Nick Hudson wrote:
> ping
Hi; thanks for the ping. This patch is in my to-review queue but it
may be a little while til I get to it, as I'm currently prioritising
work for the 3.1 release, and this will be a new feature for 4.0.
thanks
-- PMM
Add support for the '!' extended mode packet. This is required for the
multiprocess extension.
Signed-off-by: Luc Michel
---
gdbstub.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gdbstub.c b/gdbstub.c
index eec1cf0d09..ada53ac559 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1294,10 +129
On 15 November 2018 at 09:51, Alex Bennée wrote:
>
> Alistair Francis writes:
>
>> On 14/11/2018 3:12 am, Peter Maydell wrote:
>>> On 13 November 2018 at 20:10, Alistair Francis wrote:
These two and the Xilinx boards seem a little out of place in this
patch. I agree they probably aren'
On Thu, Nov 15, 2018 at 02:22:59PM +1100, Suraj Jitindar Singh wrote:
> Implement the addex instruction introduced in ISA V3.00 in qemu tcg.
>
> The add extended using alternate carry bit (addex) instruction performs
> the same operation as the add extended (adde) instruction, but using the
> over
Li Qiang writes:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-triv...@nongnu.org
>
> Signed-off-by: Li Qiang
Reviewed-by: Alex Bennée
> ---
> target/i386/hax-all.c | 15 +++
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git
On 15/11/18 9:58, Peter Xu wrote:
Hi, the list,
I am trying to boot a FreeBSD guest but failed. It hangs at the
kernel booting phase:
/boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68 syms=[0x8+0x159ee8+0x8
Booting...
(nothing more)
It's just as simple as downloading the image and boo
On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote:
> Many of the current virtio-*-pci device types actually represent
> 3 different types of devices:
> * virtio 1.0 non-transitional devices
> * virtio 1.0 transitional devices
> * virtio 0.9 ("legacy device" in virtio 1.0 terminology)
David Hildenbrand writes:
> On 14.11.18 18:38, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> The input visitor has some problems right now, especially
>>> - unsigned type "Range" is used to process signed ranges, resulting in
>>> inconsistent behavior and ugly/magical code
>>>
David Hildenbrand writes:
> On 14.11.18 17:21, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> Basically copy all int64 list tests but adapt them to work on uint64
>>> instead.
>>>
>>> Signed-off-by: David Hildenbrand
>>> ---
>>> tests/test-string-input-visitor.c | 71 +++
On Thu, Nov 15, 2018 at 02:56:59PM +1100, Alexey Kardashevskiy wrote:
> The libfdt installed in the system is preferred to the dtc submodule by
> default. The recent libfdt update added a new symbol - fdt_check_full -
> and this breaks compile if there is an older libfdt installed in
> the system.
Cc: qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
---
vl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/vl.c b/vl.c
index fa25d1ae2d..ae63018a1d 100644
--- a/vl.c
+++ b/vl.c
@@ -1522,9 +1522,6 @@ static int machine_help_func(QemuOpts *opts, MachineState
*machine)
return 1;
}
On 15/11/18 7:05, Li Qiang wrote:
And also the g_malloc doesn't need check return value,
remove it.
Cc: qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
---
target/i386/hax-all.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/target/i386/hax-all.c b/targ
On Thu, Nov 15, 2018 at 01:04:23AM -0800, Li Qiang wrote:
> When the parse_keyboard_layout() find a "include " line
> in the keyboard layout file, it will call parse_keyboard_layout()
> to perform a recursive parse. If the keyboard layout is malformed
> by adding a line include itself, this can cau
On 15.11.18 10:48, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> On 14.11.18 18:38, Markus Armbruster wrote:
>>> David Hildenbrand writes:
>>>
The input visitor has some problems right now, especially
- unsigned type "Range" is used to process signed ranges, resulting in
>>
On 15/11/18 8:56, Gerd Hoffmann wrote:
Hi,
Perhaps print a few shell commands first? Such as:
(
VARSTORE=$(mktemp)
trap 'rm -f -- "$VARSTORE"' EXIT
cat -- '[VARSTORE_TEMPLATE]' >> "$VARSTORE"
qemu ...
)
It really does take separate actions, just like when yo
Gerd Hoffmann 于2018年11月15日周四 下午6:15写道：
> On Thu, Nov 15, 2018 at 01:04:23AM -0800, Li Qiang wrote:
> > When the parse_keyboard_layout() find a "include " line
> > in the keyboard layout file, it will call parse_keyboard_layout()
> > to perform a recursive parse. If the keyboard layout is malforme
On 8 November 2018 at 12:16, David Gibson wrote:
> From: Roman Kapl
>
> External PID is a mechanism present on BookE 2.06 that enables application to
> store/load data from different address spaces. There are special version of
> some
> instructions, which operate on alternate address space, whi
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181114233831.10374-1-ehabk...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific
variants of virtio PCI devices
=== TEST SCRIPT BEGIN ===
On Thu, Nov 08, 2018 at 02:23:18AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, Oct 19, 2018 at 5:47 PM Daniel P. Berrangé
> wrote:
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index a1c3e0e59c..a9654b8115 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -4447,6 +4
On 2 November 2018 at 02:21, Jason Wang wrote:
>
> On 2018/10/31 上午8:50, Zhang Chen wrote:
>>
>> The original code just follow the TCP state diagram,
>> but in this case, we can skip the TCPS_TIME_WAIT state to simplify
>> the implementation.
>>
>> Signed-off-by: Zhang Chen
>> ---
>> net/filter
On Thu, Nov 08, 2018 at 02:23:34AM +0400, Marc-André Lureau wrote:
> On Fri, Oct 19, 2018 at 5:42 PM Daniel P. Berrangé
> wrote:
> >
> > Add a QAuthZListFile object type that implements the QAuthZ interface. This
> > built-in implementation is a proxy around the QAtuhZList object type,
> > initia
On Thu, Nov 15, 2018 at 10:11:12AM +, Daniel P. Berrangé wrote:
> On Thu, Nov 15, 2018 at 02:56:59PM +1100, Alexey Kardashevskiy wrote:
> > The libfdt installed in the system is preferred to the dtc submodule by
> > default. The recent libfdt update added a new symbol - fdt_check_full -
> > and
Cc'ing qemu-devel@
On 15/11/18 6:58, A Z wrote:
This is an issue that involves a combination of different software
packages, so my apologies in advance if this is the wrong list to post on.
I'm experiencing terrible boot times when I assign a large amount of RAM to
a VM when used in combination
On Mon, Nov 05, 2018 at 04:41:09PM -0600, Eric Blake wrote:
> On 10/9/18 8:23 AM, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently any client which can complete the TLS handshake is able to use
> > the NBD server. The server admin can turn on the 'verify-peer' option
> >
On Thu, Nov 15, 2018 at 09:33:08PM +1100, David Gibson wrote:
> On Thu, Nov 15, 2018 at 10:11:12AM +, Daniel P. Berrangé wrote:
> > On Thu, Nov 15, 2018 at 02:56:59PM +1100, Alexey Kardashevskiy wrote:
> > > The libfdt installed in the system is preferred to the dtc submodule by
> > > default.
This patch adds a notifier chain for the memory precopy. This enables various
precopy optimizations to be invoked at specific places.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
CC: Peter Xu
---
include/migration/misc.h | 12
migra
This patch adds an API to clear bits corresponding to guest free pages
from the dirty bitmap. Spilt the free page block if it crosses the QEMU
RAMBlock boundary.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
CC: Peter Xu
---
include/migration/mis
This is the deivce part implementation to add a new feature,
VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device
receives the guest free page hints from the driver and clears the
corresponding bits in the dirty bitmap, so that those free pages are
not sent by the migration thre
BITMAP_LAST_WORD_MASK(nbits) returns 0x when "nbits=0", which
makes bitmap_count_one fail to handle the "nbits=0" case. It appears to be
preferred to remain BITMAP_LAST_WORD_MASK identical to the kernel
implementation that it is ported from.
So this patch fixes bitmap_count_one to handle t
The ram save state notifier callback, for example the free page
optimization offerred by virtio-balloon, may need to check if
postcopy is in use, so move migrate_postcopy() to the outside header.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
CC: Pe
This patch adds a function to enable a precopy notifier callback outside
the migration subsystem to disable the bulk stage flag. This is needed by
the free page optimization offered by virtio-balloon.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
C
The bitmap mutex is used to synchronize threads to update the dirty
bitmap and the migration_dirty_pages counter. For example, the free
page optimization clears bits of free pages from the bitmap in an
iothread context. This patch makes migration_bitmap_clear_dirty update
the bitmap and counter und
Count the number of 1s in a bitmap starting from an offset.
Signed-off-by: Wei Wang
CC: Dr. David Alan Gilbert
CC: Juan Quintela
CC: Michael S. Tsirkin
Reviewed-by: Dr. David Alan Gilbert
---
include/qemu/bitmap.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/qem
The new feature enables the virtio-balloon device to receive hints of
guest free pages from the free page vq.
A notifier is registered to the migration precopy notifier chain. The
notifier calls free_page_start after the migration thread syncs the dirty
bitmap, so that the free page optimization s
On Mon, Nov 05, 2018 at 04:41:09PM -0600, Eric Blake wrote:
> On 10/9/18 8:23 AM, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently any client which can complete the TLS handshake is able to use
> > the NBD server. The server admin can turn on the 'verify-peer' option
> >
On Thu, 15 Nov 2018 10:05:59 +
Daniel P. Berrangé wrote:
> On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote:
> > Many of the current virtio-*-pci device types actually represent
> > 3 different types of devices:
> > * virtio 1.0 non-transitional devices
> > * virtio 1.0 transit
On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote:
> On Thu, 15 Nov 2018 10:05:59 +
> Daniel P. Berrangé wrote:
>
> > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote:
> > > Many of the current virtio-*-pci device types actually represent
> > > 3 different types of
On Wed, Nov 14, 2018 at 05:29:30PM +0400, Marc-André Lureau wrote:
> Because they are supposed to remain const.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: David Gibson
and ppc parts
Acked-by: David Gibson
> ---
> include/migration/vmstate.h | 6 +-
> hw/display/virtio-gpu.c |
> Hi, the list,
>
> I am trying to boot a FreeBSD guest but failed. It hangs at the
> kernel booting phase:
>
> /boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68
> syms=[0x8+0x159ee8+0x8
> Booting...
> (nothing more)
>
> It's just as simple as downloading the image and boot so I can't
On 14.11.18 17:09, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> Let's use the new function.
>>
>> Signed-off-by: David Hildenbrand
>> ---
>> qapi/string-input-visitor.c | 6 ++
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/qapi/string-input-visitor.c b/q
On 14 November 2018 at 10:16, Cornelia Huck wrote:
> The following changes since commit 6ff144698935e8bdbc96d255cf49b1a7d54174ac:
>
> Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2018-11-12-tag'
> into staging (2018-11-13 12:32:30 +)
>
> are available in the Git repository at:
On Wed, 14 Nov 2018 21:38:31 -0200
Eduardo Habkost wrote:
> diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h
> index 813082b0d7..1d2a11504f 100644
> --- a/hw/virtio/virtio-pci.h
> +++ b/hw/virtio/virtio-pci.h
(...)
> +/**
> + * VirtioPCIDeviceTypeInfo:
> + *
> + * Template for virti
On 11/14/18 2:00 AM, Emilio G. Cota wrote:
> The following might be related: I'm seeing segfaults with -smp 8
> and beyond when doing bootup+shutdown of an aarch64 guest on
> an x86-64 host.
I'm not seeing that. Anything else special on the command-line?
Are the segv in the code_gen_buffer or els
On Fri, Nov 9, 2018 at 9:39 PM Marc-André Lureau
wrote:
>
> After iov_discard_front(), the iov may be smaller than its initial
> size. Fixes the heap-buffer-overflow spotted by ASAN:
>
> ==9036==ERROR: AddressSanitizer: heap-buffer-overflow on address
> 0x606001e0 at pc 0x7fe632eca3f0 bp 0x7f
Coverity complains (CID 1390847) about some dead code in
do_sigreturn(). This is an if (err) clause that can never be
true, copied from the kernel (where __get_user returns an error).
The one code path that could report an error is in the
currently commented-out pseudocode for handling FPU register
On 17 October 2018 at 10:51, Stefan Hajnoczi wrote:
> On Tue, Oct 16, 2018 at 04:20:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> Theoretically possible that we finish the skipping loop with bs = NULL
>> and the following code will crash trying to dereference it. Fix that.
>>
>> Signed-off-by
On Thu, Aug 30, 2018 at 8:50 PM Marc-André Lureau
wrote:
>
> Now that the VhostUserMsg.request field is used for both master &
> slave requests, since commit d84599f56c820d8c1ac9928a76500dcdfbbf194d:
>
> contrib/libvhost-user/libvhost-user.c:953:20: error: implicit conversion from
> enumeration t
On 15/11/2018 12:46, Peter Maydell wrote:
> Coverity complains (CID 1390847) about some dead code in
> do_sigreturn(). This is an if (err) clause that can never be
> true, copied from the kernel (where __get_user returns an error).
> The one code path that could report an error is in the
> currentl
On 4 November 2018 at 07:42, Seth K wrote:
> I corrected these 2 memory regions based on specifications from the chip
> manufacturer. The existing ranges seem to overlap and and cause odd
> behavior and/or crashes when trying to set up multiple UARTs,
> I also played with changing MAX_SERIAL_PORTS
Ping
Li Qiang 于2018年11月1日周四 下午1:59写道：
> parse_fw_cfg() reports "can't load" without further details. Get
> the details from g_file_get_contents(), and include them in the
> error message.
>
> Signed-off-by: Li Qiang
> ---
> vl.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(
Record the command line that was used to start QEMU. This can be
useful for debugging.
Signed-off-by: Paolo Bonzini
---
tests/libqtest.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 44ce118cfc..f6e061d
It doesn't define any keys, only includes "common".
Which makes it effectively an "en-us" map.
Signed-off-by: Gerd Hoffmann
---
pc-bios/keymaps/nl-be | 3 ---
1 file changed, 3 deletions(-)
delete mode 100644 pc-bios/keymaps/nl-be
diff --git a/pc-bios/keymaps/nl-be b/pc-bios/keymaps/nl-be
dele
Gerd Hoffmann (4):
keymaps: remove modifiers include
keymaps: drop nl-be map
keymaps: remove common include
keymaps: drop support for include files
ui/keymaps.c | 7 +-
pc-bios/keymaps/common| 157
pc-bios/keymaps/modifiers |
Signed-off-by: Gerd Hoffmann
---
ui/keymaps.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/ui/keymaps.c b/ui/keymaps.c
index 085889b555..6e44f738ed 100644
--- a/ui/keymaps.c
+++ b/ui/keymaps.c
@@ -115,10 +115,9 @@ static int parse_keyboard_layout(kbd_layout_t *k,
"common" is the only file using it, so we can just include it directly.
Signed-off-by: Gerd Hoffmann
---
pc-bios/keymaps/common| 19 ++-
pc-bios/keymaps/modifiers | 18 --
2 files changed, 18 insertions(+), 19 deletions(-)
delete mode 100644 pc-bios/keymaps/m
Copy the content into the sl and sv files (the only ones left which are
not generated by qemu-keymap).
Signed-off-by: Gerd Hoffmann
---
pc-bios/keymaps/common | 174
pc-bios/keymaps/sl | 177 -
p
On Mon, 5 Nov 2018 02:40:35 +0100
Samuel Ortiz wrote:
> From: Yang Zhong
>
> The ACPI MCFG getter is not x86 specific and could be called from
> anywhere within generic ACPI API, so let's export it.
So far it's x86 or more exactly q35 specific thing,
for example it won't work with arm/virt wit
On Mon, 5 Nov 2018 02:40:37 +0100
Samuel Ortiz wrote:
> This property is currently defined under i386/pc while it only describes
> a region size that's eventually fetched from the AML ACPI code.
>
> We can make it more generic and shareable across machine types by moving
> it to memory-device.h
On 14/11/2018 13:36, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> slirp/libslirp.h | 6 ++
> net/slirp.c | 19 +++
> slirp/if.c | 2 +-
> slirp/ip6_icmp.c | 6 --
> slirp/slirp.c| 11 ++-
> 5 files changed, 36 insertions(+),
On 14/11/2018 13:36, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> slirp/libslirp.h | 6 ++
> slirp/slirp.h| 2 +-
> net/slirp.c | 23 +++
> slirp/ip6_icmp.c | 21 ++---
> 4 files changed, 40 insertions(+), 12 deletions(-)
>
Hello,
As I got no replies to my last mails, here again the full patch
set (rebased on current master) in the hope to get this merged.
The first few patches are cleanup, the last two patches add the
pmemload feature. Only 5/6 requires an ack (although all
mentioned issues should be fixed), all oth
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target d
i is only 32-bit. To prevent possible truncation when dumping large
memory regions use l which is target long.
Suggested-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
Reviewed-by: Dr. David Alan Gilbert
---
hmp-commands.hx | 4 ++--
hmp.c | 4 ++--
2 files changed, 4 inser
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target d
This enables completion for the filename arguments.
Suggested-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
Reviewed-by: Dr. David Alan Gilbert
---
hmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ff96c3a
qemu_open() allow passing file descriptors to qemu which is used in
restricted environments like libvirt where open() is prohibited.
Suggested-by: Eric Blake
Signed-off-by: Simon Ruderich
Reviewed-by: Eric Blake
---
cpus.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletio
On 14 November 2018 at 13:10, Alex Bennée wrote:
> The following changes since commit 186ac05f749c69e98030f037aa930ff2bc4ad7fb:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging
> (2018-11-13 11:45:16 +)
>
> are available in the Git repo
It's the natural type for object sizes and matches the return value of
sizeof(buf).
Signed-off-by: Simon Ruderich
Reviewed-by: Eric Blake
---
cpus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index c0d796f441..ee54595733 100644
--- a/cpus.c
+++ b/cpu
On 14/11/2018 13:36, Marc-André Lureau wrote:
> qemu_set_nonblock() does some event registration with the main loop on
> win32, let's have a callback.
>
> Signed-off-by: Marc-André Lureau
Perhaps a better interface would be register_poll_fd, which is called
before a file descriptor can be return
1 - 100 of 351 matches
Mail list logo
