Hello,
As I got no replies to my last mails, here again the full patch
set (rebased on current master) in the hope to get this merged.
The first few patches are cleanup, the last two patches add the
pmemload feature. Only 5/6 requires an ack (although all
mentioned issues should be fixed), all other patches were already
reviewed in the last round.
If there's anything else I can do to get this merged, please tell
me.
Regards
Simon Ruderich
Simon Ruderich (6):
cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open
cpus: use size_t in qmp_memsave/qmp_pmemsave
hmp: use l for size argument in memsave/pmemsave
hmp: use F for filename arguments in memsave/pmemsave
qmp: add pmemload command
hmp: add pmemload command
cpus.c | 79 +++++++++++++++++++++++++++++++++++++++++--------
hmp-commands.hx | 18 +++++++++--
hmp.c | 16 ++++++++--
hmp.h | 1 +
qapi/misc.json | 20 +++++++++++++
5 files changed, 118 insertions(+), 16 deletions(-)
Diff between v5 and v6:
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -1201,7 +1201,7 @@
#
# Returns: Nothing on success
#
-# Since: 3.1
+# Since: 3.2
##
{ 'command': 'pmemload',
'data': {'val': 'int', 'filename': 'str', '*size': 'int', '*offset': 'int'}
}
Diff between v4 (last full series) and v6:
--- a/cpus.c
+++ b/cpus.c
@@ -2473,6 +2473,10 @@ void qmp_pmemload(int64_t addr, const char *filename,
error_setg_errno(errp, errno, "could not fstat fd to get size");
goto exit;
}
+ if (S_ISCHR(s.st_mode) || S_ISBLK(s.st_mode)) {
+ error_setg(errp, "pmemload doesn't support char/block
devices");
+ goto exit;
+ }
size = s.st_size;
}
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -1201,7 +1201,7 @@
#
# Returns: Nothing on success
#
-# Since: 3.1
+# Since: 3.2
##
{ 'command': 'pmemload',
'data': {'val': 'int', 'filename': 'str', '*size': 'int', '*offset': 'int'}
}
--
2.19.1
