Re: [Qemu-devel] [PATCH v2] hw/bt: drop bluetooth keyboard emulation

2018-11-14 Thread Liam Merwick
On 13/11/2018 11:57, Gerd Hoffmann wrote: Broken (segfaults on first keypress, probably since 2.1) and apparently unused. Reproducer: qemu -usb -device usb-bt-dongle -bt hci,vlan=0 -bt device:keyboard Stacktrace: #0 0x5606841f7363 in bt_hid_send_data (ch=0x0, type=1, data=0x560686

[Qemu-devel] [PATCH v3] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-14 Thread Yuri Benditovich
This commit adds implementation of RX packets coalescing, compatible with requirements of Windows Hardware compatibility kit. The device enables feature VIRTIO_NET_F_RSC_EXT in host features if it supports extended RSC functionality as defined in the specification. This feature requires at least o

Re: [Qemu-devel] [PATCH v2 1/3] fsdev-throttle-qmp: refactor code for qmp interface for io throttling

2018-11-14 Thread xiezhide
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月14日 7:25 To: xiezhide ; qemu-devel@nongnu.org Cc: gr...@kaod.org; aneesh.ku...@linux.vnet.ibm.com; arm...@redhat.com; be...@igalia.com; zengcanfu 00215970 ; Jinxuefeng ; Chenyi (johnny, RTOS) Subject: Re: [PA

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 03/16] gdbstub: add multiprocess support to '?' packets

2018-11-14 Thread Luc Michel
Hi Edgar, On 11/13/18 12:06 PM, Edgar E. Iglesias wrote: > On Sat, Nov 10, 2018 at 09:11:34AM +0100, Luc Michel wrote: >> The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It >> checks if the CPU is a direct child of a CPU cluster. If it is, the >> returned PID is the cluster I

[Qemu-devel] [PATCH] MAINTAINERS: Add entries for missing ARM boards

2018-11-14 Thread Thomas Huth
Add entries for the boards "mcimx6ul-evk", "mcimx7d-sabre", "raspi2", "raspi3", "sabrelite", "vexpress-a15", "vexpress-a9" and "virt". While we're at it, also adjust the "i.MX31" section a little bit, so that the wildcards there do not match anymore for unrelated files (e.g. the new hw/misc/imx6ul_

[Qemu-devel] [Bug 1802150] Re: Guest undefined when destroyed on host after migration

2018-11-14 Thread Dr. David Alan Gilbert
Dan: Rereading your description I think this might be worth discussing on the libvirt mailing list/bug trackers instead. I *think* what you're saying is the migration works fine, the only problem is that after you shutdown the VM it disappears. My understanding (although I'm more qemu than

[Qemu-devel] [PATCH v3 0/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-14 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. xiezhide (4): fsdev-throttle-qmp: factor out throttle code to reuse code fsdev-throttle-qmp: move struct Throttl

[Qemu-devel] [PATCH v3 1/4] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-14 Thread xiezhide
This patch factor out throttle parameter parse code to common function which will be used by block and fsdev. rename function throttle_parse_options to throttle_parse_group to resolve function name conflict Signed-off-by: xiezhide --- block/throttle.c| 6 ++-- blockdev.c

Re: [Qemu-devel] [PATCH] netdev: fix socket backend implementation and docs

2018-11-14 Thread Daniel P . Berrangé
On Tue, Nov 13, 2018 at 04:13:04PM +0600, Artem Pisarenko wrote: > > Incidentally this method should not even be part of this header > > files. qemu/sockets.h is for code that lives in util/qemu-sockets.c > > > > The parse_host_port declaration and impl should better live in > > net/util.{c,h}, so

[Qemu-devel] [PATCH v3 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file

2018-11-14 Thread xiezhide
this patch move ThrottleLimits to new file and rename struct field with common format Signed-off-by: xiezhide --- Makefile | 9 +++ Makefile.objs | 4 ++ blockdev.c| 51 +--- qapi/block-core.json | 122 +- qap

[Qemu-devel] [PATCH v3 4/4] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-14 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: xiezhide --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ qapi/tlimits.json

Re: [Qemu-devel] [PATCH] gtk: sync guest display updates to host display refresh

2018-11-14 Thread Chen Zhang via Qemu-devel
Additionally, the aforementioned patch performs OK for non-vfio OpenGL enabled GTK displays, and fails DMA Buf iGVT-g display only, so far as I could tell. Perhaps a change like the following is better? static gboolean gd_frame_tick(GtkWidget *widget, GdkFrameCloc

[Qemu-devel] [PATCH v3 3/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-14 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: xiezhide --- Makefile| 9 + Makefile.objs | 4 ++ fsdev/qemu-fsdev-dummy.c| 11 + fsdev/qemu-fsdev-throttle.c | 98 ++

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

2018-11-14 Thread Fam Zheng
On Sun, 11/11 18:20, Brad Smith wrote: > ping. Queued. Will send a pull request soon. Fam > > On 10/30/2018 10:57 PM, Fam Zheng wrote: > > Upgrade OpenBSD to 6.4 using auto_install. Especially, drop SDL1, > > include SDL2. > > > > Also do the build in $HOME since both /var/tmp and /tmp are tmp

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 02/16] gdbstub: introduce GDB processes

2018-11-14 Thread Luc Michel
Hi Edgar, On 11/13/18 11:52 AM, Edgar E. Iglesias wrote: > On Sat, Nov 10, 2018 at 09:11:33AM +0100, Luc Michel wrote: >> Add a structure GDBProcess that represent processes from the GDB >> semantic point of view. >> >> CPUs can be split into different processes, by grouping them under >> differen

[Qemu-devel] [PULL for-3.1 0/1] bugfix for s390x

2018-11-14 Thread Cornelia Huck
The following changes since commit 6ff144698935e8bdbc96d255cf49b1a7d54174ac: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2018-11-12-tag' into staging (2018-11-13 12:32:30 +) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-201

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-14 Thread Berkus Decker
I will double check on High Sierra and El Capitan. So far I only tested qemu-system-aarch64 and it worked on Mojave, but did not test elsewhere (my aim was to get my osdev going, only). I have a range of older osx machines (not as old as 10.6 though), so will put it through some rounds. Will po

[Qemu-devel] [PULL for-3.1 1/1] s390x/pci: properly fail if the zPCI device cannot be created

2018-11-14 Thread Cornelia Huck
From: David Hildenbrand Right now, errors during realize()/pre_plug/plug of the zPCI device would result in QEMU crashing instead of failing nicely when creating a zPCI device for a PCI device. Reviewed-by: Thomas Huth Reviewed-by: Collin Walling Signed-off-by: David Hildenbrand Message-Id: <

Re: [Qemu-devel] [PATCH] tests/tcg/multiarch: fix 32bit linux-test on 64bit host

2018-11-14 Thread Alex Bennée
Laurent Vivier writes: > Fix: > > TESTlinux-test on i386 > .../tests/tcg/multiarch/linux-test.c:201: readdir > > readdir() calls getdents64() to have the list of the entries in a > directory, and getdents64() can return 64bit d_off values (with ext4, > for instance) that will not fit in

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 03/16] gdbstub: add multiprocess support to '?' packets

2018-11-14 Thread Edgar E. Iglesias
On Wed, Nov 14, 2018 at 09:43:27AM +0100, Luc Michel wrote: > Hi Edgar, > > On 11/13/18 12:06 PM, Edgar E. Iglesias wrote: > > On Sat, Nov 10, 2018 at 09:11:34AM +0100, Luc Michel wrote: > >> The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It > >> checks if the CPU is a direc

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 02/16] gdbstub: introduce GDB processes

2018-11-14 Thread Edgar E. Iglesias
On Wed, Nov 14, 2018 at 11:14:31AM +0100, Luc Michel wrote: > Hi Edgar, > > On 11/13/18 11:52 AM, Edgar E. Iglesias wrote: > > On Sat, Nov 10, 2018 at 09:11:33AM +0100, Luc Michel wrote: > >> Add a structure GDBProcess that represent processes from the GDB > >> semantic point of view. > >> > >> CP

Re: [Qemu-devel] [PATCH] tests/tcg/multiarch: fix 32bit linux-test on 64bit host

2018-11-14 Thread Laurent Vivier
On 14/11/2018 11:23, Alex Bennée wrote: > > Laurent Vivier writes: > >> Fix: >> >> TESTlinux-test on i386 >> .../tests/tcg/multiarch/linux-test.c:201: readdir >> >> readdir() calls getdents64() to have the list of the entries in a >> directory, and getdents64() can return 64bit d_off val

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile

2018-11-14 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > We've fixed it before like 38bb54f323 ("replication: Make > --disable-replication compile again", 2017-04-28) but it's failing > again. So fix it again. > > There could be even cleaner way to fix this but current way is the > simplest. Let's start from sim

Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication

2018-11-14 Thread Peter Xu
On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote: > This compilation issue will occur when user use --disable-replication > to config Qemu. > > Reported-by: Thomas Huth > Signed-off-by: Zhang Chen Hi, How's the status of this patch? Are we gonna merge it for 3.1? I just posted a si

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile

2018-11-14 Thread Peter Xu
On Wed, Nov 14, 2018 at 10:37:23AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > We've fixed it before like 38bb54f323 ("replication: Make > > --disable-replication compile again", 2017-04-28) but it's failing > > again. So fix it again. > > > > There could be e

Re: [Qemu-devel] [for 3.1? PATCH] qcow2: Assert that refcount block offsets fit in the refcount table

2018-11-14 Thread Kevin Wolf
Am 14.11.2018 um 08:10 hat Alberto Garcia geschrieben: > On Tue 13 Nov 2018 06:06:54 PM CET, Eric Blake wrote: > > >> Refcount table entries have a field to store the offset of the > >> refcount block. The rest of the bits of the entry are currently > >> reserved. > >> > >> The offset is always

Re: [Qemu-devel] [PATCH v5 11/24] hw: acpi: Export and generalize the PCI host AML API

2018-11-14 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:34 +0100 Samuel Ortiz wrote: > From: Yang Zhong > > The AML build routines for the PCI host bridge and the corresponding > DSDT addition are neither x86 nor PC machine type specific. > We can move them to the architecture agnostic hw/acpi folder, and by > carrying all

[Qemu-devel] [RFC PATCH 0/3] Series short description

2018-11-14 Thread Dario Faggioli
The following series implements... --- Dario Faggioli (3): i386: add properties for customizing L2 and L3 caches size i386: custom cache size in CPUID2 and CPUID4 descriptors i386: custom cache size in AMD's CPUID descriptors too 0 files changed -- Signature

[Qemu-devel] [RFC PATCH 2/3] i386: custom cache size in CPUID2 and CPUID4 descriptors

2018-11-14 Thread Dario Faggioli
If specified on the command line, alter the cache(s) properties accordingly, before encoding them in the CPUID descriptors. Tweak the number of sets (if defined), to retain consistency. Unless some specific size values are used (either by chance or voluntarily), we won't find any matching CPUID-2

[Qemu-devel] [RFC PATCH 1/3] i386: add properties for customizing L2 and L3 caches size

2018-11-14 Thread Dario Faggioli
Make it possible to specify a custom size for the L2 and L3 caches, from the command line. This can be useful in cases where applications or libraries check, within the guest, the cache size and behave differently depending on what they actually see. Signed-off-by: Dario Faggioli --- I am not en

[Qemu-devel] [RFC PATCH 3/3] i386: custom cache size in AMD's CPUID descriptors too

2018-11-14 Thread Dario Faggioli
If specified on the command line, alter the cache size(s) properties accordingly, before encoding them in the AMD's CPUID cache descriptors too (i.e., 8006 and 801d). Signed-off-by: Dario Faggioli --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- 0 files changed dif

Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication

2018-11-14 Thread Thomas Huth
On 2018-11-14 11:47, Peter Xu wrote: > On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote: >> This compilation issue will occur when user use --disable-replication >> to config Qemu. >> >> Reported-by: Thomas Huth >> Signed-off-by: Zhang Chen > > Hi, > > How's the status of this patch?

Re: [Qemu-devel] [RFC PATCH 0/3] Series short description

2018-11-14 Thread Dario Faggioli
Wow... Mmm, not sure what went wrong... Anyway, this is the cover letter I thought I had sent. Sorry :-/ -- Hello everyone, This is Dario, from SUSE, and this is the first time I touch QEMU. :-D So, basically, while playing with an AMD EPYC box, we came across a weird performance regression betwe

Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards

2018-11-14 Thread Peter Maydell
On 13 November 2018 at 20:10, Alistair Francis wrote: > These two and the Xilinx boards seem a little out of place in this > patch. I agree they probably aren't maintained as well as they should > be, but the patch talks about orphaned boards and these four all have > active QEMU maintainers liste

Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication

2018-11-14 Thread Peter Maydell
On 14 November 2018 at 11:06, Thomas Huth wrote: > On 2018-11-14 11:47, Peter Xu wrote: >> On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote: >>> This compilation issue will occur when user use --disable-replication >>> to config Qemu. >>> >>> Reported-by: Thomas Huth >>> Signed-off-by:

Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards

2018-11-14 Thread Philippe Mathieu-Daudé
On Wed, Nov 14, 2018 at 12:13 PM Peter Maydell wrote: > On 13 November 2018 at 20:10, Alistair Francis wrote: > > These two and the Xilinx boards seem a little out of place in this > > patch. I agree they probably aren't maintained as well as they should > > be, but the patch talks about orphaned

Re: [Qemu-devel] [PATCH 2/2] scripts/coverity-scan: Add Docker support

2018-11-14 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 13/11/18 19:46, Peter Maydell wrote: >> Add support for running the Coverity Scan tools inside a Docker >> container rather than directly on the host system. >> >> Signed-off-by: Peter Maydell >> --- >> scripts/coverity-scan/coverity-scan.docker | 120

Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards

2018-11-14 Thread Peter Maydell
On 14 November 2018 at 11:23, Philippe Mathieu-Daudé wrote: > On Wed, Nov 14, 2018 at 12:13 PM Peter Maydell > wrote: >> On 13 November 2018 at 20:10, Alistair Francis wrote: >> > These two and the Xilinx boards seem a little out of place in this >> > patch. I agree they probably aren't maintai

Re: [Qemu-devel] [RFC PATCH 0/3] Series short description

2018-11-14 Thread Daniel P . Berrangé
On Wed, Nov 14, 2018 at 12:08:42PM +0100, Dario Faggioli wrote: > Wow... Mmm, not sure what went wrong... Anyway, this is the cover > letter I thought I had sent. Sorry :-/ No problem ! If you have not come across it before, "git-publish" is a great addon tool for git to make sending patch series

Re: [Qemu-devel] [RFC 01/48] cpu: introduce run_on_cpu_no_bql

2018-11-14 Thread Alex Bennée
Emilio G. Cota writes: > This allows us to queue synchronous CPU work without the BQL. > > Will gain a user soon. This is also in the cpu-lock series right? > > Signed-off-by: Emilio G. Cota > --- > include/qom/cpu.h | 13 + > cpus-common.c | 28 ++--

Re: [Qemu-devel] [PATCH] Corrected memory regions

2018-11-14 Thread Philippe Mathieu-Daudé
Hi Seth, On Wed, Nov 14, 2018 at 8:25 AM Seth K wrote: > > I corrected these 2 memory regions based on specifications from the chip > manufacturer. The existing ranges seem to overlap and and cause odd > behavior and/or crashes when trying to set up multiple UARTs, > I also played with changing M

[Qemu-devel] [PATCH] cpus: run work items for all vCPUs if single-threaded

2018-11-14 Thread Paolo Bonzini
This avoids the following deadlock: 1) a thread calls run_on_cpu for CPU 2 from a timer, and single_tcg_halt_cond is signaled 2) CPU 1 is running and exits. It finds no work item and enters CPU 2 3) because the I/O thread is stuck in run_on_cpu, the round-robin kick timer never triggers, and CP

Re: [Qemu-devel] [PATCH 2/2] scripts/coverity-scan: Add Docker support

2018-11-14 Thread Philippe Mathieu-Daudé
On 14/11/18 12:25, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 13/11/18 19:46, Peter Maydell wrote: Add support for running the Coverity Scan tools inside a Docker container rather than directly on the host system. Signed-off-by: Peter Maydell --- scripts/coverity-scan/coverity-s

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add entries for missing ARM boards

2018-11-14 Thread Philippe Mathieu-Daudé
Hi Thomas, On 14/11/18 9:43, Thomas Huth wrote: Add entries for the boards "mcimx6ul-evk", "mcimx7d-sabre", "raspi2", "raspi3", "sabrelite", "vexpress-a15", "vexpress-a9" and "virt". While we're at it, also adjust the "i.MX31" section a little bit, so that the wildcards there do not match anymor

Re: [Qemu-devel] [PATCH 00/13] Support disabling TCG on ARM

2018-11-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181113165247.4806-1-sa...@linux.intel.com Type: series Subject: [Qemu-devel] [PATCH 00/13] Support disabling TCG on ARM === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] QEMU and Kconfig

2018-11-14 Thread Paolo Bonzini
On 09/11/2018 20:16, Eduardo Habkost wrote: > On Fri, Nov 09, 2018 at 11:10:21AM +0100, Paolo Bonzini wrote: >> On 08/11/2018 22:00, Eduardo Habkost wrote: >>> Understood. My interpretation of "target" was just "a QEMU >>> binary". In other words, I thought we were talking about >>> anything that

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add entries for missing ARM boards

2018-11-14 Thread Thomas Huth
On 2018-11-14 12:57, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 14/11/18 9:43, Thomas Huth wrote: >> Add entries for the boards "mcimx6ul-evk", "mcimx7d-sabre", "raspi2", >> "raspi3", "sabrelite", "vexpress-a15", "vexpress-a9" and "virt". >> While we're at it, also adjust the "i.MX31" secti

Re: [Qemu-devel] [PATCH 2/2] scripts/coverity-scan: Add Docker support

2018-11-14 Thread Paolo Bonzini
On 13/11/2018 20:37, Philippe Mathieu-Daudé wrote: > Calling "make docket-image-fedora" you can reduce this script to: > > -- >8 -- > FROM qemu:fedora > ENV PACKAGES \ >     $PACKAGES \ >     alsa-lib-devel \ >     curl \ >     cyrus-sasl-devel \ >     libepoxy-devel \ >     libgbm-devel \ >     l

[Qemu-devel] [PATCH for-3.2 04/41] slirp: remove unused M_TRAILINGSPACE

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/mbuf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/slirp/mbuf.h b/slirp/mbuf.h index bfdf8c4577..cbf17e136b 100644 --- a/slirp/mbuf.h +++ b/slirp/mbuf.h @@ -72,7 +72,6 @@ * How much free room there is */ #define M_FREEROOM(m) (M_ROOM(m) - (m)

[Qemu-devel] [PATCH for-3.2 00/41] RFC: slirp: make it again a standalone project

2018-11-14 Thread Marc-André Lureau
Hi, Based-on: https://people.debian.org/~sthibault/qemu.git/ slirp branch This series goal is to allow building libslirp as an independent library. While looking at making SLIRP a seperate running process, I thought that having an independent library from QEMU would be a first step. There has b

[Qemu-devel] [PATCH for-3.2 01/41] slirp: move socket pair creation in helper function

2018-11-14 Thread Marc-André Lureau
Originally, the patch was fixing a bunch of issues, but Peter beat me to it with earlier commit "slirp: fork_exec(): create and connect child socket before fork()". Factor out socket pair creation, to simplify the fork_exec() code. Use the name socketpair_with_oob() since the code is actually simi

[Qemu-devel] [PATCH for-3.2 05/41] slirp: use a callback structure to interface with qemu

2018-11-14 Thread Marc-André Lureau
This will bring slirp a bit forward to the state of an independent project. This could be squashed with earlier submitted "slirp: associate slirp_output". Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 7 +-- slirp/slirp.h| 2 +- net/slirp.c | 6 +- slirp/ncsi.c

[Qemu-devel] [PATCH for-3.2 02/41] glib-compat: add g_spawn_async_with_fds() fallback

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/glib-compat.h | 56 +++ 1 file changed, 56 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index fdf95a255d..8a078c5288 100644 --- a/include/glib-compat.h +++ b/include/glib-compat.h @@

[Qemu-devel] [PATCH for-3.2 03/41] slirp: simplify fork_exec()

2018-11-14 Thread Marc-André Lureau
Use g_spawn_async_with_fds() to setup the child. GSpawn handles reaping the child, and closing parent file descriptors. Signed-off-by: Marc-André Lureau --- slirp/misc.c | 75 +--- 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/sl

[Qemu-devel] [PATCH for-3.2 11/41] slirp: remove FULL_BOLT

2018-11-14 Thread Marc-André Lureau
Looking at git history, this looks like something from the past, when there was a tty layer. Let's remove it. Signed-off-by: Marc-André Lureau --- slirp/slirp_config.h | 7 --- slirp/if.c | 2 -- 2 files changed, 9 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_confi

[Qemu-devel] [PATCH for-3.2 06/41] slirp: add a callback for qemu_chr_fe_write_all()

2018-11-14 Thread Marc-André Lureau
Replace strong dependency on QEMU. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 1 + net/slirp.c | 6 ++ slirp/slirp.c| 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index 36d5fb9163..16ced2aa0f 100644 --- a/slirp/

[Qemu-devel] [PATCH for-3.2 09/41] slirp: add a set_nonblock() callback

2018-11-14 Thread Marc-André Lureau
qemu_set_nonblock() does some event registration with the main loop on win32, let's have a callback. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 1 + net/slirp.c | 1 + slirp/misc.c | 2 +- slirp/tcp_subr.c | 4 ++-- 4 files changed, 5 insertions(+), 3 deletions(-) diff --g

[Qemu-devel] [PATCH for-3.2 07/41] slirp: add clock_get_ns() callback

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 6 ++ net/slirp.c | 19 +++ slirp/if.c | 2 +- slirp/ip6_icmp.c | 6 -- slirp/slirp.c| 11 ++- 5 files changed, 36 insertions(+), 8 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslir

[Qemu-devel] [PATCH for-3.2 08/41] slirp: add callbacks for timer

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 6 ++ slirp/slirp.h| 2 +- net/slirp.c | 23 +++ slirp/ip6_icmp.c | 21 ++--- 4 files changed, 40 insertions(+), 12 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index fcebc

[Qemu-devel] [PATCH for-3.2 15/41] slirp: remove NO_UNIX_SOCKETS

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 3 --- slirp/slirp_config.h | 6 -- 2 files changed, 9 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 7c0bcd9e1c..424151b99b 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -28,9 +28,6 @@ typedef char *caddr_t; #in

[Qemu-devel] [PATCH for-3.2 10/41] slirp: remove PROBE_CONN dead-code

2018-11-14 Thread Marc-André Lureau
Nobody cares for over 14y. Somebody can revert or rewrite if interested by that. Signed-off-by: Marc-André Lureau --- slirp/slirp_config.h | 4 slirp/slirp.c| 41 - 2 files changed, 45 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/s

[Qemu-devel] [PATCH for-3.2 14/41] slirp: remove unused HAVE_SYS_BITYPES_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 4 slirp/slirp_config.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 1dbe39bc9a..7c0bcd9e1c 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -19,10 +19,6 @@ typedef char *caddr_t; # en

[Qemu-devel] [PATCH for-3.2 12/41] slirp: remove the disabled readv()/writev() code path

2018-11-14 Thread Marc-André Lureau
The soread() function may be used on datagram sockets, and would provide different behaviour if HAVE_READV was set, on empty datagrams. This looks like a minor optimization, that never has been a strong goal for slirp. Signed-off-by: Marc-André Lureau --- slirp/slirp_config.h | 3 --- slirp/soc

[Qemu-devel] [PATCH for-3.2 18/41] slirp: remove unused HAVE_SYS_WAIT_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 4 slirp/slirp_config.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 92abb2d78d..7aa14feeb6 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -40,10 +40,6 @@ typedef char *caddr_t; # in

[Qemu-devel] [PATCH for-3.2 13/41] slirp: remove HAVE_SYS_SIGNAL_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 3 --- slirp/slirp_config.h | 3 --- 2 files changed, 6 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index e5abf1c594..1dbe39bc9a 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -35,9 +35,6 @@ typedef char *caddr_t; #ifnde

[Qemu-devel] [PATCH for-3.2 23/41] slirp: remove unused HAVE_INET_ATON

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp_config.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index 833f25a965..5126711849 100644 --- a/slirp/slirp_config.h +++ b/slirp/slirp_config.h @@ -16,9 +16,3 @@ /* Define to sizeof(char *)

[Qemu-devel] [PATCH for-3.2 21/41] slirp: remove HAVE_SYS_FILIO_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 2 +- slirp/slirp_config.h | 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index a2e7c50361..1a336b2cf1 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -36,7 +36,7 @@ typedef char

[Qemu-devel] [PATCH for-3.2 19/41] slirp: remove unused HAVE_SYS_SELECT_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/main.h | 4 slirp/slirp.h| 4 slirp/slirp_config.h | 6 -- 3 files changed, 14 deletions(-) diff --git a/slirp/main.h b/slirp/main.h index e04677944f..4bc05fb904 100644 --- a/slirp/main.h +++ b/slirp/main.h @@ -8,10 +8,6 @@

[Qemu-devel] [PATCH for-3.2 16/41] slirp: remove unused HAVE_SYS_STROPTS_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 5 - slirp/slirp_config.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 424151b99b..92abb2d78d 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -54,11 +54,6 @@ typedef char *caddr_t; #de

[Qemu-devel] [PATCH for-3.2 27/41] slirp: remove unused global slirp_instance

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index c328aac88a..4356b2f427 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -199,8 +199,6 @@ struct Slirp { void *opaque; }; -extern Slirp *slirp_instan

[Qemu-devel] [PATCH for-3.2 22/41] slirp: remove unused DECLARE_IOVEC

2018-11-14 Thread Marc-André Lureau
It's actually qemu configure CONFIG_IOVEC that is being used. Signed-off-by: Marc-André Lureau --- slirp/slirp_config.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index f1ee927c15..833f25a965 100644 --- a/slirp/slirp_config.h +++ b/slirp/

[Qemu-devel] [PATCH for-3.2 24/41] slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent

2018-11-14 Thread Marc-André Lureau
One more step towards making the project independent from QEMU. Signed-off-by: Marc-André Lureau --- slirp/ip.h | 8 +--- slirp/ip6.h | 3 ++- slirp/ip6_icmp.h | 6 +++--- slirp/slirp_config.h | 3 --- slirp/tcp.h | 4 +++- 5 files changed, 13 insertions(+), 1

[Qemu-devel] [PATCH for-3.2 17/41] slirp: remove unused HAVE_ARPA_INET_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp_config.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index 47811e36dc..e95284071a 100644 --- a/slirp/slirp_config.h +++ b/slirp/slirp_config.h @@ -41,12 +41,6 @@ #define HAVE_SYS_SELECT_H #

[Qemu-devel] [PATCH for-3.2 32/41] slirp: remove unused sbflush()

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/sbuf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/slirp/sbuf.h b/slirp/sbuf.h index a722ecb629..644c201341 100644 --- a/slirp/sbuf.h +++ b/slirp/sbuf.h @@ -8,7 +8,6 @@ #ifndef SBUF_H #define SBUF_H -#define sbflush(sb) sbdrop((sb),(sb)->sb_cc

[Qemu-devel] [PATCH for-3.2 31/41] slirp: add a callback to log guest errors

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 1 + net/slirp.c | 7 +++ slirp/dhcpv6.c | 6 +++--- slirp/ip6_icmp.c | 7 +++ 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index f2e7f94ebb..c7582e6516 100644 --- a/slirp

[Qemu-devel] [PATCH for-3.2 25/41] slirp: replace SIZEOF_CHAR_P with glib equivalent

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/ip.h | 2 +- slirp/slirp_config.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/slirp/ip.h b/slirp/ip.h index 83fc9cdfbf..243b6c8b24 100644 --- a/slirp/ip.h +++ b/slirp/ip.h @@ -177,7 +177,7 @@ struct ip_timestamp

[Qemu-devel] [PATCH for-3.2 20/41] slirp: remove HAVE_SYS_IOCTL_H

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 2 +- slirp/slirp_config.h | 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index abe87618af..a2e7c50361 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -32,7 +32,7 @@ typedef char

[Qemu-devel] [PATCH for-3.2 29/41] slirp: improve a bit the debug macros

2018-11-14 Thread Marc-André Lureau
Let them accept multiple arguments. Simplify the inner argument handling of DEBUG_ARGS/DEBUG_MISC_DEBUG_ERROR. Signed-off-by: Marc-André Lureau --- slirp/debug.h | 47 -- slirp/arp_table.c | 12 ++-- slirp/bootp.c | 3 +-- slirp/cks

[Qemu-devel] [PATCH for-3.2 40/41] slirp: replace remaining QEMU dependency

2018-11-14 Thread Marc-André Lureau
Introduce utility header/object, and replace remaining qemu functions with SLIRP helpers. Signed-off-by: Marc-André Lureau --- slirp/ip.h | 14 +-- slirp/ip6.h | 5 +- slirp/ip6_icmp.h| 16 ++-- slirp/libslirp.h| 12 ++- slirp/qtailq.h | 218 +++

[Qemu-devel] [PATCH for-3.2 35/41] slirp: NULL is defined by glib (at least)

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/slirp.h | 4 1 file changed, 4 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 4356b2f427..2a61a85995 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -199,10 +199,6 @@ struct Slirp { void *opaque; }; -#ifndef NULL -#define N

[Qemu-devel] [PATCH for-3.2 26/41] slirp: replace compile time DO_KEEPALIVE

2018-11-14 Thread Marc-André Lureau
Use a global variable instead (similar to slirp_debug) Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 6 +++--- slirp/slirp_config.h | 12 slirp/slirp.c| 3 +++ slirp/tcp_input.c| 2 +- slirp/tcp_timer.c| 2 +- 5 files changed, 8 insertions(+), 17 de

[Qemu-devel] [PATCH for-3.2 33/41] slirp: replace qemu_notify_event() with a callback

2018-11-14 Thread Marc-André Lureau
Use a "slirp socket" helper function to call the callback when sbdrop() returns true. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 1 + slirp/sbuf.h | 2 +- slirp/socket.h| 1 + net/slirp.c | 1 + slirp/sbuf.c | 6 -- slirp/socket.c| 7 +++ slirp/tcp_i

[Qemu-devel] [PATCH for-3.2 36/41] slirp: remove dead TCP_ACK_HACK code

2018-11-14 Thread Marc-André Lureau
Untouched since original introduction in 2004. Signed-off-by: Marc-André Lureau --- slirp/tcp_input.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/slirp/tcp_input.c b/slirp/tcp_input.c index de4ef92aba..0d34abf8d7 100644 --- a/slirp/tcp_input.c +++

[Qemu-devel] [PATCH for-3.2 28/41] slirp: replace error_report() with g_critical()

2018-11-14 Thread Marc-André Lureau
Reduce dependency on QEMU. QEMU could use a custom log handler if it wants to redirect/filter it. Signed-off-by: Marc-André Lureau --- slirp/ip6_icmp.c | 2 +- slirp/misc.c | 4 ++-- slirp/slirp.c| 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/slirp/ip6_icmp.c

[Qemu-devel] [PATCH for-3.2 34/41] slirp: remove #if notdef dead code

2018-11-14 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- slirp/ip_input.c | 200 -- slirp/tcp_input.c | 39 - 2 files changed, 239 deletions(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 348e1dca5a..6831526320 100644 --- a/slirp/ip_input.c +++ b/slir

[Qemu-devel] [PATCH for-3.2 39/41] slirp: move QEMU state saving to a separate unit

2018-11-14 Thread Marc-André Lureau
Make state saving optional: this will allow to build SLIRP without QEMU. (eventually, the vmstate helpers will be extracted, so an external project & process could save its state) Signed-off-by: Marc-André Lureau --- slirp/slirp.h | 3 + slirp/state.h | 9 + slirp/slirp.c |

[Qemu-devel] [PATCH for-3.2 30/41] slirp: replace trace functions with DEBUG calls

2018-11-14 Thread Marc-André Lureau
Remove a dependency on QEMU. Use the existing logging facilities. Signed-off-by: Marc-André Lureau --- slirp/tftp.c | 7 --- Makefile.objs | 1 - slirp/trace-events | 5 - 3 files changed, 4 insertions(+), 9 deletions(-) delete mode 100644 slirp/trace-events diff --git a/sli

[Qemu-devel] [PATCH for-3.2 37/41] slirp: replace ARRAY_SIZE with G_N_ELEMENTS

2018-11-14 Thread Marc-André Lureau
Do not require QEMU macro. Signed-off-by: Marc-André Lureau --- slirp/ncsi.c | 2 +- slirp/tftp.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/slirp/ncsi.c b/slirp/ncsi.c index 10decfb5ef..8594382270 100644 --- a/slirp/ncsi.c +++ b/slirp/ncsi.c @@ -128,7 +128,7 @@ voi

[Qemu-devel] [PATCH for-3.2 41/41] build-sys: add a basic meson build

2018-11-14 Thread Marc-André Lureau
This is a minimal file to build a libslirp shared library. It has been tested to build on Linux and with mingw64 cross-compilation. Signed-off-by: Marc-André Lureau --- slirp/meson.build | 48 +++ 1 file changed, 48 insertions(+) create mode 100644 s

[Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals

2018-11-14 Thread Marc-André Lureau
Only slirp/libslirp.h should be included. Instead of using some slirp declarations and utility functions directly, let's copy them in net/util.h. Signed-off-by: Marc-André Lureau --- net/colo.h| 3 +-- net/util.h| 55 +++ net/colo

Re: [Qemu-devel] [PATCH] RFC: net/socket: learn to talk with a unix dgram socket

2018-11-14 Thread Marc-André Lureau
Hi On Wed, Nov 14, 2018 at 7:46 AM Jason Wang wrote: > > > On 2018/11/10 上午3:56, Marc-André Lureau wrote: > > -net socket has a fd argument, and may be passed pre-opened sockets. > > > > TCP sockets use framing. > > UDP sockets have datagram boundaries. > > > > When given a unix dgram socket, it

Re: [Qemu-devel] [RFC 03/48] tcg/README: fix typo s/afterwise/afterwards/

2018-11-14 Thread Alex Bennée
Emilio G. Cota writes: > Afterwise is "wise after the fact", as in "hindsight". > Here we meant "afterwards" (as in "subsequently"). Fix it. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > tcg/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Qemu-devel] [PATCH] vvfat: Fix memory leak

2018-11-14 Thread Kevin Wolf
Don't leak 'cluster' in the mapping == NULL case. Found by Coverity (CID 1055918). Fixes: 8d9401c2791ee2d2805b741b1ee3006041edcd3e Signed-off-by: Kevin Wolf --- block/vvfat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 1de5de1db4.

Re: [Qemu-devel] [PATCH v1 for-3.2 0/7] Get rid of global_qtest in some of the qtests

2018-11-14 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Message-id: 1542049690-12826-1-git-send-email-th...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v1 for-3.

Re: [Qemu-devel] [RFC 04/48] exec: introduce qemu_xxhash{2, 4, 5, 6, 7}

2018-11-14 Thread Alex Bennée
Emilio G. Cota writes: > Before moving them all to include/qemu/xxhash.h. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > include/exec/tb-hash-xx.h | 41 +-- > include/exec/tb-hash.h| 2 +- > tests/qht-bench.c | 2 +- > u

Re: [Qemu-devel] [PATCH for-3.2 00/41] RFC: slirp: make it again a standalone project

2018-11-14 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > Based-on: https://people.debian.org/~sthibault/qemu.git/ slirp branch > > This series goal is to allow building libslirp as an independent library. > > While looking at making SLIRP a seperate running process, I thought > that having an independent library from

[Qemu-devel] [PULL 2/2] tests/tcg/multiarch: fix 32bit linux-test on 64bit host

2018-11-14 Thread Alex Bennée
From: Laurent Vivier Fix: TESTlinux-test on i386 .../tests/tcg/multiarch/linux-test.c:201: readdir readdir() calls getdents64() to have the list of the entries in a directory, and getdents64() can return 64bit d_off values (with ext4, for instance) that will not fit in the 32bit d_off f

[Qemu-devel] [PULL for 3.1 0/2] Testing tweaks

2018-11-14 Thread Alex Bennée
The following changes since commit 186ac05f749c69e98030f037aa930ff2bc4ad7fb: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging (2018-11-13 11:45:16 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-te

Re: [Qemu-devel] [PATCH for-3.2 37/41] slirp: replace ARRAY_SIZE with G_N_ELEMENTS

2018-11-14 Thread Philippe Mathieu-Daudé
On 14/11/18 13:36, Marc-André Lureau wrote: Do not require QEMU macro. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- slirp/ncsi.c | 2 +- slirp/tftp.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/slirp/ncsi.c b/slirp/ncsi.c index 1

Re: [Qemu-devel] [RFC 02/48] trace: expand mem_info:size_shift to 3 bits

2018-11-14 Thread Alex Bennée
Emilio G. Cota writes: > This will allow us to trace 16B-long memory accesses. > > While at it, add some defines for the mem_info bits and simplify > trace_mem_get_info by making it a wrapper around trace_mem_build_info. > > Signed-off-by: Emilio G. Cota Currently we ignore atomic operation b

  1   2   3   >