Re: [Qemu-devel] [PATCH] 9p: write lock path in v9fs_co_open2()

2018-11-13 Thread Greg Kurz
On Tue, 13 Nov 2018 11:35:23 +0800 zhibin hu wrote: > Sorry, i have no time to make poc recently. > The crash log below seems to indicate you have at least one involving the CREATE and MKNOD commands, but never mind :) > IMHO, the implementation of v9fs_path_copy is not secure, it first free t

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-13 Thread Yuri Benditovich
On Mon, Nov 12, 2018 at 10:53 PM Michael S. Tsirkin wrote: > On Mon, Nov 12, 2018 at 01:31:36PM +0200, Yuri Benditovich wrote: > > > > > > On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > > > > > On 2018/11/12 下午4:57, Yuri Benditovich wrote: > > > > > > On Mon, Nov 12, 2018 at

[Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids

2018-11-13 Thread Alexey Kardashevskiy
sPAPR code will use it too so move it from VFIO to the common code. Signed-off-by: Alexey Kardashevskiy --- include/hw/pci/pci_ids.h | 2 ++ hw/vfio/pci-quirks.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index 6

[Qemu-devel] [PATCH qemu RFC 5/7] spapr-iommu: Always advertise the maximum possible DMA window size

2018-11-13 Thread Alexey Kardashevskiy
When deciding about the huge DMA window, the typical Linux pseries guest uses the maximum allowed RAM size as the upper limit. We did the same on QEMU side to match that logic. Now we are going to support GPU RAM pass through which is not available at the guest boot time as it requires the guest dr

[Qemu-devel] [PATCH qemu RFC 0/7] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2018-11-13 Thread Alexey Kardashevskiy
This is for passing through NVIDIA V100 GPUs on POWER9 systems. 22/22 has the details of hardware setup. This implements a subdriver for NVIDIA V100 GPU with coherent memory and NPU/ATS support available in the POWER9 CPU. This also implements required platform support for both powernv (host) an

[Qemu-devel] [PATCH qemu RFC 6/7] vfio: Make vfio_get_region_info_cap public

2018-11-13 Thread Alexey Kardashevskiy
This makes vfio_get_region_info_cap() to be used in quirks. Signed-off-by: Alexey Kardashevskiy --- include/hw/vfio/vfio-common.h | 2 ++ hw/vfio/common.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-commo

[Qemu-devel] [PATCH qemu RFC 4/7] vfio/nvidia-v100: Disable VBIOS update

2018-11-13 Thread Alexey Kardashevskiy
The NVIDIA V100 GPUs often come in several instances on the same system board where they are connected directly via out of band fabric called "NVLink". In order to make GPUs talk to each other, NVLink has to be enabled on both GPUs and this is guaranteed by the firmware by providing special MMIO r

[Qemu-devel] [PATCH qemu RFC 7/7] spapr: Add NVLink2 pass through support

2018-11-13 Thread Alexey Kardashevskiy
The NVIDIA V100 GPU comes with some on-board RAM which is mapped into the host memory space and accessible as normal RAM via NVLink bus. The VFIO-PCI driver implements special regions for such GPU and emulated NVLink bridge (below referred as NPU). The POWER9 CPU also provides address translation s

[Qemu-devel] [PATCH qemu RFC 1/7] vfio/spapr: Fix indirect levels calculation

2018-11-13 Thread Alexey Kardashevskiy
The current code assumes that we can address more bits on a PCI bus for DMA than we really can. Limit to the known tested maximum of 55 bits and assume 64K IOMMU pages. Signed-off-by: Alexey Kardashevskiy --- hw/vfio/spapr.c | 3 ++- hw/vfio/trace-events | 2 +- 2 files changed, 3 insertion

[Qemu-devel] [PATCH qemu RFC 2/7] linux-header: Update for new capabilities

2018-11-13 Thread Alexey Kardashevskiy
This pulls new NVIDIA V100 and NPU VFIO region types. The kernel changes are not in upstream yet so this does not have a tag. Signed-off-by: Alexey Kardashevskiy --- include/standard-headers/drm/drm_fourcc.h | 48 include/standard-headers/linux/ethtool.h | 15 +--- .../lin

Re: [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups

2018-11-13 Thread Cornelia Huck
On Mon, 12 Nov 2018 18:34:34 +0100 David Hildenbrand wrote: > On 12.11.18 18:14, Cornelia Huck wrote: > > On Mon, 5 Nov 2018 12:03:09 +0100 > > David Hildenbrand wrote: > > > >> The hotplug code needs more love, but let's do some obvious cleanups > >> first. In the future, we want to propery

Re: [Qemu-devel] [PATCH for-4.0 00/17] tcg: Move softmmu out-of-line

2018-11-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181112214503.22941-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH for-4.0 00/17] tcg: Move softmmu out-of-line === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PULL 40/55] target/arm: Enable SVE for aarch64-linux-user

2018-11-13 Thread Laurent Vivier
On 12/11/2018 23:12, Alex Bennée wrote: > > Laurent Vivier writes: > >> On 29/06/2018 16:53, Peter Maydell wrote: >>> From: Richard Henderson >>> >>> Enable ARM_FEATURE_SVE for the generic "max" cpu. >>> >>> Tested-by: Alex Bennée >>> Reviewed-by: Peter Maydell >>> Signed-off-by: Richard Hend

[Qemu-devel] [PATCH] gtk: sync guest display updates to host display refresh

2018-11-13 Thread Gerd Hoffmann
Reduce console refresh timer to idle refresh rate. Register a frame tick callback (called by gtk on each display frame) and use that to kick display updates instead. That should sync qemu refresh rate to display refresh rate. It'll also stop updating the qemu display in case the qemu is not visi

Re: [Qemu-devel] [PATCH v3 19/23] vl: Introduce shutdown_notifiers

2018-11-13 Thread Cornelia Huck
On Tue, 13 Nov 2018 09:13:08 +0200 Yuval Shaia wrote: > Notifier will be used for signaling shutdown event to inform system is > shutdown. This will allow devices and other component to run some > cleanup code needed before VM is shutdown. > > Signed-off-by: Yuval Shaia > --- > include/sysemu/

Re: [Qemu-devel] [PATCH v5 01/14] qtest: Add set_irq_in command to set IRQ/GPIO level

2018-11-13 Thread Laurent Vivier
On 12/11/2018 22:42, Steffen Görtz wrote: > Adds a new qtest command "set_irq_in" which allows > to set qemu gpio lines to a given level. > > Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html > which never got merged. > > Signed-off-by: Steffen Görtz > Originally-by: M

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Markus Armbruster
Drive-by comment... Cleber Rosa writes: [...] > My impression is that the "infrastructure for block tests" is not that > different from the infrastructure needed by other tests, specially other > QEMU tests. [...] Yes. The actual reason for having a completely separate testing infrastructure f

Re: [Qemu-devel] [PATCH] memory: check write/read_with_attrs in memory dispatch

2018-11-13 Thread Peter Maydell
On 13 November 2018 at 01:42, Li Qiang wrote: > This can avoid the NULL-deref if the rm doesn't has a > read/write nor write/read_with_attrs callback. > > Signed-off-by: Li Qiang > --- > memory.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Alternative approach -- assert that

Re: [Qemu-devel] [PULL 40/55] target/arm: Enable SVE for aarch64-linux-user

2018-11-13 Thread Richard Henderson
On 11/12/18 10:10 PM, Laurent Vivier wrote: > Running some tests for my pull request, I've found this commit breaks > ltp-full-20180515 sigaltstack01 tests with ubuntu arm64/trusty. > > sigaltstack01 274 TBROK : tst_sig.c:233: unexpected signal > SIGIOT/SIGABRT(6) received (pid = 15241). > ***

Re: [Qemu-devel] [PULL 40/55] target/arm: Enable SVE for aarch64-linux-user

2018-11-13 Thread Richard Henderson
On 11/12/18 10:10 PM, Laurent Vivier wrote: > Running some tests for my pull request, I've found this commit breaks > ltp-full-20180515 sigaltstack01 tests with ubuntu arm64/trusty. Hmm. Just noticed this part -- my pass came from ubuntu arm64/bionic. Do you believe that the glibc version plays e

Re: [Qemu-devel] [PULL 40/55] target/arm: Enable SVE for aarch64-linux-user

2018-11-13 Thread Laurent Vivier
On 13/11/2018 10:49, Richard Henderson wrote: > On 11/12/18 10:10 PM, Laurent Vivier wrote: >> Running some tests for my pull request, I've found this commit breaks >> ltp-full-20180515 sigaltstack01 tests with ubuntu arm64/trusty. >> >> sigaltstack01 274 TBROK : tst_sig.c:233: unexpected signa

[Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. x00390961 (3): fsdev-throttle-qmp: refactor code for qmp interface for io throttling fsdev-throttle-qmp: qmp inte

[Qemu-devel] [PATCH v1 1/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
This patch includes two parts: 1. factor out throttle code to reuse code 2. use ThrottleLimits structure Signed-off-by: x00390961 --- Makefile| 20 +++- Makefile.objs | 8 ++ block/throttle.c| 6 +- blockdev.c |

[Qemu-devel] [PATCH v1 2/3] fsdev-throttle-qmp: qmp interface for fsdev io

2018-11-13 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: x00390961 --- fsdev/qemu-fsdev-dummy.c| 11 fsdev/qemu-fsdev-throttle.c | 144 +--- fsdev/qemu-fsdev-throttle.h |

[Qemu-devel] [PATCH v1 3/3] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: x00390961 --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ 4 files changed, 1

Re: [Qemu-devel] [PULL 40/55] target/arm: Enable SVE for aarch64-linux-user

2018-11-13 Thread Laurent Vivier
On 13/11/2018 10:51, Richard Henderson wrote: > On 11/12/18 10:10 PM, Laurent Vivier wrote: >> Running some tests for my pull request, I've found this commit breaks >> ltp-full-20180515 sigaltstack01 tests with ubuntu arm64/trusty. > > Hmm. Just noticed this part -- my pass came from ubuntu arm64

Re: [Qemu-devel] [PATCH] memory: check write/read_with_attrs in memory dispatch

2018-11-13 Thread Li Qiang
Peter Maydell 于2018年11月13日周二 下午5:49写道: > On 13 November 2018 at 01:42, Li Qiang wrote: > > This can avoid the NULL-deref if the rm doesn't has a > > read/write nor write/read_with_attrs callback. > > > > Signed-off-by: Li Qiang > > --- > > memory.c | 8 ++-- > > 1 file changed, 6 insertion

Re: [Qemu-devel] [PATCH] netdev: fix socket backend implementation and docs

2018-11-13 Thread Artem Pisarenko
> Incidentally this method should not even be part of this header > files. qemu/sockets.h is for code that lives in util/qemu-sockets.c > > The parse_host_port declaration and impl should better live in > net/util.{c,h}, so I'd recommend moving that as the first patch > in a series. Ok. > This i

Re: [Qemu-devel] [PULL 00/14] Block layer patches

2018-11-13 Thread Peter Maydell
On 12 November 2018 at 17:05, Kevin Wolf wrote: > The following changes since commit 5704c36d25ee84e7129722cb0db53df9faefe943: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-31-20181112-pull-request' into staging (2018-11-12 > 15:55:40 +) > > are available in the Git reposit

Re: [Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

2018-11-13 Thread xiezhide
> These patches provide the qmp interface, to set/query the io throttle > status of the all fsdev devices that are present in a vm. > Some of the patches also remove the > duplicate code that was present in block and fsdev files. > > Zhide Xie (2): > fsdev-qmp: qmp interface for set/query io

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-13 Thread Kevin Wolf
Am 13.11.2018 um 02:45 hat Li Qiang geschrieben: > Ping what't the status of this patch. > > I see Kevin's new pr doesn't contain this patch. Oh, I thought you said that you wanted to fix this at a higher level so that the problem is caught before even getting into nvme code? If you don't, I

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: qmp interface to set/query io throttle for fsdev devices

2018-11-13 Thread xiezhide
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月13日 0:27 To: xiezhide ; qemu-devel@nongnu.org Cc: arm...@redhat.com; gr...@kaod.org; dgilb...@redhat.com; be...@igalia.com; aneesh.ku...@linux.vnet.ibm.com Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-9p: qmp i

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

2018-11-13 Thread xiezhide
-Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: 2018年11月13日 1:55 To: xiezhide Cc: qemu-devel@nongnu.org; be...@igalia.com; arm...@redhat.com; dgilb...@redhat.com; aneesh.ku...@linux.vnet.ibm.com Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue O

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-13 Thread Li Qiang
Kevin Wolf 于2018年11月13日周二 下午6:17写道: > Am 13.11.2018 um 02:45 hat Li Qiang geschrieben: > > Ping what't the status of this patch. > > > > I see Kevin's new pr doesn't contain this patch. > > Oh, I thought you said that you wanted to fix this at a higher level so > that the problem is caught be

Re: [Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread Greg Kurz
Hi Kidd, This posting is still broken: no threading and missing leading blanks on unchanged lines. Also is x00390961 really your name of choice ? In some other mail, you mentioned copy-paste to an outlook mail client... please don't do that to post series. Use git format-patch and git send-email

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 01/16] hw/cpu: introduce CPU clusters

2018-11-13 Thread Edgar E. Iglesias
On Sat, Nov 10, 2018 at 09:11:32AM +0100, Luc Michel wrote: > This commit adds the cpu-cluster type. It aims at gathering CPUs from > the same cluster in a machine. > > For now it only has a `cluster-id` property. > > Signed-off-by: Luc Michel > Reviewed-by: Alistair Francis > Reviewed-by: Phil

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 02/16] gdbstub: introduce GDB processes

2018-11-13 Thread Edgar E. Iglesias
On Sat, Nov 10, 2018 at 09:11:33AM +0100, Luc Michel wrote: > Add a structure GDBProcess that represent processes from the GDB > semantic point of view. > > CPUs can be split into different processes, by grouping them under > different cpu-cluster objects. Each occurrence of a cpu-cluster object

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 03/16] gdbstub: add multiprocess support to '?' packets

2018-11-13 Thread Edgar E. Iglesias
On Sat, Nov 10, 2018 at 09:11:34AM +0100, Luc Michel wrote: > The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It > checks if the CPU is a direct child of a CPU cluster. If it is, the > returned PID is the cluster ID plus one (cluster IDs start at 0, GDB > PIDs at 1). When the

Re: [Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
Following is the the patch header, user name and mail are the same at From and Signed-off-by : --- From 457f3168eca2d041bbfcad822ad9004e29a3840c Mon Sep 17 00:00:00 2001 From: x00390961 Date: Wed, 14 Nov 2018 01:03:49 +0800 Subject: [PATCH 1/3] fsdev-throttle-qmp: refactor code

Re: [Qemu-devel] [PATCH v1 for-3.2 0/7] Get rid of global_qtest in some of the qtests

2018-11-13 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1542049690-12826-1-git-send-email-th...@redhat.com Subject: [Qemu-devel] [PATCH v1 for-3.

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

2018-11-13 Thread Eduardo Habkost
On Fri, Nov 09, 2018 at 02:51:11PM -0500, Cleber Rosa wrote: > > > On 11/9/18 1:25 PM, Eduardo Habkost wrote: > >> > >> "Python -V" is quite different from "sys.version". Indeed it includes > >> the "Python " prefix, but that's all, everything else is the version > >> number. > > > > Is this a

[Qemu-devel] [PULL 00/16] target-arm queue

2018-11-13 Thread Peter Maydell
: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20181113 for you to fetch changes up to 436c0cbbeb38dd97c02fe921a7cb253a18afdd86: target/arm/cpu: Give Cortex-A15 and -A7 the EL2 feature (2018-11-13 10:47

Re: [Qemu-devel] [PULL 00/16] target-arm queue

2018-11-13 Thread Peter Maydell
into staging > (2018-11-12 17:11:22 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20181113 > > for you to fetch changes up to 436c0cbbeb38dd97c02fe921a7cb253a18afdd86: > > tar

[Qemu-devel] [PATCH v2] hw/bt: drop bluetooth keyboard emulation

2018-11-13 Thread Gerd Hoffmann
Broken (segfaults on first keypress, probably since 2.1) and apparently unused. Reproducer: qemu -usb -device usb-bt-dongle -bt hci,vlan=0 -bt device:keyboard Stacktrace: #0 0x5606841f7363 in bt_hid_send_data (ch=0x0, type=1, data=0x560686986400 "", len=8) at /home/kraxel/projects

Re: [Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread Greg Kurz
On Tue, 13 Nov 2018 11:17:19 + xiezhide wrote: > Following is the the patch header, user name and mail are the same at From > and Signed-off-by : > From and Signed-off-by are the same indeed but x00390961 doesn't look like a valid name. You should read the following page. It explains eve

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups

2018-11-13 Thread David Hildenbrand
On 13.11.18 10:03, Cornelia Huck wrote: > On Mon, 12 Nov 2018 18:34:34 +0100 > David Hildenbrand wrote: > >> On 12.11.18 18:14, Cornelia Huck wrote: >>> On Mon, 5 Nov 2018 12:03:09 +0100 >>> David Hildenbrand wrote: >>> The hotplug code needs more love, but let's do some obvious cleanup

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-13 Thread Programmingkid
> On Nov 11, 2018, at 4:35 PM, qemu-devel-requ...@nongnu.org wrote: > > It seems that Cocoa checks are stricter on Mojave and some callbacks that > worked from non-GUI thread on High Sierra are no longer working. > > The fixes included here are: > > * Deferring qemu_main() to another thread s

[Qemu-devel] [PATCH v2] s390x/pci: properly fail if the zPCI device cannot be created

2018-11-13 Thread David Hildenbrand
Right now, errors during realize()/pre_plug/plug of the zPCI device would result in QEMU crashing instead of failing nicely when creating a zPCI device for a PCI device. Reviewed-by: Thomas Huth Reviewed-by: Collin Walling Signed-off-by: David Hildenbrand --- v1 -> v2: - Fix setting of "target

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Kevin Wolf
Am 12.11.2018 um 18:36 hat Cleber Rosa geschrieben: > I hope you don't blame me for trying to have the advantage of the > counter answer. :) Thanks for being so honest, but do you actually need this advantage when you have good technical arguments in favour of your proposal? > >> And run all test

[Qemu-devel] [PATCH v2 2/3] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: xiezhide --- fsdev/qemu-fsdev-dummy.c| 11 fsdev/qemu-fsdev-throttle.c | 144 +--- fsdev/qemu-fsdev-throttle.h |

[Qemu-devel] [PATCH v2 0/3] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. xiezhide (3): fsdev-throttle-qmp: refactor code for qmp interface for io throttling fsdev-throttle-qmp: qmp inte

[Qemu-devel] [PATCH v2 1/3] fsdev-throttle-qmp: refactor code for qmp interface for io throttling

2018-11-13 Thread xiezhide
This patch includes two parts: 1. factor out throttle code to reuse code 2. use ThrottleLimits structure Signed-off-by: xiezhide --- Makefile| 20 +++- Makefile.objs | 8 ++ block/throttle.c| 6 +- blockdev.c |

[Qemu-devel] [PATCH v2 3/3] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: xiezhide --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ 4 files changed, 10

[Qemu-devel] QEMU Advent Calendar 2018 - Help wanted

2018-11-13 Thread Thomas Huth
Hi all! This year, we are celebrating the 15th anniversary of QEMU [1] - to do so, we would like to perform another edition of the QEMU Advent Calendar. If you didn't see the previous QEMU Advent Calendars yet, please visit the website and have a look at the editions from 2014 and 2016 (which

Re: [Qemu-devel] [PATCH v3 7/7] memory-device: rewrite address assignment using ranges

2018-11-13 Thread Igor Mammedov
On Tue, 23 Oct 2018 17:23:06 +0200 David Hildenbrand wrote: > Let's rewrite it properly using ranges. This fixes certain overflows that > are right now possible. E.g. > > qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \ > -object memory-backend-file,id=mem1,share,mem-path=/dev/zero,size=

Re: [Qemu-devel] [PATCH v1 for-3.2 0/7] Get rid of global_qtest in some of the qtests

2018-11-13 Thread Thomas Huth
On 2018-11-13 12:38, no-re...@patchew.org wrote: > Hi, > > This series failed docker-quick@centos7 build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > > Type: series > Message-id: 1542049690-12826-1-

Re: [Qemu-devel] [PULL 0/4] Linux user for 3.1 patches

2018-11-13 Thread Peter Maydell
On 12 November 2018 at 20:49, Laurent Vivier wrote: > The following changes since commit b4c0595446cda9252d2c7bc84f3c02f3e591935a: > > docker: use HTTPS git URL for virglrenderer (2018-11-12 11:26:02 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/l

Re: [Qemu-devel] [PATCH] slirp: add tftp tracing

2018-11-13 Thread Philippe Mathieu-Daudé
On 13/11/18 8:03, Gerd Hoffmann wrote: Useful when debugging pxeboot, to see what the guest tries to do. Good idea! Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- Makefile.objs | 1 + slirp/tftp.c | 3 +++ slirp/tr

Re: [Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
Sure. With git git send-email, seems working now, threads showing, please have a check, thanks: [Qemu-devel] [PATCH v2 1/3] fsdev-throttle-qmp: refactor code for qmp interface for io throttling [Qemu-devel] [PATCH v2 2/3] fsdev-throttle-qmp: qmp interface for fsdev io throttling [Qemu-devel] [

Re: [Qemu-devel] [PATCH v3 7/7] memory-device: rewrite address assignment using ranges

2018-11-13 Thread David Hildenbrand
On 13.11.18 13:26, Igor Mammedov wrote: > On Tue, 23 Oct 2018 17:23:06 +0200 > David Hildenbrand wrote: > >> Let's rewrite it properly using ranges. This fixes certain overflows that >> are right now possible. E.g. >> >> qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \ >> -object memory-b

[Qemu-devel] [PATCH v4] memory-device: rewrite address assignment using ranges

2018-11-13 Thread David Hildenbrand
Let's rewrite it properly using ranges. This fixes certain overflows that are right now possible. E.g. qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \ -object memory-backend-file,id=mem1,share,mem-path=/dev/zero,size=2G -device pc-dimm,memdev=mem1,id=dimm1,addr=-0x4000 Now proper

Re: [Qemu-devel] [PATCH for-3.1] fdc: fix segfault in fdctrl_stop_transfer() when DMA is disabled

2018-11-13 Thread Kevin Wolf
Am 12.11.2018 um 20:58 hat John Snow geschrieben: > > > On 11/11/18 4:40 AM, Mark Cave-Ayland wrote: > > Commit c8a35f1cf0f "fdc: use IsaDma interface instead of global DMA_* > > functions" accidentally introduced a segfault in fdctrl_stop_transfer() for > > non-DMA transfers. > > > > If fdctrl-

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: [...] > Anyway, one specific concern about the "simple way" I have is that we're > adding a hard dependency on an external package (Avocado) that isn't > usually installed anyway on developer machines. Maintainers will of > course just ins

Re: [Qemu-devel] [PULL for-3.1 0/2] qemu-ga patch queue for 3.1.0

2018-11-13 Thread Peter Maydell
On 13 November 2018 at 03:00, Michael Roth wrote: > The following changes since commit 160e5c22e55b3f775c2003dfc626fa872ee4a7a1: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2018-11-09 10:54:10 +) > > are available in the Git repository at: > > git://

Re: [Qemu-devel] [PATCH v1 for-3.2 0/7] Get rid of global_qtest in some of the qtests

2018-11-13 Thread Laurent Vivier
On 13/11/2018 13:31, Thomas Huth wrote: > On 2018-11-13 12:38, no-re...@patchew.org wrote: >> Hi, >> >> This series failed docker-quick@centos7 build test. Please find the testing >> commands and >> their output below. If you have Docker installed, you can probably reproduce >> it >> locally. >>

[Qemu-devel] qga-win: Build errors when building with vss support

2018-11-13 Thread Sameeh Jubran
Hi all, The following errors show up when attempting to compile qemu-ga for windows which is done using mingw: qga/vss-win32/requester.o: In function `requester_freeze': /home/bishara/git_qemu/qga/vss-win32/requester.cpp:283: undefined reference to `g_assertion_message_expr' qga/vss-win32/request

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Daniel P . Berrangé
On Tue, Nov 13, 2018 at 10:39:57AM +0100, Markus Armbruster wrote: > Drive-by comment... > > Cleber Rosa writes: > > [...] > > My impression is that the "infrastructure for block tests" is not that > > different from the infrastructure needed by other tests, specially other > > QEMU tests. > [..

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Kevin Wolf
Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: > On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: > [...] > > Anyway, one specific concern about the "simple way" I have is that we're > > adding a hard dependency on an external package (Avocado) that isn't > > usually installed a

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 02:51:16PM +0100, Kevin Wolf wrote: > Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: > > On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: > > [...] > > > Anyway, one specific concern about the "simple way" I have is that we're > > > adding a hard dependen

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 7:18 AM, Kevin Wolf wrote: > Am 12.11.2018 um 18:36 hat Cleber Rosa geschrieben: >> I hope you don't blame me for trying to have the advantage of the >> counter answer. :) > > Thanks for being so honest, but do you actually need this advantage when > you have good technical arguments

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 8:51 AM, Kevin Wolf wrote: > Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: >> On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: >> [...] >>> Anyway, one specific concern about the "simple way" I have is that we're >>> adding a hard dependency on an external packag

Re: [Qemu-devel] [PATCH v1 for-3.2 0/7] Get rid of global_qtest in some of the qtests

2018-11-13 Thread Thomas Huth
On 2018-11-13 14:36, Laurent Vivier wrote: > On 13/11/2018 13:31, Thomas Huth wrote: >> On 2018-11-13 12:38, no-re...@patchew.org wrote: >>> Hi, >>> >>> This series failed docker-quick@centos7 build test. Please find the testing >>> commands and >>> their output below. If you have Docker installed

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 09:20:11AM -0500, Cleber Rosa wrote: > > > On 11/13/18 8:51 AM, Kevin Wolf wrote: > > Am 13.11.2018 um 14:26 hat Eduardo Habkost geschrieben: > >> On Tue, Nov 13, 2018 at 01:18:36PM +0100, Kevin Wolf wrote: > >> [...] > >>> Anyway, one specific concern about the "simple wa

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 8:50 AM, Daniel P. Berrangé wrote: > On Tue, Nov 13, 2018 at 10:39:57AM +0100, Markus Armbruster wrote: >> Drive-by comment... >> >> Cleber Rosa writes: >> >> [...] >>> My impression is that the "infrastructure for block tests" is not that >>> different from the infrastructure neede

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Cleber Rosa
On 11/13/18 9:32 AM, Eduardo Habkost wrote: > On Tue, Nov 13, 2018 at 09:20:11AM -0500, Cleber Rosa wrote: > > With check-venv, we made "installing avocado" a small > implementation detail that people don't need to care about when > running the tests. > > I believe the sentence "which must be i

Re: [Qemu-devel] [PATCH qemu] hmp: Print if memory section is registered in KVM

2018-11-13 Thread Dr. David Alan Gilbert
* Alexey Kardashevskiy (a...@ozlabs.ru) wrote: > This adds a "KVM" marker to the "into mtree -f" to tell the user if > a particular memory section is registered as a KVM memory slot; useful > for debugging purposes. > > Since it is memory sections which get registered in KVM (rather than > memory

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2018 at 09:43:49AM -0500, Cleber Rosa wrote: > > On 11/13/18 9:32 AM, Eduardo Habkost wrote: > > On Tue, Nov 13, 2018 at 09:20:11AM -0500, Cleber Rosa wrote: > > > > With check-venv, we made "installing avocado" a small > > implementation detail that people don't need to care abou

Re: [Qemu-devel] KVM Forum block no[td]es

2018-11-13 Thread Alberto Garcia
On Sun 11 Nov 2018 11:25:00 PM CET, Max Reitz wrote: > Permission system > = > > GRAPH_MOD > - > > We need some way for the commit job to prevent graph changes on its > chain while it is running. Our current blocker doesn’t do the job, > however. What to do? > > - We have

[Qemu-devel] [PATCH] tests/ide: Free pcibus when finishing a test

2018-11-13 Thread Thomas Huth
Once a test has finished, the pcibus structure should be freed, to avoid leaking memory and to make sure that the structure is properly re-initialized when the next test starts. Signed-off-by: Thomas Huth --- tests/ide-test.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/ide-test

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-13 Thread Michael S. Tsirkin
On Tue, Nov 13, 2018 at 10:21:07AM +0200, Yuri Benditovich wrote: > > > On Mon, Nov 12, 2018 at 10:53 PM Michael S. Tsirkin wrote: > > On Mon, Nov 12, 2018 at 01:31:36PM +0200, Yuri Benditovich wrote: > > > > > > On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > >

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-13 Thread Kevin Wolf
Hi Cleber, I will shorten this email a lot while replying because I have the impression that most of the discussion isn't actually as productive as it could be. I'm not trying to evade on any point that I'm cutting out, so if there is something specific in the part I'm removing that you would like

Re: [Qemu-devel] [PULL V2 24/26] net: ignore packet size greater than INT_MAX

2018-11-13 Thread Dima Stepanov
Hi Jason, I know that this patch has been already merged to stable, but i have a question: On Fri, Oct 19, 2018 at 11:22:23AM +0800, Jason Wang wrote: > There should not be a reason for passing a packet size greater than > INT_MAX. It's usually a hint of bug somewhere, so ignore packet size > gre

[Qemu-devel] [PATCH v4 3/4] target/arm: Introduce read_sys_reg32 for kvm32

2018-11-13 Thread Richard Henderson
Assert that the value to be written is the correct size. No change in functionality here, just mirroring the same function from kvm64. Signed-off-by: Richard Henderson --- target/arm/kvm32.c | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) diff -

[Qemu-devel] [PATCH v4 1/4] target/arm: Install ARMISARegisters from kvm host

2018-11-13 Thread Richard Henderson
The ID registers are replacing (some of) the feature bits. We need (some of) these values to determine the set of data to be handled during migration. Signed-off-by: Richard Henderson --- target/arm/kvm_arm.h | 1 + target/arm/kvm.c | 1 + 2 files changed, 2 insertions(+) diff --git a/targe

[Qemu-devel] [PATCH v4 2/4] target/arm: Fill in ARMISARegisters for kvm64

2018-11-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/kvm64.c | 62 -- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 46fbe6d8ff..8dff8749c9 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c

[Qemu-devel] [PATCH v4 0/4] target/arm: KVM vs ARMISARegisters

2018-11-13 Thread Richard Henderson
My previous patch set for replacing feature bits with id registers failed to consider that these id registers are beginning to control migration, and thus we must fill them in for KVM as well. Thus, we want to initialize these values within CPU from the host. Changes, v3->v4: * Drop THUMB2EE p

[Qemu-devel] [PATCH v4 4/4] target/arm: Fill in ARMISARegisters for kvm32

2018-11-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/kvm32.c | 40 +++- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/target/arm/kvm32.c b/target/arm/kvm32.c index bc0badf53d..bd51eb43c8 100644 --- a/target/arm/kvm32.c +++ b/target/arm/kvm32.c @@ -4

Re: [Qemu-devel] [PATCH v6 0/5] Connect a PCIe host and graphics support to RISC-V

2018-11-13 Thread Andrea Bolognani
On Wed, 2018-11-07 at 13:47 -0800, Alistair Francis wrote: > I don't think there is even MSI support in the interrupt spec (I > haven't looked at all though), yet alone in QEMU. Unfortunately it > seems low down on the list of things we need to do so it will probably > be awhile. That's perfectly

Re: [Qemu-devel] [PATCH] tests/ide: Free pcibus when finishing a test

2018-11-13 Thread Eric Blake
On 11/13/18 9:11 AM, Thomas Huth wrote: Once a test has finished, the pcibus structure should be freed, to avoid leaking memory and to make sure that the structure is properly re-initialized when the next test starts. Signed-off-by: Thomas Huth --- tests/ide-test.c | 4 1 file changed,

Re: [Qemu-devel] [PATCH qemu] hmp: Print if memory section is registered in KVM

2018-11-13 Thread Paolo Bonzini
On 13/11/2018 15:51, Dr. David Alan Gilbert wrote: > * Alexey Kardashevskiy (a...@ozlabs.ru) wrote: >> This adds a "KVM" marker to the "into mtree -f" to tell the user if >> a particular memory section is registered as a KVM memory slot; useful >> for debugging purposes. >> >> Since it is memory se

Re: [Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters

2018-11-13 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:33 +0100 Samuel Ortiz wrote: > This is going to be needed by the hardware reduced implementation, so > let's export it. > Once the ACPI builder methods and getters will be implemented, the > acpi_get_pci_host() implementation will become hardware agnostic. > > Signed-of

Re: [Qemu-devel] [PATCH v2] s390x/pci: properly fail if the zPCI device cannot be created

2018-11-13 Thread Cornelia Huck
On Tue, 13 Nov 2018 13:17:10 +0100 David Hildenbrand wrote: > Right now, errors during realize()/pre_plug/plug of the zPCI device > would result in QEMU crashing instead of failing nicely when creating > a zPCI device for a PCI device. > > Reviewed-by: Thomas Huth > Reviewed-by: Collin Walling

Re: [Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test

2018-11-13 Thread Eric Blake
On 11/9/18 12:21 PM, Wainer dos Santos Moschetta wrote: QEMU used to exits with a not accurate error message when s/exits/exit/ s/a not accurate/an inaccurate/ an initrd > 2GiB was passed. That was fixed on patch: commit f3839fda5771596152b75dd1e1a6d050e6e6e380 Author: Li Zhi

[Qemu-devel] [PATCH 1/1] qga: update docs with systemd suspend support info

2018-11-13 Thread Daniel Henrique Barboza
Commit 067927d62e ("qga: systemd hibernate/suspend/hybrid-sleep support") failed to update qapi-schema.json after adding systemd hibernate/suspend/hybrid-sleep capabilities to guest-suspend-* QGA commands. Signed-off-by: Daniel Henrique Barboza --- qga/qapi-schema.json | 37 +

Re: [Qemu-devel] [PATCH 1/1] qga: update docs with systemd suspend support info

2018-11-13 Thread Eric Blake
On 11/13/18 10:09 AM, Daniel Henrique Barboza wrote: Commit 067927d62e ("qga: systemd hibernate/suspend/hybrid-sleep support") failed to update qapi-schema.json after adding systemd hibernate/suspend/hybrid-sleep capabilities to guest-suspend-* QGA commands. Signed-off-by: Daniel Henrique Barboz

Re: [Qemu-devel] [PATCH] tests/ide: Free pcibus when finishing a test

2018-11-13 Thread Philippe Mathieu-Daudé
On 13/11/18 16:11, Thomas Huth wrote: Once a test has finished, the pcibus structure should be freed, to avoid leaking memory and to make sure that the structure is properly re-initialized when the next test starts. Signed-off-by: Thomas Huth --- tests/ide-test.c | 4 1 file changed, 4

Re: [Qemu-devel] [PATCH 1/1] qga: update docs with systemd suspend support info

2018-11-13 Thread Daniel Henrique Barboza
On 11/13/18 2:32 PM, Eric Blake wrote: On 11/13/18 10:09 AM, Daniel Henrique Barboza wrote: Commit 067927d62e ("qga: systemd hibernate/suspend/hybrid-sleep support") failed to update qapi-schema.json after adding systemd hibernate/suspend/hybrid-sleep capabilities to guest-suspend-* QGA comma

[Qemu-devel] [PATCH] qcow2: Assert that refcount block offsets fit in the refcount table

2018-11-13 Thread Alberto Garcia
Refcount table entries have a field to store the offset of the refcount block. The rest of the bits of the entry are currently reserved. The offset is always taken from the entry using REFT_OFFSET_MASK to ensure that we only use the bits that belong to that field. While that mask is used every ti

[Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-13 Thread Samuel Ortiz
Most of them are TCG dependent so we want to be able to not build them in order to support TCG disablement with ARM. Signed-off-by: Samuel Ortiz Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/excp_helper.c | 550 +++ target/arm

Re: [Qemu-devel] [PATCH 01/13] target: arm: Add copyright boilerplate

2018-11-13 Thread Philippe Mathieu-Daudé
On 13/11/18 17:58, Peter Maydell wrote: On 13 November 2018 at 16:52, Samuel Ortiz wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford Reviewed-by: Samuel Ortiz --- target/arm/helper.c | 7 +++ 1 file changed, 7 insertions(+) diff

  1   2   >