Re: [Qemu-devel] [PULL 05/48] qemu-timer: optimize record/replay checkpointing for all clocks

2018-10-19 Thread Artem Pisarenko
> Signed-off-by: Artem Pisarenko > Message-Id: < 549dbf4ebfa4c82051d01a264c27f88929fc277b.1539764043.git.artem.k.pisare...@gmail.com > Actually this version has nothing common with my person. Neither original idea, nor content. Except maybe of my involvement in its discussion, commit message and

Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 03:05, Emilio G. Cota wrote: > I'm calling this series a v3 because it supersedes the two series > I previously sent about using atomics for interrupt_request: > https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg02013.html > The approach in that series cannot work reliably; u

Re: [Qemu-devel] [PATCH v3 3/3] linux-user: Implement special usbfs ioctls.

2018-10-19 Thread Laurent Vivier
Le 19/10/2018 à 04:16, Cortland Setlow Tölva a écrit : > On Thu, Oct 18, 2018 at 11:48 AM Laurent Vivier wrote: >> >> Le 08/10/2018 à 18:35, Cortland Tölva a écrit : >>> Userspace submits a USB Request Buffer to the kernel, optionally >>> discards it, and finally reaps the URB. Thunk buffers from

Re: [Qemu-devel] [PULL 00/48] Miscellaneous patches for 2018-10-18

2018-10-19 Thread Paolo Bonzini
On 18/10/2018 22:31, Paolo Bonzini wrote: > The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18 > 13:40:19 +0100) > > are available in the git repository at:

[Qemu-devel] [PULL v2 00/47] Miscellaneous patches for 2018-10-18

2018-10-19 Thread Paolo Bonzini
The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18 13:40:19 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [Qemu-devel] [web PATCH] Add a git-publish configuration file

2018-10-19 Thread Paolo Bonzini
On 18/10/2018 16:57, Daniel P. Berrangé wrote: > This adds a config file for git-publish, primarily so that patches get > sent with the "web" subject prefix to distinguish them from patches to > the main git repo. > > Signed-off-by: Daniel P. Berrangé > --- > > I picked Paolo & Thomas as CC sinc

Re: [Qemu-devel] [RFC v2 00/28] vSMMUv3/pSMMUv3 2 stage VFIO integration

2018-10-19 Thread Liu, Yi L
Hi Eric, > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Thursday, October 18, 2018 11:16 PM > > Hi Yi, > > On 10/18/18 12:30 PM, Liu, Yi L wrote: > > Hi Eric, > > > >> From: Eric Auger [mailto:eric.au...@redhat.com] > >> Sent: Friday, September 21, 2018 4:18 PM > >> Subject: [RFC v2 0

Re: [Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property

2018-10-19 Thread Gerd Hoffmann
On Mon, Oct 15, 2018 at 11:26:39AM +0800, Mao Zhongyi wrote: > According to qdev-properties.h, properties of pointer type > should be avoid, so convert qdev property to link, Whilst we > are here, also update some hardcoded strings with already > defineded macros. Patch series breaks "make check".

Re: [Qemu-devel] [PATCH] hw: AC97: make it more QOMconventional

2018-10-19 Thread Gerd Hoffmann
On Fri, Oct 12, 2018 at 11:08:09PM -0700, Li Qiang wrote: > Signed-off-by: Li Qiang Added to audio patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 8/9] iotests: Modify imports for Python 3

2018-10-19 Thread Max Reitz
On 15.10.18 20:59, Cleber Rosa wrote: > > > On 10/15/18 10:14 AM, Max Reitz wrote: >> There are two imports that need to be modified when running the iotests >> under Python 3: One is StringIO, which no longer exists; instead, the >> StringIO class comes from the io module, so import it from ther

Re: [Qemu-devel] [PATCH] es1370: more fixes for ADC_FRAMEADR and ADC_FRAMECNT

2018-10-19 Thread Thomas Huth
On 2018-10-16 15:50, Paolo Bonzini wrote: > They are not consecutive with DAC1_FRAME* and DAC2_FRAME*; Coverity > still complains about es1370_read, while es1370_write was fixed in > commit cf9270e5220671f49cc238deaf6136669cc07ae1. > > Fixes: 154c1d1f960c5147a3f8ef00907504112f271cd8 > Signed-off-b

Re: [Qemu-devel] [PATCH 3/9] iotests: Use Python byte strings where appropriate

2018-10-19 Thread Max Reitz
On 15.10.18 21:53, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 04:14:47PM +0200, Max Reitz wrote: >> Since byte strings are no longer the default in Python 3, we have to >> explicitly use them where we need to, which is mostly when working with >> structures. It also means that we need to ope

Re: [Qemu-devel] [RFC v4 02/16] linux-headers: header update for KVM/ARM KVM_ARM_GET_MAX_VM_PHYS_SHIFT

2018-10-19 Thread Suzuki K Poulose
Hi Eric, On 10/18/2018 03:30 PM, Eric Auger wrote: This is a header update against kvmarm next branch git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm kvmarm/next to get the KVM_ARM_GET_MAX_VM_PHYS_SHIFT ioctl. This allows to retrieve the IPA address range KVM supports. Signed-off-

Re: [Qemu-devel] [PATCH 5/9] iotests: Different iterator behavior in Python 3

2018-10-19 Thread Max Reitz
On 15.10.18 22:07, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 04:14:49PM +0200, Max Reitz wrote: >> In Python 3, several functions now return iterators instead of lists. >> This includes range(), items(), map(), and filter(). This means that if >> we really want a list, we have to wrap those

Re: [Qemu-devel] [PATCH] tests: docker: update test-mingw for GTK+ 2.0 removal

2018-10-19 Thread Thomas Huth
On 2018-10-18 20:10, Paolo Bonzini wrote: > --with-gtkabi does not exist anymore; remove it from the configure invocation. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/test-mingw | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/docker/test-mingw b/tests/

[Qemu-devel] [PATCH v4] Add arm SBSA reference machine

2018-10-19 Thread Hongbo Zhang
For the Aarch64, there is one machine 'virt', it is primarily meant to run on KVM and execute virtualization workloads, but we need an environment as faithful as possible to physical hardware, to support firmware and OS development for pysical Aarch64 machines. See the patch commit comments for t

[Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-10-19 Thread Hongbo Zhang
For the Aarch64, there is one machine 'virt', it is primarily meant to run on KVM and execute virtualization workloads, but we need an environment as faithful as possible to physical hardware, for supporting firmware and OS development for pysical Aarch64 machines. This patch introduces new machin

Re: [Qemu-devel] [PULL 06/48] target-i386: kvm: do not initialize padding fields

2018-10-19 Thread Peter Maydell
On 18 October 2018 at 21:31, Paolo Bonzini wrote: > The exception.pad field is going to be renamed to pending in an upcoming > header file update. Remove the unnecessary initialization; it was > introduced to please valgrind (commit 7e680753cfa2) but they were later > rendered unnecessary by comm

Re: [Qemu-devel] [PATCH 6/9] iotests: Explicitly inherit FDs in Python

2018-10-19 Thread Max Reitz
On 15.10.18 22:30, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 04:14:50PM +0200, Max Reitz wrote: >> Python 3.2 introduced the inheritable attribute for FDs. At the same >> time, it changed the default so that all FDs are not inheritable by >> default, that only inheritable FDs are inherited

Re: [Qemu-devel] [PATCH 4/9] iotests: Use // for Python integer division

2018-10-19 Thread Max Reitz
On 15.10.18 23:13, Cleber Rosa wrote: > > > On 10/15/18 10:14 AM, Max Reitz wrote: >> In Python 3, / is always a floating-point division. We usually do not >> want this, and as Python 2.7 understands // as well, change all integer >> divisions to use that. >> >> Signed-off-by: Max Reitz >> ---

Re: [Qemu-devel] [PATCH 0/9] iotests: Make them work for both Python 2 and 3

2018-10-19 Thread Max Reitz
On 16.10.18 00:19, Philippe Mathieu-Daudé wrote: > Hi Max, > > On 15/10/2018 16:14, Max Reitz wrote: >> This series prepares the iotests to work with both Python 2 and 3. In >> some places, it adds version-specific code and decides what to do based >> on the version (for instance, whether to impo

Re: [Qemu-devel] [PATCH v5 11/11] authz: delete existing ACL implementation

2018-10-19 Thread Philippe Mathieu-Daudé
On 09/10/2018 15:04, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > The 'qemu_acl' type was a previous non-QOM based attempt to provide an > authorization facility in QEMU. Because it is non-QOM based it cannot be > created via the command line and requires special monitor commands to

Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

2018-10-19 Thread Philippe Mathieu-Daudé
Hi Daniel, Markus. On 09/10/2018 15:04, Daniel P. Berrangé wrote: ... > .gitignore | 4 + > MAINTAINERS | 1 + > Makefile| 7 +- > Makefile.objs | 4 + > authz/Makefile.objs | 1 + > authz/list.c| 315 +++

Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 11:18:07AM +0200, Philippe Mathieu-Daudé wrote: > Hi Daniel, Markus. > > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > ... > > .gitignore | 4 + > > MAINTAINERS | 1 + > > Makefile| 7 +- > > Makefile.objs | 4 +

[Qemu-devel] [Bug 1798780] [NEW] hw/usb/dev-mtp.c:1616: bad test ?

2018-10-19 Thread dcb
Public bug reported: hw/usb/dev-mtp.c:1616:52: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op] Source code is if ((ret == -1) && (errno != EINTR || errno != EAGAIN || errno != EWOULDBLOCK)) { Maybe better c

Re: [Qemu-devel] [PATCH 8/9] iotests: Modify imports for Python 3

2018-10-19 Thread Max Reitz
On 16.10.18 02:12, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 08:05:02PM -0400, Cleber Rosa wrote: >> >> >> On 10/15/18 5:17 PM, Eduardo Habkost wrote: >>> On Mon, Oct 15, 2018 at 04:14:52PM +0200, Max Reitz wrote: There are two imports that need to be modified when running the iotests >

Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

2018-10-19 Thread Philippe Mathieu-Daudé
Hi Daniel, On 09/10/2018 15:04, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > Add a QAuthZList object type that implements the QAuthZ interface. This > built-in implementation maintains a trivial access control list with a > sequence of match rules and a final default policy. This r

Re: [Qemu-devel] [PATCH 9/9] iotests: Unify log outputs between Python 2 and 3

2018-10-19 Thread Max Reitz
On 16.10.18 00:26, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 04:14:53PM +0200, Max Reitz wrote: >> When dumping an object into the log, there are differences between >> Python 2 and 3. First, unicode strings are prefixed by 'u' in Python 2 >> (they are no longer in 3, because unicode string

Re: [Qemu-devel] [PATCH v4 37/38] raw: Convert a warning to warn_report()

2018-10-19 Thread Markus Armbruster
I'm dropping this patch for now. Nice formatting of hints is good. Consistency is good. The way to get both is probably a more structured interface to print hints after FOO_report(). But this goes beyond what this series tries to do.

Re: [Qemu-devel] [PATCH v5 09/11] authz: add QAuthZListFile object type for a file access control list

2018-10-19 Thread Philippe Mathieu-Daudé
On 09/10/2018 15:04, Daniel P. Berrangé wrote: > Add a QAuthZListFile object type that implements the QAuthZ interface. This > built-in implementation is a proxy around the QAtuhZList object type, > initializing it from an external file, and optionally, automatically > reloading it whenever it chan

Re: [Qemu-devel] [PATCH 5/9] iotests: Different iterator behavior in Python 3

2018-10-19 Thread Max Reitz
On 16.10.18 00:39, Cleber Rosa wrote: > > > On 10/15/18 10:14 AM, Max Reitz wrote: >> In Python 3, several functions now return iterators instead of lists. >> This includes range(), items(), map(), and filter(). This means that if >> we really want a list, we have to wrap those instances with li

Re: [Qemu-devel] [PATCH 6/9] iotests: Explicitly inherit FDs in Python

2018-10-19 Thread Max Reitz
On 16.10.18 01:18, Cleber Rosa wrote: > > > On 10/15/18 10:14 AM, Max Reitz wrote: >> Python 3.2 introduced the inheritable attribute for FDs. At the same >> time, it changed the default so that all FDs are not inheritable by >> default, that only inheritable FDs are inherited to subprocesses, a

Re: [Qemu-devel] [PATCH 7/9] iotests: 'new' module replacement in 169

2018-10-19 Thread Max Reitz
On 16.10.18 03:01, Cleber Rosa wrote: > > > On 10/15/18 7:57 PM, Eduardo Habkost wrote: >> On Mon, Oct 15, 2018 at 07:38:45PM -0400, Cleber Rosa wrote: >>> >>> >>> On 10/15/18 10:14 AM, Max Reitz wrote: iotest 169 uses the 'new' module to add methods to a class. This module no longer e

Re: [Qemu-devel] [PATCH] tests: docker: update test-mingw for GTK+ 2.0 removal

2018-10-19 Thread Philippe Mathieu-Daudé
On 18/10/2018 20:10, Paolo Bonzini wrote: > --with-gtkabi does not exist anymore; remove it from the configure invocation. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/test-mingw | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/docker/test-mingw b/tests/

Re: [Qemu-devel] [PATCH 1/9] iotests: Make nbd-fault-injector flush

2018-10-19 Thread Max Reitz
On 16.10.18 20:07, Eric Blake wrote: > On 10/15/18 9:14 AM, Max Reitz wrote: >> When closing a connection, make the nbd-fault-injector flush the socket. >> Without this, the output is a bit unreliable with Python 3. >> >> Signed-off-by: Max Reitz >> --- >>   tests/qemu-iotests/083.out 

Re: [Qemu-devel] [PATCH 3/5] dev-mtp: retry write for incomplete transfers

2018-10-19 Thread Thomas Huth
On 2018-07-20 23:40, Bandan Das wrote: > For large buffers, write may not copy the full buffer. For example, > on Linux, write imposes a limit of 0x7000. Note that this does > not fix >4G transfers but ~>2G files will transfer successfully. > > Signed-off-by: Bandan Das > --- > hw/usb/dev-mt

Re: [Qemu-devel] [PATCH v5 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks

2018-10-19 Thread Philippe Mathieu-Daudé
On 09/10/2018 15:04, Daniel P. Berrangé wrote: > In many cases a single VM will just need to whilelist a single identity > as the allowed user of network services. This is especially the case for > TLS live migration (optionally with NBD storage) where we just need to > whitelist the x509 certifica

Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

2018-10-19 Thread Philippe Mathieu-Daudé
On 09/10/2018 15:04, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > Add a QAuthZList object type that implements the QAuthZ interface. This > built-in implementation maintains a trivial access control list with a > sequence of match rules and a final default policy. This replicates th

Re: [Qemu-devel] [PATCH 1/5] option: Make option help nicer to read

2018-10-19 Thread Max Reitz
On 16.10.18 08:46, Marc-André Lureau wrote: > Hi > > On Mon, Oct 15, 2018 at 9:34 PM Max Reitz wrote: >> >> This adds some whitespace into the option help (including indentation) >> and replaces '=' by ': ' (not least because '=' should be used for >> values, not types). > > Without strong prefe

Re: [Qemu-devel] [Qemu-block] [PATCH 1/5] option: Make option help nicer to read

2018-10-19 Thread Max Reitz
On 16.10.18 14:12, Kevin Wolf wrote: > Am 15.10.2018 um 19:28 hat Max Reitz geschrieben: >> This adds some whitespace into the option help (including indentation) >> and replaces '=' by ': ' (not least because '=' should be used for >> values, not types). Furthermore, the list name is no longer pr

Re: [Qemu-devel] [PATCH 1/5] option: Make option help nicer to read

2018-10-19 Thread Max Reitz
On 17.10.18 08:50, Markus Armbruster wrote: > Max Reitz writes: > >> This adds some whitespace into the option help (including indentation) >> and replaces '=' by ': ' (not least because '=' should be used for >> values, not types). Furthermore, the list name is no longer printed as >> part of e

Re: [Qemu-devel] [RFC v1 1/1] qemu-iotests: Fix output for testcase 082

2018-10-19 Thread Max Reitz
On 16.10.18 15:00, Farhan Ali wrote: > > > On 10/15/2018 11:45 AM, Max Reitz wrote: >>> 082 is failing for me on master (046936ed), and this fixes it. >>> >>> I'm wondering if/why other people are not running into this, as 082 runs >>> with qcow2 and is included on `make check-block`. >>> >>> + M

Re: [Qemu-devel] [PATCH v5 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-10-19 Thread Philippe Mathieu-Daudé
On 09/10/2018 15:04, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > Add an authorization backend that talks to PAM to check whether the user > identity is allowed. This only uses the PAM account validation facility, > which is essentially just a check to see if the provided username i

Re: [Qemu-devel] [PATCH v5 00/11] Add a standard authorization framework

2018-10-19 Thread Philippe Mathieu-Daudé
Hi Daniel, On 18/10/2018 17:19, Daniel P. Berrangé wrote: > ping, is anyone able to review the patches in this series. We are > awfully close to soft freeze and KVM forum... I'll let the inotify patches to someone more familiar with it (patches #1 and #5). Patch #5 definitively requires Gerd's re

Re: [Qemu-devel] When it's okay to treat OOM as fatal?

2018-10-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > >> >> "Dr. David Alan Gilbert" writes: > >> >> > >> >> > *

[Qemu-devel] [PATCH] websock: fix handshake leak

2018-10-19 Thread Marc-André Lureau
Thanks Valgrind: ==955== 217 bytes in 1 blocks are definitely lost in loss record 275 of 321 ==955==at 0x483A965: realloc (vg_replace_malloc.c:785) ==955==by 0x50B6839: __vasprintf_chk (in /usr/lib64/libc-2.28.so) ==955==by 0x49AA05C: g_vasprintf (in /usr/lib64/libglib-2.0.so.0.5800.1)

Re: [Qemu-devel] [PATCH v3 3/3] tests/test-char: Check websocket chardev functionality

2018-10-19 Thread Marc-André Lureau
Hi On Fri, Oct 19, 2018 at 2:35 AM Julia Suvorova wrote: > > Test order: > Creating server websocket chardev > Creating usual tcp chardev client > Sending handshake message from client > Receiving handshake reply > Sending ping frame with "hello" payload > Receiving pong r

Re: [Qemu-devel] [PATCH v3 2/3] chardev: Add websocket support

2018-10-19 Thread Marc-André Lureau
Hi On Fri, Oct 19, 2018 at 2:35 AM Julia Suvorova wrote: > > New option "websocket" added to allow using WebSocket protocol for > chardev socket backend. > Example: > -chardev socket,websocket,server,id=... > > Signed-off-by: Julia Suvorova > --- > chardev/char-socket.c | 64 +++

Re: [Qemu-devel] [PATCH v3 1/3] chardev/char-socket: Function headers refactoring

2018-10-19 Thread Marc-André Lureau
Hi On Fri, Oct 19, 2018 at 2:35 AM Julia Suvorova wrote: > > Upcoming websocket support requires additional parameters in function > headers that are already overloaded. This patch replaces the bunch of > parameters with a single structure pointer. > > Signed-off-by: Julia Suvorova Reviewed-by:

[Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-19 Thread Hongbo Zhang
Remove the unused herder files, 'virt' can be compiled and run without including them. Signed-off-by: Hongbo Zhang --- hw/arm/virt.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 9f67782..f0066cb 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -

Re: [Qemu-devel] [PULL v2 00/28] MIPS queue October 2018, part 1, v2

2018-10-19 Thread Peter Maydell
On 18 October 2018 at 19:47, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18 > 13:40:19 +0100)

Re: [Qemu-devel] check-tcg failure

2018-10-19 Thread Alex Bennée
Richard Henderson writes: > On aa64, "cross-compiling" to aa32, with > > CC=arm-linux-gnueabihf-gcc So this is different from ./configure --cross-cc=arch-linux-gnueabihf- > > configure determines > > aarch64-linux-user/config-target.mak:CROSS_CC_GUEST="aarch64-linux-gnu-gcc" > aarch64-linux-u

Re: [Qemu-devel] [web PATCH 0/4] Add web section reporting information about CVEs in QEMU

2018-10-19 Thread Daniel P . Berrangé
On Thu, Oct 18, 2018 at 11:36:39PM +0200, Paolo Bonzini wrote: > On 18/10/2018 16:51, Daniel P. Berrangé wrote: > > > > After adding the new $YEAR/$ID.xml file, 'make' will build the > > corresponding indexes and HTML/TXT renderings. Ideally the machine which > > is hosting the QEMU website would

Re: [Qemu-devel] [PATCH] websock: fix handshake leak

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 02:13:46PM +0400, Marc-André Lureau wrote: > Thanks Valgrind: > > ==955== 217 bytes in 1 blocks are definitely lost in loss record 275 of 321 > ==955==at 0x483A965: realloc (vg_replace_malloc.c:785) > ==955==by 0x50B6839: __vasprintf_chk (in /usr/lib64/libc-2.28.so)

Re: [Qemu-devel] [PATCH v4 0/8] target/arm: Rely on id regs instead of features

2018-10-19 Thread Peter Maydell
On 16 October 2018 at 23:31, Richard Henderson wrote: > This edition moves some of the system registers into a substructure, > which is then shared with "normal" runtime and the translators. > This is seen as a better solution than letting the entire translator > have access to the main ARMCPU str

Re: [Qemu-devel] [PULL 2/7] tests/migration: Enable the migration test on s390x, too

2018-10-19 Thread Thomas Huth
On 2018-10-18 16:53, Wei Huang wrote: > > > On 10/18/2018 07:43 AM, Emilio G. Cota wrote: >> On Thu, Oct 18, 2018 at 14:38:01 +0200, Thomas Huth wrote: >>> On 2018-10-17 21:28, Emilio G. Cota wrote: Can anyone reproduce this? Otherwise, let me know what other info I could provide. >>> >

[Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Alex Bennée
The purpose of the code is to use the designated compiler for building the targets test cases. This is not actually host_cc which will still be cc even when we are cross compiling. As the tests for $cpu all use $cc we should do the same. Signed-off-by: Alex Bennée Reported-by: Richard Henderson

[Qemu-devel] [PATCH 2/2] hw: ccid-card-emulated: cleanup resource when realize in error path

2018-10-19 Thread Li Qiang
Signed-off-by: Li Qiang --- hw/usb/ccid-card-emulated.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index b356edb..25976ed 100644 --- a/hw/usb/ccid-card-emulated.c +++ b/hw/usb/ccid-card-emulat

[Qemu-devel] [PATCH 1/2] hw: ccid-card-emulated: introduce clean_event_notifier

2018-10-19 Thread Li Qiang
Call it in device unrealize function. Signed-off-by: Li Qiang --- hw/usb/ccid-card-emulated.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index 5c8b3c9..b356edb 100644 --- a/hw/usb/ccid-card-emulated.c +++ b/hw/usb/ccid-car

[Qemu-devel] [PATCH 0/2] hw: ccid-card-emulated: fix some resources leak

2018-10-19 Thread Li Qiang
Li Qiang (2): hw: ccid-card-emulated: introduce clean_event_notifier hw: ccid-card-emulated: cleanup resource when realize in error path hw/usb/ccid-card-emulated.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) -- 1.8.3.1

Re: [Qemu-devel] [PATCH v3 1/3] chardev/char-socket: Function headers refactoring

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 01:34:59AM +0300, Julia Suvorova wrote: > Upcoming websocket support requires additional parameters in function > headers that are already overloaded. This patch replaces the bunch of > parameters with a single structure pointer. > > Signed-off-by: Julia Suvorova > --- >

Re: [Qemu-devel] [PATCH v3 2/3] chardev: Add websocket support

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 02:15:10PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Oct 19, 2018 at 2:35 AM Julia Suvorova wrote: > > > > New option "websocket" added to allow using WebSocket protocol for > > chardev socket backend. > > Example: > > -chardev socket,websocket,server,id=... > >

Re: [Qemu-devel] [PATCH v2] hw/arm/boot: Increase compliance with kernel arm64 boot protocol

2018-10-19 Thread Peter Maydell
On 16 October 2018 at 16:06, Stewart Hildebrand wrote: > "The Image must be placed text_offset bytes from a 2MB aligned base > address anywhere in usable system RAM and called there." > > For the virt board, we write our startup bootloader at the very > bottom of RAM, so that bit can't be used for

[Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG

2018-10-19 Thread Thomas Huth
The migration test for s390x sometimes hangs when running with TCG, similar to the problems that we have already observed with TCG for the ppc64 guests. Thus disable the s390x test when we are not running with KVM for now until the problem with TCG has been resolved. Signed-off-by: Thomas Huth --

Re: [Qemu-devel] [PATCH v3 3/3] tests/test-char: Check websocket chardev functionality

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 01:35:01AM +0300, Julia Suvorova wrote: > Test order: > Creating server websocket chardev > Creating usual tcp chardev client > Sending handshake message from client > Receiving handshake reply > Sending ping frame with "hello" payload > Receiving pon

Re: [Qemu-devel] [PATCH v3 2/3] chardev: Add websocket support

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 01:35:00AM +0300, Julia Suvorova wrote: > New option "websocket" added to allow using WebSocket protocol for > chardev socket backend. > Example: > -chardev socket,websocket,server,id=... > > Signed-off-by: Julia Suvorova > --- > chardev/char-socket.c | 64 +++

Re: [Qemu-devel] [PATCH v5 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-10-19 Thread Daniel P . Berrangé
On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote: > On 09/10/2018 15:04, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Add an authorization backend that talks to PAM to check whether the user > > identity is allowed. This only uses the PAM account validati

Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree

2018-10-19 Thread Bastian Koppelmann
Hi Richard, On 10/12/18 8:46 PM, Richard Henderson wrote: On 10/12/18 10:30 AM, Bastian Koppelmann wrote: +static bool trans_andi(DisasContext *ctx, arg_andi *a, uint32_t insn) +{ +gen_arith_imm(ctx, OPC_RISC_ANDI, a->rd, a->rs1, a->imm); +return true; +} +static bool trans_slli(DisasCo

[Qemu-devel] [PATCH v3 0/8] crypto: improve performance of XTS cipher mode

2018-10-19 Thread Daniel P . Berrangé
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01601.html v2: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg03159.html The XTS cipher mode is significantly slower than CBC mode. This series approximately doubles the XTS performance which will improve the I/O rate for L

[Qemu-devel] [PATCH v3 6/8] crypto: annotate xts_tweak_encdec as inlineable

2018-10-19 Thread Daniel P . Berrangé
Encouraging the compiler to inline xts_tweak_encdec increases the performance for xts-aes-128 when built with gcrypt: Encrypt: 545 MB/s -> 580 MB/s Decrypt: 568 MB/s -> 602 MB/s Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- crypto/xts.c | 10 +- 1 file changed,

[Qemu-devel] [PATCH v3 3/8] crypto: introduce a xts_uint128 data type

2018-10-19 Thread Daniel P . Berrangé
The new type is designed to allow use of 64-bit arithmetic instead of operating 1-byte at a time. The following patches will use this to improve performance. Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- crypto/xts.c | 46 ++ 1 fil

[Qemu-devel] [PATCH v3 5/8] crypto: convert xts_mult_x to use xts_uint128 type

2018-10-19 Thread Daniel P . Berrangé
Using 64-bit arithmetic increases the performance for xts-aes-128 when built with gcrypt: Encrypt: 355 MB/s -> 545 MB/s Decrypt: 362 MB/s -> 568 MB/s Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- crypto/xts.c | 40 1 file changed

[Qemu-devel] [PATCH v3 1/8] crypto: expand algorithm coverage for cipher benchmark

2018-10-19 Thread Daniel P . Berrangé
Add testing coverage for AES with XTS, ECB and CTR modes Reviewed-by: Marc-André Lureau Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- tests/benchmark-crypto-cipher.c | 149 +++- 1 file changed, 126 insertions(+), 23 deletions(-) diff --git a/tes

[Qemu-devel] [PATCH v3 4/8] crypto: convert xts_tweak_encdec to use xts_uint128 type

2018-10-19 Thread Daniel P . Berrangé
Using 64-bit arithmetic increases the performance for xts-aes-128 when built with gcrypt: Encrypt: 272 MB/s -> 355 MB/s Decrypt: 275 MB/s -> 362 MB/s Signed-off-by: Daniel P. Berrangé --- crypto/xts.c | 84 1 file changed, 58 insertions(+

[Qemu-devel] [PATCH v3 8/8] crypto: add testing for unaligned buffers with XTS cipher mode

2018-10-19 Thread Daniel P . Berrangé
Validate that the XTS cipher mode will correctly operate with plain text, cipher text and IV buffers that are not 64-bit aligned. Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- tests/test-crypto-xts.c | 86 + 1 file changed, 86 insertio

[Qemu-devel] [PATCH v3 2/8] crypto: remove code duplication in tweak encrypt/decrypt

2018-10-19 Thread Daniel P . Berrangé
The tweak encrypt/decrypt functions are identical except for the comments, so can be merged. Profiling data shows that the compiler is in fact already merging the two merges in the object files. Reviewed-by: Marc-André Lureau Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- cr

[Qemu-devel] [PATCH v3 7/8] crypto: refactor XTS cipher mode test suite

2018-10-19 Thread Daniel P . Berrangé
The current XTS test overloads two different tests in a single function making the code a little hard to follow. Split it into distinct test cases. Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrangé --- tests/test-crypto-xts.c | 140 +++- 1 file ch

[Qemu-devel] [PATCH 0/2] i386/kvm: add support for Hyper-V Enlightened VMCS

2018-10-19 Thread Vitaly Kuznetsov
Hyper-V Enlightened VMCS feature was merged to KVM, enable it in Qemu. The feature gives us a significant performance boost for Hyper-V on KVM deployments. The first patch of the series is posted for completeness only. Vitaly Kuznetsov (2): linux-headers: update x86: hv_evmcs CPU flag suppor

Re: [Qemu-devel] [PATCH] i386: clarify that the Q35 machine type implements a P35 chipset

2018-10-19 Thread Daniel P . Berrangé
Ping - it has 2 reviews, but never made it into the i386 maintainers tree / pull request. Can someone queue this patch for merge. On Thu, Aug 30, 2018 at 11:57:57AM +0100, Daniel P. Berrangé wrote: > The 'q35' machine type implements an Intel Series 3 chipset, > of which there are several variants

[Qemu-devel] [PATCH 1/2] linux-headers: update

2018-10-19 Thread Vitaly Kuznetsov
Update to kvm/next commit 1e58e5e59148 ("KVM: VMX: enable nested virtualization by default"). kvm_put_vcpu_events() needs to be fixed as 'pad' was renamed to 'pending' in 'struct kvm_vcpu_events' Signed-off-by: Vitaly Kuznetsov --- linux-headers/asm-powerpc/kvm.h | 1 + linux-headers/asm-x86/

Re: [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG

2018-10-19 Thread Laurent Vivier
On 19/10/2018 13:00, Thomas Huth wrote: > The migration test for s390x sometimes hangs when running with TCG, > similar to the problems that we have already observed with TCG for > the ppc64 guests. Thus disable the s390x test when we are not running > with KVM for now until the problem with TCG ha

[Qemu-devel] [PATCH 2/2] x86: hv_evmcs CPU flag support

2018-10-19 Thread Vitaly Kuznetsov
Adds a new CPU flag to enable the Enlightened VMCS KVM feature. QEMU enables KVM_CAP_HYPERV_ENLIGHTENED_VMCS and gets back the version to be advertised in lower 16 bits of CPUID.0x400A:EAX. Suggested-by: Ladi Prosek Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 1 + targ

Re: [Qemu-devel] [PATCH 2/3] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``)

2018-10-19 Thread Alex Bennée
Mao Zhongyi writes: > Various shell files contain a mix between obsolete `` > and modern $(); It would be nice to convert to using $() > everywhere. > > Cc: alex.ben...@linaro.org > Cc: f...@redhat.com > Cc: phi...@redhat.com > > Signed-off-by: Mao Zhongyi Reviewed-by: Alex Bennée Tested-by:

Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list

2018-10-19 Thread Daniel P . Berrangé
Copying Paolo, since this probably falls under the "misc patches" maintainer bucket. On Thu, Aug 23, 2018 at 11:25:02AM +0100, Daniel P. Berrangé wrote: > In some cases the Author: email address in patches submitted to the > list gets mangled such that it says > > John Doe via Qemu-devel >

Re: [Qemu-devel] [PATCH] block: drop moderated sheepdog mailing list from MAINTAINERS file

2018-10-19 Thread Daniel P . Berrangé
Paolo, I think this is a patch for your misc patches queue. On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote: > The sheepdog mailing list is setup to stop and queue messages from > non-subscribers, pending moderator approval. Unfortunately it seems > that the moderation queue is

[Qemu-devel] [PATCH] block: Make more block drivers compile-time configurable

2018-10-19 Thread Markus Armbruster
From: Jeff Cody This adds configure options to control the following block drivers: * Bochs * Cloop * Dmg * Qcow (V1) * Vdi * Vvfat * qed * parallels * sheepdog Each of these defaults to being enabled. Signed-off-by: Jeff Cody Signed-off-by: Markus Armbruster --- Hmm, we got quite a few --e

Re: [Qemu-devel] [PATCH] block: drop moderated sheepdog mailing list from MAINTAINERS file

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 13:25, Daniel P. Berrangé wrote: > Paolo, I think this is a patch for your misc patches queue. It looks to me than this is more block/trivial than the busy misc queue. > > On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote: >> The sheepdog mailing list is setup to s

Re: [Qemu-devel] [PATCH] es1370: more fixes for ADC_FRAMEADR and ADC_FRAMECNT

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 10:46, Thomas Huth wrote: >> > It's in a pull request already, so this is likely too late: But for the > next time, could you maybe rather use a "/* fall through */" comment > instead of a goto? That looks less ugly. Wait, it's not ugly, it's wrong. The label is placed incorrectly.

Re: [Qemu-devel] [PATCH v3 0/3] chardev: Add websocket support

2018-10-19 Thread Stefan Hajnoczi
On Fri, Oct 19, 2018 at 01:34:58AM +0300, Julia Suvorova wrote: > v3: > * Refactoring moved to a separate patch [Daniel] > * "websock" option renamed to "websocket" [Stefan] > * Added documentation [Daniel] > v2: > * Fixed initialization order [Daniel] > * Function arguments ref

Re: [Qemu-devel] [PULL 06/48] target-i386: kvm: do not initialize padding fields

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 11:03, Peter Maydell wrote: > On 18 October 2018 at 21:31, Paolo Bonzini wrote: >> The exception.pad field is going to be renamed to pending in an upcoming >> header file update. Remove the unnecessary initialization; it was >> introduced to please valgrind (commit 7e680753cfa2) but

Re: [Qemu-devel] [PATCH] nvdimm: Add docs hint for Linux driver name

2018-10-19 Thread Stefan Hajnoczi
On Thu, Oct 18, 2018 at 01:13:51PM -0700, Kees Cook wrote: > I spent way too much time trying to figure out why the emulated NVDIMM > was missing under Linux. In an effort to help others who might be looking > for these kinds of things in the future, include a hint. > > Signed-off-by: Kees Cook >

Re: [Qemu-devel] [PULL v2 14/28] target/mips: Increase 'supported ISAs/ASEs' flag holder size

2018-10-19 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On Thu, Oct 18, 2018 at 9:20 PM Aleksandar Markovic wrote: > > From: Philippe Mathieu-Daudé > > Increase the size of insn_flags holder size to 64 bits. This is > needed for future extensions since existing bits are almost all used. > Why did you remove my S-o-b tag...? > Reviewe

Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Thomas Huth
On 2018-10-19 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > > Signed-o

[Qemu-devel] [PULL v3 00/47] Miscellaneous patches for 2018-10-18

2018-10-19 Thread Paolo Bonzini
The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18 13:40:19 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [Qemu-devel] [2 0/2] Linux user for 3.1 patches

2018-10-19 Thread Peter Maydell
On 18 October 2018 at 20:00, Laurent Vivier wrote: > The following changes since commit 77f7c747193662edfadeeb3118d63eed0eac51a6: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-10-17' into staging (2018-10-18 > 13:40:19 +0100) > > are available in the Git reposi

[Qemu-devel] [PULL 01/47] es1370: more fixes for ADC_FRAMEADR and ADC_FRAMECNT

2018-10-19 Thread Paolo Bonzini
They are not consecutive with DAC1_FRAME* and DAC2_FRAME*; Coverity still complains about es1370_read, while es1370_write was fixed in commit cf9270e5220671f49cc238deaf6136669cc07ae1. Fixes: 154c1d1f960c5147a3f8ef00907504112f271cd8 Signed-off-by: Paolo Bonzini --- hw/audio/es1370.c | 10

Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > > Signed-o

Re: [Qemu-devel] [PATCH v5 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 13:04, Daniel P. Berrangé wrote: > On Fri, Oct 19, 2018 at 12:02:57PM +0200, Philippe Mathieu-Daudé wrote: >> On 09/10/2018 15:04, Daniel P. Berrangé wrote: >>> From: "Daniel P. Berrange" >>> >>> Add an authorization backend that talks to PAM to check whether the user >>> identity is

Re: [Qemu-devel] [PATCH v2] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-19 Thread Peter Maydell
On 18 October 2018 at 23:10, Brad Smith wrote: > Use MAP_STACK in qemu_alloc_stack() on OpenBSD. > > Added to -current and will be in our soon to be 6.4 release. > > MAP_STACK Indicate that the mapping is used as a stack. This >flag must be used in combination with MAP_ANON a

Re: [Qemu-devel] [PATCH 2/2] hw: ccid-card-emulated: cleanup resource when realize in error path

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 12:50, Li Qiang wrote: > Signed-off-by: Li Qiang > --- > hw/usb/ccid-card-emulated.c | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c > index b356edb..25976ed 100644 > --- a/hw/u

  1   2   3   4   >