On 16.10.18 15:00, Farhan Ali wrote: > > > On 10/15/2018 11:45 AM, Max Reitz wrote: >>> 082 is failing for me on master (046936ed), and this fixes it. >>> >>> I'm wondering if/why other people are not running into this, as 082 runs >>> with qcow2 and is included on `make check-block`. >>> >>> + Max, >>> >>> FIY, I ran into this while reviewing/testing your Python 3 series. >>> >>> Tested-by: Cleber Rosa<cr...@redhat.com> >> Thanks for CC-ing me, Cleber. >> >> Farhan, I disagree with this fix, as I wrote here: >> >> http://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg01488.html >> >> I don't like the new output, so I think what we should do is change the >> code that produces it. Marc-André seemed to agree, so I just need to >> write a patch (which I didn't get to so far). >> >> Max >> > > Hi Max, > > That is fine with me. The reason I sent this patch out as an RFC was > because I wasn't sure about the fix. So for the time being is it okay > for the test to fail?
I think so, yes. It looks like we've agreed that we want another change (although we haven't agreed on the details yet), so I think it's OK to leave it broken until then. It's definitely interesting to see how many people run the iotests these days. :-) (You're not the only one to send a patch to fix this.) > And if you do submit a patch, would you kindly cc > me as well. I already did: http://lists.nongnu.org/archive/html/qemu-block/2018-10/msg00465.html (Though a v2 is in order.) Max
signature.asc
Description: OpenPGP digital signature
