On Tue, 16 Oct 2018 19:41:28 +0200
Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. 9p-handle.c's handle_parse_opts() does that, and then
> fails without setting an error. Wrong. Its caller crashes when it
> tries to report the er
On 10/8/18 3:19 PM, Dominik Csapak wrote:
when '-no-reboot' is set, it is interesting if the guest was originally
shutdown or reset, so save and return that info
Signed-off-by: Dominik Csapak
---
qapi/run-state.json | 5 -
vl.c| 5 -
2 files changed, 8 insertions(+),
On 16/10/2018 18:40, Emilio G. Cota wrote:
>> +#define SMP_CACHE_BYTES 64
>> +#define cacheline_aligned_in_smp \
>> +__attribute__((__aligned__(SMP_CACHE_BYTES)))
> You could use QEMU_ALIGNED() here.
>
>> +
>> +#define WRITE_ONCE(ptr, val) \
>> +(*((volatile typeof(ptr) *)(&(p
Sorry for the late reply! Omitted this one..
On 10/12/2018 09:26 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/12/2018 03:56 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 06:02 PM, Markus Armbruster wrote:
Fei Li writes:
Currently, when qemu_signal_init() fails it onl
Greg Kurz writes:
> On Tue, 16 Oct 2018 19:41:28 +0200
> Markus Armbruster wrote:
>
>> Calling error_report() in a function that takes an Error ** argument
>> is suspicious. 9p-handle.c's handle_parse_opts() does that, and then
>> fails without setting an error. Wrong. Its caller crashes when
Recent patches from series [PATCH v6] "Fixing record/replay and adding reverse
debugging" introduced new clock type QEMU_CLOCK_VIRTUAL_EXT and replaced
virtual timers in some external subsystems with it.
This resulted in small change to existing behavior, which I consider to be
unacceptable.
Pro
That patch series introduced new virtual clock type for use in external
subsystems. It breaks desired behavior in non-record/replay usage scenarios.
This reverts commit 87f4fe7653baf55b5c2f2753fe6003f473c07342.
This reverts commit 775a412bf83f6bc0c5c02091ee06cf649b34c593.
This reverts commit 9888
Attributes are simple flags, associated with individual timers for their whole
lifetime.
They intended to be used to mark individual timers for special handling by
various qemu features operating at qemu core level.
New/init functions family in timer interface updated and refactored (new
'attrib
Calling error_report() in a function that takes an Error ** argument
is suspicious. save_snapshot() and load_snapshot() do that, and then
fail without setting an error. Wrong. The HMP commands survive this
unscathed, since hmp_handle_error() does nothing when no error has
been set. Callers main
Calling error_report() in a function that takes an Error ** argument
is suspicious. Convert a few that are actually warnings to
warn_report().
While there, split warnings consisting of multiple sentences to
conform to conventions spelled out in warn_report()'s contract, and
improve a rather usele
Removes redundant checkpoints in replay log when there are no expired timers in
timers list, associated with corresponding clock (i.e. no rr events associated
with current clock value).
This also improves performance in rr mode.
Signed-off-by: Artem Pisarenko
---
include/qemu/timer.h | 2 +-
Adds EXTERNAL attribute definition to qemu timers subsystem and assigns it to
virtual clock timers, used in slirp (ICMP IPv6) and ui (key queue).
Virtual clock processing in rr mode reimplemented using this attribute.
Fixes: 87f4fe7653baf55b5c2f2753fe6003f473c07342
Fixes: 775a412bf83f6bc0c5c02091
>From include/qapi/error.h:
* Pass an existing error to the caller with the message modified:
* error_propagate(errp, err);
* error_prepend(errp, "Could not frobnicate '%s': ", name);
Fei Li pointed out that doing error_propagate() first doesn't work
well when @errp is &error_fatal
Calling error_report() in a function that takes an Error ** argument
is suspicious. 9p-handle.c's handle_parse_opts() does that, and then
fails without setting an error. Wrong. Its caller crashes when it
tries to report the error:
$ qemu-system-x86_64 -nodefaults -fsdev id=foo,fsdriver=hand
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_add_fd() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Also change call of cleanup_add_fd(), which can't fail, for
The conversion of "xen-pci-passthrough" to realize() (commit
5a11d0f7549, v2.6.0) neglected to convert the xen_pt_config_init()
error path. If xen_pt_config_init() fails, xen_pt_realize() reports
the error, then returns success without completing its job. I don't
know the exact impact, but it can
Calling error_report() in a function that takes an Error ** argument
is suspicious. net_socket_fd_init() does that, and then fails without
setting an error. Wrong. I didn't analyze how exactly this can
break. A caller that reports the error on failure would crash.
Broken when commit c37f0bb1d0
Calling error_report() or similar in a function that takes an Error **
argument is suspicious. Fix a number of instances that are actually
wrong. Clean up a few more that are merely fragile / bad examples.
v4:
* PATCH 36-37: Unbreak qemu-iotests [Eric]
v3:
* PATCH 27: Drop useless error message
The previous commit changed vfio's warning messages from
vfio warning: DEV-NAME: Could not frobnicate
to
warning: vfio DEV-NAME: Could not frobnicate
To match this change, change error messages from
vfio error: DEV-NAME: On fire
to
vfio DEV-NAME: On fire
Note the loss of "er
Calling error_report() in a function that takes an Error ** argument
is suspicious. device_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe
Add a slight improvement of the Coccinelle semantic patch from commit
007b06578ab, and use it to clean up. It leaves dead Error * variables
behind, cleaned up manually.
Cc: David Gibson
Cc: Alexander Graf
Cc: Eric Blake
Cc: Paolo Bonzini
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Bla
Calling error_report() in a function that takes an Error ** argument
is suspicious. machine_set_property() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Phili
Calling error_report() in a function that takes an Error ** argument
is suspicious. add_channel() does that, and then exit()s. Its caller
main(), via qemu_opts_foreach(), is fine with it, but clean it up
anyway.
Cc: Gerd Hoffmann
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
Calling error_report() in a function that takes an Error ** argument
is suspicious. mon_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mat
Calling error_report() in a function that takes an Error ** argument
is suspicious. smbios_entry_add() does that, and then exit()s. It
also passes &error_fatal to qemu_opts_validate(). Both wrong, but
currently harmless, as its only caller passes &error_fatal. Messed up
in commit 1007a37e208.
main() checks for parse_name() failure even though it can't actually
fail. That's okay. Simplify it to check by passing &error_fatal,
like the other users of qemu_opts_foreach().
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
---
vl.c | 6 ++
1 file changed, 2 insert
Calling error_report() from within a function that takes an Error **
argument is suspicious. drive_new() calls error_report() even though
it can run within drive_init_func(), which takes an Error ** argument.
drive_init_func()'s caller main(), via qemu_opts_foreach(), is fine
with it, but clean it
Signed-off-by: Markus Armbruster
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 22beca29d1..89520d8007 100644
--- a/vl.c
+++ b/vl.c
@@ -4397,7 +4397,7 @@ int main(int argc, char **argv, char **envp)
if (qemu_opts_foreach(qemu_find_opts("drive")
Calling error_report() in a function that takes an Error ** argument
is suspicious. Convert a few that are actually help and such to
error_printf().
Improves output of -chardev help from
qemu-system-x86_64: -chardev help: Available chardev backend types:
serial
...
to
Available
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_numa_node() does that, and then exit()s. It
also passes &error_fatal to machine_set_cpu_numa_node(). Both wrong.
Attempting to configure numa when the machine doesn't support it kills
the VM:
$ qemu-sy
Calling error_report() in a function that takes an Error ** argument
is suspicious. pc.c's pc_machine_set_nvdimm_persistence() does that,
and then exit()s. Wrong. Attempting to set machine property
nvdimm-persistence to a bad value instantly kills the VM:
$ qemu-system-x86_64 -nodefaults -S
When -netdev l2tpv3 fails, it first reports a specific error, then a
generic one, like this:
$ qemu-system-x86_64 -netdev l2tpv3,id=foo,src=,dst=,txsession=1
qemu-system-x86_64: -netdev l2tpv3,id=foo,src=,dst=,txsession=1:
l2tpv3_open : could not resolve src, errno = Name or service not k
If creating (empty) default drives fails, it's a bug. Therefore,
assert() is more appropriate than exit(1).
Cc: Kevin Wolf
Cc: Max Reitz
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
---
vl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --
Calling error_report() from within a function that takes an Error **
argument is suspicious. qemu_fsdev_add() does that, and its caller
fsdev_init_func() then fails without setting an error. Its caller
main(), via qemu_opts_foreach(), is fine with it, but clean it up
anyway.
Cc: Greg Kurz
Signe
From: Fei Li
Signed-off-by: Fei Li
Cc: Gerd Hoffmann
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
---
include/ui/console.h | 2 +-
ui/curses.c | 6 +++---
ui/keymaps.c | 11 ++-
ui/keymaps.h | 2 +-
ui/sdl.c | 6 +++---
Calling error_report() in a function that takes an Error ** argument
is suspicious. tpm_init_tpmdev() does that, and then fails without
setting an error. Its caller main(), via tpm_init() and
qemu_opts_foreach(), is fine with it, but clean it up anyway.
Cc: Stefan Berger
Signed-off-by: Markus A
Calling error_report() in a function that takes an Error ** argument
is suspicious. chardev_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe
bdrv_img_create() takes an Error ** argument and uses it in the
conventional way, except for one place: when qemu_opts_do_parse()
fails, it first reports its error to stderr or the HMP monitor with
error_report_err(), then error_setg()'s a generic error.
When the caller reports that second error s
Convert the warning about dangerous automatic probing of raw images to
warn_report(). Split its text to conform to conventions spelled out
in warn_report()'s contract.
Update expected output of qemu-iotest 109 accordingly. Update
qemu-iotest 099's output filtering to keep filtering out the warni
Calling error_report() in a function that takes an Error ** argument
is suspicious. vnc_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
While there, drop a "Failed to start VNC server: " error me
Calling error_report() in a function that takes an Error ** argument
is suspicious. ioapic_realize() does that, and then exit()s.
Currently mostly harmless, as the device cannot be hot-plugged.
Fixes: 20fd4b7b6d9282fe0cb83601f1821f31bd257458
Cc: Peter Xu
Signed-off-by: Markus Armbruster
Reviewe
The vfio code reports warnings like
error_report(WARN_PREFIX "Could not frobnicate", DEV-NAME);
where WARN_PREFIX is defined so the message comes out as
vfio warning: DEV-NAME: Could not frobnicate
This usage predates the introduction of warn_report() & friends in
commit 97f40301f1d. I
Calling error_report() in a function that takes an Error ** argument
is suspicious. Convert a few that are actually warnings to
warn_report().
While there, split a warning consisting of multiple sentences to
conform to conventions spelled out in warn_report()'s contract.
Cc: Alex Bennée
Cc: Mar
vpc_open() merely prints a warning when it finds a bad header
checksum. Turn that into a hard error.
Cc: Kevin Wolf
Signed-off-by: Markus Armbruster
---
block/vpc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index bf294abfa7..1729c0cb4
Calling error_report() in a function that takes an Error ** argument
is suspicious. user_creatable_add_opts_foreach() does that, and then
fails without setting an error. Its caller main(), via
qemu_opts_foreach(), is fine with it, but clean it up anyway.
Cc: Daniel P. Berrangé
Signed-off-by: Ma
Coalesced pio is base on coalesced mmio and can be used for some port
like rtc port, pci-host config port and so on.
Specially in case of rtc as coalesced pio, some versions of windows guest
access rtc frequently because of rtc as system tick. guest access rtc like
this: write register index to 0x
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_fw_cfg() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lu
Signed-off-by: Peng Hao
---
hw/pci-host/q35.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 02f9576..8ce1e09 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -51,6 +51,10 @@ static void q35_host_realize(DeviceState *dev, Error **errp)
Signed-off-by: Peng Hao
---
hw/pci-host/piix.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0e60834..da73743 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -327,6 +327,10 @@ static void i440fx_pcihost_realize(DeviceState *dev,
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_numa() does that, and then fails without setting
an error. Its caller main(), via qemu_opts_foreach(), is fine with
it, but clean it up anyway.
While there, give parse_numa() internal linkage.
Cc: Eduardo
Signed-off-by: Peng Hao
---
hw/timer/mc146818rtc.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index acee47d..808a212 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -70,6 +70,7 @@ typedef struct RTCState {
I
On Fri 12 Oct 2018 01:55:25 PM CEST, Kevin Wolf wrote:
> To fully change the read-only state of a node, we must not only change
> bs->read_only, but also update bs->open_flags.
>
> Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Berto
While errors in the keyboard layout named with -k are fatal, errors in
included files are reported, but otherwise ignored:
$ cat worst
include bad
include worse
$ ls -l bad worse
ls: cannot access 'bad': No such file or directory
ls: cannot access 'worse': No such file or d
the primary API realization.
Signed-off-by: Peng Hao
Reviewed-by: Eduardo Habkost
---
accel/kvm/kvm-all.c | 56 ---
include/exec/memory.h | 4 ++--
memory.c | 4 ++--
3 files changed, 57 insertions(+), 7 deletions(-)
diff --git a
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_sandbox() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Cc: Eduardo Otubo
Signed-off-by: Markus Armbruster
Review
On Tue, Oct 16, 2018 at 11:42:35PM +0530, Kirti Wankhede wrote:
> - Added vfio_device_migration_info structure to use interact with vendor
> driver.
There is no such thing as a 'vendor driver' in Linux - all drivers ate
treated equal. And I don't see any single driver supporting this yet,
so yo
On Tue, 16 Oct 2018 23:42:34 +0530
Kirti Wankhede wrote:
> Add migration support for VFIO device
I'd love to take a deeper look at this; but sadly, I'm currently low on
spare time, and therefore will only add some general remarks.
>
> This Patch set include patches as below:
> - Define KABI fo
add coalesced_pio's struct and KVM_CAP_COALESCED_PIO header.
Signed-off-by: Peng Hao
---
accel/kvm/kvm-all.c | 4 ++--
linux-headers/linux/kvm.h | 9 -
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index de12f78..29d208d 1
QEMU running with options "-icount,sleep=off -rtc clock=vm" doesn't
execute emulation at maximum possible speed.
Target virtual clock may run faster or slower than realtime clock by N
times, where N value depends on various unrelated conditions (i.e. random
from the user point of view), or possibly
On Tue, 16 Oct 2018 23:42:36 +0530
Kirti Wankhede wrote:
> - Migration function are implemented for VFIO_DEVICE_TYPE_PCI device.
> - Added SaveVMHandlers and implemented all basic functions required for live
> migration.
> - Added VM state change handler to know running or stopped state of VM.
On Wed, Oct 17, 2018 at 02:24:19PM +0600, Artem Pisarenko wrote:
> Attributes are simple flags, associated with individual timers for their
> whole lifetime.
> They intended to be used to mark individual timers for special handling by
> various qemu features operating at qemu core level.
I'm wor
On 17/10/2018 11:12, Stefan Hajnoczi wrote:
>> Attributes are simple flags, associated with individual timers for their
>> whole lifetime.
>> They intended to be used to mark individual timers for special handling by
>> various qemu features operating at qemu core level.
> I'm worried that this s
On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote:
> This patch adds separate device types for each of those virtio
> device flavors:
>
> - virtio-*-pci: the existing multi-purpose device types
> - Configurable using `disable-legacy` and `disable-modern`
> properties
> - Lega
On Tue, Oct 16, 2018 at 01:50:39PM -0400, Cleber Rosa wrote:
> TL;DR
> =
>
> Allow acceptance tests to be run with `make check-acceptance`.
>
> Details
> ===
>
> This introduces a Python virtual environment that will be setup within
> the QEMU build directory, that will contain the exact
On Tue, Oct 16, 2018 at 06:52:36PM +0100, Peter Maydell wrote:
> Taking the address of a field in a packed struct is a bad idea, because
> it might not be actually aligned enough for that pointer type (and
> thus cause a crash on dereference on some host architectures). Newer
> versions of clang wa
This patch adds PKU/OSPKE on Skylake-Server CPU model
Tao Xu (1):
i386: Add PKU/OSPKE on Skylake-Server CPU model
target/i386/cpu.c | 4
1 file changed, 4 insertions(+)
--
2.17.1
As the release document ref below link (page 13):
https://software.intel.com/sites/default/files/managed/c5/15/\
architecture-instruction-set-extensions-programming-reference.pdf
PKU is supported in Skylake Server (Only Server) and later, and
on Intel(R) Xeon(R) Processor Scalable Family. OSPKE i
On Tue, Oct 16, 2018 at 06:09:38PM +0100, Peter Maydell wrote:
> Taking the address of a field in a packed struct is a bad idea, because
> it might not be actually aligned enough for that pointer type (and
> thus cause a crash on dereference on some host architectures). Newer
> versions of clang wa
On Tue, Oct 16, 2018 at 06:25:03PM +0100, Peter Maydell wrote:
> Taking the address of a field in a packed struct is a bad idea, because
> it might not be actually aligned enough for that pointer type (and
> thus cause a crash on dereference on some host architectures). Newer
> versions of clang wa
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> QEMU running with options "-icount,sleep=off -rtc clock=vm" doesn't
> execute emulation at maximum possible speed.
> Target virtual clock may run faster or slower than realtime clock by N
> times, where N value depends on various unrelated condit
On Tue, Oct 16, 2018 at 12:22:32PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> hw/input/pckbd.c | 19 ++-
> hw/input/trace-events | 7 +++
> 2 files changed, 13 insertions(+), 13 deletion
Various shell files contain a mix between obsolete `` and
modern $(); It would be nice to convert to using $()
everywhere.
On https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02920.html
I just replaced `` in scripts dir, so this series is a
thorough cleanup of all obsolete `` in the sour
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Cc: phi...@redhat.com
Cc: peter.mayd...@linaro.org
Cc: th...@redhat.com
Cc: s...@weilnetz.de
Signed-off-by: Mao Zhongyi
---
po/Makefile | 2 +-
1 file changed, 1 insertion(
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Cc: alex.ben...@linaro.org
Cc: f...@redhat.com
Cc: phi...@redhat.com
Signed-off-by: Mao Zhongyi
---
tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++--
1 file changed,
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
`pwd` and `basename $0` are in 231 files under directory
tests/qemu-iotests, so replaced it with the following:
sed -i 's/`pwd`/$(pwd)/g' $(git grep -l "\`pwd\`")
sed -i 's/`
On Tue, Oct 16, 2018 at 06:27:12PM +0300, Roman Bolshakov wrote:
> Hello dear subscribers,
>
> I'm running Linux in QEMU on macOS with hvf accel enabled and having an
> issue that is very similar to the KVM bug in nested KVM environments,
> where KVM is run under another hypervisor:
> https://bugs
On 16/10/2018 19:52, Peter Maydell wrote:
> Taking the address of a field in a packed struct is a bad idea, because
> it might not be actually aligned enough for that pointer type (and
> thus cause a crash on dereference on some host architectures). Newer
> versions of clang warn about this. Avoid
See my last comment in bug report. This kind of modification, even adapted
to changed function name, doesn't solve issue.
I thought long time that it does, but once I catched qemu with a hang. And
of course, I wasn't able to reproduce it. So it just better hides issue.
Take a look at alternative so
On Tue, Oct 16, 2018 at 04:20:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Theoretically possible that we finish the skipping loop with bs = NULL
> and the following code will crash trying to dereference it. Fix that.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> migration/block-d
On 2018-10-17 11:44, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete ``
> and modern $(); It would be nice to convert to using $()
> everywhere.
>
> Cc: phi...@redhat.com
> Cc: peter.mayd...@linaro.org
> Cc: th...@redhat.com
> Cc: s...@weilnetz.de
>
> Signed-off-by: Mao Zh
I am pretty sure that you can create misleading warnings in case you
migrate at the wrong time. (migrate while half the 64k page is inflated,
on the new host the other part is inflated - a warning when switching to
another 64k page).
>>>
>>> Yes we can get bogus warnings across
On Tue, Oct 16, 2018 at 03:01:29PM +0200, Markus Armbruster wrote:
> Anything that pages commonly becomes unusable long before
> allocations fail. Anything that overcommits will send you a (commonly
> lethal) signal instead. Anything that tries handling OOM gracefully,
> and manages to dodge both
Hi Peter,
the following changes since commit dddb37495b844270088e68e3bf30b764d48d863f:
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20181015.0'
into staging (2018-10-15 18:44:04 +0100)
are available in the git repository at:
https://gitlab.com/huth/qemu.git tags/pull-r
From: Philippe Mathieu-Daudé
This probably happened when interpreting the utf8 name as latin1.
Fixes dbbaaff6867 and f4e94dfefb6.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
.mailmap | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.ma
On Tue, Oct 16, 2018 at 03:33:40PM +0200, Igor Mammedov wrote:
> When [2] was fixed it was agreed that adding and calling post_plug()
> callback after device_reset() was low risk approach to hotfix issue
> right before release. So it was merged instead of moving already
> existing plug() callback a
From: Paolo Bonzini
Commit 31d2dda ("build-system: remove per-test GCOV reporting", 2018-06-20)
removed users of the variables, since those uses can be replaced by a simple
overall report produced by gcovr. However, the variables were never removed.
Do it now.
Signed-off-by: Paolo Bonzini
Revi
From: Mao Zhongyi
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
scripts/show-fixed-bugs.sh | 10 +-
1 file changed, 5 insert
Hi Peng,
On 17/10/2018 11:23, Peng Hao wrote:
> Add pvpanic mmio device that is similar to x86's pvpanic device.
>
> Signed-off-by: Peng Hao
> ---
> default-configs/arm-softmmu.mak | 2 +-
> hw/arm/virt.c | 21
> hw/misc/Makefile.objs | 1 +
> hw/misc
From: Eric Blake
GNU make is perfectly happy to use 'check-FOO-y += bar' to
initialize check-FOO-y. (GNU Automake strictly insists that
you cannot use += until after an initial = per variable, but
thankfully we aren't using automake).
As we have had more than one instance where copy-and-paste o
From: Liu Yuan
E-mail to one of block/sheepdog maintainers Mitake Hitoshi bounces
: unknown user: "mitake.hitoshi"
and no current address is known. So just remove it.
Signed-off-by: Liu Yuan
Reviewed-by: Markus Armbruster
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 -
1 file changed, 1
Each device that is instantiatable by the users should be marked with
a category. Since the generic-loader does not fit anywhere else, put
it into the MISC category.
Reviewed-by: Alistair Francis
Reviewed-by: Cornelia Huck
Signed-off-by: Thomas Huth
---
hw/core/generic-loader.c | 1 +
1 file c
From: Marc-André Lureau
This should have been removed as part of commit
692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
configure | 6 --
1 file changed, 6 deletions(-)
Older versions of Clang (before 3.5) and GCC (before 4.1) do not
support the "__attribute__((flatten))" yet. We don't care about
such old versions of GCC anymore, but since Clang 3.4 is still
used in EPEL for RHEL7 / CentOS 7, we should not use this attribute
directly but with a wrapper macro inste
The generic-loader is currently compiled target specific due to one
single "#ifdef TARGET_WORDS_BIGENDIAN" in the file. We have already a
function called target_words_bigendian() for this instead, so we can
put the generic-loader into common-obj to save some compilation time.
Reviewed-by: Philippe
The gen_BUG() function calls already cpu_abort(), which prints the
information to stderr and the log already. So instead of additionally
printing the dc->pc via fprintf() and qemu_log here, too, we can
simply pass this information to cpu_abort() instead.
Reviewed-by: Philippe Mathieu-Daudé
Signed
Hi Cleber,
On 17/10/2018 01:22, Cleber Rosa wrote:
> The host arch name is not always the target arch name, so it's
> necessary to have a mapping.
>
> The configure scripts contains what is the authoritative and failproof
> mapping, but, reusing it is not straightforward, so it's replicated in
>
From: John Arbuckle
Currently the copyright date is set to 2017. Update the date to say
2018.
Signed-off-by: John Arbuckle
Reviewed-by: Stefan Weil
Signed-off-by: Thomas Huth
---
include/qemu-common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu-common.h b
From: Mao Zhongyi
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
scripts/archive-source.sh | 4 ++--
1 file changed, 2 insertions(+),
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Thomas Huth
Signed-off-by: Thomas Huth
---
gdbstub.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdbstub.c b/gdbstub.c
index c8478de..c4e4f9f 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -20,7 +20,6 @@
#include
On 17/10/2018 11:53, Artem Pisarenko wrote:
> See my last comment in bug report. This kind of modification, even
> adapted to changed function name, doesn't solve issue.
> I thought long time that it does, but once I catched qemu with a hang.
> And of course, I wasn't able to reproduce it. So it ju
1 - 100 of 351 matches
Mail list logo
