On Tue, Oct 16, 2018 at 06:52:36PM +0100, Peter Maydell wrote: > Taking the address of a field in a packed struct is a bad idea, because > it might not be actually aligned enough for that pointer type (and > thus cause a crash on dereference on some host architectures). Newer > versions of clang warn about this. Avoid the bug by not using the > "modify in place" byte swapping functions. > > Patch produced with scripts/coccinelle/inplace-byteswaps.cocci. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Automatically generated patch, tested with "make check" only. > > hw/acpi/nvdimm.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
