On 17/10/2018 11:12, Stefan Hajnoczi wrote: >> Attributes are simple flags, associated with individual timers for their >> whole lifetime. >> They intended to be used to mark individual timers for special handling by >> various qemu features operating at qemu core level. > I'm worried that this sentence suggests various parts of QEMU will stash > state in ts->attributes. That's messy and they shouldn't do this. Make > the field private to qemu-timer.c.
Yes, the contents of the fields are private. Are you suggesting a different wording for the commit message or the "QEMU Timer attributes" doc comment, or something more than that? Possibly removing timer_get_attributes altogether? Paolo
signature.asc
Description: OpenPGP digital signature
