Re: [Qemu-devel] [PATCH v2 4/4] hw/pci-host/x86: extend the 64-bit PCI hole relative to the fw-assigned base

2018-09-28 Thread Marcel Apfelbaum
On 9/28/18 12:24 AM, Laszlo Ersek wrote: In commit 9fa99d2519cb ("hw/pci-host: Fix x86 Host Bridges 64bit PCI hole", 2017-11-16), we meant to expose such a 64-bit PCI MMIO aperture in the ACPI DSDT that would be at least as large as the new "pci-hole64-size" property (2GB on i440fx, 32GB on q3

[Qemu-devel] [PATCH] fpu/softfloat: Replace countLeadingZeros32/64 with clz32/64

2018-09-28 Thread Thomas Huth
Our minimum required compiler for compiling QEMU is GCC 4.1 these days, so we can drop the support for compilers which do not provide the __builtin_clz*() functions yet. Since the countLeadingZeros32/64 are then identical to the clz32/64 functions, and we do not have to sync the softloat 2 codebase

Re: [Qemu-devel] [PATCH v2 2/4] tests/bios-tables-test: add 64-bit PCI MMIO aperture round-up test on Q35

2018-09-28 Thread Marcel Apfelbaum
On 9/28/18 12:24 AM, Laszlo Ersek wrote: In commit 9fa99d2519cb ("hw/pci-host: Fix x86 Host Bridges 64bit PCI hole", 2017-11-16), we meant to expose such a 64-bit PCI MMIO aperture in the ACPI DSDT that would be at least as large as the new "pci-hole64-size" property (2GB on i440fx, 32GB on q3

Re: [Qemu-devel] [PATCH v2 1/4] MAINTAINERS: list "tests/acpi-test-data" files in ACPI/SMBIOS section

2018-09-28 Thread Marcel Apfelbaum
On 9/28/18 12:24 AM, Laszlo Ersek wrote: The "tests/acpi-test-data" files are currently not covered by any section in MAINTAINERS, and "scripts/checkpatch.pl" complains when new data files are added. Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Marc

[Qemu-devel] question about usb passthrough migration

2018-09-28 Thread linzhecheng
Hi, Gerd I'm still trying to realize local live-migration with usb passthrough devices for purpose of upgrading qemu. I've made sure that source and target vms will not access host usb devices at the same time. But when I test USB flash disk copying files during live-migration stage, I encounte

Re: [Qemu-devel] [PATCH rebased 2/2] monitor: delay monitor iothread creation

2018-09-28 Thread Wolfgang Bumiller
On Fri, Sep 28, 2018 at 11:18:36AM +0800, Peter Xu wrote: > On Thu, Sep 27, 2018 at 02:35:07PM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > On Thu, Sep 27, 2018 at 10:46:34AM +0200, Markus Armbruster wrote: > > >> Peter Xu writes: > > >> > > >> > On Tue, Sep 25, 2018 at 01:09:

[Qemu-devel] [PATCH v2 1/2] monitor: guard iothread access by mon->use_io_thread

2018-09-28 Thread Wolfgang Bumiller
monitor_resume() and monitor_suspend() both want to "kick" the I/O thread if it is there, but in monitor_suspend() lacked the use_io_thread flag condition. This is required when we later only spawn the thread on first use. Signed-off-by: Wolfgang Bumiller Reviewed-by: Eric Blake Reviewed-by: Pet

[Qemu-devel] [PATCH v2 0/2] delay monitor iothread creation

2018-09-28 Thread Wolfgang Bumiller
The early monitor iothread creation conflicts with the -daemonize option causing crashes at shutdown of a daemonized qemu instance. These patches will delay the creation to when a monitor using it is actually spawned. While the second patch depends on the first one, the first is a consistency clea

[Qemu-devel] [PATCH v2 2/2] monitor: delay monitor iothread creation

2018-09-28 Thread Wolfgang Bumiller
Commit d32749deb615 moved the call to monitor_init_globals() to before os_daemonize(), making it an unsuitable place to spawn the monitor iothread as it won't be inherited over the fork() in os_daemonize(). We now spawn the thread the first time we instantiate a monitor which actually has use_io_t

Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs

2018-09-28 Thread Fam Zheng
On Thu, 09/27 14:48, Peter Maydell wrote: > NB: tested with qemu-system-x86_64 -cpu host -enable-kvm -m 4096 > -device mptsas1068 -drive id=mydisk,if=none,file=harddisk.qcow2 > -device scsi-disk,drive=mydisk > which behaves no differently before or after the patch, though > the guest I have (an x

Re: [Qemu-devel] [PATCH v2 2/2] monitor: delay monitor iothread creation

2018-09-28 Thread Marc-André Lureau
Hi On Fri, Sep 28, 2018 at 12:02 PM Wolfgang Bumiller wrote: > > Commit d32749deb615 moved the call to monitor_init_globals() > to before os_daemonize(), making it an unsuitable place to > spawn the monitor iothread as it won't be inherited over the > fork() in os_daemonize(). > > We now spawn th

[Qemu-devel] [Bug 1794939] [NEW] QEMU does not build with vte v2.91

2018-09-28 Thread Bastian Koppelmann
Public bug reported: when I build qemu with vte support and vte-2.91 installed I get the following deprecation warning: error: ‘vte_terminal_set_encoding’ is deprecated [-Werror=deprecated-declarations] vte_terminal_set_encoding(VTE_TERMINAL(vc->vte.terminal), "UTF-8", NULL); ^

Re: [Qemu-devel] [PATCH v2 3/9] target/arm: Align cortex-r5 id_isar0

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 22:13, Richard Henderson wrote: > The missing nibble made it more difficult to read. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/cpu.c b/t

Re: [Qemu-devel] [PATCH] cpus: fix TCG kick timer leak

2018-09-28 Thread Marc-André Lureau
Hi On Thu, Sep 27, 2018 at 9:17 PM Alex Bennée wrote: > > This is an alternative fix to Marc's original patch as per Paolo's suggestion. > > Reported-by: Marc-André Lureau > Suggested-by: Paolo Bonzini > Signed-off-by: Alex Bennée > --- Reviewed-by: Marc-André Lureau > cpus.c | 5 +++-- > 1

[Qemu-devel] [PATCH] block-backend: Set werror/rerror defaults in blk_new()

2018-09-28 Thread Kevin Wolf
Currently, the default values for werror and rerror have to be set explicitly with blk_set_on_error() by the callers of blk_new(). The only caller actually doing this is blockdev_init(), which is called for BlockBackends created using -drive. In particular, anonymous BlockBackends created with -de

[Qemu-devel] [PATCH] s390x: Fence huge pages prior to 3.1

2018-09-28 Thread Janosch Frank
As the kernel has no way of disallowing the start of a huge page backed VM, we can migrate a running huge backed VM to a host that has no huge page KVM support. Let's glue huge page support support to the 3.1 machine, so we do not migrate to a destination host that doesn't have QEMU huge page supp

Re: [Qemu-devel] [PATCH v12 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-28 Thread Alberto Garcia
On Thu 27 Sep 2018 05:53:34 PM CEST, Eric Blake wrote: > On 9/26/18 11:04 AM, Leonid Bloch wrote: >> The default cache-clean-interval is set to 10 minutes, in order to lower >> the overhead of the qcow2 caches (before the default was 0, i.e. >> disabled). >> >> * For non-Linux platforms the defaul

Re: [Qemu-devel] [PATCH] s390x: Fence huge pages prior to 3.1

2018-09-28 Thread Cornelia Huck
On Fri, 28 Sep 2018 11:34:35 +0200 Janosch Frank wrote: > As the kernel has no way of disallowing the start of a huge page > backed VM, we can migrate a running huge backed VM to a host that has > no huge page KVM support. > > Let's glue huge page support support to the 3.1 machine, so we do not

Re: [Qemu-devel] [PATCH v2 2/2] monitor: delay monitor iothread creation

2018-09-28 Thread Peter Xu
On Fri, Sep 28, 2018 at 01:00:26PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Sep 28, 2018 at 12:02 PM Wolfgang Bumiller > wrote: > > > > Commit d32749deb615 moved the call to monitor_init_globals() > > to before os_daemonize(), making it an unsuitable place to > > spawn the monitor iothrea

Re: [Qemu-devel] question about usb passthrough migration

2018-09-28 Thread gerd hoffmann
On Fri, Sep 28, 2018 at 07:15:50AM +, linzhecheng wrote: > Hi, Gerd > I'm still trying to realize local live-migration with usb passthrough devices > for purpose of upgrading qemu. > I've made sure that source and target vms will not access host usb devices at > the same time. > But when I t

Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 09:15, Fam Zheng wrote: > On Thu, 09/27 14:48, Peter Maydell wrote: >> NB: tested with qemu-system-x86_64 -cpu host -enable-kvm -m 4096 >> -device mptsas1068 -drive id=mydisk,if=none,file=harddisk.qcow2 >> -device scsi-disk,drive=mydisk >> which behaves no differently bef

Re: [Qemu-devel] [PATCH] cpus: fix TCG kick timer leak

2018-09-28 Thread Paolo Bonzini
On 27/09/2018 19:17, Alex Bennée wrote: > This is an alternative fix to Marc's original patch as per Paolo's suggestion. > > Reported-by: Marc-André Lureau > Suggested-by: Paolo Bonzini > Signed-off-by: Alex Bennée > --- > cpus.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs

2018-09-28 Thread Paolo Bonzini
On 27/09/2018 15:48, Peter Maydell wrote: > Taking the address of a field in a packed struct is a bad idea, because > it might not be actually aligned enough for that pointer type (and > thus cause a crash on dereference on some host architectures). Newer > versions of clang warn about this. Avoid

[Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd)

2018-09-28 Thread Sebastian Andrzej Siewior
Intel SDM says for CPUID function 0DH, sub-function 0: | • ECX enumerates the size (in bytes) required by the XSAVE instruction for an | XSAVE area containing all the user state components supported by this | processor. | • EBX enumerates the size (in bytes) required by the XSAVE instruction f

Re: [Qemu-devel] [PATCH v3] intel_iommu: better handling of dmar state switch

2018-09-28 Thread Auger Eric
Hi Peter, On 9/7/18 4:46 AM, Peter Xu wrote: > QEMU is not handling the global DMAR switch well, especially when from > "on" to "off". > > Let's first take the example of system reset. > > Assuming that a guest has IOMMU enabled. When it reboots, we will drop > all the existing DMAR mappings to

Re: [Qemu-devel] [PATCH v12 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-28 Thread Kevin Wolf
Am 28.09.2018 um 05:59 hat Leonid Bloch geschrieben: > > > On September 27, 2018 5:53:34 PM CEST, Eric Blake wrote: > >On 9/26/18 11:04 AM, Leonid Bloch wrote: > >> The default cache-clean-interval is set to 10 minutes, in order to > >lower > >> the overhead of the qcow2 caches (before the defau

[Qemu-devel] [PATCH] tests: Fix signalling race condition in TPM tests

2018-09-28 Thread Stefan Berger
Hi Michael, please apply the below patch to the 2.12 stable tree. It is a backport of commit 2271b75fa9019 from master. For a 3.0 stable branch 'git cherry-pick 2271b75fa9019' should work. Regards, Stefan This patch fixes a race condition and test failure where the main process waits

[Qemu-devel] [Bug 1794950] [NEW] qemu hangs when guest is using linux kernel 4.16+

2018-09-28 Thread Filipe Manana
Public bug reported: I have been using qemu on daily basis 5+ years in order to do btrfs development and testing and it always worked perfectly, until I upgraded the linux kernel of the guests to 4.16. With 4.16+ kernels, when running all the fstests (previously called xfstests), the qemu process

Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs

2018-09-28 Thread Fam Zheng
On Fri, 09/28 11:25, Peter Maydell wrote: > On 28 September 2018 at 09:15, Fam Zheng wrote: > > On Thu, 09/27 14:48, Peter Maydell wrote: > >> NB: tested with qemu-system-x86_64 -cpu host -enable-kvm -m 4096 > >> -device mptsas1068 -drive id=mydisk,if=none,file=harddisk.qcow2 > >> -device scsi-d

Re: [Qemu-devel] [RFC PATCH 0/3] acceptance tests: Test firmware checking debug console output

2018-09-28 Thread Laszlo Ersek
Hi Phil, (+Daniel, +Kashyap) On 09/28/18 02:30, Philippe Mathieu-Daudé wrote: > Hi, > > This RFC series add simple acceptance tests which boot SeaBIOS and > EDK2 on Q35 and virt/aarch64. > > It is more of a proof of concept (to motivate the Avocado team ;) ). > > Regards, > > Phil. > > Philippe M

Re: [Qemu-devel] [PATCH] s390x: Fence huge pages prior to 3.1

2018-09-28 Thread David Hildenbrand
On 28/09/2018 11:34, Janosch Frank wrote: > As the kernel has no way of disallowing the start of a huge page > backed VM, we can migrate a running huge backed VM to a host that has > no huge page KVM support. > > Let's glue huge page support support to the 3.1 machine, so we do not > migrate to a

Re: [Qemu-devel] [PATCH v8 1/6] monitor: Suspend monitor instead dropping commands

2018-09-28 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 10:24 AM Peter Xu wrote: > > When a QMP client sends in-band commands more quickly that we can > process them, we can either queue them without limit (QUEUE), drop > commands when the queue is full (DROP), or suspend receiving commands > when the queue is full (SUSPEND).

Re: [Qemu-devel] [PATCH v8 2/6] monitor: resume the monitor earlier if needed

2018-09-28 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 10:24 AM Peter Xu wrote: > > Currently when QMP request queue full we won't resume the monitor until > we have completely handled the current command. It's not necessary > since even before it's handled the queue is already non-full. Moving > the resume logic earlier b

Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs

2018-09-28 Thread Philippe Mathieu-Daudé
Hi Peter, On 27/09/2018 15:48, Peter Maydell wrote: > Taking the address of a field in a packed struct is a bad idea, because > it might not be actually aligned enough for that pointer type (and > thus cause a crash on dereference on some host architectures). Newer > versions of clang warn about t

Re: [Qemu-devel] [PATCH v8 3/6] monitor: remove "x-oob", turn oob on by default

2018-09-28 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 10:29 AM Peter Xu wrote: > > OOB commands were introduced in commit cf869d53172. Unfortunately, we > ran into a regression, and had to disable them by default for 2.12 > (commit be933ffc23). > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > Th

Re: [Qemu-devel] [PATCH v8 4/6] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-09-28 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 10:26 AM Peter Xu wrote: > > This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. > > Meanwhile, revert one line from fa198ad9bdef to make sure > qtest_init_without_qmp_handshake() will only pass in one parameter. > > Reviewed-by: Markus Armbruster > Signed-off-

Re: [Qemu-devel] [PATCH v4 18/24] qdev: hotplug: provide do_unplug handler

2018-09-28 Thread David Hildenbrand
On 27/09/2018 15:01, Igor Mammedov wrote: > On Wed, 26 Sep 2018 11:42:13 +0200 > David Hildenbrand wrote: > >> The unplug and unplug_request handlers are special: They are not >> executed when unrealizing a device, but rather trigger the removal of a >> device from device_del() via object_unparen

Re: [Qemu-devel] [PATCH v8 5/6] tests: add oob functional test for test-qmp-cmds

2018-09-28 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 10:24 AM Peter Xu wrote: > > Straightforward test just to let the test-qmp-cmds be complete. > > Signed-off-by: Peter Xu Reviewed-by: Marc-André Lureau > --- > tests/test-qmp-cmds.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/tests/test

Re: [Qemu-devel] [PATCH v8 6/6] tests: qmp-test: add queue full test

2018-09-28 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 10:26 AM Peter Xu wrote: > > We'll need to include "monitor/monitor.h" for the queue length macro, > then we don't need to hard code it. > > Suggested-by: Markus Armbruster > Signed-off-by: Peter Xu > --- As said in first patch, I think having the queue length somehow

Re: [Qemu-devel] [PATCH v4 3/9] x86_iommu/amd: remove V=1 check from amdvi_validate_dte()

2018-09-28 Thread Singh, Brijesh
On 9/28/18 12:46 AM, Peter Xu wrote: > On Thu, Sep 27, 2018 at 04:45:55PM +, Singh, Brijesh wrote: >> Currently, the amdvi_validate_dte() assumes that a valid DTE will >> always have V=1. This is not true. The V=1 means that bit[127:1] are >> valid. A valid DTE can have IV=1 and V=0 (i.e addr

Re: [Qemu-devel] [PULL v2 0/5] Linux user for 3.1 patches

2018-09-28 Thread Peter Maydell
On 25 September 2018 at 21:51, Laurent Vivier wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v4 6/9] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

2018-09-28 Thread Singh, Brijesh
On 9/28/18 1:08 AM, Peter Xu wrote: > On Thu, Sep 27, 2018 at 04:45:59PM +, Singh, Brijesh wrote: > > [...] > >> +/* validate that we are configure with intremap=on */ >> +if (!X86_IOMMU_DEVICE(iommu)->intr_supported) { >> +error_report("Interrupt remapping is enabled in the g

Re: [Qemu-devel] [PATCH qemu v2] hw/char/sh_serial: Add timeout handling to unbreak serial input

2018-09-28 Thread Geert Uytterhoeven
Hi Paolo, On Tue, Sep 11, 2018 at 3:11 PM Paolo Bonzini wrote: > On 05/09/2018 15:11, Geert Uytterhoeven wrote: > > As of commit 18e8cf159177100e ("serial: sh-sci: increase RX FIFO trigger > > defaults for (H)SCIF") in Linux v4.11-rc1, the serial console on the > > QEMU SH4 target is broken: it d

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Halil Pasic
On 09/27/2018 02:52 PM, Cornelia Huck wrote: > On Thu, 27 Sep 2018 14:29:01 +0200 > Thomas Huth wrote: > >> On 2018-09-27 00:54, Tony Krowiak wrote: >>> From: Tony Krowiak >>> >>> Introduces the base object model for virtualizing AP devices. >>> >>> Signed-off-by: Tony Krowiak >>> --- > >

Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 13:04, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 27/09/2018 15:48, Peter Maydell wrote: >> Taking the address of a field in a packed struct is a bad idea, because >> it might not be actually aligned enough for that pointer type (and >> thus cause a crash on dereferen

Re: [Qemu-devel] [PATCH v2 4/9] target/arm: Fix cortex-a7 id_isar0

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > The incorrect value advertised only thumb2 div without arm div. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/targe

Re: [Qemu-devel] [PULL 0/5] Block and testing patches

2018-09-28 Thread Peter Maydell
On 26 September 2018 at 03:55, Fam Zheng wrote: > The following changes since commit c5e4e49258e9b89cb34c085a419dd9f862935c48: > > Merge remote-tracking branch 'remotes/xanclic/tags/pull-block-2018-09-25' > into staging (2018-09-25 16:47:35 +0100) > > are available in the Git repository at: > >

[Qemu-devel] [PATCH 01/11] net: etraxfs_eth: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Edgar E. Iglesias Signed-off-by: Cédric Le Goater --- hw/net/etraxfs_eth.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index a6932432b164..64ab3df1ae38 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/net/etraxfs_eth

[Qemu-devel] [PATCH 00/11] net: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Hello, Here is my take to the SysBus init to realize method conversion. I picked the /net directory and did them all. Also added a couple of reset methods in separate patches. make check tested Thanks, C. Cédric Le Goater (11): net: etraxfs_eth: convert SysBus init method to a realize method

[Qemu-devel] [PATCH 02/11] net: etraxfs_eth: add a reset method

2018-09-28 Thread Cédric Le Goater
Cc: Edgar E. Iglesias Signed-off-by: Cédric Le Goater --- hw/net/etraxfs_eth.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index 64ab3df1ae38..552a18c7c730 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/net/etraxfs_eth.c

[Qemu-devel] [PATCH 11/11] net: xgmac: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Rob Herring Signed-off-by: Cédric Le Goater --- hw/net/xgmac.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c index fa001563d3de..63f5a62ebf1b 100644 --- a/hw/net/xgmac.c +++ b/hw/net/xgm

[Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/net/lance.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/lance.c b/hw/net/lance.c index a08d5ac6a848..f987b2fd180f 100644 --- a/hw/net/lance.c +++ b/hw/net/lance.c @@ -97,9 +97,9 @@ static const VMStateDescription vmstat

[Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Max Filippov Signed-off-by: Cédric Le Goater --- hw/net/opencores_eth.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index d42b79c08c6a..d6f54f8d8208 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.

[Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Michael Walle Signed-off-by: Cédric Le Goater --- hw/net/milkymist-minimac2.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c index 3eaa19dfde92..5e7304a26a50 100644 --- a/hw/net/milkymist-minimac2.c +++ b

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Wei Huang
On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@redhat.com) wrote: >> This patch adds migration test support for aarch64. The test code, which >> implements the same functionality as x86, is booted as a kernel in qemu. >> Here are the design choices we make for aarch64:

[Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/net/smc91c111.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index d2fd2040e81c..5a43afc0d3c2 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -766,9 +766,9 @@

[Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/net/lan9118.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c index b9032dac595f..d99c6127b938 100644 --- a/hw/net/lan9118.c +++ b/hw/net/lan9118.c @@ -1320,9 +1320,9 @@ stati

[Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Aleksandar Markovic Signed-off-by: Cédric Le Goater --- hw/net/mipsnet.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c index 5a63df7ccb91..03b310427860 100644 --- a/hw/net/mipsnet.c +++ b/hw/net/mipsnet.c @@ -236,9 +236,9 @@

[Qemu-devel] [PATCH 09/11] net: stellaris_enet: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Cédric Le Goater --- hw/net/stellaris_enet.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 165562d7886a..3ee1e0f8a43f 100644 --- a/hw/net/stellaris_enet.

[Qemu-devel] [PATCH 10/11] net: stellaris_enet: add a reset method

2018-09-28 Thread Cédric Le Goater
Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Cédric Le Goater --- hw/net/stellaris_enet.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 3ee1e0f8a43f..b3375ebb459c 100644 --- a/hw/net/stellaris_enet.c

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Halil Pasic
On 09/27/2018 12:54 AM, Tony Krowiak wrote: > From: Tony Krowiak > > Introduces the base object model for virtualizing AP devices. > [..] > + > +static char *vfio_ap_bus_get_dev_path(DeviceState *dev) Cover letter states you want to remove vifo_ap references form the bus. Sane thing to do

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> This patch adds migration test support for aarch64. The test code, which > >> implements the same functionality as x86, is booted as a kernel in qemu. > >

Re: [Qemu-devel] [PATCH v2 1/9] target/arm: Define fields of ISAR registers

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 80 > 1 file changed, 80 insertions(+) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > index 65c0fa0a65..e1b9270b8c 100644 > --- a/t

Re: [Qemu-devel] [PATCH v3 6/9] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

2018-09-28 Thread Michael S. Tsirkin
On Fri, Sep 28, 2018 at 11:12:37AM +0800, Peter Xu wrote: > On Thu, Sep 27, 2018 at 12:28:42PM +, Singh, Brijesh wrote: > > >> +static bool amdvi_validate_int_remap(AMDVIState *s, uint64_t *dte) > > >> +{ > > >> +/* Check if IR is enabled in DTE */ > > >> +if (!(dte[2] & AMDVI_IR_REMAP_

Re: [Qemu-devel] [PATCH v9 3/6] s390x/kvm: enable AP instruction interpretation for guest

2018-09-28 Thread Tony Krowiak
On 09/27/2018 03:52 AM, David Hildenbrand wrote: On 27/09/2018 00:54, Tony Krowiak wrote: From: Tony Krowiak Let's use the KVM_SET_DEVICE_ATTR ioctl to enable hardware interpretation of AP instructions executed on the guest. If the S390_FEAT_AP feature is switched on for the guest, AP instruct

Re: [Qemu-devel] [PATCH v2 2/9] target/arm: Convert v8 extensions from feature bits to isar tests

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Most of the v8 extensions are self-contained within the ISAR > registers and are not implied by other feature bits, which > makes them the easiest to convert. Lovely! > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Wei Huang
On 09/28/2018 09:04 AM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@redhat.com) wrote: >> >> >> On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: >>> * Wei Huang (w...@redhat.com) wrote: This patch adds migration test support for aarch64. The test code, which implements the s

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 09/28/2018 09:04 AM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> > >> > >> On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: > >>> * Wei Huang (w...@redhat.com) wrote: > This patch adds migration test support f

[Qemu-devel] [PATCH] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

2018-09-28 Thread Peter Maydell
Our __get_user_e() and __put_user_e() macros cause newer versions of clang to generate false-positive -Waddress-of-packed-member warnings if they are passed the address of a member of a packed struct (see https://bugs.llvm.org/show_bug.cgi?id=39113). Suppress these using the _Pragma() operator. To

Re: [Qemu-devel] [PATCH 6/7] qcow2: refactor qcow2_co_pwritev locals scope

2018-09-28 Thread Max Reitz
On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: > Move local variables related to individual loop iteration into while > block. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PULL 00/42] Block patches

2018-09-28 Thread Peter Maydell
On 25 September 2018 at 18:09, Peter Maydell wrote: > On 25 September 2018 at 16:14, Max Reitz wrote: >> The following changes since commit 506e4a00de01e0b29fa83db5cbbc3d154253b4ea: >> >> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-3.1-20180925' >> into staging (2018-09-25 13:30

Re: [Qemu-devel] [PATCH 5/7] qcow2: refactor qcow2_co_pwritev: split out qcow2_co_do_pwritev

2018-09-28 Thread Max Reitz
On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: > Split out block which will be reused in async scheme. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 138 > -- > 1 file changed, 86 insertions(+), 52 deletio

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Halil Pasic
On 09/27/2018 02:29 PM, Thomas Huth wrote: >> +static void vfio_ap_bus_class_init(ObjectClass *klass, void *data) >> +{ >> +BusClass *k = BUS_CLASS(klass); > I think calling the variable "oc" (or something similar) instead of > "klass" is prefered nowadays. > >> +k->get_dev_path = vfio_

Re: [Qemu-devel] [PATCH 7/7] qcow2: async scheme for qcow2_co_pwritev

2018-09-28 Thread Max Reitz
On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: > Start several async requests instead of read chunk by chunk. > > Iotest 026 output is changed, as because of async io error path has > changed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 4

Re: [Qemu-devel] [PATCH] block-backend: Set werror/rerror defaults in blk_new()

2018-09-28 Thread Eric Blake
On 9/28/18 4:18 AM, Kevin Wolf wrote: Currently, the default values for werror and rerror have to be set explicitly with blk_set_on_error() by the callers of blk_new(). The only caller actually doing this is blockdev_init(), which is called for BlockBackends created using -drive. In particular,

Re: [Qemu-devel] [PATCH 09/11] net: stellaris_enet: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater > --- > hw/net/stellaris_enet.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 10/11] net: stellaris_enet: add a reset method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater > --- > hw/net/stellaris_enet.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 11/11] net: xgmac: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Rob Herring > Signed-off-by: Cédric Le Goater > --- > hw/net/xgmac.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/net/smc91c111.c | 22 +- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c > index d2fd2040e81c..5a43afc0d3c2 100644 >

Re: [Qemu-devel] [PATCH 02/11] net: etraxfs_eth: add a reset method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Edgar E. Iglesias > Signed-off-by: Cédric Le Goater > --- > hw/net/etraxfs_eth.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c > index 64ab3df1ae38..552

Re: [Qemu-devel] [PATCH 01/11] net: etraxfs_eth: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Edgar E. Iglesias > Signed-off-by: Cédric Le Goater > --- > hw/net/etraxfs_eth.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/net/lan9118.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c > index b9032dac595f..d99c6127b938 100644 > --

Re: [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/net/lance.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Michael Walle > Signed-off-by: Cédric Le Goater > --- > hw/net/milkymist-minimac2.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c > index 3e

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Tony Krowiak
On 09/28/2018 09:57 AM, Halil Pasic wrote: On 09/27/2018 12:54 AM, Tony Krowiak wrote: From: Tony Krowiak Introduces the base object model for virtualizing AP devices. [..] + +static char *vfio_ap_bus_get_dev_path(DeviceState *dev) Cover letter states you want to remove vifo_ap refere

Re: [Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Aleksandar Markovic > Signed-off-by: Cédric Le Goater > --- > hw/net/mipsnet.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Max Filippov > Signed-off-by: Cédric Le Goater > --- > hw/net/opencores_eth.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

2018-09-28 Thread Laurent Vivier
Le 28/09/2018 à 16:25, Peter Maydell a écrit : > Our __get_user_e() and __put_user_e() macros cause newer versions > of clang to generate false-positive -Waddress-of-packed-member > warnings if they are passed the address of a member of a packed > struct (see https://bugs.llvm.org/show_bug.cgi?id=3

Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd)

2018-09-28 Thread Eduardo Habkost
On Fri, Sep 28, 2018 at 12:43:19PM +0200, Sebastian Andrzej Siewior wrote: > Intel SDM says for CPUID function 0DH, sub-function 0: > > | • ECX enumerates the size (in bytes) required by the XSAVE instruction for > an > | XSAVE area containing all the user state components supported by this > |

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Cornelia Huck
On Fri, 28 Sep 2018 16:22:12 +0200 Halil Pasic wrote: > On 09/27/2018 02:29 PM, Thomas Huth wrote: > >> +static void vfio_ap_bus_class_init(ObjectClass *klass, void *data) > >> +{ > >> +BusClass *k = BUS_CLASS(klass); > > I think calling the variable "oc" (or something similar) instead of >

Re: [Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
On 9/28/18 4:45 PM, Peter Maydell wrote: > On 28 September 2018 at 14:50, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >> hw/net/smc91c111.c | 22 +- >> 1 file changed, 9 insertions(+), 13 deletions(-) >> >> diff --git a/hw/net/smc91c111.c b/hw/net/smc91c

Re: [Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Cc: Aleksandar Markovic > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/mipsnet.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c > index

Re: [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/lance.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/lance.c b/hw/net/lance.c > index a08d5ac6a848..f987b2fd180f 100644

Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Cc: Michael Walle > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/milkymist-minimac2.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/milkymist-minimac2.c b/hw/net/mi

Re: [Qemu-devel] [PATCH 09/11] net: stellaris_enet: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/stellaris_enet.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/stellaris_e

Re: [Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
On 9/28/18 4:48 PM, Peter Maydell wrote: > On 28 September 2018 at 14:49, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >> hw/net/lan9118.c | 24 ++-- >> 1 file changed, 10 insertions(+), 14 deletions(-) >> >> diff --git a/hw/net/lan9118.c b/hw/net/lan9118

Re: [Qemu-devel] [PATCH v5 2/8] target/mips: Support R5900 specific three-operand MULT and MULTU

2018-09-28 Thread Fredrik Noring
Hi Philippe, > Can you copy/paste some info regarding those instructions from the ISA > here, to note how they differ? ... Yes. Other corresponding functions typically do not seem to have such ISA notes, but I can certainly write one for it. > Since we have acc = 0 we can directly use cpu_LO[0]

Re: [Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Cc: Max Filippov > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/opencores_eth.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.

Re: [Qemu-devel] [PATCH 10/11] net: stellaris_enet: add a reset method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/stellaris_enet.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/net/stellaris_en

Re: [Qemu-devel] [PATCH] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

2018-09-28 Thread Liam Merwick
On 28/09/18 15:25, Peter Maydell wrote: Our __get_user_e() and __put_user_e() macros cause newer versions of clang to generate false-positive -Waddress-of-packed-member warnings if they are passed the address of a member of a packed struct (see https://bugs.llvm.org/show_bug.cgi?id=39113). Supp

  1   2   >