Public bug reported:
Below is the full Qemu command used to launch the VM. Have been using
this same setup since Qemu 2.12, plus a couple of cherry picked patch
commits fixing ide-hd and e1000e in Windows guests. Both sets of patches
have now been merged to 3.0, so decided to update to 3.0.
The V
On 14/09/2018 02:38, Liran Alon wrote:
> Kernel commit 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE")
> introduced new IOCTLs to extract and restore KVM internal state used to
> run a VM that is in VMX operation.
>
> Utilize these IOCTLs to add support of migration of VMs which are
> r
Post separatedly from the OpenBSD series for some more focus since the rest are
already queued.
Fam Zheng (2):
slirp: Add sanity check for str option length
slirp: Implement RFC2132 TFTP server name
net/slirp.c | 21 +++--
qapi/net.json| 5 -
qemu-options.hx |
When user provides a long domainname or hostname that doesn't fit in the
DHCP packet, we mustn't overflow the response packet buffer. Instead,
report errors, following the g_warning() in the slirp->vdnssearch
branch.
Also check the strlen against 256 when initializing slirp, which limit
is also fr
This new usernet option can be used to add data for option 66 (tftp
server name) in the BOOTP reply, which is useful in PXE based automatic
OS install such as OpenBSD.
Signed-off-by: Fam Zheng
Reviewed-by: Thomas Huth
Tested-by: Gerd Hoffmann
---
net/slirp.c | 12 ++--
qapi/net.js
> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru]
> > From: John Snow [mailto:js...@redhat.com]
> > On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote:
> > > This patch makes IDE trim BH deterministic, because it affects
> > > the device state. Therefore its invocation should be replayed
> > > instead
On Thu, 09/13 18:59, Kevin Wolf wrote:
> Am 13.09.2018 um 17:10 hat Paolo Bonzini geschrieben:
> > On 13/09/2018 14:52, Kevin Wolf wrote:
> > > + if (qemu_get_current_aio_context() == qemu_get_aio_context()) {
> > > + /* If we are in the main thread, the callback is allowed to unref
> > > + * the B
This enables the correct generation of bootdevice fw paths for in-built IDE
and virtio-pci-blk devices suitable for OpenBIOS.
Note we also set the MachineClass ignore_boot_device_suffixes property to true
to allow the correct customisation of the disk node names as required.
Signed-off-by: Mark C
-sparc.for-upstream-20180914
for you to fetch changes up to 0a1d5c4596b2fcd3accfe2556e7fade8787ce6b6:
sun4u: implement custom FWPathProvider (2018-09-14 09:18:11 +0100)
qemu-sparc.for-upst
Set the fw_name property to "pci" and also set an explicit OFW address
using the value of the special_base property.
Signed-off-by: Mark Cave-Ayland
---
hw/pci-host/sabre.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index e2f4ee480
Le 09/13/2018 à 07:29 PM, Andrew Baumann a écrit :
Does this crash always happen at startup? Is it deterministic?
Hi Andrew,
Thanks for your reactivity! Yes it crashes all the time..
c135 is STATUS_DLL_NOT_FOUND. I suspect ntdll is trying to demand-load
another DLL to provide that
The function qcow2_get_cluster_type() is in /block/qcow2.h
It will return the flage based on the entry.
There're some flags confused me.
What's difference between QCOW2_CLUSTER_ZERO_ALLOC &
QCOW2_CLUSTER_ZERO_PLAIN
in there?
On Thu, Sep 13, 2018 at 5:30 PM Mark Cave-Ayland
wrote:
>
> On 13/09/18 15:21, Artyom Tarasenko wrote:
>
> > On Sat, Sep 8, 2018 at 11:11 AM Mark Cave-Ayland
> > wrote:
> >>
> >> Whilst the PReP specification describes how all PCI IRQs are routed via IRQ
> >> 15 on the interrupt controller, the r
>On 14/09/2018 09:16, Paolo Bonzini wrote:
>Heh, I was going to send a similar patch. However, things are a bit
>more complex for two reason.
>
>First, I'd prefer to reuse the hflags and hflags2 fields that we already
>have, and only store the VMCS blob in the subsection. For example,
>HF_SVMI_MA
The sslverify setting is supposed to turn off all TLS certificate
checks in libcurl. However because of the way we use it, it only
turns off peer certificate authenticity checks
(CURLOPT_SSL_VERIFYPEER). This patch makes it also turn off the check
that the server name in the certificate is the sa
Windows guests have trouble dealing with usb devices having identical
serial numbers. So, assign unique serial numbers to usb hid devices.
All other usb devices have this already.
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-hid.c | 24 +---
1 file changed, 13 insertions(+),
Yes I could, but it rebuilds too long. I will report results later, when
find broke commit.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1792193
Title:
AMD Athlon(tm) X2 Dual-Core QL-64 bug
Statu
* Gerd Hoffmann (kra...@redhat.com) wrote:
> Windows guests have trouble dealing with usb devices having identical
> serial numbers. So, assign unique serial numbers to usb hid devices.
> All other usb devices have this already.
>
> Signed-off-by: Gerd Hoffmann
OK, so that's part of https://bug
> > +[STR_SERIAL_MOUSE] = "89126",
> > +[STR_SERIAL_TABLET]= "28754",
> > +[STR_SERIAL_KEYBOARD] = "68284",
>
> Is there any significance to the magical numbers?
No, other than that the three device types should have different ones.
> Will this change trigger a serial number
Windows guests have trouble dealing with usb devices having identical
serial numbers. So, assign unique serial numbers to usb hid devices.
All other usb devices have this already.
Signed-off-by: Gerd Hoffmann
---
include/hw/compat.h | 14 +-
hw/usb/dev-hid.c| 24 +---
Hi,
> > Also libvirt manages hotpluggability per device *class*, not per device
> > *instance*. So a device being hotpluggable or not depending on some
> > device property is a problem for libvirt ...
> >
> > I'm open to suggestions how to handle this better, as long as the
> > libvirt people
Hi,
> +* --pidfile=PATH
> +
> +Write the process id (PID) to the given file PATH. This is mostly
> +useful if the backend daemonize/fork itself.
Is there any reason to daemonize itself?
If not: shoud we disallow it and drop the --pidfile switch?
If yes: should we add a --daemonize switch then
* Gerd Hoffmann (kra...@redhat.com) wrote:
> > > +[STR_SERIAL_MOUSE] = "89126",
> > > +[STR_SERIAL_TABLET]= "28754",
> > > +[STR_SERIAL_KEYBOARD] = "68284",
> >
> > Is there any significance to the magical numbers?
>
> No, other than that the three device types should have di
On 14/09/2018 11:54, Liran Alon wrote:
>> On 14/09/2018 09:16, Paolo Bonzini wrote:
>> Heh, I was going to send a similar patch. However, things are a bit
>> more complex for two reason.
>>
>> First, I'd prefer to reuse the hflags and hflags2 fields that we already
>> have, and only store the VMCS
Ok finally got it,
The SRWL API seems to be available since Vista and Server 2008
except the 'TryAcquireSRWLockExclusive' function which is
available starting Seven and Server 2008 *R2*. Hence the error
message.
So basically that means QEMU is not compatible with version older
than Seven or 2008
It is broken since Xen 4.9 [1] and it will not build in Xen 4.12. Also,
it is not built by default since QEMU 2.6.
[1] https://lists.xenproject.org/archives/html/xen-devel/2018-09/msg00313.html
Signed-off-by: Anthony PERARD
---
configure | 17 --
hw/xenpv/Makefile.objs |
See first patch description.
Anthony PERARD (2):
Remove broken Xen PV domain builder
xen: Replace few mentions of xend by libxl
configure | 17 --
hw/xenpv/Makefile.objs | 2 -
hw/xenpv/xen_domainbuild.c | 299
hw/xenpv/xen_doma
xend have been replaced by libxenlight (libxl) for many Xen releases
now.
Signed-off-by: Anthony PERARD
---
hw/xenpv/xen_machine_pv.c | 2 +-
include/hw/xen/xen.h | 2 +-
qemu-options.hx | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xenpv/xen_machine_
* Gerd Hoffmann (kra...@redhat.com) wrote:
> Windows guests have trouble dealing with usb devices having identical
> serial numbers. So, assign unique serial numbers to usb hid devices.
> All other usb devices have this already.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/hw/compat.h | 14
>
> > Hi Luiz,
> >
> > Thanks for the review.
> >
> > >
> > > > This patch adds virtio-pmem driver for KVM guest.
> > > >
> > > > Guest reads the persistent memory range information from
> > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also
> > > > creates a nd_region object wit
ping
> -Original Message-
> From: liujunjie (A)
> Sent: Saturday, September 08, 2018 9:05 PM
> To: m...@redhat.com; jasow...@redhat.com
> Cc: wangxin (U) ; Zhoujian (jay)
> ; Gonglei (Arei) ;
> Huangweidong (C) ; qemu-devel@nongnu.org;
> liujunjie (A)
> Subject: [PATCH] clean up callback
Hi
On Fri, Sep 14, 2018 at 2:55 PM, Gerd Hoffmann wrote:
> Hi,
>
>> +* --pidfile=PATH
>> +
>> +Write the process id (PID) to the given file PATH. This is mostly
>> +useful if the backend daemonize/fork itself.
>
> Is there any reason to daemonize itself?
>
> If not: shoud we disallow it and dro
On 2018年09月08日 21:04, liujunjie wrote:
Before, we did not clear callback like handle_output when delete
the virtqueue which may result be segmentfault.
The scene is as follows:
1. Start a vm with multiqueue vhost-net,
2. then we write VIRTIO_PCI_GUEST_FEATURES in PCI configuration to
triger mu
Hi,
> OK, so now I've found the bit about the magic 42; commit 7b074a22 of
> yours; recommended checking for 42 for knowing we had autosuspend;
> what's actually in the current fedora hid rules is serial!=1 - I wonder
> what others have.
Whatever upstream systemd/udev has I guess ...
A bit of
From: Marc-André Lureau
Remove -sandbox option if the host is not capable of TSYNC, since the
sandbox will fail at setup time otherwise. This will help libvirt, for
ex, to figure out if -sandbox will work.
Signed-off-by: Marc-André Lureau
Acked-by: Eduardo Otubo
---
qemu-seccomp.c | 19 ++
ll-seccomp-20180914
for you to fetch changes up to d3228ed3829981047138bbaff332026f9d64f337:
seccomp: check TSYNC host capability (2018-09-14 15:01:55 +0200)
pull-seccom
On 09/13/2018 02:24 PM, Halil Pasic wrote:
On 09/13/2018 07:15 PM, Tony Krowiak wrote:
On 09/13/2018 01:02 PM, Tony Krowiak wrote:
On 09/13/2018 02:29 AM, Christian Borntraeger wrote:
On 09/13/2018 07:48 AM, Thomas Huth wrote:
On 2018-09-12 22:08, Tony Krowiak wrote:
From: Tony Krowiak
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Friday, September 14, 2018 8:45 PM
> To: liujunjie (A) ; m...@redhat.com
> Cc: Huangweidong (C) ; wangxin (U)
> ; qemu-devel@nongnu.org; Gonglei (Arei)
> ; Zhoujian (jay)
> Subject: Re: [Qemu-devel] [PATCH] clea
As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
review, let's define a common set of backend conventions to help with
management layer implementation, and interoperability.
v2:
- drop --pidfile
- add some notes about daemonizing & stdin/out/err
Cc: libvir-l...@redhat.com
Cc: G
On 09/14/2018 01:48 AM, Pavel Dovgalyuk wrote:
>> From: John Snow [mailto:js...@redhat.com]
>> On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote:
>>> This patch makes IDE trim BH deterministic, because it affects
>>> the device state. Therefore its invocation should be replayed
>>> instead of runnin
On 9/13/18 7:58 PM, Zhang Chen wrote:
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Should both of these last two S-o-b be present?
Maybe it will be more convenient to contact me, I use both of the email. :)
I can't tell you it's wrong, only that it
11.09.2018 22:45, John Snow wrote:
On 07/06/2018 07:36 AM, Vladimir Sementsov-Ogievskiy wrote:
New action is like clean action: do the whole thing in .prepare and
undo in .abort. This behavior for bitmap-changing actions is needed
because backup job actions use bitmap in .prepare.
Signed-off-b
On 09/14/2018 03:27 AM, Pavel Dovgalyuk wrote:
>> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru]
>>> From: John Snow [mailto:js...@redhat.com]
>>> On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote:
This patch makes IDE trim BH deterministic, because it affects
the device state. Therefor
On Fri, Sep 14, 2018 at 12:50:09PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > Also libvirt manages hotpluggability per device *class*, not per device
> > > *instance*. So a device being hotpluggable or not depending on some
> > > device property is a problem for libvirt ...
> > >
> > > I'm open t
On 9/13/18 10:58 PM, lampahome wrote:
In general case, what's difference between internal and external snapshot?
You may find my KVM forum presentation from 2015 useful:
http://events17.linuxfoundation.org/sites/events/files/slides/2015-qcow2-expanded.pdf
Internal snapshots use reference count
> On 14 Sep 2018, at 13:59, Paolo Bonzini wrote:
>
> On 14/09/2018 11:54, Liran Alon wrote:
>>> On 14/09/2018 09:16, Paolo Bonzini wrote:
>>> Heh, I was going to send a similar patch. However, things are a bit
>>> more complex for two reason.
>>>
>>> First, I'd prefer to reuse the hflags and
On Thu, 13 Sep 2018 14:20:25 +0200
Igor Mammedov wrote:
> On Wed, 29 Aug 2018 17:36:09 +0200
> David Hildenbrand wrote:
>
> > To factor out plugging and unplugging of memory device we need access to
> > the memory region. So let's replace get_region_size() by
> > get_memory_region().
this part
* Gerd Hoffmann (kra...@redhat.com) wrote:
> Hi,
>
> > OK, so now I've found the bit about the magic 42; commit 7b074a22 of
> > yours; recommended checking for 42 for knowing we had autosuspend;
> > what's actually in the current fedora hid rules is serial!=1 - I wonder
> > what others have.
>
On 9/13/18 9:19 PM, lampahome wrote:
Sorry, I need to explain what case I want to do
Todo: I want to *backup a block device into qcow2 format image.*
I met a problem which is the *file size limit of filesystem* ex: Max is
16TB for any file in ext4, but the block device maybe 32TB or more.
I fig
On 9/14/18 1:05 AM, Fam Zheng wrote:
On Fri, 09/14 12:23, lampahome wrote:
Can I convert from internap snapshot to external snapshot?
If there's 3 snapshots in one qcow2, can I convert them all to external
snapshots?
Qcow2 doesn't track internal snapshot dependencies like external snapshot, so
On 9/14/18 3:35 AM, lampahome wrote:
The function qcow2_get_cluster_type() is in /block/qcow2.h
It will return the flage based on the entry.
There're some flags confused me.
What's difference between QCOW2_CLUSTER_ZERO_ALLOC &
QCOW2_CLUSTER_ZERO_PLAIN
in there?
Look at docs/interop/qcow2.txt a
On 14/09/2018 16:31, Liran Alon wrote:
>> There is still a problem, however, in that the same input stream would
>> be parsed differently depending on the kernel version. In particular,
>> if in the future the maximum nested state size grows, you break all
>> existing save files.
>
> I’m not sure
On 14/09/2018 07:11, Li Qiang wrote:
> Just as other devices do.
>
> Signed-off-by: Li Qiang
> ---
> hw/misc/edu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index df26a4d046..0687ffd343 100644
> --- a/hw/misc/edu.c
> +++ b/hw/m
On 13/09/2018 18:59, Kevin Wolf wrote:
> Am 13.09.2018 um 17:10 hat Paolo Bonzini geschrieben:
>> On 13/09/2018 14:52, Kevin Wolf wrote:
>>> + if (qemu_get_current_aio_context() == qemu_get_aio_context()) {
>>> + /* If we are in the main thread, the callback is allowed to unref
>>> + * the BlockBac
On 13/09/2018 19:21, Kevin Wolf wrote:
> Am 13.09.2018 um 17:11 hat Paolo Bonzini geschrieben:
>> On 13/09/2018 14:52, Kevin Wolf wrote:
>>> Even if AIO_WAIT_WHILE() is called in the home context of the
>>> AioContext, we still want to allow the condition to change depending on
>>> other threads as
Add backup parameter to bdrv_merge_dirty_bitmap() to be used then with
bdrv_restore_dirty_bitmap() if it needed to restore the bitmap after
merge operation.
This is needed to implement bitmap merge transaction action in further
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/blo
Use more generic names to reuse the function for bitmap merge in the
following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block_int.h | 2 +-
block/dirty-bitmap.c | 4 ++--
blockdev.c| 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --
Rename block-dirty-bitmap-clear transaction handlers to reuse them for
x-block-dirty-bitmap-merge transaction in the following patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
---
blockdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/blo
Move checks from qmp_x_block_dirty_bitmap_merge() to
bdrv_merge_dirty_bitmap(), to share them with dirty bitmap merge
transaction action in future commit.
Note: for now, only qmp_x_block_dirty_bitmap_merge() calls
bdrv_merge_dirty_bitmap().
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by
This is a last brick, necessary to play with nbd bitmap export in
conjunction with image fleecing.
v3:
01: fix type in commit message, add John's r-b
02: splitted refactoring
03: improve commit message, split some refactoring to 02
04: add John's r-b
05: drop extra state variable, make it local in
New action is like clean action: do the whole thing in .prepare and
undo in .abort. This behavior for bitmap-changing actions is needed
because backup job actions use bitmap in .prepare.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
---
qapi/transaction.json | 2 ++
blockd
On Fri, 14 Sep 2018 16:19:07 +0200
Erik Skultety wrote:
> On Fri, Sep 14, 2018 at 12:50:09PM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > > > Also libvirt manages hotpluggability per device *class*, not per device
> > > > *instance*. So a device being hotpluggable or not depending on some
> >
On 29/08/2018 14:41, Viktor Prutyanov wrote:
> elf2dmp is a converter from ELF dump (produced by 'dump-guest-memory') to
> Windows MEMORY.DMP format (also know as 'Complete Memory Dump') which can be
> opened in WinDbg.
>
> This tool can help if VMCoreInfo device/driver is absent in Windows VM and
On 14/09/2018 16:00, John Snow wrote:
>> Maybe not. We can hardly analyze all peripheral devices code and fix all the
>> calls.
>> But I think we can improve that patch and at least look through ide core to
>> fix other calls.
>>
>> Pavel Dovgalyuk
>>
> It just seems odd that if you're working on
On Fri, 14 Sep 2018, Anthony PERARD wrote:
> It is broken since Xen 4.9 [1] and it will not build in Xen 4.12. Also,
> it is not built by default since QEMU 2.6.
>
> [1] https://lists.xenproject.org/archives/html/xen-devel/2018-09/msg00313.html
>
> Signed-off-by: Anthony PERARD
Acked-by: Stefan
On Fri, 14 Sep 2018, Anthony PERARD wrote:
> xend have been replaced by libxenlight (libxl) for many Xen releases
> now.
>
> Signed-off-by: Anthony PERARD
Acked-by: Stefano Stabellini
> ---
> hw/xenpv/xen_machine_pv.c | 2 +-
> include/hw/xen/xen.h | 2 +-
> qemu-options.hx |
On 14 September 2018 at 16:19, Paolo Bonzini wrote:
> On 14/09/2018 16:00, John Snow wrote:
>>> Maybe not. We can hardly analyze all peripheral devices code and fix all
>>> the calls.
>>> But I think we can improve that patch and at least look through ide core to
>>> fix other calls.
>>>
>>> Pav
To clarify, are the problematic USB passthrough devices these:
-device usb-host,vendorid=0x04d9,productid=0x0171 \
-device usb-host,vendorid=0x1532,productid=0x005c \
-device usb-host,vendorid=0x1b1c,productid=0x0c09
or this:
-device vfio-pci,host=04:00.0 \
Without knowing what the vfio-pci dev
20.06.2018 21:09, Eric Blake wrote:
On 06/20/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote:
20.06.2018 19:27, Eric Blake wrote:
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote:
Handle new NBD meta namespace: "qemu", and corresponding queries:
"qemu:dirty-bitmap:".
With new meta
Am 13.09.2018 um 22:55 hat Max Reitz geschrieben:
> On 13.09.18 14:52, Kevin Wolf wrote:
> > When starting an active commit job, other callbacks can run before
> > mirror_start_job() calls bdrv_ref() where needed and cause the nodes to
> > go away. Add another pair of bdrv_ref/unref() around it to
bitmap_to_extents function is broken: it switches dirty variable after
every iteration, however it can process only part of dirty (or zero)
area during one iteration in case when this area is too large for one
extent.
Fortunately, the bug don't produce wrong extents: it just inserts
zero-length ex
Thanks for digging into this Fred, and sorry -- it seems Andrey and I both
missed that subtlety with TryAcquireSRWLockExclusive when we first made this
change.
On the other hand, since these OSes are a decade old (mainstream support ended;
will drop out of extended support in just over a year
From: "Dr. David Alan Gilbert"
Clear have_listen_thread when we exit the thread.
The fallout from this was that various things thought there was
an ongoing postcopy after the postcopy had finished.
The case that failed was postcopy->savevm->loadvm.
This corresponds to RH bug https://bugzilla.re
From: "Dr. David Alan Gilbert"
This is a pair of related migration fixes for cases where the loadvm
state doesn't get cleaned up.
In the first case this is because the code hasn't cleared the postcopy
flag, and so a following loadvm gets very confused (leading to it
not cleaning up the loadvm st
From: "Dr. David Alan Gilbert"
There's a couple of error paths in qemu_loadvm_state
which happen early on but after we've initialised the
load state; that needs to be cleaned up otherwise
we can hit asserts if the state gets reinitialised later.
Signed-off-by: Dr. David Alan Gilbert
---
migrat
Am 14.09.2018 um 17:12 hat Paolo Bonzini geschrieben:
> On 13/09/2018 18:59, Kevin Wolf wrote:
> > Am 13.09.2018 um 17:10 hat Paolo Bonzini geschrieben:
> >> On 13/09/2018 14:52, Kevin Wolf wrote:
> >>> + if (qemu_get_current_aio_context() == qemu_get_aio_context()) {
> >>> + /* If we are in the ma
On 09/14/2018 11:15 AM, Vladimir Sementsov-Ogievskiy wrote:
> This is a last brick, necessary to play with nbd bitmap export in
> conjunction with image fleecing.
>
> v3:
> 01: fix type in commit message, add John's r-b
> 02: splitted refactoring
> 03: improve commit message, split some refacto
On 9/14/18 11:51 AM, Vladimir Sementsov-Ogievskiy wrote:
bitmap_to_extents function is broken: it switches dirty variable after
every iteration, however it can process only part of dirty (or zero)
area during one iteration in case when this area is too large for one
extent.
Fortunately, the bug
14.09.2018 20:24, Eric Blake wrote:
On 9/14/18 11:51 AM, Vladimir Sementsov-Ogievskiy wrote:
bitmap_to_extents function is broken: it switches dirty variable after
every iteration, however it can process only part of dirty (or zero)
area during one iteration in case when this area is too large f
On 9/14/18 12:30 PM, Vladimir Sementsov-Ogievskiy wrote:
while (begin < overall_end && i < nb_extents) {
+ bool next_dirty = !dirty;
+
if (dirty) {
end = bdrv_dirty_bitmap_next_zero(bitmap, begin);
} else {
@@ -1962,6 +1964,7 @@ static unsigned int
I did a git-bisect between 4.14.18(bad) and 4.14.10(good).
Unsurprisingly, this is the first "bad" commit:
KVM/VMX: Allow direct access to MSR_IA32_SPEC_CTRL
commit d28b387fb74da95d69d2615732f50cceb38e9a4d
George
--
You received this bug notification because you are a member of qemu-
deve
On 09/14/2018 11:15 AM, Vladimir Sementsov-Ogievskiy wrote:
> This is a last brick, necessary to play with nbd bitmap export in
> conjunction with image fleecing.
>
> v3:
> 01: fix type in commit message, add John's r-b
> 02: splitted refactoring
> 03: improve commit message, split some refacto
14.09.2018 20:30, Vladimir Sementsov-Ogievskiy wrote:
14.09.2018 20:24, Eric Blake wrote:
On 9/14/18 11:51 AM, Vladimir Sementsov-Ogievskiy wrote:
bitmap_to_extents function is broken: it switches dirty variable after
every iteration, however it can process only part of dirty (or zero)
area dur
On 14/09/2018 19:14, Kevin Wolf wrote:
>> As you mention, you could have a nested aio_poll() in the main thread,
>> for example invoked from a bottom half, but in that case I'd rather
>> track the caller that is creating the bottom half and see if it lacks a
>> bdrv_ref/bdrv_unref (or perhaps it's
On 14/09/2018 18:54, Andrew Baumann wrote:
> On the other hand, since these OSes are a decade old (mainstream support
> ended; will drop out of extended support in just over a year from now),
> and you are the first person to report a problem in 1.5 years since the
> patch went in, I wonder if we c
On 09/10/2018 01:00 PM, Vladimir Sementsov-Ogievskiy wrote:
> 10.09.2018 19:55, Eric Blake wrote:
>> On 9/10/18 11:49 AM, Vladimir Sementsov-Ogievskiy wrote:
>>
> -int64_t hbitmap_next_zero(const HBitmap *hb, uint64_t start);
> +int64_t hbitmap_next_zero(const HBitmap *hb, uint64_t start
14.09.2018 20:35, Eric Blake wrote:
On 9/14/18 12:30 PM, Vladimir Sementsov-Ogievskiy wrote:
while (begin < overall_end && i < nb_extents) {
+ bool next_dirty = !dirty;
+
if (dirty) {
end = bdrv_dirty_bitmap_next_zero(bitmap, begin);
} else {
@@ -1
On 9/12/18 8:18 AM, Jeff Cody wrote:
When we converted rbd to get rid of the older key/value-centric
encoding format, we broke compatibility with image files with backing
file strings encoded in the old format.
This leaves a bit of an ugly conundrum, and a hacky solution.
+/* Take ca
14.09.2018 20:39, John Snow wrote:
On 09/10/2018 01:00 PM, Vladimir Sementsov-Ogievskiy wrote:
10.09.2018 19:55, Eric Blake wrote:
On 9/10/18 11:49 AM, Vladimir Sementsov-Ogievskiy wrote:
-int64_t hbitmap_next_zero(const HBitmap *hb, uint64_t start);
+int64_t hbitmap_next_zero(const HBitmap
On 09/14/2018 01:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> 14.09.2018 20:39, John Snow wrote:
>>
>> On 09/10/2018 01:00 PM, Vladimir Sementsov-Ogievskiy wrote:
>>> 10.09.2018 19:55, Eric Blake wrote:
On 9/10/18 11:49 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> -int64_t hbitmap_n
George: Can you confirm how your graphics is setup; the original
reporter had an Nvidia card with PCI passthrough; is yours the same?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1788665
Title:
Lo
On 9/14/18 12:24 PM, Eric Blake wrote:
On 9/14/18 11:51 AM, Vladimir Sementsov-Ogievskiy wrote:
bitmap_to_extents function is broken: it switches dirty variable after
every iteration, however it can process only part of dirty (or zero)
area during one iteration in case when this area is too larg
I try to bisect git version. When I run git bisect bad v3.0.0 it says:
Bisecting: 1298 revisions left to test after this (roughly 10 steps)
error: Your local changes to the following files would be overwritten by
checkout:
configure
po/bg.po
po/de_DE.po
po/fr_FR.po
Interrupt remapping needs kernel-irqchip={off|split} on both Intel and AMD
platforms. Move the check in common place.
Signed-off-by: Brijesh Singh
Reviewed-by: Peter Xu
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: Tom Lendacky
The vtd_generate_msi_message() in intel-iommu is used to construct a MSI
Message from IRQ. A similar function will be needed when we add interrupt
remapping support in amd-iommu. Moving the function in common file to
avoid the code duplication. Rename it to x86_iommu_irq_to_msi_message().
There is
Now that amd-iommu support interrupt remapping, enable the GASup in IVRS
table and GASup in extended feature register to indicate that IOMMU
support guest virtual APIC mode. GASup provides option to guest OS to
make use of 128-bit IRTE.
Note that the GAMSup is set to zero to indicate that amd-iomm
This series adds the interrupt remapping support for amd-iommu device.
IOMMU spec is available at: https://support.amd.com/TechDocs/48882_IOMMU.pdf
To enable the interrupt remap use below qemu cli
# $QEMU \
-device amd-iommu,intremap=on
I have tested FC-28 and Ubuntu 18.04 guest.
Linux guest
Register the interrupt remapping callback and read/write ops for the
amd-iommu-ir memory region.
amd-iommu-ir is set to higher priority to ensure that this region won't
be masked out by other memory regions.
While at it, add a overlapping amd-iommu region with higher priority
and update address s
Currently, the amdvi_validate_dte() assumes that a valid DTE will
always have V=1. This is not true. The V=1 means that bit[127:1] are
valid. A valid DTE can have IV=1 and V=0 (i.e pt=off, intremap=on).
Remove the V=1 check from amdvi_validate_dte(), make the caller
responsible to check for V or I
Emulate the interrupt remapping support when guest virtual APIC is
not enabled.
For more info Refer: AMD IOMMU spec Rev 3.0 - section 2.2.5.1
When VAPIC is not enabled, it uses interrupt remapping as defined in
Table 20 and Figure 15 from IOMMU spec.
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
1 - 100 of 110 matches
Mail list logo
