On 14/09/2018 16:00, John Snow wrote: >> Maybe not. We can hardly analyze all peripheral devices code and fix all the >> calls. >> But I think we can improve that patch and at least look through ide core to >> fix other calls. >> >> Pavel Dovgalyuk >> > It just seems odd that if you're working on a replay mechanism that > requires you to intercept my QEMU API calls that you're only changing a > trim callback.
You need it only here because the block layer is already calling replay_bh_schedule_event (actually replay_bh_schedule_oneshot_event after patch 22 of this series) on reads and writes. Paolo > I'd kind of expect that you don't need to intercept any, unless these > are legacy calls that I shouldn't be making at all and you have a more > generic intercept somewhere deeper in the codebase. > > In that case, I really ought to hustle off of my use of legacy calls. > > What are the criteria for things you need to intercept/wrap?
