On 14 September 2018 at 16:19, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 14/09/2018 16:00, John Snow wrote: >>> Maybe not. We can hardly analyze all peripheral devices code and fix all >>> the calls. >>> But I think we can improve that patch and at least look through ide core to >>> fix other calls. >>> >>> Pavel Dovgalyuk >>> >> It just seems odd that if you're working on a replay mechanism that >> requires you to intercept my QEMU API calls that you're only changing a >> trim callback. > > You need it only here because the block layer is already calling > replay_bh_schedule_event (actually replay_bh_schedule_oneshot_event > after patch 22 of this series) on reads and writes.
Do we have documentation describing when a device model needs to care about record/replay ? thanks -- PMM
