[Qemu-devel] [Bug 1771948] Re: aarch64 msr CNTFRQ_EL0

2018-09-05 Thread manuel
Thank you for your reply. Sorry to take so long (was on vacations). Your comment seems correct to me. I tried with the ELF file instead of the binary file and it worked perfectly (and all the cores were running instead of just core 0). >From my point of view, this bug can be marked as invalid. T

Re: [Qemu-devel] [PATCH v10 3/6] tpm: allocate/map buffer for TPM Physical Presence interface

2018-09-05 Thread Marc-André Lureau
Hi On Tue, Sep 4, 2018 at 10:51 AM Igor Mammedov wrote: > > On Mon, 03 Sep 2018 23:48:15 +0200 > Juan Quintela wrote: > > > Marc-André Lureau wrote: > > > Hi > > > > > > On Fri, Aug 31, 2018 at 7:32 PM Marc-André Lureau > > > wrote: > > >> > > >> From: Stefan Berger > > >> > > >> Implement a

[Qemu-devel] [PATCH] memory: size can be different from ptr_size

2018-09-05 Thread Marc-André Lureau
memory_region_init_ram*_ptr() take only the size of the MemoryRegion, and allocate a RAMBlock with the same size. However, it may be convenient to expose a smaller MemoryRegion (for ex: a few bytes) than the RAMBlock (which must be a multiple of TARGET_PAGE_SIZE). Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 3/3] virtio-pmem: Add virtio pmem driver

2018-09-05 Thread Pankaj Gupta
Hello, Thanks for the report. > Hi Pankaj, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linux-nvdimm/libnvdimm-for-next] > [also build test ERROR on v4.19-rc2 next-20180903] > [if your patch is applied to the wrong git tree, please drop us a note to > h

Re: [Qemu-devel] [PATCH 2/3] libnvdimm: nd_region flush callback support

2018-09-05 Thread Pankaj Gupta
Hello, Thanks for the report. > > Hi Pankaj, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linux-nvdimm/libnvdimm-for-next] > [also build test WARNING on v4.19-rc2 next-20180831] > [if your patch is applied to the wrong git tree, please drop us a

Re: [Qemu-devel] [PATCH v3] configure: preserve various environment variables in config.status

2018-09-05 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 10:16:26PM +0100, Peter Maydell wrote: > On 4 September 2018 at 17:21, Eric Blake wrote: > > I still find it odd > > that we aren't precisely mirroring the (nice!) semantics that autoconf users > > have come to rely on > > I think that's more the result of (a) most people

Re: [Qemu-devel] [PATCH 1/5] Fix segmentation fault when qemu_signal_init fails

2018-09-05 Thread Daniel P . Berrangé
On Wed, Sep 05, 2018 at 12:17:24PM +0800, Fei Li wrote: > Thanks for the review! :) > > > On 09/04/2018 07:26 PM, Daniel P. Berrangé wrote: > > On Tue, Sep 04, 2018 at 07:08:18PM +0800, Fei Li wrote: > > > Currently, when qemu_signal_init() fails it only returns a non-zero > > > value but without

Re: [Qemu-devel] [PATCH v10 3/6] tpm: allocate/map buffer for TPM Physical Presence interface

2018-09-05 Thread Juan Quintela
Marc-André Lureau wrote: Hi >> > Physical RAM is multiple of TARGET_PAGE_SIZE O:-) >> > That assumtion is held in too many places, if you can change the size to >> > be multiple of page size, that would be greate. > > It needs the RAMBlock to be a multiple of TARGET_PAGE_SIZE, but the > memory re

[Qemu-devel] [Bug 1497479] Re: memory corruption with migrate/savevm in TCG mode

2018-09-05 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? If you still can reproduce the issue, please send your patch to the qemu-devel mailing list for discussion (we generally do not take patches from the bugtra

[Qemu-devel] [Bug 1496384] Re: Error 0x5D in Qemu for Windows

2018-09-05 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Have you tried "-usb -device usb- tablet" already? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [Bug 1496712] Re: no bootable device after qemu-img convert parallels windows 2012 r2 to raw/qcow2

2018-09-05 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest *upstream* version of QEMU? Or could we close this ticket nowadays? (or in case you want to get support for qemu-img from Ubuntu instead, please use the "qemu" Ubuntu package as target, not the "qemu" project targ

Re: [Qemu-devel] [PATCH v1 00/17] Background snapshots

2018-09-05 Thread Denis Plotnikov
Hi Peter, Thanks for the reply. Ok, I understand about tcg. So my only option is to wait for userfaultfd-wp. Do you know if anyone is currently working on this? And if so, then is there any estimations when the userfaultfd is ready? Denis On 05.09.2018 06:32, Peter Xu wrote: On Tue, Sep 0

Re: [Qemu-devel] [PATCH v10 3/6] tpm: allocate/map buffer for TPM Physical Presence interface

2018-09-05 Thread Igor Mammedov
On Wed, 5 Sep 2018 12:21:39 +0400 Marc-André Lureau wrote: > Hi > > On Tue, Sep 4, 2018 at 10:51 AM Igor Mammedov wrote: > > > > On Mon, 03 Sep 2018 23:48:15 +0200 > > Juan Quintela wrote: > > > > > Marc-André Lureau wrote: > > > > Hi > > > > > > > > On Fri, Aug 31, 2018 at 7:32 PM Marc-André

Re: [Qemu-devel] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

2018-09-05 Thread Igor Mammedov
On Tue, 4 Sep 2018 23:12:55 -0300 Eduardo Habkost wrote: > On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote: > > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > > so that total number of logical CPUs [sockets * cores * threads] > > would be equal to [maxcpus],

Re: [Qemu-devel] [PATCH v1 00/17] Background snapshots

2018-09-05 Thread Peter Xu
On Wed, Sep 05, 2018 at 12:18:09PM +0300, Denis Plotnikov wrote: > Hi Peter, > > Thanks for the reply. > > Ok, I understand about tcg. > So my only option is to wait for userfaultfd-wp. > Do you know if anyone is currently working on this? And if so, then is > there any estimations when the user

[Qemu-devel] [PATCH] util/async: use qemu_aio_coroutine_enter in co_schedule_bh_cb

2018-09-05 Thread Sergio Lopez
AIO Coroutines shouldn't by managed by an AioContext different than the one assigned when they are created. aio_co_enter avoids entering a coroutine from a different AioContext, calling aio_co_schedule instead. Scheduled coroutines are then entered by co_schedule_bh_cb using qemu_coroutine_enter,

[Qemu-devel] [RFC-PATCH V2] hw/pci/pci_example.c : Added a new pci example device

2018-09-05 Thread Yoni Bettan
The main goal is to add 2 example devices to be used as templates or guideline for contributors when they wish to create a new device, the first is a PCI device and the second will be a VirtIO device. Those devices may be compiled by default with qemu, to ensure they won't break, but not have to b

Re: [Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-05 Thread Igor Mammedov
On Tue, 4 Sep 2018 22:40:49 -0300 Eduardo Habkost wrote: > On Tue, Sep 04, 2018 at 05:18:48PM +0200, Andrew Jones wrote: > > On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote: > > > commit > > > (5cdc9b76e3 vl.c: Remove dead assignment) > > > removed sockets calculation when 'socket

Re: [Qemu-devel] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread Kevin Wolf
Am 04.09.2018 um 21:30 hat Eric Blake geschrieben: > On 09/04/2018 02:15 PM, John Snow wrote: > > > > > post-script: I really, really hate the "fake cancel" we've implemented > > for mirror. It makes the job logic so much worse. > > Mirror really does have a tri-state way to end the job (and acc

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-09-05 Thread Hongbo Zhang
On 30 August 2018 at 21:29, Ard Biesheuvel wrote: > On 30 August 2018 at 12:02, Leif Lindholm wrote: >> On Thu, Aug 30, 2018 at 09:39:33AM +0100, Peter Maydell wrote: >>> On 30 August 2018 at 09:31, Leif Lindholm wrote: >>> > On Thu, Aug 30, 2018 at 03:07:29PM +0800, Hongbo Zhang wrote: >>> >> @

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-04 22:32, John Snow wrote: > > > On 09/04/2018 02:46 PM, Jeff Cody wrote: >> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: >>> Use the component callbacks; prepare, abort, and clean. >>> >>> NB: prepare is only called when the job has not yet failed; >>> and abort can be c

[Qemu-devel] [Bug 1788665] Re: Low 2D graphics performance with Windows 10 (1803) VGA passthrough VM using "Spectre" protection

2018-09-05 Thread Dr. David Alan Gilbert
I don't have the nvidia for pass through to try this with; but I suggest that you try the following: a) Start a windows vm running an older version unaffected by the bug and start a 2d test b) run 'perf top' on the host while the test is running and capture the results - make sure you

Re: [Qemu-devel] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread Max Reitz
On 2018-09-04 19:09, John Snow wrote: > In cases where we abort the block/mirror job, there's no point in > installing the new backing chain before we finish aborting. > > Move this to the "success" portion of mirror_exit. Sounds a bit weird now that you don't do any moving. > Signed-off-by: Joh

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread Max Reitz
On 2018-09-04 19:09, John Snow wrote: > For purposes of minimum code movement, refactor the mirror_exit > callback to use the post-finalization callbacks in a trivial way. > > Signed-off-by: John Snow > --- > block/mirror.c | 34 +++--- > 1 file changed, 27 insertions

Re: [Qemu-devel] [PATCH v4 10/15] tests/test-blockjob-txn: move .exit to .clean

2018-09-05 Thread Max Reitz
On 2018-09-04 19:09, John Snow wrote: > The exit callback in this test actually only performs cleanup. > > Signed-off-by: John Snow > --- > tests/test-blockjob-txn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Kevin Wolf
Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: > On 2018-09-04 22:32, John Snow wrote: > > > > > > On 09/04/2018 02:46 PM, Jeff Cody wrote: > >> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: > >>> Use the component callbacks; prepare, abort, and clean. > >>> > >>> NB: prepare is o

Re: [Qemu-devel] [PATCH 1/5] Fix segmentation fault when qemu_signal_init fails

2018-09-05 Thread Fei Li
On 09/05/2018 04:36 PM, Daniel P. Berrangé wrote: On Wed, Sep 05, 2018 at 12:17:24PM +0800, Fei Li wrote: Thanks for the review! :) On 09/04/2018 07:26 PM, Daniel P. Berrangé wrote: On Tue, Sep 04, 2018 at 07:08:18PM +0800, Fei Li wrote: ... snip ... free(info); re

[Qemu-devel] [PATCH] block/linux-aio: acquire AioContext before qemu_laio_process_completions

2018-09-05 Thread Sergio Lopez
In qemu_laio_process_completions_and_submit, the AioContext is acquired before the ioq_submit iteration and after qemu_laio_process_completions, but the latter is not thread safe either. This change avoids a number of random crashes when the Main Thread and an IO Thread collide processing completi

[Qemu-devel] [PATCH] intel_iommu: do address space switching when reset

2018-09-05 Thread Peter Xu
We will drop all the mappings when system reset, however we'll still keep the existing memory layouts. That'll be problematic since if IOMMU is enabled in the guest and then reboot the guest, SeaBIOS will try to drive a device that with no page mapped there. What we need to do is to rebuild the G

Re: [Qemu-devel] [PATCH] memory: size can be different from ptr_size

2018-09-05 Thread Juan Quintela
Marc-André Lureau wrote: > memory_region_init_ram*_ptr() take only the size of the MemoryRegion, > and allocate a RAMBlock with the same size. However, it may be > convenient to expose a smaller MemoryRegion (for ex: a few bytes) than > the RAMBlock (which must be a multiple of TARGET_PAGE_SIZE).

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-05 12:49, Kevin Wolf wrote: > Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: >> On 2018-09-04 22:32, John Snow wrote: >>> >>> >>> On 09/04/2018 02:46 PM, Jeff Cody wrote: On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: > Use the component callbacks; prepare, abort,

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-05 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Daniel P. Berrangé writes: > > > On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > >> >> On 09/03/2018 08:31 AM, Markus Arm

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-09-05 Thread Jaggi, Manish
> On 04-Sep-2018, at 3:24 PM, Andrew Jones wrote: > > External Email > > On Tue, Sep 04, 2018 at 09:16:58AM +, Jaggi, Manish wrote: >>> On 31-Aug-2018, at 4:41 PM, Andrew Jones wrote: >>> I think the sequence should look something like this: >>> >>> 1) Guest running on Host A with proces

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Kevin Wolf
Am 05.09.2018 um 13:37 hat Max Reitz geschrieben: > On 2018-09-05 12:49, Kevin Wolf wrote: > > Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: > >> On 2018-09-04 22:32, John Snow wrote: > >>> > >>> > >>> On 09/04/2018 02:46 PM, Jeff Cody wrote: > On Tue, Sep 04, 2018 at 01:09:19PM -0400, Joh

Re: [Qemu-devel] [PATCH 3/3] virtio-pmem: Add virtio pmem driver

2018-09-05 Thread kbuild test robot
Hi Pankaj, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-nvdimm/libnvdimm-for-next] [also build test ERROR on v4.19-rc2 next-20180905] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-09-05 Thread Andrew Jones
On Wed, Sep 05, 2018 at 06:08:57PM +0800, Hongbo Zhang wrote: > On 30 August 2018 at 21:29, Ard Biesheuvel wrote: > > On 30 August 2018 at 12:02, Leif Lindholm wrote: > >> On Thu, Aug 30, 2018 at 09:39:33AM +0100, Peter Maydell wrote: > >>> On 30 August 2018 at 09:31, Leif Lindholm > >>> wrote:

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-09-05 Thread Andrew Jones
On Wed, Sep 05, 2018 at 11:46:11AM +, Jaggi, Manish wrote: > (a) Changes in KVM: > > - Introducing a specific error code (KVM_EINVARIANT) in case of invariant > writes. > This should not change anything to API SET_ONE_REG KVM API. > Not sure which is the best place to put the define… > I have

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-05 13:53, Kevin Wolf wrote: > Am 05.09.2018 um 13:37 hat Max Reitz geschrieben: >> On 2018-09-05 12:49, Kevin Wolf wrote: >>> Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: On 2018-09-04 22:32, John Snow wrote: > > > On 09/04/2018 02:46 PM, Jeff Cody wrote: >> On

[Qemu-devel] [PATCH] cpu.h: fix a typo in comment

2018-09-05 Thread Li Qiang
Found by reading the code. Signed-off-by: Li Qiang --- include/qom/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index dc130cd307..5bb94a9f86 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -852,7 +852,7 @@ extern CPUInt

Re: [Qemu-devel] [PATCH v2 03/10] block: Remove child references from bs->{options, explicit_options}

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > Block drivers allow opening their children using a reference to an > existing BlockDriverState. These references remain stored in the > 'options' and 'explicit_options' QDicts, but we don't need to keep > them once everything is open. > > What is more i

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Peter Krempa
On Tue, Sep 04, 2018 at 17:34:36 +0200, Kevin Wolf wrote: > Am 04.09.2018 um 17:00 hat Peter Krempa geschrieben: > > On Tue, Sep 04, 2018 at 16:42:17 +0200, Alberto Garcia wrote: > > > On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote: [...] > > I remember being told some time ago to specif

Re: [Qemu-devel] [PATCH v2 05/10] block: Allow child references on reopen

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > In the previous patches we removed all child references from > bs->{options,explicit_options} because keeping them is useless and > wrong. > > Because of this, any attempt to reopen a BlockDriverState using a > child reference as one of its options woul

Re: [Qemu-devel] [PATCH for-3.1 v10 22/31] block: Add BlockDriver.bdrv_gather_child_options

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:19 PM CEST, Max Reitz wrote: > Some follow-up patches will rework the way bs->full_open_options is > refreshed in bdrv_refresh_filename(). The new implementation will remove > the need for the block drivers' bdrv_refresh_filename() implementations > to set bs->full_open_opt

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-09-05 Thread Jaggi, Manish
> On 05-Sep-2018, at 5:50 PM, Andrew Jones wrote: > > External Email > > On Wed, Sep 05, 2018 at 11:46:11AM +, Jaggi, Manish wrote: >> (a) Changes in KVM: >> >> - Introducing a specific error code (KVM_EINVARIANT) in case of invariant >> writes. >> This should not change anything to API

Re: [Qemu-devel] [PATCH for-3.1 v10 23/31] block: Generically refresh runtime options

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:20 PM CEST, Max Reitz wrote: > Instead of having every block driver which implements > bdrv_refresh_filename() copy all of the strong runtime options over to > bs->full_open_options, implement this process generically in > bdrv_refresh_filename(). > > This patch only adds t

Re: [Qemu-devel] [PATCH v2 06/10] block: Forbid trying to change unsupported options during reopen

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > The bdrv_reopen_prepare() function checks all options passed to each > BlockDriverState (in the reopen_state->options QDict) and makes all > necessary preparations to apply the option changes requested by the > user. > > Options are removed from the QDi

Re: [Qemu-devel] [PATCH for-3.1 v10 24/31] block: Purify .bdrv_refresh_filename()

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:21 PM CEST, Max Reitz wrote: > Currently, BlockDriver.bdrv_refresh_filename() is supposed to both > refresh the filename (BDS.exact_filename) and set BDS.full_open_options. > Now that we have generic code in the central bdrv_refresh_filename() for > creating BDS.full_open_o

Re: [Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > The file-posix code is used for the "file", "host_device" and > "host_cdrom" drivers, and it allows reopening images. However the only > option that is actually processed is "x-check-cache-dropped", and > changes in all other options (e.g. "filename") ar

Re: [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > 'discard' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in an error: > >(qemu) qemu-io virtio0 "reopen -o discard=on" >Cannot change the optio

Re: [Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' on reopen

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > 'detect-zeroes' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare(), so any attempt > to change it results in an error: > >(qemu) qemu-io virtio0 "reopen -o detect-zeroes=on" >Cannot cha

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Brad Smith
On 8/27/2018 5:05 AM, Gerd Hoffmann wrote: On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Brad Smith
On 8/27/2018 5:18 AM, Fam Zheng wrote: On Fri, 08/24 10:36, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched from GCC 4.2 to Clang. Th

Re: [Qemu-devel] [PATCH v2 10/10] block: Allow changing 'force-share' on reopen

2018-09-05 Thread Max Reitz
On 2018-09-03 16:34, Alberto Garcia wrote: > 'force-share' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in a "Cannot change the option" error: > >(qemu) qemu-io virtio0 "reopen -o force-shar

Re: [Qemu-devel] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread John Snow
On 09/05/2018 05:54 AM, Kevin Wolf wrote: > Am 04.09.2018 um 21:30 hat Eric Blake geschrieben: >> On 09/04/2018 02:15 PM, John Snow wrote: >> >>> >>> post-script: I really, really hate the "fake cancel" we've implemented >>> for mirror. It makes the job logic so much worse. >> >> Mirror really d

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread John Snow
On 09/05/2018 06:43 AM, Max Reitz wrote: > On 2018-09-04 19:09, John Snow wrote: >> For purposes of minimum code movement, refactor the mirror_exit >> callback to use the post-finalization callbacks in a trivial way. >> >> Signed-off-by: John Snow >> --- >> block/mirror.c | 34 +

[Qemu-devel] [PATCH qemu v2] hw/char/sh_serial: Add timeout handling to unbreak serial input

2018-09-05 Thread Geert Uytterhoeven
As of commit 18e8cf159177100e ("serial: sh-sci: increase RX FIFO trigger defaults for (H)SCIF") in Linux v4.11-rc1, the serial console on the QEMU SH4 target is broken: it delays serial input until enough data has been received. Since aforementioned commit, the Linux SCIF driver programs the Recei

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-09-05 Thread Andrew Jones
On Wed, Sep 05, 2018 at 12:42:05PM +, Jaggi, Manish wrote: > > > > On 05-Sep-2018, at 5:50 PM, Andrew Jones wrote: > > > > External Email > > > > On Wed, Sep 05, 2018 at 11:46:11AM +, Jaggi, Manish wrote: > >> (a) Changes in KVM: > >> > >> - Introducing a specific error code (KVM_EINV

Re: [Qemu-devel] [PATCH for-3.1 v10 25/31] block: Do not copy exact_filename from format file

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:22 PM CEST, Max Reitz wrote: > If a format BDS's file BDS is in turn a format BDS, we cannot simply use > the same filename, because when opening a BDS tree based on a filename > alone, qemu will create only one format node on top of one protocol node > (disregarding a pote

Re: [Qemu-devel] [PATCH v4 0/9] Add limited MXU instruction support

2018-09-05 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Thursday, August 30, 2018 9:30 PM > > Subject: [PATCH v4 0/9] Add limited MXU instruction support > This patch set begins to add MXU instruction support for mips emulation. Hi, Craig, I mentioned some time ago that we planned to revamp translate.c. Related to tha

Re: [Qemu-devel] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

2018-09-05 Thread Eduardo Habkost
On Wed, Sep 05, 2018 at 11:25:11AM +0200, Igor Mammedov wrote: > On Tue, 4 Sep 2018 23:12:55 -0300 > Eduardo Habkost wrote: > > > On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote: > > > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > > > so that total number of

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Eric Blake
On 09/05/2018 07:38 AM, Peter Krempa wrote: block-commit is able to reopen the format layers and works as expected. Unfortunately though the 'read-only' option is actually useful as the curl-driver does not work without it: -blockdev {"driver":"http","url":"http://ftp.sjtu.edu.cn:80/ubuntu-cd

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Peter Krempa
On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote: > On 09/05/2018 07:38 AM, Peter Krempa wrote: > > > block-commit is able to reopen the format layers and works as expected. > > > > Unfortunately though the 'read-only' option is actually useful as the > > curl-driver does not work without

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-09-05 Thread Hongbo Zhang
On 5 September 2018 at 20:02, Andrew Jones wrote: > On Wed, Sep 05, 2018 at 06:08:57PM +0800, Hongbo Zhang wrote: >> On 30 August 2018 at 21:29, Ard Biesheuvel wrote: >> > On 30 August 2018 at 12:02, Leif Lindholm wrote: >> >> On Thu, Aug 30, 2018 at 09:39:33AM +0100, Peter Maydell wrote: >> >>>

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eduardo Habkost
Question to the QAPI schema maintainers below: On Wed, Sep 05, 2018 at 01:47:55PM +0800, Robert Hoo wrote: > On Fri, 2018-08-17 at 17:52 +0200, Paolo Bonzini wrote: > > On 10/08/2018 16:06, Robert Hoo wrote: > > > x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only. > > > > This should

[Qemu-devel] Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage

2018-09-05 Thread Quan Xu
From 7de4cc7c944bfccde0ef10992a7ec882fdcf0508 Mon Sep 17 00:00:00 2001 From: Quan Xu Date: Wed, 5 Sep 2018 22:06:58 +0800 Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage Since the bulk stage assumes in (migration_bitmap_find_dirty) that every page

Re: [Qemu-devel] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:01 PM CEST, Max Reitz wrote: > If the backing file is overridden, this most probably does change the > guest-visible data of a BDS. Therefore, we will need to consider this > in bdrv_refresh_filename(). > > To see whether it has been overridden, we might want to compare >

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Gerd Hoffmann
On Wed, Sep 05, 2018 at 08:54:39AM -0400, Brad Smith wrote: > On 8/27/2018 5:05 AM, Gerd Hoffmann wrote: > > > On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: > > > I very much appreciate the effort to bump up to 6.3 as I was going > > > to suggest doing that at some point. But bumping

Re: [Qemu-devel] [PATCH] dump: fix Windows dump memory run mapping

2018-09-05 Thread Прутьянов , Виктор Владимирович
2018-08-29 21:30 GMT+03:00 Viktor Prutyanov : > > We should map and use guest memory run by parts if it can't be mapped as > a whole. > After this patch, continuos guest physical memory blocks which are not > continuos in host virtual address space will be processed correctly. > > Signed-off-by: Vi

[Qemu-devel] [Bug 1529173] Re: Absolutely slow Windows XP SP3 installation

2018-09-05 Thread Emilio G. Cota
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1529173 Title: Absolutely slow Windows XP SP3 installation Status in QEMU: Invalid Bug descriptio

Re: [Qemu-devel] [PATCH for-3.1 v10 08/31] iotests: Add test for backing file overrides

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:05 PM CEST, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 1/5] Fix segmentation fault when qemu_signal_init fails

2018-09-05 Thread Fam Zheng
On Wed, 09/05 19:20, Fei Li wrote: > > > On 09/05/2018 04:36 PM, Daniel P. Berrangé wrote: > > On Wed, Sep 05, 2018 at 12:17:24PM +0800, Fei Li wrote: > > > Thanks for the review! :) > > > > > > > > > On 09/04/2018 07:26 PM, Daniel P. Berrangé wrote: > > > > On Tue, Sep 04, 2018 at 07:08:18PM +

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Fam Zheng
On Wed, 09/05 16:24, Gerd Hoffmann wrote: > On Wed, Sep 05, 2018 at 08:54:39AM -0400, Brad Smith wrote: > > On 8/27/2018 5:05 AM, Gerd Hoffmann wrote: > > > > > On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: > > > > I very much appreciate the effort to bump up to 6.3 as I was going >

[Qemu-devel] [Bug 1735049] Re: Need MTTCG support for x86 guests

2018-09-05 Thread Emilio G. Cota
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1735049 Title: Need MTTCG support for x86 guests Status in QEMU: In Progress Bug description:

Re: [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs

2018-09-05 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:28 PM CEST, Max Reitz wrote: > +vm.shutdown() > + > +#assert top_name[:5] == 'json:' > +#top_options = json.loads(top_name[5:]) > + > +#if filter_node_name: > +## This should be present and set > +#assert top_options['

[Qemu-devel] [Bug 1529173] Re: Absolutely slow Windows XP SP3 installation

2018-09-05 Thread Emilio G. Cota
For integer workloads such as installing an OS you should expect TCG to be about 12x slower than KVM on average. That is on current master; note that TCG has gotten faster in the last couple of years. See a performance comparison from v2.7.0 to v2.11.0 for SPEC06 here: https://imgur.com/a/5P5zj I'

Re: [Qemu-devel] [PATCH] intel_iommu: do address space switching when reset

2018-09-05 Thread Alex Williamson
On Wed, 5 Sep 2018 19:31:58 +0800 Peter Xu wrote: > We will drop all the mappings when system reset, however we'll still > keep the existing memory layouts. That'll be problematic since if IOMMU > is enabled in the guest and then reboot the guest, SeaBIOS will try to > drive a device that with

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-09-05 Thread Andrew Jones
On Wed, Sep 05, 2018 at 10:09:46PM +0800, Hongbo Zhang wrote: > On 5 September 2018 at 20:02, Andrew Jones wrote: > > On Wed, Sep 05, 2018 at 06:08:57PM +0800, Hongbo Zhang wrote: > >> On 30 August 2018 at 21:29, Ard Biesheuvel > >> wrote: > >> > On 30 August 2018 at 12:02, Leif Lindholm > >>

[Qemu-devel] [Bug 1735049] Re: Need MTTCG support for x86 guests

2018-09-05 Thread Emilio G. Cota
Patches are now on the list to enable MTTCG for i386 and x86_64 guests. See v2 here: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00237.html I'm hoping these patches will be in the next QEMU release. Regarding your last question: > For instance, has support for strong-on-weak memory

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Kevin Wolf
Am 05.09.2018 um 16:02 hat Peter Krempa geschrieben: > On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote: > > On 09/05/2018 07:38 AM, Peter Krempa wrote: > > > > > block-commit is able to reopen the format layers and works as expected. > > > > > > Unfortunately though the 'read-only' optio

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-05 Thread Wolfgang Bumiller
On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: > From: Peter Xu > > Before this patch, monitor fd helpers might be called even earlier than > monitor_init_globals(). This can be problematic. > > After previous work, now monitor_init_globals() does not depend on > accelerator

[Qemu-devel] [PATCH] configure: Support --enable-capstone=internal

2018-09-05 Thread Eduardo Habkost
Currently there's no way to make configure not try to use the system-provided capstone library using pkgconfig. Add support to --enable-capstone=internal option to make QEMU not use the system-provided library automatically. Signed-off-by: Eduardo Habkost --- configure | 5 + 1 file changed

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eric Blake
On 09/05/2018 09:10 AM, Eduardo Habkost wrote: Question to the QAPI schema maintainers below: ## -{ 'struct': 'X86CPUFeatureWordInfo', - 'data': { 'cpuid-input-eax': 'int', -'*cpuid-input-ecx': 'int', -'cpuid-register': 'X86CPURegister32', +{ 'struct': 'X86CPUIDFeat

Re: [Qemu-devel] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread John Snow
On 09/05/2018 06:40 AM, Max Reitz wrote: > On 2018-09-04 19:09, John Snow wrote: >> In cases where we abort the block/mirror job, there's no point in >> installing the new backing chain before we finish aborting. >> >> Move this to the "success" portion of mirror_exit. > > Sounds a bit weird no

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread Eric Blake
On 09/05/2018 08:09 AM, John Snow wrote: On 09/05/2018 06:43 AM, Max Reitz wrote: On 2018-09-04 19:09, John Snow wrote: For purposes of minimum code movement, refactor the mirror_exit callback to use the post-finalization callbacks in a trivial way. Signed-off-by: John Snow --- block/mirr

[Qemu-devel] [PATCH v2] linux-user: do setrlimit selectively

2018-09-05 Thread Max Filippov
setrlimit guest calls that affect memory resources (RLIMIT_{AS,DATA,STACK}) may interfere with QEMU internal memory management. They may result in QEMU lockup because mprotect call in page_unprotect would fail with ENOMEM error code, causing infinite loop of SIGSEGV. E.g. it happens when running li

[Qemu-devel] [PATCH] docs/block-replication.txt: Add more detail about replication_do_checkpoint_all

2018-09-05 Thread Zhang Chen
Add more detail description for COLO checkpoint use case. Suggested by Dr. David Alan Gilbert Signed-off-by: Zhang Chen --- docs/block-replication.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/block-replication.txt b/docs/block-replication.txt index 6bde673

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: add PCI resource reserve capability to legacy PCI bridge

2018-09-05 Thread Marcel Apfelbaum
On 09/05/2018 05:08 AM, Liu, Jing2 wrote: Hi Marcel and Michael, Got no response so I would like to ask if I need do something more for this serial? :) Hi Jing, Maybe Michael is PTO, let's wait a few more days. Michael, I can send a pull request for this series if you are busy. Thanks, M

Re: [Qemu-devel] Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage

2018-09-05 Thread Eric Blake
On 09/05/2018 09:17 AM, Quan Xu wrote: From 7de4cc7c944bfccde0ef10992a7ec882fdcf0508 Mon Sep 17 00:00:00 2001 From: Quan Xu Date: Wed, 5 Sep 2018 22:06:58 +0800 Subject: [RFC PATCH v2] migration: calculate remaining pages accurately during the bulk stage Since the bulk stage assumes in (migr

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eduardo Habkost
On Wed, Sep 05, 2018 at 10:32:33AM -0500, Eric Blake wrote: > On 09/05/2018 09:10 AM, Eduardo Habkost wrote: > > Question to the QAPI schema maintainers below: > > > > > > ## > > > -{ 'struct': 'X86CPUFeatureWordInfo', > > > - 'data': { 'cpuid-input-eax': 'int', > > > -'*cpuid-inpu

Re: [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen

2018-09-05 Thread Alberto Garcia
On Mon 03 Sep 2018 04:34:06 PM CEST, Alberto Garcia wrote: > +value = qemu_opt_get_del(opts, "discard"); > +if (value != NULL) { > +if (bdrv_parse_discard_flags(value, &reopen_state->flags) != 0) { > +error_setg(errp, "Invalid discard option"); > +ret = -EI

Re: [Qemu-devel] [PATCH 3/5] qemu_init_vcpu: add a new Error paramater to propagate

2018-09-05 Thread Eric Blake
Adding Markus, as the maintainer of Error APIs, to make sure he sees this thread. On 09/04/2018 06:22 AM, Daniel P. Berrangé wrote: On Tue, Sep 04, 2018 at 07:08:20PM +0800, Fei Li wrote: In the subject line: s/paramater/parameter/ The caller of qemu_init_vcpu() already passed the **errp to

Re: [Qemu-devel] [PATCH v2 0/3] target/riscv: use tcg_lookup_and_goto_ptr

2018-09-05 Thread Alistair Francis
On Tue, Sep 4, 2018 at 6:07 PM, Emilio G. Cota wrote: > On Tue, Sep 04, 2018 at 16:42:32 -0700, Alistair Francis wrote: >> On Tue, Sep 4, 2018 at 4:39 PM, Emilio G. Cota wrote: >> > On Tue, Sep 04, 2018 at 13:18:28 -0700, Alistair Francis wrote: >> >> On Fri, Aug 31, 2018 at 3:22 PM, Emilio G. Co

Re: [Qemu-devel] [PATCH v4 3/9] target/mips: Split mips instruction handling

2018-09-05 Thread Aleksandar Markovic
> From: Janeczek, Craig > Sent: Tuesday, September 4, 2018 4:44 PM > > Subject: RE: [PATCH v4 3/9] target/mips: Split mips instruction handling > > To clarify the OPC_MUL here is not an MXU instruction, this is the original > OPC_MUL that was in the special2 instruction set. The inclusion of this

Re: [Qemu-devel] [PATCH v4 3/9] target/mips: Split mips instruction handling

2018-09-05 Thread Aleksandar Markovic
> From: Janeczek, Craig > Sent: Tuesday, September 4, 2018 4:44 PM > > Subject: RE: [PATCH v4 3/9] target/mips: Split mips instruction handling > > To clarify the OPC_MUL here is not an MXU instruction, this is the original > OPC_MUL that was in the special2 instruction set. The inclusion of this

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-09-05 Thread Eric Blake
On 09/05/2018 11:44 AM, Eduardo Habkost wrote: On Wed, Sep 05, 2018 at 10:32:33AM -0500, Eric Blake wrote: On 09/05/2018 09:10 AM, Eduardo Habkost wrote: Question to the QAPI schema maintainers below: ## -{ 'struct': 'X86CPUFeatureWordInfo', - 'data': { 'cpuid-input-eax': 'int', -

Re: [Qemu-devel] [PATCH] memory: size can be different from ptr_size

2018-09-05 Thread Marc-André Lureau
Hi On Wed, Sep 5, 2018 at 1:37 PM, Juan Quintela wrote: > Marc-André Lureau wrote: >> memory_region_init_ram*_ptr() take only the size of the MemoryRegion, >> and allocate a RAMBlock with the same size. However, it may be >> convenient to expose a smaller MemoryRegion (for ex: a few bytes) than

Re: [Qemu-devel] [RFC-PATCH V2] hw/pci/pci_example.c : Added a new pci example device

2018-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2018 at 12:38:00PM +0300, Yoni Bettan wrote: > The main goal is to add 2 example devices to be used as templates or guideline > for contributors when they wish to create a new device, the first is a PCI > device and the second will be a VirtIO device. > > Those devices may be compi

[Qemu-devel] [Bug 1696773] Re: golang calls to exec crash user emulation

2018-09-05 Thread Edward Vielmetti
This bug is mentioned in this account from Cloudflare of porting their software stack to arm64: https://blog.cloudflare.com/porting-our-software-to-arm64/ The relevant section from that blog reads as follows: # Intermittent Go Failures > With a decent amount of Go code running through our CI sy

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread John Snow
On 09/05/2018 06:27 AM, Max Reitz wrote: > On 2018-09-04 22:32, John Snow wrote: >> >> >> On 09/04/2018 02:46 PM, Jeff Cody wrote: >>> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: Use the component callbacks; prepare, abort, and clean. NB: prepare is only called when

[Qemu-devel] [PATCH V9 2/4] tests/migration: Support cross compilation in generating boot header file

2018-09-05 Thread Wei Huang
Recently a new configure option, CROSS_CC_GUEST, was added to $(TARGET)-softmmu/config-target.mak to support TCG-related tests. This patch tries to leverage this option to support cross compilation when the migration boot block file is being re-generated: * The x86 related files are moved to a ne

  1   2   >