Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Pavel Dovgalyuk
> From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > Pavel Dovgalyuk, le mer. 25 juil. 2018 15:17:06 +0300, a ecrit: > > ICMP implementation for IPv6 uses timers based on virtual clock. > > This is incorrect because this service is not related to the guest state. > > ? Why not? The RAs are

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-26 Thread David Hildenbrand
On 25.07.2018 22:14, Eduardo Habkost wrote: > On Wed, Jul 25, 2018 at 07:50:21PM +0200, David Hildenbrand wrote: >> On 25.07.2018 19:09, Eduardo Habkost wrote: > [...] +if (local_err) { +g_assert(kvm_enabled()); +error_report_err(local_err); +/* fallb

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > As documented: > > > > * @QEMU_CLOCK_REALTIME: Real time clock > > * > > * The real time clock should be used only for stuff which does not > > * change the virtual machine state, as it runs even if the virtual > > * machine

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Hongbo Zhang
On 25 July 2018 at 18:53, Dr. David Alan Gilbert wrote: > * Hongbo Zhang (hongbo.zh...@linaro.org) wrote: >> On 25 July 2018 at 17:54, Andrew Jones wrote: >> > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> >> For the Aarch64, there is one machine 'virt', it is primarily meant t

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Pavel Dovgalyuk
> From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > > As documented: > > > > > > * @QEMU_CLOCK_REALTIME: Real time clock > > > * > > > * The real time clock should be used only for stuff which does not > > > * change the

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:37:03 +0300, a ecrit: > > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > > > As documented: > > > > > > > > * @QEMU_CLOCK_REALTIME: Real time clock > > > > * > > > > * The re

Re: [Qemu-devel] [PATCH] target/ppc: only save guest timebase once after stopping

2018-07-26 Thread Laurent Vivier
On 26/07/2018 07:07, David Gibson wrote: > On Thu, May 03, 2018 at 11:20:44PM -0500, Michael Roth wrote: >> In some cases (e.g. spapr) we record guest timebase after qmp_stop() >> via a runstate hook so we can restore it on qmp_cont(). If a migration >> occurs in between those events we end up savi

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Ard Biesheuvel
On 26 July 2018 at 09:35, Hongbo Zhang wrote: > On 25 July 2018 at 18:53, Dr. David Alan Gilbert wrote: >> * Hongbo Zhang (hongbo.zh...@linaro.org) wrote: >>> On 25 July 2018 at 17:54, Andrew Jones wrote: >>> > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >>> >> For the Aarch64,

Re: [Qemu-devel] [PATCH] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread Laurent Vivier
Le 26/07/2018 à 08:48, Shivaprasad G Bhat a écrit : > r11 is a volatile register on PPC as per calling conventions. > The safe_syscall code uses it to check if the signal_pending > is set during the safe_syscall. When a syscall is interrupted > on return from signal handling, the r11 might be corru

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > virtual clock should be used by the virtual devices. > slirp module is not the virtual device. Therefore processed packets > become visible to the guest after passing to the virtual network card. > Before that it can create any timer

[Qemu-devel] [Bug 1587065] Update Released

2018-07-26 Thread Łukasz Zemczak
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a reg

[Qemu-devel] [Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze

2018-07-26 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.5+dfsg-5ubuntu10.31 --- qemu (1:2.5+dfsg-5ubuntu10.31) xenial; urgency=medium * d/p/ubuntu/lp-1587065-qga-ignore-EBUSY-when-freezing-a-filesystem.patch: Fix qemu-guest-agent failing to freeze filesystems that were mounted multiple

[Qemu-devel] [PATCH v2] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread Shivaprasad G Bhat
r11 is a volatile register on PPC as per calling conventions. The safe_syscall code uses it to check if the signal_pending is set during the safe_syscall. When a syscall is interrupted on return from signal handling, the r11 might be corrupted before we retry the syscall leading to a crash. The reg

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Pavel Dovgalyuk
> From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > virtual clock should be used by the virtual devices. > > slirp module is not the virtual device. Therefore processed packets > > become visible to the guest after passing t

Re: [Qemu-devel] [PATCH v2] riscv: remove define cpu_init()

2018-07-26 Thread Igor Mammedov
On Thu, 26 Jul 2018 10:27:38 +1200 Michael Clark wrote: > On Fri, May 18, 2018 at 8:02 PM, Igor Mammedov wrote: > > > On Fri, 18 May 2018 14:10:24 +1200 > > Michael Clark wrote: > > > > > On Wed, May 16, 2018 at 4:00 AM, Igor Mammedov > > wrote: > > > > > > > cpu_init() was removed si

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-07-26 Thread Paolo Bonzini
On 25/07/2018 22:04, Andrea Arcangeli wrote: > > It may look like the uffd-wp model is wish-feature similar to an > optimization, but without the uffd-wp model when the WP fault is > triggered by kernel code, the sigsegv model falls apart and requires > all kind of ad-hoc changes just for this sin

Re: [Qemu-devel] [PATCH v2 1/2] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

2018-07-26 Thread Cédric Le Goater
Ben, I have found out recently that the QEMU PowerNV could hang while accessing the disk. The issue seems to be the phb3_msi_try_send() routine when called from the resend() handler. The 'P' is ignored in that case but not the 'Q' bit which means that no interrupt will be resent if P|Q are set

Re: [Qemu-devel] [PATCH for-3.1 00/10] Move virtio-ccw devices to separate files

2018-07-26 Thread Cornelia Huck
On Wed, 25 Jul 2018 19:20:59 +0200 Thomas Huth wrote: > On 25.07.2018 15:48, Cornelia Huck wrote: > > On Wed, 25 Jul 2018 14:20:14 +0200 > > Thomas Huth wrote: > > > >> For more fine-grained control over the build process, it would be good > >> to have the possibility to disable single virtio

Re: [Qemu-devel] [PATCH for-3.1 01/10] hw/s390x/virtio-ccw: Consolidate calls to virtio_ccw_unrealize()

2018-07-26 Thread Cornelia Huck
On Wed, 25 Jul 2018 14:20:15 +0200 Thomas Huth wrote: > Currently, every virtio-ccw device explicitely sets its unrealize > function to virtio_ccw_unrealize() in its class_init function. > We can simplify this by using a common unrealize function, just like > it is already done for the realize fu

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 11:37:57 +0300, a ecrit: > > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > > virtual clock should be used by the virtual devices. > > > slirp module is not the virtual device. The

[Qemu-devel] [PATCH v2] block/gluster: defend on legacy ftruncate api use

2018-07-26 Thread Niels de Vos
From: Prasanna Kumar Kalever New versions of Glusters libgfapi.so have an updated glfs_ftruncate() function that returns additional 'struct stat' structures to enable advanced caching of attributes. This is useful for file servers, not so much for QEMU. Never the less, the API has changed and nee

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Peter Maydell
On 26 July 2018 at 08:44, Ard Biesheuvel wrote: > Does that really matter? As I pointed out before, we are not > interested in running the firmware on actual bare metal. What we do > care about is not having code in the reference firmware stack that was > added specifically to deal with the dynami

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Hongbo Zhang
On 25 July 2018 at 19:26, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 06:22:17PM +0800, Hongbo Zhang wrote: >> On 25 July 2018 at 17:54, Andrew Jones wrote: >> > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> >> For the Aarch64, there is one machine 'virt', it is primarily mea

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-07-26 Thread Peter Xu
On Thu, Jul 26, 2018 at 10:51:33AM +0200, Paolo Bonzini wrote: > On 25/07/2018 22:04, Andrea Arcangeli wrote: > > > > It may look like the uffd-wp model is wish-feature similar to an > > optimization, but without the uffd-wp model when the WP fault is > > triggered by kernel code, the sigsegv mode

Re: [Qemu-devel] [PATCH for-3.0] qcow: fix a reference leak

2018-07-26 Thread Kevin Wolf
Am 25.07.2018 um 20:07 hat KONRAD Frederic geschrieben: > Since 42a3e1ab367cdf38cce093de24eb406b99a4ef96 qemu asserts when using the > vvfat driver: > > git clone git://qemu.org/qemu.git > cd qemu > ./configure --target-list=ppc-softmmu --enable-debug > make -j8 > mkdir foo > touch foo/hello > ./p

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Hongbo Zhang
On 25 July 2018 at 22:08, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 03:46:01PM +0200, Ard Biesheuvel wrote: >> On 25 July 2018 at 15:38, Andrew Jones wrote: >> > On Wed, Jul 25, 2018 at 03:03:40PM +0200, Ard Biesheuvel wrote: >> >> On 25 July 2018 at 14:59, Andrew Jones wrote: >> >> > On Wed

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Hongbo Zhang
On 26 July 2018 at 00:15, Igor Mammedov wrote: > On Wed, 25 Jul 2018 13:36:45 +0200 > Andrew Jones wrote: > >> On Wed, Jul 25, 2018 at 11:50:41AM +0100, Dr. David Alan Gilbert wrote: >> > * Andrew Jones (drjo...@redhat.com) wrote: >> > > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrot

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/4 for-3.0] qcow2: A grammar fix in conflicting cache sizing error message

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 00:19 hat John Snow geschrieben: > On 07/25/2018 10:27 AM, Leonid Bloch wrote: > > Signed-off-by: Leonid Bloch > > Reviewed-by: John Snow Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Kevin Wolf
Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: > Signed-off-by: Leonid Bloch > --- > docs/qcow2-cache.txt | 3 +++ > qemu-options.hx | 10 ++ > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt > index 8a09a5cc5f..36

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Hongbo Zhang
On 25 July 2018 at 19:44, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 06:46:59PM +0800, Hongbo Zhang wrote: >> On 25 July 2018 at 17:54, Andrew Jones wrote: >> > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> >> For the Aarch64, there is one machine 'virt', it is primarily mea

Re: [Qemu-devel] tb_flush during softreset

2018-07-26 Thread Sai Pavan Boddu
Hi, Still looking if anyone can comment on this, Thanks. Regards, Sai Pavan From: Sai Pavan Boddu Sent: Wednesday, July 25, 2018 1:34 PM To: qemu-devel@nongnu.org Cc: Edgar Iglesias Subject: tb_flush during softreset Hi, We are seeing issue when fetching tb cache, any suggestions for debug wo

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Hongbo Zhang
On 25 July 2018 at 20:19, Peter Maydell wrote: > On 25 July 2018 at 12:44, Andrew Jones wrote: >> On Wed, Jul 25, 2018 at 06:46:59PM +0800, Hongbo Zhang wrote: >>> For Armv7, there is one typical platform 'vexpress', but for Armv8, no >> >> Wasn't the vexpress model designed for a specific machin

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 05:22:14PM +0800, Hongbo Zhang wrote: > On 25 July 2018 at 19:26, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 06:22:17PM +0800, Hongbo Zhang wrote: > >> On 25 July 2018 at 17:54, Andrew Jones wrote: > >> > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 05:46:23PM +0800, Hongbo Zhang wrote: > On 25 July 2018 at 22:08, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 03:46:01PM +0200, Ard Biesheuvel wrote: > >> On 25 July 2018 at 15:38, Andrew Jones wrote: > >> > On Wed, Jul 25, 2018 at 03:03:40PM +0200, Ard Biesheuvel wrot

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Ard Biesheuvel
On 26 July 2018 at 12:28, Andrew Jones wrote: > On Thu, Jul 26, 2018 at 05:22:14PM +0800, Hongbo Zhang wrote: >> On 25 July 2018 at 19:26, Andrew Jones wrote: >> > On Wed, Jul 25, 2018 at 06:22:17PM +0800, Hongbo Zhang wrote: >> >> On 25 July 2018 at 17:54, Andrew Jones wrote: >> >> > On Wed, Ju

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 06:17:36PM +0800, Hongbo Zhang wrote: > On 25 July 2018 at 19:44, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 06:46:59PM +0800, Hongbo Zhang wrote: > >> On 25 July 2018 at 17:54, Andrew Jones wrote: > >> > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >

Re: [Qemu-devel] [PULL 0/2] seccomp branch queue

2018-07-26 Thread Peter Maydell
On 25 July 2018 at 15:16, Eduardo Otubo wrote: > The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: > > Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccom

Re: [Qemu-devel] tb_flush during softreset

2018-07-26 Thread Peter Maydell
On 25 July 2018 at 09:04, Sai Pavan Boddu wrote: > We are seeing issue when fetching tb cache, any suggestions for debug would > be helpful. > > Issue: Post soft reset of the core, bootloader(running over different cpu) > reloads the program memory and releases the reset. At that point CPU crash

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Peter Maydell
On 26 July 2018 at 11:46, Andrew Jones wrote: > i440fx and q35 are specific machine types. 'sbsa' is a generic machine > type that conforms to the SBSA specification. If you weren't trying to > memory map AHCI and EHCI controllers, or if memory mapped AHCI and EHCI > controllers were mandated in t

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Ard Biesheuvel
On 26 July 2018 at 12:52, Peter Maydell wrote: > On 26 July 2018 at 11:46, Andrew Jones wrote: >> i440fx and q35 are specific machine types. 'sbsa' is a generic machine >> type that conforms to the SBSA specification. If you weren't trying to >> memory map AHCI and EHCI controllers, or if memory

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 05:55:54PM +0800, Hongbo Zhang wrote: > On 26 July 2018 at 00:15, Igor Mammedov wrote: > > On Wed, 25 Jul 2018 13:36:45 +0200 > > Andrew Jones wrote: > > > >> On Wed, Jul 25, 2018 at 11:50:41AM +0100, Dr. David Alan Gilbert wrote: > >> > * Andrew Jones (drjo...@redhat.com)

Re: [Qemu-devel] [PATCH v3 2/3] arm: Add Nordic Semiconductor nRF51 SoC

2018-07-26 Thread Julia Suvorova via Qemu-devel
On 26.07.2018 05:36, Joel Stanley wrote: The nRF51 is a Cortex-M0 microcontroller with an on-board radio module, plus other common ARM SoC peripherals. http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf This defines a basic model of the CPU and memory, with no peripherals implemented at t

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 12:35:08PM +0200, Ard Biesheuvel wrote: > On 26 July 2018 at 12:28, Andrew Jones wrote: > > On Thu, Jul 26, 2018 at 05:22:14PM +0800, Hongbo Zhang wrote: > >> On 25 July 2018 at 19:26, Andrew Jones wrote: > >> > On Wed, Jul 25, 2018 at 06:22:17PM +0800, Hongbo Zhang wrote:

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 12:56:22PM +0200, Ard Biesheuvel wrote: > On 26 July 2018 at 12:52, Peter Maydell wrote: > > On 26 July 2018 at 11:46, Andrew Jones wrote: > >> i440fx and q35 are specific machine types. 'sbsa' is a generic machine > >> type that conforms to the SBSA specification. If you

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Ard Biesheuvel
On 26 July 2018 at 13:11, Andrew Jones wrote: > On Thu, Jul 26, 2018 at 12:35:08PM +0200, Ard Biesheuvel wrote: >> On 26 July 2018 at 12:28, Andrew Jones wrote: >> > On Thu, Jul 26, 2018 at 05:22:14PM +0800, Hongbo Zhang wrote: >> >> On 25 July 2018 at 19:26, Andrew Jones wrote: >> >> > On Wed,

[Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as all-zero afterwards, so don't try to abuse it for zero writing. We try to only use this if BLKDISCARDZEROES tells us that it is safe, but this is unreliable on older kernels and a constant 0 in newer kernels. In other words, t

Re: [Qemu-devel] [PATCH] s390x/cpumodel: enum type S390FeatGroup now gets generated

2018-07-26 Thread Cornelia Huck
On Wed, 25 Jul 2018 16:36:17 +0200 Michael Mueller wrote: > The enumeration type S390FeatGroup is now generated as well. > This shall simplify the definition of new feature groups > without the requirement to modify existing code. So can we expect new feature groups soon? :) > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 01:15:15PM +0200, Ard Biesheuvel wrote: > That may be true. But we'll still end up with a UEFI build that has > OVMF virtio bus drivers and device drivers included, blurring the line > between emulation and virtualization. The UEFI build can drop the virtio-mmio support, an

Re: [Qemu-devel] [PULL 0/2] seccomp branch queue

2018-07-26 Thread Eduardo Otubo
On 26/07/2018 - 11:47:46, Peter Maydell wrote: > On 25 July 2018 at 15:16, Eduardo Otubo wrote: > > The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: > > > > Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) > > > > are available in the Git repository a

Re: [Qemu-devel] [PULL 0/2] seccomp branch queue

2018-07-26 Thread Marc-André Lureau
Hi On Thu, Jul 26, 2018 at 12:47 PM, Peter Maydell wrote: > On 25 July 2018 at 15:16, Eduardo Otubo wrote: >> The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: >> >> Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) >> >> are available in the Git repo

Re: [Qemu-devel] [PULL 0/2] seccomp branch queue

2018-07-26 Thread Marc-André Lureau
H On Thu, Jul 26, 2018 at 2:04 PM, Eduardo Otubo wrote: > On 26/07/2018 - 11:47:46, Peter Maydell wrote: >> On 25 July 2018 at 15:16, Eduardo Otubo wrote: >> > The following changes since commit >> > 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: >> > >> > Update version for v3.0.0-rc2 release (20

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Peter Maydell
On 26 July 2018 at 12:41, Andrew Jones wrote: > The patch guards the generation. It'll only modify DT and ACPI for the > new machine type. But, while modifying the DT makes sense, as that > generated DT will get consumed ...will it? Why would we want the firmware to read the QEMU-generated DT? Re

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Laszlo Ersek
On 07/26/18 13:13, Andrew Jones wrote: > On Thu, Jul 26, 2018 at 12:56:22PM +0200, Ard Biesheuvel wrote: >> On 26 July 2018 at 12:52, Peter Maydell wrote: >>> On 26 July 2018 at 11:46, Andrew Jones wrote: i440fx and q35 are specific machine types. 'sbsa' is a generic machine type that c

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Leonid Bloch
You mean with QDict? I'll look into that now. But already sent v5 before reading this email. Yes, with reading it from the QDict. (Or whatever the simplest way is that results in the right external interface, but I suppose this is the one.) Well, there is a problem with that: I can easily isol

Re: [Qemu-devel] [PATCH] target/ppc: only save guest timebase once after stopping

2018-07-26 Thread Michael Roth
Quoting David Gibson (2018-07-26 00:07:46) > On Thu, May 03, 2018 at 11:20:44PM -0500, Michael Roth wrote: > > In some cases (e.g. spapr) we record guest timebase after qmp_stop() > > via a runstate hook so we can restore it on qmp_cont(). If a migration > > occurs in between those events we end up

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Andrew Jones
On Thu, Jul 26, 2018 at 01:10:34PM +0100, Peter Maydell wrote: > On 26 July 2018 at 12:41, Andrew Jones wrote: > > The patch guards the generation. It'll only modify DT and ACPI for the > > new machine type. But, while modifying the DT makes sense, as that > > generated DT will get consumed > > .

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Peter Maydell
On 26 July 2018 at 13:35, Andrew Jones wrote: > On Thu, Jul 26, 2018 at 01:10:34PM +0100, Peter Maydell wrote: >> On 26 July 2018 at 12:41, Andrew Jones wrote: >> > The patch guards the generation. It'll only modify DT and ACPI for the >> > new machine type. But, while modifying the DT makes sens

Re: [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-07-26 Thread Markus Armbruster
Gerd Hoffmann writes: > Add parse_display_qapi() function which parses the -display command line > using a qapi visitor for DisplayOptions. Wire up as default catch in > parse_display(). > > Improves the error message for unknown display types. > > Also enables json as -display argument, i.e. -d

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-26 Thread Daniel P . Berrangé
On Thu, Jul 26, 2018 at 02:23:46PM +0200, Laszlo Ersek wrote: > On 07/26/18 13:13, Andrew Jones wrote: > > On Thu, Jul 26, 2018 at 12:56:22PM +0200, Ard Biesheuvel wrote: > >> On 26 July 2018 at 12:52, Peter Maydell wrote: > >>> On 26 July 2018 at 11:46, Andrew Jones wrote: > i440fx and q35

[Qemu-devel] [PATCH v1 for 3.0 1/2] linux-user/mmap.c: handle len = 0 maps correctly

2018-07-26 Thread Alex Bennée
I've slightly re-organised the check to more closely match the sequence that the kernel uses in do_mmap(). Signed-off-by: Alex Bennée Cc: umarcor <1783...@bugs.launchpad.net> --- linux-user/mmap.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/linux-user/mmap

[Qemu-devel] [PATCH v1 for 3.0 0/2] fix for bug 1783362

2018-07-26 Thread Alex Bennée
Hi, This fixes a bug where a zero len is passed to mmap. It comes with an enhancement to the mmap test case. Alex Bennée (2): linux-user/mmap.c: handle len = 0 maps correctly tests: add check_invalid_maps to test-mmap linux-user/mmap.c | 14 +++--- tests/tcg/multiarch/

[Qemu-devel] [PATCH v1 for 3.0 2/2] tests: add check_invalid_maps to test-mmap

2018-07-26 Thread Alex Bennée
This adds a test to make sure we fail properly for a 0 length mmap. There are most likely other failure conditions we should also check. Signed-off-by: Alex Bennée Cc: umarcor <1783...@bugs.launchpad.net> --- tests/tcg/multiarch/test-mmap.c | 16 +++- 1 file changed, 15 insertions(+)

Re: [Qemu-devel] [PATCH v1 for 3.0 1/2] linux-user/mmap.c: handle len = 0 maps correctly

2018-07-26 Thread Laurent Vivier
Le 26/07/2018 à 15:29, Alex Bennée a écrit : > I've slightly re-organised the check to more closely match the > sequence that the kernel uses in do_mmap(). > > Signed-off-by: Alex Bennée > Cc: umarcor <1783...@bugs.launchpad.net> > --- > linux-user/mmap.c | 14 +++--- > 1 file changed, 1

[Qemu-devel] [PATCH v5 2/3] spapr: introduce a IRQ controller backend to the machine

2018-07-26 Thread Cédric Le Goater
This proposal moves all the related IRQ routines of the sPAPR machine behind a sPAPR IRQ backend interface 'spapr_irq' to prepare for future changes. First of which will be to increase the size of the IRQ number space, then, will follow a new backend for the POWER9 XIVE IRQ controller. Signed-off-

[Qemu-devel] [PATCH v5 0/3] spapr: introduce a fixed IRQ number space and an IRQ controller backend

2018-07-26 Thread Cédric Le Goater
Here is a proposal for a new IRQ number space layout using static numbers and a bitmap allocator for the MSIs. The previous layout is kept for compatibly in machines raising the 'legacy_irq_allocation' flag. The patchset also introduces a sPAPR IRQ interface which offers the possibility to provide

[Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

2018-07-26 Thread Cédric Le Goater
This proposal introduces a new IRQ number space layout using static numbers for all devices, depending on a device index, and a bitmap allocator for the MSI IRQ numbers which are negotiated by the guest at runtime. As the VIO device model does not have a device index but a "reg" property, we intro

[Qemu-devel] [PATCH v5 3/3] spapr: increase the size of the IRQ number space

2018-07-26 Thread Cédric Le Goater
The new layout using static IRQ number does not leave much space to the dynamic MSI range, only 0x100 IRQ numbers. Increase the total number of IRQS for newer machines and introduce a legacy XICS backend for pre-3.1 machines to maintain compatibility. Signed-off-by: Cédric Le Goater --- include/

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] tpm_spapr: Support suspend and resume

2018-07-26 Thread Eric Blake
On 07/26/2018 12:31 AM, David Gibson wrote: On Tue, Dec 12, 2017 at 03:44:03PM -0500, Stefan Berger wrote: Signed-off-by: Stefan Berger --- hw/tpm/tpm_spapr.c | 61 ++ 1 file changed, 57 insertions(+), 4 deletions(-) diff --git a/hw/tpm/t

Re: [Qemu-devel] [PATCH 1/2] qstring: Assert size calculations don't overflow

2018-07-26 Thread Eric Blake
On 07/26/2018 01:18 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qobject/qstring.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qobject/qstring.c b/qobject/qstring.c index 18b8eb82f8..7990569c5a 100644 --- a/qobject/qstring.c +++ b/qobject/qstr

Re: [Qemu-devel] [PATCH 2/2] qstring: Move qstring_from_substr()'s @end one to the right

2018-07-26 Thread Eric Blake
On 07/26/2018 01:18 AM, Markus Armbruster wrote: qstring_from_substr() takes the index of the substring's first and last character. qstring_from_substr(s, 0, SIZE_MAX) denotes an empty substring. Awkward. Shift the end index one to the right. This simplifies both qstring_from_substr() and its

Re: [Qemu-devel] [PATCH v2] block/gluster: defend on legacy ftruncate api use

2018-07-26 Thread Eric Blake
On 07/26/2018 04:19 AM, Niels de Vos wrote: From: Prasanna Kumar Kalever When sending a v2, it's best to start a new thread instead of in-reply-to v1, so that the automated tooling spots it easier. Subject line is awkward, may I suggest: block/gluster: Handle changed glfs_ftruncate signatu

Re: [Qemu-devel] [PULL for-3.0 1/1] trace/simple: fix hang in child after fork(2)

2018-07-26 Thread Stefan Hajnoczi
On Tue, Jul 24, 2018 at 03:41:01PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 24, 2018 at 03:35:51PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 24, 2018 at 03:25:04PM +0100, Stefan Hajnoczi wrote: > > > The simple trace backend spawns a write-out thread which is used to > > > asynchronous

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Eric Blake
On 07/26/2018 05:02 AM, Kevin Wolf wrote: Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 10 ++ 2 files changed, 9 insertions(+), 4 deletions(-) +++ b/qemu-options.hx @@ -752,15 +752,17 @

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Leonid Bloch
On 07/26/2018 01:02 PM, Kevin Wolf wrote: Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 10 ++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 06:33 AM, Kevin Wolf wrote: The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as all-zero afterwards, so don't try to abuse it for zero writing. We try to only use this if BLKDISCARDZEROES tells us that it is safe, but this is unreliable on older kernels and a co

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Leonid Bloch
On 07/26/2018 05:20 PM, Eric Blake wrote: On 07/26/2018 05:02 AM, Kevin Wolf wrote: Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: Signed-off-by: Leonid Bloch ---   docs/qcow2-cache.txt |  3 +++   qemu-options.hx  | 10 ++   2 files changed, 9 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 14:24 hat Leonid Bloch geschrieben: > > > You mean with QDict? I'll look into that now. But already sent v5 before > > > reading this email. > > > > Yes, with reading it from the QDict. (Or whatever the simplest way is > > that results in the right external interface, but I suppos

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 16:27 hat Leonid Bloch geschrieben: > On 07/26/2018 01:02 PM, Kevin Wolf wrote: > > Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: > > > Signed-off-by: Leonid Bloch > > > --- > > > docs/qcow2-cache.txt | 3 +++ > > > qemu-options.hx | 10 ++ > > > 2 files c

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Leonid Bloch
On 07/26/2018 05:42 PM, Kevin Wolf wrote: Am 26.07.2018 um 14:24 hat Leonid Bloch geschrieben: You mean with QDict? I'll look into that now. But already sent v5 before reading this email. Yes, with reading it from the QDict. (Or whatever the simplest way is that results in the right external i

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Leonid Bloch
How about: "default: 4 times the cluster size; or if cache-size is specified, the part of it which is not used for the L2 cache" Even simpler, easier to understand and more accurate. I like it. Thanks! Kevin

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Stefan Hajnoczi
On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > Hey, > > Our team is adding a NIC functional emulation to QEMU. > One of the features we are adding to this NIC is SRIOV. > > Here is the error message I get when checking SRIOV support of our emulated > NIC on Win2016 server (

Re: [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in

2018-07-26 Thread Juan Quintela
Thomas Huth wrote: > On 17.07.2018 13:33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index b3e707e8c3..ccf71bddcc 100

Re: [Qemu-devel] [Qemu-block] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Nir Soffer
On Thu, Jul 26, 2018 at 5:28 PM Eric Blake wrote: > On 07/26/2018 06:33 AM, Kevin Wolf wrote: > > The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as > > all-zero afterwards, so don't try to abuse it for zero writing. We try > > to only use this if BLKDISCARDZEROES tells us t

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 16:28 hat Eric Blake geschrieben: > On 07/26/2018 06:33 AM, Kevin Wolf wrote: > > The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as > > all-zero afterwards, so don't try to abuse it for zero writing. We try > > to only use this if BLKDISCARDZEROES tells us th

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2018 at 09:29:44AM +0200, David Hildenbrand wrote: > On 25.07.2018 22:14, Eduardo Habkost wrote: > > On Wed, Jul 25, 2018 at 07:50:21PM +0200, David Hildenbrand wrote: > >> On 25.07.2018 19:09, Eduardo Habkost wrote: > > [...] > +if (local_err) { > +g_assert(kv

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-07-26 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 25/07/2018 22:04, Andrea Arcangeli wrote: > > > > It may look like the uffd-wp model is wish-feature similar to an > > optimization, but without the uffd-wp model when the WP fault is > > triggered by kernel code, the sigsegv model falls apart and

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 10:06 AM, Kevin Wolf wrote: +#ifdef CONFIG_FALLOCATE_PUNCH_HOLE +ret = do_fallocate(s->fd, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE, + aiocb->aio_offset, aiocb->aio_nbytes); Umm, doesn't this have to use FALLOC_FL_ZERO_RANGE? FALLOC_FL_PUNCH_HOLE deall

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 17:23 hat Eric Blake geschrieben: > On 07/26/2018 10:06 AM, Kevin Wolf wrote: > > > > > +#ifdef CONFIG_FALLOCATE_PUNCH_HOLE > > > > +ret = do_fallocate(s->fd, FALLOC_FL_PUNCH_HOLE | > > > > FALLOC_FL_KEEP_SIZE, > > > > + aiocb->aio_offset, aiocb->aio_nby

Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-07-26 Thread Alex Bennée
Pavel Dovgalyuk writes: > Replay is capable of recording normal BH events, but sometimes > there are single use callbacks scheduled with aio_bh_schedule_oneshot > function. This patch enables recording and replaying such callbacks. > Block layer uses these events for calling the completion func

Re: [Qemu-devel] [PATCH hack dontapply v2 7/7] pc: HACK: acpi: tie in _CST object to Processor

2018-07-26 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 04:49:08PM +0200, Igor Mammedov wrote: > On Wed, 25 Jul 2018 15:50:09 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 25, 2018 at 02:37:24PM +0200, Igor Mammedov wrote: > > > On Tue, 10 Jul 2018 03:01:34 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Based

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Marcel Apfelbaum
Hi On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: Hey, Our team is adding a NIC functional emulation to QEMU. One of the features we are adding to this NIC is SRIOV. Here is the error message I get when checking SRIOV support o

Re: [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation

2018-07-26 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 05:53:35PM +0200, Igor Mammedov wrote: > On Wed, 25 Jul 2018 15:44:37 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 25, 2018 at 02:32:11PM +0200, Igor Mammedov wrote: > > > On Tue, 10 Jul 2018 03:01:30 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Now t

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 10:33 AM, Kevin Wolf wrote: As far as I know, the comment you quoted is accurate for BLKDISCARD and BLKZEROOUT, but not for the fallocate() flags. I sure wish the man pages were more explicit on what guarantees each flag offers. Hmm - that thread also mentions FALLOC_FL_NO_

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-07-26 Thread Marcel Apfelbaum
On 07/25/2018 01:59 PM, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (marcel.apfelb...@gmail.com) wrote: Hi, On 07/25/2018 10:32 AM, Thomas Huth wrote: On 25.07.2018 06:47, Rebecca Cran wrote: In commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc, ./configure on FreeBSD incorrectly detect

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > Hi > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > > > Hey, > > > > > > Our team is adding a NIC functional emulation to QEMU. > > > One of the features w

Re: [Qemu-devel] [Qemu-block] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Nir Soffer
On Thu, Jul 26, 2018 at 2:33 PM Kevin Wolf wrote: > The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as > all-zero afterwards, so don't try to abuse it for zero writing. We try > to only use this if BLKDISCARDZEROES tells us that it is safe, but this > is unreliable on older

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Marcel Apfelbaum
On 07/26/2018 07:14 PM, Michael S. Tsirkin wrote: On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: Hi On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: Hey, Our team is adding a NIC functional emulation to QEM

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 07:34:41PM +0300, Marcel Apfelbaum wrote: > > > On 07/26/2018 07:14 PM, Michael S. Tsirkin wrote: > > On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > > > Hi > > > > > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > > > On Thu, Jul 12, 2018 at 07:3

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Knut Omang
On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum wrote: > Hi > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > > > Hey, > > > > > > Our team is adding a NIC functional emulation to QEMU. > > > One of the features we are a

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 06:38:32PM +0200, Knut Omang wrote: > On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum wrote: > > Hi > > > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > > On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > > > > Hey, > > > > > > > > Our team is ad

  1   2   >