Thomas Huth <th...@redhat.com> wrote: > On 17.07.2018 13:33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> tests/Makefile.include | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index b3e707e8c3..ccf71bddcc 100644 >> --- a/tests/Makefile.include >> +++ b/tests/Makefile.include >> @@ -288,8 +288,8 @@ check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF) >> gcov-files-i386-y += hw/usb/hcd-ehci.c >> gcov-files-i386-y += hw/usb/dev-hid.c >> gcov-files-i386-y += hw/usb/dev-storage.c >> -check-qtest-i386-y += tests/usb-hcd-xhci-test$(EXESUF) >> -gcov-files-i386-y += hw/usb/hcd-xhci.c >> +check-qtest-i386-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF) >> +gcov-files-i386-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c >> check-qtest-i386-y += tests/cpu-plug-test$(EXESUF) >> check-qtest-i386-y += tests/q35-test$(EXESUF) >> check-qtest-i386-y += tests/vmgenid-test$(EXESUF) >> @@ -347,8 +347,8 @@ check-qtest-ppc64-y += tests/usb-hcd-ohci-test$(EXESUF) >> gcov-files-ppc64-y += hw/usb/hcd-ohci.c >> check-qtest-ppc64-y += tests/usb-hcd-uhci-test$(EXESUF) >> gcov-files-ppc64-y += hw/usb/hcd-uhci.c >> -check-qtest-ppc64-y += tests/usb-hcd-xhci-test$(EXESUF) >> -gcov-files-ppc64-y += hw/usb/hcd-xhci.c >> +check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF) >> +gcov-files-ppc64-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c >> check-qtest-ppc64-y += $(check-qtest-virtio-y) >> check-qtest-ppc64-$(CONFIG_SLIRP) += tests/test-netfilter$(EXESUF) >> check-qtest-ppc64-$(CONFIG_POSIX) += tests/test-filter-mirror$(EXESUF) > > I wonder whether the gcov lines are still up-to-date, or whether they > should include hcd-xhci-nec.c as well? (See commit 0bbb2f3df1ffd9ccf713 > for the split)
Added the hcd-xhci-nec.c file to gcov. I still don't know how to launch gcowv :-( So no clue about how up-to-date the lines are. Later, Juan.
