H On Thu, Jul 26, 2018 at 2:04 PM, Eduardo Otubo <ot...@redhat.com> wrote: > On 26/07/2018 - 11:47:46, Peter Maydell wrote: >> On 25 July 2018 at 15:16, Eduardo Otubo <ot...@redhat.com> wrote: >> > The following changes since commit >> > 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: >> > >> > Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) >> > >> > are available in the Git repository at: >> > >> > https://github.com/otubo/qemu.git tags/pull-seccomp-20180725 >> > >> > for you to fetch changes up to 5b2f59307372bae13a2ff95706646674eccb65e0: >> > >> > RFC: seccomp: prefer SCMP_ACT_KILL_PROCESS if available (2018-07-25 >> > 16:07:31 +0200) >> > >> > ---------------------------------------------------------------- >> > pull-seccomp-20180725 >> > >> > ---------------------------------------------------------------- >> > Marc-André Lureau (2): >> > seccomp: use SIGSYS signal instead of killing the thread >> > RFC: seccomp: prefer SCMP_ACT_KILL_PROCESS if available >> >> Hi. This fails to compile with clang: >> >> CC qemu-seccomp.o >> qemu-seccomp.c:112:1: error: unused function 'qemu_seccomp' >> [-Werror,-Wunused-function] >> qemu_seccomp(unsigned int operation, unsigned int flags, void *args) >> ^ >> >> This is because clang is stricter about warning about static inline >> functions defined in .c files but never used and your ifdef >> guard on the callsite is not matched by one around the function >> definition. >> > > Peter, sorry for not catching that before. > Marc, can you fix and resend?
I suggest to drop that patch from 3.0. Since it will require a newer libseccomp to be actually useful, it can be delayed imho. -- Marc-André Lureau
