Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-05-31 Thread Peter Maydell
On 17 May 2018 at 20:31, Aaron Lindsay wrote: > On Apr 17 16:00, Peter Maydell wrote: >> So, the underlying issue here is that there's a QEMU specific >> fudge going on. Architecturally, if the CPU implements the >> Virtualization Extensions, then: >> * it has Hyp mode >> * it must also implemen

[Qemu-devel] [PULL 11/25] Make tb_invalidate_phys_addr() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to tb_invalidate_phys_addr(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by

[Qemu-devel] [PULL 13/25] Make address_space_map() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_map(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard He

[Qemu-devel] [PULL 00/25] target-arm queue

2018-05-31 Thread Peter Maydell
/tags/numa-next-pull-request' into staging (2018-05-31 11:12:36 +0100) are available in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180531 for you to fetch changes up to 49d1dca0520ea71bc21867fab6647f474fcf857b: KVM: GIC: Fix memory

[Qemu-devel] [PULL 02/25] MAINTAINERS: Add entries for newer MPS2 boards and devices

2018-05-31 Thread Peter Maydell
Add entries to MAINTAINERS to cover the newer MPS2 boards and the new devices they use. Signed-off-by: Peter Maydell Message-id: 20180518153157.14899-1-peter.mayd...@linaro.org --- MAINTAINERS | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[Qemu-devel] [PULL 04/25] arm_gicv3_kvm: increase clroffset accordingly

2018-05-31 Thread Peter Maydell
From: Shannon Zhao It forgot to increase clroffset during the loop. So it only clear the first 4 bytes. Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920 Cc: qemu-sta...@nongnu.org Signed-off-by: Shannon Zhao Reviewed-by: Eric Auger Message-id: 1527047633-12368-1-git-send-email-zhaoshengl...@hua

[Qemu-devel] [PULL 10/25] memory.h: Improve IOMMU related documentation

2018-05-31 Thread Peter Maydell
Add more detail to the documentation for memory_region_init_iommu() and other IOMMU-related functions and data structures. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Message-id: 20180521140402.23318-2-peter.mayd...@linaro.org --

[Qemu-devel] [PULL 18/25] Make flatview_access_valid() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_access_valid(). Its callers now all have an attrs value to hand, so we can correct our earlier temporary use of MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell Reviewed-by: Alex Benné

[Qemu-devel] [PULL 09/25] Correct CPACR reset value for v7 cores

2018-05-31 Thread Peter Maydell
In commit f0aff255700 we made cpacr_write() enforce that some CPACR bits are RAZ/WI and some are RAO/WI for ARMv7 cores. Unfortunately we forgot to also update the register's reset value. The effect was that (a) a guest that read CPACR on reset would not see ones in the RAO bits, and (b) if you did

[Qemu-devel] [PULL 03/25] hw/intc/arm_gicv3: Fix APxR register dispatching

2018-05-31 Thread Peter Maydell
From: Jan Kiszka There was a nasty flip in identifying which register group an access is targeting. The issue caused spuriously raised priorities of the guest when handing CPUs over in the Jailhouse hypervisor. Cc: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka Message-id: 28b927d3-da58-bce4-

[Qemu-devel] [PULL 15/25] Make flatview_extend_translation() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_extend_translation(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by:

[Qemu-devel] [PULL 12/25] Make address_space_translate{, _cached}() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_translate() and address_space_translate_cached(). Callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell Reviewed-b

[Qemu-devel] [PULL 05/25] tcg: Fix helper function vs host abi for float16

2018-05-31 Thread Peter Maydell
From: Richard Henderson Depending on the host abi, float16, aka uint16_t, values are passed and returned either zero-extended in the host register or with garbage at the top of the host register. The tcg code generator has so far been assuming garbage, as that matches the x86 abi, but this is in

[Qemu-devel] [PULL 17/25] Make MemoryRegion valid.accepts callback take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to the MemoryRegion valid.accepts callback. We'll need this for subpage_accepts(). We could take the approach we used with the read and write callbacks and add new a new _with_attrs version, but since

[Qemu-devel] [PULL 21/25] Make flatview_do_translate() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_do_translate(). Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-id: 20180521140402.23318-13-peter.mayd...@linaro.org --- exec.c | 9 ++--

[Qemu-devel] [PULL 08/25] xlnx-zdma: Correct mem leaks and memset to zero on desc unaligned errors

2018-05-31 Thread Peter Maydell
From: Francisco Iglesias Coverity found that the string return by 'object_get_canonical_path' was not being freed at two locations in the model (CID 1391294 and CID 1391293) and also that a memset was being called with a value greater than the max of a byte on the second argument (CID 1391286). T

[Qemu-devel] [PULL 16/25] Make memory_region_access_valid() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to memory_region_access_valid(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. The callsite in flatview_access_valid() is part of a recursive loop fl

[Qemu-devel] [PULL 20/25] Make address_space_get_iotlb_entry() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_get_iotlb_entry(). Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-id: 20180521140402.23318-12-peter.mayd...@linaro.org --- include/exe

[Qemu-devel] [PULL 22/25] Make address_space_translate_iommu take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_translate_iommu(). Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-id: 20180521140402.23318-14-peter.mayd...@linaro.org --- exec.c | 8

[Qemu-devel] [PULL 23/25] vmstate.h: Provide VMSTATE_BOOL_SUB_ARRAY

2018-05-31 Thread Peter Maydell
Provide a VMSTATE_BOOL_SUB_ARRAY to go with VMSTATE_UINT8_SUB_ARRAY and friends. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Message-id: 20180521140402.23318-23-peter.mayd...@linaro.org --- include/migration/vmstate.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/migr

[Qemu-devel] [PULL 07/25] arm: fix malloc type mismatch

2018-05-31 Thread Peter Maydell
From: Paolo Bonzini cpregs_keys is an uint32_t* so the allocation should use uint32_t. g_new is even better because it is type-safe. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/gdbstub.c | 3 +-- 1 f

[Qemu-devel] [PULL 19/25] Make flatview_translate() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_translate(); all its callers now have attrs available. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-id: 20180521140402.23318-11-peter.mayd

[Qemu-devel] [PULL 06/25] arm: fix qemu crash on startup with -bios option

2018-05-31 Thread Peter Maydell
From: Igor Mammedov When QEMU is started with following CLI -machine virt,gic-version=3,accel=kvm -cpu host -bios AAVMF_CODE.fd it crashes with abort at accel/kvm/kvm-all.c:2164: KVM_SET_DEVICE_ATTR failed: Group 6 attr 0xc665: Invalid argument Which is caused by implicit dependen

[Qemu-devel] [PULL 24/25] ARM: ACPI: Fix use-after-free due to memory realloc

2018-05-31 Thread Peter Maydell
From: Shannon Zhao acpi_data_push uses g_array_set_size to resize the memory size. If there is no enough contiguous memory, the address will be changed. So previous pointer could not be used any more. It must update the pointer and use the new one. Also, previous codes wrongly use le32 conversio

[Qemu-devel] [PULL 25/25] KVM: GIC: Fix memory leak due to calling kvm_init_irq_routing twice

2018-05-31 Thread Peter Maydell
From: Shannon Zhao kvm_irqchip_create called by kvm_init will call kvm_init_irq_routing to initialize global capability variables. If we call kvm_init_irq_routing in GIC realize function, previous allocated memory will leak. Fix this by deleting the unnecessary call. Signed-off-by: Shannon Zhao

[Qemu-devel] [PULL 01/25] target/arm: Honour FPCR.FZ in FRECPX

2018-05-31 Thread Peter Maydell
The FRECPX instructions should (like most other floating point operations) honour the FPCR.FZ bit which specifies whether input denormals should be flushed to zero (or FZ16 for the half-precision version). We forgot to implement this, which doesn't affect the results (since the calculation doesn't

[Qemu-devel] [PULL 14/25] Make address_space_access_valid() take a MemTxAttrs argument

2018-05-31 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_access_valid(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: R

Re: [Qemu-devel] [PATCH v5 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-05-31 Thread Shannon Zhao
2018-05-31 21:50 GMT+08:00 Peter Maydell : > On 31 May 2018 at 04:15, Shannon Zhao wrote: > > While we skip the GIC_INTERNAL irqs, we don't change the register offset > > accordingly. This will overlap the GICR registers value and leave the > > last GIC_INTERNAL irq's registers out of update. > >

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Junyan He
> Also, there was a discussion about leaving the code unchanged but adding > an nvdimm_flush() call at the very end of migration. I think someone > benchmarked it but can't find the email. Please post a link or > summarize the results, because that approach would be much less > invasive. Thanks!

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > David Gilbert previously suggested a memory access interface. I guess > it would look something like this: > > typedef struct { > void (*memset)(void *s, int c, size_t n); > void (*memcpy)(void *dest, const void *src, size_t n); > }

Re: [Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event

2018-05-31 Thread Eric Blake
On 05/31/2018 12:16 AM, Peter Xu wrote: This event is not really necessary. After OOB series it might affect the timing of the script so this event may or may not be there comparing to the old *.out results. Let's just filter it out. This is worrying. Are you stating that the SHUTDOWN event c

Re: [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default

2018-05-31 Thread Eric Blake
On 05/31/2018 12:16 AM, Peter Xu wrote: There was a regression reported by Eric Auger before with OOB: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html The fix is 951702f39c ("monitor: bind dispatch bh to iohandler context", 2018-04-10), which is in master already. s/, wh

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Dr. David Alan Gilbert
* Junyan He (junyan...@gmx.com) wrote: > > Also, there was a discussion about leaving the code unchanged but adding > > an nvdimm_flush() call at the very end of migration. I think someone > > benchmarked it but can't find the email. Please post a link or > > summarize the results, because that a

Re: [Qemu-devel] [RFC v2 4/4] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-05-31 Thread Eric Blake
On 05/31/2018 12:16 AM, Peter Xu wrote: This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. Meanwhile, revert one line from fa198ad9bdef to make sure qtest_init_without_qmp_handshake() will only pass in one parameter. Signed-off-by: Peter Xu --- +++ b/tests/libqtest.h @@ -56,14 +5

Re: [Qemu-devel] [PATCH v5 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-05-31 Thread Peter Maydell
On 31 May 2018 at 15:36, Shannon Zhao wrote: > > > 2018-05-31 21:50 GMT+08:00 Peter Maydell : >> Shouldn't we be adding the same thing to clroffset that we add to offset ? >> >> Yeah, right. It should like this > > clroffset += (GIC_INTERNAL * 1) / 8; > > I don't remember why I didn't write this

Re: [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

2018-05-31 Thread Eric Blake
On 05/30/2018 07:43 PM, John Snow wrote: These functions work on the AHCI device, not the individual s/device/state/ ? AHCI devices, so trim the AHCIDevice argument. Signed-off-by: John Snow --- hw/ide/ahci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Eric Blake,

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Junyan He
> > So Haozhong's manner seems to be a little faster and I choose to keep that. > > > > If you want to choose this manner, the code will be clean and no need for > > > > typedef struct { > > > void (*memset)(void *s, int c, size_t n); > > > void (*memcpy)(void *dest, const void *src

Re: [Qemu-devel] [PATCH] Fix hang with -L and symlink loop

2018-05-31 Thread Peter Maydell
On 30 May 2018 at 21:50, Richard Henderson wrote: > On 05/29/2018 04:44 PM, Evan Green wrote: >> When using -L with Linux app emulation, there is an issue in >> init_paths where Qemu will get lost exploring a directory tree >> with a symlink loop in it. This causes Qemu to hang, and >> eventually

Re: [Qemu-devel] [PULL 00/25] target-arm queue

2018-05-31 Thread Peter Maydell
a3ac12fba028df90f7b3dbec924995c126c41022: > > Merge remote-tracking branch 'remotes/ehabkost/tags/numa-next-pull-request' > into staging (2018-05-31 11:12:36 +0100) > > are available in the Git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.

Re: [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

2018-05-31 Thread John Snow
On 05/31/2018 10:56 AM, Eric Blake wrote: > On 05/30/2018 07:43 PM, John Snow wrote: >> These functions work on the AHCI device, not the individual > > s/device/state/ ? > It's confusing; the AHCI device itself (the HBA) is represented by the struct AHCIState. the SATA devices are referred to

Re: [Qemu-devel] [PULL 00/25] target-arm queue

2018-05-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180531142357.904-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PULL 00/25] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneli

Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] ahci: trim signatures on raise/lower

2018-05-31 Thread Jeff Cody
On Wed, May 30, 2018 at 08:43:21PM -0400, John Snow wrote: > These functions work on the AHCI device, not the individual > AHCI devices, so trim the AHCIDevice argument. > > Signed-off-by: John Snow > --- > hw/ide/ahci.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff -

[Qemu-devel] [PULL 00/25] target-arm queue

2018-05-31 Thread Peter Maydell
e-tracking branch 'remotes/ehabkost/tags/numa-next-pull-request' into staging (2018-05-31 11:12:36 +0100) are available in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180531-1 for you to fetch changes up to 2f15b79280cf71b7991d

Re: [Qemu-devel] [PATCH v5 13/14] travis: improve python version test coverage

2018-05-31 Thread Philippe Mathieu-Daudé
Hi Daniel, On 01/16/2018 10:42 AM, Daniel P. Berrange wrote: > Currently travis declares ancient python 2.4 is desired. Update that to > 2.6 which is the oldest version any targetted distros still needs. If we > just list a python 3 version at the top level this will double the > number of travis

Re: [Qemu-devel] [PATCH v1 5/8] .travis.yml: rationalise clang testing

2018-05-31 Thread Philippe Mathieu-Daudé
On 05/30/2018 08:06 AM, Alex Bennée wrote: > As Travis includes Clang 5.0 in its own build environment there is no > point manually building with older Clangs. We still need to test with > the two pythons though so we leave them as system only builds. We also > split the clang build into two as it

Re: [Qemu-devel] [PATCH v13 03/12] migration: Add multifd traces for start/end thread

2018-05-31 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We want to know how many pages/packets each channel has sent. Add > counters for those. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > -- > sort trace-events (dave) > --- > migration/ram.c| 22

Re: [Qemu-devel] [PATCH v1 7/8] .travis.yml: update GCC sanitizer build to GCC 7

2018-05-31 Thread Philippe Mathieu-Daudé
On 05/30/2018 08:06 AM, Alex Bennée wrote: > GCC has moved on and so should we. We also enable apt update to ensure > we get the latest build from the toolchain PPA. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > .travis.yml | 9 +

Re: [Qemu-devel] [PATCH v1 6/8] .travis.yml: make current setup explicit

2018-05-31 Thread Philippe Mathieu-Daudé
On 05/30/2018 08:06 AM, Alex Bennée wrote: > Add some commentary and make the selection of Container based Trusty > build explicit. We will need to add VM builds later when using docker. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > ---

Re: [Qemu-devel] [PATCH v1 1/8] .travis.yml: disable linux-user build for gcov

2018-05-31 Thread Philippe Mathieu-Daudé
On 05/30/2018 08:06 AM, Alex Bennée wrote: > Currently the default testing doesn't exercise the linux-user builds > so there is no point spending time building them. We may want to > enable a separate gcov build once linux-user testing is re-enabled > although it's likely to report very low coverag

Re: [Qemu-devel] [PATCH 03/13] 9p: Move a couple xattr functions to 9p-util

2018-05-31 Thread Keno Fischer
> I'm ok with this move, but if the functions need to have distinct > implementations, and they really do according to patch 10, then > I'd rather have distinct files and rely on conditional building in > the makefile. Maybe rename the current file to 9p-util-linux.c > and introduce a 9p-util-darwi

Re: [Qemu-devel] [PATCH 2/3] ahci: fix PxCI register race

2018-05-31 Thread John Snow
>From comments on the cover letter, I am adding: Fixes: https://bugs.launchpad.net/qemu/+bug/1769189 On 05/30/2018 08:43 PM, John Snow wrote: > AHCI presently signals completion prior to the PxCI register being > cleared to indicate completion. If a guest driver attempts to issue > a new command

Re: [Qemu-devel] [PATCH v1 4/8] docker: update Travis docker image

2018-05-31 Thread Philippe Mathieu-Daudé
Hi Alex, On 05/30/2018 08:06 AM, Alex Bennée wrote: > This is still poorly documented by Travis but according to: > > > https://docs.travis-ci.com/user/common-build-problems/#Running-a-Container-Based-Docker-Image-Locally > > their reference images are now hosted on Docker Hub. So we update t

Re: [Qemu-devel] [PATCH 05/13] 9p: darwin: Handle struct dirent differences

2018-05-31 Thread Keno Fischer
>> diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c >> index eb68b42..3c0a6d8 100644 >> --- a/hw/9pfs/9p-synth.c >> +++ b/hw/9pfs/9p-synth.c >> @@ -221,7 +221,11 @@ static void synth_direntry(V9fsSynthNode *node, >> { >> strcpy(entry->d_name, node->name); >> entry->d_ino = node->attr

Re: [Qemu-devel] [Qemu-block] [PATCH 2/3] ahci: fix PxCI register race

2018-05-31 Thread Jeff Cody
On Wed, May 30, 2018 at 08:43:22PM -0400, John Snow wrote: > AHCI presently signals completion prior to the PxCI register being > cleared to indicate completion. If a guest driver attempts to issue > a new command in its IRQ handler, it might be surprised to learn there > is still a command pending

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH

2018-05-31 Thread Jeff Cody
On Wed, May 30, 2018 at 08:43:23PM -0400, John Snow wrote: > The comment gives us a hint. *Maybe* we still have something to > process. Well, why not check? Heh :) Reviewed-by: Jeff Cody > > Signed-off-by: John Snow > --- > hw/ide/ahci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-31 Thread John Snow
On 05/30/2018 05:28 PM, Philippe Mathieu-Daudé wrote: > On 05/30/2018 05:17 PM, John Snow wrote: >> On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: >>> Hi John, >>> >>> On 05/25/2018 08:54 PM, John Snow wrote: A trace is added to let us watch unimplemented registers specifically,

Re: [Qemu-devel] [PATCH 07/13] 9p: darwin: Properly translate AT_REMOVEDIR flag

2018-05-31 Thread Keno Fischer
>> +errno = EINVAL; >> +return -1; > > ... I'm more concerned about this new error path. How can this happen ? > As far as I can tell, the flags come from the client without any intermediate error checking. Since the Darwin constants do not match the Linux constants (which have the

Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

2018-05-31 Thread Keno Fischer
>> --- a/hw/9pfs/9p-local.c >> +++ b/hw/9pfs/9p-local.c >> @@ -67,7 +67,10 @@ int local_open_nofollow(FsContext *fs_ctx, const char >> *path, int flags, >> assert(*path != '/'); >> >> head = g_strdup(path); >> -c = strchrnul(path, '/'); >> +/* equivalent to strchr

Re: [Qemu-devel] [PATCH] Fix hang with -L and symlink loop

2018-05-31 Thread Richard Henderson
On 05/31/2018 08:26 AM, Peter Maydell wrote: > On 30 May 2018 at 21:50, Richard Henderson > wrote: >> On 05/29/2018 04:44 PM, Evan Green wrote: >>> When using -L with Linux app emulation, there is an issue in >>> init_paths where Qemu will get lost exploring a directory tree >>> with a symlink lo

Re: [Qemu-devel] [PATCH 08/13] 9p: darwin: Ignore O_{NOATIME, DIRECT}

2018-05-31 Thread Keno Fischer
> > Please don't kill the spaces. > Sorry, will undo. My editor has strong opinions about styling. >> +#ifndef CONFIG_DARWIN >> +{P9_DOTL_NOATIME, O_NOATIME}, >> +/* On Darwin, we could map to F_NOCACHE, which is >> + similar, but doesn't quite have the same >> +

Re: [Qemu-devel] [PATCH 11/13] 9p: darwin: Mark mknod as unsupported

2018-05-31 Thread Keno Fischer
>> +#ifdef CONFIG_DARWIN >> +/* Darwin doesn't have mknodat and it's unlikely to work anyway, > > What's unlikely to work ? > My concern was that allowing this would cause unexpected behavior, since the device numbers will differ between OS X and Linux. Though maybe this isn't the place to wor

Re: [Qemu-devel] [PATCH] Fix hang with -L and symlink loop

2018-05-31 Thread Peter Maydell
On 31 May 2018 at 17:32, Richard Henderson wrote: > On 05/31/2018 08:26 AM, Peter Maydell wrote: >> On 30 May 2018 at 21:50, Richard Henderson >> wrote: >>> On 05/29/2018 04:44 PM, Evan Green wrote: When using -L with Linux app emulation, there is an issue in init_paths where Qemu will

[Qemu-devel] [Bug 1766904] Re: Creating high hdd load (with constant fsyncs) on a SATA disk leads to freezes and errors in guest dmesg

2018-05-31 Thread Jake
It's still possible to reproduce this issue with qemu-master (a3ac12fba028df90f7b3dbec924995c126c41022). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1766904 Title: Creating high hdd load (with co

[Qemu-devel] [PULL 05/53] memory: Do not include "exec/ioport.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git grep '#include "exec/ioport.h"' memory.c | \ cut -d: -f-1 | \ xargs egrep -Li "(portio|cpu_(in|out).\()" | \ xargs sed -i.bak '/#include "exec\/ioport.h"/d' Signed-off-by: Philippe Mathieu-Daudé Message-Id: <201

[Qemu-devel] [PULL 01/53] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-31 Thread Paolo Bonzini
From: Yi Min Zhao If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code regarding seccomp command line options to qemu-seccomp.c file and wr

[Qemu-devel] [PULL 02/53] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé No declaration of "hw/vfio/vfio-common.h" directly requires to include the "exec/address-spaces.h" header. To simplify dependencies and ease the upcoming cleanup of "exec/address-spaces.h", directly include it in the source file where the declaration are used. Signe

[Qemu-devel] [PULL 03/53] accel: Do not include "exec/address-spaces.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git grep '#include "exec/address-spaces.h"' accel | \ cut -d: -f-1 | \ xargs egrep -L "(get_system_|address_space_)" | \ xargs sed -i.bak '/#include "exec\/address-spaces.h"/d' Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 04/53] target: Do not include "exec/address-spaces.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git grep '#include "exec/address-spaces.h"' target | \ cut -d: -f-1 | \ xargs egrep -L "(get_system_|address_space_)" | \ xargs sed -i.bak '/#include "exec\/address-spaces.h"/d' Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 07/53] target/xtensa: Include "qemu/timer.h" to use NANOSECONDS_PER_SECOND

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Since d0ce7e9cfc the dc232b structure uses the NANOSECONDS_PER_SECOND definition from "qemu/timer.h". Include it to allow further includes cleanup. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-7-f4...@amsat.org> Acked-by: Michael S. Tsirki

[Qemu-devel] [PULL 15/53] hw: Do not include "sysemu/blockdev.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The header "hw/boards.h" already includes "sysemu/blockdev.h". Code change produced with: $ git grep '#include "sysemu/blockdev.h"' hw | \ cut -d: -f-1 | \ xargs fgrep -l '#include "hw/boards.h"' | \ xargs sed -i.bak '/#include "sysemu\/blockde

[Qemu-devel] [PULL 08/53] target/ppc: Include "exec/exec-all.h" which provides tlb_flush()

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Since it inception this include uses tlb_flush() declared in "exec/exec-all.h". Include the other header to allow further includes cleanup. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-8-f4...@amsat.org> Acked-by: Michael S. Tsirkin Signed

[Qemu-devel] [PULL 09/53] target/hppa: Include "qemu/log.h" to use qemu_log()

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Since his inception in 61766fe9e2d, this file uses the qemu_log() API from "qemu/log.h". Include it to allow further includes cleanup. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-9-f4...@amsat.org> Acked-by: Michael S. Tsirkin Signed-off

[Qemu-devel] [PULL 23/53] hw: Clean "hw/devices.h" includes

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-22-f4...@amsat.org> Acked-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- include/hw/devices.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/hw/devi

[Qemu-devel] [PULL 17/53] hw/block/nvme: Include "qemu/cutils.h" directly in the source file

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20180528232719.4721-16-f4...@amsat.org> Acked-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- hw/block/nvme.c | 1 + hw/block/nvme.h | 1 - 2 files changed, 1 insertion(+), 1 dele

[Qemu-devel] [PULL 00/53] Misc patches for 2018-05-31

2018-05-31 Thread Paolo Bonzini
The following changes since commit 5a5c383b1373aeb6c87a0d6060f6c3dc7c53082b: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-2.13-pull-request' into staging (2018-05-25 10:04:36 +0100) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upst

[Qemu-devel] [PULL 21/53] hw/i386/pc: Remove unused include

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-20-f4...@amsat.org> Acked-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc.c b/hw

[Qemu-devel] [PULL 24/53] qom: Document qom/device-list-properties implementation specific

2018-05-31 Thread Paolo Bonzini
From: Alexey Kardashevskiy The recently introduced qom-list-properties QMP command raised a question what properties it (and its cousin - device-list-properties) can possibly print - only those defined by DeviceClass::props or dynamically created in TypeInfo::instance_init() so properties created

[Qemu-devel] [PULL 06/53] target/i386: Do not include "exec/ioport.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git grep '#include "exec/ioport.h"' target | \ cut -d: -f-1 | \ xargs egrep -Li "(portio|cpu_(in|out).\()" | \ xargs sed -i.bak '/#include "exec\/ioport.h"/d' Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180

[Qemu-devel] [PULL 10/53] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git grep '#include "exec/exec-all.h"' | \ cut -d: -f-1 | \ xargs egrep -L "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)" | \ xargs sed -i.bak '/#include "exec\/exec-all.h"/d' Signed

[Qemu-devel] [PULL 20/53] hw/hppa: Remove unused include

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-19-f4...@amsat.org> Acked-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- hw/hppa/hppa_sys.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h i

[Qemu-devel] [PULL 12/53] hw: Do not include "exec/ioport.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git grep '#include "exec/ioport.h"' hw | \ cut -d: -f-1 | \ xargs egrep -Li "(portio|cpu_(in|out).\()" | \ xargs sed -i.bak '/#include "exec\/ioport.h"/d' Signed-off-by: Philippe Mathieu-Daudé Message-Id: <201805282

[Qemu-devel] [PULL 29/53] memory: delete struct AddressSpaceOps

2018-05-31 Thread Paolo Bonzini
From: Jay Zhou Since struct AddressSpaceOps isn't used anywhere else, so just delete it. Signed-off-by: Jay Zhou Message-Id: <1526384108-49348-1-git-send-email-jianjay.z...@huawei.com> Signed-off-by: Paolo Bonzini --- memory.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/memory.c b/me

[Qemu-devel] [PULL 36/53] qemu-options: Mark the non-functional -clock option as deprecated

2018-05-31 Thread Paolo Bonzini
From: Thomas Huth The function is only ignored since QEMU version 1.7.0. Let's mark it as deprecated, so that we can finally completely remove it soon. Signed-off-by: Thomas Huth Message-Id: <1526990298-17924-1-git-send-email-th...@redhat.com> Signed-off-by: Paolo Bonzini --- qemu-doc.texi |

Re: [Qemu-devel] [PATCH v13 04/12] migration: Calculate transferred ram correctly

2018-05-31 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > On multifd we send data from more places that main channel. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/migration/migration.c b/migration/migrat

[Qemu-devel] [PULL 33/53] exec.c: Initialize sa_flags passed to sigaction()

2018-05-31 Thread Paolo Bonzini
From: Peter Maydell Coverity points out that in the user-only version of cpu_abort() we call sigaction() with a partially initialized struct sigaction (CID 1005351). Correct the omission. Signed-off-by: Peter Maydell Message-Id: <20180515182700.31736-1-peter.mayd...@linaro.org> Signed-off-by: P

[Qemu-devel] [PULL 11/53] nios2: do not include exec-all.h from cpu.h

2018-05-31 Thread Paolo Bonzini
exec-all.h contains TCG-specific declarations, it should only be includer from helper C files. Signed-off-by: Paolo Bonzini --- target/nios2/cpu.h | 1 - target/nios2/op_helper.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h ind

[Qemu-devel] [PULL 16/53] hw: Do not include "sysemu/blockdev.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Remove those unneeded includes to speed up the compilation process a little bit. Code change produced with: $ git grep '#include "sysemu/blockdev.h"' | \ cut -d: -f-1 | \ xargs egrep -L "(BlockInterfaceType|DriveInfo|drive_get|blk_legacy_dinfo|block

[Qemu-devel] [PULL 19/53] hw/misc/sga: Use the correct ISA include

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The SGA BIOS loader is an ISA device, it does not require the PCI header. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-18-f4...@amsat.org> Acked-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum Signed-off-by: Paolo Bonzini --- hw/mis

[Qemu-devel] [PULL 32/53] memfd: Avoid Coverity warning about integer overflow

2018-05-31 Thread Paolo Bonzini
From: Peter Maydell Coverity complains about qemu_memfd_create() (CID 1385858) because we calculate a bit position htsize which could be up to 63, but then use it in "1 << htsize" which is a 32-bit integer calculation and could push the 1 off the top of the value. Silence the complaint bu using

[Qemu-devel] [PULL 13/53] hw: Do not include "exec/address-spaces.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git grep '#include "exec/address-spaces.h"' hw include/hw | \ cut -d: -f-1 | \ xargs egrep -L "(get_system_|address_space_)" | \ xargs sed -i.bak '/#include "exec\/address-spaces.h"/d' Signed-off-by: Philippe Mathieu

[Qemu-devel] [PULL 34/53] WHPX: dynamically load WHP libraries

2018-05-31 Thread Paolo Bonzini
From: Lucian Petrut We're currently linking against import libraries of the WHP DLLs. By dynamically loading the libraries, we ensure that QEMU will work on previous Windows versions, where the WHP DLLs will be missing (assuming that WHP is not requested). Also, we're simplifying the build proc

[Qemu-devel] [PULL 14/53] hw: Do not include "sysemu/block-backend.h" if it is not necessary

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Remove those unneeded includes to speed up the compilation process a little bit. (Continue 7eceff5b5a1fa cleanup) Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-13-f4...@amsat.org> Acked-by: Michael S. Tsirkin Acked-by: Cornelia Huck Signed

[Qemu-devel] [PULL 18/53] hw/misc/mips_itu: Cleanup includes

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180528232719.4721-17-f4...@amsat.org> Acked-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- hw/misc/mips_itu.c | 5 + include/hw/misc/mips_itu.h | 2 ++ 2 files changed, 3 insertions(+), 4 de

[Qemu-devel] [PULL 43/53] scripts/update-linux-headers: Handle __aligned_u64

2018-05-31 Thread Paolo Bonzini
From: Peter Maydell We'll currently replace any 'u64' with a 'uint64_t' including when it's embedded in an '__aligned_u64', creating a '__aligned_uint64_t' which doesn't exist. We need to instead expand out the kernel's definition of __aligned_u64: #define __aligned_u64 __u64 __attribute__((al

[Qemu-devel] [PULL 47/53] target/i386/kvm.c: Remove compatibility shim for KVM_HINTS_REALTIME

2018-05-31 Thread Paolo Bonzini
From: Peter Maydell Now we've updated our copy of the kernel headers we can remove the compatibility shim that handled KVM_HINTS_REALTIME not being defined. Signed-off-by: Peter Maydell Message-Id: <20180525132755.21839-7-peter.mayd...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 37/53] tcg: remove softfloat from --disable-tcg builds

2018-05-31 Thread Paolo Bonzini
Even though the presence of softfloat does not cause --disable-tcg builds to fail, it is the single largest .o file in them. Remove it, since TCG is the only client. Acked-by: Richard Henderson Signed-off-by: Paolo Bonzini --- Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[Qemu-devel] [PULL 42/53] virtio-gpu-3d: Define VIRTIO_GPU_CAPSET_VIRGL2 elsewhere

2018-05-31 Thread Paolo Bonzini
From: Alex Williamson Commit 5643cc94ac1c ("virtio-gpu-3d: add support for second capability set (v4)") updated virtio_gpu.h with a define that does not yet(?) exist upstream resulting in build breakage every time Linux headers are updated via the standard update script. Conditionally define thi

[Qemu-devel] [PULL 48/53] hw/i2c/smbus: Use DeviceClass::realize instead of SMBusDeviceClass::init

2018-05-31 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé SMBusDeviceClass::init is no more used, remove it. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180419212727.26095-2-f4...@amsat.org> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Message-Id: <20180528144509.15812-2-arm...@redhat.com> Sig

[Qemu-devel] [PULL 28/53] memory: get rid of memory_region_init_reservation

2018-05-31 Thread Paolo Bonzini
The function has been deprecated for 2.5 years, and there are just a handful of users. Convert them to memory_region_init_io with NULL callbacks, and while at it pass the right device as the owner. Signed-off-by: Paolo Bonzini --- docs/devel/memory.txt | 5 ++--- hw/i386/kvm/i8254.c | 2 +-

[Qemu-devel] [PULL 45/53] target/i386/kvm.c: Handle renaming of KVM_HINTS_DEDICATED

2018-05-31 Thread Paolo Bonzini
From: Peter Maydell In kernel header commit 633711e8287, the define KVM_HINTS_DEDICATED was renamed to KVM_HINTS_REALTIME. Work around this compatibility break by (a) using the new constant name, and (b) defining it if the headers don't. Part (b) can be removed once we've updated our copy of the

<    1   2   3   4   >