On 05/31/2018 10:56 AM, Eric Blake wrote: > On 05/30/2018 07:43 PM, John Snow wrote: >> These functions work on the AHCI device, not the individual > > s/device/state/ ? > It's confusing; the AHCI device itself (the HBA) is represented by the struct AHCIState. the SATA devices are referred to by "AHCIDevice". Not great names, admittedly. --js >> AHCI devices, so trim the AHCIDevice argument. >> >> Signed-off-by: John Snow <js...@redhat.com> >> --- >> hw/ide/ahci.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >
- [Qemu-devel] [PATCH 0/3] ahci: fix completion race... John Snow
- [Qemu-devel] [PATCH 3/3] ahci: don't schedule... John Snow
- [Qemu-devel] [PATCH 2/3] ahci: fix PxCI regis... John Snow
- [Qemu-devel] [PATCH 1/3] ahci: trim signature... John Snow
- Re: [Qemu-devel] [PATCH 1/3] ahci: trim s... Eric Blake
- Re: [Qemu-devel] [PATCH 1/3] ahci: tr... John Snow
- Re: [Qemu-devel] [Qemu-block] [PATCH 1/3]... Jeff Cody
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] ahc... Stefan Hajnoczi
- Re: [Qemu-devel] [PATCH 0/3] ahci: fix comple... Bruce Rogers
- Re: [Qemu-devel] [PATCH 0/3] ahci: fix co... Philippe Mathieu-Daudé
- Re: [Qemu-devel] [PATCH 0/3] ahci: fi... Bruce Rogers
- Re: [Qemu-devel] [PATCH 0/3] ahci: fix comple... John Snow
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/3]... Stefan Hajnoczi