Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-05-14 Thread Alexey Kardashevskiy
On 13/3/18 6:44 pm, Samuel Thibault wrote: > Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: >> Signed-off-by: Alexey Kardashevskiy > > Applied to my tree, thanks! And what is your tree, is this something to be merged sometime later somewhere? :) > >> --- >> >> checkpatch.

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-05-14 Thread Samuel Thibault
Alexey Kardashevskiy, le lun. 14 mai 2018 17:00:08 +1000, a ecrit: > On 13/3/18 6:44 pm, Samuel Thibault wrote: > > Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: > >> Signed-off-by: Alexey Kardashevskiy > > > > Applied to my tree, thanks! > > > And what is your tree, is this

Re: [Qemu-devel] [PATCH 2/2] migration: not wait RDMA_CM_EVENT_DISCONNECTED event after rdma_disconnect

2018-05-14 Thread 858585 jemmy
On Sat, May 12, 2018 at 2:03 AM, Dr. David Alan Gilbert wrote: > * 858585 jemmy (jemmy858...@gmail.com) wrote: >> On Wed, May 9, 2018 at 2:40 AM, Dr. David Alan Gilbert >> wrote: >> > * Lidong Chen (jemmy858...@gmail.com) wrote: >> >> When cancel migration during RDMA precopy, the source qemu mai

[Qemu-devel] [PATCH qemu v2] qom: Document qom/device-list-properties implementation specific

2018-05-14 Thread Alexey Kardashevskiy
The recently introduced qom-list-properties QMP command raised a question what properties it (and its cousin - device-list-properties) can possibly print - only those defined by DeviceClass::props or dynamically created in TypeInfo::instance_init() so properties created elsewhere won't show up and

[Qemu-devel] [PULL 2/4] net: Remove the deprecated "vlan" parameter

2018-05-14 Thread Jason Wang
From: Thomas Huth It's been marked as deprecated since QEMU v2.9.0, so that should have been enough time for everybody to either just drop unnecessary "vlan=0" parameters, to switch to the modern -device + -netdev syntax for connecting guest NICs with host network backends, or to switch to the "h

[Qemu-devel] [PULL 0/4] Net patches

2018-05-14 Thread Jason Wang
The following changes since commit c74e62ee3e2dc2955e07d004c71badecb68a84eb: Merge remote-tracking branch 'remotes/rth/tags/cota-target-pull-request' into staging (2018-05-11 15:41:29 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request

[Qemu-devel] [PULL 1/4] net: Fix memory leak in net_param_nic()

2018-05-14 Thread Jason Wang
From: Thomas Huth The early exits in case of errors leak the memory allocated for nd_id. Fix it by using a "goto out" to the cleanup at the end of the function instead. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- ne

Re: [Qemu-devel] [PATCH v4 0/3] net: Get rid of 'vlan'

2018-05-14 Thread Jason Wang
On 2018年05月03日 20:21, Stefan Hajnoczi wrote: On Mon, Apr 30, 2018 at 08:02:22PM +0200, Thomas Huth wrote: The 'vlan' term caused a lot of confusion and misconfigurations in the past. The parameter has been marked as deprecated since QEMU v2.9.0, so it's now time to finally remove the parameter

[Qemu-devel] [PULL 4/4] net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files

2018-05-14 Thread Jason Wang
From: Thomas Huth 'vlan' is very confusing since it does not mean something like IEEE 802.1Q, but rather emulated hubs, so let's switch to that terminology instead. While we're at it, move the subsection about hub a little bit downward in the documentation (it's not as important anymore as it was

[Qemu-devel] [PULL 3/4] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files

2018-05-14 Thread Jason Wang
From: Thomas Huth 'vlan' is very confusing since it does not mean something like IEEE 802.1Q, but rather emulated hubs, so let's switch to that terminology instead. Buglink: https://bugs.launchpad.net/qemu/+bug/658904 Reviewed-by: Stefan Hajnoczi Signed-off-by: Thomas Huth Signed-off-by: Jason

Re: [Qemu-devel] [PATCH 4/4] audio/hda: detect output buffer overruns and underruns

2018-05-14 Thread Gerd Hoffmann
On Fri, May 11, 2018 at 11:25:37AM +0200, KONRAD Frederic wrote: > > > On 04/25/2018 03:05 PM, Gerd Hoffmann wrote: > > On Mon, Apr 23, 2018 at 11:31:34AM +0200, KONRAD Frederic wrote: > > > > > > > > > On 04/19/2018 03:10 PM, Gerd Hoffmann wrote: > > > > If some event caused some larger playba

Re: [Qemu-devel] [PATCH v2 2/2] blockjob: do not cancel timer in resume

2018-05-14 Thread QingFeng Hao
在 2018/5/8 21:54, Stefan Hajnoczi 写道: > Currently the timer is cancelled and the block job is entered by > block_job_resume(). This behavior causes drain to run extra blockjob > iterations when the job was sleeping due to the ratelimit. > > This patch leaves the job asleep when block_job_resume

Re: [Qemu-devel] [PATCH V7 00/17] COLO: integrate colo frame with block replication and COLO proxy

2018-05-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1526268228-27951-1-git-send-email-zhangc...@gmail.com Subject: [Qemu-devel] [PATCH V7 00/17] COLO: integrate colo frame with block replication and COLO proxy === TEST SCRIPT

Re: [Qemu-devel] [PATCH v5 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-05-14 Thread Markus Armbruster
Markus Armbruster writes: > Daniel Henrique Barboza writes: > >> Ping > > Michael, you reviewed v4 (at least in part), can you have a look? Have these patches fallen through the cracks?

Re: [Qemu-devel] [PULL 00/21] target-arm queue

2018-05-14 Thread Peter Maydell
On 10 May 2018 at 18:44, Peter Maydell wrote: > The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2018-05-08 17:05:58 +0100) > > are available in the Git repository at: > > git:/

Re: [Qemu-devel] [RFC 00/10] [TESTING NEEDED] python: futurize --stage1 (Python 3 compatibility)

2018-05-14 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > TESTING NEEDED: Due to the amount of changes, I didn't test all > scripts touched by this series. If you are responsible for any > of the touched files, I would appreciate help on testing the > series. Running the 'analyze-migration.py' script on a

Re: [Qemu-devel] [PULL 00/13] openrisc: Covert to decodetree.py

2018-05-14 Thread Peter Maydell
On 11 May 2018 at 05:23, Richard Henderson wrote: > Stafford Horne has acked and asked that I send the pull-request. > > > r~ > > > The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging

Re: [Qemu-devel] ping latency issue on passthrough guest

2018-05-14 Thread Zhu Yijun
Hi Alex, Thanks for your reply, I will try to assign PF to VM and test. 2018-05-11 22:26 GMT+08:00 Alex Williamson : > On Fri, 11 May 2018 15:20:05 +0800 > Zhu Yijun wrote: > >> Hi all, >> >> I booted two sr-iov guests using KVM-VFIO and pinged each other with >> no-load one night. I found

Re: [Qemu-devel] ping latency issue on passthrough guest

2018-05-14 Thread Zhu Yijun
Hi Alexey, thanks for your advise. 2018-05-14 14:13 GMT+08:00 Alexey Kardashevskiy : > On 11/5/18 5:20 pm, Zhu Yijun wrote: >> Hi all, >> >> I booted two sr-iov guests using KVM-VFIO and pinged each other with >> no-load one night. I found that most of the latency was little than 0.1ms, >> but s

Re: [Qemu-devel] [PATCH v2 04/17] pc: route all memory devices through the machine hotplug handler

2018-05-14 Thread David Hildenbrand
On 12.05.2018 16:47, Paolo Bonzini wrote: > On 11/05/2018 15:19, David Hildenbrand wrote: >> +if (dev->parent_bus) { >> +if (object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE)) { >> +return HOTPLUG_HANDLER(machine); >> +} >> +} >> + > > How do you get here wit

Re: [Qemu-devel] [PATCH v1] s390x: refactor reset/reipl handling

2018-05-14 Thread Cornelia Huck
On Tue, 24 Apr 2018 12:18:59 +0200 David Hildenbrand wrote: > Calling pause_all_vcpus()/resume_all_vcpus() from a VCPU thread might > not be the best idea. As pause_all_vcpus() temporarily drops the qemu > mutex, two parallel calls to pause_all_vcpus() can be active at a time, > resulting in a de

Re: [Qemu-devel] Requiring Python 2.7+ (was Re: [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42)

2018-05-14 Thread Daniel P . Berrangé
On Fri, May 11, 2018 at 07:48:23PM -0300, Eduardo Habkost wrote: > On Fri, May 04, 2018 at 05:00:23PM +0100, Daniel P. Berrangé wrote: > [...] > > Based on that doc and https://repology.org/metapackage/glib/versions, > > I identified that we could feasibly set min glib to 2.42. Note that > > this w

Re: [Qemu-devel] Requiring Python 2.7+ (was Re: [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42)

2018-05-14 Thread Peter Maydell
On 14 May 2018 at 10:33, Daniel P. Berrangé wrote: > On Fri, May 11, 2018 at 07:48:23PM -0300, Eduardo Habkost wrote: >> On Fri, May 04, 2018 at 05:00:23PM +0100, Daniel P. Berrangé wrote: >> [...] >> > Based on that doc and https://repology.org/metapackage/glib/versions, >> > I identified that we

Re: [Qemu-devel] [PATCH v2 0/2] xen-hvm: use new resource mapping API

2018-05-14 Thread Paul Durrant
Anthony, Stefano, Ping? I'd like to get your feedback before spinning a v3 to incorporate Eric's suggestion regarding the commit comment for #2. Paul > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 10 May 2018 10:15 > To: qemu-devel@nongnu.org; xen-

Re: [Qemu-devel] Restoring bitmaps after failed/cancelled migration

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
12.05.2018 00:23, John Snow wrote: On 04/18/2018 10:00 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. We now have the following problem: If dirty-bitmaps migration capability is enabled, persistance flag is dropped for all migrated bitmaps, to prevent their storing to the storage on inactiva

[Qemu-devel] [PATCH v3 01/18] memory-device: drop assert related to align and start of address space

2018-05-14 Thread David Hildenbrand
The start of the address space does not have to be aligned for the search. Handle this case explicitly when starting the search for a new address. Signed-off-by: David Hildenbrand --- hw/mem/memory-device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/mem/memory-devic

[Qemu-devel] [PATCH v3 03/18] qdev: let machine hotplug handler to override bus hotplug handler

2018-05-14 Thread David Hildenbrand
From: Igor Mammedov it will allow to return another hotplug handler than the default one for a specific bus based device type. Which is needed to handle non trivial plug/unplug sequences that need the access to resources configured outside of bus where device is attached. That will allow for ret

[Qemu-devel] [PATCH v3 00/18] MemoryDevice: use multi stage hotplug handlers

2018-05-14 Thread David Hildenbrand
We can have devices that need certain other resources that are e.g. system resources managed by the machine. We need a clean way to assign these resources (without violating layers as brought up by Igor). One example is virtio-mem/virtio-pmem. Both device types need to be assigned some region in g

[Qemu-devel] [PATCH v3 02/18] memory-device: introduce separate config option

2018-05-14 Thread David Hildenbrand
Some architectures might support memory devices, while they don't support DIMM/NVDIMM. So let's - Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE - Intriduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM CONFIG_DIMM and CONFIG_NVDIMM require CONFIG_MEM_DEVICE. Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v3 04/18] pc: prepare for multi stage hotplug handlers

2018-05-14 Thread David Hildenbrand
For multi stage hotplug handlers, we'll have to do some error handling in some hotplug functions, so let's use a local error variable (except for unplug requests). Also, add code to pass control to the final stage hotplug handler at the parent bus. Signed-off-by: David Hildenbrand --- hw/i386/p

[Qemu-devel] [PATCH v3 05/18] pc: route all memory devices through the machine hotplug handler

2018-05-14 Thread David Hildenbrand
Necessary to hotplug them cleanly later. We could drop the PC_DIMM check, as PC_DIMM are just memory devices, but this approach is cleaner. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 510076e156..8bc41e

[Qemu-devel] [PATCH v3 06/18] spapr: prepare for multi stage hotplug handlers

2018-05-14 Thread David Hildenbrand
For multi stage hotplug handlers, we'll have to do some error handling in some hotplug functions, so let's use a local error variable (except for unplug requests). Also, add code to pass control to the final stage hotplug handler at the parent bus. Signed-off-by: David Hildenbrand --- hw/ppc/sp

[Qemu-devel] [PATCH v3 09/18] spapr: handle cpu core unplug via hotplug handler chain

2018-05-14 Thread David Hildenbrand
Let's handle it via hotplug_handler_unplug(). Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 286c38c842..13d153b5a6 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -34

[Qemu-devel] [PATCH v3 11/18] pc-dimm: implement new memory device functions

2018-05-14 Thread David Hildenbrand
Implement the new functions, we don't have to care about alignment for these DIMMs right now, so leave that function unimplemented. Signed-off-by: David Hildenbrand --- hw/mem/pc-dimm.c | 17 + 1 file changed, 17 insertions(+) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c ind

[Qemu-devel] [PATCH v3 07/18] spapr: route all memory devices through the machine hotplug handler

2018-05-14 Thread David Hildenbrand
Necessary to hotplug them cleanly later. Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index b7c5c95f7a..2f315f963b 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3666,6 +3666,7 @@ static HotplugHandl

[Qemu-devel] [PATCH v3 10/18] memory-device: new functions to handle plug/unplug

2018-05-14 Thread David Hildenbrand
We will need a handful of new functions: - set_addr(): To set the calculated address - get_memory_region(): To add it to the memory region container - get_addr(): If the device has any specific alignment requirements Using these and the existing functions, we can properly plug/unplug memory device

[Qemu-devel] [PATCH v3 17/18] s390x: initialize memory region for memory devices

2018-05-14 Thread David Hildenbrand
While s390x has no real interface for communicating devices mapped into the physical address space of the guest, paravirtualized devices can easily expose the applicable address range themselves. So let's use the difference between maxram_size and ram_size as the size for our hotplug memory area (

[Qemu-devel] [PATCH v3 08/18] spapr: handle pc-dimm unplug via hotplug handler chain

2018-05-14 Thread David Hildenbrand
Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/ unplug memory devices (which a pc-dimm is) later. Signed-off-by: David Hildenbrand --- hw/ppc/spapr.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spap

[Qemu-devel] [PATCH v3 12/18] memory-device: factor out pre-plug into hotplug handler

2018-05-14 Thread David Hildenbrand
Let's move all pre-plug checks we can do without the device being realized into the applicable hotplug handler for pc and spapr. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 11 +++ hw/mem/memory-device.c | 72 +++--- hw/pp

[Qemu-devel] [PATCH v3 13/18] memory-device: factor out unplug into hotplug handler

2018-05-14 Thread David Hildenbrand
Let's move the unplug logic into the applicable hotplug handler for pc and spapr. We'll move the plug logic next, then this will look more symmetrical in the hotplug handlers. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 17 - hw/mem/memory-device.c

[Qemu-devel] [PATCH v3 14/18] memory-device: factor out plug into hotplug handler

2018-05-14 Thread David Hildenbrand
Let's move the plug logic into the applicable hotplug handler for pc and spapr. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 35 --- hw/mem/memory-device.c | 40 ++-- hw/mem/pc-dimm.c

[Qemu-devel] [PATCH v3 15/18] s390x/sclp: make sure ram_size and maxram_size stay in sync

2018-05-14 Thread David Hildenbrand
On s390x, we sometimes have to shrink ram_size in order to be able to correctly indicate the size to the guest. In case maxmem is not set, ram_size and maxram_size should always be kept equal. Make sure to also fixup maxram_size if necessary. In case maxmem is set, we really want to bail out in c

[Qemu-devel] [PATCH v3 16/18] s390x: prepare for multi stage hotplug handlers

2018-05-14 Thread David Hildenbrand
For multi stage hotplug handlers, we'll have to do some error handling in some hotplug functions, so let's use a local error variable (except for unplug requests). Also, add code to pass control to the final stage hotplug handler at the parent bus. Signed-off-by: David Hildenbrand --- hw/s390x/

Re: [Qemu-devel] [PATCH 02/42] blockjob: Wrappers for progress counter access

2018-05-14 Thread Kevin Wolf
Am 12.05.2018 um 00:12 hat Max Reitz geschrieben: > On 2018-05-09 18:25, Kevin Wolf wrote: > > Block job drivers are not expected to mess with the internals of the > > BlockJob object, so provide wrapper functions for one of the cases where > > they still do it: Updating the progress counter. > >

Re: [Qemu-devel] Restoring bitmaps after failed/cancelled migration

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
14.05.2018 09:41, Fam Zheng wrote: On Wed, 04/18 17:00, Vladimir Sementsov-Ogievskiy wrote: Hi all. We now have the following problem: If dirty-bitmaps migration capability is enabled, persistance flag is dropped for all migrated bitmaps, to prevent their storing to the storage on inactivate.

[Qemu-devel] [PATCH v3 18/18] s390x: support memory devices

2018-05-14 Thread David Hildenbrand
Let's route all memory devices we can hotplug through the machine hotplug handler, just like on pc and spapr. As CONFIG_DIMM is not enabled, we won't ever try to plug DIMMs. Signed-off-by: David Hildenbrand --- default-configs/s390x-softmmu.mak | 1 + hw/s390x/s390-virtio-ccw.c| 31 +++

Re: [Qemu-devel] [PULL v2 00/29] Misc patches for 2018-05-09

2018-05-14 Thread Peter Maydell
On 11 May 2018 at 13:36, Paolo Bonzini wrote: > The following changes since commit cc8f8ba754bba17eea9791d67b572eb26e30b4ce: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-05-08 > 15:25:17 +0100) > > are available in the git repository a

Re: [Qemu-devel] [PATCH v2 01/27] fpu/softfloat: int_to_float ensure r fully initialised

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > From: Alex Bennée > > Reported by Coverity (CID1390635). We ensure this for uint_to_float > later on so we might as well mirror that. > > Signed-off-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 2 +- > 1 file c

Re: [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0

2018-05-14 Thread Cornelia Huck
On Fri, 11 May 2018 21:59:43 -0700 Richard Henderson wrote: > The warning is > > target/s390x/misc_helper.c:209:21: error: suggest > braces around initialization of subobject [-Werror,-Wmissing-braces] > SysIB sysib = { 0 }; > ^ > {} > > While t

Re: [Qemu-devel] [PATCH v5 0/3] linux-headers: arch fixups

2018-05-14 Thread Peter Maydell
On 11 May 2018 at 22:32, Michael S. Tsirkin wrote: > It turns out that we have unistd.h and kvm headers for some > architectures but not others. We are thus unable to use e.g. usefaultfd > on these systems unless system headers have been updated. > > Fix up update-linux-headers.sh to make sure we

Re: [Qemu-devel] [PATCH v2 02/27] fpu/softfloat: Don't set Invalid for float-to-int(MAXINT)

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > From: Peter Maydell > > In float-to-integer conversion, if the floating point input > converts exactly to the largest or smallest integer that > fits in to the result type, this is not an overflow. > In this situation we were producing the corre

Re: [Qemu-devel] [PATCH v2 04/27] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > The new function assumes that the input is an SNaN and > does not double-check. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > fpu/softfloat-specialize.h | 174 + > include/fpu/softf

Re: [Qemu-devel] [PATCH v2 03/27] fpu/softfloat: Merge NO_SIGNALING_NANS definitions

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > Move the ifdef inside the relevant functions instead of > duplicating the function declarations. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > fpu/softfloat-specialize.h | 100 +++-- >

Re: [Qemu-devel] Restoring bitmaps after failed/cancelled migration

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
14.05.2018 13:09, Vladimir Sementsov-Ogievskiy wrote: 14.05.2018 09:41, Fam Zheng wrote: On Wed, 04/18 17:00, Vladimir Sementsov-Ogievskiy wrote: Hi all. We now have the following problem: If dirty-bitmaps migration capability is enabled, persistance flag is dropped for all migrated bitmaps,

Re: [Qemu-devel] [PATCH v2 05/27] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > We want to be able to specialize on the canonical representation. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff -

[Qemu-devel] [PATCH] xen_pt: Present the size of 64 bit BARs correctly

2018-05-14 Thread Ross Lagerwall
The full size of the BAR is stored in the lower PCIIORegion.size. The upper PCIIORegion.size is 0. Calculate the size of the upper half correctly from the lower half otherwise the size read by the guest will be incorrect. Signed-off-by: Ross Lagerwall --- hw/xen/xen_pt_config_init.c | 2 ++ 1 f

Re: [Qemu-devel] [PATCH v2 06/27] fpu/softfloat: Canonicalize NaN fraction

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > Shift the NaN fraction to a canonical position, much like we do > for the fraction of normal numbers. Immediately, this simplifies > the float-to-float conversion. Later, this will facilitate > manipulation of NaNs within the shared code paths.

Re: [Qemu-devel] [PATCH v9 4/9] block: introduce BDRV_REQ_ALLOCATE flag

2018-05-14 Thread Alberto Garcia
On Tue 08 May 2018 04:58:11 PM CEST, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. > > The call with the flag set must return -ENOTSUP if allocation cannot > be done efficiently. > This has to be m

[Qemu-devel] [PATCH] vga: catch depth 0

2018-05-14 Thread Gerd Hoffmann
depth == 0 is used to indicate 256 color modes. Our region calculation goes wrong in that case. So detect that and just take the safe code path we already have for the wraparound case. While being at it also catch depth == 15 (where our region size calculation goes wrong too). And make the comm

Re: [Qemu-devel] [PATCH v2 07/27] fpu/softfloat: Introduce parts_is_snan_frac

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > fpu/softfloat-specialize.h | 15 +++ > fpu/softfloat.c| 12 ++-- > 2 files changed, 17 insertions(+), 10 deletions(-) > > diff --git a/fpu/softfloat-specialize.h b/fpu/sof

Re: [Qemu-devel] [PATCH v3 18/18] s390x: support memory devices

2018-05-14 Thread David Hildenbrand
On 14.05.2018 12:00, David Hildenbrand wrote: > Let's route all memory devices we can hotplug through the machine hotplug > handler, just like on pc and spapr. > > As CONFIG_DIMM is not enabled, we won't ever try to plug DIMMs. > > Signed-off-by: David Hildenbrand > --- > default-configs/s390x-

Re: [Qemu-devel] [PATCH v2 08/27] fpu/softfloat: Replace float_class_dnan with parts_default_nan

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > With a canonical representation of NaNs, we can return the > default nan directly rather than delay the expansion until > the final format is known. > > Note one case where we uselessly assigned to a.sign, which was > overwritten/ignored later wh

Re: [Qemu-devel] [PATCH v2 09/27] fpu/softfloat: Replace float_class_msnan with parts_silence_nan

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > With a canonical representation of NaNs, we can silence an SNaN > immediately rather than delay until the final format is known. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat-specialize.h | 23 ++ > fpu/softfloa

Re: [Qemu-devel] [PATCH 10/42] job: Add JobDriver.job_type

2018-05-14 Thread Kevin Wolf
Am 12.05.2018 um 00:53 hat Max Reitz geschrieben: > On 2018-05-09 18:26, Kevin Wolf wrote: > > This moves the job_type field from BlockJobDriver to JobDriver. > > > > Signed-off-by: Kevin Wolf > > --- > > include/block/blockjob_int.h | 3 --- > > include/qemu/job.h | 11 +++ >

Re: [Qemu-devel] [RFC PATCH 00/12] qemu-img: add bitmap queries

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
12.05.2018 04:25, John Snow wrote: Allow qemu-img to show information about bitmaps stored in qcow2 images. Add a 'bitmap' meta-command with 'dump' sub-command to retrieve a list of dirty regions in bitmaps stored in a qcow2 image. RFC: - I am not 1000% convinced the bm_list caching is perfectly

Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: post-QEMU 2.12 fixes for 185

2018-05-14 Thread Jeff Cody
On Tue, May 08, 2018 at 02:54:34PM +0100, Stefan Hajnoczi wrote: > v2: > * Rebase onto Jeff's block tree to get mirror ratelimit fix [Jeff, Vladimir] > * Update comments in 185 since drain no longer causes a spurious iteration > > The 185 qemu-iotests test case was in a bad state for the QEMU 2.

Re: [Qemu-devel] [PATCH v9 6/9] file-posix: support BDRV_REQ_ALLOCATE

2018-05-14 Thread Alberto Garcia
On Tue 08 May 2018 04:58:13 PM CEST, Anton Nefedov wrote: > Current write_zeroes implementation is good enough to satisfy this flag too > > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC PATCH 01/12] qcow2-bitmap: cache bm_list

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
12.05.2018 04:25, John Snow wrote: We don't need to re-read this list every time, exactly. We can keep it cached and delete our copy when we flush to disk. Why not simply delete cache only on close (unconditionally)? Why do we need to remove it after flush? Actually, I think we need to remov

[Qemu-devel] [PATCH] cpus: remove useless cond signal

2018-05-14 Thread linzhecheng
commit dbadee4 removed qemu_cond_wait in cpu_remove_sync, so it is useless to keep qemu_cond_signal here. Signed-off-by: linzhecheng diff --git a/cpus.c b/cpus.c index 5bcd3ecf38..c7262484f3 100644 --- a/cpus.c +++ b/cpus.c @@ -1222,7 +1222,6 @@ static void *qemu_kvm_cpu_thread_fn(void *arg)

Re: [Qemu-devel] [RFC PATCH 01/12] qcow2-bitmap: cache bm_list

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
14.05.2018 14:55, Vladimir Sementsov-Ogievskiy wrote: 12.05.2018 04:25, John Snow wrote: We don't need to re-read this list every time, exactly. We can keep it cached and delete our copy when we flush to disk. Why not simply delete cache only on close (unconditionally)? Why do we need to rem

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2018-05-14 Thread Peter Maydell
On 11 May 2018 at 19:28, Stefan Hajnoczi wrote: > The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2018-05-08 17:05:58 +0100) > > are available in the Git repository at: > > git

Re: [Qemu-devel] [PATCH 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-14 Thread Cornelia Huck
On Thu, 10 May 2018 02:07:11 +0200 Halil Pasic wrote: > There is at least one control program (guest) that although it does not I'd drop 'control program' here as well, as it probably confuses more than helps. > rely on the guarantees provided by ORB 1 word 9 bit (aka unlimited > prefetch, aka

Re: [Qemu-devel] [PATCH] cpus: remove useless cond signal

2018-05-14 Thread Peter Maydell
On 14 May 2018 at 12:55, linzhecheng wrote: > commit dbadee4 removed qemu_cond_wait in cpu_remove_sync, so it is > useless to keep qemu_cond_signal here. > > Signed-off-by: linzhecheng > > diff --git a/cpus.c b/cpus.c > index 5bcd3ecf38..c7262484f3 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1222,

Re: [Qemu-devel] [PATCH 2/2] vfio-ccw: remove orb.c64 (64 bit data addresses) check

2018-05-14 Thread Cornelia Huck
On Thu, 10 May 2018 02:07:12 +0200 Halil Pasic wrote: > The vfio-ccw module does the check too, and there is actually no > technical obstacle for supporting fmt 1 idaws. Let us be ready for the > beautiful day when fmt 1 idaws become supported by the vfio-ccw kernel > module. QEMU does not have t

Re: [Qemu-devel] [RFC PATCH 02/12] qcow2/dirty-bitmap: cache loaded bitmaps

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
12.05.2018 04:25, John Snow wrote: For bitmaps that we succeeded in loading, we can cache a reference to that object. This will let us iterate over the more convenient form of in-memory bitmaps for qemu-img bitmap manipulation tools. Signed-off-by: John Snow --- block/qcow2-bitmap.c | 1 + 1

[Qemu-devel] [PATCH v3] qemu-ga: make get-fsinfo work over pci bridges

2018-05-14 Thread Marc-André Lureau
Iterate over the PCI bridges to lookup the PCI device associated with the block device. This allows to lookup the driver under the following syspath: /sys/devices/pci:00/:00:02.2/:03:00.0/virtio2/block/vda/vda3 It also works with an "old-style" Q35 libvirt hierarchy: root complex -> D

Re: [Qemu-devel] [PATCH 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-14 Thread Halil Pasic
On 05/14/2018 02:18 PM, Cornelia Huck wrote: On Thu, 10 May 2018 02:07:11 +0200 Halil Pasic wrote: There is at least one control program (guest) that although it does not I'd drop 'control program' here as well, as it probably confuses more than helps. Will do (everywhere). rely on th

Re: [Qemu-devel] [RFC PATCH 03/12] block/qcow2-bitmap: avoid adjusting bm->flags for RO bitmaps

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
12.05.2018 04:25, John Snow wrote: Instead of always setting IN_USE, handle whether or not the bitmap is read-only instead of a two-loop pass. This will allow us to show the flags exactly as they appear for bitmaps in `qemu-img info`. Signed-off-by: John Snow --- block/qcow2-bitmap.c | 48 +++

Re: [Qemu-devel] [RFC PATCH 04/12] qcow2/dirty-bitmaps: load IN_USE bitmaps if disk is RO

2018-05-14 Thread Vladimir Sementsov-Ogievskiy
12.05.2018 04:25, John Snow wrote: For the purposes of qemu-img manipulation and querying of bitmaps, load bitmaps that are "in use" -- if the image is read only. This will allow us to diagnose problems with this flag using the qemu-img tool. It looks unsafe.. We can load them, then reopen rw a

Re: [Qemu-devel] [PATCH 08/42] job: Create Job, JobDriver and job_create()

2018-05-14 Thread Kevin Wolf
Am 12.05.2018 um 00:46 hat Max Reitz geschrieben: > On 2018-05-09 18:26, Kevin Wolf wrote: > > This is the first step towards creating an infrastructure for generic > > background jobs that aren't tied to a block device. For now, Job only > > stores its ID and JobDriver, the rest stays in BlockJob.

Re: [Qemu-devel] [PATCH 02/10] RFC: Implement qcow2's snapshot dependent saving function.

2018-05-14 Thread Stefan Hajnoczi
On Tue, May 08, 2018 at 09:50:00AM -0500, Eric Blake wrote: > On 03/13/2018 03:33 AM, junyan...@intel.com wrote: > > From: Junyan He > > > > For qcow2 format, we can increase the cluster's reference count of > > dependent snapshot content and link the offset to the L2 table of > > the new snapsho

Re: [Qemu-devel] GSoC Intro: Vulkan-ize VirGL

2018-05-14 Thread Stefan Hajnoczi
On Tue, May 08, 2018 at 09:36:51PM +0200, Nathan Gauër wrote: > I'm Nathan Gauër, a french student in computer science. > For this year's Google Summer of Code, I've been selected to work on > the Vulkan support for Virgl3D. The nature of this project makes the > roadmap a bit blurry, but hopefully

[Qemu-devel] [PATCH v6 0/3] linux-headers: arch fixups

2018-05-14 Thread Michael S. Tsirkin
It turns out that we have unistd.h and kvm headers for some architectures but not others. We are thus unable to use e.g. usefaultfd on these systems unless system headers have been updated. Fix up update-linux-headers.sh to make sure we auto-updates all architectures which have linux-headers/ (un

[Qemu-devel] [PATCH v6 1/3] update-linux-headers.sh: unistd.h, kvm consistency

2018-05-14 Thread Michael S. Tsirkin
Rework the update script slightly, add the unistd.h header and its dependencies on all architectures. This also removes the IA64 and MIPS from a KVM blacklist: Linux dropped IA64, and there was never a reason to exclude MIPS from kvm specifically - it was excluded due to dependency of its unistd.h

Re: [Qemu-devel] [PATCH v5 0/3] linux-headers: arch fixups

2018-05-14 Thread Michael S. Tsirkin
On Mon, May 14, 2018 at 11:17:14AM +0100, Peter Maydell wrote: > On 11 May 2018 at 22:32, Michael S. Tsirkin wrote: > > It turns out that we have unistd.h and kvm headers for some > > architectures but not others. We are thus unable to use e.g. usefaultfd > > on these systems unless system header

[Qemu-devel] [PATCH v6 3/3] linux-headers: add kvm header for mips

2018-05-14 Thread Michael S. Tsirkin
kvm header for MIPS was manually excluded from auto-updates. Update it now to 4.17-rc2. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-mips/kvm.h | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/linux-headers/asm-mips/kvm.h b/linux-headers/

[Qemu-devel] [PATCH v6 2/3] linux-headers: add unistd.h on all arches

2018-05-14 Thread Michael S. Tsirkin
This adds unistd.h on ARM64 and MIPS and their dependencies. Updated to Linux 4.17-rc2. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-arm/bitsperlong.h | 1 + linux-headers/asm-arm64/bitsperlong.h | 24 + linux-headers/asm-generic/bitsperlong.h | 16 + linux-headers/asm-gene

Re: [Qemu-devel] [PATCH v9 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-05-14 Thread Alberto Garcia
On Tue 08 May 2018 04:58:15 PM CEST, Anton Nefedov wrote: > If COW areas of the newly allocated clusters are zeroes on the backing image, > efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole > cluster instead of writing explicit zero buffers later in perform_cow(). > > io

Re: [Qemu-devel] Question about QEMU

2018-05-14 Thread Stefan Hajnoczi
On Thu, May 10, 2018 at 05:55:38PM +0900, 유원상 wrote: > Hi, > This is Wonsang Ryu. > I'm developer working in South Korea. Welcome! > Do you have forum or community for any developer? > I want share my issues with other developers. > I have some question about QEMU. That's what the qemu-devel@non

Re: [Qemu-devel] [PULL 0/8] Block patches

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 10:28, Stefan Hajnoczi wrote: > The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2018-05-08 17:05:58 +0100) > > are available in the Git repository at: > > git

Re: [Qemu-devel] [PATCH v2 13/27] target/arm: convert conversion helpers to fpst/ahp_flag

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > From: Alex Bennée > > Instead of passing env and leaving it up to the helper to get the > right fpstatus we pass it explicitly. There was already a get_fpstatus > helper for neon for the 32 bit code. We also add an get_ahp_flag() for > passing t

Re: [Qemu-devel] [PATCH 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-14 Thread Cornelia Huck
On Mon, 14 May 2018 14:40:13 +0200 Halil Pasic wrote: > On 05/14/2018 02:18 PM, Cornelia Huck wrote: > > On Thu, 10 May 2018 02:07:11 +0200 > > Halil Pasic wrote: > > > >> There is at least one control program (guest) that although it does not > > > > I'd drop 'control program' here as wel

[Qemu-devel] [PATCH] qemu-options: Allow -no-user-config again

2018-05-14 Thread Michal Privoznik
After 1217d6ca2bf28c0febe1bd7d5b3fa912bbf6af2a we error out explicitly if an unknown -option was passed on the command line. However, we are doing two pass command line option parsing. In the first pass we just look for -no-user-config or -nodefconfig being present which determines whether we load

Re: [Qemu-devel] [PATCH v2 10/27] fpu/softfloat: re-factor float to float conversions

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > From: Alex Bennée > > This allows us to delete a lot of additional boilerplate code which is > no longer needed. Currently the ieee flag is ignored (everything is > assumed to be ieee). Handling for ARM AHP will be in the next patch. > > Signed-

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-05-14 Thread Stefan Hajnoczi
On Fri, May 11, 2018 at 07:25:31PM +0200, Kevin Wolf wrote: > Am 10.05.2018 um 10:26 hat Stefan Hajnoczi geschrieben: > > On Wed, May 09, 2018 at 07:54:31PM +0200, Max Reitz wrote: > > > On 2018-05-09 12:16, Stefan Hajnoczi wrote: > > > > On Tue, May 08, 2018 at 05:03:09PM +0200, Kevin Wolf wrote:

Re: [Qemu-devel] [PATCH v2 11/27] fpu/softfloat: support ARM Alternative half-precision

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > From: Alex Bennée > > For float16 ARM supports an alternative half-precision format which > sacrifices the ability to represent NaN/Inf in return for a higher > dynamic range. To support this I've added an additional > FloatFmt (float16_params_a

Re: [Qemu-devel] [PATCH v2 12/27] target/arm: Use floatX_silence_nan when we have already checked for SNaN

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-a64.c | 6 +++--- > target/arm/helper.c | 12 ++-- > 2 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH] Added SIGPWR handler to send ACPI shutdown

2018-05-14 Thread Stefan Hajnoczi
On Fri, May 11, 2018 at 09:32:38PM +0100, andrewjameswood--- via Qemu-devel wrote: > From: Andrew Wood > > Signed-off-by: Andrew Wood Thanks! Please include a commit description to give the rationale for this change. Please address coding style issues. You can run the checker like this:

Re: [Qemu-devel] [PATCH v2 14/27] target/arm: squash FZ16 behaviour for conversions

2018-05-14 Thread Peter Maydell
On 12 May 2018 at 01:42, Richard Henderson wrote: > From: Alex Bennée > > The ARM ARM specifies FZ16 is suppressed for conversions. Rather than > pushing this logic into the softfloat code we can simply save the FZ > state and temporarily disable it for the softfloat call. > > Signed-off-by: Alex

Re: [Qemu-devel] [PATCH 12/42] job: Maintain a list of all jobs

2018-05-14 Thread Max Reitz
On 2018-05-09 18:26, Kevin Wolf wrote: > This moves the job list from BlockJob to Job. Now we can check for > duplicate IDs in job_create(). > > Signed-off-by: Kevin Wolf > --- > include/block/blockjob.h | 3 --- > include/qemu/job.h | 19 +++ > blockjob.c |

  1   2   3   4   >