On 14 May 2018 at 12:55, linzhecheng <linzhech...@huawei.com> wrote: > commit dbadee4 removed qemu_cond_wait in cpu_remove_sync, so it is > useless to keep qemu_cond_signal here. > > Signed-off-by: linzhecheng <linzhech...@huawei.com> > > diff --git a/cpus.c b/cpus.c > index 5bcd3ecf38..c7262484f3 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1222,7 +1222,6 @@ static void *qemu_kvm_cpu_thread_fn(void *arg) > > qemu_kvm_destroy_vcpu(cpu); > cpu->created = false; > - qemu_cond_signal(&qemu_cpu_cond); > qemu_mutex_unlock_iothread(); > rcu_unregister_thread(); > return NULL; > -- > 2.12.2.windows.2
At the moment we seem to have an invariant "everywhere we set cpu->created = false we also signal the qemu_cpu_cond". If signalling the condition is no longer necessary in this function, is it also no longer necessary in all the other places where we do it after setting created = false ? thanks -- PMM
