Re: [Qemu-devel] [PATCH RESEND v10] vhost: used_memslots refactoring

2018-05-01 Thread Zhoujian (jay)
Hi Michael and Igor, I'm afraid this patch has been missed, could you help to review? PS: In order to avoid side effect, code redundancy does exist between vhost_user_set_used_memslots(), vhost_user_set_mem_table() and vhost_user_set_mem_table_postcopy(), I haven't found a good solution to solve i

Re: [Qemu-devel] [RFC PATCH 00/11] iommu: add MemTxAttrs argument to IOMMU translate function

2018-05-01 Thread Peter Maydell
On 30 April 2018 at 19:18, Peter Maydell wrote: > This is an RFC patchset because it's a little bit unmotivated > and only lightly tested, but in principle it could be > committed, so half-RFC-half-not :-) > > The Arm SMMU wants to know if the transaction it is handling > is secure/nonsecure and u

Re: [Qemu-devel] [PATCH 7/7] hw/rdma: Fix possible out of bounds access to port GID index

2018-05-01 Thread Marcel Apfelbaum
On 05/01/2018 12:14 AM, Eric Blake wrote: On 04/30/2018 03:02 PM, Marcel Apfelbaum wrote: Make sure the backend GID index is less then port's git table length. s/git/gid/ Thanks, I will fix in the pull request Marcel Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia ---   hw/r

[Qemu-devel] [RFC PATCH v2 00/12] iommu: add MemTxAttrs argument to IOMMU translate function

2018-05-01 Thread Peter Maydell
This is an RFC patchset because it's a little bit unmotivated and only lightly tested, but in principle it could be committed, so half-RFC-half-not :-) The Arm SMMU wants to know if the transaction it is handling is secure/nonsecure and user/privileged, because the iommu page tables can be configu

[Qemu-devel] [RFC PATCH v2 03/12] Make address_space_map() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_map(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- include/exec/memory.h | 3 ++- include/sys

[Qemu-devel] [RFC PATCH v2 06/12] Make memory_region_access_valid() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to memory_region_access_valid(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. The callsite in flatview_access_valid() is part of a recursive loop fl

[Qemu-devel] [RFC PATCH v2 04/12] Make address_space_access_valid() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_access_valid(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- include/exec/memory.h | 4 +++-

[Qemu-devel] [RFC PATCH v2 05/12] Make flatview_extend_translation() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_extend_translation(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- exec.c | 8 1 file change

[Qemu-devel] [RFC PATCH v2 08/12] Make flatview_access_valid() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_access_valid(). Its callers now all have an attrs value to hand, so we can correct our earlier temporary use of MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- exec.c | 11 +-

[Qemu-devel] [RFC PATCH v2 07/12] Make MemoryRegion valid.accepts callback take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to the MemoryRegion valid.accepts callback. We'll need this for subpage_accepts(). We could take the approach we used with the read and write callbacks and add new a new _with_attrs version, but since

[Qemu-devel] [RFC PATCH v2 01/12] Make tb_invalidate_phys_addr() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to tb_invalidate_phys_addr(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- include/exec/exec-all.h | 5 +++-- a

[Qemu-devel] [RFC PATCH v2 02/12] Make address_space_translate() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_translate(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- include/exec/memory.h | 4 +++- a

[Qemu-devel] [RFC PATCH v2 11/12] Make flatview_do_translate() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_do_translate(). Signed-off-by: Peter Maydell --- exec.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index c29bf47ce2..9c6d9aae28 100644 --

[Qemu-devel] [RFC PATCH v2 09/12] Make flatview_translate() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_translate(); all its callers now have attrs available. Signed-off-by: Peter Maydell --- include/exec/memory.h | 7 --- exec.c| 17 + 2 files changed,

[Qemu-devel] [RFC PATCH v2 10/12] Make address_space_get_iotlb_entry() take a MemTxAttrs argument

2018-05-01 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_get_iotlb_entry(). Signed-off-by: Peter Maydell --- include/exec/memory.h | 2 +- exec.c| 2 +- hw/virtio/vhost.c | 3 ++- 3 files changed, 4 insertions(+), 3 del

[Qemu-devel] [RFC PATCH v2 12/12] Add MemTxAttrs argument to IOMMU translate function

2018-05-01 Thread Peter Maydell
Add a MemTxAttrs argument to the IOMMU translate function; this is necessary for IOMMU implementations that care about transaction attributes such as user/privileged or secure/nonsecure when deciding whether a transaction is permitted. Signed-off-by: Peter Maydell --- include/exec/memory.h|

Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 04:35, Philippe Mathieu-Daudé wrote: > On 04/30/2018 10:49 AM, Edgar E. Iglesias wrote: >> On Fri, Apr 27, 2018 at 12:55:21PM +0100, Peter Maydell wrote: >>> On 13 February 2018 at 04:07, Philippe Mathieu-Daudé >>> wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed

[Qemu-devel] Translation block identification.

2018-05-01 Thread Rafael Kioji
Dear all, During translation how can I identify what is the basic block of the guest code? I wanted to know whether the block being translated is the beginning of a function and get its name. My current approach involves looking up the symbol associated with the first PC of the translation b

Re: [Qemu-devel] [PATCH for-2.13 v2 5/5] arm/boot: split load_dtb() from arm_load_kernel()

2018-05-01 Thread Igor Mammedov
On Fri, 27 Apr 2018 15:47:28 +0200 Andrew Jones wrote: > On Wed, Apr 18, 2018 at 04:28:05PM +0200, Igor Mammedov wrote: > > load_dtb() depends on arm_load_kernel() to figure out place > > in RAM where it should be loaded, but it's not required for > > arm_load_kernel() to work. Sometimes it's nec

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > During a TLS connect we see: > migration_channel_connect calls > migration_tls_channel_connect > (calls after TLS setup) > migration_channel_connect > > My previous error ha

Re: [Qemu-devel] Translation block identification.

2018-05-01 Thread Alex Bennée
Rafael Kioji writes: > Dear all, > > During translation how can I identify what is the basic block of the > guest code? I wanted to know whether the block being translated is the > beginning of a function and get its name. > > My current approach involves looking up the symbol associated with th

Re: [Qemu-devel] [PATCH 3/9] target/arm: Fix float16 to/from int16

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > The instruction "ucvtf v0.4h, v04h, #2", with input 0x8000u, > overflows the intermediate float16 to infinity before we have a > chance to scale the output. Use float64 as the intermediate type > so that no input argument (uint32_t in this case) can overflow > or rou

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > During a TLS connect we see: > > migration_channel_connect calls > > migration_tls_channel_connect > >

[Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

2018-05-01 Thread Peter Maydell
Add more detail to the documentation for memory_region_init_iommu() and other IOMMU-related functions and data structures. Signed-off-by: Peter Maydell --- v1 -> v2 changes: * documented replay method * added note about wanting RCU or big qemu lock while calling translate include/exec/memo

Re: [Qemu-devel] Translation block identification.

2018-05-01 Thread Rafael Kioji
This logging flag prints what I want. But I really wanted is to get this info inside the QEMU source code. Why am I not able to lookup the symbols in the translator.c file the way I showed? Kind regards, Rafael On 5/1/2018 6:04 PM, Alex Bennée wrote: Rafael Kioji writes: Dear all, During

Re: [Qemu-devel] Translation block identification.

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 11:20, Rafael Kioji wrote: > This logging flag prints what I want. But I really wanted is to get this > info inside the QEMU source code. Why am I not able to lookup the symbols in > the translator.c file the way I showed? The -d in_asm logging is just using lookup_symbol() (eg f

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-05-01 Thread Wei Liu
On Mon, Apr 30, 2018 at 03:30:02PM +, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 30 April 2018 16:28 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu- > > de...@nongnu.org; Anthony Perard ; Kevin > > Wolf ; Ste

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-05-01 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 01 May 2018 11:30 > To: Paul Durrant > Cc: Roger Pau Monne ; Kevin Wolf > ; Stefano Stabellini ; qemu- > bl...@nongnu.org; qemu-devel@nongnu.org; Max Reitz > ; Anthony Perard ; xen- > de...@lists.xenproject.org; Wei

Re: [Qemu-devel] Translation block identification.

2018-05-01 Thread Alex Bennée
Rafael Kioji writes: > This logging flag prints what I want. But I really wanted is to get > this info inside the QEMU source code. Why am I not able to lookup the > symbols in the translator.c file the way I showed? Without a failing patch it's hard to say, after all the working disassembly is

Re: [Qemu-devel] [PATCH 4/9] target/arm: Clear SVE high bits for FMOV

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > Use write_fp_dreg and clear_vec_high to zero the bits > that need zeroing for these cases. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 17 + > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/target/arm/

Re: [Qemu-devel] Translation block identification.

2018-05-01 Thread Rafael Kioji
Solved. The reason I was not able to get the symbols is because logging has to be enabled, otherwise the symbols are not loaded. In "elfload.c" there is the condition: if (qemu_log_enabled()) {     load_symbols(ehdr, image_fd, load_bias); } Thanks! Kind regards, Rafael On 5/1/2018 6:28 PM,

Re: [Qemu-devel] [PATCH 6/9] target/arm: Implement FCVT (scalar, integer) for fp16

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper.h| 6 +++ > target/arm/helper.c| 38 +- > target/arm/translate-a64.c | 96 > ++ > 3 files changed, 12

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > During a TLS connect we see: > > > migr

Re: [Qemu-devel] [PATCH 7/9] target/arm: Implement FCVT (scalar, fixed-point) for fp16

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 4f6317aa0f..79

Re: [Qemu-devel] [PATCH 8/9] target/arm: Implement FP data-processing (2 source) for fp16

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > We missed all of the scalar fp16 binary operations. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 73 > ++ > 1 file changed, 73 insertions(+) > > diff --git a/target/arm/translate-a64.c b/targe

Re: [Qemu-devel] [PATCH 9/9] target/arm: Implement FP data-processing (3 source) for fp16

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > We missed all of the scalar fp16 fma operations. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 48 > ++ > 1 file changed, 48 insertions(+) > > diff --git a/target/arm/translate-a64.c b/target/a

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 11:57:25AM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From

Re: [Qemu-devel] [PATCH] qxl: fix local renderer crash

2018-05-01 Thread Marc-André Lureau
Hi On Fri, Apr 27, 2018 at 1:55 PM, Gerd Hoffmann wrote: > Make sure we only ask the spice local renderer for display updates in > case we have a valid primary surface. Without that spice is confused > and throws errors in case a display update request (triggered by > screendump for example) hap

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-05-01 Thread David Gibson
On Thu, Apr 26, 2018 at 09:20:11AM +0200, Cédric Le Goater wrote: > On 04/26/2018 08:46 AM, David Gibson wrote: > > On Wed, Apr 25, 2018 at 11:52:18AM +0200, Cédric Le Goater wrote: > >> On 04/17/2018 09:17 AM, David Gibson wrote: > >>> In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are i

[Qemu-devel] [PATCH v3 1/5] pc: simplify MachineClass::get_hotplug_handler handling

2018-05-01 Thread Igor Mammedov
By default MachineClass::get_hotplug_handler is NULL and concrete board should set it to it's own handler. Considering there isn't any default handler, drop saving empty MachineClass::get_hotplug_handler in child class and make PC code consistent with spapr/s390x boards. We can bring this back whe

[Qemu-devel] [PATCH v3 2/5] platform-bus-device: use device plug callback instead of machine_done notifier

2018-05-01 Thread Igor Mammedov
platform-bus were using machine_done notifier to get and map (assign irq/mmio resources) dynamically added sysbus devices after all '-device' options had been processed. That however creates non obvious dependencies on ordering of machine_done notifiers and requires carefull line juggling to keep i

[Qemu-devel] [PATCH v3 3/5] arm/boot: split load_dtb() from arm_load_kernel()

2018-05-01 Thread Igor Mammedov
load_dtb() depends on arm_load_kernel() to figure out place in RAM where it should be loaded, but it's not required for arm_load_kernel() to work. Sometimes it's neccesary for devices added with -device/device_add to be enumerated in DTB as well, which's lead to [1] and surrounding commits to add 2

[Qemu-devel] [PATCH v3 4/5] arm: boot: set boot_info starting from first_cpu

2018-05-01 Thread Igor Mammedov
even though nothing is currently broken, make sure that boot_info is set on all CPUs. Ref: "Message-ID: " Signed-off-by: Igor Mammedov --- hw/arm/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index ad71dd4..144abbd 100644 --- a/hw/arm/

[Qemu-devel] [PATCH v3 5/5] make sure that we aren't overwriting mc->get_hotplug_handler by accident

2018-05-01 Thread Igor Mammedov
Suggested-by: Eduardo Habkost Signed-off-by: Igor Mammedov --- hw/arm/virt.c | 1 + hw/i386/pc.c | 1 + hw/ppc/e500plat.c | 1 + hw/ppc/spapr.c | 1 + hw/s390x/s390-virtio-ccw.c | 1 + 5 files changed, 5 insertions(+) diff --git a/hw/arm/virt.c b/

[Qemu-devel] [PATCH v3 0/5] arm: isolate and clean up dtb generation

2018-05-01 Thread Igor Mammedov
Changelog v2->v3: * drop already merged patches 'arm: always start from first_cpu when registering loader cpu reset callback' 'ppc: e500: switch E500 based machines to full machine definition' * add small not related cleanup 'arm: boot: set boot_info starting from fir

Re: [Qemu-devel] [PATCH v3 4/5] arm: boot: set boot_info starting from first_cpu

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 13:08, Igor Mammedov wrote: > even though nothing is currently broken, make sure that boot_info > is set on all CPUs. > > Ref: > "Message-ID: > " Can you include the rationale in the commit message rather than just pointing to a message-id, please? > > Signed-off-by: Igor Mamme

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-01 Thread Stefan Hajnoczi
On Fri, Apr 27, 2018 at 04:51:03PM +0100, Peter Maydell wrote: > (2) release timing: > * usual schedule would give us a next release mid-to-late August > * unless I can persuade Stefan to do the release management this >cycle we might need to wind that in by a couple of weeks so >it's def

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 13:24, Stefan Hajnoczi wrote: > On Fri, Apr 27, 2018 at 04:51:03PM +0100, Peter Maydell wrote: >> (2) release timing: >> * usual schedule would give us a next release mid-to-late August >> * unless I can persuade Stefan to do the release management this >>cycle we might need

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 12:21:18PM +0100, Daniel P. Berrangé wrote: > On Tue, May 01, 2018 at 11:57:25AM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Tue, May 01, 2018 at 11:00:35AM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Apr 30, 2018

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-01 Thread Eric Blake
On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy --- There is no rationale in the commit body (a good commit message has a one-line summary of "what", then a paragraph stating "why", making it easier for the reviewer to check that the patch itself is th

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check

2018-05-01 Thread Stefan Hajnoczi
On Mon, Apr 30, 2018 at 05:56:30AM -0700, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/5: checkpatch: add a --strict check for utf-8 in commit > logs... > WARNING: line over 80 characters > #101: FILE: scripts/checkpatch.pl:1420: > + WARN("8-bit UTF-8 u

[Qemu-devel] [PATCH v4] dump: add Windows dump format to dump-guest-memory

2018-05-01 Thread Viktor Prutyanov
This patch adds Windows crashdumping feature. Now QEMU can produce ELF-dump containing Windows crashdump header, which can help to convert to a valid WinDbg-understandable crashdump file, or immediately create such file. The crashdump will be obtained by joining physical memory dump and 8K header e

[Qemu-devel] [Bug 1768246] [NEW] cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed.

2018-05-01 Thread John Paul Adrian Glaubitz
Public bug reported: OpenJDK no longer works on qemu-sh4, it previously did after #1735384 was fixed. Crash indicates an assertion failure: (sid-sh4-sbuild)root@nofan:/# java --version qemu-sh4-static: /root/qemu/accel/tcg/cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed. qemu: u

Re: [Qemu-devel] [PATCH v3 4/5] arm: boot: set boot_info starting from first_cpu

2018-05-01 Thread Igor Mammedov
On Tue, 1 May 2018 13:19:12 +0100 Peter Maydell wrote: > On 1 May 2018 at 13:08, Igor Mammedov wrote: > > even though nothing is currently broken, make sure that boot_info > > is set on all CPUs. > > > > Ref: > > "Message-ID: > > " > > Can you include the rationale in the commit message rath

[Qemu-devel] [PATCH v4 4/5] arm: boot: set boot_info starting from first_cpu

2018-05-01 Thread Igor Mammedov
Even though nothing is currently broken (since all boards use first_cpu as boot cpu), make sure that boot_info is set on all CPUs. If some board would like support heterogenuos setup (i.e. init boot_info on subset of CPUs) in future, it should add a reasonable API to do it, instead of starting assi

[Qemu-devel] [PULL 2/4] m68k: Fix floatx80_lognp1 (Coverity CID1390587)

2018-05-01 Thread Laurent Vivier
return the result of packFloatx80() instead of dropping it. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180430170156.1860-1-laur...@vivier.eu> --- target/m68k/softfloat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[Qemu-devel] [PULL 4/4] hw/m68k/mcf5208: Fix trivial typo in board description

2018-05-01 Thread Laurent Vivier
From: Thomas Huth It's the MCF5208 evaluation board, not the MCF5206 eval board. Signed-off-by: Thomas Huth Reviewed-by: Laurent Vivier Message-Id: <20180429094002.3293c...@thl530.multi.box> Signed-off-by: Laurent Vivier --- hw/m68k/mcf5208.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[Qemu-devel] [PULL 0/4] M68k for 2.13 patches

2018-05-01 Thread Laurent Vivier
The following changes since commit c2c768500f17fc8cdcfa44d169f089953bb22748: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-2.13-pull-request' into staging (2018-04-30 10:43:41 +0100) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k

[Qemu-devel] [PULL 1/4] m68k: fix subx mem, mem instruction

2018-05-01 Thread Laurent Vivier
From: Pavel Dovgalyuk This patch fixes decrement of the pointers for subx mem, mem instructions. Without the patch pointers are decremented by OS_* constant value instead of retrieving the corresponding data size and using it as a decrement. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Laurent V

[Qemu-devel] [PULL 3/4] m68k: remove dead code (Coverity CID1390617)

2018-05-01 Thread Laurent Vivier
floatx80_sin() and floatx80_cos() are derived from one sincos() function. They have both unused code coming from their common origin. Remove it. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Message-Id: <20180430170156.1860-2-laur...@vivier.eu> --- target/m68k/softfloat.c | 43 ++

Re: [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen

2018-05-01 Thread Knut Omang
Hi Peter, Seems this test was lost along the way? I thought it got merged with Daniel's fix to the potential leak that the test exposed in your build, but it seems not? Thanks, Knut On Mon, 2017-11-06 at 15:33 +, Daniel P. Berrange wrote: > From: Knut Omang > > There's a potential race c

Re: [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 04:00:35PM +0200, Knut Omang wrote: > Hi Peter, > > Seems this test was lost along the way? > > I thought it got merged with Daniel's fix to the potential leak > that the test exposed in your build, but it seems not? I've never been able to get this test, nor another one

Re: [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen

2018-05-01 Thread Knut Omang
On Tue, 2018-05-01 at 15:07 +0100, Daniel P. Berrangé wrote: > On Tue, May 01, 2018 at 04:00:35PM +0200, Knut Omang wrote: > > Hi Peter, > > > > Seems this test was lost along the way? > > > > I thought it got merged with Daniel's fix to the potential leak > > that the test exposed in your build

[Qemu-devel] [RFC PATCH 02/12] tests/tcg/tricore: Add build infrastructure

2018-05-01 Thread Bastian Koppelmann
this includes the Makefile and linker script to build all the tests. Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile | 30 +++ tests/tcg/tricore/link.ld | 60 ++ 2 files changed, 90 insertions(+) create mode 10064

[Qemu-devel] [RFC PATCH 08/12] tests/tcg/tricore: Add fmul test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_fmul.S | 8 2 files changed, 9 insertions(+) create mode 100644 tests/tcg/tricore/test_fmul.S diff --git a/tests/tcg/tricore/Makefile b/tests/tcg/tricore/Makefile index ba0514bfa3..5e2a450

[Qemu-devel] [RFC PATCH 03/12] tests/tcg/tricore: Add macros to easily create tests and first test 'abs'

2018-05-01 Thread Bastian Koppelmann
This kind of tests is inspired by the riscv-tests repository. This adds macros that makes it easy to create single instruction self containing tests. This is achieved by macros that create a test sequence for an instruction and check for a supplied correct value. If the value is correct the next i

[Qemu-devel] [RFC PATCH 05/12] tests/tcg/tricore: Add clz test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile | 1 + tests/tcg/tricore/test_clz.S | 9 + 2 files changed, 10 insertions(+) create mode 100644 tests/tcg/tricore/test_clz.S diff --git a/tests/tcg/tricore/Makefile b/tests/tcg/tricore/Makefile index 34c91dccf5..16ec5460

[Qemu-devel] [RFC PATCH 04/12] tests/tcg/tricore: Add bmerge test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile | 1 + tests/tcg/tricore/macros.h | 24 tests/tcg/tricore/test_bmerge.S | 8 3 files changed, 33 insertions(+) create mode 100644 tests/tcg/tricore/test_bmerge.S diff --git a/tests/tcg

[Qemu-devel] [RFC PATCH 06/12] tests/tcg/tricore: Add dvstep test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile | 1 + tests/tcg/tricore/macros.h | 29 - tests/tcg/tricore/test_dvstep.S | 15 +++ 3 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/tricore/test_dvste

[Qemu-devel] [RFC PATCH 09/12] tests/tcg/tricore: Add ftoi test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/macros.h| 7 +++ tests/tcg/tricore/test_ftoi.S | 10 ++ 3 files changed, 18 insertions(+) create mode 100644 tests/tcg/tricore/test_ftoi.S diff --git a/tests/tcg/tricore/Makefile b/tes

[Qemu-devel] [RFC PATCH 11/12] tests/tcg/tricore: Add msub test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_msub.S | 9 + 2 files changed, 10 insertions(+) create mode 100644 tests/tcg/tricore/test_msub.S diff --git a/tests/tcg/tricore/Makefile b/tests/tcg/tricore/Makefile index 2d32ec3077..e3113

[Qemu-devel] [RFC PATCH 00/12] tests/tcg: Add TriCore tests

2018-05-01 Thread Bastian Koppelmann
Hi Alex, I finally came around converting some of my TriCore regression tests into actual tests, that don't require the proprietary Infineon simulator. These tests are heavily inspired by the riscv-tests [1]. I add macros that allow easy testing of single asm instructions. e.g. for add %d1, %d2,

[Qemu-devel] [RFC PATCH 10/12] tests/tcg/tricore: Add madd test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/macros.h| 18 ++ tests/tcg/tricore/test_madd.S | 11 +++ 3 files changed, 30 insertions(+) create mode 100644 tests/tcg/tricore/test_madd.S diff --git a/tests/tcg/tricore/Ma

[Qemu-devel] [RFC PATCH 07/12] tests/tcg/tricore: Add fadd test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_fadd.S | 16 2 files changed, 17 insertions(+) create mode 100644 tests/tcg/tricore/test_fadd.S diff --git a/tests/tcg/tricore/Makefile b/tests/tcg/tricore/Makefile index 36f15a75

[Qemu-devel] [RFC PATCH 01/12] hw/tricore: Add testdevice for tests in tests/tcg/

2018-05-01 Thread Bastian Koppelmann
this device is used to verify the correctness of regression tests by allowing guests to write their exit status to this device. This is then used by qemu to exit using the written status. Signed-off-by: Bastian Koppelmann --- hw/tricore/Makefile.objs| 1 + hw/tricore/tricore_tes

[Qemu-devel] [RFC PATCH 12/12] tests/tcg/tricore: Add muls test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_muls.S | 9 + 2 files changed, 10 insertions(+) create mode 100644 tests/tcg/tricore/test_muls.S diff --git a/tests/tcg/tricore/Makefile b/tests/tcg/tricore/Makefile index e3113b726c..37c31

Re: [Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

2018-05-01 Thread Auger Eric
Hi Peter, On 05/01/2018 12:19 PM, Peter Maydell wrote: > Add more detail to the documentation for memory_region_init_iommu() > and other IOMMU-related functions and data structures. > > Signed-off-by: Peter Maydell > --- > v1 -> v2 changes: > * documented replay method > * added note about wan

Re: [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 04:21:01PM +0200, Knut Omang wrote: > On Tue, 2018-05-01 at 15:07 +0100, Daniel P. Berrangé wrote: > > On Tue, May 01, 2018 at 04:00:35PM +0200, Knut Omang wrote: > > > Hi Peter, > > > > > > Seems this test was lost along the way? > > > > > > I thought it got merged with D

Re: [Qemu-devel] [PATCH v3 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-05-01 Thread Balamuruhan S
Hi, Dave, David and Juan if you guys are okay with the patch, please help to merge it. Thanks, Bala On Wed, Apr 25, 2018 at 12:40:40PM +0530, Balamuruhan S wrote: > expected_downtime value is not accurate with dirty_pages_rate * page_size, > using ram_bytes_remaining would yeild it correct. It w

Re: [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

2018-05-01 Thread Igor Mammedov
On Fri, 27 Apr 2018 17:05:30 -0500 Eric Blake wrote: > On 04/27/2018 10:05 AM, Igor Mammedov wrote: > > New option will be used to allow commands, which are prepared/need > > to run, during preconfig state. Other commands that should be able > > to run in preconfig state, should be ameded to not

Re: [Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 15:32, Auger Eric wrote: > Hi Peter, > > On 05/01/2018 12:19 PM, Peter Maydell wrote: >> Add more detail to the documentation for memory_region_init_iommu() >> and other IOMMU-related functions and data structures. >> >> Signed-off-by: Peter Maydell >> --- >> v1 -> v2 changes: >>

[Qemu-devel] Introducing a nanoMIPS port for QEMU

2018-05-01 Thread Matthew Fortune
Earlier today MIPS Tech announced the latest generation of the MIPS family of architectures called nanoMIPS [1]. As part of the development we have been designing all the open source tools necessary to support the architecture and, thanks to the speed with which we were able to prototype, we have a

Re: [Qemu-devel] [PATCH v6 03/11] cli: add --preconfig option

2018-05-01 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 05:05:15PM +0200, Igor Mammedov wrote: > This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, > allowing the configuration of QEMU from QMP before the machine jumps > into board initialization code of machine_run_board_init() > > The intent is to allow mana

Re: [Qemu-devel] [RFC PATCH 00/12] tests/tcg: Add TriCore tests

2018-05-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 2018050114.19154-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [RFC PATCH 00/12] tests/tcg: Add TriCore tests === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=

Re: [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

2018-05-01 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 05:05:17PM +0200, Igor Mammedov wrote: > New option will be used to allow commands, which are prepared/need > to run, during preconfig state. Other commands that should be able > to run in preconfig state, should be ameded to not expect machine > in initialized state or deal

Re: [Qemu-devel] [PULL 0/4] M68k for 2.13 patches

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 14:55, Laurent Vivier wrote: > The following changes since commit c2c768500f17fc8cdcfa44d169f089953bb22748: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-2.13-pull-request' into staging > (2018-04-30 10:43:41 +0100) > > are available in the Git reposi

Re: [Qemu-devel] [Bug 1768246] [NEW] cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed.

2018-05-01 Thread Alex Bennée
John Paul Adrian Glaubitz writes: > Public bug reported: > > OpenJDK no longer works on qemu-sh4, it previously did after #1735384 > was fixed. > > Crash indicates an assertion failure: > > (sid-sh4-sbuild)root@nofan:/# java --version > qemu-sh4-static: /root/qemu/accel/tcg/cpu-exec.c:648: cpu_l

Re: [Qemu-devel] [RFC PATCH 02/12] tests/tcg/tricore: Add build infrastructure

2018-05-01 Thread Alex Bennée
Bastian Koppelmann writes: > this includes the Makefile and linker script to build all the tests. > > Signed-off-by: Bastian Koppelmann > --- > tests/tcg/tricore/Makefile | 30 +++ > tests/tcg/tricore/link.ld | 60 > ++ > 2 file

Re: [Qemu-devel] [PATCH 2/2] iotests: Repairing error during snapshot deletion

2018-05-01 Thread Max Reitz
On 2018-04-30 18:01, Eric Blake wrote: > On 04/28/2018 11:34 AM, Max Reitz wrote: >> This adds a test for an I/O error during snapshot deletion, and maybe >> more importantly, for how to repair the resulting image.  If the >> snapshot has been deleted before the error occurs, the only negative >> r

Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > When running the gcc testsuite with current aarch64-linux-user, > the testsuite detects the presence of the fp16 extension and > enables lots of extra tests for builtins. > > Quite a few of these new tests fail because we missed implementing > some instructions. We r

[Qemu-devel] [PATCH] nbd/client: Fix error messages during NBD_INFO_BLOCK_SIZE

2018-05-01 Thread Eric Blake
A missing space makes for poor error messages. Also, we missed diagnosing a server that sends a maximum block size less than the minimum. Fixes: 081dd1fe CC: qemu-sta...@nongnu.org Signed-off-by: Eric Blake --- nbd/client.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

2018-05-01 Thread Auger Eric
Hi Peter, On 05/01/2018 05:00 PM, Peter Maydell wrote: > On 1 May 2018 at 15:32, Auger Eric wrote: >> Hi Peter, >> >> On 05/01/2018 12:19 PM, Peter Maydell wrote: >>> Add more detail to the documentation for memory_region_init_iommu() >>> and other IOMMU-related functions and data structures. >>>

Re: [Qemu-devel] [PATCH for 2.13] linux-user: introduce target_sigsp() and target_save_altstack()

2018-05-01 Thread Laurent Vivier
Le 11/04/2018 à 21:23, Laurent Vivier a écrit : > Signed-off-by: Laurent Vivier > --- > Based-on: <20180411185651.21351-1-laur...@vivier.eu> > "[PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c > to arch directories" This patch can be applied now on top of master. > >

Re: [Qemu-devel] [PATCH] nbd/client: Fix error messages during NBD_INFO_BLOCK_SIZE

2018-05-01 Thread Vladimir Sementsov-Ogievskiy
01.05.2018 18:46, Eric Blake wrote: A missing space makes for poor error messages. Also, we missed diagnosing a server that sends a maximum block size less than the minimum. Fixes: 081dd1fe CC: qemu-sta...@nongnu.org Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-05-01 Thread Cédric Le Goater
On 05/01/2018 08:39 AM, David Gibson wrote: > On Thu, Apr 26, 2018 at 09:20:11AM +0200, Cédric Le Goater wrote: >> On 04/26/2018 08:46 AM, David Gibson wrote: >>> On Wed, Apr 25, 2018 at 11:52:18AM +0200, Cédric Le Goater wrote: On 04/17/2018 09:17 AM, David Gibson wrote: > In cpu_ppc_set_

[Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-01 Thread Auger Eric
Hi, I would like to resume the discussion on extending the number of PCI buses to 256 (as in Q35) as a follow-up of past discussions: https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg03631.html. With the current 16MB ECAM region we are limited to 16 PCIe busses. Could we envision to have

Re: [Qemu-devel] Introducing a nanoMIPS port for QEMU

2018-05-01 Thread Stefan Hajnoczi
On Tue, May 1, 2018 at 4:07 PM, Matthew Fortune wrote: > QEMU specific details > > > The nanoMIPS QEMU port borrows a significant amount of logic from the MIPS > port. Most instructions in nanoMIPS exist in one of the other MIPS ISAs, which > allows the new decoder to hook int

[Qemu-devel] [PATCH 2/3] scripts/update-linux-headers: Update handling of __aligned_u64

2018-05-01 Thread Alex Williamson
We'll currently replace any 'u64' with a 'uint64_t' including when it's embedded in an '__aligned_u64', creating a '__aligned_uint64_t' which doesn't exist. Add another sed entry to find these and convert them back to their original form. Signed-off-by: Alex Williamson --- scripts/update-linux-

[Qemu-devel] [PATCH 0/3] Update linux-headers to v4.17-rc3

2018-05-01 Thread Alex Williamson
This series is based on Michael's series moving kvm_para.h out to standard headers, which resolves the conflict in definitions of KVM_HINTS_DEDICATED between QEMU and kernel. Additionally, this series moves the definition of VIRTIO_GPU_CAPSET_VIRGL2 into QEMU code as the definition does not exist

[Qemu-devel] [PATCH 1/3] virtio-gpu-3d: Define VIRTIO_GPU_CAPSET_VIRGL2 elsewhere

2018-05-01 Thread Alex Williamson
Commit 5643cc94ac1c ("virtio-gpu-3d: add support for second capability set (v4)") updated virtio_gpu.h with a define that does not yet(?) exist upstream resulting in build breakage every time Linux headers are updated via the standard update script. Conditionally define this within QEMU code inste

  1   2   >