Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-04-30 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180430065235.577-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu] qom: Document qom/

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-04-30 Thread Alexey Kardashevskiy
On 30/4/18 4:56 pm, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. wow, did not know that the format is that strict :) I'll repost if there is no other comments about actual notes. -- Alexey

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-04-30 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180430065235.577-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu] qom: Document qom/de

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

2018-04-30 Thread Paolo Bonzini
On 28/04/2018 04:24, Peter Xu wrote: 2) Can we just reuse qemu BQL here? >>> I would prefer not. As I mentioned, at least I have spent too much >>> time on fighting BQL already. I really hope we can start to use >>> isolated locks when capable. BQL is always the worst choice to me. >> Just

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

2018-04-30 Thread Paolo Bonzini
On 28/04/2018 05:14, Peter Xu wrote: >> # git grep imrc-\>translate\ = >> hw/alpha/typhoon.c:    imrc->translate = typhoon_translate_iommu; >> hw/dma/rc4030.c:    imrc->translate = rc4030_dma_translate; >> hw/i386/amd_iommu.c:    imrc->translate = amdvi_translate; >> hw/i386/intel_iommu.c:    imrc-

[Qemu-devel] [PATCH] net: Fix memory leak in net_param_nic()

2018-04-30 Thread Thomas Huth
The early exits in case of errors leak the memory allocated for nd_id. Fix it by using a "goto out" to the cleanup at the end of the function instead. Signed-off-by: Thomas Huth --- net/net.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net/net.c index 29

[Qemu-devel] [PATCH] trivial: Do not include pci.h if it is not necessary

2018-04-30 Thread Thomas Huth
There is no need to include pci.h in these files. Signed-off-by: Thomas Huth --- include/hw/ppc/ppc4xx.h| 2 -- include/hw/virtio/virtio-balloon.h | 1 - include/hw/virtio/virtio-gpu.h | 1 - 3 files changed, 4 deletions(-) diff --git a/include/hw/ppc/ppc4xx.h b/include/hw/ppc/p

Re: [Qemu-devel] [PATCH v8 18/23] RISC-V VirtIO Machine

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 01:18, Michael Clark wrote: > Quite a bit of our initialization code in several QOM classes allocate > memory that is not freed. e.g. the PLIC. Usually these functions are only > run once, but ideally all of the code should be memory clean. i.e. exit > without leaks. Many progr

Re: [Qemu-devel] [PATCH] net: Fix memory leak in net_param_nic()

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 08:26, Thomas Huth wrote: > The early exits in case of errors leak the memory allocated for nd_id. > Fix it by using a "goto out" to the cleanup at the end of the function > instead. > > Signed-off-by: Thomas Huth > --- Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Christophe Lyon
Hello, This patch series implements the QEMU contribution of the FDPIC ABI for ARM targets. This ABI enables to run Linux on ARM MMU-less cores and supports shared libraries to reduce the memory footprint. Without MMU, text and data segment relative distances are different from one process to an

[Qemu-devel] [ARM/FDPIC v4 1/4] Remove CONFIG_USE_FDPIC.

2018-04-30 Thread Christophe Lyon
We want to avoid code disabled by default, because it ends up less tested. This patch removes all instances of #ifdef CONFIG_USE_FDPIC, most of which can be safely kept. For the ones that should be conditionally executed, we define elf_is_fdpic(). Without this patch, defining CONFIG_USE_FDPIC would

[Qemu-devel] [ARM/FDPIC v4 4/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-30 Thread Christophe Lyon
The FDPIC restorer needs to deal with a function descriptor, hence we have to extend 'retcode' such that it can hold the instructions needed to perform this. The restorer sequence uses the same thumbness as the exception handler (mainly to support Thumb-only architectures). Co-Authored-By: Mickaë

[Qemu-devel] [ARM/FDPIC v4 2/4] linux-user: ARM-FDPIC: Identify ARM FDPIC binaries

2018-04-30 Thread Christophe Lyon
Define an ARM-specific version of elf_is_fdpic: FDPIC ELF objects are identified with e_ident[EI_OSABI] == ELFOSABI_ARM_FDPIC. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/include/elf.h b/include/elf.h index c0dc9bb..934dbbd 100644 --- a/include/elf.h +++ b/include/

[Qemu-devel] [ARM/FDPIC v4 3/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-30 Thread Christophe Lyon
Add FDPIC info into image_info structure since interpreter info is on stack and needs to be saved to be accessed later on. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 76d7718..36d5219 100644 --- a/linux-user/elfloa

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 09:03, Christophe Lyon wrote: > Hello, > > This patch series implements the QEMU contribution of the FDPIC > ABI for ARM targets. Hi; I definitely reviewed at least some of these patches, but this respin seems to have lost all the reviewed-by tags? thanks -- PMM

Re: [Qemu-devel] [PATCH v2 3/9] block: Add BDRV_REQ_WRITE_UNCHANGED flag

2018-04-30 Thread Kevin Wolf
Am 28.04.2018 um 13:19 hat Max Reitz geschrieben: > On 2018-04-26 04:12, Eric Blake wrote: > > On 04/25/2018 10:08 AM, Max Reitz wrote: > > > >> > >>> Also, that does raise the question of whether you have more work to > >>> support write-zero requests with WRITE_UNCHANGED (which indeed sounds > >

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Christophe Lyon
On 30 April 2018 at 10:11, Peter Maydell wrote: > On 30 April 2018 at 09:03, Christophe Lyon wrote: >> Hello, >> >> This patch series implements the QEMU contribution of the FDPIC >> ABI for ARM targets. > > Hi; I definitely reviewed at least some of these patches, > but this respin seems to have

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 09:40, Christophe Lyon wrote: > On 30 April 2018 at 10:11, Peter Maydell wrote: >> On 30 April 2018 at 09:03, Christophe Lyon wrote: >>> Hello, >>> >>> This patch series implements the QEMU contribution of the FDPIC >>> ABI for ARM targets. >> >> Hi; I definitely reviewed at

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Christophe Lyon
On 30 April 2018 at 10:59, Peter Maydell wrote: > On 30 April 2018 at 09:40, Christophe Lyon wrote: >> On 30 April 2018 at 10:11, Peter Maydell wrote: >>> On 30 April 2018 at 09:03, Christophe Lyon wrote: Hello, This patch series implements the QEMU contribution of the FDPIC

[Qemu-devel] [PULL 07/42] linux-user: move microblaze signal.c parts to microblaze directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to microblaze/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-6-laur...@vivier.eu> --- linux-us

[Qemu-devel] [PULL 13/42] linux-user: move alpha signal.c parts to alpha directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to alpha/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-12

[Qemu-devel] [PULL 06/42] linux-user: move sh4 signal.c parts to sh4 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to sh4/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-5-laur...@vivier.eu> --- linux-user/sh4/

[Qemu-devel] [PULL 02/42] linux-user: Fix getdents emulation for 64 bit guest on 32 bit host

2018-04-30 Thread Laurent Vivier
From: Peter Maydell Currently we mishandle emulation of the getdents syscall for the case of a 64 bit guest on a 32 bit host -- it defaults into the 'host and guest same size' codepath and generates incorrect structures in the guest buffer. We can't easily handle the 64-on-32 case using the host

[Qemu-devel] [PULL 08/42] linux-user: move cris signal.c parts to cris directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to cris/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-7-laur...@vivier.eu> --- linux-user/cri

[Qemu-devel] [PULL 03/42] linux-user: create a dummy per arch signal.c

2018-04-30 Thread Laurent Vivier
Create a signal-common.h for future use by these new files and use it in the existing signal.c Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-2-laur...@vivier.eu> --- linux-user/Makefile.objs | 2 +- linux-user/aarc

[Qemu-devel] [PULL 24/42] linux-user: move i386/x86_64 cpu loop to i386 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to i386/cpu_loop.c. Include i386/cpu_loop.c in x86_64/cpu_loop.c to avoid to duplicate code. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-3-laur...@vivier.eu> --- linux-user/i386/cpu_loop.c | 343 +++

[Qemu-devel] [PULL 01/42] linux-user: set minimum uname for RISC-V

2018-04-30 Thread Laurent Vivier
From: Alex Bennée As support for RISC-V was only merged into the mainline kernel at 4.15 it is unlikely that glibc will be happy with a reported kernel version of 3.8.0. Indeed when I testing binaries created by the current Debian Sid compiler the tests failed with: FATAL: kernel too old Bump

[Qemu-devel] [PULL 09/42] linux-user: move nios2 signal.c parts to nios2 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to nios2/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-8-laur...@vivier.eu> --- linux-user/nios2/signal.c

[Qemu-devel] [PULL 05/42] linux-user: move arm signal.c parts to arm directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to arm/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-4-laur...@vivier.eu> --- linux-user/arm/

[Qemu-devel] [PULL 27/42] linux-user: move sparc/sparc64 cpu loop to sparc directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to sparc/cpu_loop.c. Include sparc/cpu_loop.c in sparc64/cpu_loop.c to avoid to duplicate code. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-6-laur...@vivier.eu> ---

[Qemu-devel] [PULL 04/42] linux-user: move aarch64 signal.c parts to aarch64 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to aarch64/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-3-laur...@vivier.eu> --- linux-user/

[Qemu-devel] [PULL 00/42] Linux user for 2.13 patches

2018-04-30 Thread Laurent Vivier
The following changes since commit 6f0c4706b35dead265509115ddbd2a8d1af516c1: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180427-pull-request' into staging (2018-04-27 12:27:59 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-2.1

[Qemu-devel] [PULL 12/42] linux-user: move m68k signal.c parts to m68k directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to m68k/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-11-laur...@vivier.eu> --- linux-user/m6

[Qemu-devel] [PULL 17/42] linux-user: move xtensa signal.c parts to xtensa directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to xtensa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-16-laur...@vivier.eu> --- linux-user/signal.c

[Qemu-devel] [PULL 22/42] linux-user: define TARGET_ARCH_HAS_SETUP_FRAME

2018-04-30 Thread Laurent Vivier
Instead of calling setup_frame() conditionally to a list of known targets, define TARGET_ARCH_HAS_SETUP_FRAME if the target provides the function and call it only if the macro is defined. Move declarations of setup_frame() and setup_rt_frame() to linux-user/signal-common.h Signed-off-by: Laurent

[Qemu-devel] [PULL 36/42] linux-user: move alpha cpu loop to alpha directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to alpha/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-15-laur...@vivier.eu> --- linux-user/alpha/cpu_loop.c | 199 +++

[Qemu-devel] [PULL 10/42] linux-user: move openrisc signal.c parts to openrisc directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to openrisc/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-9-laur...@vivier.eu> --- linux-user/openrisc/signal.c

[Qemu-devel] [PULL 40/42] linux-user: move hppa cpu loop to hppa directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to hppa/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-19-laur...@vivier.eu> --- linux-user/hppa/cpu_loop.c | 185 +

[Qemu-devel] [PULL 11/42] linux-user: move s390x signal.c parts to s390x directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to s390x/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Acked-by: Cornelia Huck Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-10-laur...@viv

[Qemu-devel] [PULL 16/42] linux-user: move hppa signal.c parts to hppa directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to hppa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-15-laur...@vivier.eu>

[Qemu-devel] [PULL 33/42] linux-user: move cris cpu loop to cris directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to cris/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-12-laur...@vivier.eu> --- linux-user/cris/cpu_loop.c | 89 ++

[Qemu-devel] [PULL 20/42] linux-user: move mips/mips64 signal.c parts to mips directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to mips/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). mips64/signal.c includes mips/signal.c Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henders

[Qemu-devel] [PULL 30/42] linux-user: move nios2 cpu loop to nios2 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to nios2/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-9-laur...@vivier.eu> --- linux-user/main.c | 133 linux-user/nios2/cpu_loop.c | 1

[Qemu-devel] [PULL 25/42] linux-user: move aarch64 cpu loop to aarch64 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to aarch64/cpu_loop.c and duplicate some macro defined for both arm and aarch64. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-4-laur...@vivier.eu> --- linux-user/aarch64/cpu_loop.c | 156 +++

[Qemu-devel] [PULL 34/42] linux-user: move microblaze cpu loop to microblaze directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to microblaze/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-13-laur...@vivier.eu> --- linux-user/main.c| 155 -

[Qemu-devel] [PULL 42/42] linux-user: Add ARM get_tls syscall support

2018-04-30 Thread Laurent Vivier
From: Christophe Lyon Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell Message-Id: <20180416091845.7315-1-christophe.l...@st.com> [lv: moved the change to linux-user/arm/cpu_loop.c] Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 3 +

[Qemu-devel] [PULL 32/42] linux-user: move sh4 cpu loop to sh4 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to sh4/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-11-laur...@vivier.eu> --- linux-user/main.c | 90

[Qemu-devel] [PULL 15/42] linux-user: move riscv signal.c parts to riscv directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to riscv/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-14-laur...@vivier.eu

[Qemu-devel] [PULL 31/42] linux-user: move openrisc cpu loop to openrisc directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to openrisc/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-10-laur...@vivier.eu> --- linux-user/main.c | 96 -- linux-user/openrisc/cpu_loo

[Qemu-devel] [PULL 26/42] linux-user: move arm cpu loop to arm directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to arm/cpu_loop.c and duplicate some macro defined for both arm and aarch64. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-5-laur...@vivier.eu> --- linux-user/arm/cpu_loop.c | 430 +++

[Qemu-devel] [PULL 35/42] linux-user: move m68k cpu loop to m68k directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to m68k/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-14-laur...@vivier.eu> --- linux-user/m68k/cpu_loop.c | 144 +++ linux-user/main.c | 150

[Qemu-devel] [PULL 28/42] linux-user: move ppc/ppc64 cpu loop to ppc directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to ppc/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-7-laur...@vivier.eu> --- linux-user/main.c | 560 +- linux-user/ppc/cpu_loop.c | 553 +

[Qemu-devel] [PULL 14/42] linux-user: move tilegx signal.c parts to tilegx directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to tilegx/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180424192635.6027-13-laur...@vivier.e

[Qemu-devel] [PULL 39/42] linux-user: move riscv cpu loop to riscv directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to riscv/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Michael Clark Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-18-laur...@vivier.eu> --- linux-user/main.c | 101 +--

[Qemu-devel] [PULL 38/42] linux-user: move tilegx cpu loop to tilegx directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to tilegx/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-17-laur...@vivier.eu> --- linux-user/main.c| 267 --- linux-user/tilegx/cpu_loop.c

[Qemu-devel] [PULL 21/42] linux-user: move ppc/ppc64 signal.c parts to ppc directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to ppc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-20-laur...@vivier.eu> --- linux-user/ppc

[Qemu-devel] [PULL 18/42] linux-user: move i386/x86_64 signal.c parts to i386 directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to i386/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). x86_64/signal.c includes i386/signal.c Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.6027-

[Qemu-devel] [PULL 29/42] linux-user: move mips/mips64 cpu loop to mips directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to mips/cpu_loop.c. Include mips/cpu_loop.c in mips64/cpu_loop.c to avoid to duplicate code. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-8-laur...@vivier.eu> --- l

[Qemu-devel] [PULL 23/42] linux-user: create a dummy per arch cpu_loop.c

2018-04-30 Thread Laurent Vivier
Create a cpu_loop-common.h for future use by these new files and use it in the existing main.c Introduce target_cpu_copy_regs(): declare the function in cpu_loop-common.h and an empty function for each target, to move all the cpu_loop prologues to this function. Signed-off-by: Laurent Vivier Rev

[Qemu-devel] [PULL 41/42] linux-user: move xtensa cpu loop to xtensa directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to xtensa/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20180411185651.21351-20-laur...@vivier.eu> --- linux-user/main.c| 250 --- linux-user/xtensa/cpu_loop.c

[Qemu-devel] [PULL 37/42] linux-user: move s390x cpu loop to s390x directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from main.c to s390x/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Acked-by: Cornelia Huck Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20180411185651.21351-16-laur...@vivier.eu> --- linux-user/main.c | 146 --

Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

2018-04-30 Thread Daniel P . Berrangé
On Sat, Apr 28, 2018 at 12:16:36PM +0800, 858585 jemmy wrote: > On Fri, Apr 27, 2018 at 5:16 PM, Daniel P. Berrangé > wrote: > so I prefer to add a lock for QEMUFile struct, like this: > > int qemu_fclose(QEMUFile *f) > { > int ret; > qemu_fflush(f); > ret = qemu_file_get_error(f); >

[Qemu-devel] [PULL 19/42] linux-user: move sparc/sparc64 signal.c parts to sparc directory

2018-04-30 Thread Laurent Vivier
No code change, only move code from signal.c to sparc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). sparc64/signal.c includes sparc/signal.c Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20180424192635.60

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 08:52, Alexey Kardashevskiy wrote: > diff --git a/qapi/misc.json b/qapi/misc.json > index 5636f4a..399ec74 100644 > --- a/qapi/misc.json > +++ b/qapi/misc.json > @@ -1491,6 +1491,10 @@ > # > # List properties associated with a device. > # > +# Note: the handler creates a device obj

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 10:28, Laurent Vivier wrote: > Le 30/04/2018 à 11:12, Peter Maydell a écrit : >> Great. Riku/Laurent -- I'm assuming you're going to take this set >> via the linux-user tree. > > I just sent a pull request without it... > > Do you prefer I update this one or I send another one

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 10:08, Christophe Lyon wrote: > On 30 April 2018 at 10:59, Peter Maydell wrote: >> On 30 April 2018 at 09:40, Christophe Lyon >> wrote: >>> On 30 April 2018 at 10:11, Peter Maydell wrote: On 30 April 2018 at 09:03, Christophe Lyon wrote: > Hello, > > This

Re: [Qemu-devel] [PATCH qemu v2 2/2] object: Handle objects with no parents

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 08:25, Alexey Kardashevskiy wrote: > At the moment object_get_canonical_path_component() crashes on assert() > if the object does not have a parent. Usually it is not called for > orphan objects but various HMP/QMP commands can do that (info mtree, > qom-get). > > This adds few more

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Laurent Vivier
Le 30/04/2018 à 11:46, Peter Maydell a écrit : > On 30 April 2018 at 10:28, Laurent Vivier wrote: >> Le 30/04/2018 à 11:12, Peter Maydell a écrit : >>> Great. Riku/Laurent -- I'm assuming you're going to take this set >>> via the linux-user tree. >> >> I just sent a pull request without it... >> >

Re: [Qemu-devel] [PATCH] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-30 Thread Cornelia Huck
On Thu, 26 Apr 2018 16:59:54 +0200 Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, even for virtual > consoles like spapr-v

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Laurent Vivier
Le 30/04/2018 à 11:12, Peter Maydell a écrit : > On 30 April 2018 at 10:08, Christophe Lyon wrote: >> On 30 April 2018 at 10:59, Peter Maydell wrote: >>> On 30 April 2018 at 09:40, Christophe Lyon >>> wrote: On 30 April 2018 at 10:11, Peter Maydell wrote: > On 30 April 2018 at 09:03,

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Cornelia Huck
On Fri, 27 Apr 2018 16:51:03 +0100 Peter Maydell wrote: > Hi; I usually let people forget about releases for a month or > so before bringing this topic up, but: > > (1) do we want to call the next release 2.13, or something else? > There's no particular reason to bump to 3.0 except some combinat

Re: [Qemu-devel] [PATCH v2 1/3] monitor: rename out_lock to mon_lock

2018-04-30 Thread Stefan Hajnoczi
On Wed, Apr 18, 2018 at 05:02:37PM +0800, Peter Xu wrote: > The out_lock was only protecting out buffers. In the future the monitor > code will start to run in multiple threads. We turn it into a bigger > lock to protect not only the out buffer but also all the rest. We split > this lock until n

Re: [Qemu-devel] [PATCH qemu v2 1/2] memory/hmp: Print owners/parents in "info mtree"

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 08:25, Alexey Kardashevskiy wrote: > +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, TYPE_DEVICE); > +const char *id = object_property_print(obj, "id", true, NULL); The only objects that have an "id" property are memdevs. If you want to special case their printi

[Qemu-devel] [PATCH] target/i386: sev: fix memory leaks

2018-04-30 Thread Paolo Bonzini
Reported by Coverity. Signed-off-by: Paolo Bonzini --- target/i386/sev.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index c01167143f..2395171acf 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 10:29, Cornelia Huck wrote: > On a related note: During the development phase, does it make more > sense to collect stuff until you have a big pile of patches, or is it > better (from an integration perspective) to do more frequent, smaller > pull requests? Generally my prefer

Re: [Qemu-devel] [PATCH qemu v4 1/2] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo

2018-04-30 Thread Paolo Bonzini
On 18/04/2018 18:35, Eric Blake wrote: > On 03/02/2018 06:25 PM, Alexey Kardashevskiy wrote: >> ObjectPropertyInfo is more generic and only missing @description. >> This adds a description to ObjectPropertyInfo and removes >> DevicePropertyInfo so the resulting ObjectPropertyInfo can be used >> els

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Paolo Bonzini
On 27/04/2018 18:42, Thomas Huth wrote: > On 27.04.2018 18:24, Peter Maydell wrote: >> (In the utopian far future I'd like us to have just one QEMU >> executable that could handle all architectures at once :-)) > > Yes, that would be great ... but that's really distant future, I guess. Not _that_

Re: [Qemu-devel] [PATCH] hw/block/nvme: Add doorbell buffer config support

2018-04-30 Thread Paolo Bonzini
Ping... Keith, can you review this? Thanks, Paolo On 05/03/2018 20:49, Huaicheng Li wrote: > This patch adds Doorbell Buffer Config support (NVMe 1.3) to QEMU NVMe, > based on Mihai Rusu / Lin Ming's Google vendor extension patch [1]. The > basic idea of this optimization is to use a shared buff

Re: [Qemu-devel] [PATCH v2 2/3] monitor: take mon_lock where proper

2018-04-30 Thread Stefan Hajnoczi
On Wed, Apr 18, 2018 at 05:02:38PM +0800, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index c93aa4e22b..f4951cafbc 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -306,16 +306,20 @@ void monitor_read_command(Monitor *mon, int show_prompt) > if (!mon->rs) > return; > > +

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 11:06, Paolo Bonzini wrote: > On 27/04/2018 18:42, Thomas Huth wrote: >> On 27.04.2018 18:24, Peter Maydell wrote: >>> (In the utopian far future I'd like us to have just one QEMU >>> executable that could handle all architectures at once :-)) >> >> Yes, that would be great ...

Re: [Qemu-devel] [PATCH v2 3/3] monitor: add lock to protect mon_fdsets

2018-04-30 Thread Stefan Hajnoczi
On Wed, Apr 18, 2018 at 05:02:39PM +0800, Peter Xu wrote: > Similar to previous patch, but introduce a new global big lock for > mon_fdsets. Take it where needed. Looks like monitor_fdset_get_fd() is missing. signature.asc Description: PGP signature

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 04:51:03PM +0100, Peter Maydell wrote: > Hi; I usually let people forget about releases for a month or > so before bringing this topic up, but: > > (1) do we want to call the next release 2.13, or something else? > There's no particular reason to bump to 3.0 except some com

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 09:01:20PM +0200, Michal Suchánek wrote: > On Fri, 27 Apr 2018 17:24:38 +0100 > Peter Maydell wrote: > > > On 27 April 2018 at 17:17, Thomas Huth wrote: > > > On 27.04.2018 17:51, Peter Maydell wrote: > > >> Hi; I usually let people forget about releases for a month or

Re: [Qemu-devel] [RFC PATCH] mmio-exec: Make device return MemoryRegion rather than host pointer

2018-04-30 Thread Paolo Bonzini
On 26/04/2018 17:09, Peter Maydell wrote: > > QUESTIONS: > * do we really need to postpone things from >memory_region_invalidate_mmio_ptr() to >memory_region_do_invalidate_mmio_ptr(), given that the deletion of >the memory region and ramblock is RCU-deferred anyway? > * should we add

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Cornelia Huck
On Mon, 30 Apr 2018 11:33:12 +0100 Daniel P. Berrangé wrote: > On Fri, Apr 27, 2018 at 04:51:03PM +0100, Peter Maydell wrote: > > Hi; I usually let people forget about releases for a month or > > so before bringing this topic up, but: > > > > (1) do we want to call the next release 2.13, or some

Re: [Qemu-devel] [PATCH 2/3] nvdimm, acpi: add NFIT platform capabilities

2018-04-30 Thread Stefan Hajnoczi
On Fri, Apr 27, 2018 at 03:53:13PM -0600, Ross Zwisler wrote: > Add support for the NFIT Platform Capabilities Structure, newly added in > ACPI 6.2 Errata A. > > Signed-off-by: Ross Zwisler > --- > hw/acpi/nvdimm.c | 32 > 1 file changed, 32 insertions(+) Review

Re: [Qemu-devel] [PATCH 3/3] nvdimm: platform capabilities command line option

2018-04-30 Thread Stefan Hajnoczi
On Fri, Apr 27, 2018 at 03:53:14PM -0600, Ross Zwisler wrote: > Add a device command line option to allow the user to control the Platform > Capabilities Structure in the virtualized NFIT. > > Signed-off-by: Ross Zwisler > --- > docs/nvdimm.txt | 22 ++ > hw/acpi/nvdi

Re: [Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition

2018-04-30 Thread Stefan Hajnoczi
On Fri, Apr 27, 2018 at 03:53:12PM -0600, Ross Zwisler wrote: > Signed-off-by: Ross Zwisler > Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") > Cc: Haozhong Zhang > Cc: Michael S. Tsirkin > Cc: Stefan Hajnoczi > --- > hw/mem/nvdimm.c | 2 +- > include/hw/me

Re: [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 10:09, Laurent Vivier wrote: > The following changes since commit 6f0c4706b35dead265509115ddbd2a8d1af516c1: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180427-pull-request' into staging (2018-04-27 > 12:27:59 +0100) > > are available in the Git repository

Re: [Qemu-devel] [ARM/FDPIC v4 0/4] FDPIC ABI for ARM

2018-04-30 Thread Laurent Vivier
Le 30/04/2018 à 11:46, Peter Maydell a écrit : > On 30 April 2018 at 10:28, Laurent Vivier wrote: >> Le 30/04/2018 à 11:12, Peter Maydell a écrit : >>> Great. Riku/Laurent -- I'm assuming you're going to take this set >>> via the linux-user tree. >> >> I just sent a pull request without it... >> >

[Qemu-devel] [Bug 1762179] Re: Record and replay replay fails with: "ERROR:replay/replay-time.c:49:replay_read_clock: assertion failed"

2018-04-30 Thread Ciro Santilli 六四事件 法轮功
@arna35: I have tested this yet unmerged patch: https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg04286.html and it solves this problem, I will close this issue once it gets merged. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

[Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Peter Maydell
Add more detail to the documentation for memory_region_init_iommu() and other IOMMU-related functions and data structures. Signed-off-by: Peter Maydell --- I've been trying to understand how the IOMMU support works, with a vague idea of extending it to be able to use it to implement the Arm Trust

[Qemu-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup

2018-04-30 Thread Paul Durrant
The grant copy operation was added to libxengnttab in Xen 4.8.0 (released nearly 18 months ago) but the xen_disk PV backend QEMU is still carrying a significant amount of code purely to remain compatible with older versions of Xen. As can be inferred from the diff stats below, removing this suppor

[Qemu-devel] [PATCH 1/4] block/xen_disk: remove persistent grant code

2018-04-30 Thread Paul Durrant
The grant copy operation was added to libxengnttab in Xen 4.8.0. If grant copy is available then persistent grants will not be used. The xen_disk source can be siginificantly simplified by removing this now redundant code. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard

[Qemu-devel] [PATCH 3/4] block/xen_disk: use a single entry iovec

2018-04-30 Thread Paul Durrant
Since xen_disk now always copies data to and from a guest there is no need to maintain a vector entry corresponding to every page of a request. This means there is less per-request state to maintain so the ioreq structure can shrink significantly. Signed-off-by: Paul Durrant --- Cc: Stefano Stabe

[Qemu-devel] [PATCH 4/4] block/xen_disk: be consistent with use of xendev and blkdev->xendev

2018-04-30 Thread Paul Durrant
Certain functions in xen_disk are called with a pointer to xendev (struct XenDevice *). They then use continer_of() to acces the surrounding blkdev (struct XenBlkDev) but then in various places use &blkdev->xendev when use of the original xendev pointer is shorter to express and clearly equivalent.

[Qemu-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-04-30 Thread Paul Durrant
The grant copy operation was added to libxengnttab in Xen 4.8.0. If grant copy is available then data from the guest will be copied rather than mapped. The xen_disk source can be significantly simplified by removing this now redundant code. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini

[Qemu-devel] [PATCH v2 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset

2018-04-30 Thread Stefan Hajnoczi
From: Pasi Savanainen Check that a commit log doesn't contain UTF-8 when a mail header explicitly defines a different charset, like 'Content-Type: text/plain; charset="us-ascii"' Signed-off-by: Pasi Savanainen Cc: Joe Perches Cc: Andy Whitcroft Signed-off-by: Andrew Morton Signed-off-by: Li

[Qemu-devel] [PATCH v2 1/5] checkpatch: add a --strict check for utf-8 in commit logs

2018-04-30 Thread Stefan Hajnoczi
From: Joe Perches Some find using utf-8 in commit logs inappropriate. Some patch commit logs contain unintended utf-8 characters when doing things like copy/pasting compilation output. Look for the start of any commit log by skipping initial lines that look like email headers and "From: " lines

[Qemu-devel] [PATCH v2 5/5] checkpatch: reduce MAINTAINERS update message frequency

2018-04-30 Thread Stefan Hajnoczi
From: Joe Perches When files are being added/moved/deleted and a patch contains an update to the MAINTAINERS file, assume it's to update the MAINTAINERS file correctly and do not emit the "does MAINTAINERS need updating?" message. Reported by many people. Signed-off-by: Joe Perches Signed-off-

  1   2   3   >