On 28/04/2018 05:14, Peter Xu wrote: >> # git grep imrc-\>translate\ = >> hw/alpha/typhoon.c: imrc->translate = typhoon_translate_iommu; >> hw/dma/rc4030.c: imrc->translate = rc4030_dma_translate; >> hw/i386/amd_iommu.c: imrc->translate = amdvi_translate; >> hw/i386/intel_iommu.c: imrc->translate = vtd_iommu_translate; >> hw/ppc/spapr_iommu.c: imrc->translate = spapr_tce_translate_iommu; >> hw/s390x/s390-pci-bus.c: imrc->translate = s390_translate_iommu; >> hw/sparc/sun4m_iommu.c: imrc->translate = sun4m_translate_iommu; >> hw/sparc64/sun4u_iommu.c: imrc->translate = sun4u_translate_iommu; > Sorry I didn't notice this one. This point is valid. But again, we > need to know whether they are thread-safe already. For VT-d, it never > hurt to have this patch to fix its own problem, so above is not a > reason to not have current patch, since it solves different problems. > Basically I'll see the solution of above problem as a separate patch > as current one.
If they are not thread-safe, we fix them too. They are not many. Paolo
