Re: [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-04-18 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Apr 17, 2018 at 05:41:10PM +0200, Igor Mammedov wrote: >> On Tue, 17 Apr 2018 11:27:39 -0300 >> Eduardo Habkost wrote: >> >> > On Tue, Apr 17, 2018 at 04:13:34PM +0200, Markus Armbruster wrote: >> > > Igor Mammedov writes: >> > > >> > > [...] >> > > > Serie

Re: [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

2018-04-18 Thread Markus Armbruster
John Snow writes: > On 04/17/2018 09:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> This series seeks to address two distinct but closely related issues >>> concerning the job management API. >>> >>> (1) For jobs that complete when a monitor is not attached and receiving >>> ev

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

2018-04-18 Thread Cornelia Huck
On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: > On 04/16/2018 05:44 PM, David Hildenbrand wrote: > > > >> > >> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > >> index 0cdbc15..0d5b0f7 100644 > >> --- a/target/s390x/gen-features.c > >> +++ b/target/

[Qemu-devel] [PATCH v2 1/1] xilinx_spips: send dummy cycles only if cmd requires it

2018-04-18 Thread Sai Pavan Boddu
For all the commands, which do not have an entry in xilinx_spips_num_dummies, present logic sends dummy cycles when ever we are in SNOOP_NONE state, fix it to only send dummy cycles if the cmd requires them. SNOOP_NONE state handle is moved above (previously its part of default else case), as its

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-18 Thread Markus Armbruster
Peter Xu writes: > On Wed, Apr 18, 2018 at 01:12:24PM +0800, Stefan Hajnoczi wrote: >> On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: >> > Stefan Hajnoczi writes: >> > >> > > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: >> > >> On Mon, Apr 16, 2018 at 04:37:48PM

[Qemu-devel] [PATCH v1] configure: recognize more rpmbuild macros

2018-04-18 Thread Olaf Hering
Extend the list of recognized, but ignored options from rpms %configure macro. This fixes build on hosts running SUSE Linux. Signed-off-by: Olaf Hering --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 0a19b033bc..6e9b994f21 100755 --- a/configure +

Re: [Qemu-devel] [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks

2018-04-18 Thread Cornelia Huck
On Tue, 17 Apr 2018 21:58:21 +0300 "Michael S. Tsirkin" wrote: > It turns out (as will be clear from follow-up patches) > we do not really need any kvm para macros host side > for now, except on x86, and there we need it > unconditionally whether we run on kvm or we don't. > > Import the x86 asm

[Qemu-devel] [PATCH v2 0/1] xilinx_spips dummy bytes fix

2018-04-18 Thread Sai Pavan Boddu
For zynq-7000 boards, we saw issues when u-boot/linux accessing the qspi. Issue is due to wrong dummy byte transfers for few of un-handled commands ex: 0x9F, 0x6, 0xe9, 0x4, 0x18, etc There are many unhandled commands which do not require dummy bytes but they can be followed by address cycles. T

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-18 Thread Peter Xu
On Wed, Apr 18, 2018 at 09:45:27AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Apr 18, 2018 at 01:12:24PM +0800, Stefan Hajnoczi wrote: > >> On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: > >> > Stefan Hajnoczi writes: > >> > > >> > > On Mon, Apr 16, 201

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-18 Thread Bob Chen
I found that it has nothing to do with the release version, but the github one is just not able to work... So what github and qemu.org provide are totally different things? 2018-04-18 14:52 GMT+08:00 Bob Chen : > No, I downloaded the release tarball from github. > > 2018-04-18 14:25 GMT+08:00

[Qemu-devel] [PATCH v1] roms/ipxe: use configured compiler for ipxe

2018-04-18 Thread Olaf Hering
configure allows to run a dedicated compiler binary, which is stored in CC and HOST_CC variables, and overrides the default 'cc' command. This command however is not used when building ipxe from source. "make -C roms pxerom" invokes the buildsystem of ipxe.git, which has the command "gcc" hardcode

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 08:02, Gerd Hoffmann wrote: > On Wed, Apr 18, 2018 at 12:40:54AM +0200, Laszlo Ersek wrote: >> Add a schema that describes the different uses and properties of >> virtual machine firmware. > > Looks good to me overall. > >> +{ 'enum' : 'FirmwareType', >> + 'data' : [ 'bios', 'slof', 'u

Re: [Qemu-devel] [PATCH v1] roms/ipxe: use configured compiler for ipxe

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 10:13:10 +0200 schrieb Olaf Hering : > configure allows to run a dedicated compiler binary, which is stored in > CC and HOST_CC variables, and overrides the default 'cc' command. > This command however is not used when building ipxe from source. > "make -C roms pxerom" invokes

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-18 Thread Dr. David Alan Gilbert
* Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > > On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > > > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > > > expected_downtime value is not accurate w

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Markus Armbruster
Mostly quick QAPI schema style review, as I know next to nothing about the subject matter. Laszlo Ersek writes: > Add a schema that describes the different uses and properties of virtual > machine firmware. > > Each firmware executable installed on a host system should come with at > least one J

[Qemu-devel] [PATCH 1/3] monitor: rename out_lock to mon_lock

2018-04-18 Thread Peter Xu
The out_lock was only protecting out buffers. In the future the monitor code will start to run in multiple threads. We turn it into a bigger lock to protect not only the out buffer but also all the rest. We split this lock until necessary. So far I don't see a reason to complicate lock usage fo

[Qemu-devel] [PATCH 2/3] monitor: take mon_lock where proper

2018-04-18 Thread Peter Xu
Went through all the montior.h APIs to make sure existing Monitor related APIs will always take the new monitor lock when necessary. Signed-off-by: Peter Xu --- monitor.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

2018-04-18 Thread David Hildenbrand
On 18.04.2018 09:40, Cornelia Huck wrote: > On Tue, 17 Apr 2018 20:21:31 +0200 > Christian Borntraeger wrote: > >> On 04/16/2018 05:44 PM, David Hildenbrand wrote: >>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 0cdbc15..0d5b0f7 100644 ---

[Qemu-devel] [PATCH 0/3] monitor: let Monitor be thread safe

2018-04-18 Thread Peter Xu
Stefan reported this problem that in the future we might start to have more threads operating on the same Monitor object. This seris try to add fundamental support for it. Patch 1 renames the old out_lock to mon_lock, so that it can cover more things. Patch 2 uses the mon_lock to protect Monitor

[Qemu-devel] [PATCH 3/3] monitor: add lock to protect mon_fdsets

2018-04-18 Thread Peter Xu
Similar to previous patch, but introduce a new global big lock for mon_fdsets. Take it where needed. Signed-off-by: Peter Xu --- monitor.c | 48 ++-- 1 file changed, 42 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index f4951cafbc

[Qemu-devel] [PATCH v2 3/3] monitor: add lock to protect mon_fdsets

2018-04-18 Thread Peter Xu
Similar to previous patch, but introduce a new global big lock for mon_fdsets. Take it where needed. Signed-off-by: Peter Xu --- monitor.c | 48 ++-- 1 file changed, 42 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index f4951cafbc

[Qemu-devel] [PATCH v2 0/3] monitor: let Monitor be thread safe

2018-04-18 Thread Peter Xu
v2: - cc correct people... sorry. Stefan reported this problem that in the future we might start to have more threads operating on the same Monitor object. This seris try to add fundamental support for it. Patch 1 renames the old out_lock to mon_lock, so that it can cover more things. Patch 2 u

[Qemu-devel] [PATCH] QemuMutex: support --enable-debug-mutex

2018-04-18 Thread Peter Xu
We have had some tracing tools for mutex but it's not easy to use them for e.g. dead locks. Let's provide "--enable-debug-mutex" parameter when configure to allow QemuMutex to store the last owner that took specific lock. It might be extremely easy to use this tool to debug deadlocks since we can

[Qemu-devel] [PATCH v2 2/3] monitor: take mon_lock where proper

2018-04-18 Thread Peter Xu
Went through all the montior.h APIs to make sure existing Monitor related APIs will always take the new monitor lock when necessary. Signed-off-by: Peter Xu --- monitor.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Gerd Hoffmann
> This surfaced in the RFCv1 discussion, but Daniel suggested ignoring > version numbers: > > 20180410093412.GI5155@redhat.com">http://mid.mail-archive.com/20180410093412.GI5155@redhat.com > > On 04/10/18 11:34, Daniel P. Berrangé wrote: > > IMHO it would be valid to just keep life simple and onl

[Qemu-devel] [PATCH v2 1/3] monitor: rename out_lock to mon_lock

2018-04-18 Thread Peter Xu
The out_lock was only protecting out buffers. In the future the monitor code will start to run in multiple threads. We turn it into a bigger lock to protect not only the out buffer but also all the rest. We split this lock until necessary. So far I don't see a reason to complicate lock usage fo

[Qemu-devel] [PATCH v2] QemuMutex: support --enable-debug-mutex

2018-04-18 Thread Peter Xu
We have had some tracing tools for mutex but it's not easy to use them for e.g. dead locks. Let's provide "--enable-debug-mutex" parameter when configure to allow QemuMutex to store the last owner that took specific lock. It might be extremely easy to use this tool to debug deadlocks since we can

Re: [Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-04-18 Thread Pierre Morel
On 15/04/2018 21:07, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device dri

Re: [Qemu-devel] [PATCH v4 2/5] s390x/ap: base Adjunct Processor (AP) object

2018-04-18 Thread Pierre Morel
On 15/04/2018 21:07, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 39 +++ include/hw/s390x/ap-device.h | 38 ++

Re: [Qemu-devel] [RFC 17/18] validator.py script

2018-04-18 Thread Eduardo Habkost
On Wed, Apr 18, 2018 at 08:58:00AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Apr 17, 2018 at 02:01:53PM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > [...] > >> > +command-line: '$QEMU -nodefaults -machine none' > >> > +monitor-commands: > >

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 08:32, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 17/04/2018 14:18, Igor Mammedov wrote: What's the point of an object name if it cannot be unique? >>> It should be sufficient for it to be unique within parent's >>> scope and object_property_add_child() should mak

Re: [Qemu-devel] [PATCH v1] configure: recognize more rpmbuild macros

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 09:50, Olaf Hering wrote: > Extend the list of recognized, but ignored options from rpms %configure > macro. This fixes build on hosts running SUSE Linux. > > Signed-off-by: Olaf Hering > --- > configure | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure b/confi

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-18 Thread Peter Maydell
On 18 April 2018 at 09:09, Bob Chen wrote: > I found that it has nothing to do with the release version, but the github > one is just not able to work... > > So what github and qemu.org provide are totally different things? The "tarballs" from github don't work and can't work, but github provides

Re: [Qemu-devel] [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 06.04.2018 um 10:04 hat Kevin Wolf geschrieben: > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > > > This patch introdu

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test new qemu-nbd --nolist option

2018-04-18 Thread Vladimir Sementsov-Ogievskiy
17.04.2018 22:56, Eric Blake wrote: On 04/13/2018 02:26 PM, Nir Soffer wrote: Add new test module for tesing the --nolist option. Signed-off-by: Nir Soffer --- +iotests.log('Check that listing exports is allowed by default') +disk, nbd_sock = iotests.file_path('disk1', 'nbd-sock1') +iotests.qe

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 00:40, Laszlo Ersek wrote: > +# > +# Lists firmware types commonly used with QEMU virtual machines. > +# > +# @bios: The firmware was built from the SeaBIOS project. > +# > +# @slof: The firmware was built from the Slimline Open Firmware project. > +# > +# @uboot: The firmware was bui

Re: [Qemu-devel] [Qemu-ppc] [PATCH for 2.13] spapr: Correct max associativity domains value for non-NUMA configs

2018-04-18 Thread Greg Kurz
On Wed, 18 Apr 2018 11:49:08 +1000 David Gibson wrote: > On Tue, Apr 17, 2018 at 07:17:51PM +0200, Greg Kurz wrote: > > Cc'ing David who should always be in the recipient list when posting ppc > > related > > patches :) > > > > On Tue, 17 Apr 2018 12:21:35 -0400 > > Serhii Popovych wrote: > >

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-18 Thread Bob Chen
I think you can edit the github's repo description to tell people not to download release from this site. 2018-04-18 17:29 GMT+08:00 Peter Maydell : > On 18 April 2018 at 09:09, Bob Chen wrote: > > I found that it has nothing to do with the release version, but the > github > > one is just not a

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-18 Thread Alex Bennée
Bob Chen writes: > I found that it has nothing to do with the release version, but the github > one is just not able to work... > > So what github and qemu.org provide are totally different things? AFAICT github generates those tarballs automatically whenever it sees a tag. But it's not the sam

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-18 Thread Alex Bennée
Bob Chen writes: > I think you can edit the github's repo description to tell people not to > download release from this site. I've updated the repo description. Official QEMU mirror. Please see http://wiki.qemu.org/Contribute/SubmitAPatch for how to submit changes to QEMU. Pull Requests

[Qemu-devel] [PATCH] configure: add sanity check to catch builds from "git archive"

2018-04-18 Thread Daniel P . Berrangé
The "git archive" feature creates tarballs which are missing all submodule content. GitHub unhelpfully provides users with "Download" links that claim to give them valid source release tarballs. These GitHub archives will not be buildable as they are created by the "git archive" feature and so are

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 10:29:35AM +0100, Peter Maydell wrote: > On 18 April 2018 at 09:09, Bob Chen wrote: > > I found that it has nothing to do with the release version, but the github > > one is just not able to work... > > > > So what github and qemu.org provide are totally different things? >

[Qemu-devel] [PATCH v1 0/2] riscv: htif fixes

2018-04-18 Thread KONRAD Frederic
Hi all, Here are some fixes for the HTIF device. I saw some changing behavior since I use qemu upstream instead of the RISC-V fork because the htif can't be based to 0 anymore. The first patch address that issue. The second patch fixes the priority of the htif subregion as I don't think we guar

Re: [Qemu-devel] [PATCH] configure: add sanity check to catch builds from "git archive"

2018-04-18 Thread Peter Maydell
On 18 April 2018 at 11:11, Daniel P. Berrangé wrote: > The "git archive" feature creates tarballs which are missing all > submodule content. GitHub unhelpfully provides users with "Download" > links that claim to give them valid source release tarballs. These > GitHub archives will not be buildabl

[Qemu-devel] [PATCH v1 1/2] riscv: spike: allow base == 0

2018-04-18 Thread KONRAD Frederic
The sanity check on base doesn't allow htif to be mapped @0. Check if the symbol exists instead so we can map it where we want. Signed-off-by: KONRAD Frederic --- hw/riscv/riscv_htif.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/ris

[Qemu-devel] [PATCH v1 2/2] riscv: htif: increase the priority of the htif subregion

2018-04-18 Thread KONRAD Frederic
The htif device is supposed to be mapped over an other subregion. So increase its priority to one to avoid any conflict. Here is the output of info mtree: Before: (qemu) info mtree address-space: memory - (prio 0, i/o): system -

Re: [Qemu-devel] [PATCH] m68k: fix subx mem, mem instruction

2018-04-18 Thread Laurent Vivier
Le 18/04/2018 à 08:41, Pavel Dovgalyuk a écrit : > This patch fixes decrement of the pointers for subx mem, mem instructions. > Without the patch pointers are decremented by OS_* constant value instead of > retrieving the corresponding data size and using it as a decrement. > > Signed-off-by: Pave

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Marc-André Lureau
Hi On Tue, Apr 17, 2018 at 8:36 PM, Philippe Mathieu-Daudé wrote: > Hi, > On 16 April 2018 at 19:18, Marc-André Lureau wrote: > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > regression, but was inadvertently broken again in merge commit > 2d6752d38d

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 12:36, Marc-André Lureau wrote: > > +if (chr == NULL || chr->be) { > +name = g_strdup_printf("discarding-serial%d", i); > +chr = qemu_chr_new(name, "null"); > +} else { > +name = g_strdup_printf("serial%d", i); >

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

2018-04-18 Thread Halil Pasic
On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index 3b9e274..5ee3a2d 100644 --- a/target/s390x/cpu_features.

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

2018-04-18 Thread Zhang, Yulei
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, April 17, 2018 10:35 PM > To: Zhang, Yulei > Cc: qemu-devel@nongnu.org; Tian, Kevin ; > joonas.lahti...@linux.intel.com; zhen...@linux.intel.com; > kwankh...@nvidia.com; Wang, Zhi A ; > dgil

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

2018-04-18 Thread David Hildenbrand
On 18.04.2018 12:55, Halil Pasic wrote: > > > On 04/15/2018 09:07 PM, Tony Krowiak wrote: >> A new CPU model feature and two new CPU model facilities are >> introduced to support AP devices for a KVM guest. > [..] >> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c >> index

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

2018-04-18 Thread Dr. David Alan Gilbert
* Zhang, Yulei (yulei.zh...@intel.com) wrote: > > > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, April 17, 2018 10:35 PM > > To: Zhang, Yulei > > Cc: qemu-devel@nongnu.org; Tian, Kevin ; > > joonas.lahti...@linux.intel.com; zhen...

Re: [Qemu-devel] [PATCH] ppc: e500: switch E500 based machines to full machine definition

2018-04-18 Thread David Gibson
On Tue, Apr 17, 2018 at 06:34:05PM +0200, Igor Mammedov wrote: > Convert PPCE500Params to PCCE500MachineClass which it essentially is, > and introduce PCCE500MachineState to keep track of E500 specific > state instead of adding global variables or extra parameters to > functions when we need to kee

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Marc-André Lureau
Hi On Wed, Apr 18, 2018 at 12:55 PM, Paolo Bonzini wrote: > On 18/04/2018 12:36, Marc-André Lureau wrote: >> >> +if (chr == NULL || chr->be) { >> +name = g_strdup_printf("discarding-serial%d", i); >> +chr = qemu_chr_new(name, "null"); >> +}

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 10:47, Markus Armbruster wrote: > Laszlo Ersek writes: >> +## >> +# @FirmwareArchitecture: >> +# >> +# Defines the target architectures (emulator binaries) that firmware may >> +# execute on. >> +# >> +# @aarch64: The firmware can be executed by the qemu-system-aarch64 >> emulator. >

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 11:04, Gerd Hoffmann wrote: >> This surfaced in the RFCv1 discussion, but Daniel suggested ignoring >> version numbers: >> >> 20180410093412.GI5155@redhat.com">http://mid.mail-archive.com/20180410093412.GI5155@redhat.com >> >> On 04/10/18 11:34, Daniel P. Berrangé wrote: >>> IMHO it wou

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

2018-04-18 Thread Pierre Morel
On 18/04/2018 13:03, David Hildenbrand wrote: On 18.04.2018 12:55, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b/tar

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 11:43, Paolo Bonzini wrote: > On 18/04/2018 00:40, Laszlo Ersek wrote: >> +# >> +# Lists firmware types commonly used with QEMU virtual machines. >> +# >> +# @bios: The firmware was built from the SeaBIOS project. >> +# >> +# @slof: The firmware was built from the Slimline Open Firmware

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 13:35, Marc-André Lureau wrote: >> CharBackend is not the frontend, it is *used* by the front-end. It is >> the qemu_chr_* functions that are named wrong (they're named according >> to the user rather than the recipient). > If I follow you and the naming, you have this in mind: > >

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 01:48:10PM +0200, Laszlo Ersek wrote: > On 04/18/18 11:04, Gerd Hoffmann wrote: > >> This surfaced in the RFCv1 discussion, but Daniel suggested ignoring > >> version numbers: > >> > >> 20180410093412.GI5155@redhat.com">http://mid.mail-archive.com/20180410093412.GI5155@redha

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 01:52:19PM +0200, Laszlo Ersek wrote: > On 04/18/18 11:43, Paolo Bonzini wrote: > > On 18/04/2018 00:40, Laszlo Ersek wrote: > >> +# > >> +# Lists firmware types commonly used with QEMU virtual machines. > >> +# > >> +# @bios: The firmware was built from the SeaBIOS project.

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Peter Maydell
On 18 April 2018 at 11:36, Marc-André Lureau wrote: > In commit cd9526ab7c04f2c32c63340b04401f6ed25682b9 > Author: Philippe Mathieu-Daudé > Date: Thu Mar 8 23:39:32 2018 +0100 > > hw/isa/superio: Factor out the serial code from pc87312.c > > You changed from: > > -if (chr == NU

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Marc-André Lureau
Hi On Wed, Apr 18, 2018 at 1:55 PM, Paolo Bonzini wrote: > On 18/04/2018 13:35, Marc-André Lureau wrote: >>> CharBackend is not the frontend, it is *used* by the front-end. It is >>> the qemu_chr_* functions that are named wrong (they're named according >>> to the user rather than the recipient)

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Gerd Hoffmann
Hi, > Hmmm, I'm not sure I agree. One use case is that you want a domain > config in which well-known OS-es, signed by the MS UEFI certs, just boot > with SB enabled. (Some of our internal folks really want this.) > > Another use case is that you want a domain in which SB *can* be enabled, > bu

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Gerd Hoffmann
Hi, > So now the question is should this string be declared to be > glob format, or regex format. Regex is more flexible, but > regex syntax is ill-defined because every regex engine is > slightly different. I'd go for glob. It's good enough for the version number and most likely we don't need

[Qemu-devel] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements

2018-04-18 Thread Thomas Huth
Some patches to improve the network boot experience on s390x: First, make sure that we shut down the virtio-net device before jumping into the kernel. Otherwise some incoming packets might destroy some of the kernel's data if it has not taken over the device yet. Then the last two patches add sup

[Qemu-devel] [PATCH v1 for-2.13 2/4] pc-bios/s390-ccw/net: Stop virtio-net device before jumping into the OS

2018-04-18 Thread Thomas Huth
The virtio-net receive buffers are filled asynchronously, so we should make sure to properly shut down the virtio-net device before we jump into the loaded kernel. Otherwise an incoming packet could destroy memory of the OS kernel if it did not re-initialize the virtio-net device fast enough yet.

[Qemu-devel] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts

2018-04-18 Thread Thomas Huth
When we want to support pxelinux-style network booting later, we've got to do several TFTP transfers - and we do not want to apply for a new IP address via DHCP each time. So split up net_load into three parts: 1. net_init(), which initializes virtio-net, gets an IP address via DHCP and prints

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 02:30:02PM +0200, Gerd Hoffmann wrote: > Hi, > > > So now the question is should this string be declared to be > > glob format, or regex format. Regex is more flexible, but > > regex syntax is ill-defined because every regex engine is > > slightly different. > > I'd go f

[Qemu-devel] [PATCH v1 for-2.13 4/4] pc-bios/s390-ccw/net: Add support for .INS config files

2018-04-18 Thread Thomas Huth
The .INS config files can normally be found on CD-ROM ISO images, so by supporting these files, it is now possible to boot directly when the TFTP server is set up with the contents of such an CD-ROM image. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 51 +++

[Qemu-devel] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-18 Thread Thomas Huth
Since it is quite cumbersome to manually create a combined kernel with initrd image for network booting, we now support loading via pxelinux configuration files, too. In these files, the kernel, initrd and command line parameters can be specified seperately, and the firmware then takes care of glue

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Gerd Hoffmann
Hi, >"features": [ > "bios" > "uefi", >], > > means a traditional BIOS firmware with compat for UEFI (thinking uboot > being able to include uefi support in this case) Well, uboot is it's own world, I would write that as [ "uboot", "uefi" ]. I like the idea t

[Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Olaf Hering
Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. Fixes commit 418026ca43 ("util: Introduce vfio helpers") Signed-off-by: Olaf Hering --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6e9b994f21..81760ef45a 1

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 14:03, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 01:52:19PM +0200, Laszlo Ersek wrote: >> On 04/18/18 11:43, Paolo Bonzini wrote: >>> On 18/04/2018 00:40, Laszlo Ersek wrote: +# +# Lists firmware types commonly used with QEMU virtual machines. +# +# @bios:

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Cornelia Huck
On Wed, 18 Apr 2018 14:38:37 +0200 Olaf Hering wrote: > Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Signed-off-by: Olaf Hering > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote: > Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. > Fixes commit 418026ca43 ("util: Introduce vfio helpers") Normally we expect ./include/glib-compat.h to be changed in this scenario to add compat for the mi

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 02:45:38PM +0200, Cornelia Huck wrote: > On Wed, 18 Apr 2018 14:38:37 +0200 > Olaf Hering wrote: > > > Since usage of g_realloc_n was introduced, glib-2.22 can not be used > > anymore. > > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > > > Signed-off-by: Ol

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 14:23, Gerd Hoffmann wrote: > Hi, > >> Hmmm, I'm not sure I agree. One use case is that you want a domain >> config in which well-known OS-es, signed by the MS UEFI certs, just boot >> with SB enabled. (Some of our internal folks really want this.) >> >> Another use case is that you

Re: [Qemu-devel] [PATCH v3 0/2] Give the refcount cache the minimum possible size by default

2018-04-18 Thread Max Reitz
On 2018-04-17 14:37, Alberto Garcia wrote: > Hi, > > we talked about this the other day, so here are the patches to change > the default cache sizes in qcow2. > > Without this patch: > > * refcount-cache-size = l2-cache-size / 4 > > unless otherwise specified by the user. This is wasteful, the

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 14:32, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 02:30:02PM +0200, Gerd Hoffmann wrote: >> Hi, >> >>> So now the question is should this string be declared to be >>> glob format, or regex format. Regex is more flexible, but >>> regex syntax is ill-defined because every regex

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 13:47:53 +0100 schrieb Daniel P. Berrangé : > IIRC, one of Peters desired build targets required 2.22, but I guess we > missed this bug because that platform would not enable vfio functionality ? Does the check in configure need a wrap "if Linux", just as the Makefile does? O

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 05:53:58 -0700 (PDT) schrieb no-re...@patchew.org: > This series failed docker-build@min-glib build test. I guess that test must be fixed either way because it does not test what it is supposed to test... Olaf pgpgzq5OJ4fiN.pgp Description: Digitale Signatur von OpenPGP

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Gerd Hoffmann
> > Other question: Do we want allow to specify which certs/keys are > > enrolled? Which would probably mean to drop "enrolled-keys" from > > features and make it an optional string instead, > > Not an enum? "Microsoft" below should be an enum constant, shouldn't it? I don't think so. If we wa

Re: [Qemu-devel] [PATCH] qemu-progress: redirct qemu progress message to another file stream

2018-04-18 Thread Max Reitz
On 2018-04-16 09:46, zhenwei pi wrote: > currently qemu progress message only print into stdout, and other thread may > print some log into stdout at the same time. > add a new api qemu_progress_set_output to redirect progress message to > another file stream. > > Signed-off-by: zhenwei pi > ---

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/06/2018 03:04 AM, Kevin Wolf wrote: > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: >> The legacy command line syntax supports a "password-secret" option that >> allows to pass an authentication key to Ceph. This was not supported in >> QMP so far. >> >> This patch introduces authenticat

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/05/2018 12:06 PM, Kevin Wolf wrote: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. > > This patch introduces authentication options in the QAPI schema, makes > them do the corre

Re: [Qemu-devel] [PATCH v1 1/1] xilinx_spips: send dummy only if cmd requires it

2018-04-18 Thread Sai Pavan Boddu
Hi Francisco, From: francisco iglesias [mailto:frasse.igles...@gmail.com] Sent: Wednesday, April 18, 2018 4:13 AM To: Sai Pavan Boddu Cc: alist...@alistair23.me; crosthwaite.pe...@gmail.com; Peter Maydell ; Edde ; qemu-devel@nongnu.org Developers Subject: Re: [PATCH v1 1/1] xilinx_spips: send

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 15:06, Gerd Hoffmann wrote: >>> Other question: Do we want allow to specify which certs/keys are >>> enrolled? Which would probably mean to drop "enrolled-keys" from >>> features and make it an optional string instead, >> >> Not an enum? "Microsoft" below should be an enum constant, s

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Peter Maydell
On 18 April 2018 at 13:47, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote: >> Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. >> Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Normally we expect ./include/glib-com

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Eric Blake
On 04/18/2018 07:47 AM, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote: >> Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. >> Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Normally we expect ./include/glib-compat

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:21 hat Eric Blake geschrieben: > On 04/06/2018 03:04 AM, Kevin Wolf wrote: > > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: > >> The legacy command line syntax supports a "password-secret" option that > >> allows to pass an authentication key to Ceph. This was not supporte

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-18 Thread Eric Blake
On 04/13/2018 11:59 AM, Halil Pasic wrote: > This ssize_t seems to be an rather interesting type. For instance POSIX says > """ > size_t > Used for sizes of objects. > ssize_t > Used for a count of bytes or an error indication. > """ > and > """ > The type ssize_t shall be capable of stori

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 14:22, Marc-André Lureau wrote: >>> - Chardev: stdio, mux, ringbuf, pty, file, null etc.. >>> - CharBackend: the "user" end >>> - frontend: the "user" >> The frontend is the device, the monitor, etc. > yes, I should have listed it for clarity > >> The backend is how the >> frontend s

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:26 hat Eric Blake geschrieben: > On 04/05/2018 12:06 PM, Kevin Wolf wrote: > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > > > This patch introduces authe

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 14:06, Peter Maydell wrote: > >> In case of a mux chardev, it may already >> have an active frontend (yeah be is CharBackend which is the frontend, >> I still can't grasp that either, please Paolo change your mind! ;). > I agree with Marc-André that the terminology for our chardev >

Re: [Qemu-devel] [PATCH v4 2/5] qcow2: Document some maximum size constraints

2018-04-18 Thread Eric Blake
On 04/13/2018 12:08 PM, Max Reitz wrote: With 512 byte clusters and 64 bit refcount entries I still get 8 PB, way over what's limited by the L1/L2 tables (128 GB). >>> >>> Do I need to make any modifications to the sentence, then? >> >> I guess what surprised me the first time that I rea

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 03:30:36PM +0200, Laszlo Ersek wrote: > On 04/18/18 15:06, Gerd Hoffmann wrote: > >>> Other question: Do we want allow to specify which certs/keys are > >>> enrolled? Which would probably mean to drop "enrolled-keys" from > >>> features and make it an optional string inste

[Qemu-devel] Restoring bitmaps after failed/cancelled migration

2018-04-18 Thread Vladimir Sementsov-Ogievskiy
Hi all. We now have the following problem: If dirty-bitmaps migration capability is enabled, persistance flag is dropped for all migrated bitmaps, to prevent their storing to the storage on inactivate. It works ok, persistence itself is migrated through the migration channel. But on source, b

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Marc-André Lureau
Hi On Wed, Apr 18, 2018 at 3:47 PM, Paolo Bonzini wrote: > On 18/04/2018 14:22, Marc-André Lureau wrote: - Chardev: stdio, mux, ringbuf, pty, file, null etc.. - CharBackend: the "user" end - frontend: the "user" >>> The frontend is the device, the monitor, etc. >> yes, I should hav

  1   2   3   >