On 18 April 2018 at 11:11, Daniel P. Berrangé <berra...@redhat.com> wrote: > The "git archive" feature creates tarballs which are missing all > submodule content. GitHub unhelpfully provides users with "Download" > links that claim to give them valid source release tarballs. These > GitHub archives will not be buildable as they are created by the > "git archive" feature and so are missing content. The user gets > unhelpful messages from make such as: > > fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or directory > > By adding a sanity check we can give users an informative message about > what they've done wrong. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Is it worth also mentioning in the error message the existence of scripts/archive-source.sh to help people who need to create tarballs for their test setups (the way we do internally for docker builds)? thanks -- PMM
