On 04/18/2018 07:47 AM, Daniel P. Berrangé wrote:
> On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote:
>> Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore.
>> Fixes commit 418026ca43 ("util: Introduce vfio helpers")
>
> Normally we expect ./include/glib-compat.h to be changed in this scenario
> to add compat for the missing symbol.Or rewrite the offending addition of g_realloc_n to use something like g_renew that IS available in 2.22 (this is not the first time the issue has appeared; see commit 071d405, for example). > > IIRC, one of Peters desired build targets required 2.22, but I guess we > missed this bug because that platform would not enable vfio functionality ? Which platform? CentOS 6 is at glib 2.28; we also require 2.30 for building on mingw. I'm not seeing an easy document that says which distros we still actively support, and which culprit distro has the oldest glib. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
