Re: [Qemu-devel] [PATCH for-2.12] monitor: bind dispatch bh to iohandler context

2018-04-09 Thread Stefan Hajnoczi
On Sun, Apr 08, 2018 at 01:12:07PM +0800, Peter Xu wrote: > On Wed, Apr 04, 2018 at 03:22:20PM +0100, Stefan Hajnoczi wrote: > > On Tue, Apr 03, 2018 at 01:01:15PM +0800, Peter Xu wrote: > > > Eric Auger reported the problem days ago that OOB broke ARM when running > > > with libvirt: > > > > > >

Re: [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()

2018-04-09 Thread Stefan Hajnoczi
On Sun, Apr 08, 2018 at 11:05:42AM +0800, Peter Xu wrote: > If there are more than one events, wait_until_completed() might return > the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop > will continue to run even if completed is set to True. > > It never happened before, but i

Re: [Qemu-devel] [PATCH] qemu-guest-agent: freeze-hook to ignore dpkg files as well

2018-04-09 Thread Christian Ehrhardt
Re-Ping for consideration? On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > Hi, > maybe I missed a formal thing on this submission, but I don't see it right > away. > So for now just a ping on any updates in regard to accept this? > > On Wed, Dec 13

[Qemu-devel] [PULL 4/4] docker: fedora: test more components

2018-04-09 Thread Fam Zheng
From: Paolo Bonzini Install optional dependencies of QEMU to get better coverage. Signed-off-by: Paolo Bonzini Message-Id: <1520942752-19449-1-git-send-email-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 13 ++--- 1 file changed, 10 inserti

[Qemu-devel] [PULL 1/4] docker: dump 'config.log' if ./configure fails

2018-04-09 Thread Fam Zheng
From: Philippe Mathieu-Daudé Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-Id: <20180315142713.30960-1-f4...@amsat.org> Signed-off-by: Fam Zheng --- tests/docker/common.rc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PULL 3/4] docker: Inline "prep_fail" in run script

2018-04-09 Thread Fam Zheng
We don't source common.rc where prep_fail is defined, so spell out the commands and do what was intended. Signed-off-by: Fam Zheng Message-Id: <20180326090350.30014-1-f...@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Fam Zheng --- tests/docker/run | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PULL 0/4] Testing patches

2018-04-09 Thread Fam Zheng
The following changes since commit 08e173f29461396575c85510eb41474b993cb1fb: Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-04-06 17:51:21 +0100) are available in the Git repository at: git://github.com/famz/qemu.git tags/testing-pull-requ

[Qemu-devel] [PULL 2/4] tests: Fix ubuntu.i386 image initialization

2018-04-09 Thread Fam Zheng
The apt-get commands we run through ssh expect certain features of the tty, and refuses to work if /dev/null is used. It is ugly, but easy to satisfy. Actually, there is no reason to hide the output. It just makes things harder to diagnose. We can always redirect in the Makefile, so don't do it co

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 v2] qemu-iotests: update 185 output

2018-04-09 Thread Stefan Hajnoczi
On Wed, Apr 04, 2018 at 06:16:12PM +0200, Max Reitz wrote: > On 2018-04-04 17:01, Stefan Hajnoczi wrote: > > Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce > > vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the > > drain operation the block job iterates one mor

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Thomas Huth
Hi Laszlo, On 07.04.2018 02:01, Laszlo Ersek wrote: > Add a schema that describes the properties of virtual machine firmware. > > Each firmware executable installed on a host system should come with a > JSON file that conforms to this schema, and informs the management > applications about the f

Re: [Qemu-devel] [PATCH v2 1/2] vfio-ccw: fix memory leaks in vfio_ccw_realize()

2018-04-09 Thread Cornelia Huck
On Sat, 07 Apr 2018 16:43:46 +0200 Greg Kurz wrote: > If the subchannel is already attached or if vfio_get_device() fails, the > code jumps to the 'out_device_err' label and doesn't free the string it > has just allocated. > > The code should be reworked so that vcdev->vdev.name only gets set wh

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-09 Thread Daniel Vetter
On Fri, Apr 06, 2018 at 12:54:22PM +0200, Gerd Hoffmann wrote: > On Fri, Apr 06, 2018 at 10:52:21AM +0100, Daniel Stone wrote: > > Hi Gerd, > > > > On 14 March 2018 at 08:03, Gerd Hoffmann wrote: > > >> Either mlock account (because it's mlocked defacto), and get_user_pages > > >> won't do that f

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Thomas Huth
On 07.04.2018 02:01, Laszlo Ersek wrote: > Add a schema that describes the properties of virtual machine firmware. [...] > +## > +# @SystemFirmware: > +# > +# Describes a system firmware binary and any NVRAM slots that it requires. > +# > +# @executable: Identifies the platform firmware executable.

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-09 Thread Daniel Vetter
On Thu, Apr 05, 2018 at 05:11:17PM -0700, Matt Roper wrote: > On Thu, Apr 05, 2018 at 10:32:04PM +0200, Daniel Vetter wrote: > > Pulling this out of the shadows again. > > > > We now also have xen-zcopy from Oleksandr and the hyper dmabuf stuff > > from Matt and Dongwong. > > > > At least from th

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Gerd Hoffmann
> > +{ 'enum' : 'SystemFirmwareType', > > + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } > > The naming here is quite a bad mixture between firmware interface > ('bios', 'uefi') and firmware implementations ('slof', 'uboot'). There > could be other implementations of BIOS or UEFI than SeaBIOS a

Re: [Qemu-devel] [PULL 10/25] aarch64-linux-user: Add support for SVE signal frame records

2018-04-09 Thread Richard Henderson
On 04/07/2018 04:12 AM, Peter Maydell wrote: > Richard (Henderson): I'll have a closer look at this on Monday if you don't > get to it first... I should have an env to reproduce shortly. r~

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-04-09 Thread Daniel Vetter
On Fri, Apr 06, 2018 at 02:24:46PM +0200, Christian König wrote: > Am 06.04.2018 um 11:33 schrieb Gerd Hoffmann: > >Hi, > > > > > The pages backing a DMA-buf are not allowed to move (at least not without > > > a > > > patch set I'm currently working on), but for certain MM operations to work

[Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Peter Xu
We don't need to detect GTK ABI if GTK is disabled in general. Otherwise we could get this warning (when host is installed with GTK ABI version 2) even when configure with "--disable-gtk": WARNING: Use of GTK 2.0 is deprecated and will be removed in WARNING: future releases. Please switch

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Gerd Hoffmann
> +# { > +# "executable": { > +# "pathname": "/usr/share/OVMF/OVMF_CODE.secboot.fd", > +# "description": "OVMF with Secure Boot and SMM-protected varstore", > +# "tags": [ > +# "FD_SIZE_4MB", > +# "IA32X64", > +# "SECURE_BOOT_ENABLE",

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 04:23:23PM +0800, Peter Xu wrote: > We don't need to detect GTK ABI if GTK is disabled in general. > Otherwise we could get this warning (when host is installed with GTK ABI > version 2) even when configure with "--disable-gtk": > > WARNING: Use of GTK 2.0 is deprecated

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Daniel P . Berrangé
On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: > Add a schema that describes the properties of virtual machine firmware. > > Each firmware executable installed on a host system should come with a > JSON file that conforms to this schema, and informs the management > applications abo

[Qemu-devel] [PATCH for-2.12 v2] iothread: workaround glib bug which hangs qmp-test

2018-04-09 Thread Peter Xu
Free the AIO context earlier than the GMainContext (if we have) to workaround a glib2 bug that GSource context pointer is not cleared even if the context has already been destroyed (while it should). The patch itself only changed the order to destroy the objects, no functional change at all. Witho

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 4/8] file-posix: Implement bdrv_co_copy_range

2018-04-09 Thread Fam Zheng
On Wed, 04/04 14:20, Stefan Hajnoczi wrote: > On Thu, Mar 29, 2018 at 07:09:10PM +0800, Fam Zheng wrote: > > +static ssize_t handle_aiocb_copy_range(RawPosixAIOData *aiocb) > > +{ > > +#ifndef HAS_COPY_FILE_RANGE > > +return -ENOTSUP; > > +#else > > +uint64_t bytes = aiocb->aio_nbytes; > >

Re: [Qemu-devel] [PATCH v2 2/2] vfio-ccw: introduce vfio_ccw_get_device()

2018-04-09 Thread Cornelia Huck
On Sat, 07 Apr 2018 16:44:01 +0200 Greg Kurz wrote: > A recent patch fixed leaks of the dynamically allocated vcdev->vdev.name > field in vfio_ccw_realize(), but we now have three freeing sites for it. > This is unfortunate and seems to indicate something is wrong with its > life cycle. > > The

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-04-09 Thread Kashyap Chamarthy
On Fri, Apr 06, 2018 at 08:21:00PM +0200, Laszlo Ersek wrote: > On 04/06/18 20:10, Eric Blake wrote: [...] > # key=value pairs also support Python or JSON object literal subset notations, > # without spaces. Dictionaries/objects {} are supported as are arrays []. > # > #example-command arg-na

Re: [Qemu-devel] [Qemu-block] block-stream/commit and mixing internal and external snapshots

2018-04-09 Thread Kevin Wolf
Am 07.04.2018 um 00:16 hat Eric Blake geschrieben: > Perhaps others have already known this, but I just realized that if you > mix internal and external snapshots, you can set yourself up for massive > failures when trying to use block-stream or block-commit to consolidate > data across the externa

[Qemu-devel] [PATCH] icount: fix cpu_restore_state_from_tb for non-tb-exit cases

2018-04-09 Thread Pavel Dovgalyuk
In icount mode instructions, that access io memory spaces in the middle of the translation blocks, invoke TB recompilation. After recompilation such instructions become last in the TB and are allowed to access io memory spaces. When the code includes instruction like i386 'xchg eax, 0xd080' whi

Re: [Qemu-devel] [PATCH v3 00/10] migration: improve and cleanup compression

2018-04-09 Thread Paolo Bonzini
On 08/04/2018 05:19, Xiao Guangrong wrote: > > Hi Paolo, Michael, Stefan and others, > > Could anyone merge this patchset if it is okay to you guys? Hi Guangrong, Dave and Juan will take care of merging it. However, right now QEMU is in freeze so they may wait a week or two. If they have revi

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-04-09 Thread Marc-André Lureau
Hi On Sun, Apr 8, 2018 at 5:02 AM, Peter Xu wrote: > On Wed, Apr 04, 2018 at 03:58:56PM +0200, Marc-André Lureau wrote: >> Hi Peter >> >> On Wed, Mar 28, 2018 at 6:02 AM, Peter Xu wrote: >> > On Mon, Mar 26, 2018 at 11:46:13AM +0200, Marc-André Lureau wrote: >> >> Hi >> >> >> >> On Mon, Mar 26,

Re: [Qemu-devel] [PULL 00/20] Miscellaneous patches for QEMU 2.12-rc

2018-04-09 Thread Peter Maydell
On 6 April 2018 at 18:11, Paolo Bonzini wrote: > The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: > > Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstre

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 09:31, Daniel P. Berrangé wrote: > Feels to me that since we've deprecated 2.0, we could just *never* auto > detect - just do test -z "$gtkabi" && gtkabi=3.0 > > Anyone who wants gtk2 should have to use an explicit --with-gtkabi=2.0 I think if we still work with gtk2 then w

Re: [Qemu-devel] [PATCH v2] scsi-disk: Don't enlarge min_io_size to max_io_size

2018-04-09 Thread Paolo Bonzini
On 09/04/2018 03:08, David Gibson wrote: > On Thu, 5 Apr 2018 17:54:00 +0200 Paolo Bonzini wrote: >> On 27/03/2018 18:41, Fam Zheng wrote: >>> Some backends report big max_io_sectors. Making min_io_size the same >>> value in this case will make it impossible for guest to align memory, >>> therefor

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Split 214 off of 122

2018-04-09 Thread Alberto Garcia
On Fri 06 Apr 2018 06:41:08 PM CEST, Max Reitz wrote: > Commit abd3622cc03cf41ed542126a540385f30a4c0175 added a case to 122 > regarding how the qcow2 driver handles an incorrect compressed data > length value. This does not really fit into 122, as that file is > supposed to contain qemu-img conve

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-04-09 Thread Cornelia Huck
On Fri, 6 Apr 2018 18:07:56 +0200 Halil Pasic wrote: > On 04/05/2018 06:38 PM, Tony Krowiak wrote: > > On 04/03/2018 05:36 AM, Cornelia Huck wrote: > >> On Mon, 2 Apr 2018 12:36:27 -0400 > >> Tony Krowiak  wrote: > >> > >>> On 03/26/2018 05:03 AM, Pierre Morel wrote: > On 26/03/2018 10

[Qemu-devel] Crash when running hello-world unikernel for ARM

2018-04-09 Thread Ajay Garg
Hi All. We did the following : a) Cross-compile rumprun for ARM on a linux x86_64 : ajay@latitude-3480:~/rumprun-arm-hw/rumprun$ CC=arm-linux-gnueabihf-gcc ./build-rr.sh hw b) Compile and bake the hello-world binary ajay@latitude-3480:~/rumprun-arm-hw/rumprun$ arm-rumprun-netbsdelf-eabihf-gcc

Re: [Qemu-devel] [PATCH for-2.12] gdbstub: fix off-by-one in gdb_handle_packet()

2018-04-09 Thread Paolo Bonzini
On 09/04/2018 07:58, Stefan Hajnoczi wrote: > On Sun, Apr 08, 2018 at 11:59:33AM -0300, Philippe Mathieu-Daudé wrote: >> memtohex() adds an extra trailing NUL character. >> >> Reported-by: AddressSanitizer >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> (gdb) dump binary memory /tmp/dram.bin 0x

[Qemu-devel] [PULL 2/6] ui: add ctrl modifier support to kbd_put_qcode_console()

2018-04-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180321135041.15768-2-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- ui/console.c | 15 +-- ui/gtk.c | 4 ++-- ui/sdl2-input.c | 2 +- 4 files changed, 17 insertions(+), 6 deletions

[Qemu-devel] [PULL 3/6] sdl2: track kbd modifier state unconditionally

2018-04-09 Thread Gerd Hoffmann
For both grapical and text consoles. Signed-off-by: Gerd Hoffmann Message-id: 20180321135041.15768-3-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 39 +-- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/ui/sdl2-input.c b

[Qemu-devel] [PULL 4/6] sdl2: enable ctrl modifier keys for text consoles

2018-04-09 Thread Gerd Hoffmann
Unbreaks ctrl-pageup/pagedown scrollback. Signed-off-by: Gerd Hoffmann Message-id: 20180321135041.15768-4-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index 8d0d9ba17c.

[Qemu-devel] [PULL 6/6] sdl2: drop dead code

2018-04-09 Thread Gerd Hoffmann
Leftover from sdl1 -> sdl2 port. Signed-off-by: Gerd Hoffmann Message-id: 20180321135041.15768-6-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 8 1 file changed, 8 deletions(-) diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index d46411c474..1378b63dd9 100644 --

[Qemu-devel] [PULL 5/6] sdl2: drop QEMU_KEY_BACKSPACE special case

2018-04-09 Thread Gerd Hoffmann
Not needed, kbd_put_qcode_console() will handle that for us. Signed-off-by: Gerd Hoffmann Message-id: 20180321135041.15768-5-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index 62c2b58ef

[Qemu-devel] [PULL 0/6] Ui 20180409 patches

2018-04-09 Thread Gerd Hoffmann
The following changes since commit 094b62cd9cd9f137cf75b4931e41b8953fb4ccd9: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-04-04 11:13:52 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180409-pu

Re: [Qemu-devel] [PATCH v4] linux-user: fix preadv/pwritev offsets

2018-04-09 Thread Laurent Vivier
Le 06/04/2018 à 03:36, Max Filippov a écrit : > preadv/pwritev accept low and high parts of file offset in two separate > parameters. When host bitness doesn't match guest bitness these parts > must be appropriately recombined. > Introduce target_to_host_low_high that does this recombination and us

[Qemu-devel] [PULL 1/6] sdl2: Remove unused epoxy include

2018-04-09 Thread Gerd Hoffmann
From: Elie Tournier Signed-off-by: Elie Tournier Message-id: 20180404093040.26009-1-tournier.e...@gmail.com Signed-off-by: Gerd Hoffmann --- ui/sdl2-gl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index 5e1073a084..c3683e6b65 100644 --- a/ui/sdl2-gl.c +++

Re: [Qemu-devel] [PATCH 0/5] sdl2 text console fixes and cleanups.

2018-04-09 Thread Gerd Hoffmann
On Sun, Apr 08, 2018 at 12:52:18PM +0200, BALATON Zoltan wrote: > On Wed, 21 Mar 2018, Gerd Hoffmann wrote: > > Gerd Hoffmann (5): > > ui: add ctrl modifier support to kbd_put_qcode_console() > > sdl2: track kbd modifier state unconditionally > > sdl2: enable ctrl modifier keys for text consoles

Re: [Qemu-devel] [PATCH for-2.12] hw/block/pflash_cfi: fix off-by-one error

2018-04-09 Thread Kevin Wolf
Am 05.04.2018 um 01:32 hat Philippe Mathieu-Daudé geschrieben: > ASAN reported: > > hw/block/pflash_cfi02.c:245:33: runtime error: index 82 out of bounds for > type 'uint8_t [82]' > > Since the 'cfi_len' member is not used, remove it to keep the code safer. > > Reported-by: AddressSanitizer

[Qemu-devel] [PATCH v3 for-2.13] vfio-ccw: introduce vfio_ccw_get_device()

2018-04-09 Thread Greg Kurz
A recent patch fixed leaks of the dynamically allocated vcdev->vdev.name field in vfio_ccw_realize(), but we now have three freeing sites for it. This is unfortunate and seems to indicate something is wrong with its life cycle. The root issue is that vcdev->vdev.name is set before vfio_get_device(

Re: [Qemu-devel] [PATCH 0/5] sdl2 text console fixes and cleanups.

2018-04-09 Thread Mark Cave-Ayland
On 09/04/18 10:43, Gerd Hoffmann wrote: On Sun, Apr 08, 2018 at 12:52:18PM +0200, BALATON Zoltan wrote: On Wed, 21 Mar 2018, Gerd Hoffmann wrote: Gerd Hoffmann (5): ui: add ctrl modifier support to kbd_put_qcode_console() sdl2: track kbd modifier state unconditionally sdl2: enable ctrl m

Re: [Qemu-devel] [PATCH 1/1] block-backend: simplify blk_get_aio_context

2018-04-09 Thread Kevin Wolf
Am 27.03.2018 um 15:08 hat Daniel Henrique Barboza geschrieben: > blk_get_aio_context verifies if BlockDriverState bs is not NULL, > return bdrv_get_aio_context(bs) if true or qemu_get_aio_context() > otherwise. However, bdrv_get_aio_context from block.c already does > this verification itself, als

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-09 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 03.04.2018 um 22:52 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 28.03.2018 um 19:02 hat Dr. David Alan Gilbert (git) geschrieben: > > > > From: "Dr. David Alan Gilbert" > > > > > > > > Activating the block

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-04-09 Thread Halil Pasic
On 04/09/2018 11:32 AM, Cornelia Huck wrote: >> We can kind of (i.e. modulo EECA.28) ensure this in a different fashion I >> think. How >> about proclaiming a 'has ap instructions, but nothing to see here' in the >> SIE interpreted flavor (ECA.28 set) the default way of having ap instructions >>

[Qemu-devel] [PATCH for-2.12] target/arm: Don't corrupt insn_start arguments on 32-bit hosts

2018-04-09 Thread Peter Maydell
For the Arm target, we have a 3-operand tcg_insn_start, where the 3 arguments are the PC, condexec bits, and a syndrome value. We set it up like this: tcg_gen_insn_start(dc->pc, (dc->condexec_cond << 4) | (dc->condexec_mask >> 1), 0); dc->insn_

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-04-09 Thread Cornelia Huck
On Mon, 9 Apr 2018 12:37:42 +0200 Halil Pasic wrote: > On 04/09/2018 11:32 AM, Cornelia Huck wrote: > >> We can kind of (i.e. modulo EECA.28) ensure this in a different fashion I > >> think. How > >> about proclaiming a 'has ap instructions, but nothing to see here' in the > >> SIE interpreted f

Re: [Qemu-devel] [PULL 00/20] Miscellaneous patches for QEMU 2.12-rc

2018-04-09 Thread Paolo Bonzini
On 09/04/2018 11:20, Peter Maydell wrote: > This fails to compile on OSX and the BSDs: > /Users/pm215/src/qemu-for-merges/util/memfd.c:208:19: error: implicit > declaration of function 'memfd_create' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > int mfd = memfd_create("tes

Re: [Qemu-devel] [PULL 0/4] Testing patches

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 08:19, Fam Zheng wrote: > The following changes since commit 08e173f29461396575c85510eb41474b993cb1fb: > > Merge remote-tracking branch > 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-04-06 > 17:51:21 +0100) > > are available in the Git repository at:

[Qemu-devel] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate

2018-04-09 Thread David Hildenbrand
If we already triggered another exception, don't overwrite it with a protection exception. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 1deeb6e6e4..a2

[Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread David Hildenbrand
Let's simplify it a bit. On some weird circumstances we would have tried to recompute watchpoints when running under KVM. Signed-off-by: David Hildenbrand --- target/s390x/helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/s390x/helper.c b/target/s390x

[Qemu-devel] [PATCH v1 for-2.12 0/2] s390x/kvm: last minute fixes

2018-04-09 Thread David Hildenbrand
Patch 1 only applies to old KVM instances without the virtual memory access IOCTL in KVM. Patch 2 could be problematic when toggling PER in a restart interrupt. Watchpoint recomputation only applies to TCG. David Hildenbrand (2): s390x/mmu: don't overwrite pending exception in mmu translate s

Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
03.04.2018 16:36, Kevin Wolf wrote: Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: Blacklist these formats, as they don't support image creation, as they say: > ./qemu-img create -f bochs x 1m qemu-img: x: Format driver 'bochs' does not support image creation

Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread Christian Borntraeger
On 04/09/2018 01:30 PM, David Hildenbrand wrote: > Let's simplify it a bit. On some weird circumstances we would have tried > to recompute watchpoints when running under KVM. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.c | 10 ++ > 1 file changed, 6 insertions(+),

Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread David Hildenbrand
On 09.04.2018 13:35, Christian Borntraeger wrote: > > > On 04/09/2018 01:30 PM, David Hildenbrand wrote: >> Let's simplify it a bit. On some weird circumstances we would have tried >> to recompute watchpoints when running under KVM. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/

Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread Christian Borntraeger
On 04/09/2018 01:36 PM, David Hildenbrand wrote: > On 09.04.2018 13:35, Christian Borntraeger wrote: >> >> >> On 04/09/2018 01:30 PM, David Hildenbrand wrote: >>> Let's simplify it a bit. On some weird circumstances we would have tried >>> to recompute watchpoints when running under KVM. >>> >>>

[Qemu-devel] [PATCH v2 0/2] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
v2: move from unsupported_fmts to support "generic", like in bash tests. Vladimir Sementsov-Ogievskiy (2): iotests.py: improve verify_image_format helper iotests: blacklist bochs and cloop for 205 and 208 tests/qemu-iotests/205| 2 +- tests/qemu-iotests/208| 2 ++ tests/qem

Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread David Hildenbrand
On 09.04.2018 13:40, Christian Borntraeger wrote: > > > On 04/09/2018 01:36 PM, David Hildenbrand wrote: >> On 09.04.2018 13:35, Christian Borntraeger wrote: >>> >>> >>> On 04/09/2018 01:30 PM, David Hildenbrand wrote: Let's simplify it a bit. On some weird circumstances we would have tried

[Qemu-devel] [PATCH v2 2/2] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
Blacklist these formats, as they don't support image creation, as they say: > ./qemu-img create -f bochs x 1m qemu-img: x: Format driver 'bochs' does not support image creation > ./qemu-img create -f cloop x 1m qemu-img: x: Format driver 'cloop' does not support image creation Sig

Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread Christian Borntraeger
On 04/09/2018 01:44 PM, David Hildenbrand wrote: > On 09.04.2018 13:40, Christian Borntraeger wrote: >> >> >> On 04/09/2018 01:36 PM, David Hildenbrand wrote: >>> On 09.04.2018 13:35, Christian Borntraeger wrote: On 04/09/2018 01:30 PM, David Hildenbrand wrote: > Let's simplify

Re: [Qemu-devel] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate

2018-04-09 Thread Thomas Huth
On 09.04.2018 13:30, David Hildenbrand wrote: > If we already triggered another exception, don't overwrite it with a > protection exception. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s39

[Qemu-devel] [PATCH v2 1/2] iotests.py: improve verify_image_format helper

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
Support "generic" formats like in bash tests with their _supported_fmt generic The test, supporting "generic" formats will run if IMGFMT_GENERIC = true, which is default, except for bochs and cloop. However, you can use verify_image_format(['generic', 'bochs']), which will run for all except clo

Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread Cornelia Huck
On Mon, 9 Apr 2018 13:44:30 +0200 David Hildenbrand wrote: > Conny, when (and if ;) ) picking this up, can you change the description to > > "Let's simplify it a bit. On some weird circumstances we would have > tried to recompute watchpoints when running under KVM. load_psw() is > called from do

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate

2018-04-09 Thread Christian Borntraeger
On 04/09/2018 01:30 PM, David Hildenbrand wrote: > If we already triggered another exception, don't overwrite it with a > protection exception. > > Signed-off-by: David Hildenbrand Can you add your description from the cover letter regarding "only applies to old KVM instances without the virt

[Qemu-devel] [PATCH 2/2] linux-user: add microblaze/microblazeel magic numbers in qemu-binfmt-conf.sh

2018-04-09 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index f39ad344fc..7ab7435fbd 100755 --- a/scripts/qemu-binfmt-conf.sh +++ b/scripts/qemu-binfmt

[Qemu-devel] [PATCH 1/2] linux-user: fix microblaze get_sp_from_cpustate()

2018-04-09 Thread Laurent Vivier
get_sigframe() uses regs[1] and this is actual SP. Signed-off-by: Laurent Vivier --- linux-user/microblaze/target_signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/microblaze/target_signal.h b/linux-user/microblaze/target_signal.h index de2b0f49d5..642865f1

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate

2018-04-09 Thread Cornelia Huck
On Mon, 9 Apr 2018 13:50:03 +0200 Christian Borntraeger wrote: > On 04/09/2018 01:30 PM, David Hildenbrand wrote: > > If we already triggered another exception, don't overwrite it with a > > protection exception. > > > > Signed-off-by: David Hildenbrand > > > Can you add your description fr

Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM

2018-04-09 Thread Thomas Huth
On 09.04.2018 13:30, David Hildenbrand wrote: > Let's simplify it a bit. On some weird circumstances we would have tried > to recompute watchpoints when running under KVM. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.c | 10 ++ > 1 file changed, 6 insertions(+), 4 del

Re: [Qemu-devel] [PATCH v1 for-2.12 0/2] s390x/kvm: last minute fixes

2018-04-09 Thread Cornelia Huck
On Mon, 9 Apr 2018 13:30:17 +0200 David Hildenbrand wrote: > Patch 1 only applies to old KVM instances without the virtual memory access > IOCTL in KVM. > > Patch 2 could be problematic when toggling PER in a restart interrupt. > Watchpoint recomputation only applies to TCG. > > David Hildenbr

Re: [Qemu-devel] Crash when running hello-world unikernel for ARM

2018-04-09 Thread Alex Bennée
Ajay Garg writes: > Hi All. > > We did the following : > > a) > Cross-compile rumprun for ARM on a linux x86_64 : > > ajay@latitude-3480:~/rumprun-arm-hw/rumprun$ > CC=arm-linux-gnueabihf-gcc ./build-rr.sh hw > > c) > Tried running on x86_64, via qemu, but got the crash : > > ##

Re: [Qemu-devel] Crash when running hello-world unikernel for ARM

2018-04-09 Thread Ajay Garg
> > qemu-system-x86_64 is expecting an x86 binary blob. I assume you need > qemu-system-arm. More importantly you need to specify a -M machine type > that matches whatever rumprun is expecting. > Oops, sorry my bad. Here is the updated status : ajay@latitude-3480:~/rumprun-arm-hw/rumprun$ qemu-sy

Re: [Qemu-devel] [PATCH] scripts/qemugdb: support coroutine backtrace in coredumps

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
04.04.2018 13:34, Stefan Hajnoczi wrote: Use the 'select-frame' GDB command to switch stacks instead of manually setting the debugged thread's registers (this only works when debugging a live process, not in a coredump). Cc: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi --- Vladi

[Qemu-devel] [PATCH v1] cpus: track calls to resume/pause_all_vcpus()

2018-04-09 Thread David Hildenbrand
If we have parallel calls to resume/pause_all_vcpus() we can get into trouble because the qemu mutex is temporarily dropped while waiting for all threads to stop. This can happen e.g. for s390x, where resume/pause_all_vcpus() can be triggered by a VCPU. Pause/Resume exactly once, when we leave/hit

Re: [Qemu-devel] [PULL 0/6] Ui 20180409 patches

2018-04-09 Thread Peter Maydell
ble in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180409-pull-request > > for you to fetch changes up to 1458da9131c39ca99699b521436d6ce72d7c7981: > > sdl2: drop dead code (2018-04-09 10:40:47 +0200) > >

Re: [Qemu-devel] [PATCH v1] cpus: track calls to resume/pause_all_vcpus()

2018-04-09 Thread Paolo Bonzini
On 09/04/2018 15:07, David Hildenbrand wrote: > If we have parallel calls to resume/pause_all_vcpus() we can get > into trouble because the qemu mutex is temporarily dropped while > waiting for all threads to stop. This can happen e.g. for s390x, where > resume/pause_all_vcpus() can be triggered by

[Qemu-devel] [Bug 1756927] Re: ARMv7 LPAE: IFSR doesn't have the LPAE bit in case of BKPT

2018-04-09 Thread Vincent Siles
Hi Peter, we tested the fix and it work correctly now, thank you very much ! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1756927 Title: ARMv7 LPAE: IFSR doesn't have the LPAE bit in case of BKPT

Re: [Qemu-devel] [PATCH v1] cpus: track calls to resume/pause_all_vcpus()

2018-04-09 Thread David Hildenbrand
On 09.04.2018 15:12, Paolo Bonzini wrote: > On 09/04/2018 15:07, David Hildenbrand wrote: >> If we have parallel calls to resume/pause_all_vcpus() we can get >> into trouble because the qemu mutex is temporarily dropped while >> waiting for all threads to stop. This can happen e.g. for s390x, where

Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Kevin Wolf
Am 09.04.2018 um 13:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 03.04.2018 16:36, Kevin Wolf wrote: > > Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Blacklist these formats, as they don't support image creation, as they > > > say: > > > > ./qemu-img create

Re: [Qemu-devel] Crash when running hello-world unikernel for ARM

2018-04-09 Thread Alex Bennée
Ajay Garg writes: >> >> qemu-system-x86_64 is expecting an x86 binary blob. I assume you need >> qemu-system-arm. More importantly you need to specify a -M machine type >> that matches whatever rumprun is expecting. >> > > Oops, sorry my bad. > Here is the updated status : > > ajay@latitude-3480

[Qemu-devel] Use of -machine when running via qemu-system-arm

2018-04-09 Thread Ajay Garg
Hi All. Not sure if this is purely an ARM-related question, but I will be grateful if someone could point to some literature that explains what difference choosing a machine makes (when we don't need to have any such flag for qemu-system-i386 or qemu-system-x86_64). I am sorry for the noob quest

Re: [Qemu-devel] [Qemu-arm] Use of -machine when running via qemu-system-arm

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 14:35, Ajay Garg wrote: > Hi All. > > Not sure if this is purely an ARM-related question, but I will be > grateful if someone could point to some literature that explains what > difference choosing a machine makes (when we don't need to have any > such flag for qemu-system-i386

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-09 Thread Kevin Wolf
Am 09.04.2018 um 12:27 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 03.04.2018 um 22:52 hat Dr. David Alan Gilbert geschrieben: > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > Am 28.03.2018 um 19:02 hat Dr. David Alan Gilbert (git) geschrieben: > > >

Re: [Qemu-devel] [Qemu-arm] Use of -machine when running via qemu-system-arm

2018-04-09 Thread Ajay Garg
Hi Peter, Thanks for the reply .. On Mon, Apr 9, 2018 at 7:08 PM, Peter Maydell wrote: > On 9 April 2018 at 14:35, Ajay Garg wrote: >> Hi All. >> >> Not sure if this is purely an ARM-related question, but I will be >> grateful if someone could point to some literature that explains what >> diff

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-09 Thread Bastian Koppelmann
Hi Emilio, On 04/06/2018 08:19 PM, Emilio G. Cota wrote: > v1: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00445.html > > Changes since v1: > > - Rebase onto master > > - Add R-b's > > - Add riscv conversion Thanks for doing this grunt work. Me and a colleague were planning to do

Re: [Qemu-devel] [Qemu-arm] Use of -machine when running via qemu-system-arm

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 14:43, Ajay Garg wrote: > On Mon, Apr 9, 2018 at 7:08 PM, Peter Maydell > wrote: >> On 9 April 2018 at 14:35, Ajay Garg wrote: >>> Hi All. >>> >>> Not sure if this is purely an ARM-related question, but I will be >>> grateful if someone could point to some literature that exp

Re: [Qemu-devel] [PATCH v2 15/17] target/riscv: convert to DisasJumpType

2018-04-09 Thread Bastian Koppelmann
On 04/06/2018 08:19 PM, Emilio G. Cota wrote: > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > > Signed-off-by: Emilio G. Cota > --- > target/riscv/translate.c | 72 > +++- > 1 file changed, 28 insertions(

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-09 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 09.04.2018 um 12:27 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 03.04.2018 um 22:52 hat Dr. David Alan Gilbert geschrieben: > > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > > Am 28.03.2018 um 19:02 hat

[Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-09 Thread Peter Maydell
The AArch64 signal frame design was extended for SVE in commit 8c5931de0ac77388096d79ceb, so that instead of having a fixed setup we now add various records to the frame, with some of them possibly overflowing into an extra space outside the original 4K reserved block in the target_sigcontext. How

Re: [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()

2018-04-09 Thread Eric Blake
On 04/07/2018 10:05 PM, Peter Xu wrote: > If there are more than one events, wait_until_completed() might return > the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop > will continue to run even if completed is set to True. > > It never happened before, but it can be triggered

Re: [Qemu-devel] [PATCH for-2.12 v2] iothread: workaround glib bug which hangs qmp-test

2018-04-09 Thread Eric Blake
On 04/09/2018 03:39 AM, Peter Xu wrote: > Free the AIO context earlier than the GMainContext (if we have) to > workaround a glib2 bug that GSource context pointer is not cleared even > if the context has already been destroyed (while it should). > > The patch itself only changed the order to destr

Re: [Qemu-devel] [Qemu-block] block-stream/commit and mixing internal and external snapshots

2018-04-09 Thread Eric Blake
On 04/09/2018 04:11 AM, Kevin Wolf wrote: > Am 07.04.2018 um 00:16 hat Eric Blake geschrieben: >> Perhaps others have already known this, but I just realized that if you >> mix internal and external snapshots, you can set yourself up for massive >> failures when trying to use block-stream or block-

[Qemu-devel] [Bug 1761535] Re: qemu-aarch64-static docker arm64v8/openjdk coredump

2018-04-09 Thread Peter Maydell
I think this should be fixed by https://patchwork.ozlabs.org/patch/896295/ (incidentally the segfault is in the guest /bin/sh, not in javac or ls.) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is s

Re: [Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase

2018-04-09 Thread Bastian Koppelmann
On 04/06/2018 08:19 PM, Emilio G. Cota wrote: > Notes: > > - Did not convert {num,max}_insns, since the corresponding code > will go away in the next patch. > > - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_tmp. Please call pc_tmp something meaningful, like pc_succ_insn

[Qemu-devel] [PULL 3/5] contrib/libvhost-user: add the protocol feature used for SET/GET message

2018-04-09 Thread Michael S. Tsirkin
From: Changpeng Liu Signed-off-by: Changpeng Liu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- contrib/libvhost-user/libvhost-user.h | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h index

  1   2   3   >