Re: [Qemu-devel] [Qemu-ppc] [PULL 0/9] ppc-for-2.12 queue 20180315

2018-03-19 Thread Thomas Huth
On 17.03.2018 12:30, BALATON Zoltan wrote: > On Sat, 17 Mar 2018, BALATON Zoltan wrote: >> On Sat, 17 Mar 2018, Peter Maydell wrote: [...] >   /ppc64/boot-serial/sam460ex: > /home/petmay01/linaro/qemu-for-merges/target/ppc/translate.c:2979:15: > runtime error: load of value 85, which is

[Qemu-devel] [Bug 1435359] Re: Booting kernel 3.19.2 fails most of the time

2018-03-19 Thread Thomas Huth
Ok, thanks, so I'm closing this now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1435359 Title: Booting kernel 3.19.2 fails most of

[Qemu-devel] [PATCH v2 3/6] virtio: support adding sub-regions for notify region

2018-03-19 Thread Tiwei Bie
Provide APIs to support querying whether the page-per-vq is enabled and adding sub-regions for notify region. Signed-off-by: Tiwei Bie --- Makefile.target| 4 hw/virtio/virtio-pci.c | 48 ++ hw/virtio/virtio-pci.h | 5 +

[Qemu-devel] [PATCH v2 2/6] vhost-user: introduce shared vhost-user state

2018-03-19 Thread Tiwei Bie
When multi-queue is enabled for virtio-net, each virtio queue pair will have a vhost_dev, and the only thing they share currently is the chardev. This patch introduces a vhost-user state structure which will be shared by all virtio queue pairs of the same virtio device. Signed-off-by: Tiwei Bie -

[Qemu-devel] [PATCH v2 0/6] Extend vhost-user to support VFIO based accelerators

2018-03-19 Thread Tiwei Bie
This patch set does some small extensions to vhost-user protocol to support VFIO based accelerators, and makes it possible to get the similar performance of VFIO based PCI passthru while keeping the virtio device emulation in QEMU. How does accelerator accelerate vhost (data path)

[Qemu-devel] [PATCH v2 1/6] vhost-user: support receiving file descriptors in slave_read

2018-03-19 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- hw/virtio/vhost-user.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 41ff5cff41..1ad6caa6a3 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-

[Qemu-devel] [PATCH v2 4/6] vfio: support getting VFIOGroup from groupfd

2018-03-19 Thread Tiwei Bie
Add an API to support getting VFIOGroup from groupfd. When groupfd is shared by another process, the VFIOGroup may not have its container and address space in QEMU. Besides, add a reference counter to better support getting VFIOGroup multiple times. Signed-off-by: Tiwei Bie --- hw/vfio/common.c

[Qemu-devel] [PATCH v2 5/6] vfio: remove DPRINTF() definition from vfio-common.h

2018-03-19 Thread Tiwei Bie
This macro isn't used by any VFIO code. And its name is too generic. The vfio-common.h (in include/hw/vfio) can be included by other modules in QEMU. It can introduce conflicts. Signed-off-by: Tiwei Bie --- include/hw/vfio/vfio-common.h | 9 - 1 file changed, 9 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 6/6] vhost-user: add VFIO based accelerators support

2018-03-19 Thread Tiwei Bie
This patch does some small extensions to vhost-user protocol to support VFIO based accelerators, and makes it possible to get the similar performance of VFIO based PCI passthru while keeping the virtio device emulation in QEMU. Any virtio ring compatible devices potentially can be used as the vhos

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compressionand decompression errors

2018-03-19 Thread jiang.biao2
Hi, guangrong > @@ -1051,11 +1052,13 @@ static int do_compress_ram_page(QEMUFile *f, z_stream > *stream, RAMBlock *block, > { > RAMState *rs = ram_state; > int bytes_sent, blen; > -uint8_t *p = block->host + (offset & TARGET_PAGE_MASK); > +uint8_t buf[TARGET_PAGE_SIZE], *p; > +p = blo

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compressionand decompression errors

2018-03-19 Thread Xiao Guangrong
On 03/19/2018 03:56 PM, jiang.bi...@zte.com.cn wrote: Hi, guangrong @@ -1051,11 +1052,13 @@ static int do_compress_ram_page(QEMUFile *f, z_stream *stream, RAMBlock *block, { RAMState *rs = ram_state; int bytes_sent, blen; -uint8_t *p = block->host + (offset & TARGET_PAGE_MASK); +uint8

[Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-03-19 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it appropriate for 2.12, let's push it. If not - then for 2.13. v2: - squash 02 (indentation fix) to 01 - drop comment from qcow2_check_metadata_overlap() - set @ign to QCOW2_OL_BITMAP_DIRECTORY for in-place case in bitmap_list_st

Re: [Qemu-devel] [PATCH 3/3] nvram: at24c: use a sane default for "rom-size"

2018-03-19 Thread Wolfram Sang
Hi Philippe, > > I don't mind much, but why? My reasoning was "let's first fix the cause > > and then the symptom"? > > The '0' case is worst than incorrect, it segfaults, so you are right :) Ok, thanks. > >> Can you add a #define for this value? Such AT24C_ROMSIZE_MIN. > > > > Can do, of cour

Re: [Qemu-devel] [PATCH] target/m68k: add a mechanism to automatically free TCGv

2018-03-19 Thread Richard Henderson
On 03/19/2018 12:12 AM, Laurent Vivier wrote: > SRC_EA() and gen_extend() can return either a temporary > TCGv or a memory allocated one. Mark them when they are > allocated, and free them automatically at end of the > instruction translation. > > We want to free locally allocated TCGv to avoid >

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v5 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-19 Thread Wei Wang
On 03/19/2018 12:24 PM, Michael S. Tsirkin wrote: On Sun, Mar 18, 2018 at 06:36:20PM +0800, Wei Wang wrote: On 03/16/2018 11:16 PM, Michael S. Tsirkin wrote: On Fri, Mar 16, 2018 at 06:48:28PM +0800, Wei Wang wrote: OTOH it seems that if thread stops nothing will wake it up whem vm is restart

[Qemu-devel] [PATCH v3 3/3] iotests: enable shared migration cases in 169

2018-03-19 Thread Vladimir Sementsov-Ogievskiy
Shared migration for dirty bitmaps is fixed by previous patches, so we can enable the test. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/169 | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/169 index 3a8

[Qemu-devel] [PATCH v3 2/3] qcow2: handle reopening bitmaps on bdrv_invalidate_cache

2018-03-19 Thread Vladimir Sementsov-Ogievskiy
Consider migration with shared storage. Persistent bitmaps are stored on bdrv_inactivate. Then, on destination process_incoming_migration_bh() calls bdrv_invalidate_cache_all() which leads to qcow2_load_autoloading_dirty_bitmaps() which fails if bitmaps are already loaded on destination start. In t

[Qemu-devel] [PATCH v3 1/3] qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint()

2018-03-19 Thread Vladimir Sementsov-Ogievskiy
Add version of qcow2_reopen_bitmaps_rw, which do the same work but also return a hint about was header updated or not. This will be used in the following fix for bitmaps reloading after migration. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- block/qcow2.h| 2 +

[Qemu-devel] [PATCH v3 for 2.12 0/3] fix bitmaps migration through shared storage

2018-03-19 Thread Vladimir Sementsov-Ogievskiy
Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The bug introduced in 2.10 with the whole qcow2 bitmaps feature, so qemu-stable in CC. However I doubt that someone really suffered from this. Do we need dirty bitmaps at all in inactive case? - that was a quest

Re: [Qemu-devel] [PATCH] target/m68k: add a mechanism to automatically free TCGv

2018-03-19 Thread Laurent Vivier
Le 19/03/2018 à 09:39, Richard Henderson a écrit : > On 03/19/2018 12:12 AM, Laurent Vivier wrote: >> SRC_EA() and gen_extend() can return either a temporary >> TCGv or a memory allocated one. Mark them when they are >> allocated, and free them automatically at end of the >> instruction translation

Re: [Qemu-devel] [PATCH v2 0/3] vfio/pci: ioeventfd support

2018-03-19 Thread Alexey Kardashevskiy
On 16/3/18 8:31 am, Alex Williamson wrote: > A vfio ioeventfd will perform the pre-specified device write on > triggering of an eventfd. When coupled with KVM ioeventfds, this > feature allows a VM to trap a device page for virtualization, while > also registering targeted ioeventfds to maintain p

[Qemu-devel] [PATCH] replay: finish record/replay before closing the disks

2018-03-19 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |2 ++ vl.c|

Re: [Qemu-devel] [PULL 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Peter Xu
On Sat, Mar 17, 2018 at 12:10:35PM +, Peter Maydell wrote: > On 16 March 2018 at 14:04, Eric Blake wrote: > > The following changes since commit 3788c7b6e56fa34ee2a73e41706eb2a2447ba75a: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > > staging (2018-03-16 11

[Qemu-devel] [Bug 1756519] Re: qemu linux-user crash in QOM path canonicalization during do_fork() call to cpu_create

2018-03-19 Thread Daniel Berrange
** Summary changed: - qemu linux-user glib hash table crash in qom/object.c + qemu linux-user crash in QOM path canonicalization during do_fork() call to cpu_create -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

[Qemu-devel] [PATCH v1 0/1] iotests: fix test case 185

2018-03-19 Thread QingFeng Hao
Hi, This patch is to remove the redundant call to bdrv_drain_all in vm_shutdown. Thanks! Test case 185 failed as below: 185 2s ... - output mismatch (see 185.out.bad) --- /home/mc/gitcheck/work/qemu-master/tree/qemu/tests/qemu-iotests/185.out 2018-03-09 01:00:40.451603189 +0100 +++ /home/mc/g

[Qemu-devel] [PATCH v1 1/1] iotests: fix test case 185

2018-03-19 Thread QingFeng Hao
Test case 185 failed since commit 4486e89c219 --- "vl: introduce vm_shutdown()". It's because of the newly introduced function vm_shutdown calls bdrv_drain_all, which is called later by bdrv_close_all. bdrv_drain_all resumes the jobs that doubles the speed and offset is doubled. Some jobs' status a

[Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none"

2018-03-19 Thread Thomas Huth
Many device introspection crashes only happen if you are using a certain machine, e.g.: $ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2}, "package": "build-all"}, "capabilities": []}} { 'execute': 'qmp_capabili

Re: [Qemu-devel] [PATCH v3 10/24] RISC-V: Hold rcu_read_lock when accessing memory

2018-03-19 Thread Paolo Bonzini
On 16/03/2018 20:41, Michael Clark wrote: > From reading other code that accesses memory regions directly, > it appears that the rcu_read_lock needs to be held. Note: the > original code for accessing RAM directly was added because > there is no other way to use atomic_cmpxchg on guest physical > a

Re: [Qemu-devel] [PATCH] gdbstub: send a terminaison packet instead of crashing gdb

2018-03-19 Thread KONRAD Frederic
Hi Philippe, Thanks for the review! BTW I forgot the for 2.12 tag can this be included in 2.12 or is it too late? Thanks, Fred On 03/19/2018 12:30 AM, Philippe Mathieu-Daudé wrote: On 03/16/2018 05:23 PM, KONRAD Frederic wrote: Since the commit: commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff226

[Qemu-devel] [PULL 0/1] Seabios 1.11.1 20180319 patches

2018-03-19 Thread Gerd Hoffmann
The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into staging (2018-03-17 14:15:03 +) are available in the git repository at: git://git.kraxel.org/qemu tags/seabios-1.11.1-201

[Qemu-devel] [PULL 1/1] update seabios to 1.11.1

2018-03-19 Thread Gerd Hoffmann
git shortlog rel-1.11.0..rel-1.11.1 === Kevin O'Connor (3): build: Use git describe --always shadow: Don't invoke a shutdown on reboot unless in a reboot loop paravirt: Only enable sercon in NOGRAPHIC mode if no other console specified Marcel Apf

[Qemu-devel] qapi escape-too-big test doesn't work if LANG=C ?

2018-03-19 Thread Peter Maydell
I recently tweaked my build scripts to run with LANG=C (trying to suppress gcc's irritating habit of using smartquotes rather than plain old ''). This seems to result in an error running the qapi-schema/escape-too-big test: PYTHONPATH=/home/petmay01/linaro/qemu-for-merges/scripts python3 -B /home/

Re: [Qemu-devel] [PATCH 1/2] char: i.MX: Simplify imx_update()

2018-03-19 Thread Peter Maydell
On 15 March 2018 at 19:11, Andrey Smirnov wrote: > Code of imx_update() is slightly confusing since the "flags" variable > doesn't really corespond to anything in real hardware and server as a > kitchensink accumulating events normally reported via USR1 and USR2 > registers. > > Change the code to

Re: [Qemu-devel] HELP

2018-03-19 Thread Stefan Hajnoczi
On Sat, Mar 17, 2018 at 8:37 PM, Projat Banerjee wrote: > What is the type of proposal should I submit here ? What kind or on what > basis should I build my proposal so that I may get easily selected or chances > for my selection is high ? Are you referring to Google Summer of Code? Outreachy?

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 03/15/2018 07:03 PM, Dr. David Alan Gilbert wrote: > > > > +static int compress_threads_load_setup(void) > > > +{ > > > +int i, thread_count; > > > + > > > +if (!migrate_use_compression()) { > > > +return 0; > > > +}

Re: [Qemu-devel] [PULL 0/8] ppc-for-2.12 queue 20180319

2018-03-19 Thread Peter Maydell
Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180319 > > for you to fetch changes up to 91c60f124e682a78c9a2ef951e8e58ebab6441d0: > > target/ppc: fix tlbsync to check privilege level d

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Peter Maydell
On 13 March 2018 at 23:16, Philippe Mathieu-Daudé wrote: > On 03/13/2018 06:09 PM, Peter Maydell wrote: >> On 13 March 2018 at 16:55, Andrew Baumann >> wrote: >>> At some point I remember seeing a patch to change this to cortex-a7. Is >>> there a reason we didn't make that change? >>> >>> (Back

[Qemu-devel] [PATCH for-2.12] hw/arm/bcm2836: Use the Cortex-A7 instead of Cortex-A15

2018-03-19 Thread Peter Maydell
The BCM2836 uses a Cortex-A7, not a Cortex-A15. Update the device to use the correct CPU. https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf When the BCM2836 was introduced (bad5623690b) the Cortex-A7 was not available, so the very similar Cortex-A15 was used. Si

[Qemu-devel] [PULL v3 00/46] Block layer patches

2018-03-19 Thread Kevin Wolf
The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into staging (2018-03-17 14:15:03 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetc

Re: [Qemu-devel] qapi escape-too-big test doesn't work if LANG=C ?

2018-03-19 Thread Daniel P . Berrangé
On Mon, Mar 19, 2018 at 10:37:12AM +, Peter Maydell wrote: > I recently tweaked my build scripts to run with LANG=C (trying > to suppress gcc's irritating habit of using smartquotes rather > than plain old ''). This seems to result in an error running > the qapi-schema/escape-too-big test: > >

[Qemu-devel] [PATCH v2 0/2] target/m68k: add a mechanism to automatically free TCGv

2018-03-19 Thread Laurent Vivier
SRC_EA() and gen_extend() can return either a temporary TCGv or a memory allocated one. Mark them when they are allocated, and free them automatically at end of the instruction translation. We want to free locally allocated TCGv to avoid overflow in sequence like: 0x

[Qemu-devel] [PATCH v2 1/2] target/m68k: add DisasContext parameter to gen_extend()

2018-03-19 Thread Laurent Vivier
This parameter will be needed to manage automatic release of temporary allocated TCG variables. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/target/m68k/translate.c b

[Qemu-devel] [PATCH v2 2/2] target/m68k: add a mechanism to automatically free TCGv

2018-03-19 Thread Laurent Vivier
SRC_EA() and gen_extend() can return either a temporary TCGv or a memory allocated one. Mark them when they are allocated, and free them automatically at end of the instruction translation. We want to free locally allocated TCGv to avoid overflow in sequence like: 0xc00ae406: movel %fp@(-132),

Re: [Qemu-devel] [PULL 0/1] Seabios 1.11.1 20180319 patches

2018-03-19 Thread Peter Maydell
git repository at: > > git://git.kraxel.org/qemu tags/seabios-1.11.1-20180319-pull-request > > for you to fetch changes up to 9cdd2a736b99bad19fb4f88d2230c75f680c31ec: > > update seabios to 1.11.1 (2018-03-19 11:18:29 +0100) > > ---

Re: [Qemu-devel] [PATCH v8 5/9] block: treat BDRV_REQ_ALLOCATE as serialising

2018-03-19 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:54 AM CET, Anton Nefedov wrote: > The idea is that ALLOCATE requests may overlap with other requests. > Reuse the existing block layer infrastructure for serialising requests. > Use the following approach: > - mark ALLOCATE serialising, so subsequent requests to the area

Re: [Qemu-devel] [Qemu-arm] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Peter Maydell
On 13 March 2018 at 15:34, Peter Maydell wrote: > Now we have separate types for BCM2386 and BCM2387, we might as well > just hard-code the CPU type they use rather than having it passed > through as an object property. This then lets us put the initialization > of the CPU object in init rather th

[Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main()

2018-03-19 Thread Bastian Koppelmann
if '-w 16' was given as a cmdline args a local copy of insnmask is set and not the global one. Signed-off-by: Peer Adelt Signed-off-by: Bastian Koppelmann --- scripts/decodetree.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 41301c84aa

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-19 Thread 858585 jemmy
ping. On Thu, Mar 15, 2018 at 1:33 PM, 858585 jemmy wrote: > On Thu, Mar 15, 2018 at 4:19 AM, Dr. David Alan Gilbert > wrote: >> * Lidong Chen (jemmy858...@gmail.com) wrote: >>> RDMA migration implement save_page function for QEMUFile, but >>> ram_control_save_page do not increase bytes_xfer. So

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > Hi David, > > Thanks for your review. > > On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: > > > > migration/ram.c | 32 > > > > Hi, > >Do you have some performance numbers to show this helps? We

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-19 Thread Xiao Guangrong
On 03/19/2018 06:54 PM, Dr. David Alan Gilbert wrote: +return 0; +exit: +compress_threads_load_cleanup(); I don't think this is safe; if inflateInit(..) fails in not-the-last thread, compress_threads_load_cleanup() will try and destroy all the mutex's and condition variables, even th

Re: [Qemu-devel] [PULL v3 00/46] Block layer patches

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 11:04, Kevin Wolf wrote: > The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: > > Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into > staging (2018-03-17 14:15:03 +) > > are available in the git repository at: > > git://r

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 03/15/2018 07:47 PM, Dr. David Alan Gilbert wrote: > > > > /* Check the pages is dirty and if it is send it */ > > > if (migration_bitmap_clear_dirty(rs, pss->block, pss->page)) { > > > +RAMBlock *block = pss->block;

[Qemu-devel] [PATCH for-2.12] gitmodules: Use the QEMU mirror of qemu-palcode

2018-03-19 Thread Peter Maydell
We have a mirror of the qemu-palcode repository on git.qemu.org; use that instead of the upstream github, in line with our general policy of keeping and using a mirror for submodules. Signed-off-by: Peter Maydell --- We also currently have two submodules we don't have mirroring for: seabios-hppa

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-03-19 Thread Peter Maydell
On 21 February 2018 at 05:27, Jeff Cody wrote: > On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: >> I just noticed that we seem to have acquired another git >> submodule that isn't pointing to a qemu.org git url: >> >> [submodule "roms/seabios-hppa"] >> path = roms/seabios-h

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-03-19 Thread BALATON Zoltan
On Mon, 19 Mar 2018, Peter Maydell wrote: On 21 February 2018 at 05:27, Jeff Cody wrote: On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: I just noticed that we seem to have acquired another git submodule that isn't pointing to a qemu.org git url: [submodule "roms/seabios-hppa"]

[Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Su Hang
Bug fix: checkpatch.pl stops complaining about following pattern: """ do { //do somethins; } while (conditions); """ Signed-off-by: Su Hang --- scripts/checkpatch.pl | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatc

[Qemu-devel] [PATCH v2] target-mips: Add initrd support for the Boston board

2018-03-19 Thread Aleksandar Rikalo
From: Aleksandar Rikalo Add support for initial ramdisk loading for the Mips Boston board. Signed-off-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé --- Changes since previous version according to Philippe's comments: - 'long inird_size' is changed to 'target_ulong initrd_size',

[Qemu-devel] [PATCH for-2.12] hw/misc/macio: Fix crash when listing device properties of macio device

2018-03-19 Thread Thomas Huth
The macio-newworld device can currently be used to abort QEMU unexpectedly: $ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2}, "package": "build-all"}, "capabilities": []}} { 'execute': 'qmp_capabilities' } {"re

[Qemu-devel] [PATCH] hax: Properly handle IA32_APIC_BASE MSR

2018-03-19 Thread chao . qin
From: Qin Chao Emulation of IA32_APIC_BASE MSR in HAXM is not correct, such as bit 8, which is BSP flag and should be set to 1 for the bootstrap processor and set to 0 for the application processors, but it's set to 0 for all processors in HAXM. So guest OSes that expect a valid BSP flag, such as

[Qemu-devel] [Bug 1756807] Re: performance regression in qemu-user + proot

2018-03-19 Thread ChristianEhrhardt
Thanks for the check Alistar, Lets add a Qemu (upstream) bug task so this one is mirrored to the ML. I'm not familiar with that area, but on the ML one can decide if it is a dup to https://bugs.launchpad.net/qemu/+bug/1740219 or not. ** Also affects: qemu Importance: Undecided Status:

[Qemu-devel] [PATCH 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-03-19 Thread Shannon Zhao
It should skip to getting/putting the registers banked by GICR so that it could get/put the correct ones. Signed-off-by: Shannon Zhao --- hw/intc/arm_gicv3_kvm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index 7000716..e

[Qemu-devel] [PATCH 1/2] arm_gicv3_kvm: increase clroffset accordingly

2018-03-19 Thread Shannon Zhao
It forgot to increase clroffset during the loop. So it only clear the first 4 bytes. Signed-off-by: Shannon Zhao --- hw/intc/arm_gicv3_kvm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index ec37177..7000716 100644 -

[Qemu-devel] [PATCH 0/2] two fixes for KVM GICv3 dist get/put functions

2018-03-19 Thread Shannon Zhao
Shannon Zhao (2): arm_gicv3_kvm: increase clroffset accordingly arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR hw/intc/arm_gicv3_kvm.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) -- 2.0.4

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-19 Thread Igor Mammedov
On Thu, 15 Mar 2018 17:13:03 + Peter Maydell wrote: > On 13 March 2018 at 16:55, Andrew Baumann > wrote: > >> From: Qemu-devel >> bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter > >> Maydell > >> Sent: Tuesday, 13 March 2018 08:35 > >> > >> Now we have separate types fo

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

2018-03-19 Thread Eric Blake
On 03/16/2018 09:40 AM, Nia Alarie wrote: If qemu_strtoi indicates an error, return the default value. Would it be better to diagnose the error instead of silently returning a default value? Signed-off-by: Nia Alarie --- audio/audio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletion

Re: [Qemu-devel] [PULL 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Eric Blake
On 03/19/2018 04:26 AM, Peter Xu wrote: for you to fetch changes up to 75eb57e3ed3682f011a6694863044e8b143a9821: qapi: Pass '-u' when doing non-silent diff (2018-03-16 09:00:07 -0500) Hi. I get a bunch of test assertion failures with this: ppc64 host: QTEST_QEMU_BINARY=nios2-softmmu/qe

[Qemu-devel] [PATCH for-2.12] hw/char/serial: Fix crash when serial_mm_init() is used with -nodefaults

2018-03-19 Thread Thomas Huth
Quite a lot of boards call serial_mm_init() directly with a value from the serial_hds[] table. However, this table is only containing NULL if QEMU has been started with "-nodefaults": $ gdb --args arm-softmmu/qemu-system-arm -S -nodefaults -M cubieboard (gdb) r Program received signal SIGSEGV, Seg

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

2018-03-19 Thread nee
On Mon, Mar 19, 2018 at 2:47 PM, Eric Blake wrote: > On 03/16/2018 09:40 AM, Nia Alarie wrote: >> >> If qemu_strtoi indicates an error, return the default value. > > > Would it be better to diagnose the error instead of silently returning a > default value? > >> >> Signed-off-by: Nia Alarie >> --

Re: [Qemu-devel] [PULL v2 0/7] Machine queue, 2018-03-15

2018-03-19 Thread Igor Mammedov
On Fri, 16 Mar 2018 16:28:54 -0300 Eduardo Habkost wrote: > On Fri, Mar 16, 2018 at 07:05:29PM +, Peter Maydell wrote: > > On 15 March 2018 at 18:14, Eduardo Habkost wrote: > > > Changes in v2 (v1 was 2018-03-12): > > > * Fix bsd-user build error > > > > > > The following changes since commi

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

2018-03-19 Thread Eric Blake
On 03/19/2018 10:01 AM, nee wrote: On Mon, Mar 19, 2018 at 2:47 PM, Eric Blake wrote: On 03/16/2018 09:40 AM, Nia Alarie wrote: If qemu_strtoi indicates an error, return the default value. Would it be better to diagnose the error instead of silently returning a default value? Possibly

[Qemu-devel] [PATCH 0/2] vhost-user-scsi: add message for device reset

2018-03-19 Thread David Vrabel
When a virtio scsi device is reset by a guest, the reset is not passed on to the vhost-user backend. This reset may be necessary if a device driver is restarted or the device is handed off between (for example) SeaBIOS and the OS. Iff the vhost-user-scsi backend reports that it supports a new "res

[Qemu-devel] [PATCH 1/2] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices

2018-03-19 Thread David Vrabel
Add a VHOST_USER_RESET_DEVICE message which will reset the vhost user backend. Disabling all rings, and resetting all internal state, ready for the backend to be reinitialized. A backend has to report it supports this features with the VHOST_USER_PROTOCOL_F_RESET_DEVICE protocol feature bit. If it

[Qemu-devel] [PATCH 2/2] vhost-user-scsi: reset the device if supported

2018-03-19 Thread David Vrabel
If the vhost-user-scsi backend supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the device can be reset when requested. If this feature is not supported, do not try a reset as this will send a VHOST_USER_RESET_OWNER that the backend is not expecting, potentially putting into an inoper

Re: [Qemu-devel] qapi escape-too-big test doesn't work if LANG=C ?

2018-03-19 Thread Eric Blake
On 03/19/2018 06:20 AM, Daniel P. Berrangé wrote: On Mon, Mar 19, 2018 at 10:37:12AM +, Peter Maydell wrote: I recently tweaked my build scripts to run with LANG=C (trying to suppress gcc's irritating habit of using smartquotes rather than plain old ''). This seems to result in an error runn

Re: [Qemu-devel] [PATCH v9 13/14] hw/arm/virt-acpi-build: Add smmuv3 node in IORT table

2018-03-19 Thread Shannon Zhao
On 2018/3/12 20:48, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> From: Prem Mallappa >> >> This patch builds the smmuv3 node in the ACPI IORT table. >> >> The RID space of the root complex, which spans 0x0-0x1 >> maps to streamid space 0x0-0x1 in smmuv3, whi

Re: [Qemu-devel] [PATCH v3 14/22] target/arm: Make PMOVSCLR 64 bits wide

2018-03-19 Thread Aaron Lindsay
Phil, On Mar 19 00:14, Philippe Mathieu-Daudé wrote: > Hi Aaron, > > On 03/16/2018 09:31 PM, Aaron Lindsay wrote: > > This is a bug fix to ensure 64-bit reads of this register don't read > > adjacent data. > > > > Signed-off-by: Aaron Lindsay > > --- > > target/arm/cpu.h | 2 +- > > 1 file cha

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Eric Blake
On 03/19/2018 08:56 AM, Su Hang wrote: Bug fix: checkpatch.pl stops complaining about following pattern: """ do { //do somethins; s/somethins/something/ } while (conditions); Having the commit message point to the commit id that introduced the bug is useful. The grammar is awkward (i

Re: [Qemu-devel] [PULL 00/38] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-19 Thread Eric Blake
On 03/19/2018 09:57 AM, Eric Blake wrote: On 03/19/2018 04:26 AM, Peter Xu wrote: for you to fetch changes up to 75eb57e3ed3682f011a6694863044e8b143a9821:    qapi: Pass '-u' when doing non-silent diff (2018-03-16 09:00:07 -0500) Hi. I get a bunch of test assertion failures with this:

Re: [Qemu-devel] [PATCH v4] file-posix: specify expected filetypes

2018-03-19 Thread Kevin Wolf
Am 13.03.2018 um 18:20 hat John Snow geschrieben: > > > On 01/19/2018 06:03 PM, Eric Blake wrote: > > On 01/19/2018 04:47 PM, John Snow wrote: > >> Adjust each caller of raw_open_common to specify if they are expecting > >> host and character devices or not. Tighten expectations of file types upo

Re: [Qemu-devel] [PATCH v3 23/24] RISC-V: Convert cpu definition towards future model

2018-03-19 Thread Igor Mammedov
On Fri, 16 Mar 2018 12:41:20 -0700 Michael Clark wrote: > - Model borrowed from target/sh4/cpu.c > - Rewrote riscv_cpu_list to use object_class_get_list > - Dropped 'struct RISCVCPUInfo' and used TypeInfo array > - Replaced riscv_cpu_register_types with DEFINE_TYPES > - Marked base class as abstr

[Qemu-devel] [PULL v2 3/7] fixup! tests: add machine 'none' with -cpu test

2018-03-19 Thread Igor Mammedov
Fixup test to account for 2 new targets that were merged since this test was written. Signed-off-by: Igor Mammedov --- tests/machine-none-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c index 596ad01..efdd4be 100644 --- a/tests/m

Re: [Qemu-devel] [PATCH] iotests: 163 is not quick

2018-03-19 Thread Kevin Wolf
Am 10.03.2018 um 22:45 hat Eric Blake geschrieben: > Testing on ext4, most 'quick' qcow2 tests took less than 5 seconds, > but 163 took more than 20. Let's remove it from the quick set. > > Signed-off-by: Eric Blake Takes only 11 seconds for me, but that's still longer than most other tests. T

Re: [Qemu-devel] [PATCH v3 14/22] target/arm: Make PMOVSCLR 64 bits wide

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 15:24, Aaron Lindsay wrote: > Phil, > > On Mar 19 00:14, Philippe Mathieu-Daudé wrote: >> Hi Aaron, >> >> On 03/16/2018 09:31 PM, Aaron Lindsay wrote: >> > This is a bug fix to ensure 64-bit reads of this register don't read >> > adjacent data. >> > >> > Signed-off-by: Aaron Li

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Su Hang
> -Original Messages- > From: "Eric Blake" > Sent Time: 2018-03-19 23:25:20 (Monday) > To: "Su Hang" , vsement...@virtuozzo.com > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix > Having the commit message point to the commit id that introd

Re: [Qemu-devel] [PATCH] hax: Properly handle IA32_APIC_BASE MSR

2018-03-19 Thread Paolo Bonzini
On 19/03/2018 10:04, chao@linux.intel.com wrote: > From: Qin Chao > > Emulation of IA32_APIC_BASE MSR in HAXM is not correct, such as bit > 8, which is BSP flag and should be set to 1 for the bootstrap > processor and set to 0 for the application processors, but it's set > to 0 for all proces

Re: [Qemu-devel] [PATCH] replay: finish record/replay before closing the disks

2018-03-19 Thread Paolo Bonzini
On 19/03/2018 10:25, Pavel Dovgalyuk wrote: > After recent updates block devices cannot be closed on qemu exit. > This happens due to the block request polling when replay is not finished. > Therefore now we stop execution recording before closing the block devices. > > Signed-off-by: Pavel Dovgal

Re: [Qemu-devel] [PATCH v2] tcg: Really fix cpu_io_recompile

2018-03-19 Thread Paolo Bonzini
On 19/03/2018 04:15, Richard Henderson wrote: > We have confused the number of instructions that have been > executed in the TB with the number of instructions needed > to repeat the I/O instruction. > > We have used cpu_restore_state_from_tb, which means that > the guest pc is pointing to the I/O

Re: [Qemu-devel] [PATCH] hax: Properly handle IA32_APIC_BASE MSR

2018-03-19 Thread Igor Mammedov
On Mon, 19 Mar 2018 17:04:49 +0800 chao@linux.intel.com wrote: > From: Qin Chao > > Emulation of IA32_APIC_BASE MSR in HAXM is not correct, such as bit > 8, which is BSP flag and should be set to 1 for the bootstrap > processor and set to 0 for the application processors, but it's set > to 0

Re: [Qemu-devel] [Qemu-block] [PATCH v1 1/1] iotests: fix test case 185

2018-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2018 at 9:35 AM, QingFeng Hao wrote: > Test case 185 failed since commit 4486e89c219 --- "vl: introduce > vm_shutdown()". > It's because of the newly introduced function vm_shutdown calls > bdrv_drain_all, > which is called later by bdrv_close_all. bdrv_drain_all resumes the jobs

[Qemu-devel] [PATCH for-2.12 0/2] bcm2835_sdhost: fix interrupt handling

2018-03-19 Thread Peter Maydell
This patchset fixes the code in the bcm2835_sdhost device so that it raises interrupts in more plausible places. The Linux bcm2835_sdhost driver doesn't work on QEMU at the moment, because our model raises spurious data interrupts. Our function bcm2835_sdhost_fifo_run() will flag an interrupt any

[Qemu-devel] qemu:handle_cpu_signal received signal outside vCPU context

2018-03-19 Thread Andreas Schwab
I'm seeing this error while building gedit for riscv64 with linux-user emulation: $ LD_LIBRARY_PATH=gedit/.libs qemu-riscv64 gedit/.libs/gedit --introspect-dump=/tmp/tmp-introspectnj0xla07/functions.txt,/tmp/tmp-introspectnj0xla07/dump.xml qemu:handle_cpu_signal received signal outside vCPU conte

Re: [Qemu-devel] [PATCH v4] file-posix: specify expected filetypes

2018-03-19 Thread John Snow
On 03/19/2018 11:29 AM, Kevin Wolf wrote: > Am 13.03.2018 um 18:20 hat John Snow geschrieben: >> >> >> On 01/19/2018 06:03 PM, Eric Blake wrote: >>> On 01/19/2018 04:47 PM, John Snow wrote: Adjust each caller of raw_open_common to specify if they are expecting host and character devices

[Qemu-devel] [PATCH] tpm: Set tpmRegValidSts flag to '1' in initialization

2018-03-19 Thread Stefan Berger
Fix the initialization of the tpmRegValidSts flag and set it to '1' during device reset without expecting a write to another register. This seems to also be the default behavior of real hardware. Signed-off-by: Stefan Berger --- hw/tpm/tpm_crb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[Qemu-devel] [PATCH] tpm: Set tpmRegValidSts flag to '1' in device reset

2018-03-19 Thread Stefan Berger
Fix the initialization of the tpmRegValidSts flag and set it to '1' during device reset without expecting a write to another register. This seems to also be the default behavior of real hardware. Signed-off-by: Stefan Berger --- hw/tpm/tpm_crb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[Qemu-devel] [PATCH RFC v2] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Su Hang
Commit 2b9aef6fcd96ba7ed8c1ee723e391901852d344c introduced a regression: checkpatch.pl started complaining about the following valid pattern: do { /* something */ } while (condition); Fix the script to once again permit this pattern. --- v1: fix bug. v2: correct inappropriate patch descripti

Re: [Qemu-devel] [PATCH 1/2] arm_gicv3_kvm: increase clroffset accordingly

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 14:36, Shannon Zhao wrote: > It forgot to increase clroffset during the loop. So it only clear the > first 4 bytes. > > Signed-off-by: Shannon Zhao > --- > hw/intc/arm_gicv3_kvm.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/intc/arm_gicv3

Re: [Qemu-devel] [PATCH for-2.12] gitmodules: Use the QEMU mirror of qemu-palcode

2018-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2018 at 01:17:43PM +, Peter Maydell wrote: > We have a mirror of the qemu-palcode repository on > git.qemu.org; use that instead of the upstream github, > in line with our general policy of keeping and using > a mirror for submodules. > > Signed-off-by: Peter Maydell > --- > W

[Qemu-devel] [PATCH for-2.12 2/2] hw/sd/bcm2835_sdhost: Don't raise spurious interrupts

2018-03-19 Thread Peter Maydell
The Linux bcm2835_sdhost driver doesn't work on QEMU, because our model raises spurious data interrupts. Our function bcm2835_sdhost_fifo_run() will flag an interrupt any time it is called with s->datacnt == 0, even if the host hasn't actually issued a data read or write command yet. This means t

[Qemu-devel] [PATCH for-2.12 1/2] hw/sd/bcm2835_sdhost: Add tracepoints

2018-03-19 Thread Peter Maydell
Add some tracepoints to the bcm2835_sdhost driver, to assist debugging. Signed-off-by: Peter Maydell --- hw/sd/bcm2835_sdhost.c | 10 ++ hw/sd/trace-events | 6 ++ 2 files changed, 16 insertions(+) diff --git a/hw/sd/bcm2835_sdhost.c b/hw/sd/bcm2835_sdhost.c index f7f4e656df..7

[Qemu-devel] [Bug 1756927] [NEW] ARMv7 LPAE: IFSR doesn't have the LPAE bit in case of BKPT

2018-03-19 Thread Vincent Siles
Public bug reported: When a user application triggers a 'bkpt' instruction while LPAE is used, the bit [9] of IFSR is not correctly set during the prefetch abort exception. You'll find attached a minimal example to reproduce the issue (just run 'make all'). The output I get is: supervisor user

  1   2   3   4   >