> -----Original Messages----- > From: "Eric Blake" <ebl...@redhat.com> > Sent Time: 2018-03-19 23:25:20 (Monday) > To: "Su Hang" <suhan...@mails.ucas.ac.cn>, vsement...@virtuozzo.com > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix
> Having the commit message point to the commit id that introduced the bug > is useful. The grammar is awkward (it sounds like the bug is that > checkpatch.pl stopped complaining about the pattern, so the fix is to > reinstate the complaint); better might be: > > Commit XYZ introduced a regression: checkpatch.pl started complaining > about the following valid pattern: > do { > /* something */ > } while (condition); > > Fix the script to once again permit this pattern. Thank you for correcting my mistakes. :-) > Is this an updated revision to a patch posted earlier? If so, including > 'v2' in the subject line (easy if you use 'git format-patch -v2' or 'git > send-email -v2'), and then using this space after the --- separator to > describe what changed since v1, makes life easier for reviewers. Yes, it's an updated revision to a earlier patch. But I wasn't about sending it, when I was using [ctrl + r] and [enter], I send it accidentally. Thanks for your kind suggestion. Best, Su Hang