From: Philippe Mathieu-Daudé
(qemu) info mtree
address-space: cpu-memory-0
- (prio 0, i/o): system
-07ff (prio 0, rom): aspeed.boot_rom
-1e60-1e7f (prio -1, i/o): aspeed_soc.io
+1e60-0
The v8M architecture includes hardware support for enforcing
stack pointer limits. We don't implement this behaviour yet,
but provide the MSPLIM and PSPLIM stack pointer limit registers
as reads-as-written, so that when we do implement the checks
in future this won't break guest migration.
Signed-
From: Pekka Enberg
This patch adds a "cpu-type" property to BCM2836 SoC in preparation for
reusing the code for the Raspberry Pi 3, which has a different processor
model.
Signed-off-by: Pekka Enberg
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
include/hw/arm/bcm2836.h | 1 +
In many of the NVIC registers relating to interrupts, we
have to convert from a byte offset within a register set
into the number of the first interrupt which is affected.
We were getting this wrong for:
* reads of NVIC_ISPR, NVIC_ISER, NVIC_ICPR, NVIC_ICER,
NVIC_IABR -- in all these cases we w
Le 05/02/2018 à 12:40, Andreas Schwab a écrit :
> Signed-off-by: Andreas Schwab
> ---
> linux-user/syscall.c | 23 +++
> 1 file changed, 23 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index ff89016adc..82848fd97d 100644
> --- a/linux-user/sysc
We were previously making the system control register (SCR)
just RAZ/WI. Although we don't implement the functionality
this register controls, we should at least provide the state,
including the banked state for v8M.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Message-id: 2018020
In commit abc24d86cc0364f we accidentally broke migration of
the stack pointer value for the mode (process, handler) the CPU
is not currently running as. (The commit correctly removed the
no-longer-used v7m.current_sp flag from the VMState but also
deleted the still very much in use v7m.other_sp SP
This series of patches adds tests for the TPM TIS.
Stefan
v1->v2:
- moved common TPM test code into tpm-emu.c
- clearified a few comments in tpm-tis-test.c, no code changes
Stefan Berger (2):
tests: Move common TPM test code into tpm-emu.c
tests: add test for TPM TIS device
MAINTAINER
In commit 50f11062d4c896 we added support for MSR/MRS access
to the NS banked special registers, but we forgot to implement
the support for writing to CONTROL_NS. Correct the omission.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Message-id: 20180209165810.6668-8-peter.mayd...@lin
On 14 February 2018 at 11:20, Thomas Huth wrote:
> The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> staging (2018-02-13 18:24:08 +)
>
> are available in the git repository at:
>
> https
In commit commit 3b2e934463121 we added support for the AIRCR
register holding state, but forgot to add it to the vmstate
structs. Since it only holds r/w state if the security extension
is implemented, we can just add it to vmstate_m_security.
Signed-off-by: Peter Maydell
Reviewed-by: Richard He
On 15.02.2018 15:13, Eric Blake wrote:
> On 02/15/2018 03:49 AM, Cornelia Huck wrote:
>> On Thu, 15 Feb 2018 10:47:45 +0100
>> David Hildenbrand wrote:
>>
>>> On 14.02.2018 20:04, Richard Henderson wrote:
On 02/14/2018 09:31 AM, David Hildenbrand wrote:
> Let's add proper alignment checks
This is fixed long time ago
Greetings
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1589272
Title:
qemu-system-x86_64: There is no option group 'vnc'
Status in QEMU:
Incomplete
Bug description
On 01/05/2018 02:57 PM, Eric Blake wrote:
> On 01/05/2018 08:44 AM, Murilo Opsfelder Araujo wrote:
>> This patch prevents a possible segmentation fault when .desc members are
>> checked
>> against NULL.
>>
>> The ssh_runtime_opts was added by commit
>> 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("bl
On 02/15/2018 04:20 AM, Viktor Mihajlovski wrote:
From: Luiz Capitulino
The query-cpus command has an extremely serious side effect:
it always interrupts all running vCPUs so that they can run
ioctl calls. This can cause a huge performance degradation for
some workloads. And most of the informa
On 02/15/2018 04:20 AM, Viktor Mihajlovski wrote:
Start the deprecation period for QAPI query-cpus (replaced by
query-cpus-fast) and HMP 'info cpus' (replaced by 'info cpus_fast')
beginning with 2.12.0.
See my comments on 2/4 - if we want, we could just make HMP 'info cpus'
be the fast version
Move the TPM TIS related register and flag #defines into
include/hw/acpi/tpm.h for access by the test case.
Write a test case that covers the TIS functionality.
Add the tests cases to the MAINTAINERS file.
Signed-off-by: Stefan Berger
---
MAINTAINERS| 1 +
hw/tpm/tpm_tis.c
Move threads and other common TPM test code into tpm-emu.c.
Signed-off-by: Stefan Berger
---
tests/Makefile.include | 2 +-
tests/tpm-crb-test.c | 174 +
tests/tpm-emu.c| 168 +++
tests/tpm-em
Am 15.02.2018 um 12:15 schrieb Stefan Hajnoczi:
The libiscsi iscsi_task_mgmt_async() API documentation says:
abort_task will also cancel the scsi task. The callback for the scsi
task will be invoked with SCSI_STATUS_CANCELLED
The libiscsi implementation does not fulfil this promise. The
Le 06/02/2018 à 11:31, Andreas Schwab a écrit :
> No attempt is made to emulate it on the host.
I don't understand what you mean here...
> Signed-off-by: Andreas Schwab
> ---
> v2: fix spacing
> ---
> linux-user/syscall.c | 39 +++
> 1 file changed, 39 insert
On 02/15/2018 04:08 AM, Daniel P. Berrangé wrote:
Hmm - here you're changing who supplies the (). But that argues that
maybe the callsites should supply " (" and ")" themselves.
Yeah, that's likely the saner way to do this. The question is: What
about the query-version QMP command? Should it
On 02/15/2018 03:49 AM, Cornelia Huck wrote:
On Thu, 15 Feb 2018 10:47:45 +0100
David Hildenbrand wrote:
On 14.02.2018 20:04, Richard Henderson wrote:
On 02/14/2018 09:31 AM, David Hildenbrand wrote:
Let's add proper alignment checks for a handful of instructions that
require a SPECIFICATION
On 02/15/2018 04:12 AM, Kevin Wolf wrote:
Having acquired the AioContext does not make this function return true.
The semantics are:
1. Current thread is the IOThread that runs the AioContext
2. Current thread is the main loop and the AioContext is the global
AioContext.
The function tests w
On 02/15/2018 04:23 AM, Anton Nefedov wrote:
The output is better indeed, thanks; a little drawback is now we need to
pass the whole BlockStats to the driver so it fills its stats.
e.g. the interface:
void (*bdrv_get_stats)(BlockDriverState *bs, BlockStats *stats);
And that BlockdevDriver
On 02/15/2018 05:06 AM, Thomas Huth wrote:
Since commit 67a1de0d195a there is no space anymore between the
version number and the parentheses when running configure with
--with-pkgversion=foo :
$ qemu-system-s390x --version
QEMU emulator version 2.11.50(foo)
But the space is included when b
On 02/15/2018 04:26 AM, Daniel P. Berrangé wrote:
vnc_listen_io() does not own the reference on the 'cioc' parameter is it
passed, so should not be unref'ing it.
Reported-by: Bandan Das
Signed-off-by: Daniel P. Berrangé
---
ui/vnc.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Eric B
On Feb 15 2018, Laurent Vivier wrote:
> Le 06/02/2018 à 11:31, Andreas Schwab a écrit :
>> No attempt is made to emulate it on the host.
>
> I don't understand what you mean here...
If your host doesn't have it, neither will the emulation.
Andreas.
--
Andreas Schwab, SUSE Labs, sch...@suse.de
Le 08/02/2018 à 10:56, Nageswara R Sastry a écrit :
> On 2018-02-07 19:27, Laurent Vivier wrote:
>> Le 07/02/2018 à 10:49, no-re...@patchew.org a écrit :
>>> Hi,
>>>
>>> This series failed build test on s390x host. Please find the details
>>> below.
>> ...
>>> CC aarch64_be-linux-user/linux-
On 02/15/2018 08:09 AM, Murilo Opsfelder Araujo wrote:
On 01/05/2018 02:57 PM, Eric Blake wrote:
On 01/05/2018 08:44 AM, Murilo Opsfelder Araujo wrote:
This patch prevents a possible segmentation fault when .desc members are checked
against NULL.
Cc: Max Reitz
Cc: Eric Blake
Signed-off-by
On 15.02.2018 15:19, Eric Blake wrote:
> On 02/15/2018 04:20 AM, Viktor Mihajlovski wrote:
>> From: Luiz Capitulino
>>
>> The query-cpus command has an extremely serious side effect:
>> it always interrupts all running vCPUs so that they can run
>> ioctl calls. This can cause a huge performance de
On 02/15/2018 08:40 AM, Viktor Mihajlovski wrote:
On 15.02.2018 15:19, Eric Blake wrote:
On 02/15/2018 04:20 AM, Viktor Mihajlovski wrote:
From: Luiz Capitulino
The query-cpus command has an extremely serious side effect:
it always interrupts all running vCPUs so that they can run
ioctl calls
On 02/14/2018 10:28 PM, Philippe Mathieu-Daudé wrote:
It ease code review, unit is explicit.
I noticed it here, then see it occurs throughout the series:
s/ease/eases/ in the commit message.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/tc58128.c | 2 +-
hw/sh4/r2d.c | 2 +-
On 02/15/2018 02:50 AM, David Hildenbrand wrote:
> On 15.02.2018 11:38, David Hildenbrand wrote:
>> Let's add proper alignment checks for a handful of instructions that
>> require a SPECIFICATION exception in case alignment is violated.
>>
>> Introduce new wout/in functions. As we are right now onl
On 15.02.2018 15:53, Eric Blake wrote:
> On 02/15/2018 08:40 AM, Viktor Mihajlovski wrote:
>> On 15.02.2018 15:19, Eric Blake wrote:
>>> On 02/15/2018 04:20 AM, Viktor Mihajlovski wrote:
From: Luiz Capitulino
The query-cpus command has an extremely serious side effect:
it alway
On Thu, Feb 15, 2018 at 11:43 AM, Eric Blake wrote:
> On 02/14/2018 10:28 PM, Philippe Mathieu-Daudé wrote:
>>
>> It ease code review, unit is explicit.
>
>
> I noticed it here, then see it occurs throughout the series:
> s/ease/eases/ in the commit message.
Oops, thanks Eric I'll fix in respin.
On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> -void translator_loop_temp_check(DisasContextBase *db);
> +int translator_loop_temp_check(DisasContextBase *db);
>
bool.
Although I don't see how this is helpful. If you want to customize the output,
surely you just use tcg_check_temp_count direc
On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> A couple of notes:
>
> - removed ctx->nip in favour of base->pc_next. Yes, it is annoying,
> but didn't want to waste its 4 bytes.
>
> - ctx->singlestep_enabled does a lot more than
> base.singlestep_enabled; this confused me at first.
>
> Sign
On 02/15/2018 01:28 AM, Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.
Forgot to add:
Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/lm32/lm32_boards.c | 12 ++--
> hw/lm32/milkymist.c | 8
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
>
On 02/15/2018 01:28 AM, Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.
Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/misc/ivshmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 16f03701b7..9b3a
Le 24/01/2018 à 14:01, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> please double check __pad and ntohl()
>
> linux-user/syscall_defs.h | 7 +++
> linux-user/strace.c | 34 ++
> 2 files changed, 41 insertions(+)
>
>
On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> A few changes worth noting:
>
> - Didn't migrate ctx->exception to DISAS_* since the exception field is
> in many cases architecturally relevant.
>
> - Moved the cross-page check from the end of translate_insn to tb_start.
>
> - Removed the exit(
* Denis Plotnikov (dplotni...@virtuozzo.com) wrote:
>
>
> On 13.02.2018 18:05, Dr. David Alan Gilbert wrote:
> > * Denis V. Lunev (d...@virtuozzo.com) wrote:
> > > On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote:
> > > > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > > > On Tue, Feb
Hi Laurent,
On 02/15/2018 12:17 PM, Laurent Vivier wrote:
> Le 24/01/2018 à 14:01, Philippe Mathieu-Daudé a écrit :
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> please double check __pad and ntohl()
>>
>> linux-user/syscall_defs.h | 7 +++
>> linux-user/strace.c | 34 +++
On Thu, Feb 15, 2018 at 5:28 AM, Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.
Reviewed-by: Marc-André Lureau
> ---
> hw/misc/ivshmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 16f03701b7..9
Extend the MemTxAttrs to include 'debug' flag. The flag can be used as
general indicator that operation was triggered by the debugger.
Later in the patch series we set the debug=1 when issuing a memory access
from the gdbstub or HMP commands. This patch is prerequisite to support
debugging the enc
This patch series provides support for AMD's new Secure Encrypted
Virtualization (SEV) feature.
SEV is an extension to the AMD-V architecture which supports running
multiple VMs under the control of a hypervisor. The SEV feature allows
the memory contents of a virtual machine (VM) to be transpare
Currently, the guest memory access for the debug purpose is performed
using the memcpy(). Lets extend the 'struct MemoryRegion' to include
ram_debug_ops callbacks. The ram_debug_ops can be used to override
memcpy() with something else.
The feature can be used by encrypted guest -- which can regist
When CPU supports memory encryption feature, the property can be used to
specify the encryption object to use when launching an encrypted guest.
Cc: Paolo Bonzini
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: Stefan Hajnoczi
Signed-off-by: Brijesh Singh
---
hw/core/machine.c | 22 ++
Adds the following new APIs
- cpu_physical_memory_read_debug
- cpu_physical_memory_write_debug
- cpu_physical_memory_rw_debug
- ldl_phys_debug
- ldq_phys_debug
Cc: Paolo Bonzini
Cc: Peter Crosthwaite
Cc: Richard Henderson
Signed-off-by: Brijesh Singh
Reviewed-by: Paolo Bonzini
---
exec.c
Updates kmv.h to include memory encryption ioctls and SEV commands.
Cc: Christian Borntraeger
Cc: Cornelia Huck
Cc: Paolo Bonzini
Signed-off-by: Brijesh Singh
---
linux-headers/linux/kvm.h | 90 +++
1 file changed, 90 insertions(+)
diff --git a/lin
When memory encryption is enabled, the guest RAM and boot flash ROM will
contain the encrypted data. By setting the debug ops allow us to invoke
encryption APIs when accessing the memory for the debug purposes.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: "Michael S. Tsirkin"
When SEV is enabled, the hardware encryption engine uses a tweak such
that the two identical plaintext at different location will have a
different ciphertexts. So swapping or moving a ciphertexts of two guest
pages will not result in plaintexts being swapped. Hence relocating
a physical backing pag
Updates HMP commands to use the debug version of APIs when accessing the
guest memory.
Cc: Paolo Bonzini
Cc: Peter Crosthwaite
Cc: Richard Henderson
Cc: "Dr. David Alan Gilbert"
Cc: Markus Armbruster
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
cpus.c| 2 +-
disas.
Add a new memory encryption object 'sev-guest'. The object will be used
to create enrypted VMs on AMD EPYC CPU. The object provides the properties
to pass guest owner's public Diffie-hellman key, guest policy and session
information required to create the memory encryption context within the
SEV fi
The command is used to query the current SEV guest status. We use this
command to query the guest policy for QMP query-sev command.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
target/i386/sev.c | 16
1 file changed, 16 insertio
When memory encryption is enabled, KVM_SEV_INIT command is used to
initialize the platform. The command loads the SEV related persistent
data from non-volatile storage and initializes the platform context.
This command should be first issued before invoking any other guest
commands provided by the
The KVM_SEV_LAUNCH_START command creates a new VM encryption key (VEK).
The encryption key created with the command will be used for encrypting
the bootstrap images (such as guest bios).
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
target/i386/s
Create a documentation entry to describe the AMD Secure Encrypted
Virtualization (SEV) feature.
Cc: Paolo Bonzini
Signed-off-by: Brijesh Singh
---
docs/amd-memory-encryption.txt | 92 ++
1 file changed, 92 insertions(+)
create mode 100644 docs/amd-memory
When SEV is enabled, CPUID 0x8000_001F should provide additional
information regarding the feature (such as which page table bit is used
to mark the pages as encrypted etc).
The details for memory encryption CPUID is available in AMD APM
(https://support.amd.com/TechDocs/24594.pdf) Section E.4.17
query-sev command is used to get the SEV guest information, fill the
SevInfo fields with SEV guest information.
Cc: Eric Blake
Cc: "Daniel P. Berrangé"
Cc: "Dr. David Alan Gilbert"
Cc: Markus Armbruster
Signed-off-by: Brijesh Singh
---
qmp.c | 12 +++-
1 file changed, 11 insertions(+
The command can be used to show the SEV information when memory
encryption is enabled on AMD platform.
Cc: Eric Blake
Cc: "Daniel P. Berrangé"
Cc: "Dr. David Alan Gilbert"
Cc: Markus Armbruster
Signed-off-by: Brijesh Singh
---
hmp-commands-info.hx | 14 ++
hmp.c|
The QMP query command can used to retrieve the SEV information when
memory encryption is enabled on AMD platform.
Cc: Eric Blake
Cc: "Daniel P. Berrangé"
Cc: "Dr. David Alan Gilbert"
Cc: Markus Armbruster
Signed-off-by: Brijesh Singh
---
qapi-schema.json | 57
Inorder to integerate the Secure Encryption Virtualization (SEV) support
add few high-level memory encryption APIs which can be used for encrypting
the guest memory region.
Cc: Paolo Bonzini
Cc: k...@vger.kernel.org
Signed-off-by: Brijesh Singh
---
accel/kvm/kvm-all.c| 30 ++
SEV requires that guest bios must be encrypted before booting the guest.
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
hw/i386/pc_sysfw.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/i386/pc_sysf
During machine creation we encrypted the guest bios image, the
LAUNCH_MEASURE command can be used to retrieve the measurement of
the encrypted memory region. This measurement is a signature of
the memory contents that can be sent to the guest owner as an
attestation that the memory was encrypted co
The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory
region using the VM Encryption Key created using LAUNCH_START.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
accel/kvm/kvm-all.c | 2 ++
include/sysemu/sev.h | 1
SEV launch flow requires us to issue LAUNCH_FINISH command before guest
is ready to run.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
target/i386/sev.c| 29 +
target/i386/trace-events | 1 +
2 files changed,
In SEV-enabled guest the pte entry will have C-bit set, we need to
clear the C-bit when walking the page table.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
target/i386/helper.c | 31 +--
target/i386/monitor.c | 69 +
KVM_SEV_DBG_DECRYPT and KVM_SEV_DBG_ENCRYPT commands are used for
decrypting and encrypting guest memory region. The command works only if
the guest policy allows the debugging.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
accel/kvm/kvm-all.c
The header file provide the ioctl command and structure to communicate
with /dev/sev device.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Brijesh Singh
---
linux-headers/linux/psp-sev.h | 142 ++
1 file changed, 142 inserti
SEV guest migration is not implemented yet.
Signed-off-by: Brijesh Singh
Reviewed-by: Dr. David Alan Gilbert
---
target/i386/sev.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/target/i386/sev.c b/target/i386/sev.c
index 559881084d50..a4f5a87e9b51 100644
--- a/target/i386/s
The command can be used by libvirt to retrieve the measurement of SEV guest.
This measurement is a signature of the memory contents that was encrypted
through the LAUNCH_UPDATE_DATA.
Cc: "Daniel P. Berrangé"
Cc: "Dr. David Alan Gilbert"
Cc: Markus Armbruster
Signed-off-by: Brijesh Singh
---
q
On 14 February 2018 at 15:39, Dr. David Alan Gilbert (git)
wrote:
> From: "Dr. David Alan Gilbert"
>
> The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> staging (2018-02-13 18:24:08 +)
>
The query-sev-launch-measure command returns a measurement of encrypted
memory when SEV is enabled otherwise it returns an error. Blacklist the
command in qmp-test to fix the 'make check' failure.
Cc: "Daniel P. Berrangé"
Cc: "Dr. David Alan Gilbert"
Cc: Markus Armbruster
Reviewed-by: "Dr. Davi
On Thu, Feb 15, 2018 at 3:10 PM, Stefan Berger
wrote:
> This series of patches adds tests for the TPM TIS.
>
>Stefan
>
> v1->v2:
> - moved common TPM test code into tpm-emu.c
> - clearified a few comments in tpm-tis-test.c, no code changes
>
> Stefan Berger (2):
> tests: Move common TPM te
On 02/15/2018 02:04 AM, Thomas Huth wrote:
On 14.02.2018 16:33, Collin L. Walling wrote:
On 02/14/2018 05:57 AM, David Hildenbrand wrote:
[...]
1. CKC interrupts can be cleared by resetting the CKC
2. SCLP interrupts can be cleared only via delivery (apart from CPU
reset)
So if you have CKC a
>
> Ah, I understand the problem now. We can't have a multiple irqs of the
> *same* *type*
> pending at the same time, but we /can/ have multiple irqs of *different*
> *types* pending
> at the same time (i.e. a ckc and service signal).
Indeed, at least for these types of external interrupts.
(
On Thu, Feb 15, 2018 at 07:09:56 -0800, Richard Henderson wrote:
> On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> > -void translator_loop_temp_check(DisasContextBase *db);
> > +int translator_loop_temp_check(DisasContextBase *db);
>
> bool.
>
> Although I don't see how this is helpful. If you w
Here's a small series that prevents the user from opening corrupted
internal snapshots and allows 'qemu-img check' to detect and repair
them.
This is an RFC because I tried a few different approaches to deal with
this but I'm not 100% convinced with any of them.
What this one does is simply delet
The L1 table parameters of internal snapshots are generally not
checked by QEMU. This patch allows 'qemu-img check' to detect broken
snapshots and to skip them when doing the refcount consistency check.
Since without an L1 table we don't have a reliable way to recover the
data from the snapshot, w
The code that reads the qcow2 snapshot table takes the offset and size
of all snapshots' L1 table without doing any kind of checks.
Although qcow2_snapshot_load_tmp() does verify that the table size is
valid, the table offset is not checked at all. On top of that there
are several other code paths
Hi all.
Two years later, is there are any news on the topic?
I can't understand the following thing:
- FIEMAP without FLAG_SYNC is unsafe
- FIEMAP with FLAG_SYNC is safe but slow
- so, we've dropped FIEMAP and use only lseek. So, it means that lseek
is safe _and_ fast (at least, faster than
On 15/02/2018 17:40, Vladimir Sementsov-Ogievskiy wrote:
> Hi all.
>
> Two years later, is there are any news on the topic?
>
> I can't understand the following thing:
>
> - FIEMAP without FLAG_SYNC is unsafe
> - FIEMAP with FLAG_SYNC is safe but slow
> - so, we've dropped FIEMAP and use only
On Thu, 15 Feb 2018 11:38:22 +0100
David Hildenbrand wrote:
> Let's add proper alignment checks for a handful of instructions that
> require a SPECIFICATION exception in case alignment is violated.
>
> Introduce new wout/in functions. As we are right now only using them for
> privileged instruct
On Thu, 15 Feb 2018 15:08:18 +1100
David Gibson wrote:
> On Wed, Feb 14, 2018 at 08:41:03PM +0100, Greg Kurz wrote:
> >
> > It breaks migration of pre-2.7 machine types with unusual CPU topologies,
> > but I guess this is an acceptable trade-off.
>
> No, not really. Weird topologies are s
OK, thanks, so marking this as "Fix released" now
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1589272
Title:
qemu-system-x86_64: The
On Thu, Feb 15, 2018 at 05:08:57PM +0100, Greg Kurz wrote:
> On Thu, 15 Feb 2018 15:08:18 +1100
> David Gibson wrote:
>
> > On Wed, Feb 14, 2018 at 08:41:03PM +0100, Greg Kurz wrote:
>
>
>
> > >
> > > It breaks migration of pre-2.7 machine types with unusual CPU topologies,
> > > but I guess
Le 15/02/2018 à 16:28, Philippe Mathieu-Daudé a écrit :
> Hi Laurent,
>
> On 02/15/2018 12:17 PM, Laurent Vivier wrote:
>> Le 24/01/2018 à 14:01, Philippe Mathieu-Daudé a écrit :
>>> Signed-off-by: Philippe Mathieu-Daudé
>>> ---
>>> please double check __pad and ntohl()
>>>
>>> linux-user/syscal
On Thu, 15 Feb 2018 13:17:50 +
Peter Maydell wrote:
> On 15 February 2018 at 13:04, Philippe Mathieu-Daudé wrote:
> > Hi Peter,
> >
> > On 02/15/2018 08:29 AM, Peter Maydell wrote:
> >> On 2 February 2018 at 00:42, Alistair Francis
> >> wrote:
> >>> List all possible valid CPU options.
On Thu, 15 Feb 2018 16:54:18 +
Daniel P. Berrangé wrote:
> On Thu, Feb 15, 2018 at 05:08:57PM +0100, Greg Kurz wrote:
> > On Thu, 15 Feb 2018 15:08:18 +1100
> > David Gibson wrote:
> >
> > > On Wed, Feb 14, 2018 at 08:41:03PM +0100, Greg Kurz wrote:
> >
> >
> >
> > > >
> > > > It
When configure fails inside a docker job it is not easy to get access to
the config.log file. It is nicer for developers if we just splatter the
contents of config.log to stdout upon failure
Suggested-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
tests/docker/common.rc | 3 ++-
1 file ch
On 15 February 2018 at 09:42, Stefan Hajnoczi wrote:
> The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> staging (2018-02-13 18:24:08 +)
>
> are available in the Git repository at:
>
> g
Le 24/01/2018 à 14:01, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> linux-user/syscall.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index b6b9beca5b..e082af2911 100644
> --
Suggested-by: Eric Blake
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/common.rc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 7951555e3f..dd011cdf1e 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/com
On Thu, Feb 15, 2018 at 03:24:54PM +0100, Peter Lieven wrote:
> Am 15.02.2018 um 12:15 schrieb Stefan Hajnoczi:
> > The libiscsi iscsi_task_mgmt_async() API documentation says:
> >
> >abort_task will also cancel the scsi task. The callback for the scsi
> >task will be invoked with SCSI_STA
Le 24/01/2018 à 14:01, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> linux-user/syscall.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 11c9116c4a..b6b9beca5b 100644
> --- a/linux-user/syscall.
On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
> Suggested-by: Eric Blake
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/docker/common.rc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
>
The use of is recommended by the upstream project:
http://www.capstone-engine.org/lang_c.html
However when building the in-tree cloned submodule, the header is accessible
via .
This fixes building on Gentoo (and Haiku OS - not supported since 898be3e0415):
CC disas.o
/sources/qemu-2.
On Wed, Feb 14, 2018 at 8:28 PM, Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/xtensa/xtfpga.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Max Filippov
Michael, could you please take it into th
On 02/15/2018 02:34 PM, Daniel P. Berrangé wrote:
> On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
>> Suggested-by: Eric Blake
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> tests/docker/common.rc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff
101 - 200 of 399 matches
Mail list logo