On 01/05/2018 02:57 PM, Eric Blake wrote: > On 01/05/2018 08:44 AM, Murilo Opsfelder Araujo wrote: >> This patch prevents a possible segmentation fault when .desc members are >> checked >> against NULL. >> >> The ssh_runtime_opts was added by commit >> 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts for >> runtime >> options"). >> >> This fix was inspired by >> http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00883.html. >> >> Fixes: 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts >> for runtime options") > > present since 2.7.0, so we've gotten lucky that no one has actually > encountered a crash (but I didn't try hard to see if one was possible) > >> Cc: Max Reitz <mre...@redhat.com> >> Cc: Eric Blake <ebl...@redhat.com> >> Signed-off-by: Murilo Opsfelder Araujo <muri...@linux.vnet.ibm.com> >> --- >> block/ssh.c | 1 + >> 1 file changed, 1 insertion(+) > > CC: qemu-sta...@nongnu.org > Reviewed-by: Eric Blake <ebl...@redhat.com>
Hi, Eric. Was this supposed to land stable-2.11 branch? Cheers Murilo