[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2017-12-18 Thread ChristianEhrhardt
** Tags added: qemu-18.04 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1350435 Title: tcg.c:1693: tcg fatal error Status in launchpad-buildd: Won't Fix Status in QEMU: Fix Released Status in

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)

2017-12-18 Thread David Hildenbrand
> I think the best solution would be to call tcg_s390_program_interrupt() > directly from helper_divs64() instead of going through the > s390_program_interrupt() wrapper. helper_divs64() is for TCG only, so it > should be fine to directly use the tcg_s390_program_interrupt() function > there. Ju

Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations

2017-12-18 Thread Wei Wang
On 12/17/2017 11:16 PM, Tetsuo Handa wrote: Wang, Wei W wrote: Wei Wang wrote: But passing GFP_NOWAIT means that we can handle allocation failure. There is no need to use preload approach when we can handle allocation failure. I think the reason we need xb_preload is because radix tree inserti

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)

2017-12-18 Thread David Hildenbrand
>> Or we could suppress the s390x compiler warning by using a compiler >> pragma. But I don't like that alternative. > > I think the best solution would be to call tcg_s390_program_interrupt() > directly from helper_divs64() instead of going through the > s390_program_interrupt() wrapper. helper_

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)

2017-12-18 Thread Thomas Huth
On 18.12.2017 09:05, David Hildenbrand wrote: > >>> Or we could suppress the s390x compiler warning by using a compiler >>> pragma. But I don't like that alternative. >> >> I think the best solution would be to call tcg_s390_program_interrupt() >> directly from helper_divs64() instead of going thr

Re: [Qemu-devel] [RFC v5 21/26] qmp: isolate responses into io thread

2017-12-18 Thread Stefan Hajnoczi
On Mon, Dec 18, 2017 at 03:32:29PM +0800, Peter Xu wrote: > On Mon, Dec 18, 2017 at 01:52:17PM +0800, Peter Xu wrote: > > On Thu, Dec 14, 2017 at 01:43:59PM +, Stefan Hajnoczi wrote: > > > On Tue, Dec 05, 2017 at 01:51:55PM +0800, Peter Xu wrote: > > > > @@ -4429,6 +4515,13 @@ void monitor_clea

Re: [Qemu-devel] [virtio-dev] Re: [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-18 Thread Longpeng (Mike)
Hi Halil, On 2017/12/11 21:54, Halil Pasic wrote: > > > On 12/11/2017 01:56 PM, Longpeng (Mike) wrote: >> >> >> On 2017/12/6 19:01, Halil Pasic wrote: >> >>> >>> >>> On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: +\field{outcome_len} is the size of struct virtio_crypto_session_input or

[Qemu-devel] [PATCH] io: fix QIONetListener memory leak

2017-12-18 Thread Paolo Bonzini
The sources array does not escape out of qio_net_listener_wait_client, so we have to free it. Reported by Coverity. Cc: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- io/net-listener.c | 1 + 1 file changed, 1 insertion(+) diff --git a/io/net-listener.c b/io/net-listener.c index 77a4e283

Re: [Qemu-devel] [PATCH 0/4] cryptodev: add vhost support

2017-12-18 Thread Gonglei (Arei)
Ping... Fan (working for DPDK parts) is waiting for those patches upstreamed. :) Thanks, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, November 28, 2017 5:03 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com; Huangweidong (C); > stefa...@r

Re: [Qemu-devel] [RFC/RFT PATCH 5/5] vfio/pci: Allow relocating MSI-X MMIO

2017-12-18 Thread Alexey Kardashevskiy
On 18/12/17 16:02, Alex Williamson wrote: > With recently proposed kernel side vfio-pci changes, the MSI-X vector > table area can be mmap'd from userspace, allowing direct access to > non-MSI-X registers within the host page size of this area. However, > we only get that direct access if QEMU isn

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-18 Thread Stefan Hajnoczi
On Mon, Dec 18, 2017 at 01:26:49PM +0800, Peter Xu wrote: > On Sat, Dec 16, 2017 at 09:23:22AM +, Stefan Hajnoczi wrote: > > On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote: > > > On Wed, Dec 13, 2017 at 08:09:38PM +, Stefan Hajnoczi wrote: > > > > On Tue, Dec 05, 2017 at 01:51:50P

Re: [Qemu-devel] [PATCH v1 1/2] qmp.c: (re)implement qmp_cpu

2017-12-18 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Daniel Henrique Barboza (danie...@linux.vnet.ibm.com) wrote: >> >> >> On 12/14/2017 01:21 PM, Markus Armbruster wrote: >> > Eric Blake writes: >> > >> > > On 12/13/2017 12:15 PM, Daniel Henrique Barboza wrote: >> > > > Commit 755f196898 ("qapi: Convert the

[Qemu-devel] [PATCH 2/6] spapr: Treat Hardware Transactional Memory (HTM) as an optional capability

2017-12-18 Thread David Gibson
This adds an spapr capability bit for Hardware Transactional Memory. It is enabled by default for pseries-2.11 and earlier machine types. with POWER8 or later CPUs (as it must be, since earlier qemu versions would implicitly allow it). However it is disabled by default for the latest pseries-2.12

Re: [Qemu-devel] [PATCH v1 1/2] qmp.c: (re)implement qmp_cpu

2017-12-18 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/12/2017 14:56, Markus Armbruster wrote: >> >> Paolo, we have numerous Features/ pages, and I suspect many of them are >> too outdated to serve any purpose but confusing readers. In theory, >> "somebody" could go through them to identify stale ones. In practice, >>

[Qemu-devel] [PATCH 4/6] target/ppc: Clean up probing of VMX, VSX and DFP availability on KVM

2017-12-18 Thread David Gibson
When constructing the "host" cpu class we modify whether the VMX and VSX vector extensions and DFP (Decimal Floating Point) are available based on whether KVM can support those instructions. This can depend on policy in the host kernel as well as on the actual host cpu capabilities. However, the

[Qemu-devel] [PATCH 0/6] spapr: Add optional capabilities

2017-12-18 Thread David Gibson
This series is a first draft to add the notion of optional capabilities to the "pseries" machine type. A default set of capabilities is selected based on the machine type version and selected cpu model, but this can be overridden with machine parameters. The purpose of this is to get rid of a num

[Qemu-devel] [PATCH 6/6] spapr: Handle Decimal Floating Point (DFP) as an optional capability

2017-12-18 Thread David Gibson
Decimal Floating Point has been available on POWER7 and later (server) cpus. However, it can be disabled on the hypervisor, meaning that it's not available to guests. We currently handle this by conditionally advertising DFP support in the device tree depending on whether the guest CPU model supp

[Qemu-devel] [PATCH 5/6] spapr: Handle VMX/VSX presence as an spapr capability flag

2017-12-18 Thread David Gibson
We currently have some conditionals in the spapr device tree code to decide whether or not to advertise the availability of the VMX (aka Altivec) and VSX vector extensions to the guest, based on whether the guest cpu has those features. This can lead to confusion and subtle failures on migration,

[Qemu-devel] [PATCH 3/6] spapr: Validate capabilities on migration

2017-12-18 Thread David Gibson
Now that the "pseries" machine type implements optional capabilities (well, one so far) there's the possibility of having different capabilities available at either end of a migration. Although arguably a user error, it would be nice to catch this situation and fail as gracefully as we can. This

[Qemu-devel] [PATCH 1/6] spapr: Capabilities infrastructure

2017-12-18 Thread David Gibson
Because PAPR is a paravirtual environment access to certain CPU (or other) facilities can be blocked by the hypervisor. PAPR provides ways to advertise in the device tree whether or not those features are available to the guest. In some places we automatically determine whether to make a feature

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-18 Thread seeteena
On 12/15/2017 02:48 PM, Max Reitz wrote: On 2017-12-13 05:50, seeteena wrote: Hi David, While creating snapshots when tag name '0' used in the very first and followed by tag name '1' then snapshot created with tag name '0' is getting erased. A snapshot is identified by a name computed either

Re: [Qemu-devel] [RFC v5 07/26] monitor: unify global init

2017-12-18 Thread Stefan Hajnoczi
On Mon, Dec 18, 2017 at 11:27:02AM +0800, Peter Xu wrote: > On Sat, Dec 16, 2017 at 09:01:12AM +, Stefan Hajnoczi wrote: > > On Sat, Dec 16, 2017 at 11:52:28AM +0800, Peter Xu wrote: > > > On Fri, Dec 15, 2017 at 12:47:11PM +, Stefan Hajnoczi wrote: > > > > On Fri, Dec 15, 2017 at 04:11:41P

Re: [Qemu-devel] [PATCH] io: fix QIONetListener memory leak

2017-12-18 Thread Daniel P. Berrange
On Mon, Dec 18, 2017 at 09:53:08AM +0100, Paolo Bonzini wrote: > The sources array does not escape out of qio_net_listener_wait_client, so > we have to free it. > > Reported by Coverity. > > Cc: Daniel P. Berrange > Signed-off-by: Paolo Bonzini > --- > io/net-listener.c | 1 + > 1 file changed

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-12-18 Thread Liu, Yi L
On Mon, Dec 18, 2017 at 05:14:42PM +1100, David Gibson wrote: > On Thu, Nov 16, 2017 at 04:57:09PM +0800, Liu, Yi L wrote: > > Hi David, > > > > On Tue, Nov 14, 2017 at 11:59:34AM +1100, David Gibson wrote: > > > On Mon, Nov 13, 2017 at 04:28:45PM +0800, Peter Xu wrote: > > > > On Mon, Nov 13, 201

Re: [Qemu-devel] [RFC v5 24/26] docs: update QMP documents for OOB commands

2017-12-18 Thread Peter Xu
On Thu, Dec 14, 2017 at 02:30:19PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:58PM +0800, Peter Xu wrote: > > diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt > > index f04c63fe82..8597fdb087 100644 > > --- a/docs/devel/qapi-code-gen.txt > > +++ b/docs/dev

Re: [Qemu-devel] [PATCH] hw/tpm: remove old i386 dependency

2017-12-18 Thread Marc-André Lureau
Reviewed-by: Marc-André Lureau Le lun. 18 déc. 2017 à 03:01, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Stefan Berger > --- > Based-on: 1513446109-9013-33-git-send-email-stef...@linux.vnet.ibm.com > --- > hw/tpm/tpm_emulator.c| 1 - > hw/tpm/t

Re: [Qemu-devel] [RFC v5 25/26] tests: qmp-test: verify command batching

2017-12-18 Thread Peter Xu
On Thu, Dec 14, 2017 at 02:39:34PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:59PM +0800, Peter Xu wrote: > > OOB introduced DROP event for flow control. This should not affect old > > QMP clients. Add a command batching check to make sure of it. > > > > Signed-off-by: Peter X

Re: [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test

2017-12-18 Thread Peter Xu
On Thu, Dec 14, 2017 at 02:47:12PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:52:00PM +0800, Peter Xu wrote: > > +/* Try a fake capability, it should fail. */ > > +resp = qmp("{ 'execute': 'qmp_capabilities', " > > + " 'arguments': { 'enable': [ 'cap-does-not-

[Qemu-devel] [Bug 1373228] Re: Crash upon adding a USB device in Windows 7 (64-bit)

2017-12-18 Thread Thomas Huth
Fix has been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=7da76e12c ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1373228 Tit

Re: [Qemu-devel] [PATCH RFC 1/1] tests: Add migration test for aarch64

2017-12-18 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 15 December 2017 at 20:37, Wei Huang wrote: > > This patch adds the migration test support for aarch64. The test code, > > which implements the same functionality as x86, is compiled into a binary > > and booted as a kernel to qemu. Here are t

[Qemu-devel] [Bug 1731588] Re: qemu-system-arm black screen and keyboard not detected

2017-12-18 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1731588 Title: qemu-system-arm black screen and keyboard not detected Status in QEMU: Incomplet

Re: [Qemu-devel] [PATCH 1/6] spapr: Capabilities infrastructure

2017-12-18 Thread Greg Kurz
On Mon, 18 Dec 2017 20:20:19 +1100 David Gibson wrote: > Because PAPR is a paravirtual environment access to certain CPU (or other) > facilities can be blocked by the hypervisor. PAPR provides ways to > advertise in the device tree whether or not those features are available to > the guest. > >

[Qemu-devel] [Bug 1587970] Re: QEMU Crashes when attaching USB 3.00 devices to xhci bus

2017-12-18 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1486768] Re: BlackMagic USB3 video capture returns only blank frames in Windows (xHCI issue)

2017-12-18 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1721187] Re: install Centos7 or fedora27 on qemu on windows8.1

2017-12-18 Thread Thomas Huth
So I assume the mouse is working now? I think we then can close this ticket. Concerning the speed: QEMU is emulating the CPU by default, so this is of course slower than running everything natively. You've got to use an accelerator to get more speed - for Windows, you can use HAXM: https://www.q

[Qemu-devel] [Bug 1490853] Re: qemu windows guest hangs on 100% cpu usage

2017-12-18 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-18 Thread Peter Xu
On Mon, Dec 18, 2017 at 09:10:53AM +, Stefan Hajnoczi wrote: > On Mon, Dec 18, 2017 at 01:26:49PM +0800, Peter Xu wrote: > > On Sat, Dec 16, 2017 at 09:23:22AM +, Stefan Hajnoczi wrote: > > > On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote: > > > > On Wed, Dec 13, 2017 at 08:09:38P

[Qemu-devel] [PATCHv2 1/4] tests/pxe-test: Remove unnecessary special case test functions

2017-12-18 Thread David Gibson
All of the x86 and some of the other test cases here use a common test function, test_pxe_ipv4(), but one ppc and one s390 test use different functions. In the s390 case, this is completely pointless, the right parameter to test_pxe_ipv4() will already do exactly the right thing. For the spapr-vl

[Qemu-devel] [PATCHv2 0/4] Improvements to pxe-test

2017-12-18 Thread David Gibson
This series makes several cleanups and enhancements to tests/pxe-test. In particular it improves its handling of different machine types. Changes since v1: * Simplified handling of device model options, at the expense of further changes to the test names * Assorted minor changes based on r

[Qemu-devel] [PATCHv2 2/4] tests/pxe-test: Use table of testcases rather than open-coding

2017-12-18 Thread David Gibson
Currently pxe-tests open codes the list of tests for each architecture. This changes it to use tables of test parameters, somewhat similar to boot-serial-test. This adds the machine type into the table as well, giving us the ability to perform tests on multiple machine types for architectures wher

[Qemu-devel] [PATCHv2 4/4] tests/pxe-test: Add some extra tests

2017-12-18 Thread David Gibson
Previously virtio-net was only tested for ppc64 in "slow" mode. That doesn't make much sense since virtio-net is used much more often in practice than the spapr-vlan device which was tested always. So, move virtio-net to always be tested on ppc64. We had no tests at all for the q35 machine, whic

Re: [Qemu-devel] [PATCH RFC 1/1] tests: Add migration test for aarch64

2017-12-18 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > This patch adds the migration test support for aarch64. The test code, > which implements the same functionality as x86, is compiled into a binary > and booted as a kernel to qemu. Here are the design ideas: > > * We choose this -kernel design because aarch64

[Qemu-devel] [PATCHv2 3/4] tests/pxe-test: Test net booting over IPv6 in some cases

2017-12-18 Thread David Gibson
This adds IPv6 net boot testing (in addition to IPv4) when in slow test mode on ppc64 or s390. IPv6 PXE doesn't seem to work on x86, I'm guessing our BIOS image doesn't support it. Signed-off-by: David Gibson --- tests/pxe-test.c | 26 -- 1 file changed, 20 insertions(+)

Re: [Qemu-devel] Raw notes from a small block layer/QAPI/something pre-christmas meeting

2017-12-18 Thread Markus Armbruster
Max Reitz writes: [...] > == Image creation == > > Image creation and op blockers: > At least for the time being, we probably just want file-posix to open > the new file with O_CREAT | O_RDWR, then claim the appropriate op > blockers (WRITE and RESIZE) and then invoke ftruncate(). > Alter

Re: [Qemu-devel] [PATCH 1/6] spapr: Capabilities infrastructure

2017-12-18 Thread David Gibson
On Mon, Dec 18, 2017 at 10:58:00AM +0100, Greg Kurz wrote: > On Mon, 18 Dec 2017 20:20:19 +1100 > David Gibson wrote: [snip] > > +void spapr_caps_reset(sPAPRMachineState *spapr) > > +{ > > +Error *local_err = NULL; > > +sPAPRCapabilities caps; > > +int i; > > + > > +/* First comput

Re: [Qemu-devel] [RFC v5 21/26] qmp: isolate responses into io thread

2017-12-18 Thread Peter Xu
On Mon, Dec 18, 2017 at 08:40:47AM +, Stefan Hajnoczi wrote: > On Mon, Dec 18, 2017 at 03:32:29PM +0800, Peter Xu wrote: > > On Mon, Dec 18, 2017 at 01:52:17PM +0800, Peter Xu wrote: > > > On Thu, Dec 14, 2017 at 01:43:59PM +, Stefan Hajnoczi wrote: > > > > On Tue, Dec 05, 2017 at 01:51:55P

Re: [Qemu-devel] [RFC v5 07/26] monitor: unify global init

2017-12-18 Thread Peter Xu
On Mon, Dec 18, 2017 at 09:24:57AM +, Stefan Hajnoczi wrote: > On Mon, Dec 18, 2017 at 11:27:02AM +0800, Peter Xu wrote: > > On Sat, Dec 16, 2017 at 09:01:12AM +, Stefan Hajnoczi wrote: > > > On Sat, Dec 16, 2017 at 11:52:28AM +0800, Peter Xu wrote: > > > > On Fri, Dec 15, 2017 at 12:47:11P

[Qemu-devel] [Bug 1486768] Re: BlackMagic USB3 video capture returns only blank frames in Windows (xHCI issue)

2017-12-18 Thread Steinar H. Gunderson
I haven't tried this in a long time, and I already managed to do what I wanted to do (which was to write a free Linux driver :-) ). I guess you can close this; not because I believe it's fixed, but because it's not that important to me anymore. -- You received this bug notification because you ar

[Qemu-devel] [PATCH v2 2/2] blockdev: convert qemu-nbd server to QIONetListener

2017-12-18 Thread Daniel P. Berrange
Instead of creating a QIOChannelSocket directly for the NBD server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. This also means we can honour multiple FDs received during socket activation.

[Qemu-devel] [PATCH v2 0/2] Enable full IPv4/IPv6 dual stack for NBD server

2017-12-18 Thread Daniel P. Berrange
These patches were previously posted as part of a larger series: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html These patches port the NBD server to use QIONetListener, which allows for easy setup of multiple listening sockets. This enables full support for IPv4/IPv6 dual s

[Qemu-devel] [PATCH v2 1/2] blockdev: convert internal NBD server to QIONetListener

2017-12-18 Thread Daniel P. Berrange
Instead of creating a QIOChannelSocket directly for the NBD server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- blockdev-nbd

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-12-18 Thread Laurent Vivier
On 13/12/2017 20:59, Alexander Graf wrote: > > > On 13.12.17 20:29, Laurent Vivier wrote: >> On 13/12/2017 20:19, Alexander Graf wrote: >>> >>> >>> On 02.02.17 06:14, David Gibson wrote: From: Laurent Vivier This is a port to ppc of the i386 commit: 00f4d64 kvmclock: cloc

Re: [Qemu-devel] [PATCH v2] docs: Convert migration.txt to rst

2017-12-18 Thread Peter Xu
On Fri, Dec 15, 2017 at 03:45:07PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Mostly just manual conversion with very minor fixes. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCHv2 2/4] tests/pxe-test: Use table of testcases rather than open-coding

2017-12-18 Thread Thomas Huth
On 18.12.2017 11:04, David Gibson wrote: > Currently pxe-tests open codes the list of tests for each architecture. > This changes it to use tables of test parameters, somewhat similar to > boot-serial-test. > > This adds the machine type into the table as well, giving us the ability > to perform t

Re: [Qemu-devel] [PATCHv2 3/4] tests/pxe-test: Test net booting over IPv6 in some cases

2017-12-18 Thread Thomas Huth
On 18.12.2017 11:04, David Gibson wrote: > This adds IPv6 net boot testing (in addition to IPv4) when in slow test > mode on ppc64 or s390. IPv6 PXE doesn't seem to work on x86, I'm guessing > our BIOS image doesn't support it. > > Signed-off-by: David Gibson > --- > tests/pxe-test.c | 26 +

Re: [Qemu-devel] [PATCHv2 4/4] tests/pxe-test: Add some extra tests

2017-12-18 Thread Thomas Huth
On 18.12.2017 11:04, David Gibson wrote: > Previously virtio-net was only tested for ppc64 in "slow" mode. That > doesn't make much sense since virtio-net is used much more often in > practice than the spapr-vlan device which was tested always. So, move > virtio-net to always be tested on ppc64.

[Qemu-devel] [PATCH v3 0/2] 9pfs: Correctly handle cancelled requests

2017-12-18 Thread Greg Kurz
Hi, As discussed during the v2 review [*], this series changes the transport API so that it is now possible to discard a reply to the guest, and adapts Keno's patch accordingly. [*] https://patchwork.kernel.org/patch/10091517/ -- Greg --- Greg Kurz (1): 9pfs: allow PDU to complete withou

[Qemu-devel] [PATCH v3 2/2] 9pfs: Correctly handle cancelled requests

2017-12-18 Thread Greg Kurz
From: Keno Fischer # Background I was investigating spurious non-deterministic EINTR returns from various 9p file system operations in a Linux guest served from the qemu 9p server. ## EINTR, ERESTARTSYS and the linux kernel When a signal arrives that the Linux kernel needs to deliver to user-

[Qemu-devel] [PATCH v3 1/2] 9pfs: allow PDU to complete without sending a reply

2017-12-18 Thread Greg Kurz
The 9p protocol mostly relies on a request/reply dialog between the client and the server. A notable exception to this rule is request cancellation (ie, flush in 9p wording): the server shouldn't send a reply when the request was flushed. This patch changes the transport API so that the core 9p co

Re: [Qemu-devel] [PATCH] scsi: provide general-purpose functions to manage sense data

2017-12-18 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Extract the common parts of scsi_sense_buf_to_errno, scsi_convert_sense > and scsi_target_send_command's REQUEST SENSE handling into two new > functions scsi_parse_sense_buf and scsi_build_sense_buf. > > Fix a bug in scsi_target_send_command along the

[Qemu-devel] [PATCH v1 1/1] qmp: marking qmp_cpu as deprecated

2017-12-18 Thread Daniel Henrique Barboza
qmp_cpu is a nop that was created a while ago in commit 755f196898 ("qapi: Convert the cpu command") for the sake of compatibility, due to the existence of hmp_cpu. Today, there is no need or requirement to keep it as is. QMP is meant to be as stateless as possible, thus any QMP command that needs

Re: [Qemu-devel] Key code conflict in keycodemapdb

2017-12-18 Thread Daniel P. Berrange
On Fri, Dec 15, 2017 at 10:03:31PM +0200, Miika S wrote: > Ok, I don't know if there is a separate place where to send patches > for keycodemapdb but I will put it in this reply. I will send a new > set of patches for the QEMU changes that were in the first mail > (hopefully in a better format than

Re: [Qemu-devel] [PATCH v1 1/1] qmp: marking qmp_cpu as deprecated

2017-12-18 Thread Daniel P. Berrange
On Mon, Dec 18, 2017 at 08:53:18AM -0200, Daniel Henrique Barboza wrote: > qmp_cpu is a nop that was created a while ago in commit 755f196898 > ("qapi: Convert the cpu command") for the sake of compatibility, > due to the existence of hmp_cpu. > > Today, there is no need or requirement to keep it

[Qemu-devel] [Bug 1486768] Re: BlackMagic USB3 video capture returns only blank frames in Windows (xHCI issue)

2017-12-18 Thread Thomas Huth
OK, thanks for your reply ... so I'm closing this ticket now ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1486768 Title: BlackMagic USB3

[Qemu-devel] [PATCH 5/5] block/parallels: add backing support to readv/writev

2017-12-18 Thread Denis V. Lunev
From: Edgar Kaziakhmedov Since parallels format supports backing files, refine readv/writev (allocate_clusters) to redirect read/write requests to a backing file (if cluster is not available in the current bs). Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Vladimir Sementsov-Ogievskiy Signe

[Qemu-devel] [PATCH 0/5] preparation for Parallels Disk xml driver

2017-12-18 Thread Denis V. Lunev
Parallels Desktop and Parallels Cloud Server uses images glued with the bundle description in XML format. This series contains very basic description of this XML files and makes preparations for actual implementation to be followed. Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Klim Kireev Si

Re: [Qemu-devel] [PATCH 2/6] spapr: Treat Hardware Transactional Memory (HTM) as an optional capability

2017-12-18 Thread Greg Kurz
On Mon, 18 Dec 2017 20:20:20 +1100 David Gibson wrote: > This adds an spapr capability bit for Hardware Transactional Memory. It is > enabled by default for pseries-2.11 and earlier machine types. with POWER8 > or later CPUs (as it must be, since earlier qemu versions would implicitly > allow it

[Qemu-devel] [PATCH 4/5] block/parallels: replace some magic numbers

2017-12-18 Thread Denis V. Lunev
From: Klim Kireev Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- block/parallels.h | 2 ++ block/parallels.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/block/parallels.h b/block/paralle

[Qemu-devel] [PATCH 2/5] configure: add dependency

2017-12-18 Thread Denis V. Lunev
From: Klim Kireev This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. The patch also adds clause to

[Qemu-devel] [PATCH 3/5] block/parallels: move some structures into header

2017-12-18 Thread Denis V. Lunev
From: Klim Kireev To implement xml format, some defines and structures from parallels.c are required. Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- block/parallels.h | 83 +++

[Qemu-devel] [PATCH 1/5] docs/interop/prl-xml: description of Parallels Disk format

2017-12-18 Thread Denis V. Lunev
From: Klim Kireev This patch adds main information about Parallels Disk format, which consists of DiskDescriptor.xml and other files. Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Klim Kireev Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --

Re: [Qemu-devel] [PULL v1 00/32] Merge tpm 2017/12/15

2017-12-18 Thread Thomas Huth
On 17.12.2017 22:34, Peter Maydell wrote: > On 16 December 2017 at 17:41, Stefan Berger > wrote: >> The following patch series refactors the TPM TIS and backend drivers for >> easier addition of new front-end devices. Further, the TPM buffer sizes >> are read from the backend and the backend's bu

Re: [Qemu-devel] [PATCH 3/6] spapr: Validate capabilities on migration

2017-12-18 Thread Greg Kurz
On Mon, 18 Dec 2017 20:20:21 +1100 David Gibson wrote: > Now that the "pseries" machine type implements optional capabilities (well, > one so far) there's the possibility of having different capabilities > available at either end of a migration. Although arguably a user error, > it would be nice

Re: [Qemu-devel] [PATCH 2/2] qemu: add linkspeed and duplex setting to virtio-net

2017-12-18 Thread Yan Vugenfirer
> On 14 Dec 2017, at 21:33, Jason Baron via Qemu-devel > wrote: > > Although they can be currently set in linux via 'ethtool -s', this requires > guest changes, and thus it would be nice to extend this functionality such > that it can be configured automatically from the host (as other network

[Qemu-devel] [Bug 1738767] [NEW] Cannot build QEMU on RHEL6 because of MAP_HUGETLB

2017-12-18 Thread Christophe Lyon
Public bug reported: Hello, I've just downloaded qemu-2.11.0 sources and I wanted to build QEMU on RHEL6 x86_64, for various targets, amonst which arm-linux-user. The build fails because /usr/include/bits/mman.h does not define MAP_HUGETLB. I think it is needed since commit 541e16904. I'm not

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-12-18 Thread David Gibson
On Tue, Nov 14, 2017 at 11:21:59AM +0100, Auger Eric wrote: > Hi Yi L, > > On 03/11/2017 13:01, Liu, Yi L wrote: > > From: Peter Xu > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > > spaces to store arch-specific hooks. > > > > The first hook I would like to introd

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-12-18 Thread David Gibson
On Mon, Dec 18, 2017 at 05:17:35PM +0800, Liu, Yi L wrote: > On Mon, Dec 18, 2017 at 05:14:42PM +1100, David Gibson wrote: > > On Thu, Nov 16, 2017 at 04:57:09PM +0800, Liu, Yi L wrote: > > > Hi David, > > > > > > On Tue, Nov 14, 2017 at 11:59:34AM +1100, David Gibson wrote: > > > > On Mon, Nov 13

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-12-18 Thread David Gibson
On Wed, Nov 15, 2017 at 03:16:32PM +0800, Peter Xu wrote: > On Tue, Nov 14, 2017 at 10:52:54PM +0100, Auger Eric wrote: > > [...] > > > I meant, in the current intel_iommu code, vtd_find_add_as() creates 1 > > IOMMU MR and 1 AS per PCIe device, right? > > I think this is the most tricky point -

[Qemu-devel] [PATCH v2 0/4] tests: Rename pc-cpu-test.c to cpu-plug-test.c

2017-12-18 Thread Thomas Huth
So far the CPU hot-plug qtest was only checking "cpu-add" on x86. With these patches, we now test "device_add" for hot-plugging CPUs on x86, and enable the test on ppc64 and s390x, too. v2: - Rebased to current master, fixed contextual conflicts in tests/Makefile.include - Adjusted the data->

[Qemu-devel] [PATCH v2 1/4] tests: Rename pc-cpu-test.c to cpu-plug-test.c

2017-12-18 Thread Thomas Huth
The test will be extended to work on other architectures, too, so let's use a more generic name for the file and the functions in here first. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth --- tests/Makefile.include | 4 ++-- te

[Qemu-devel] [PATCH v2 2/4] tests/cpu-plug-test: Check the CPU hot-plugging with device_add, too

2017-12-18 Thread Thomas Huth
Using 'device_add' instead of 'cpu-add' is the new way for hot-plugging CPUs, so we should test this regularly, too. Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth --- tests/cpu-plug-test.c | 47 +-- 1 file changed, 45 insertions(+), 2 dele

[Qemu-devel] [PATCH v2 3/4] tests/cpu-plug-test: Check CPU hot-plugging on ppc64, too

2017-12-18 Thread Thomas Huth
Hot plugging on ppc64 is possible via "device_add", too. Unlike x86, we must not specify a 'socket-id' and 'thread-id' here, so this needs to be done with a separate function that just specifies the 'core-id' during the "device_add". Reviewed-by: Daniel Barboza Tested-by: Daniel Barboza Signed-o

Re: [Qemu-devel] [PATCH 4/6] target/ppc: Clean up probing of VMX, VSX and DFP availability on KVM

2017-12-18 Thread Greg Kurz
On Mon, 18 Dec 2017 20:20:22 +1100 David Gibson wrote: > When constructing the "host" cpu class we modify whether the VMX and VSX > vector extensions and DFP (Decimal Floating Point) are available > based on whether KVM can support those instructions. This can depend on > policy in the host kern

[Qemu-devel] [PATCH v2 4/4] tests/cpu-plug-test: Test CPU hot-plugging on s390x

2017-12-18 Thread Thomas Huth
CPU hot-plugging on s390x is possible with both, "cpu-add" and "device_add", so test both. Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/cpu-plug-test.c | 39 +++ 2 files changed, 40 insertions(+) diff --

Re: [Qemu-devel] [PATCH 5/6] spapr: Handle VMX/VSX presence as an spapr capability flag

2017-12-18 Thread Greg Kurz
On Mon, 18 Dec 2017 20:20:23 +1100 David Gibson wrote: > We currently have some conditionals in the spapr device tree code to decide > whether or not to advertise the availability of the VMX (aka Altivec) and > VSX vector extensions to the guest, based on whether the guest cpu has > those feature

Re: [Qemu-devel] [PATCH v2 0/2] Enable full IPv4/IPv6 dual stack for NBD server

2017-12-18 Thread Paolo Bonzini
On 18/12/2017 11:16, Daniel P. Berrange wrote: > These patches were previously posted as part of a larger series: > > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html > > These patches port the NBD server to use QIONetListener, which allows for > easy setup of multiple listen

Re: [Qemu-devel] [PULL v1 00/32] Merge tpm 2017/12/15

2017-12-18 Thread Thomas Huth
On 18.12.2017 12:18, Thomas Huth wrote: > On 17.12.2017 22:34, Peter Maydell wrote: >> On 16 December 2017 at 17:41, Stefan Berger >> wrote: >>> The following patch series refactors the TPM TIS and backend drivers for >>> easier addition of new front-end devices. Further, the TPM buffer sizes >>>

Re: [Qemu-devel] [PATCH 6/6] spapr: Handle Decimal Floating Point (DFP) as an optional capability

2017-12-18 Thread Greg Kurz
On Mon, 18 Dec 2017 20:20:24 +1100 David Gibson wrote: > Decimal Floating Point has been available on POWER7 and later (server) > cpus. However, it can be disabled on the hypervisor, meaning that it's > not available to guests. > > We currently handle this by conditionally advertising DFP suppo

Re: [Qemu-devel] [PATCH v1 1/1] qmp: marking qmp_cpu as deprecated

2017-12-18 Thread Daniel Henrique Barboza
On 12/18/2017 08:59 AM, Daniel P. Berrange wrote: On Mon, Dec 18, 2017 at 08:53:18AM -0200, Daniel Henrique Barboza wrote: qmp_cpu is a nop that was created a while ago in commit 755f196898 ("qapi: Convert the cpu command") for the sake of compatibility, due to the existence of hmp_cpu. Today

[Qemu-devel] [Bug 1738771] [NEW] qemu user does not provide AT_SECURE auxiliary vector entry

2017-12-18 Thread Marco A L Barbosa
Public bug reported: When executing an android native binary using qemu in user mode, the program fail with the message FATAL: kernel did not supply AT_SECURE Android uses bionic libc.The linker requires that AT_SECURE is provided in the auxiliary vector, but qemu does not provide the entry. Th

Re: [Qemu-devel] [PATCH for-2.11 v3 0/2] Check for the availability of a hotplug controller before adding a device

2017-12-18 Thread Thomas Huth
On 02.11.2017 11:10, Thomas Huth wrote: > First patch is a small clean up to the error handling code in > qdev_device_add(), and the second patch adds a proper check for > the availability of a hotplug controller to prevent the possibility > of a crash with device_del. > > The crash can currently

Re: [Qemu-devel] [PATCH v1 1/1] qmp: marking qmp_cpu as deprecated

2017-12-18 Thread Daniel P. Berrange
On Mon, Dec 18, 2017 at 09:55:55AM -0200, Daniel Henrique Barboza wrote: > > > On 12/18/2017 08:59 AM, Daniel P. Berrange wrote: > > On Mon, Dec 18, 2017 at 08:53:18AM -0200, Daniel Henrique Barboza wrote: > > > qmp_cpu is a nop that was created a while ago in commit 755f196898 > > > ("qapi: Conv

[Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm

2017-12-18 Thread Cornelia Huck
Building with --disable-tpm yields ../hw/core/qdev-properties-system.o: In function `set_tpm': /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:274: undefined reference to `qemu_find_tpm_be' /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:278: undefined reference to `tpm_backend_ini

Re: [Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm

2017-12-18 Thread Paolo Bonzini
On 18/12/2017 13:16, Cornelia Huck wrote: > Building with --disable-tpm yields > > ../hw/core/qdev-properties-system.o: In function `set_tpm': > /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:274: undefined > reference to `qemu_find_tpm_be' > /home/cohuck/git/qemu/hw/core/qdev-properties-

Re: [Qemu-devel] [virtio-dev] Re: [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-18 Thread Halil Pasic
On 12/18/2017 09:43 AM, Longpeng (Mike) wrote: > Hi Halil, > > On 2017/12/11 21:54, Halil Pasic wrote: > >> >> >> On 12/11/2017 01:56 PM, Longpeng (Mike) wrote: >>> >>> >>> On 2017/12/6 19:01, Halil Pasic wrote: >>> On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: > +\field{outc

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] hw/ide: Emulate SiI3112 SATA controller

2017-12-18 Thread BALATON Zoltan
On Mon, 18 Dec 2017, David Gibson wrote: On Sat, Dec 16, 2017 at 11:42:39PM +0100, BALATON Zoltan wrote: This is a common generic PCI SATA controller that is also used in PCs but more importantly guests running on the Sam460ex board prefer this card and have a driver for it (unlike for other SAT

Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-18 Thread Peter Maydell
On 18 December 2017 at 07:52, Laurent Vivier wrote: > I think we don't need it anymore as there is no difference betweent > qemu_main() and main(). You need to be a bit cautious there to avoid breaking the OSX code in ui/cocoa.m, which has its own version of main() which kicks off the GUI code an

Re: [Qemu-devel] [PULL v1 00/32] Merge tpm 2017/12/15

2017-12-18 Thread Peter Maydell
On 18 December 2017 at 11:50, Thomas Huth wrote: > On 18.12.2017 12:18, Thomas Huth wrote: >> This apparently broke compilation on non-x86 architectures: >> >> LINKs390x-softmmu/qemu-system-s390x >> ../hw/core/qdev-properties-system.o: In function `release_tpm': >> /home/thuth/devel/qemu/hw/

Re: [Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm

2017-12-18 Thread Cornelia Huck
On Mon, 18 Dec 2017 13:27:09 +0100 Paolo Bonzini wrote: > On 18/12/2017 13:16, Cornelia Huck wrote: > > Building with --disable-tpm yields > > > > ../hw/core/qdev-properties-system.o: In function `set_tpm': > > /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:274: undefined > > reference

Re: [Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm

2017-12-18 Thread Marc-André Lureau
On Mon, Dec 18, 2017 at 1:35 PM, Cornelia Huck wrote: > On Mon, 18 Dec 2017 13:27:09 +0100 > Paolo Bonzini wrote: > >> On 18/12/2017 13:16, Cornelia Huck wrote: >> > Building with --disable-tpm yields >> > >> > ../hw/core/qdev-properties-system.o: In function `set_tpm': >> > /home/cohuck/git/qemu

  1   2   3   4   5   >